[GitHub] [incubator-druid] shuqi7 commented on a change in pull request #7493: No SQL mode in web console

2019-04-18 Thread GitBox
shuqi7 commented on a change in pull request #7493: No SQL mode in web console URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276898822 ## File path: web-console/src/console-application.tsx ## @@ -62,28 +63,34 @@ export class ConsoleApplication

[GitHub] [incubator-druid] shuqi7 commented on a change in pull request #7493: No SQL mode in web console

2019-04-18 Thread GitBox
shuqi7 commented on a change in pull request #7493: No SQL mode in web console URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276898822 ## File path: web-console/src/console-application.tsx ## @@ -62,28 +63,34 @@ export class ConsoleApplication

[GitHub] [incubator-druid] kaka11chen commented on issue #7508: Druid historical node running caused os kernel creating too many kernel's dentry cache slab objects.

2019-04-18 Thread GitBox
kaka11chen commented on issue #7508: Druid historical node running caused os kernel creating too many kernel's dentry cache slab objects. URL: https://github.com/apache/incubator-druid/issues/7508#issuecomment-484757430 The following is a simple test which can reproduce the issue.

[GitHub] [incubator-druid] kaka11chen opened a new pull request #7509: Fix too many dentry cache slab objs#7508.

2019-04-18 Thread GitBox
kaka11chen opened a new pull request #7509: Fix too many dentry cache slab objs#7508. URL: https://github.com/apache/incubator-druid/pull/7509 Fix #7508. This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-druid] kaka11chen opened a new issue #7508: Druid historical node running caused os kernel creating too many kernel's dentry cache slab objects.

2019-04-18 Thread GitBox
kaka11chen opened a new issue #7508: Druid historical node running caused os kernel creating too many kernel's dentry cache slab objects. URL: https://github.com/apache/incubator-druid/issues/7508 Druid historical node running caused os kernel creating too many kernel's dentry cache slab

[GitHub] [incubator-druid] xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-18 Thread GitBox
xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276888990 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint

2019-04-18 Thread GitBox
jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7428#discussion_r276886114 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint

2019-04-18 Thread GitBox
jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7428#discussion_r276886722 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint

2019-04-18 Thread GitBox
jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7428#discussion_r276886299 ## File path:

[GitHub] [incubator-druid] gianm commented on issue #7281: bump calcite version to 1.18.0 in druid-sql

2019-04-18 Thread GitBox
gianm commented on issue #7281: bump calcite version to 1.18.0 in druid-sql URL: https://github.com/apache/incubator-druid/pull/7281#issuecomment-484743988 If it’s not possible (it is fighting against the SQL grain a bit) then I’d also be ok with something that is at least in the spirit of

[GitHub] [incubator-druid] gianm commented on issue #7281: bump calcite version to 1.18.0 in druid-sql

2019-04-18 Thread GitBox
gianm commented on issue #7281: bump calcite version to 1.18.0 in druid-sql URL: https://github.com/apache/incubator-druid/pull/7281#issuecomment-484743556 > It looks Calcite released 1.19.0 recently.. @gianm Do you think which way is make more sense, updating this pr to upgrade Calcite to

[GitHub] [incubator-druid] gianm commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table

2019-04-18 Thread GitBox
gianm commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r276882763 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/MetadataSegmentView.java

[GitHub] [incubator-druid] gianm commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table

2019-04-18 Thread GitBox
gianm commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r276882146 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/MetadataSegmentView.java

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

2019-04-18 Thread GitBox
jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r276880208 ## File path: dev/code-review/concurrency.md ## @@ -0,0 +1,178 @@ +## Druid's Checklist for Concurrency Code +

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

2019-04-18 Thread GitBox
jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r276880835 ## File path: dev/code-review/concurrency.md ## @@ -0,0 +1,178 @@ +## Druid's Checklist for Concurrency Code +

[GitHub] [incubator-druid] gianm commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table

2019-04-18 Thread GitBox
gianm commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r276876625 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/MetadataSegmentView.java

[GitHub] [incubator-druid] gianm commented on issue #7093: [PROPOSAL] Query vectorization

2019-04-18 Thread GitBox
gianm commented on issue #7093: [PROPOSAL] Query vectorization URL: https://github.com/apache/incubator-druid/issues/7093#issuecomment-484737473 Thanks for taking a look @fjy. I would prefer to leave vectorization off by default for the first couple of releases at least, since the

[GitHub] [incubator-druid] leerho commented on issue #7187: Improve topN algorithm

2019-04-18 Thread GitBox
leerho commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-484736772 @peferron The new FDT sketch is in master and should be stable enough for you to start looking at it and playing with it. I'm sure you will have

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7490: Add reload by interval API

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7490: Add reload by interval API URL: https://github.com/apache/incubator-druid/pull/7490#discussion_r276849086 ## File path: docs/content/operations/api-reference.md ## @@ -230,6 +230,19 @@ Enables all segments of

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7490: Add reload by interval API

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7490: Add reload by interval API URL: https://github.com/apache/incubator-druid/pull/7490#discussion_r276856491 ## File path: server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java ## @@ -700,4

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7490: Add reload by interval API

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7490: Add reload by interval API URL: https://github.com/apache/incubator-druid/pull/7490#discussion_r276878309 ## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java ## @@ -219,82

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7490: Add reload by interval API

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7490: Add reload by interval API URL: https://github.com/apache/incubator-druid/pull/7490#discussion_r276847961 ## File path: docs/content/operations/api-reference.md ## @@ -230,6 +230,19 @@ Enables all segments of

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7490: Add reload by interval API

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7490: Add reload by interval API URL: https://github.com/apache/incubator-druid/pull/7490#discussion_r276861172 ## File path: server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java ## @@ -700,4

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7490: Add reload by interval API

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7490: Add reload by interval API URL: https://github.com/apache/incubator-druid/pull/7490#discussion_r276848515 ## File path: docs/content/operations/api-reference.md ## @@ -230,6 +230,19 @@ Enables all segments of

[GitHub] [incubator-druid] fjy commented on issue #7093: [PROPOSAL] Query vectorization

2019-04-18 Thread GitBox
fjy commented on issue #7093: [PROPOSAL] Query vectorization URL: https://github.com/apache/incubator-druid/issues/7093#issuecomment-484734125 I finally found some time to read and review the proposal. I think the overall approach makes a lot of sense, and generally agree with the stages.

[GitHub] [incubator-druid] gianm commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table

2019-04-18 Thread GitBox
gianm commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r276876394 ## File path: core/src/main/java/org/apache/druid/timeline/SegmentWithOvershadowedStatus.java

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7507: Fixed filter for status in task table

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7507: Fixed filter for status in task table URL: https://github.com/apache/incubator-druid/pull/7507#discussion_r276876045 ## File path: web-console/src/utils/general.tsx ## @@ -66,28 +66,48 @@ export function

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7507: Fixed filter for status in task table

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7507: Fixed filter for status in task table URL: https://github.com/apache/incubator-druid/pull/7507#discussion_r276875975 ## File path: web-console/src/utils/general.tsx ## @@ -66,28 +66,48 @@ export function

[GitHub] [incubator-druid] xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-18 Thread GitBox
xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276874963 ## File path: core/src/main/java/org/apache/druid/java/util/common/ByteBufferUtils.java ## @@

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7493: No SQL mode in web console

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7493: No SQL mode in web console URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276868993 ## File path: web-console/src/views/home-view.tsx ## @@ -160,33 +187,31 @@ export class HomeView extends

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7493: No SQL mode in web console

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7493: No SQL mode in web console URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276870759 ## File path: web-console/src/console-application.tsx ## @@ -62,28 +63,34 @@ export class ConsoleApplication

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7493: No SQL mode in web console

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7493: No SQL mode in web console URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276869238 ## File path: web-console/src/views/home-view.tsx ## @@ -212,8 +237,21 @@ GROUP BY 1`);

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7493: No SQL mode in web console

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7493: No SQL mode in web console URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276868547 ## File path: web-console/src/views/home-view.tsx ## @@ -160,33 +187,31 @@ export class HomeView extends

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7493: No SQL mode in web console

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7493: No SQL mode in web console URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276869514 ## File path: web-console/src/views/home-view.tsx ## @@ -160,33 +187,31 @@ export class HomeView extends

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7493: No SQL mode in web console

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7493: No SQL mode in web console URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276870238 ## File path: web-console/src/console-application.tsx ## @@ -62,28 +63,34 @@ export class ConsoleApplication

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7493: No SQL mode in web console

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7493: No SQL mode in web console URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276869715 ## File path: web-console/src/views/segments-view.tsx ## @@ -42,27 +42,47 @@ import './segments-view.scss';

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7493: No SQL mode in web console

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7493: No SQL mode in web console URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276869852 ## File path: web-console/src/views/servers-view.tsx ## @@ -100,14 +124,40 @@ export class ServersView

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7507: Fixed filter for status in task table

2019-04-18 Thread GitBox
vogievetsky commented on a change in pull request #7507: Fixed filter for status in task table URL: https://github.com/apache/incubator-druid/pull/7507#discussion_r276864728 ## File path: web-console/src/utils/general.tsx ## @@ -66,13 +66,11 @@ export function

[GitHub] [incubator-druid] vogievetsky commented on issue #7506: New Router UI: No way to enable/disable datasources. confusing 'drop data' option.

2019-04-18 Thread GitBox
vogievetsky commented on issue #7506: New Router UI: No way to enable/disable datasources. confusing 'drop data' option. URL: https://github.com/apache/incubator-druid/issues/7506#issuecomment-484701601 `Drop data` = disable

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint

2019-04-18 Thread GitBox
jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7428#discussion_r276817653 ## File path:

[incubator-druid] branch master updated: Fix result-level cache for queries (#7325)

2019-04-18 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new c2a42e0 Fix result-level cache for

[GitHub] [incubator-druid] gianm merged pull request #7325: Fix result-level cache for queries

2019-04-18 Thread GitBox
gianm merged pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid] justinborromeo edited a comment on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks

2019-04-18 Thread GitBox
justinborromeo edited a comment on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks URL: https://github.com/apache/incubator-druid/issues/7238#issuecomment-484273106 After taking a first crack at this, I've realized that publishing segments once the number

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint

2019-04-18 Thread GitBox
jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7428#discussion_r276817653 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint

2019-04-18 Thread GitBox
jon-wei commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7428#discussion_r276817653 ## File path:

[GitHub] [incubator-druid] vogievetsky commented on issue #7507: Fixed filter for status in task table

2019-04-18 Thread GitBox
vogievetsky commented on issue #7507: Fixed filter for status in task table URL: https://github.com/apache/incubator-druid/pull/7507#issuecomment-484662611 Wow, this is like when two cars merge into the same lane at the same time from right and left

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table

2019-04-18 Thread GitBox
jon-wei commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r276808390 ## File path: core/src/main/java/org/apache/druid/timeline/SegmentWithOvershadowedStatus.java

[GitHub] [incubator-druid] jihoonson commented on issue #7501: Compact doesn't go more far than P1M back in history?

2019-04-18 Thread GitBox
jihoonson commented on issue #7501: Compact doesn't go more far than P1M back in history? URL: https://github.com/apache/incubator-druid/issues/7501#issuecomment-484653675 > Oh, I though maxNumSegmentsToCompact was a count of segments to take for 1 pass... Hmm I think it's true.

[GitHub] [incubator-druid] samarthjain commented on issue #7088: Improve parallelism of zookeeper based segment change processing

2019-04-18 Thread GitBox
samarthjain commented on issue #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#issuecomment-484652276 @leventov - looks like the build couldn't complete because the system was in the midst of shutting down.

[GitHub] [incubator-druid] shuqi7 opened a new pull request #7507: Fixed filter for status in task table

2019-04-18 Thread GitBox
shuqi7 opened a new pull request #7507: Fixed filter for status in task table URL: https://github.com/apache/incubator-druid/pull/7507 - PRs https://github.com/apache/incubator-druid/pull/7448 and https://github.com/apache/incubator-druid/pull/7460 caused a regression bug, in which the

[GitHub] [incubator-druid] gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-18 Thread GitBox
gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276791235 ## File path:

[GitHub] [incubator-druid] gianm merged pull request #7496: refactor druid-bloom-filter aggregators

2019-04-18 Thread GitBox
gianm merged pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-druid] branch master updated: refactor druid-bloom-filter aggregators (#7496)

2019-04-18 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new be65cca refactor druid-bloom-filter

[GitHub] [incubator-druid] dene14 commented on issue #7501: Compact doesn't go more far than P1M back in history?

2019-04-18 Thread GitBox
dene14 commented on issue #7501: Compact doesn't go more far than P1M back in history? URL: https://github.com/apache/incubator-druid/issues/7501#issuecomment-484627601 Oh, I though maxNumSegmentsToCompact was a count of segments to take for 1 pass... actually I even tried to increase

[GitHub] [incubator-druid] gianm commented on issue #7506: New Router UI: No way to enable/disable datasources. confusing 'drop data' option.

2019-04-18 Thread GitBox
gianm commented on issue #7506: New Router UI: No way to enable/disable datasources. confusing 'drop data' option. URL: https://github.com/apache/incubator-druid/issues/7506#issuecomment-484625465 It's equivalent to the old 'disable' functionality (mark all segments unused). We're trying

[GitHub] [incubator-druid] pdeva opened a new issue #7506: New Router UI: No way to enable/disable datasources. confusing 'drop data' option.

2019-04-18 Thread GitBox
pdeva opened a new issue #7506: New Router UI: No way to enable/disable datasources. confusing 'drop data' option. URL: https://github.com/apache/incubator-druid/issues/7506 ### Affected Version 0.14.0-iap3 ### Description as title says. I see an option to

[GitHub] [incubator-druid] jihoonson commented on issue #7501: Compact doesn't go more far than P1M back in history?

2019-04-18 Thread GitBox
jihoonson commented on issue #7501: Compact doesn't go more far than P1M back in history? URL: https://github.com/apache/incubator-druid/issues/7501#issuecomment-484620152 Ah, currently auto compaction can compact if total segment size and # of segments in a timeChunk are smaller than

[GitHub] [incubator-druid] dene14 commented on issue #7501: Compact doesn't go more far than P1M back in history?

2019-04-18 Thread GitBox
dene14 commented on issue #7501: Compact doesn't go more far than P1M back in history? URL: https://github.com/apache/incubator-druid/issues/7501#issuecomment-484614850 What is this value? Could be... These datasources were very weird... like 7 segments for 2 month, sometimes up

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276470247 ## File path: processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276761225 ## File path:

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276469967 ## File path: processing/src/main/java/org/apache/druid/query/timeseries/TimeseriesQueryQueryToolChest.java

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276469114 ## File path: server/src/main/java/org/apache/druid/client/CachingClusteredClient.java ## @@

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276469546 ## File path: processing/src/main/java/org/apache/druid/query/topn/TopNQueryQueryToolChest.java ##

[GitHub] [incubator-druid] leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-18 Thread GitBox
leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276742914 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-18 Thread GitBox
leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276742058 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-18 Thread GitBox
leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276738983 ## File path: core/src/main/java/org/apache/druid/java/util/common/ByteBufferUtils.java ##

[GitHub] [incubator-druid] leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-18 Thread GitBox
leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276740682 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-18 Thread GitBox
leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276740168 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-18 Thread GitBox
leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276741474 ## File path: core/src/main/java/org/apache/druid/java/util/common/UnsafeUtil.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table

2019-04-18 Thread GitBox
leventov commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r276737444 ## File path: core/src/main/java/org/apache/druid/timeline/SegmentWithOvershadowedStatus.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table

2019-04-18 Thread GitBox
leventov commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r276737444 ## File path: core/src/main/java/org/apache/druid/timeline/SegmentWithOvershadowedStatus.java

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-18 Thread GitBox
clintropolis commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276734508 ## File path:

[GitHub] [incubator-druid] RestfulBlue closed issue #7505: Auto compaction tasks leaks disk space in case of failure

2019-04-18 Thread GitBox
RestfulBlue closed issue #7505: Auto compaction tasks leaks disk space in case of failure URL: https://github.com/apache/incubator-druid/issues/7505 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-druid] RestfulBlue commented on issue #7505: Auto compaction tasks leaks disk space in case of failure

2019-04-18 Thread GitBox
RestfulBlue commented on issue #7505: Auto compaction tasks leaks disk space in case of failure URL: https://github.com/apache/incubator-druid/issues/7505#issuecomment-484571016 Hi, thanks for response! in our configuration we was settings baseTaskDir and not baseDir. And it looks like

[GitHub] [incubator-druid] gianm commented on issue #7496: refactor druid-bloom-filter aggregators

2019-04-18 Thread GitBox
gianm commented on issue #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#issuecomment-484570688 Tagged 0.15 since it is a bug. This is an automated message from the

[GitHub] [incubator-druid] gianm commented on issue #7496: refactor druid-bloom-filter aggregators

2019-04-18 Thread GitBox
gianm commented on issue #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#issuecomment-484565316 @clintropolis checkstyle has some words for you: ``` [ERROR]

[GitHub] [incubator-druid] gianm commented on issue #6909: Remove CardinalityAggregatorColumnSelectorStrategy and CardinalityAggregatorColumnSelectorStrategyFactory as too shallow abstractions.

2019-04-18 Thread GitBox
gianm commented on issue #6909: Remove CardinalityAggregatorColumnSelectorStrategy and CardinalityAggregatorColumnSelectorStrategyFactory as too shallow abstractions. URL: https://github.com/apache/incubator-druid/issues/6909#issuecomment-484564986 I accidentally stumbled into this by

[GitHub] [incubator-druid] gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-18 Thread GitBox
gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276719274 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-18 Thread GitBox
gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276715440 ## File path:

[GitHub] [incubator-druid] gianm commented on issue #7505: Auto compaction tasks leaks disk space in case of failure

2019-04-18 Thread GitBox
gianm commented on issue #7505: Auto compaction tasks leaks disk space in case of failure URL: https://github.com/apache/incubator-druid/issues/7505#issuecomment-484557153 Hmm, it seems like a bug in the indexing task. Each task has a working directory that it's supposed to use for

[GitHub] [incubator-druid] gianm commented on issue #7501: Compact doesn't go more far than P1M back in history?

2019-04-18 Thread GitBox
gianm commented on issue #7501: Compact doesn't go more far than P1M back in history? URL: https://github.com/apache/incubator-druid/issues/7501#issuecomment-484541700 Is it possible they're outside the limit of segments per time chunk?

[GitHub] [incubator-druid] RestfulBlue opened a new issue #7505: Auto compaction tasks leaks disk space in case of failure

2019-04-18 Thread GitBox
RestfulBlue opened a new issue #7505: Auto compaction tasks leaks disk space in case of failure URL: https://github.com/apache/incubator-druid/issues/7505 Hi, recently we was trying to use auto compaction, but found some strange behavior of temporary data location. At first we make a

[GitHub] [incubator-druid] vogievetsky commented on issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data ye

2019-04-18 Thread GitBox
vogievetsky commented on issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data yet URL: https://github.com/apache/incubator-druid/issues/7498#issuecomment-484537927 Client-side workaround coming

[GitHub] [incubator-druid] dene14 commented on issue #7501: Compact doesn't go more far than P1M back in history?

2019-04-18 Thread GitBox
dene14 commented on issue #7501: Compact doesn't go more far than P1M back in history? URL: https://github.com/apache/incubator-druid/issues/7501#issuecomment-484411741 No, no task submission at all. This is an automated

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-18 Thread GitBox
clintropolis commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276536440 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-18 Thread GitBox
clintropolis commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276536313 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-18 Thread GitBox
clintropolis commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276535379 ## File path:

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table

2019-04-18 Thread GitBox
surekhasaharan commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r276529355 ## File path: core/src/main/java/org/apache/druid/timeline/SegmentWithOvershadowedStatus.java

[GitHub] [incubator-druid] clintropolis merged pull request #7462: Capitalize keywords in SQL auto complete

2019-04-18 Thread GitBox
clintropolis merged pull request #7462: Capitalize keywords in SQL auto complete URL: https://github.com/apache/incubator-druid/pull/7462 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated: Capitalize keywords in SQL auto complete (#7462)

2019-04-18 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 99ddce1 Capitalize keywords in SQL

[incubator-druid] branch master updated: Add created_time as tie breaker when sorting by status in task table (#7460)

2019-04-18 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new f06f0c3 Add created_time as tie

[incubator-druid] branch master updated: Add exact match filtering to console table (#7448)

2019-04-18 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new c8bffd9 Add exact match filtering to

[GitHub] [incubator-druid] clintropolis closed issue #7155: web console segments view unable to search by exact datasource

2019-04-18 Thread GitBox
clintropolis closed issue #7155: web console segments view unable to search by exact datasource URL: https://github.com/apache/incubator-druid/issues/7155 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-druid] clintropolis merged pull request #7448: Add exact match filtering to console table

2019-04-18 Thread GitBox
clintropolis merged pull request #7448: Add exact match filtering to console table URL: https://github.com/apache/incubator-druid/pull/7448 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] vogievetsky commented on issue #7405: Add Druid SQL support to JetBrains DataGrip

2019-04-18 Thread GitBox
vogievetsky commented on issue #7405: Add Druid SQL support to JetBrains DataGrip URL: https://github.com/apache/incubator-druid/issues/7405#issuecomment-484367637 I have had success using Druid from DataGrip via the JDBC connector. Have you tried that?

[GitHub] [incubator-druid] jihoonson commented on issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data yet

2019-04-18 Thread GitBox
jihoonson commented on issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data yet URL: https://github.com/apache/incubator-druid/issues/7498#issuecomment-484367385 I added the milestone before I

[GitHub] [incubator-druid] vogievetsky commented on issue #7431: Is there a way ingest a datasource base on a query result

2019-04-18 Thread GitBox
vogievetsky commented on issue #7431: Is there a way ingest a datasource base on a query result URL: https://github.com/apache/incubator-druid/issues/7431#issuecomment-484367292 Yes there is. Check out http://druid.io/docs/latest/ingestion/firehose.html#Ingestsegmentfirehose We are