[GitHub] [incubator-druid] clintropolis closed issue #7790: Repeatedly parsing expression in ExpressionPostAggregator wastes a lot of CPU time and potentially hits performance

2019-05-31 Thread GitBox
clintropolis closed issue #7790: Repeatedly parsing expression in ExpressionPostAggregator wastes a lot of CPU time and potentially hits performance URL: https://github.com/apache/incubator-druid/issues/7790 This is an

[incubator-druid] branch master updated: Fix repeated expr parsing in ExpressionPostAggregation (#7791)

2019-05-31 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 55af692 Fix repeated expr parsing in

[GitHub] [incubator-druid] clintropolis merged pull request #7791: Fix repeated expr parsing in ExpressionPostAggregation

2019-05-31 Thread GitBox
clintropolis merged pull request #7791: Fix repeated expr parsing in ExpressionPostAggregation URL: https://github.com/apache/incubator-druid/pull/7791 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-druid] fjy merged pull request #7808: Enable SQL by default

2019-05-31 Thread GitBox
fjy merged pull request #7808: Enable SQL by default URL: https://github.com/apache/incubator-druid/pull/7808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-druid] branch master updated: Enables SQL by default. (#7808)

2019-05-31 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 69e9b8a Enables SQL by default. (#7808)

[GitHub] [incubator-druid] fjy closed issue #7793: Enable SQL by default

2019-05-31 Thread GitBox
fjy closed issue #7793: Enable SQL by default URL: https://github.com/apache/incubator-druid/issues/7793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-31 Thread GitBox
jon-wei commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r289587119 ## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java ##

[GitHub] [incubator-druid] stale[bot] commented on issue #6633: make bitmap index usage optional for bloom filters

2019-05-31 Thread GitBox
stale[bot] commented on issue #6633: make bitmap index usage optional for bloom filters URL: https://github.com/apache/incubator-druid/pull/6633#issuecomment-497901234 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further

[GitHub] [incubator-druid] xueyumusic commented on issue #7801: Support var_pop, var_samp, stddev_pop and stddev_samp etc in sql

2019-05-31 Thread GitBox
xueyumusic commented on issue #7801: Support var_pop, var_samp, stddev_pop and stddev_samp etc in sql URL: https://github.com/apache/incubator-druid/pull/7801#issuecomment-497900897 Hi, @clintropolis , thanks for suggestion. I updated the codes and rebased on master.

[GitHub] [incubator-druid] clintropolis closed issue #7217: [PROPOSAL] API Endpoint for Supervisor Errors

2019-05-31 Thread GitBox
clintropolis closed issue #7217: [PROPOSAL] API Endpoint for Supervisor Errors URL: https://github.com/apache/incubator-druid/issues/7217 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-druid] clintropolis merged pull request #7428: Add errors and state to stream supervisor status API endpoint

2019-05-31 Thread GitBox
clintropolis merged pull request #7428: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7428 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289571746 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -241,6

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289570269 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289569607 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -330,10

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289569487 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -252,12

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289566371 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -241,6

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289566106 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -205,6

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289564922 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -118,11

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289564340 ## File path: core/src/main/java/org/apache/druid/math/expr/Parser.java ## @@ -141,13

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289564340 ## File path: core/src/main/java/org/apache/druid/math/expr/Parser.java ## @@ -141,13

[GitHub] [incubator-druid] Fokko opened a new pull request #7811: Remove explicit snappy-java

2019-05-31 Thread GitBox
Fokko opened a new pull request #7811: Remove explicit snappy-java URL: https://github.com/apache/incubator-druid/pull/7811 I would remove the `snappy-java` dependency from the Parquet project. This dependency is only required if you're using snappy compression, which is just one of the

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289557083 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -118,11

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289555721 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289555721 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@

[incubator-druid] branch master updated: Bump Joda time to 2.10.2 (#7809)

2019-05-31 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new c8e1511 Bump Joda time to 2.10.2

[GitHub] [incubator-druid] gianm merged pull request #7809: Bump Joda time to 2.10.2

2019-05-31 Thread GitBox
gianm merged pull request #7809: Bump Joda time to 2.10.2 URL: https://github.com/apache/incubator-druid/pull/7809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289555300 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@

[GitHub] [incubator-druid] gianm commented on issue #7810: Remove Apache Pig from the tests

2019-05-31 Thread GitBox
gianm commented on issue #7810: Remove Apache Pig from the tests URL: https://github.com/apache/incubator-druid/pull/7810#issuecomment-497864807 Hmm, ordinarily I would suggest to keep the flag in, and instead remove the Pig test dependency and test it some other way. But Pig looks like it

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint

2019-05-31 Thread GitBox
clintropolis commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7428#discussion_r289551878 ## File path: docs/content/development/extensions-core/kinesis-ingestion.md

[GitHub] [incubator-druid] Fokko commented on issue #7809: Bump Joda time to 2.10.2

2019-05-31 Thread GitBox
Fokko commented on issue #7809: Bump Joda time to 2.10.2 URL: https://github.com/apache/incubator-druid/pull/7809#issuecomment-497859723 Joda has been superseded by JSR310: https://community.oracle.com/docs/DOC-983209 Even the author of Joda [recommends

[GitHub] [incubator-druid] drcrallen commented on issue #7809: Bump Joda time to 2.10.2

2019-05-31 Thread GitBox
drcrallen commented on issue #7809: Bump Joda time to 2.10.2 URL: https://github.com/apache/incubator-druid/pull/7809#issuecomment-497858706 Why remove Joda time? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] Fokko opened a new pull request #7810: Remove Apache Pig from the tests

2019-05-31 Thread GitBox
Fokko opened a new pull request #7810: Remove Apache Pig from the tests URL: https://github.com/apache/incubator-druid/pull/7810 I strongly feel we should remove Pig from the tests since it is blocking https://github.com/apache/incubator-druid/pull/7772 Currently, we write the Avro

[GitHub] [incubator-druid] himanshug commented on issue #7736: Druid keep using segment from the segment-cache the one not exists on deep storage anymore

2019-05-31 Thread GitBox
himanshug commented on issue #7736: Druid keep using segment from the segment-cache the one not exists on deep storage anymore URL: https://github.com/apache/incubator-druid/issues/7736#issuecomment-497840108 > If you try to reproduce the case above you will see that. At least I hope for

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289517157 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -348,16

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289507079 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -118,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288732868 ## File path: core/src/main/java/org/apache/druid/math/expr/ExprEval.java ## @@ -87,9

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289508279 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -178,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288263123 ## File path:

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288739565 ## File path: core/src/main/java/org/apache/druid/math/expr/Parser.java ## @@ -141,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288731396 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -213,7

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288719530 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@ -23,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289509283 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -205,6

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288730317 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@ -23,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289513984 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -241,6

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289525216 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -1453,4

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288725691 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -148,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288723606 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -118,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288720307 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@ -23,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289516752 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -330,10

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288723761 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -118,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288731915 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -241,6

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289516306 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -252,12

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288725888 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -178,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288263051 ## File path:

[GitHub] [incubator-druid] Fokko opened a new pull request #7809: Bump Joda time to 2.10.2

2019-05-31 Thread GitBox
Fokko opened a new pull request #7809: Bump Joda time to 2.10.2 URL: https://github.com/apache/incubator-druid/pull/7809 I'm looking into removing Joda time, but this will be a big PR. First, we need to bump Avro to 1.9.0 to remove that Joda dependency.

[GitHub] [incubator-druid] yurmix opened a new pull request #7808: Enables SQL by default.

2019-05-31 Thread GitBox
yurmix opened a new pull request #7808: Enables SQL by default. URL: https://github.com/apache/incubator-druid/pull/7808 Fixes #7793 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-druid] leventov commented on a change in pull request #7789: Druid basic authentication class composition config

2019-05-31 Thread GitBox
leventov commented on a change in pull request #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789#discussion_r289477254 ## File path:

[GitHub] [incubator-druid] gianm commented on issue #7807: Fix - correcting conversion issue on sequence start number when doing…

2019-05-31 Thread GitBox
gianm commented on issue #7807: Fix - correcting conversion issue on sequence start number when doing… URL: https://github.com/apache/incubator-druid/pull/7807#issuecomment-497786972 @acdn-mpreston, could you please raise this patch against `master` instead of `0.14.0-incubating`?

[GitHub] [incubator-druid] acdn-mpreston opened a new pull request #7807: Fix - correcting conversion issue on sequence start number when doing…

2019-05-31 Thread GitBox
acdn-mpreston opened a new pull request #7807: Fix - correcting conversion issue on sequence start number when doing… URL: https://github.com/apache/incubator-druid/pull/7807 … internal reset. This is very similar to the issue described here:

[GitHub] [incubator-druid] teeram opened a new issue #7806: Kafka index tasks failing after upgrade to 0.14.1-incubating

2019-05-31 Thread GitBox
teeram opened a new issue #7806: Kafka index tasks failing after upgrade to 0.14.1-incubating URL: https://github.com/apache/incubator-druid/issues/7806 ### Affected Version 0.14.1-incubating ### Description I recently performed an upgrade on my Druid cluster from

[GitHub] [incubator-druid] sashidhar commented on issue #7798: Use smile format instead of json for internal Druid process communication.

2019-05-31 Thread GitBox
sashidhar commented on issue #7798: Use smile format instead of json for internal Druid process communication. URL: https://github.com/apache/incubator-druid/issues/7798#issuecomment-497701769 Just curious what is the rationale behind choosing Smile amongst myriads of binary encoding

[incubator-druid] branch master updated: friendly printed arrays for json responses (#7805)

2019-05-31 Thread asdf2014
This is an automated email from the ASF dual-hosted git repository. asdf2014 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 94b3591 friendly printed arrays for

[GitHub] [incubator-druid] asdf2014 merged pull request #7805: friendly printed arrays for json responses

2019-05-31 Thread GitBox
asdf2014 merged pull request #7805: friendly printed arrays for json responses URL: https://github.com/apache/incubator-druid/pull/7805 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-druid] vogievetsky commented on issue #7805: friendly printed arrays for json responses

2019-05-31 Thread GitBox
vogievetsky commented on issue #7805: friendly printed arrays for json responses URL: https://github.com/apache/incubator-druid/pull/7805#issuecomment-497587100 LGTM after travis, solid `if` game.  This is an automated

[GitHub] [incubator-druid] clintropolis opened a new pull request #7805: friendly printed arrays for json responses

2019-05-31 Thread GitBox
clintropolis opened a new pull request #7805: friendly printed arrays for json responses URL: https://github.com/apache/incubator-druid/pull/7805 before: https://user-images.githubusercontent.com/1577461/58684883-a581eb00-832e-11e9-9e02-c819c27bd120.png;> after: