[GitHub] [incubator-druid] stale[bot] commented on issue #7676: Add OakIncrementalIndex to Druid

2019-11-21 Thread GitBox
stale[bot] commented on issue #7676: Add OakIncrementalIndex to Druid URL: https://github.com/apache/incubator-druid/pull/7676#issuecomment-557429931 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you

[GitHub] [incubator-druid] stale[bot] closed pull request #7676: Add OakIncrementalIndex to Druid

2019-11-21 Thread GitBox
stale[bot] closed pull request #7676: Add OakIncrementalIndex to Druid URL: https://github.com/apache/incubator-druid/pull/7676 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-druid] leventov opened a new issue #8926: Document how to run micro-quickstart or nano-quickstart in a docker container

2019-11-21 Thread GitBox
leventov opened a new issue #8926: Document how to run micro-quickstart or nano-quickstart in a docker container URL: https://github.com/apache/incubator-druid/issues/8926 This [doc

[GitHub] [incubator-druid] leventov commented on issue #8920: Failed to build docker image: npm ci failed

2019-11-21 Thread GitBox
leventov commented on issue #8920: Failed to build docker image: npm ci failed URL: https://github.com/apache/incubator-druid/issues/8920#issuecomment-557425420 It would also allow faster turnaround because re-build an image after some changes may be faster than always doing a clean build

[GitHub] [incubator-druid] aditya-r-m commented on issue #8679: Feature request to support GREATEST/LEAST function in Druid sql

2019-11-21 Thread GitBox
aditya-r-m commented on issue #8679: Feature request to support GREATEST/LEAST function in Druid sql URL: https://github.com/apache/incubator-druid/issues/8679#issuecomment-557406104 @gianm can we merge this? This is an

[GitHub] [incubator-druid] suneet-amp commented on a change in pull request #8915: add TsvInputFormat

2019-11-21 Thread GitBox
suneet-amp commented on a change in pull request #8915: add TsvInputFormat URL: https://github.com/apache/incubator-druid/pull/8915#discussion_r349440447 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SeparateValueInputFormat.java ## @@ -0,0 +1,204 @@

[GitHub] [incubator-druid] jihoonson commented on issue #8923: RetryingInputEntity to retry on transient errors

2019-11-21 Thread GitBox
jihoonson commented on issue #8923: RetryingInputEntity to retry on transient errors URL: https://github.com/apache/incubator-druid/pull/8923#issuecomment-557396049 @clintropolis @jon-wei thanks for the review! This is an

[incubator-druid] branch master updated (dc6178d -> 934547a)

2019-11-21 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from dc6178d Upgrade Calcite to 1.21 (#8566) add 934547a RetryingInputEntity to retry on transient

[GitHub] [incubator-druid] jihoonson merged pull request #8923: RetryingInputEntity to retry on transient errors

2019-11-21 Thread GitBox
jihoonson merged pull request #8923: RetryingInputEntity to retry on transient errors URL: https://github.com/apache/incubator-druid/pull/8923 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8915: add TsvInputFormat

2019-11-21 Thread GitBox
jon-wei commented on a change in pull request #8915: add TsvInputFormat URL: https://github.com/apache/incubator-druid/pull/8915#discussion_r349428651 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SeparateValueInputFormat.java ## @@ -0,0 +1,204 @@ +/*

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8915: add TsvInputFormat

2019-11-21 Thread GitBox
jon-wei commented on a change in pull request #8915: add TsvInputFormat URL: https://github.com/apache/incubator-druid/pull/8915#discussion_r349428651 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SeparateValueInputFormat.java ## @@ -0,0 +1,204 @@ +/*

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8923: RetryingInputEntity to retry on transient errors

2019-11-21 Thread GitBox
jon-wei commented on a change in pull request #8923: RetryingInputEntity to retry on transient errors URL: https://github.com/apache/incubator-druid/pull/8923#discussion_r349417001 ## File path: core/src/main/java/org/apache/druid/data/input/RetryingInputEntity.java ##

[GitHub] [incubator-druid] ccaominh opened a new pull request #8925: Parallel indexing single dim partitions

2019-11-21 Thread GitBox
ccaominh opened a new pull request #8925: Parallel indexing single dim partitions URL: https://github.com/apache/incubator-druid/pull/8925 ### Description Implements single dimension range partitioning for native parallel batch indexing as described in #8769. This initial version

[GitHub] [incubator-druid] clintropolis commented on issue #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster)

2019-11-21 Thread GitBox
clintropolis commented on issue #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster) URL: https://github.com/apache/incubator-druid/pull/6988#issuecomment-557361993 Hi @pzhdfy, my apologies for totally forgetting about this PR. Could you please fix the

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed

2019-11-21 Thread GitBox
jihoonson commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed URL: https://github.com/apache/incubator-druid/pull/7041#discussion_r349407287 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8923: RetryingInputEntity to retry on transient errors

2019-11-21 Thread GitBox
jihoonson commented on a change in pull request #8923: RetryingInputEntity to retry on transient errors URL: https://github.com/apache/incubator-druid/pull/8923#discussion_r349407133 ## File path: core/src/main/java/org/apache/druid/data/input/RetryingInputEntity.java ##

[GitHub] [incubator-druid] jihoonson opened a new pull request #8924: Fix the potential race between SplittableInputSource.getNumSplits() and SplittableInputSource.createSplits() in TaskMonitor

2019-11-21 Thread GitBox
jihoonson opened a new pull request #8924: Fix the potential race between SplittableInputSource.getNumSplits() and SplittableInputSource.createSplits() in TaskMonitor URL: https://github.com/apache/incubator-druid/pull/8924 ### Description `SplittableInputSource` has two methods

[GitHub] [incubator-druid] stale[bot] commented on issue #8127: [WIP]growable sketch aggregator support

2019-11-21 Thread GitBox
stale[bot] commented on issue #8127: [WIP]growable sketch aggregator support URL: https://github.com/apache/incubator-druid/pull/8127#issuecomment-557352333 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs.

[GitHub] [incubator-druid] AlexanderSaydakov commented on issue #8647: use the latest release of datasketches

2019-11-21 Thread GitBox
AlexanderSaydakov commented on issue #8647: use the latest release of datasketches URL: https://github.com/apache/incubator-druid/pull/8647#issuecomment-557350975 removed the JDK version check (back to how it was before)

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8923: RetryingInputEntity to retry on transient errors

2019-11-21 Thread GitBox
jon-wei commented on a change in pull request #8923: RetryingInputEntity to retry on transient errors URL: https://github.com/apache/incubator-druid/pull/8923#discussion_r349401023 ## File path: core/src/main/java/org/apache/druid/data/input/RetryingInputEntity.java ##

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8883: add parquet support to native batch

2019-11-21 Thread GitBox
ccaominh commented on a change in pull request #8883: add parquet support to native batch URL: https://github.com/apache/incubator-druid/pull/8883#discussion_r349352032 ## File path: extensions-core/parquet-extensions/pom.xml ## @@ -137,10 +137,249 @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8883: add parquet support to native batch

2019-11-21 Thread GitBox
ccaominh commented on a change in pull request #8883: add parquet support to native batch URL: https://github.com/apache/incubator-druid/pull/8883#discussion_r349396346 ## File path:

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8883: add parquet support to native batch

2019-11-21 Thread GitBox
ccaominh commented on a change in pull request #8883: add parquet support to native batch URL: https://github.com/apache/incubator-druid/pull/8883#discussion_r349395211 ## File path:

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8883: add parquet support to native batch

2019-11-21 Thread GitBox
ccaominh commented on a change in pull request #8883: add parquet support to native batch URL: https://github.com/apache/incubator-druid/pull/8883#discussion_r349394798 ## File path:

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8923: RetryingInputEntity to retry on transient errors

2019-11-21 Thread GitBox
lgtm-com[bot] commented on issue #8923: RetryingInputEntity to retry on transient errors URL: https://github.com/apache/incubator-druid/pull/8923#issuecomment-557306672 This pull request **introduces 1 alert** when merging db25fa232cb0fcb3ffd08e0e94ebe7e545654e8e into

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8923: RetryingInputEntity to retry on transient errors

2019-11-21 Thread GitBox
jihoonson commented on a change in pull request #8923: RetryingInputEntity to retry on transient errors URL: https://github.com/apache/incubator-druid/pull/8923#discussion_r349355036 ## File path: core/src/main/java/org/apache/druid/data/input/impl/RetryingInputEntity.java

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8923: RetryingInputEntity to retry on transient errors

2019-11-21 Thread GitBox
clintropolis commented on a change in pull request #8923: RetryingInputEntity to retry on transient errors URL: https://github.com/apache/incubator-druid/pull/8923#discussion_r349352361 ## File path: core/src/main/java/org/apache/druid/data/input/impl/RetryingInputEntity.java

[GitHub] [incubator-druid] clintropolis commented on issue #8921: use retry-able stream for native batch google input source

2019-11-21 Thread GitBox
clintropolis commented on issue #8921: use retry-able stream for native batch google input source URL: https://github.com/apache/incubator-druid/pull/8921#issuecomment-557290277 closing in favor of #8923 This is an automated

[GitHub] [incubator-druid] clintropolis closed pull request #8921: use retry-able stream for native batch google input source

2019-11-21 Thread GitBox
clintropolis closed pull request #8921: use retry-able stream for native batch google input source URL: https://github.com/apache/incubator-druid/pull/8921 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] jihoonson opened a new pull request #8923: RetryingInputEntity to retry on transient errors

2019-11-21 Thread GitBox
jihoonson opened a new pull request #8923: RetryingInputEntity to retry on transient errors URL: https://github.com/apache/incubator-druid/pull/8923 ### Description Reading from some inputSources such as S3 or GS should retry on transient errors. This PR has: -

[GitHub] [incubator-druid] jihoonson commented on issue #8922: ArrayIndexOutOfBoundsException on historical in class GroupByMergingQueryRunnerV2 when grouping on high-cardinality dimension

2019-11-21 Thread GitBox
jihoonson commented on issue #8922: ArrayIndexOutOfBoundsException on historical in class GroupByMergingQueryRunnerV2 when grouping on high-cardinality dimension URL: https://github.com/apache/incubator-druid/issues/8922#issuecomment-557243853 Hi @sascha-coenen, groupBy v2 supports

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8915: add TsvInputFormat

2019-11-21 Thread GitBox
SEKIRO-J commented on a change in pull request #8915: add TsvInputFormat URL: https://github.com/apache/incubator-druid/pull/8915#discussion_r349267860 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SeparateValueInputFormat.java ## @@ -0,0 +1,179 @@ +/*

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8915: add TsvInputFormat

2019-11-21 Thread GitBox
ccaominh commented on a change in pull request #8915: add TsvInputFormat URL: https://github.com/apache/incubator-druid/pull/8915#discussion_r349260837 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SeparateValueInputFormat.java ## @@ -0,0 +1,179 @@ +/*

[GitHub] [incubator-druid] stale[bot] closed issue #6880: [Proposal] Support a "Random" function as an expression

2019-11-21 Thread GitBox
stale[bot] closed issue #6880: [Proposal] Support a "Random" function as an expression URL: https://github.com/apache/incubator-druid/issues/6880 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] sascha-coenen opened a new issue #8922: ArrayIndexOutOfBoundsException on historical in class GroupByMergingQueryRunnerV2 when grouping on high-cardinality dimension

2019-11-21 Thread GitBox
sascha-coenen opened a new issue #8922: ArrayIndexOutOfBoundsException on historical in class GroupByMergingQueryRunnerV2 when grouping on high-cardinality dimension URL: https://github.com/apache/incubator-druid/issues/8922 ### Affected Version Druid 0.16.0 ###

[GitHub] [incubator-druid] vogievetsky commented on issue #8920: Failed to build docker image: npm ci failed

2019-11-21 Thread GitBox
vogievetsky commented on issue #8920: Failed to build docker image: npm ci failed URL: https://github.com/apache/incubator-druid/issues/8920#issuecomment-557215664 Strange that it is not consistent. Is npm having issues?

[GitHub] [incubator-druid] vogievetsky commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema`

2019-11-21 Thread GitBox
vogievetsky commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema` URL: https://github.com/apache/incubator-druid/issues/8916#issuecomment-557215185 @jimj you can use the web console data loader to make the JSON for you:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed

2019-11-21 Thread GitBox
jihoonson commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed URL: https://github.com/apache/incubator-druid/pull/7041#discussion_r349248979 ## File path:

[GitHub] [incubator-druid] leventov commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-11-21 Thread GitBox
leventov commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-557208174 @pjain1 could you please take another look? I didn't test

[GitHub] [incubator-druid] SEKIRO-J commented on issue #8915: add TsvInputFormat

2019-11-21 Thread GitBox
SEKIRO-J commented on issue #8915: add TsvInputFormat URL: https://github.com/apache/incubator-druid/pull/8915#issuecomment-557206453 > Sorry for being the grammar police here, but it would be better if we correct `Seperate` to `Separate` thank you for pointing out

[GitHub] [incubator-druid] zhenxiao commented on issue #8879: Add RandomStorageLocationSelectorStrategy and MostAvailableSizeStorageLocationSelectorStrategy

2019-11-21 Thread GitBox
zhenxiao commented on issue #8879: Add RandomStorageLocationSelectorStrategy and MostAvailableSizeStorageLocationSelectorStrategy URL: https://github.com/apache/incubator-druid/pull/8879#issuecomment-557203981 Hi @sashidhar existing LeastBytesUsedStorageLocationSelectorStrategy only

[GitHub] [incubator-druid] jihoonson commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema`

2019-11-21 Thread GitBox
jihoonson commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema` URL: https://github.com/apache/incubator-druid/issues/8916#issuecomment-557200660 @jimj glad it worked! This is an

[GitHub] [incubator-druid] jimj closed issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema`

2019-11-21 Thread GitBox
jimj closed issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema` URL: https://github.com/apache/incubator-druid/issues/8916 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-druid] jimj commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema`

2019-11-21 Thread GitBox
jimj commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema` URL: https://github.com/apache/incubator-druid/issues/8916#issuecomment-557200293 WOW thanks so much for the fresh eyes finding the user error! Terribly embarrassing that neither I or a

[GitHub] [incubator-druid] jihoonson commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema`

2019-11-21 Thread GitBox
jihoonson commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema` URL: https://github.com/apache/incubator-druid/issues/8916#issuecomment-557196167 BTW, we are currently developing a new `InputFormat` API

[GitHub] [incubator-druid] jihoonson commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema`

2019-11-21 Thread GitBox
jihoonson commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema` URL: https://github.com/apache/incubator-druid/issues/8916#issuecomment-557194685 Hi @jimj, thanks for sharing your spec. It seems like `transformSpec` is inside of `parser`. But it

[GitHub] [incubator-druid] jimj commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema`

2019-11-21 Thread GitBox
jimj commented on issue #8916: Kinesis Indexing does not honor `transformSpec` of the `dataSchema` URL: https://github.com/apache/incubator-druid/issues/8916#issuecomment-557192112 I'm sorry to say this still does not appear to work for me. I've pared my example down to the bare bones.

[GitHub] [incubator-druid] gianm commented on a change in pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console

2019-11-21 Thread GitBox
gianm commented on a change in pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console URL: https://github.com/apache/incubator-druid/pull/8919#discussion_r349217646 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java

[GitHub] [incubator-druid] gianm commented on a change in pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console

2019-11-21 Thread GitBox
gianm commented on a change in pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console URL: https://github.com/apache/incubator-druid/pull/8919#discussion_r349217078 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java

[GitHub] [incubator-druid] scottbelden closed issue #8827: Failure to ingest local file when running through the tutorial with the docker cluster

2019-11-21 Thread GitBox
scottbelden closed issue #8827: Failure to ingest local file when running through the tutorial with the docker cluster URL: https://github.com/apache/incubator-druid/issues/8827 This is an automated message from the Apache

[GitHub] [incubator-druid] scottbelden commented on issue #8827: Failure to ingest local file when running through the tutorial with the docker cluster

2019-11-21 Thread GitBox
scottbelden commented on issue #8827: Failure to ingest local file when running through the tutorial with the docker cluster URL: https://github.com/apache/incubator-druid/issues/8827#issuecomment-557153119 It turns out that the main issue was that the default environment file wants to

[GitHub] [incubator-druid] leventov commented on issue #8920: Failed to build docker image: npm ci failed

2019-11-21 Thread GitBox
leventov commented on issue #8920: Failed to build docker image: npm ci failed URL: https://github.com/apache/incubator-druid/issues/8920#issuecomment-557120108 Another run, it failed with ``` [ERROR] npm ERR! 404 Not Found: tslib@1.10.0 ```

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console

2019-11-21 Thread GitBox
vogievetsky commented on a change in pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console URL: https://github.com/apache/incubator-druid/pull/8919#discussion_r349125442 ## File path: web-console/src/views/query-view/query-view.tsx ## @@ -251,17

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console

2019-11-21 Thread GitBox
vogievetsky commented on a change in pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console URL: https://github.com/apache/incubator-druid/pull/8919#discussion_r349126443 ## File path: web-console/src/views/query-view/query-view.tsx ## @@ -320,14

[GitHub] [incubator-druid] vogievetsky commented on issue #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console

2019-11-21 Thread GitBox
vogievetsky commented on issue #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console URL: https://github.com/apache/incubator-druid/pull/8919#issuecomment-557113254  on the console changes! This is an

[GitHub] [incubator-druid] clintropolis opened a new pull request #8921: use retry-able stream for native batch google input source

2019-11-21 Thread GitBox
clintropolis opened a new pull request #8921: use retry-able stream for native batch google input source URL: https://github.com/apache/incubator-druid/pull/8921 ### Description Wrap the object stream provided by the `GoogleCloudStorageEntity` implementation of `InputEntity` in a

[GitHub] [incubator-druid] leventov opened a new issue #8920: Failed to build docker image: npm ci failed

2019-11-21 Thread GitBox
leventov opened a new issue #8920: Failed to build docker image: npm ci failed URL: https://github.com/apache/incubator-druid/issues/8920 ``` [ERROR] npm ERR! code E404 [ERROR] npm ERR! 404 Not Found: awesome-code-style@1.4.3 [ERROR] [ERROR] npm ERR! A complete log of this run

[GitHub] [incubator-druid] leventov commented on issue #7232: Fix ITRealtimeIndexTaskTest Flakiness

2019-11-21 Thread GitBox
leventov commented on issue #7232: Fix ITRealtimeIndexTaskTest Flakiness URL: https://github.com/apache/incubator-druid/pull/7232#issuecomment-557070890 I still see flakiness in this test: #8918, should we make the pause longer or rather implement deterministic wait?

[GitHub] [incubator-druid] clintropolis opened a new pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console

2019-11-21 Thread GitBox
clintropolis opened a new pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console URL: https://github.com/apache/incubator-druid/pull/8919 ### Description This PR modifies the 'smart limit' strategy in the web-console query view to use the `sqlOuterLimit`

[GitHub] [incubator-druid] leventov opened a new issue #8918: Flaky test ITAppenderatorDriverRealtimeIndexTaskTest testRealtimeIndexTask()

2019-11-21 Thread GitBox
leventov opened a new issue #8918: Flaky test ITAppenderatorDriverRealtimeIndexTaskTest testRealtimeIndexTask() URL: https://github.com/apache/incubator-druid/issues/8918 Same as #7219 This is an automated message from

[GitHub] [incubator-druid] sashidhar commented on issue #8879: Add RandomStorageLocationSelectorStrategy and MostAvailableSizeStorageLocationSelectorStrategy

2019-11-21 Thread GitBox
sashidhar commented on issue #8879: Add RandomStorageLocationSelectorStrategy and MostAvailableSizeStorageLocationSelectorStrategy URL: https://github.com/apache/incubator-druid/pull/8879#issuecomment-557068720 @zhenxiao How is the MostAvailableSizeStorageLocationSelectorStrategy

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-11-21 Thread GitBox
lgtm-com[bot] commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-557008732 This pull request **introduces 1 alert** when merging

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-11-21 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r348958815 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-11-21 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r348957847 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-11-21 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r348955071 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed

2019-11-21 Thread GitBox
leventov commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed URL: https://github.com/apache/incubator-druid/pull/7041#discussion_r348950767 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-11-21 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r348945394 ## File path:

[GitHub] [incubator-druid] leventov opened a new issue #8917: Reconcile comment/documentation spelling to "datasource" rather than "data source"

2019-11-21 Thread GitBox
leventov opened a new issue #8917: Reconcile comment/documentation spelling to "datasource" rather than "data source" URL: https://github.com/apache/incubator-druid/issues/8917 Note the difference with #6870: #6870 is about code occurrences (in identifiers, method names, etc.) while this

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-11-21 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r348944488 ## File path:

[GitHub] [incubator-druid] pjain1 commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-11-21 Thread GitBox
pjain1 commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r315040429 ## File path: