[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8980: Address security vulnerabilities CVSS >= 7

2019-12-03 Thread GitBox
clintropolis commented on a change in pull request #8980: Address security vulnerabilities CVSS >= 7 URL: https://github.com/apache/incubator-druid/pull/8980#discussion_r353581529 ## File path: core/src/main/java/org/apache/druid/data/input/impl/prefetch/JsonIterator.java

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8980: Address security vulnerabilities CVSS >= 7

2019-12-03 Thread GitBox
clintropolis commented on a change in pull request #8980: Address security vulnerabilities CVSS >= 7 URL: https://github.com/apache/incubator-druid/pull/8980#discussion_r353580777 ## File path: licenses.yaml ## @@ -233,6 +233,30 @@ notice: | --- +name: JavaBeans

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8980: Address security vulnerabilities CVSS >= 7

2019-12-03 Thread GitBox
clintropolis commented on a change in pull request #8980: Address security vulnerabilities CVSS >= 7 URL: https://github.com/apache/incubator-druid/pull/8980#discussion_r353580899 ## File path: licenses/bin/jakarta.activation-api.EDL1 ## @@ -0,0 +1,13 @@ +Eclipse

[GitHub] [incubator-druid] clintropolis commented on issue #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
clintropolis commented on issue #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#issuecomment-561508627 >actually periodic snapshot of FJP state would be nice to see to identify potential bugs e.g. number of

[URGENT] [MENTORS] Druid Incubator Report

2019-12-03 Thread Justin Mclean
Hi, Thanks for submitting you report. However, under "Three most important unfinished issues to address before graduating:" in your report you have put "No major issues". In this current form this report will not be accepted by the IPMC and you will be asked to report next month. The IPMC

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
clintropolis commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#discussion_r353576202 ## File path:

[GitHub] [incubator-druid] himanshug commented on issue #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
himanshug commented on issue #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#issuecomment-561506572 LGTM overall non blocking commentary > Also absent are any sort of aggregate metrics, such as

[GitHub] [incubator-druid] qutang1 edited a comment on issue #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter, InDimFilter

2019-12-03 Thread GitBox
qutang1 edited a comment on issue #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter, InDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#issuecomment-561465846 1. In the line 58 of eclipse_formatting.xml, it should be changed to: `` instead of

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
himanshug commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#discussion_r353573985 ## File path:

[GitHub] [incubator-druid] viongpanzi commented on issue #7540: call threadlocal.remove explicitly to avoid CPU usage spikes

2019-12-03 Thread GitBox
viongpanzi commented on issue #7540: call threadlocal.remove explicitly to avoid CPU usage spikes URL: https://github.com/apache/incubator-druid/pull/7540#issuecomment-561497573 In our prod env, this problem will cause many query become slow. This PR may be useful.

[GitHub] [incubator-druid] sekingme opened a new pull request #8986: For total segment

2019-12-03 Thread GitBox
sekingme opened a new pull request #8986: For total segment URL: https://github.com/apache/incubator-druid/pull/8986 Add total segments information in server with '/druid/coordinator/v1/servers'. This is useful to get the realtime segment numbers in each historical server. By the

[GitHub] [incubator-druid] qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

2019-12-03 Thread GitBox
qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r353539356 ## File path:

[GitHub] [incubator-druid] qutang1 commented on issue #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

2019-12-03 Thread GitBox
qutang1 commented on issue #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#issuecomment-561465846 In the line 58 of eclipse_formatting.xml, it should be changed to: `` instead of "do not insert". By

[GitHub] [incubator-druid] qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

2019-12-03 Thread GitBox
qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r353539356 ## File path:

[GitHub] [incubator-druid] qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

2019-12-03 Thread GitBox
qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r353538985 ## File path:

[GitHub] [incubator-druid] qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

2019-12-03 Thread GitBox
qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r353538985 ## File path:

[GitHub] [incubator-druid] qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

2019-12-03 Thread GitBox
qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r353538688 ## File path:

[GitHub] [incubator-druid] qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

2019-12-03 Thread GitBox
qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r353538688 ## File path:

[GitHub] [incubator-druid] ccaominh commented on issue #8980: Address security vulnerabilities CVSS >= 7

2019-12-03 Thread GitBox
ccaominh commented on issue #8980: Address security vulnerabilities CVSS >= 7 URL: https://github.com/apache/incubator-druid/pull/8980#issuecomment-561463740 Manually tested with https://druid.apache.org/docs/latest/tutorials/tutorial-batch-hadoop.html

[GitHub] [incubator-druid] alex601049502 opened a new issue #8985: extension-contrib distinctCount function calc result is wrong #BUG

2019-12-03 Thread GitBox
alex601049502 opened a new issue #8985: extension-contrib distinctCount function calc result is wrong #BUG URL: https://github.com/apache/incubator-druid/issues/8985 Druid Version:0.12.3 I used distinctCount as aggregations‘s type,when dimension and aggregation contain the same fields,

[GitHub] [incubator-druid] jon-wei commented on issue #8982: Add DruidInputSource (replacement for IngestSegmentFirehose)

2019-12-03 Thread GitBox
jon-wei commented on issue #8982: Add DruidInputSource (replacement for IngestSegmentFirehose) URL: https://github.com/apache/incubator-druid/pull/8982#issuecomment-561462456 Added a doc entry for the new input source. We'll need a larger rework of the docs for the new input sources/input

[GitHub] [incubator-druid] clintropolis commented on issue #8947: Unnecessary cartesian explosion if multi-value column is reused in expression

2019-12-03 Thread GitBox
clintropolis commented on issue #8947: Unnecessary cartesian explosion if multi-value column is reused in expression URL: https://github.com/apache/incubator-druid/issues/8947#issuecomment-561453513 >so this should yield a result of [other, 1], [b, 1], [g, 1] ? With the adjusted

[GitHub] [incubator-druid] gianm merged pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console

2019-12-03 Thread GitBox
gianm merged pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console URL: https://github.com/apache/incubator-druid/pull/8919 This is an automated message from the Apache Git Service. To respond to

[incubator-druid] branch master updated (187cf0d -> d0a6fe7)

2019-12-03 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 187cf0d [Improvement] historical fast restart by lazy load columns metadata(20X faster) (#6988) add

[GitHub] [incubator-druid] stale[bot] commented on issue #6268: Unexpected result is returned when query start time equals to end time

2019-12-03 Thread GitBox
stale[bot] commented on issue #6268: Unexpected result is returned when query start time equals to end time URL: https://github.com/apache/incubator-druid/issues/6268#issuecomment-561443951 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if

svn commit: r37073 - /dev/incubator/druid/0.16.1-incubating-rc2/

2019-12-03 Thread jonwei
Author: jonwei Date: Wed Dec 4 01:15:24 2019 New Revision: 37073 Log: Add 0.16.1-incubating-rc2 artifacts Added: dev/incubator/druid/0.16.1-incubating-rc2/ dev/incubator/druid/0.16.1-incubating-rc2/apache-druid-0.16.1-incubating-bin.tar.gz (with props)

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
clintropolis commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#discussion_r353503025 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
clintropolis commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#discussion_r353502939 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
jon-wei commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#discussion_r353492990 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
jon-wei commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#discussion_r353452801 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
jon-wei commented on a change in pull request #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#discussion_r353491280 ## File path:

[incubator-druid] 01/02: Revert "[maven-release-plugin] prepare release druid-0.16.1-incubating-rc1"

2019-12-03 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to tag druid-0.16.1-incubating-rc2 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git commit 20fa4785684b287706577b94f890925f39488dba Author: jon-wei AuthorDate: Tue Dec 3 16:08:03 2019

[incubator-druid] 02/02: [maven-release-plugin] prepare release druid-0.16.1-incubating-rc2

2019-12-03 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to tag druid-0.16.1-incubating-rc2 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git commit 144bd782964cac3d3d31f21b9e03b3c215f7f42d Author: jon-wei AuthorDate: Thu Nov 28 18:09:07

[incubator-druid] tag druid-0.16.1-incubating-rc2 created (now 144bd78)

2019-12-03 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to tag druid-0.16.1-incubating-rc2 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. at 144bd78 (commit) This tag includes the following new commits: new 20fa478 Revert

[incubator-druid] tag druid-0.16.1-incubating-rc2 created (now 0706f70)

2019-12-03 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to tag druid-0.16.1-incubating-rc2 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. at 0706f70 (commit) No new revisions were added by this update.

[GitHub] [incubator-druid] jon-wei commented on issue #8931: Make DruidAvaticaHandler extensible to support auth on mTLS JDBC requests

2019-12-03 Thread GitBox
jon-wei commented on issue #8931: Make DruidAvaticaHandler extensible to support auth on mTLS JDBC requests URL: https://github.com/apache/incubator-druid/issues/8931#issuecomment-561386021 @a2l007 The Authenticators can provide a servlet Filter, would it it be possible to pass

[GitHub] [incubator-druid] zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback)

2019-12-03 Thread GitBox
zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#issuecomment-561382604 Hi @leventov I rebased this PR to resolve code conflicts. Are you free to take a look?

[GitHub] [incubator-druid] clintropolis commented on issue #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
clintropolis commented on issue #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#issuecomment-561353177 >I'm surprised that off by default means the user has to write code to enable them vs using a config option

[GitHub] [incubator-druid] vogievetsky commented on issue #8982: Add DruidInputSource (replacement for IngestSegmentFirehose)

2019-12-03 Thread GitBox
vogievetsky commented on issue #8982: Add DruidInputSource (replacement for IngestSegmentFirehose) URL: https://github.com/apache/incubator-druid/pull/8982#issuecomment-561348229 Tested this (as a user) from the console (via https://github.com/apache/incubator-druid/pull/8828 ) and it

[GitHub] [incubator-druid] zhenxiao edited a comment on issue #8848: Refactor DirectDruidClient, extract QueryContextInputStreamResponseHandler

2019-12-03 Thread GitBox
zhenxiao edited a comment on issue #8848: Refactor DirectDruidClient, extract QueryContextInputStreamResponseHandler URL: https://github.com/apache/incubator-druid/pull/8848#issuecomment-561312258 whoops, CI pass now @leventov how about this one? when merge master into my branch, let's

[GitHub] [incubator-druid] zhenxiao commented on issue #8848: Refactor DirectDruidClient, extract QueryContextInputStreamResponseHandler

2019-12-03 Thread GitBox
zhenxiao commented on issue #8848: Refactor DirectDruidClient, extract QueryContextInputStreamResponseHandler URL: https://github.com/apache/incubator-druid/pull/8848#issuecomment-561312258 whoops, CI pass now @leventov how about this one? when merge master into my branch, let's say

[GitHub] [incubator-druid] himanshug opened a new issue #8984: [Proposal] Authenticator impl for OpenID Connect OAuth2.0 protocol

2019-12-03 Thread GitBox
himanshug opened a new issue #8984: [Proposal] Authenticator impl for OpenID Connect OAuth2.0 protocol URL: https://github.com/apache/incubator-druid/issues/8984 ### Motivation Okta is used by my employer (and many others, maybe some other OpenID server) for authenticating employees in

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8925: Parallel indexing single dim partitions

2019-12-03 Thread GitBox
ccaominh commented on a change in pull request #8925: Parallel indexing single dim partitions URL: https://github.com/apache/incubator-druid/pull/8925#discussion_r352984386 ## File path:

[incubator-druid] branch master updated (b4efaa6 -> 187cf0d)

2019-12-03 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from b4efaa6 unexclude necessary jackson mapper-asl jars (#8977) add 187cf0d [Improvement] historical

[GitHub] [incubator-druid] himanshug merged pull request #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster)

2019-12-03 Thread GitBox
himanshug merged pull request #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster) URL: https://github.com/apache/incubator-druid/pull/6988 This is an automated message from the Apache Git

[GitHub] [incubator-druid] leventov commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

2019-12-03 Thread GitBox
leventov commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r353327275 ## File path:

[GitHub] [incubator-druid] qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

2019-12-03 Thread GitBox
qutang1 commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r353326275 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

2019-12-03 Thread GitBox
leventov commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r353325211 ## File path:

[GitHub] [incubator-druid] leventov commented on issue #8848: Refactor DirectDruidClient, extract QueryContextInputStreamResponseHandler

2019-12-03 Thread GitBox
leventov commented on issue #8848: Refactor DirectDruidClient, extract QueryContextInputStreamResponseHandler URL: https://github.com/apache/incubator-druid/pull/8848#issuecomment-561274465 @zhenxiao note for future: don't force push branches. merge master into PR branch, **do not

[GitHub] [incubator-druid] jnaous commented on issue #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
jnaous commented on issue #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981#issuecomment-561227213 I'm surprised that off by default means the user has to write code to enable them vs using a config option of some

[GitHub] [incubator-druid] pzhdfy commented on a change in pull request #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster)

2019-12-03 Thread GitBox
pzhdfy commented on a change in pull request #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster) URL: https://github.com/apache/incubator-druid/pull/6988#discussion_r353211479 ## File path: docs/configuration/index.md ## @@ -1359,6

[GitHub] [incubator-druid] zhanglistar commented on issue #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster)

2019-12-03 Thread GitBox
zhanglistar commented on issue #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster) URL: https://github.com/apache/incubator-druid/pull/6988#issuecomment-561148357 great!!! This is an

[GitHub] [incubator-druid] sekingme opened a new pull request #8983: Enable parameters 'resultAsArray' working in materialized-view-selection with a group by query

2019-12-03 Thread GitBox
sekingme opened a new pull request #8983: Enable parameters 'resultAsArray' working in materialized-view-selection with a group by query URL: https://github.com/apache/incubator-druid/pull/8983 Enable parameter '**resultAsArray'** working in materialized-view-selection with a group by

[GitHub] [incubator-druid] stale[bot] commented on issue #7086: [ERROR] Numeric columns do not support multivalue rows

2019-12-03 Thread GitBox
stale[bot] commented on issue #7086: [ERROR] Numeric columns do not support multivalue rows URL: https://github.com/apache/incubator-druid/issues/7086#issuecomment-561082328 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further

[GitHub] [incubator-druid] jon-wei commented on issue #8982: Add DruidInputSource (replacement for IngestSegmentFirehose)

2019-12-03 Thread GitBox
jon-wei commented on issue #8982: Add DruidInputSource (replacement for IngestSegmentFirehose) URL: https://github.com/apache/incubator-druid/pull/8982#issuecomment-561062141 Marking WIP, need to update the docs, and will add an integration test to `ITParallelIndexTaskTest` that uses the

[GitHub] [incubator-druid] jon-wei opened a new pull request #8982: Add DruidInputSource (replacement for IngestSegmentFirehose)

2019-12-03 Thread GitBox
jon-wei opened a new pull request #8982: Add DruidInputSource (replacement for IngestSegmentFirehose) URL: https://github.com/apache/incubator-druid/pull/8982 Based on an initial patch by @jihoonson This PR adds `DruidInputSource` and associated classes, a new replacement for

[GitHub] [incubator-druid] clintropolis opened a new pull request #8981: add query metrics for broker parallel merges, off by default

2019-12-03 Thread GitBox
clintropolis opened a new pull request #8981: add query metrics for broker parallel merges, off by default URL: https://github.com/apache/incubator-druid/pull/8981 ### Description This PR is a follow-up to #8578, adding a handful of query metrics that I believe are interesting, but