[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-27 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r565775481 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java ## @@ -320,12 +320,1

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-27 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r565774749 ## File path: server/src/main/java/org/apache/druid/segment/indexing/granularity/GranularitySpec.java ## @@ -41,11 +40,11 @@ public interface Granular

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-27 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r565773059 ## File path: server/src/main/java/org/apache/druid/segment/indexing/LookupIntervalBuckets.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Soft

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-27 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r565763900 ## File path: indexing-hadoop/src/test/java/org/apache/druid/indexer/HadoopDruidDetermineConfigurationJobTest.java ## @@ -99,7 +98,7 @@ public void te

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-27 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r565762407 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/DetermineHashedPartitionsJob.java ## @@ -109,10 +109,10 @@ public boolean run()

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-27 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r565762407 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/DetermineHashedPartitionsJob.java ## @@ -109,10 +109,10 @@ public boolean run()

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-26 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564978098 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java ## @@ -1062,7 +1064,

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-26 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564977372 ## File path: core/src/main/java/org/apache/druid/java/util/common/granularity/IntervalsByGranularity.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-26 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564941129 ## File path: core/src/main/java/org/apache/druid/java/util/common/granularity/IntervalsByGranularity.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-26 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564941129 ## File path: core/src/main/java/org/apache/druid/java/util/common/granularity/IntervalsByGranularity.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-26 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564940783 ## File path: core/src/main/java/org/apache/druid/java/util/common/granularity/IntervalsByGranularity.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-26 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564882937 ## File path: core/src/main/java/org/apache/druid/java/util/common/JodaUtils.java ## @@ -50,15 +58,31 @@ sortedIntervals.add(interval);

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-26 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564678335 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java ## @@ -373,23 +373,25 @@ private boolean

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-26 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564679000 ## File path: core/src/main/java/org/apache/druid/java/util/common/granularity/IntervalsByGranularity.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-26 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564678335 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java ## @@ -373,23 +373,25 @@ private boolean

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-25 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564080150 ## File path: core/src/main/java/org/apache/druid/java/util/common/granularity/IntervalsByGranularity.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-25 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r564080150 ## File path: core/src/main/java/org/apache/druid/java/util/common/granularity/IntervalsByGranularity.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-21 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r562027501 ## File path: server/src/test/java/org/apache/druid/segment/indexing/granularity/IntervalsByGranularityTest.java ## @@ -76,6 +79,21 @@ public void test

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-21 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r562047065 ## File path: server/src/test/java/org/apache/druid/segment/indexing/granularity/IntervalsByGranularityTest.java ## @@ -76,6 +79,21 @@ public void test

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-21 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r562044660 ## File path: core/src/main/java/org/apache/druid/java/util/common/JodaUtils.java ## @@ -50,15 +49,25 @@ sortedIntervals.add(interval);

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-21 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r562031987 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java ## @@ -373,23 +373,25 @@ private boolean

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-21 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r562029029 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialDimensionDistributionTask.java ## @@ -106,7 +1

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-21 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r562027501 ## File path: server/src/test/java/org/apache/druid/segment/indexing/granularity/IntervalsByGranularityTest.java ## @@ -76,6 +79,21 @@ public void test

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-14 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r55778 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java ## @@ -398,22 +375,21 @@ private boolean

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-14 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r557784750 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopDruidIndexerConfig.java ## @@ -314,9 +313,9 @@ public void setShardSpecs(Map

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-14 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r55778 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java ## @@ -398,22 +375,21 @@ private boolean

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-14 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r557576226 ## File path: server/src/main/java/org/apache/druid/segment/indexing/LookupIntervalBuckets.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Soft

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-14 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r557576226 ## File path: server/src/main/java/org/apache/druid/segment/indexing/LookupIntervalBuckets.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Soft

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-12 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r555991064 ## File path: server/src/main/java/org/apache/druid/segment/indexing/granularity/GranularitySpec.java ## @@ -45,7 +46,7 @@ * * @return set of a

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-12 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r555931298 ## File path: server/src/main/java/org/apache/druid/segment/indexing/granularity/UniformGranularitySpec.java ## @@ -57,18 +60,17 @@ public UniformGranu

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-11 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r555457289 ## File path: server/src/main/java/org/apache/druid/segment/indexing/granularity/GranularitySpec.java ## @@ -45,7 +46,7 @@ * * @return set of a