Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

LakshSingla merged PR #16130: URL: https://github.com/apache/druid/pull/16130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

github-advanced-security[bot] commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1551290113 ## processing/src/main/java/org/apache/druid/frame/write/RowBasedFrameWriter.java: ## @@ -299,11 +300,15 @@

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

gargvishesh commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1551132601 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/FrameFieldWriterFault.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

gargvishesh commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1551129181 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2983,6 +2984,20 @@ private MSQErrorReport

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

gargvishesh commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1551124120 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/FrameFieldWriterFault.java: ## @@ -49,7 +51,7 @@ public

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

LakshSingla commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1551086264 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2983,6 +2984,20 @@ private MSQErrorReport

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

LakshSingla commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1551084415 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/FrameFieldWriterFault.java: ## @@ -49,7 +51,7 @@ public

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

LakshSingla commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1551082323 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/FrameFieldWriterFault.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

gargvishesh commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1551071976 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/FrameFieldWriterFault.java: ## Review Comment: Done. I've also added

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

gargvishesh commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1551065872 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2983,6 +2984,20 @@ private MSQErrorReport

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

LakshSingla commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1549763794 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/FrameFieldWriterFault.java: ## Review Comment: Let's add this class to

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

LakshSingla commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1549761358 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2983,6 +2984,20 @@ private MSQErrorReport

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

gargvishesh commented on PR #16130: URL: https://github.com/apache/druid/pull/16130#issuecomment-2029185932 > * Can you please add a test case where the exception gets generated? Tried multiple routes incl insert via external inline tables and insert via joins, but an error isn't

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

gargvishesh commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1545971957 ## processing/src/main/java/org/apache/druid/frame/write/FrameFieldWriterException.java: ## Review Comment: Converting `FrameFieldWriterException` now to an

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

gargvishesh commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1545971524 ## processing/src/main/java/org/apache/druid/frame/write/InvalidNullByteException.java: ## @@ -53,17 +50,16 @@ private InvalidNullByteException( @Nullable

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

github-advanced-security[bot] commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1534284022 ## processing/src/main/java/org/apache/druid/frame/write/RowBasedFrameWriter.java: ## @@ -299,11 +300,15 @@

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

cryptoe commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1530055165 ## processing/src/main/java/org/apache/druid/frame/write/FrameFieldWriterException.java: ## Review Comment: I think we can make a MSQ fault out of this. That way

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

cryptoe commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1530054071 ## processing/src/main/java/org/apache/druid/frame/write/InvalidNullByteException.java: ## @@ -53,17 +50,16 @@ private InvalidNullByteException( @Nullable final

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

LakshSingla commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1525991508 ## processing/src/main/java/org/apache/druid/frame/write/FrameFieldWriterException.java: ## Review Comment: I doubt that we need this class anywhere. Can't we

Re: [PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

LakshSingla commented on code in PR #16130: URL: https://github.com/apache/druid/pull/16130#discussion_r1525991508 ## processing/src/main/java/org/apache/druid/frame/write/FrameFieldWriterException.java: ## Review Comment: I doubt that we need this class anywhere. Can't we

[PR] Record column name for exceptions while writing frames in RowBasedFrameWriter (druid)

gargvishesh opened a new pull request, #16130: URL: https://github.com/apache/druid/pull/16130 Current Runtime Exceptions generated while writing frames only include the exception itself without including the name of the column they were encountered in, for e.g.