Re: [PR] Add indexer level task metrics to provide more visibility in the task distribution (druid)

2024-03-20 Thread via GitHub
rbankar7 commented on PR #15991: URL: https://github.com/apache/druid/pull/15991#issuecomment-2011246840 @kfaraz looks like build is passing now could you please take a look Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Add indexer level task metrics to provide more visibility in the task distribution (druid)

2024-03-20 Thread via GitHub
kfaraz merged PR #15991: URL: https://github.com/apache/druid/pull/15991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated (e769ec7b964 -> 3d8b0ffae84)

2024-03-20 Thread kfaraz
This is an automated email from the ASF dual-hosted git repository. kfaraz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from e769ec7b964 Web console: fix Azure icon not rendering (#16173) add 3d8b0ffae84 Add indexer level task metrics to

Re: [PR] Add indexer level task metrics to provide more visibility in the task distribution (druid)

2024-03-20 Thread via GitHub
kfaraz commented on PR #15991: URL: https://github.com/apache/druid/pull/15991#issuecomment-2011258164 Thanks a lot for the fix, @rbankar7 ! Congrats on your first commit to Apache Druid!  -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix mark segment unused when overshadowed by zero replica segment (druid)

2024-03-20 Thread via GitHub
kfaraz commented on PR #16181: URL: https://github.com/apache/druid/pull/16181#issuecomment-2011255081 > Could you please share when should a segment only on the brokers, but not on any of the historicals, overshadow segments? This could be possible for a broadcast segment that is

Re: [PR] Geo spatial interfaces (druid)

2024-03-20 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16029: URL: https://github.com/apache/druid/pull/16029#discussion_r1533281045 ## processing/src/test/java/org/apache/druid/collections/spatial/search/RadiusBoundTest.java: ## @@ -48,4 +85,54 @@ new

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533189728 ## processing/src/main/java/org/apache/druid/query/filter/TypedInFilter.java: ## @@ -0,0 +1,713 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533196664 ## extensions-core/druid-ranger-security/pom.xml: ## @@ -45,6 +45,7 @@ com.amazonaws aws-java-sdk-bundle

[PR] Fix mark segment unused when overshadowed by zero replica segment (druid)

2024-03-20 Thread via GitHub
kfaraz opened a new pull request, #16181: URL: https://github.com/apache/druid/pull/16181 ### Bug In the `MarkOvershadowedSegmentsAsUnused` duty, the coordinator marks a segment as unused if it is overshadowed by a segment currently being served by a historical or broker. But it

Re: [I] Cannot connect to Apache Kafka (druid)

2024-03-20 Thread via GitHub
github-actions[bot] commented on issue #14423: URL: https://github.com/apache/druid/issues/14423#issuecomment-2010951838 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If this issue is still relevant,

Re: [PR] Compress theta sketches (druid)

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #15732: URL: https://github.com/apache/druid/pull/15732#issuecomment-2010952077 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [I] Error when push data through api (druid)

2024-03-20 Thread via GitHub
github-actions[bot] commented on issue #11035: URL: https://github.com/apache/druid/issues/11035#issuecomment-2010951782 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [I] Error when push data through api (druid)

2024-03-20 Thread via GitHub
github-actions[bot] closed issue #11035: Error when push data through api URL: https://github.com/apache/druid/issues/11035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Unifying GroupBy strategies and grouping on complex columns (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16068: URL: https://github.com/apache/druid/pull/16068#discussion_r1526860696 ## processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java: ## @@ -413,9 +414,12 @@ public static Object convertObjectToType( case

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533198022 ## processing/src/main/java/org/apache/druid/query/filter/TypedInFilter.java: ## @@ -0,0 +1,664 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533198752 ## processing/src/main/java/org/apache/druid/segment/index/semantic/ValueSetIndexes.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation

Re: [I] Wrong results for filtered aggregates when run through SQL query, this was working on 25.0.0 but found not working on latest release 29.0.0, so has broken somewhere in between (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on issue #16178: URL: https://github.com/apache/druid/issues/16178#issuecomment-2011191822 can you set `druid.sql.planner.useGroupingSetForExactDistinct` to true and see if that fixes the issue? This bug might be same as what's being discussed here -

Re: [PR] Fix mark segment unused when overshadowed by zero replica segment (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula commented on PR #16181: URL: https://github.com/apache/druid/pull/16181#issuecomment-2011211393 > the coordinator marks a segment as unused if it is overshadowed by a segment currently being served by a historical or broker. Could you please share when should a

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533189333 ## processing/src/main/java/org/apache/druid/query/filter/TypedInFilter.java: ## @@ -0,0 +1,713 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533188709 ## processing/src/main/java/org/apache/druid/segment/nested/ScalarDoubleColumnAndIndexSupplier.java: ## @@ -258,6 +265,70 @@ public T

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533188709 ## processing/src/main/java/org/apache/druid/segment/nested/ScalarDoubleColumnAndIndexSupplier.java: ## @@ -258,6 +265,70 @@ public T

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533200679 ## processing/src/main/java/org/apache/druid/segment/nested/ScalarDoubleColumnAndIndexSupplier.java: ## @@ -258,6 +265,70 @@ public T

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533179974 ## sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/ArrayOverlapOperatorConversion.java: ## @@ -127,7 +130,7 @@ public DimFilter toDruidFilter(

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533193264 ## processing/src/main/java/org/apache/druid/query/filter/TypedInFilter.java: ## @@ -0,0 +1,713 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533183035 ## processing/src/main/java/org/apache/druid/segment/index/semantic/ValueSetIndexes.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533196315 ## processing/src/test/java/org/apache/druid/segment/filter/TypedInFilterTests.java: ## @@ -0,0 +1,509 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533181036 ## sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/ArrayOverlapOperatorConversion.java: ## @@ -127,7 +130,7 @@ public DimFilter toDruidFilter(

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533194261 ## processing/src/main/java/org/apache/druid/query/filter/TypedInFilter.java: ## @@ -0,0 +1,713 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [I] Wrong results for filtered aggregates when run through SQL query, this was working on 25.0.0 but found not working on latest release 29.0.0, so has broken somewhere in between (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on issue #16178: URL: https://github.com/apache/druid/issues/16178#issuecomment-2011192798 Though I am surprised how did this query even work in 25.0.0 without you setting `druid.sql.planner.useGroupingSetForExactDistinct`. It would have failed outright. --

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533190347 ## processing/src/main/java/org/apache/druid/query/filter/TypedInFilter.java: ## @@ -0,0 +1,713 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533197171 ## processing/src/main/java/org/apache/druid/query/filter/TypedInFilter.java: ## @@ -0,0 +1,664 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1533197382 ## processing/src/main/java/org/apache/druid/query/filter/TypedInFilter.java: ## @@ -0,0 +1,664 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Introduce Segment Schema Publishing and Polling for Efficient Datasource Schema Building (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15817: URL: https://github.com/apache/druid/pull/15817#discussion_r1531560103 ## server/src/main/java/org/apache/druid/segment/metadata/SegmentSchemaManager.java: ## @@ -0,0 +1,387 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add versions to `markUsed` and `markUnused` APIs (druid)

2024-03-20 Thread via GitHub
kfaraz commented on code in PR #16141: URL: https://github.com/apache/druid/pull/16141#discussion_r1531541234 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java: ## @@ -312,53 +327,91 @@ public int markSegments(final Collection segmentIds, final

Re: [PR] Check for handoff of upgraded segments (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula commented on code in PR #16162: URL: https://github.com/apache/druid/pull/16162#discussion_r1531559028 ## server/src/test/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorDriverFailTest.java: ## @@ -221,10 +221,8 @@ public void

Re: [PR] add curl (druid)

2024-03-20 Thread via GitHub
LakshSingla commented on code in PR #16176: URL: https://github.com/apache/druid/pull/16176#discussion_r1531748779 ## distribution/docker/Dockerfile: ## @@ -86,6 +91,7 @@ COPY distribution/docker/druid.sh /druid.sh COPY distribution/docker/peon.sh /peon.sh COPY

Re: [PR] pacj4: add UserProfile attributes to AuthenticationResult context (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on code in PR #16109: URL: https://github.com/apache/druid/pull/16109#discussion_r1531801805 ## extensions-core/druid-pac4j/src/main/java/org/apache/druid/security/pac4j/Pac4jFilter.java: ## @@ -96,24 +97,24 @@ public void doFilter(ServletRequest

Re: [PR] INSERT/REPLACE dimension target column types are validated against source input expressions (druid)

2024-03-20 Thread via GitHub
kgyrtkirk commented on code in PR #15962: URL: https://github.com/apache/druid/pull/15962#discussion_r1531846727 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java: ## @@ -226,6 +235,20 @@ public void validateInsert(final SqlInsert insert) //

Re: [PR] add curl (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on PR #16176: URL: https://github.com/apache/druid/pull/16176#issuecomment-2009192284 Why do you need curl in this image and how much does the size increase post adding curl? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1531931991 ## processing/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java: ## @@ -815,6 +820,15 @@ public PartitionHolder getPartitionHolder()

Re: [PR] Resolve a bug where datasketches would not downsample sketches sufficiently (druid)

2024-03-20 Thread via GitHub
LakshSingla commented on code in PR #16119: URL: https://github.com/apache/druid/pull/16119#discussion_r1531740540 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/statistics/ClusterByStatisticsCollectorImpl.java: ## @@ -443,7 +449,9 @@ void downSample()

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
kfaraz commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1531914003 ## processing/src/main/java/org/apache/druid/timeline/partition/PartitionHolder.java: ## @@ -60,14 +68,24 @@ public PartitionHolder(List> initialChunks) } }

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
kfaraz commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1531915288 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataManager.java: ## @@ -1072,12 +1074,19 @@ public DataSegment map(int index, ResultSet r,

Re: [PR] Resolve a bug where datasketches would not downsample sketches sufficiently (druid)

2024-03-20 Thread via GitHub
LakshSingla commented on code in PR #16119: URL: https://github.com/apache/druid/pull/16119#discussion_r1531740540 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/statistics/ClusterByStatisticsCollectorImpl.java: ## @@ -443,7 +449,9 @@ void downSample()

Re: [PR] Check for handoff of upgraded segments (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on code in PR #16162: URL: https://github.com/apache/druid/pull/16162#discussion_r153188 ## server/src/main/java/org/apache/druid/segment/realtime/appenderator/SegmentsAndCommitMetadata.java: ## @@ -20,28 +20,50 @@ package

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1531932564 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataManager.java: ## @@ -1072,12 +1074,19 @@ public DataSegment map(int index, ResultSet r,

Re: [PR] INSERT/REPLACE dimension target column types are validated against source input expressions (druid)

2024-03-20 Thread via GitHub
kgyrtkirk commented on code in PR #15962: URL: https://github.com/apache/druid/pull/15962#discussion_r1531846727 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java: ## @@ -226,6 +235,20 @@ public void validateInsert(final SqlInsert insert) //

[I] Kafka ingestion breaks when headers miss values (druid)

2024-03-20 Thread via GitHub
daniel-imgarena opened a new issue, #16177: URL: https://github.com/apache/druid/issues/16177 Please provide a detailed title (e.g. "Broker crashes when using TopN query with Bound filter" instead of just "Broker crashes"). ### Affected Version 28.0.1, at least ###

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
kfaraz commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1531913409 ## processing/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java: ## @@ -815,6 +820,15 @@ public PartitionHolder getPartitionHolder() return

Re: [PR] Check for handoff of upgraded segments (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on PR #16162: URL: https://github.com/apache/druid/pull/16162#issuecomment-2009090491 what does `original` segment mean here? can you please elaborate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Improve worst-case performance of LIKE filters by 20x (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on PR #16153: URL: https://github.com/apache/druid/pull/16153#issuecomment-2009025245 https://github.com/spring-projects/spring-framework/blob/main/spring-expression/src/main/java/org/springframework/expression/spel/ast/OperatorMatches.java#L128 seems like a

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
kfaraz commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1531581102 ## processing/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java: ## @@ -450,6 +450,18 @@ private Map> computeOvershadowedPartit return

[PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-03-20 Thread via GitHub
adarshsanjeev opened a new pull request, #16175: URL: https://github.com/apache/druid/pull/16175 MSQ chooses the shard spec based on certain criteria. However, this criteria is not very transparent to the user. The only way to find the shard spec which was chosen is to search for a segment

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1531605233 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataManager.java: ## @@ -1063,12 +1063,20 @@ public DataSegment map(int index, ResultSet r,

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1531605630 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataManager.java: ## @@ -1063,12 +1063,20 @@ public DataSegment map(int index, ResultSet r,

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1531604207 ## processing/src/main/java/org/apache/druid/timeline/partition/PartitionHolder.java: ## @@ -34,16 +34,26 @@ public class PartitionHolder> implements

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15952: URL: https://github.com/apache/druid/pull/15952#discussion_r1531604772 ## processing/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java: ## @@ -815,6 +832,11 @@ public PartitionHolder getPartitionHolder()

[PR] add curl (druid)

2024-03-20 Thread via GitHub
ran1995ml opened a new pull request, #16176: URL: https://github.com/apache/druid/pull/16176 Fixes #. ### Description Fixed the bug ... Renamed the class ... Added a forbidden-apis entry ...

Re: [PR] INSERT/REPLACE dimension target column types are validated against source input expressions (druid)

2024-03-20 Thread via GitHub
kgyrtkirk commented on code in PR #15962: URL: https://github.com/apache/druid/pull/15962#discussion_r1531710389 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java: ## @@ -226,6 +235,20 @@ public void validateInsert(final SqlInsert insert) //

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1515960661 ## processing/src/main/java/org/apache/druid/query/filter/TypedInFilter.java: ## @@ -0,0 +1,664 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] add new typed in filter (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1512205368 ## extensions-core/druid-ranger-security/pom.xml: ## @@ -45,6 +45,7 @@ com.amazonaws aws-java-sdk-bundle

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula merged PR #15952: URL: https://github.com/apache/druid/pull/15952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Optimize isOvershadowed when there is a unique minor version for an interval (#15952)

2024-03-20 Thread amatya
This is an automated email from the ASF dual-hosted git repository. amatya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 488d376209f Optimize isOvershadowed when there

svn commit: r68024 - /dev/druid/29.0.1-rc1/

2024-03-20 Thread karan
Author: karan Date: Wed Mar 20 14:50:40 2024 New Revision: 68024 Log: add 29.0.1-rc1 artifacts Added: dev/druid/29.0.1-rc1/ dev/druid/29.0.1-rc1/apache-druid-29.0.1-bin.tar.gz (with props) dev/druid/29.0.1-rc1/apache-druid-29.0.1-bin.tar.gz.asc

Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

2024-03-20 Thread via GitHub
AmatyaAvadhanula commented on PR #15952: URL: https://github.com/apache/druid/pull/15952#issuecomment-2009643935 Thank you for the review @kfaraz! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Kafka ingestion breaks when headers miss values (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on issue #16177: URL: https://github.com/apache/druid/issues/16177#issuecomment-2009731844 Yes. The code should just add `null` I suppose. Is it something you will be interested in fixing? Should be a simple fix in this class -

Re: [I] Wrong results for filtered aggregates when run through SQL query, this was working on 25.0.0 but found not working on latest release 29.0.0, so has broken somewhere in between (druid)

2024-03-20 Thread via GitHub
abhishekagarwal87 commented on issue #16178: URL: https://github.com/apache/druid/issues/16178#issuecomment-2010029155 was the `approximate distinct count` turned off when you ran this query? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Wrong results for filtered aggregates when run through SQL query, this was working on 25.0.0 but found not working on latest release 29.0.0, so has broken somewhere in between (druid)

2024-03-20 Thread via GitHub
stamboli commented on issue #16178: URL: https://github.com/apache/druid/issues/16178#issuecomment-2010033904 Yes In environment file I have druid_sql_planner_useApproximateCountDistinct=false From: Abhishek Agarwal ***@***.***> Sent: 20

[I] Unconditiional join query with SQL which was working on 25.0.0 not working on 29.0.0 it must have broken somewhere in between (druid)

2024-03-20 Thread via GitHub
stamboli opened a new issue, #16179: URL: https://github.com/apache/druid/issues/16179 ### Affected Version 29.0.0 ### Description [SampleSaleData.csv](https://github.com/apache/druid/files/14670155/SampleSaleData.csv)

Re: [I] Deprecate Netty3 in Druid (druid)

2024-03-20 Thread via GitHub
dpippenger commented on issue #15651: URL: https://github.com/apache/druid/issues/15651#issuecomment-2010181322 It would help to have some clarification from the project maintainers what the plan is for netty3 since the included 3.10.6 is no longer maintained by the netty developers and

[I] Wrong results for filtered aggregates, this was working on 25.0.0 but found not working on latest release 29.0.0, so has broken somewhere in between (druid)

2024-03-20 Thread via GitHub
stamboli opened a new issue, #16178: URL: https://github.com/apache/druid/issues/16178 [SampleSaleData.json](https://github.com/apache/druid/files/14668899/SampleSaleData.json) [SampleSaleData.csv](https://github.com/apache/druid/files/14668912/SampleSaleData.csv) ###

Re: [I] Wrong results for filtered aggregates when run through SQL query, this was working on 25.0.0 but found not working on latest release 29.0.0, so has broken somewhere in between (druid)

2024-03-20 Thread via GitHub
stamboli commented on issue #16178: URL: https://github.com/apache/druid/issues/16178#issuecomment-2010187792 [environment.txt](https://github.com/apache/druid/files/14670451/environment.txt) -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Web console: only pick kafka input format by default when needed (druid)

2024-03-20 Thread via GitHub
vogievetsky opened a new pull request, #16180: URL: https://github.com/apache/druid/pull/16180 Changes the input format guesser to, instead of always picking the kafka input format for a kafka source, to only pick it if it detects meaningful info in the kafka sample. Meaningful info

Re: [PR] Web console: fix Azure icon not rendering (druid)

2024-03-20 Thread via GitHub
vogievetsky merged PR #16173: URL: https://github.com/apache/druid/pull/16173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Web console: fix Azure icon not rendering (#16173)

2024-03-20 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new e769ec7b964 Web console: fix Azure icon not