[PR] Fixes for LastVectorAggregator and FirstVectorAggregator (druid)

2024-04-02 Thread via GitHub
LakshSingla opened a new pull request, #16230: URL: https://github.com/apache/druid/pull/16230 ### Description This PR fixes the first and last vector aggregators and improves their readability. Following changes are introduced * The folding is broken in the vectorized

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-02 Thread via GitHub
gargvishesh commented on PR #15965: URL: https://github.com/apache/druid/pull/15965#issuecomment-2031140076 @cryptoe @kfaraz Tested it on local cluster. Storing compaction state and triggering compaction only if states differ are working as expected. However, the defaults for

[PR] Adding druid 29.0.1 src website [druid-website-src]

2024-04-02 Thread via GitHub
cryptoe opened a new pull request, #470: URL: https://github.com/apache/druid-website-src/pull/470 Adding druid 29.0.1 src website -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Handle task location fetch from overlord during rolling upgrades (druid)

2024-04-02 Thread via GitHub
AmatyaAvadhanula opened a new pull request, #16227: URL: https://github.com/apache/druid/pull/16227 ### Bug: https://github.com/apache/druid/pull/15724 - introduced a bug where a rolling upgrade would cause all task locations returned by the Overlord on an older version to be

(druid) branch master updated: Handling nil selector column in vector math processors (#16128)

2024-04-02 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 26f9b174dee Handling nil selector column in

Re: [PR] Handling nil selector column in vector math processors (druid)

2024-04-02 Thread via GitHub
clintropolis merged PR #16128: URL: https://github.com/apache/druid/pull/16128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Adding site for 29.0.1 release [druid-website]

2024-04-02 Thread via GitHub
cryptoe commented on PR #270: URL: https://github.com/apache/druid-website/pull/270#issuecomment-2031727921 Reference src building https://github.com/apache/druid-website-src/pull/470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Adding site for 29.0.1 release [druid-website]

2024-04-02 Thread via GitHub
cryptoe opened a new pull request, #270: URL: https://github.com/apache/druid-website/pull/270 Adding site for 29.0.1 release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Use created time from metadata store in the method to list multiple active tasks (druid)

2024-04-02 Thread via GitHub
AmatyaAvadhanula opened a new pull request, #16228: URL: https://github.com/apache/druid/pull/16228 ### Description The web-console of getTasks API can return incorrect created times and durations afte the Overlord restarts. This is because we populate the field with the time at

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-02 Thread via GitHub
cryptoe commented on PR #15965: URL: https://github.com/apache/druid/pull/15965#issuecomment-2031636201 > ested it on local cluster. Storing compaction state and triggering compaction only if states differ are working as expected. However, the defaults for DynamicPartitionsSpec weren't

Re: [PR] Handle task location fetch from overlord during rolling upgrades (druid)

2024-04-02 Thread via GitHub
kfaraz commented on PR #16227: URL: https://github.com/apache/druid/pull/16227#issuecomment-2032258149 I don't think it is desirable to fall back to another API within the OverlordClientImpl. The OverlordClient methods are meant to have 1-to-1 correspondence with the Overlord APIs.

[PR] Restore context flag for window functions (druid)

2024-04-02 Thread via GitHub
somu-imply opened a new pull request, #16229: URL: https://github.com/apache/druid/pull/16229 This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the

(druid) branch master updated (26f9b174dee -> 9b52c909e08)

2024-04-02 Thread zachjsh
This is an automated email from the ASF dual-hosted git repository. zachjsh pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 26f9b174dee Handling nil selector column in vector math processors (#16128) add 9b52c909e08 fix complex types

Re: [PR] fix complex types returning UNKNOWN as their SQL type inference (druid)

2024-04-02 Thread via GitHub
zachjsh merged PR #16216: URL: https://github.com/apache/druid/pull/16216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] only create `sqlSegmentsMetadataManager` once to speed up test (druid)

2024-04-02 Thread via GitHub
TestBoost closed pull request #15557: only create `sqlSegmentsMetadataManager` once to speed up test URL: https://github.com/apache/druid/pull/15557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] only create `sqlSegmentsMetadataManager` once to speed up test (druid)

2024-04-02 Thread via GitHub
TestBoost commented on PR #15557: URL: https://github.com/apache/druid/pull/15557#issuecomment-2033192292 Thank you so much for letting me know!!! I can close this pull request now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix name of combining filtered aggregator factory. (druid)

2024-04-02 Thread via GitHub
gianm merged PR #16224: URL: https://github.com/apache/druid/pull/16224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Fix name of combining filtered aggregator factory. (#16224)

2024-04-02 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new b0ca06f8cd9 Fix name of combining filtered

Re: [PR] Update error messages when supervisor's checkpoint state is invalid (druid)

2024-04-02 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16208: URL: https://github.com/apache/druid/pull/16208#discussion_r1548848130 ## server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java: ## @@ -2415,25 +2410,24 @@

Re: [PR] Use created time from metadata store to list multiple active tasks (druid)

2024-04-02 Thread via GitHub
AmatyaAvadhanula merged PR #16228: URL: https://github.com/apache/druid/pull/16228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated (b0ca06f8cd9 -> 218513ad559)

2024-04-02 Thread amatya
This is an automated email from the ASF dual-hosted git repository. amatya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from b0ca06f8cd9 Fix name of combining filtered aggregator factory. (#16224) add 218513ad559 Use created time from

Re: [PR] Use created time from metadata store to list multiple active tasks (druid)

2024-04-02 Thread via GitHub
AmatyaAvadhanula commented on PR #16228: URL: https://github.com/apache/druid/pull/16228#issuecomment-2033467666 Thank you for the review @kfaraz! Merged as the failing checks were unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Update error messages when supervisor's checkpoint state is invalid (druid)

2024-04-02 Thread via GitHub
kfaraz commented on code in PR #16208: URL: https://github.com/apache/druid/pull/16208#discussion_r1548866838 ## server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java: ## @@ -2395,17 +2388,19 @@ protected DataStoreMetadataUpdateResult

Re: [PR] Add read timeout for getting records when sampling a stream (druid)

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #15035: URL: https://github.com/apache/druid/pull/15035#issuecomment-2033314171 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] Add read timeout for getting records when sampling a stream (druid)

2024-04-02 Thread via GitHub
github-actions[bot] closed pull request #15035: Add read timeout for getting records when sampling a stream URL: https://github.com/apache/druid/pull/15035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Integrate catalog schema validation into planner -WIP (druid)

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #15711: URL: https://github.com/apache/druid/pull/15711#issuecomment-2033314331 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Validate datasource retention rules: Reject rules that fully contain subsequent rules' interval (druid)

2024-04-02 Thread via GitHub
github-actions[bot] closed pull request #15015: Validate datasource retention rules: Reject rules that fully contain subsequent rules' interval URL: https://github.com/apache/druid/pull/15015 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Validate datasource retention rules: Reject rules that fully contain subsequent rules' interval (druid)

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #15015: URL: https://github.com/apache/druid/pull/15015#issuecomment-2033314137 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] provide a response description for supervisor status api (druid)

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #15031: URL: https://github.com/apache/druid/pull/15031#issuecomment-2033314153 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] provide a response description for supervisor status api (druid)

2024-04-02 Thread via GitHub
github-actions[bot] closed pull request #15031: provide a response description for supervisor status api URL: https://github.com/apache/druid/pull/15031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

(druid-website) branch asf-site updated (a50d4c9cd -> 1d79dc17a)

2024-04-02 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/druid-website.git from a50d4c9cd Merge pull request #268 from ektravel/asf-site add 14c2b5e79 Adding site for 29.0.1 release

Re: [PR] Adding site for 29.0.1 release [druid-website]

2024-04-02 Thread via GitHub
cryptoe merged PR #270: URL: https://github.com/apache/druid-website/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid-website) 01/01: Merge pull request #270 from cryptoe/apache/asf-site

2024-04-02 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/druid-website.git commit 1d79dc17a813bdcd276b76ab8edb961a1870b273 Merge: a50d4c9cd 14c2b5e79 Author: Karan Kumar AuthorDate: Wed Apr 3

Re: [PR] Handle task location fetch from overlord during rolling upgrades (druid)

2024-04-02 Thread via GitHub
AmatyaAvadhanula commented on PR #16227: URL: https://github.com/apache/druid/pull/16227#issuecomment-2033506147 > It would make more sense to have the fallback logic in the specific task service locator class. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Handle task location fetch from overlord during rolling upgrades (druid)

2024-04-02 Thread via GitHub
AmatyaAvadhanula commented on PR #16227: URL: https://github.com/apache/druid/pull/16227#issuecomment-2033507982 > It would make more sense to have the fallback logic in the specific task service locator class. Would it be ok to add a parameter within the Overlord client to fallback

Re: [PR] Handle task location fetch from overlord during rolling upgrades (druid)

2024-04-02 Thread via GitHub
kfaraz commented on PR #16227: URL: https://github.com/apache/druid/pull/16227#issuecomment-2033513702 > Would it be ok to add a parameter within the Overlord client to fallback to the older API? The locations are needed not only in SpecificTaskServiceLocator but also

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-02 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1548909835 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSeekableStreamEndSequenceNumbers.java: ## @@ -0,0 +1,126 @@ +/* + *

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-02 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1548910010 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSeekableStreamStartSequenceNumbers.java: ## @@ -0,0 +1,158 @@ +/* + *

Re: [PR] Fix OverlordClient to read reports as a concrete `ReportMap` object instead of a generic map (druid)

2024-04-02 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16226: URL: https://github.com/apache/druid/pull/16226#discussion_r1548916228 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -1683,21 +1684,29

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-02 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1548924208 ## extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/KafkaDataSourceMetadataTest.java: ## @@ -203,19 +462,60