[GitHub] jihoonson commented on issue #6155: Fix three bugs with segment publishing.

2018-08-14 Thread GitBox
jihoonson commented on issue #6155: Fix three bugs with segment publishing. URL: https://github.com/apache/incubator-druid/pull/6155#issuecomment-413089530 Hmm, now some unit tests are failing and looks legitimate. ``` Failed tests:

[GitHub] jihoonson commented on issue #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies

2018-08-14 Thread GitBox
jihoonson commented on issue #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies URL: https://github.com/apache/incubator-druid/pull/6173#issuecomment-413089187 @gianm sounds good to me.

[GitHub] kaijianding opened a new pull request #6178: trigger clean dir when unzip fails with IOException

2018-08-14 Thread GitBox
kaijianding opened a new pull request #6178: trigger clean dir when unzip fails with IOException URL: https://github.com/apache/incubator-druid/pull/6178 SegmentManager, SegmentLoaderLocalCacheManager, and many pullers catch IOException and wrap IOException as SegmentLoadingException, and

[GitHub] gianm opened a new issue #6177: TimeBoundary, DataSourceMetadata filterSegments flawed with overlapping segments

2018-08-14 Thread GitBox
gianm opened a new issue #6177: TimeBoundary, DataSourceMetadata filterSegments flawed with overlapping segments URL: https://github.com/apache/incubator-druid/issues/6177 The "interval" on a LogicalSegment corresponds to the timeline object holder interval, meaning that with overlapping

[GitHub] gianm commented on issue #6155: Fix three bugs with segment publishing.

2018-08-14 Thread GitBox
gianm commented on issue #6155: Fix three bugs with segment publishing. URL: https://github.com/apache/incubator-druid/pull/6155#issuecomment-413061200 OMG, sorry, I'll check more thoroughly before I push again. This is an

[GitHub] jihoonson commented on issue #6155: Fix three bugs with segment publishing.

2018-08-14 Thread GitBox
jihoonson commented on issue #6155: Fix three bugs with segment publishing. URL: https://github.com/apache/incubator-druid/pull/6155#issuecomment-413060382 There are still some build failures. ``` [ERROR] COMPILATION ERROR : [ERROR]

[GitHub] gianm opened a new issue #6176: CuratorInventoryManager may not report inventory as initialized

2018-08-14 Thread GitBox
gianm opened a new issue #6176: CuratorInventoryManager may not report inventory as initialized URL: https://github.com/apache/incubator-druid/issues/6176 The reason is unclear, but we've seen brokers running 0.12.1 fail to report "Inventory Initialized" events even after running for long

[incubator-druid] branch master updated: update sigar link (#6175)

2018-08-14 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new f447b78 update sigar link (#6175)

[GitHub] gianm commented on issue #6155: Fix three bugs with segment publishing.

2018-08-14 Thread GitBox
gianm commented on issue #6155: Fix three bugs with segment publishing. URL: https://github.com/apache/incubator-druid/pull/6155#issuecomment-413052577 @jihoonson thanks, I pushed again. This is an automated message from the

[GitHub] gianm commented on a change in pull request #6155: Fix three bugs with segment publishing.

2018-08-14 Thread GitBox
gianm commented on a change in pull request #6155: Fix three bugs with segment publishing. URL: https://github.com/apache/incubator-druid/pull/6155#discussion_r210139522 ## File path: server/src/main/java/io/druid/segment/realtime/appenderator/BaseAppenderatorDriver.java

[GitHub] gianm commented on a change in pull request #6155: Fix three bugs with segment publishing.

2018-08-14 Thread GitBox
gianm commented on a change in pull request #6155: Fix three bugs with segment publishing. URL: https://github.com/apache/incubator-druid/pull/6155#discussion_r210139596 ## File path: server/src/main/java/io/druid/metadata/IndexerSQLMetadataStorageCoordinator.java ## @@

[GitHub] Caroline1000 opened a new pull request #6175: update sigar link

2018-08-14 Thread GitBox
Caroline1000 opened a new pull request #6175: update sigar link URL: https://github.com/apache/incubator-druid/pull/6175 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] gianm commented on a change in pull request #6155: Fix three bugs with segment publishing.

2018-08-14 Thread GitBox
gianm commented on a change in pull request #6155: Fix three bugs with segment publishing. URL: https://github.com/apache/incubator-druid/pull/6155#discussion_r210139396 ## File path: server/src/main/java/io/druid/metadata/IndexerSQLMetadataStorageCoordinator.java ## @@

[GitHub] jon-wei edited a comment on issue #6076: Mutual TLS support

2018-08-14 Thread GitBox
jon-wei edited a comment on issue #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#issuecomment-413040496 I updated the patch with the following: - Added mutual TLS to the integration tests. All druid services will have both plaintext and TLS port

[GitHub] fjy commented on issue #6076: Mutual TLS support

2018-08-14 Thread GitBox
fjy commented on issue #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#issuecomment-413040567  This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] jon-wei commented on issue #6076: Mutual TLS support

2018-08-14 Thread GitBox
jon-wei commented on issue #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#issuecomment-413040496 I updated the patch with the following: - Added mutual TLS to the integration tests. All druid services will have both plaintext and TLS port enabled with

[GitHub] jihoonson closed pull request #6159: fix compress fail when file size is Integer.MAX_VALUE

2018-08-14 Thread GitBox
jihoonson closed pull request #6159: fix compress fail when file size is Integer.MAX_VALUE URL: https://github.com/apache/incubator-druid/pull/6159 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jihoonson commented on issue #6159: fix compress fail when file size is Integer.MAX_VALUE

2018-08-14 Thread GitBox
jihoonson commented on issue #6159: fix compress fail when file size is Integer.MAX_VALUE URL: https://github.com/apache/incubator-druid/pull/6159#issuecomment-413033275 The last travis job has actually succeeded: https://travis-ci.org/apache/incubator-druid/jobs/415334532. I'm merging

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-14 Thread GitBox
himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r210072090 ## File path: processing/src/main/java/io/druid/segment/data/codecs/ints/RunLengthBytePackedIntFormEncoder.java

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-14 Thread GitBox
himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r210070343 ## File path: processing/src/main/java/io/druid/segment/data/codecs/ints/RunLengthBytePackedIntFormEncoder.java

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-14 Thread GitBox
himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r210072506 ## File path: processing/src/main/java/io/druid/segment/data/codecs/ints/RunLengthBytePackedIntFormEncoder.java

[GitHub] himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-14 Thread GitBox
himanshug commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r210107245 ## File path: processing/src/main/java/io/druid/segment/data/codecs/ints/RunLengthBytePackedIntFormEncoder.java

[GitHub] samarthjain commented on issue #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies

2018-08-14 Thread GitBox
samarthjain commented on issue #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies URL: https://github.com/apache/incubator-druid/pull/6173#issuecomment-413026337 Thanks for taking a look, @jihoonson. I have updated the PR

[GitHub] jihoonson commented on a change in pull request #6158: Make time-related variables more readable

2018-08-14 Thread GitBox
jihoonson commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210107682 ## File path:

[GitHub] jihoonson commented on a change in pull request #6158: Make time-related variables more readable

2018-08-14 Thread GitBox
jihoonson commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210107984 ## File path:

[GitHub] jihoonson commented on a change in pull request #6158: Make time-related variables more readable

2018-08-14 Thread GitBox
jihoonson commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210107813 ## File path:

[GitHub] jihoonson commented on a change in pull request #6158: Make time-related variables more readable

2018-08-14 Thread GitBox
jihoonson commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210107756 ## File path:

[GitHub] jihoonson commented on a change in pull request #6158: Make time-related variables more readable

2018-08-14 Thread GitBox
jihoonson commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210108444 ## File path: processing/src/test/java/io/druid/query/AsyncQueryRunnerTest.java ## @@ -38,7

[GitHub] jihoonson commented on issue #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies

2018-08-14 Thread GitBox
jihoonson commented on issue #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies URL: https://github.com/apache/incubator-druid/pull/6173#issuecomment-413019439 Hi @samarthjain, thank you for the PR. Would you add some more details

[GitHub] pdeva commented on issue #6171: hetrogenous peon configurations

2018-08-14 Thread GitBox
pdeva commented on issue #6171: hetrogenous peon configurations URL: https://github.com/apache/incubator-druid/issues/6171#issuecomment-412990974 >@gianm thanks for the comment but not sure about taskResource. AFAIK, processing threads are used for query processing in peons. Does

[GitHub] jihoonson closed issue #6171: hetrogenous peon configurations

2018-08-14 Thread GitBox
jihoonson closed issue #6171: hetrogenous peon configurations URL: https://github.com/apache/incubator-druid/issues/6171 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] jihoonson commented on issue #6171: hetrogenous peon configurations

2018-08-14 Thread GitBox
jihoonson commented on issue #6171: hetrogenous peon configurations URL: https://github.com/apache/incubator-druid/issues/6171#issuecomment-412975313 @himanshug thanks, good to know. I'm closing this. This is an automated

[GitHub] pdeva edited a comment on issue #6172: nodes should allow draining

2018-08-14 Thread GitBox
pdeva edited a comment on issue #6172: nodes should allow draining URL: https://github.com/apache/incubator-druid/issues/6172#issuecomment-412955648 @gianm ref the druid-dev sync conversation: - neither google cloud nor azure load balancers have the ability to check for a file as

[GitHub] himanshug commented on issue #6171: hetrogenous peon configurations

2018-08-14 Thread GitBox
himanshug commented on issue #6171: hetrogenous peon configurations URL: https://github.com/apache/incubator-druid/issues/6171#issuecomment-412949805 @pdeva actually all tasks are capable of taking java opts in task def in the "context" e.g. ``` {.. .. "context": {

[GitHub] pdeva opened a new issue #6172: nodes should allow draining

2018-08-14 Thread GitBox
pdeva opened a new issue #6172: nodes should allow draining URL: https://github.com/apache/incubator-druid/issues/6172 currently individual nodes have no concept of draining. this means when updating the cluster, as you take down nodes, the queries in progress will fail. similarly,

[GitHub] NextSunrises closed issue #5145: Hadoop Index Task Fail

2018-08-14 Thread GitBox
NextSunrises closed issue #5145: Hadoop Index Task Fail URL: https://github.com/apache/incubator-druid/issues/5145 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] Harish346 commented on issue #6113: Inserting Nested Json into Druid

2018-08-14 Thread GitBox
Harish346 commented on issue #6113: Inserting Nested Json into Druid URL: https://github.com/apache/incubator-druid/issues/6113#issuecomment-412824516 hi @gianm can you help me in this? This is an automated message from the

[GitHub] asdf2014 edited a comment on issue #5976: Update license headers.

2018-08-14 Thread GitBox
asdf2014 edited a comment on issue #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-412790274 Hi, @gianm . Maybe we should update the [wikipedia](https://en.wikipedia.org/wiki/Druid_(open-source_data_store)) page of Druid too..

[GitHub] asdf2014 edited a comment on issue #5976: Update license headers.

2018-08-14 Thread GitBox
asdf2014 edited a comment on issue #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-412790274 Hi, @gianm . Maybe we should update the wikipedia page of Druid too..

[GitHub] asdf2014 commented on issue #5976: Update license headers.

2018-08-14 Thread GitBox
asdf2014 commented on issue #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-412790274 Hi, @gianm . Maybe we should update the wikipedia page of Druid too..

[GitHub] asdf2014 commented on a change in pull request #6156: New doc fixes

2018-08-14 Thread GitBox
asdf2014 commented on a change in pull request #6156: New doc fixes URL: https://github.com/apache/incubator-druid/pull/6156#discussion_r209840771 ## File path: docs/content/tutorials/tutorial-compaction.md ## @@ -31,7 +31,7 @@ There will be 24 segments for this

[GitHub] jon-wei commented on a change in pull request #6156: New doc fixes

2018-08-14 Thread GitBox
jon-wei commented on a change in pull request #6156: New doc fixes URL: https://github.com/apache/incubator-druid/pull/6156#discussion_r209838391 ## File path: docs/content/tutorials/tutorial-compaction.md ## @@ -31,7 +31,7 @@ There will be 24 segments for this datasource,