[GitHub] kamaci opened a new issue #7029: Indexing Arbitrary Key/Value Data

2019-02-06 Thread GitBox
kamaci opened a new issue #7029: Indexing Arbitrary Key/Value Data URL: https://github.com/apache/incubator-druid/issues/7029 I can index such data with Druid: `{"ts":"2018-01-01T02:35:45Z","appToken":"guid", "eventName":"app-open", "key1":"value1"} ` via this configuration:

[GitHub] clintropolis opened a new pull request #7028: add license checker to web-console

2019-02-06 Thread GitBox
clintropolis opened a new pull request #7028: add license checker to web-console URL: https://github.com/apache/incubator-druid/pull/7028 This PR modifies `druid-console` to add a 'dev dependency' to a lib called `license-checker` and adds a `check-licenses` npm "script" that is run by mave

[GitHub] kamaci opened a new issue #7027: Auto Detection of Field Types

2019-02-06 Thread GitBox
kamaci opened a new issue #7027: Auto Detection of Field Types URL: https://github.com/apache/incubator-druid/issues/7027 I can define auto type detection for timestamp as follows: ``` "timestampSpec" : { "format" : "auto", "column" : "ts" } ``` In simi

[GitHub] kamaci commented on a change in pull request #6939: Throw caught exception.

2019-02-06 Thread GitBox
kamaci commented on a change in pull request #6939: Throw caught exception. URL: https://github.com/apache/incubator-druid/pull/6939#discussion_r254560102 ## File path: codestyle/checkstyle.xml ## @@ -204,6 +204,12 @@ + + Review comment: chec

[GitHub] kamaci commented on issue #6930: Improper getter value is fixed.

2019-02-06 Thread GitBox
kamaci commented on issue #6930: Improper getter value is fixed. URL: https://github.com/apache/incubator-druid/pull/6930#issuecomment-461301424 CI checks are OK 👍 This is an automated message from the Apache Git Service. To

[GitHub] jon-wei edited a comment on issue #7026: [WIP] Update LICENSE and NOTICE files

2019-02-06 Thread GitBox
jon-wei edited a comment on issue #7026: [WIP] Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-druid/pull/7026#issuecomment-461297076 marking WIP, some of the "licenseFile" entries (pulled from node dependencies in web-console using a script) are not actually licens

[GitHub] jon-wei edited a comment on issue #7026: [WIP] Update LICENSE and NOTICE files

2019-02-06 Thread GitBox
jon-wei edited a comment on issue #7026: [WIP] Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-druid/pull/7026#issuecomment-461297076 marking WIP, some of the "licenseFile" entries (pulled from node dependencies in web-console using a script) are not actually licens

[GitHub] jon-wei edited a comment on issue #7026: [WIP] Update LICENSE and NOTICE files

2019-02-06 Thread GitBox
jon-wei edited a comment on issue #7026: [WIP] Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-druid/pull/7026#issuecomment-461297076 marking WIP, some of the "licenseFIle" entries (pulled from node dependencies in web-console using a script) are not actually licens

[GitHub] jon-wei commented on issue #7026: [WIP] Update LICENSE and NOTICE files

2019-02-06 Thread GitBox
jon-wei commented on issue #7026: [WIP] Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-druid/pull/7026#issuecomment-461297076 marking WIP, some of the "license files" (pulled from node dependencies in web-console using a script) are not actually license files, will

[GitHub] jon-wei opened a new pull request #7026: Update LICENSE and NOTICE files

2019-02-06 Thread GitBox
jon-wei opened a new pull request #7026: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-druid/pull/7026 Updates the LICENSE and NOTICE files in preparation for the next release. Notes: - At one point we included a modified TestNG which was mentioned in our

[GitHub] vogievetsky commented on issue #7025: Add an api to get all lookup specs

2019-02-06 Thread GitBox
vogievetsky commented on issue #7025: Add an api to get all lookup specs URL: https://github.com/apache/incubator-druid/pull/7025#issuecomment-461292764 Should this update the docs here: http://druid.io/docs/latest/querying/lookups.html ? ---

[GitHub] hpandeycodeit commented on a change in pull request #6971: Added checkstyle for "Methods starting with Capital Letters"

2019-02-06 Thread GitBox
hpandeycodeit commented on a change in pull request #6971: Added checkstyle for "Methods starting with Capital Letters" URL: https://github.com/apache/incubator-druid/pull/6971#discussion_r254546839 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java

[GitHub] jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments

2019-02-06 Thread GitBox
jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254506991 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java ## @@ -112,7 +112,7 @@

[GitHub] jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments

2019-02-06 Thread GitBox
jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254512964 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/schema/SystemSchemaTest.java ## @@ -469,7 +485,7

[GitHub] jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments

2019-02-06 Thread GitBox
jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254509876 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/schema/DruidSchemaTest.java ## @@ -239,6 +246,34

[GitHub] jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments

2019-02-06 Thread GitBox
jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254510572 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/schema/DruidSchemaTest.java ## @@ -239,6 +246,34

[GitHub] jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments

2019-02-06 Thread GitBox
jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254506974 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java ## @@ -112,7 +112,7 @@

[GitHub] jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments

2019-02-06 Thread GitBox
jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254509558 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/schema/DruidSchemaTest.java ## @@ -239,6 +246,34

[GitHub] jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments

2019-02-06 Thread GitBox
jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254509737 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/schema/DruidSchemaTest.java ## @@ -239,6 +246,34

[GitHub] jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments

2019-02-06 Thread GitBox
jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254508518 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/schema/DruidSchemaTest.java ## @@ -239,6 +246,34

[GitHub] jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments

2019-02-06 Thread GitBox
jihoonson commented on a change in pull request #6888: Fix num_rows in sys.segments URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254510463 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/schema/DruidSchemaTest.java ## @@ -239,6 +246,34

[GitHub] AlexanderSaydakov commented on issue #6581: Moments Sketch custom aggregator

2019-02-06 Thread GitBox
AlexanderSaydakov commented on issue #6581: Moments Sketch custom aggregator URL: https://github.com/apache/incubator-druid/pull/6581#issuecomment-461241638 @jon-wei you may want to update the docs for the Approximate Histogram and Druid HLL as well. ---

[GitHub] jon-wei commented on issue #6581: Moments Sketch custom aggregator

2019-02-06 Thread GitBox
jon-wei commented on issue #6581: Moments Sketch custom aggregator URL: https://github.com/apache/incubator-druid/pull/6581#issuecomment-461240192 @leerho @edgan8 I'll take care of writing the Druid doc pages based on the information you've provided, thanks a lot for the help!

[GitHub] fjy commented on issue #7025: Add an api to get all lookup specs

2019-02-06 Thread GitBox
fjy commented on issue #7025: Add an api to get all lookup specs URL: https://github.com/apache/incubator-druid/pull/7025#issuecomment-461239933 👍 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] jihoonson opened a new pull request #7025: Add an api to get all lookup specs

2019-02-06 Thread GitBox
jihoonson opened a new pull request #7025: Add an api to get all lookup specs URL: https://github.com/apache/incubator-druid/pull/7025 Currently it needs 3 APIs to retrieve all lookup specs which is not good for some use cases like UI to show all configured specs. -

[GitHub] leerho commented on issue #6581: Moments Sketch custom aggregator

2019-02-06 Thread GitBox
leerho commented on issue #6581: Moments Sketch custom aggregator URL: https://github.com/apache/incubator-druid/pull/6581#issuecomment-461234790 @jon-wei I hope that the studies that I reference in this thread as well as my concerns and @edgan8's agreement should provide sufficient informa

[GitHub] justinborromeo opened a new pull request #7024: Time Ordering Option on Small-Result-Set Scan Queries

2019-02-06 Thread GitBox
justinborromeo opened a new pull request #7024: Time Ordering Option on Small-Result-Set Scan Queries URL: https://github.com/apache/incubator-druid/pull/7024 This PR addresses point 2 of issue #6088 . For scan queries where the limit is less than a configurable threshold (default 100K),

[GitHub] jihoonson merged pull request #7018: [Backport] Add null checks in DruidSchema

2019-02-06 Thread GitBox
jihoonson merged pull request #7018: [Backport] Add null checks in DruidSchema URL: https://github.com/apache/incubator-druid/pull/7018 This is an automated message from the Apache Git Service. To respond to the message, plea

[incubator-druid] branch 0.14.0-incubating updated: Add null checks in DruidSchema (#6830) (#7018)

2019-02-06 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch 0.14.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.14.0-incubating by this push: new 4cb631d Add n

[incubator-druid] branch master updated: Improve druid.storage.sse.kms.keyId and druid.s3.protocol (#7012)

2019-02-06 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 8e3a58f Improve druid.storage.sse.k

[GitHub] jihoonson merged pull request #7012: Improve druid.storage.sse.kms.keyId and druid.s3.protocol

2019-02-06 Thread GitBox
jihoonson merged pull request #7012: Improve druid.storage.sse.kms.keyId and druid.s3.protocol URL: https://github.com/apache/incubator-druid/pull/7012 This is an automated message from the Apache Git Service. To respond to

[GitHub] justinborromeo commented on issue #7002: [Benchmarking] Call blackhole#consume() on collections instead of iterating through each element

2019-02-06 Thread GitBox
justinborromeo commented on issue #7002: [Benchmarking] Call blackhole#consume() on collections instead of iterating through each element URL: https://github.com/apache/incubator-druid/pull/7002#issuecomment-461222342 @drcrallen By lazy transforms, are you talking about how sequences are l

[GitHub] jihoonson commented on issue #6989: Behavior of index_parallel with appendToExisting=false and no bucketIntervals in GranularitySpec is surprising

2019-02-06 Thread GitBox
jihoonson commented on issue #6989: Behavior of index_parallel with appendToExisting=false and no bucketIntervals in GranularitySpec is surprising URL: https://github.com/apache/incubator-druid/issues/6989#issuecomment-461221023 @glasser > 1\. Where should tests of this new logic e

[GitHub] justinborromeo removed a comment on issue #7002: [Benchmarking] Call blackhole#consume() on collections instead of iterating through each element

2019-02-06 Thread GitBox
justinborromeo removed a comment on issue #7002: [Benchmarking] Call blackhole#consume() on collections instead of iterating through each element URL: https://github.com/apache/incubator-druid/pull/7002#issuecomment-461219288 Fair enough. If it's too risky given that we're not certain abou

[GitHub] justinborromeo commented on issue #7002: [Benchmarking] Call blackhole#consume() on collections instead of iterating through each element

2019-02-06 Thread GitBox
justinborromeo commented on issue #7002: [Benchmarking] Call blackhole#consume() on collections instead of iterating through each element URL: https://github.com/apache/incubator-druid/pull/7002#issuecomment-461219288 Fair enough. If it's too risky given that we're not certain about the c

[GitHub] jon-wei merged pull request #6986: Create Scan Benchmark

2019-02-06 Thread GitBox
jon-wei merged pull request #6986: Create Scan Benchmark URL: https://github.com/apache/incubator-druid/pull/6986 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and u

[incubator-druid] branch master updated: Create Scan Benchmark (#6986)

2019-02-06 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 6723243 Create Scan Benchmark (#6986)

[GitHub] drcrallen commented on issue #7002: [Benchmarking] Call blackhole#consume() on collections instead of iterating through each element

2019-02-06 Thread GitBox
drcrallen commented on issue #7002: [Benchmarking] Call blackhole#consume() on collections instead of iterating through each element URL: https://github.com/apache/incubator-druid/pull/7002#issuecomment-461215711 it is entirely possible that there are lazy transforms that can affect the re

[GitHub] drcrallen commented on issue #6896: Add docker container for druid

2019-02-06 Thread GitBox
drcrallen commented on issue #6896: Add docker container for druid URL: https://github.com/apache/incubator-druid/pull/6896#issuecomment-461214722 team city issues look unrelated This is an automated message from the Apache Gi

[GitHub] drcrallen commented on issue #6896: Add docker container for druid

2019-02-06 Thread GitBox
drcrallen commented on issue #6896: Add docker container for druid URL: https://github.com/apache/incubator-druid/pull/6896#issuecomment-461214041 for posterity there is a discussion on the incubator list about docker releases (only tangentially related) http://mail-archives.apache.

[GitHub] jihoonson opened a new pull request #7023: Fix filterSegments for TimeBoundary and DataSourceMetadata queries

2019-02-06 Thread GitBox
jihoonson opened a new pull request #7023: Fix filterSegments for TimeBoundary and DataSourceMetadata queries URL: https://github.com/apache/incubator-druid/pull/7023 Fixes https://github.com/apache/incubator-druid/issues/6177. --

[GitHub] clintropolis opened a new pull request #7022: [Backport] Improper equals override is fixed to prevent NullPointerException

2019-02-06 Thread GitBox
clintropolis opened a new pull request #7022: [Backport] Improper equals override is fixed to prevent NullPointerException URL: https://github.com/apache/incubator-druid/pull/7022 Backport of #6938 to 0.14.0-incubating. This

[incubator-druid] branch master updated: Improper equals override is fixed to prevent NullPointerException (#6938)

2019-02-06 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 58f9507 Improper equals override is fi

[GitHub] clintropolis merged pull request #6938: Improper equals override is fixed to prevent NullPointerException

2019-02-06 Thread GitBox
clintropolis merged pull request #6938: Improper equals override is fixed to prevent NullPointerException URL: https://github.com/apache/incubator-druid/pull/6938 This is an automated message from the Apache Git Service. To

[GitHub] jon-wei commented on issue #7015: [Issue #6967] NoClassDefFoundError when using druid-hdfs-storage

2019-02-06 Thread GitBox
jon-wei commented on issue #7015: [Issue #6967] NoClassDefFoundError when using druid-hdfs-storage URL: https://github.com/apache/incubator-druid/pull/7015#issuecomment-461207328 There are some real UT failures: ``` org.apache.druid.segment.loading.HdfsDataSegmentFinderTest Time

[GitHub] jon-wei commented on issue #6581: Moments Sketch custom aggregator

2019-02-06 Thread GitBox
jon-wei commented on issue #6581: Moments Sketch custom aggregator URL: https://github.com/apache/incubator-druid/pull/6581#issuecomment-461205513 > @jon-wei please let me know your thoughts on the best place to put this package moving forward, I am also happy keeping it in my own repositor

[GitHub] justinborromeo opened a new issue #7021: ITBasicAuthConfigurationTest.testAuthConfiguration is Flaky

2019-02-06 Thread GitBox
justinborromeo opened a new issue #7021: ITBasicAuthConfigurationTest.testAuthConfiguration is Flaky URL: https://github.com/apache/incubator-druid/issues/7021 I noticed that the `testAuthConfiguration` test in `ITBasicAuthConfigurationTest` experiences transient failures. Based on the s

[GitHub] ferristseng opened a new pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

2019-02-06 Thread GitBox
ferristseng opened a new pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020 I noticed a couple of comments that hadn't been addressed in the Hadoop Indexing project regarding serializing and deserializin

[GitHub] jon-wei commented on issue #6984: Need to fix LICENSE and NOTICE for next release

2019-02-06 Thread GitBox
jon-wei commented on issue #6984: Need to fix LICENSE and NOTICE for next release URL: https://github.com/apache/incubator-druid/issues/6984#issuecomment-461200669 The new web-console has a dependency on Palantir Blueprint (https://github.com/palantir/blueprint/blob/develop/LICENSE) which

[GitHub] edgan8 edited a comment on issue #6581: Moments Sketch custom aggregator

2019-02-06 Thread GitBox
edgan8 edited a comment on issue #6581: Moments Sketch custom aggregator URL: https://github.com/apache/incubator-druid/pull/6581#issuecomment-461197020 @leerho I completely agree, it seems the concern is about the recommendations we provide to users. Due to concerns about robustness, I don

[GitHub] edgan8 commented on issue #6581: Moments Sketch custom aggregator

2019-02-06 Thread GitBox
edgan8 commented on issue #6581: Moments Sketch custom aggregator URL: https://github.com/apache/incubator-druid/pull/6581#issuecomment-461197020 I completely agree, it seems the concern is about the recommendations we provide to users. Due to concerns about robustness, I don't think the mo

[GitHub] hpandeycodeit commented on issue #6858: Free AggregatorFactory implementors from boilerplate in getMergingFactory()

2019-02-06 Thread GitBox
hpandeycodeit commented on issue #6858: Free AggregatorFactory implementors from boilerplate in getMergingFactory() URL: https://github.com/apache/incubator-druid/issues/6858#issuecomment-461192267 @leventov sounds good. I will do the changes.

[GitHub] glasser edited a comment on issue #6989: Behavior of index_parallel with appendToExisting=false and no bucketIntervals in GranularitySpec is surprising

2019-02-06 Thread GitBox
glasser edited a comment on issue #6989: Behavior of index_parallel with appendToExisting=false and no bucketIntervals in GranularitySpec is surprising URL: https://github.com/apache/incubator-druid/issues/6989#issuecomment-461108169 Hi @jihoonson. A couple random questions while I work on

[GitHub] gianm commented on issue #6993: [Proposal] Dynamic prioritization and laning

2019-02-06 Thread GitBox
gianm commented on issue #6993: [Proposal] Dynamic prioritization and laning URL: https://github.com/apache/incubator-druid/issues/6993#issuecomment-461180795 > Let me ask you this: if there was an omniscient function available in the broker that could exactly predict how light or heavy a

[GitHub] peferron commented on issue #6993: [Proposal] Dynamic prioritization and laning

2019-02-06 Thread GitBox
peferron commented on issue #6993: [Proposal] Dynamic prioritization and laning URL: https://github.com/apache/incubator-druid/issues/6993#issuecomment-461159982 > I was thinking a period threshold is likely to align with how people often set up historical tiers: a 'hot' tier for the lates

[GitHub] AlexanderSaydakov commented on issue #7019: Placement of SketchMergeAggregatorFactory.getMergingFactory()

2019-02-06 Thread GitBox
AlexanderSaydakov commented on issue #7019: Placement of SketchMergeAggregatorFactory.getMergingFactory() URL: https://github.com/apache/incubator-druid/issues/7019#issuecomment-461149807 What negative consequences do you think this has? ---

[GitHub] Dylan1312 commented on a change in pull request #6896: Add docker container for druid

2019-02-06 Thread GitBox
Dylan1312 commented on a change in pull request #6896: Add docker container for druid URL: https://github.com/apache/incubator-druid/pull/6896#discussion_r254377012 ## File path: distribution/docker/Dockerfile ## @@ -0,0 +1,55 @@ +# +# Licensed to the Apache Software Found

[GitHub] Dylan1312 commented on a change in pull request #6896: Add docker container for druid

2019-02-06 Thread GitBox
Dylan1312 commented on a change in pull request #6896: Add docker container for druid URL: https://github.com/apache/incubator-druid/pull/6896#discussion_r254381483 ## File path: distribution/docker/Dockerfile ## @@ -0,0 +1,55 @@ +# +# Licensed to the Apache Software Found

[GitHub] glasser commented on issue #6989: Behavior of index_parallel with appendToExisting=false and no bucketIntervals in GranularitySpec is surprising

2019-02-06 Thread GitBox
glasser commented on issue #6989: Behavior of index_parallel with appendToExisting=false and no bucketIntervals in GranularitySpec is surprising URL: https://github.com/apache/incubator-druid/issues/6989#issuecomment-461108169 Hi @jihoonson. A couple random questions while I work on this:

[GitHub] gianm commented on issue #6993: [Proposal] Dynamic prioritization and laning

2019-02-06 Thread GitBox
gianm commented on issue #6993: [Proposal] Dynamic prioritization and laning URL: https://github.com/apache/incubator-druid/issues/6993#issuecomment-461095949 @peferron, > Could you perhaps elaborate a bit more about why the dynamic prioritization scheme based on `periodThreshold` m

[GitHub] donbowman commented on issue #6896: Add docker container for druid

2019-02-06 Thread GitBox
donbowman commented on issue #6896: Add docker container for druid URL: https://github.com/apache/incubator-druid/pull/6896#issuecomment-461095091 I'm not sure what else is needed of me here. No comments received. I've made the requested changes. --

[GitHub] nishantmonu51 edited a comment on issue #6972: Support LDAP authentication/authorization

2019-02-06 Thread GitBox
nishantmonu51 edited a comment on issue #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-461074099 A very useful feature, Thanks for the contribution @mohammadjkhan Can you add a description to the PR and also link to

[GitHub] nishantmonu51 commented on issue #6972: Support LDAP authentication/authorization

2019-02-06 Thread GitBox
nishantmonu51 commented on issue #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-461074099 A very useful feature, Thanks for the contribution @mohammadjkhan -

[GitHub] mohammadjkhan commented on issue #6972: Support LDAP authentication/authorization

2019-02-06 Thread GitBox
mohammadjkhan commented on issue #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-461066711 Thanks @gianm. I'm taking a look at failing integration tests right now. I see them falling for me with the same errors/issue ev

[GitHub] kamaci commented on issue #6930: Improper getter value is fixed.

2019-02-06 Thread GitBox
kamaci commented on issue #6930: Improper getter value is fixed. URL: https://github.com/apache/incubator-druid/pull/6930#issuecomment-461030761 > > Do you mean adding a method to ApproximateHistogramPostAggregatorTest which extends BucketsPostAggregator? > > I'd suggest adding a Buc

[GitHub] kamaci commented on a change in pull request #6939: Throw caught exception.

2019-02-06 Thread GitBox
kamaci commented on a change in pull request #6939: Throw caught exception. URL: https://github.com/apache/incubator-druid/pull/6939#discussion_r254249330 ## File path: codestyle/checkstyle.xml ## @@ -204,6 +204,12 @@ + + + + Review

[GitHub] kamaci commented on a change in pull request #6931: Since notify might not wake up the right thread, notifyAll should be used instead.

2019-02-06 Thread GitBox
kamaci commented on a change in pull request #6931: Since notify might not wake up the right thread, notifyAll should be used instead. URL: https://github.com/apache/incubator-druid/pull/6931#discussion_r254247419 ## File path: extensions-contrib/druid-rocketmq/src/main/java/org/ap

[GitHub] leventov opened a new issue #7019: Placement of SketchMergeAggregatorFactory.getMergingFactory()

2019-02-06 Thread GitBox
leventov opened a new issue #7019: Placement of SketchMergeAggregatorFactory.getMergingFactory() URL: https://github.com/apache/incubator-druid/issues/7019 Shouldn't this method belong to `SketchAggregatorFactory`, like for `DoublesSketchAggregatorFactory.getMergingFactory()` and other si

[GitHub] leventov commented on issue #6858: Free AggregatorFactory implementors from boilerplate in getMergingFactory()

2019-02-06 Thread GitBox
leventov commented on issue #6858: Free AggregatorFactory implementors from boilerplate in getMergingFactory() URL: https://github.com/apache/incubator-druid/issues/6858#issuecomment-460938950 @hpandeycodeit I think it should have default implementation `return getClass();`. In Aggregato