[druid] branch master updated (36bc418 -> 61e1ffc)

2022-03-03 Thread frankchen
This is an automated email from the ASF dual-hosted git repository. frankchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 36bc418 Set Content-Type for String based response (#12295) add 61e1ffc add a new query laning metrics to

[GitHub] [druid] FrankChen021 merged pull request #12111: add a new query laning metrics to visualize lane assignment

2022-03-03 Thread GitBox
FrankChen021 merged pull request #12111: URL: https://github.com/apache/druid/pull/12111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[druid] branch master updated: Set Content-Type for String based response (#12295)

2022-03-03 Thread frankchen
This is an automated email from the ASF dual-hosted git repository. frankchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 36bc418 Set Content-Type for String based

[GitHub] [druid] FrankChen021 merged pull request #12295: Explicitly set Content-Type for string-based response

2022-03-03 Thread GitBox
FrankChen021 merged pull request #12295: URL: https://github.com/apache/druid/pull/12295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] FrankChen021 commented on pull request #12295: Explicitly set Content-Type for string-based response

2022-03-03 Thread GitBox
FrankChen021 commented on pull request #12295: URL: https://github.com/apache/druid/pull/12295#issuecomment-1058899420 All jobs in phase 2 succeeded except "other module test" which failed due to the same reason as in phase 1. -- This is an automated message from the Apache Git

[GitHub] [druid] samarthjain merged pull request #12304: Fix ci

2022-03-03 Thread GitBox
samarthjain merged pull request #12304: URL: https://github.com/apache/druid/pull/12304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[druid] branch master updated: Fix ci (#12304)

2022-03-03 Thread samarth
This is an automated email from the ASF dual-hosted git repository. samarth pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 58d05d7 Fix ci (#12304) 58d05d7 is described

[GitHub] [druid] samarthjain commented on pull request #12304: Fix ci

2022-03-03 Thread GitBox
samarthjain commented on pull request #12304: URL: https://github.com/apache/druid/pull/12304#issuecomment-1058893109 i am going to go ahead and merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [druid] samarthjain commented on pull request #12304: Fix ci

2022-03-03 Thread GitBox
samarthjain commented on pull request #12304: URL: https://github.com/apache/druid/pull/12304#issuecomment-1058849196 I am not sure why the LGTM build is still failing. Should I go ahead and merge this PR, @clintropolis, @jihoonson ? The build is failing right at the line that this PR is

[GitHub] [druid] samarthjain closed pull request #12304: Fix ci

2022-03-03 Thread GitBox
samarthjain closed pull request #12304: URL: https://github.com/apache/druid/pull/12304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] samarthjain commented on pull request #12304: Fix ci

2022-03-03 Thread GitBox
samarthjain commented on pull request #12304: URL: https://github.com/apache/druid/pull/12304#issuecomment-1058801269 Not sure why the build is still complaining about `String.format`. I am going to retry the build. -- This is an automated message from the Apache Git Service. To

[GitHub] [druid] jihoonson commented on pull request #12300: Add git hooks that can run multiple scripts

2022-03-03 Thread GitBox
jihoonson commented on pull request #12300: URL: https://github.com/apache/druid/pull/12300#issuecomment-1058796184 @maytasm thank you for pointing that out. I fixed the script (renamed it to `hooks/install-hooks.sh`). -- This is an automated message from the Apache Git Service. To

[GitHub] [druid] successok commented on issue #5202: Error: com.google.inject.util.Types.collectionOf(Ljava/lang/reflect/Type;)Ljava/lang/reflect/ParameterizedType;

2022-03-03 Thread GitBox
successok commented on issue #5202: URL: https://github.com/apache/druid/issues/5202#issuecomment-1058785160 add "jobProperties": { "mapreduce.job.classloader": "true" } -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [druid] jasonk000 edited a comment on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
jasonk000 edited a comment on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1058768666 Oops my bad, we had that fixed last night but I broke it again. Sorry! Thx @samarthjain for addressing it. -- This is an automated message from the Apache Git

[GitHub] [druid] jasonk000 edited a comment on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
jasonk000 edited a comment on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1058768666 Oops my bad, we had that fixed last night but I broke it again. Sorry! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [druid] jasonk000 commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
jasonk000 commented on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1058768666 Oops my bad, i thought we had that fixed last night. Sorry! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [druid] clintropolis commented on pull request #12304: Fix ci

2022-03-03 Thread GitBox
clintropolis commented on pull request #12304: URL: https://github.com/apache/druid/pull/12304#issuecomment-1058754504 i think we can merge after the forbidden api check passes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [druid] samarthjain commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
samarthjain commented on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1058752068 Submitted https://github.com/apache/druid/pull/12304 to fix CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [druid] samarthjain opened a new pull request #12304: Fix ci

2022-03-03 Thread GitBox
samarthjain opened a new pull request #12304: URL: https://github.com/apache/druid/pull/12304 Fix CI broken after https://github.com/apache/druid/commit/36193955b6d8a03fe247157dddebea0365c7e501 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [druid] FrankChen021 merged pull request #12290: Bump jersey.version from 1.19.3 to 1.19.4

2022-03-03 Thread GitBox
FrankChen021 merged pull request #12290: URL: https://github.com/apache/druid/pull/12290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[druid] branch master updated: Bump jersey.version from 1.19.3 to 1.19.4 (#12290)

2022-03-03 Thread frankchen
This is an automated email from the ASF dual-hosted git repository. frankchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new a1cdee2 Bump jersey.version from 1.19.3 to

[GitHub] [druid] samarthjain commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
samarthjain commented on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1058748780 Looks like the last rebase you pushed reverted your String.format changes, @jasonk000 . I will submit a PR to fix CI, @clintropolis -- This is an automated message from

[GitHub] [druid] FrankChen021 commented on pull request #12067: Enforce console logging for peon process

2022-03-03 Thread GitBox
FrankChen021 commented on pull request #12067: URL: https://github.com/apache/druid/pull/12067#issuecomment-1058748706 Hi @jihoonson @clintropolis this PR should be merged before we start a new release. Please take a look at it at you convenience. Thank you. -- This is an automated

[GitHub] [druid] clintropolis commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
clintropolis commented on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1058747362 this PR has broken the ci, forbidden api check is failing, `String.format` shouldn't be called directly, use `StringUtils.format` instead -- This is an automated

[GitHub] [druid] FrankChen021 commented on pull request #12303: Kafka & Kinesis stream ingest parsing in parallel

2022-03-03 Thread GitBox
FrankChen021 commented on pull request #12303: URL: https://github.com/apache/druid/pull/12303#issuecomment-1058742270 Do you have a performance report that shows how this change improves the throughput by setting different values of thread count under same incoming message rate? --

[GitHub] [druid] FrankChen021 commented on a change in pull request #12302: perf: core TextReader use a smaller default buffer

2022-03-03 Thread GitBox
FrankChen021 commented on a change in pull request #12302: URL: https://github.com/apache/druid/pull/12302#discussion_r819198659 ## File path: core/src/main/java/org/apache/druid/data/input/TextReader.java ## @@ -55,7 +56,8 @@ public InputRowSchema getInputRowSchema()

[GitHub] [druid] jasonk000 commented on pull request #12303: Kafka & Kinesis stream ingest parsing in parallel

2022-03-03 Thread GitBox
jasonk000 commented on pull request #12303: URL: https://github.com/apache/druid/pull/12303#issuecomment-1058721052 looks like i'll need check those LGTMs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [druid] jasonk000 opened a new pull request #12303: Kafka & Kinesis stream ingest parsing in parallel

2022-03-03 Thread GitBox
jasonk000 opened a new pull request #12303: URL: https://github.com/apache/druid/pull/12303 ### Description Introduce parallel parsing to the stream ingestion service. This is slightly different as it allows each "indexing" task to run parse and transform stages across multiple

[GitHub] [druid] jasonk000 opened a new pull request #12302: perf: core TextReader use a smaller default buffer

2022-03-03 Thread GitBox
jasonk000 opened a new pull request #12302: URL: https://github.com/apache/druid/pull/12302 ### Description Use a smaller default buffer in the TextReader during parsing. By default, the [LineIterator creates a BufferedReader if one is not

[GitHub] [druid] jasonk000 commented on a change in pull request #12177: introduce a "tree" type to the flattenSpec

2022-03-03 Thread GitBox
jasonk000 commented on a change in pull request #12177: URL: https://github.com/apache/druid/pull/12177#discussion_r819152744 ## File path: core/src/main/java/org/apache/druid/java/util/common/parsers/JSONFlattenerMaker.java ## @@ -108,6 +108,22 @@ public Object

[GitHub] [druid] jasonk000 commented on a change in pull request #12177: introduce a "tree" type to the flattenSpec

2022-03-03 Thread GitBox
jasonk000 commented on a change in pull request #12177: URL: https://github.com/apache/druid/pull/12177#discussion_r819147514 ## File path: core/src/main/java/org/apache/druid/java/util/common/parsers/JSONFlattenerMaker.java ## @@ -108,6 +108,22 @@ public Object

[GitHub] [druid] clintropolis merged pull request #12251: use virtual columns for sql simple aggregators instead of inline expressions

2022-03-03 Thread GitBox
clintropolis merged pull request #12251: URL: https://github.com/apache/druid/pull/12251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[druid] branch master updated (3619395 -> 1c004ea)

2022-03-03 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 3619395 perf: eliminate expensive log construction in remote-task-runner shutdown (#12097) add 1c004ea use

[GitHub] [druid] cchanyi opened a new pull request #12301: Switches to writable memory to support write operations

2022-03-03 Thread GitBox
cchanyi opened a new pull request #12301: URL: https://github.com/apache/druid/pull/12301 Fixes #10364 ### Description The method getPMF in DoublesSketch performs a sort operation when the number of split points is greater than 50. It looks like the sort is for performance

[GitHub] [druid] samarthjain merged pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
samarthjain merged pull request #12097: URL: https://github.com/apache/druid/pull/12097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[druid] branch master updated: perf: eliminate expensive log construction in remote-task-runner shutdown (#12097)

2022-03-03 Thread samarth
This is an automated email from the ASF dual-hosted git repository. samarth pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 3619395 perf: eliminate expensive log

[GitHub] [druid] samarthjain commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
samarthjain commented on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1058518405 Looking at the CI failures, it looks like the build timed out because `HashPartitionMultiPhaseParallelIndexingTest` never completed. To be double sure, I ran the test

[GitHub] [druid] maytasm commented on pull request #12300: Add git hooks that can run multiple scripts

2022-03-03 Thread GitBox
maytasm commented on pull request #12300: URL: https://github.com/apache/druid/pull/12300#issuecomment-1058447012 I added a pre-push hook before in https://github.com/apache/druid/pull/9554 Does this change break the setup script

[GitHub] [druid] jihoonson opened a new pull request #12300: Add git hooks that can run multiple scripts

2022-03-03 Thread GitBox
jihoonson opened a new pull request #12300: URL: https://github.com/apache/druid/pull/12300 ### Description This PR adds new scripts that can be used as git hooks. To do this, this PR changes the directory structure in https://github.com/apache/druid/tree/master/hooks by adding 2

[GitHub] [druid] atris commented on issue #10559: Query planner fails to plan nested query when an inner query is to topN and outer one has a filter

2022-03-03 Thread GitBox
atris commented on issue #10559: URL: https://github.com/apache/druid/issues/10559#issuecomment-1058372800 If this issue if open, I would like to take this up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [druid] somu-imply opened a new pull request #12299: Introducing new config to make errors in jetty layer return by defaul…

2022-03-03 Thread GitBox
somu-imply opened a new pull request #12299: URL: https://github.com/apache/druid/pull/12299 …t in json Introduced a new config called `druid.server.http.returnJettyErrorsInJson` which by default is set to `true`. When set to true any error from the Jetty layer is returned as a

[GitHub] [druid] atris commented on issue #9843: Reordering of predicates and filters (pushing up and/or pushing down) in JOINs to get the most performant plan

2022-03-03 Thread GitBox
atris commented on issue #9843: URL: https://github.com/apache/druid/issues/9843#issuecomment-1058305210 I would like to take this up, please. cc @nishantmonu51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [druid] clintropolis commented on pull request #12251: use virtual columns for sql simple aggregators instead of inline expressions

2022-03-03 Thread GitBox
clintropolis commented on pull request #12251: URL: https://github.com/apache/druid/pull/12251#issuecomment-1057972359 I have confirmed this change is safe for min/max aggregators, which have special logic when using the `expression` field that only impacts STRING and ARRAY typed

[GitHub] [druid] tejaswini-imply closed pull request #12297: Changed the `HttpEntity.openInputStream` parameter from URI to URL

2022-03-03 Thread GitBox
tejaswini-imply closed pull request #12297: URL: https://github.com/apache/druid/pull/12297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: