[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13027: Use standard library to correctly glob and stop at the correct folder structure when filtering cloud objects

2022-10-31 Thread GitBox
abhishekagarwal87 commented on code in PR #13027: URL: https://github.com/apache/druid/pull/13027#discussion_r1009347352 ## docs/ingestion/native-batch-input-source.md: ## @@ -773,7 +773,7 @@ The following is an example of a Combining input source spec: "delegates" : [

[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13027: Use standard library to correctly glob and stop at the correct folder structure when filtering cloud objects

2022-10-31 Thread GitBox
abhishekagarwal87 commented on code in PR #13027: URL: https://github.com/apache/druid/pull/13027#discussion_r1009348853 ## docs/ingestion/native-batch-input-source.md: ## @@ -307,7 +307,7 @@ Sample specs: "type": "index_parallel", "inputSource": { "type":

[GitHub] [druid-website-src] vogievetsky commented on pull request #345: Add sample file for Kafka ingestion tutorial

2022-10-31 Thread GitBox
vogievetsky commented on PR #345: URL: https://github.com/apache/druid-website-src/pull/345#issuecomment-1297302375 This is a tiny file, why not version it with the Druid docs by committing it here: https://github.com/apache/druid/tree/master/examples/quickstart/tutorial -- This is an au

[GitHub] [druid] writer-jill opened a new pull request, #13290: 25.0 release notes: batch 1

2022-10-31 Thread GitBox
writer-jill opened a new pull request, #13290: URL: https://github.com/apache/druid/pull/13290 First batch of draft release notes for 25.0 for review. This PR has: - [x] been self-reviewed. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [druid] didip commented on a diff in pull request #13027: Use standard library to correctly glob and stop at the correct folder structure when filtering cloud objects

2022-10-31 Thread GitBox
didip commented on code in PR #13027: URL: https://github.com/apache/druid/pull/13027#discussion_r1009641477 ## docs/ingestion/native-batch-input-source.md: ## @@ -307,7 +307,7 @@ Sample specs: "type": "index_parallel", "inputSource": { "type": "azure", -

[GitHub] [druid] didip commented on a diff in pull request #13027: Use standard library to correctly glob and stop at the correct folder structure when filtering cloud objects

2022-10-31 Thread GitBox
didip commented on code in PR #13027: URL: https://github.com/apache/druid/pull/13027#discussion_r1009641832 ## docs/ingestion/native-batch-input-source.md: ## @@ -773,7 +773,7 @@ The following is an example of a Combining input source spec: "delegates" : [ {

[GitHub] [druid] lgtm-com[bot] commented on pull request #12032: Migrate Druid HttpClient from Netty 3 to 4

2022-10-31 Thread GitBox
lgtm-com[bot] commented on PR #12032: URL: https://github.com/apache/druid/pull/12032#issuecomment-1297381307 This pull request **introduces 3 alerts** when merging a1ade92de40b0c49b94fbb2989b6bc02aa09f67a into 675fd982fb5ca274b057495a90563ecc248ad823 - [view on LGTM.com](https://lgtm.com/

[GitHub] [druid] xvrl commented on a diff in pull request #13281: [Backport] Fix QueryContext race condition

2022-10-31 Thread GitBox
xvrl commented on code in PR #13281: URL: https://github.com/apache/druid/pull/13281#discussion_r1009675268 ## sql/src/main/java/org/apache/druid/sql/avatica/DruidConnection.java: ## @@ -97,7 +97,7 @@ public DruidJdbcStatement createStatement(SqlStatementFactory sqlStatementFac

[GitHub] [druid] vogievetsky opened a new pull request, #13291: Web console: expose in the UI that a query is stuck waiting for task slots

2022-10-31 Thread GitBox
vogievetsky opened a new pull request, #13291: URL: https://github.com/apache/druid/pull/13291 This is a UI followup to https://github.com/apache/druid/pull/13263 This PR adds two things: (1) a capacity check + notification when clicking the Run (or Preview) buttons: ht

[GitHub] [druid] lgtm-com[bot] commented on pull request #13027: Use standard library to correctly glob and stop at the correct folder structure when filtering cloud objects

2022-10-31 Thread GitBox
lgtm-com[bot] commented on PR #13027: URL: https://github.com/apache/druid/pull/13027#issuecomment-1297484020 This pull request **introduces 2 alerts** when merging 4c89a1bfbb010c1ac3d76a4fe0d71a13d5813d2d into 675fd982fb5ca274b057495a90563ecc248ad823 - [view on LGTM.com](https://lgtm.com/

[GitHub] [druid] churromorales commented on pull request #13156: Support for middle manager less druid, tasks launch as k8s jobs

2022-10-31 Thread GitBox
churromorales commented on PR #13156: URL: https://github.com/apache/druid/pull/13156#issuecomment-1297750038 > * Avoid creating TaskLocations with `null` host and non-`-1` values for `port` and `tlsPort`. This may be happening in `K8sWorkItem` if `mainPod.getStatus().getPodIP()` is `nu

[GitHub] [druid] dependabot[bot] opened a new pull request, #13292: Bump oauth2-oidc-sdk from 6.5 to 10.1

2022-10-31 Thread GitBox
dependabot[bot] opened a new pull request, #13292: URL: https://github.com/apache/druid/pull/13292 Bumps [oauth2-oidc-sdk](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions) from 6.5 to 10.1. Changelog Sourced from https://bitbucket.org/connect2id/oauth

[GitHub] [druid] dependabot[bot] commented on pull request #13256: Bump oauth2-oidc-sdk from 6.5 to 10.0

2022-10-31 Thread GitBox
dependabot[bot] commented on PR #13256: URL: https://github.com/apache/druid/pull/13256#issuecomment-1297818345 Superseded by #13292. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [druid] dependabot[bot] closed pull request #13256: Bump oauth2-oidc-sdk from 6.5 to 10.0

2022-10-31 Thread GitBox
dependabot[bot] closed pull request #13256: Bump oauth2-oidc-sdk from 6.5 to 10.0 URL: https://github.com/apache/druid/pull/13256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [druid] lgtm-com[bot] commented on pull request #13156: Support for middle manager less druid, tasks launch as k8s jobs

2022-10-31 Thread GitBox
lgtm-com[bot] commented on PR #13156: URL: https://github.com/apache/druid/pull/13156#issuecomment-1297821985 This pull request **introduces 5 alerts** when merging fb6609e189e8f041219821ef349e401b6ba28cdb into 675fd982fb5ca274b057495a90563ecc248ad823 - [view on LGTM.com](https://lgtm.com/

[GitHub] [druid] gianm commented on a diff in pull request #13027: Use standard library to correctly glob and stop at the correct folder structure when filtering cloud objects

2022-10-31 Thread GitBox
gianm commented on code in PR #13027: URL: https://github.com/apache/druid/pull/13027#discussion_r1009976897 ## docs/ingestion/native-batch-input-source.md: ## @@ -182,7 +182,7 @@ Sample specs: |uris|JSON array of URIs where S3 objects to be ingested are located.|None|`uris` o

[GitHub] [druid] vogievetsky commented on pull request #13253: Version Bump CSS

2022-10-31 Thread GitBox
vogievetsky commented on PR #13253: URL: https://github.com/apache/druid/pull/13253#issuecomment-1297884389 you need to update package-lock.json also -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] vogievetsky closed pull request #13099: Bump scss-tokenizer and node-sass in /web-console

2022-10-31 Thread GitBox
vogievetsky closed pull request #13099: Bump scss-tokenizer and node-sass in /web-console URL: https://github.com/apache/druid/pull/13099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [druid] dependabot[bot] commented on pull request #13099: Bump scss-tokenizer and node-sass in /web-console

2022-10-31 Thread GitBox
dependabot[bot] commented on PR #13099: URL: https://github.com/apache/druid/pull/13099#issuecomment-1297885120 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

[GitHub] [druid] kfaraz merged pull request #13279: [Backport] nested column fixes 24.0.1

2022-10-31 Thread GitBox
kfaraz merged PR #13279: URL: https://github.com/apache/druid/pull/13279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apach

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13197: Segment loading: Allow cancellation and prioritization of load queue items

2022-10-31 Thread GitBox
imply-cheddar commented on code in PR #13197: URL: https://github.com/apache/druid/pull/13197#discussion_r1009974733 ## server/src/main/java/org/apache/druid/server/coordinator/SegmentHolder.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [druid] a2l007 commented on issue #13289: [Flaky ut] KafkaSupervisorTest.testResumeAllActivelyReadingTasks

2022-10-31 Thread GitBox
a2l007 commented on issue #13289: URL: https://github.com/apache/druid/issues/13289#issuecomment-1297978138 Found in pr: #13156 as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [druid] jasonk000 commented on pull request #12177: introduce a "tree" type to the flattenSpec

2022-10-31 Thread GitBox
jasonk000 commented on PR #12177: URL: https://github.com/apache/druid/pull/12177#issuecomment-1298079326 Great! What's needed to merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [druid] jasonk000 commented on pull request #12177: introduce a "tree" type to the flattenSpec

2022-10-31 Thread GitBox
jasonk000 commented on PR #12177: URL: https://github.com/apache/druid/pull/12177#issuecomment-1298079460 Great! What's needed to merge it? @abhishekagarwal87 @FrankChen021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [druid] AshishKapoor commented on pull request #13253: Version Bump CSS

2022-10-31 Thread GitBox
AshishKapoor commented on PR #13253: URL: https://github.com/apache/druid/pull/13253#issuecomment-1298092561 > you need to update package-lock.json also Done, good catch! @vogievetsky -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [druid] FrankChen021 merged pull request #12177: introduce a "tree" type to the flattenSpec

2022-10-31 Thread GitBox
FrankChen021 merged PR #12177: URL: https://github.com/apache/druid/pull/12177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid

[GitHub] [druid] FrankChen021 commented on pull request #12177: introduce a "tree" type to the flattenSpec

2022-10-31 Thread GitBox
FrankChen021 commented on PR #12177: URL: https://github.com/apache/druid/pull/12177#issuecomment-1298097899 I merged it. Thanks for the contribution @jasonk000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [druid] NikitaElmanov opened a new issue, #13293: Different sending metrics for small and nano-quickstart configurations

2022-11-01 Thread GitBox
NikitaElmanov opened a new issue, #13293: URL: https://github.com/apache/druid/issues/13293 Hi! I'm using druid 0.23.0 version in 2 stands (develop stand and load testing stand). Of course, DEV stand has fewer resources than LT, because of it in DEV applies **nano-quickstart** configurat

[GitHub] [druid] kfaraz commented on a diff in pull request #13197: Segment loading: Allow cancellation and prioritization of load queue items

2022-11-01 Thread GitBox
kfaraz commented on code in PR #13197: URL: https://github.com/apache/druid/pull/13197#discussion_r1010207688 ## server/src/test/java/org/apache/druid/server/coordinator/RunRulesTest.java: ## @@ -119,35 +118,39 @@ public void testOneTierTwoReplicantsWithStrictReplicantLimit()

[GitHub] [druid] kfaraz commented on a diff in pull request #13197: Segment loading: Allow cancellation and prioritization of load queue items

2022-11-01 Thread GitBox
kfaraz commented on code in PR #13197: URL: https://github.com/apache/druid/pull/13197#discussion_r1010207839 ## server/src/test/java/org/apache/druid/server/coordinator/BalancerStrategyTest.java: ## @@ -84,29 +84,32 @@ public void findNewSegmentHomeReplicatorNotEnoughSpace()

[GitHub] [druid] kfaraz commented on a diff in pull request #13197: Segment loading: Allow cancellation and prioritization of load queue items

2022-11-01 Thread GitBox
kfaraz commented on code in PR #13197: URL: https://github.com/apache/druid/pull/13197#discussion_r1010208298 ## server/src/main/java/org/apache/druid/server/coordinator/SegmentLoader.java: ## @@ -0,0 +1,460 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [druid] kfaraz commented on a diff in pull request #13197: Segment loading: Allow cancellation and prioritization of load queue items

2022-11-01 Thread GitBox
kfaraz commented on code in PR #13197: URL: https://github.com/apache/druid/pull/13197#discussion_r1010208794 ## server/src/main/java/org/apache/druid/server/coordinator/SegmentLoader.java: ## @@ -0,0 +1,460 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [druid] kfaraz commented on a diff in pull request #13197: Segment loading: Allow cancellation and prioritization of load queue items

2022-11-01 Thread GitBox
kfaraz commented on code in PR #13197: URL: https://github.com/apache/druid/pull/13197#discussion_r1010210402 ## server/src/main/java/org/apache/druid/server/coordinator/HttpLoadQueuePeon.java: ## @@ -380,10 +407,12 @@ public void loadSegment(DataSegment segment, LoadPeonCallba

[GitHub] [druid] Maplejw closed issue #13264: use thetaSketch when index hadoop , a little mertic of thetaSketch values is null. So I can not upgrade druid from 0.20.2 to 24.0

2022-11-01 Thread GitBox
Maplejw closed issue #13264: use thetaSketch when index hadoop , a little mertic of thetaSketch values is null. So I can not upgrade druid from 0.20.2 to 24.0 URL: https://github.com/apache/druid/issues/13264 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [druid] Maplejw commented on issue #13264: use thetaSketch when index hadoop , a little mertic of thetaSketch values is null. So I can not upgrade druid from 0.20.2 to 24.0

2022-11-01 Thread GitBox
Maplejw commented on issue #13264: URL: https://github.com/apache/druid/issues/13264#issuecomment-1298294463 upgrade to 0.22.0 and upgrade historicals first,upgrade broker finally,it works. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [druid] adarshsanjeev commented on a diff in pull request #13269: Add a OverlordHelper that cleans up durable storage objects in MSQ

2022-11-01 Thread GitBox
adarshsanjeev commented on code in PR #13269: URL: https://github.com/apache/druid/pull/13269#discussion_r1010377540 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/DurableStorageCleaner.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache S

[GitHub] [druid-website-src] writer-jill closed pull request #345: Add sample file for Kafka ingestion tutorial

2022-11-01 Thread GitBox
writer-jill closed pull request #345: Add sample file for Kafka ingestion tutorial URL: https://github.com/apache/druid-website-src/pull/345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [druid-website-src] writer-jill commented on pull request #345: Add sample file for Kafka ingestion tutorial

2022-11-01 Thread GitBox
writer-jill commented on PR #345: URL: https://github.com/apache/druid-website-src/pull/345#issuecomment-1298493233 Closing - agreed with @techdocsmith and @vogievetsky to save this file elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [druid] kfaraz merged pull request #13287: Improve run time of coordinator duty MarkAsUnusedOvershadowedSegments

2022-11-01 Thread GitBox
kfaraz merged PR #13287: URL: https://github.com/apache/druid/pull/13287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apach

[GitHub] [druid] kfaraz commented on pull request #13287: Improve run time of coordinator duty MarkAsUnusedOvershadowedSegments

2022-11-01 Thread GitBox
kfaraz commented on PR #13287: URL: https://github.com/apache/druid/pull/13287#issuecomment-1298620621 Thanks for the reviews, @imply-cheddar , @AmatyaAvadhanula ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [druid] paul-rogers commented on pull request #13165: Druid Catalog basics

2022-11-01 Thread GitBox
paul-rogers commented on PR #13165: URL: https://github.com/apache/druid/pull/13165#issuecomment-1298799254 PR has been updated with a large set of changes based on review comments: * Revised the REST API per the design outlined above. * Replaced the ad-hoc ways to "edit" a table wi

[GitHub] [druid] vogievetsky merged pull request #13291: Web console: expose in the UI that a query is stuck waiting for task slots

2022-11-01 Thread GitBox
vogievetsky merged PR #13291: URL: https://github.com/apache/druid/pull/13291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.

[GitHub] [druid] paul-rogers commented on a diff in pull request #13165: Druid Catalog basics

2022-11-01 Thread GitBox
paul-rogers commented on code in PR #13165: URL: https://github.com/apache/druid/pull/13165#discussion_r1010661428 ## server/src/main/java/org/apache/druid/catalog/model/table/ClusterKeySpec.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [druid] paul-rogers commented on a diff in pull request #13165: Druid Catalog basics

2022-11-01 Thread GitBox
paul-rogers commented on code in PR #13165: URL: https://github.com/apache/druid/pull/13165#discussion_r1010668721 ## extensions-core/druid-catalog/src/main/java/org/apache/druid/catalog/sync/CatalogUpdateNotifier.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [druid] paul-rogers commented on a diff in pull request #13165: Druid Catalog basics

2022-11-01 Thread GitBox
paul-rogers commented on code in PR #13165: URL: https://github.com/apache/druid/pull/13165#discussion_r1010669600 ## extensions-core/druid-catalog/src/main/java/org/apache/druid/catalog/http/CatalogResource.java: ## @@ -0,0 +1,774 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [druid] techdocsmith commented on pull request #13261: Update Kafka ingestion tutorial

2022-11-01 Thread GitBox
techdocsmith commented on PR #13261: URL: https://github.com/apache/druid/pull/13261#issuecomment-1298929116 @writer-jill , can we make sure to include an explicit mention on `querying/nested-columns.md` that streaming ingestion is supported and link out to the tutorial for an example.

[GitHub] [druid] gianm commented on pull request #13261: Update Kafka ingestion tutorial

2022-11-01 Thread GitBox
gianm commented on PR #13261: URL: https://github.com/apache/druid/pull/13261#issuecomment-1298929514 Would it be possible to address #13261 as well, by updating `querying/nested-columns.md`? i.e. adding an example to this page: https://druid.apache.org/docs/latest/querying/nested-columns.h

[GitHub] [druid] didip commented on a diff in pull request #13027: Use standard library to correctly glob and stop at the correct folder structure when filtering cloud objects

2022-11-01 Thread GitBox
didip commented on code in PR #13027: URL: https://github.com/apache/druid/pull/13027#discussion_r1010760240 ## docs/ingestion/native-batch-input-source.md: ## @@ -182,7 +182,7 @@ Sample specs: |uris|JSON array of URIs where S3 objects to be ingested are located.|None|`uris` o

[GitHub] [druid] lgtm-com[bot] commented on pull request #13156: Support for middle manager less druid, tasks launch as k8s jobs

2022-11-01 Thread GitBox
lgtm-com[bot] commented on PR #13156: URL: https://github.com/apache/druid/pull/13156#issuecomment-1298942861 This pull request **introduces 5 alerts** when merging a4b4cdb1b021a097627963b74cccbf7adb431d91 into fd7864ae33ba8afe56d660c2b6d84ec5b498d321 - [view on LGTM.com](https://lgtm.com/

[GitHub] [druid] lgtm-com[bot] commented on pull request #13027: Use standard library to correctly glob and stop at the correct folder structure when filtering cloud objects

2022-11-01 Thread GitBox
lgtm-com[bot] commented on PR #13027: URL: https://github.com/apache/druid/pull/13027#issuecomment-1299035954 This pull request **introduces 2 alerts** when merging 14069f1d563c02260add3da56cf521fc22b930ef into 176934e849d50a2360f50db7771c1775110308f3 - [view on LGTM.com](https://lgtm.com/

[GitHub] [druid] lgtm-com[bot] commented on pull request #13247: Always return sketches from DS_HLL, DS_THETA, DS_QUANTILES_SKETCH.

2022-11-01 Thread GitBox
lgtm-com[bot] commented on PR #13247: URL: https://github.com/apache/druid/pull/13247#issuecomment-1299045254 This pull request **introduces 1 alert** when merging 64e2eb098ee5b40a7e3d29132fca84c0d5c47ecd into 176934e849d50a2360f50db7771c1775110308f3 - [view on LGTM.com](https://lgtm.com/p

[GitHub] [druid] rohangarg commented on pull request #13201: Try converting all inner joins to filters

2022-11-01 Thread GitBox
rohangarg commented on PR #13201: URL: https://github.com/apache/druid/pull/13201#issuecomment-1299045861 Facing https://github.com/apache/druid/issues/13289 in CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [druid] gianm commented on a diff in pull request #13271: Use lookup memory footprint in MSQ memory computations.

2022-11-01 Thread GitBox
gianm commented on code in PR #13271: URL: https://github.com/apache/druid/pull/13271#discussion_r1010925470 ## extensions-core/lookups-cached-single/src/main/java/org/apache/druid/server/lookup/cache/polling/OnHeapPollingCache.java: ## @@ -83,6 +84,19 @@ public List getKeys(fin

[GitHub] [druid] gianm commented on a diff in pull request #13271: Use lookup memory footprint in MSQ memory computations.

2022-11-01 Thread GitBox
gianm commented on code in PR #13271: URL: https://github.com/apache/druid/pull/13271#discussion_r1010928629 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/IndexerWorkerContext.java: ## @@ -276,6 +268,62 @@ public Bouncer processorBouncer()

[GitHub] [druid] gianm commented on a diff in pull request #13271: Use lookup memory footprint in MSQ memory computations.

2022-11-01 Thread GitBox
gianm commented on code in PR #13271: URL: https://github.com/apache/druid/pull/13271#discussion_r1010929285 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/IndexerWorkerContext.java: ## @@ -276,6 +268,62 @@ public Bouncer processorBouncer()

[GitHub] [druid] gianm commented on a diff in pull request #13271: Use lookup memory footprint in MSQ memory computations.

2022-11-01 Thread GitBox
gianm commented on code in PR #13271: URL: https://github.com/apache/druid/pull/13271#discussion_r1010929783 ## extensions-core/lookups-cached-single/src/main/java/org/apache/druid/server/lookup/cache/polling/OnHeapPollingCache.java: ## @@ -83,6 +84,19 @@ public List getKeys(fin

[GitHub] [druid] lgtm-com[bot] commented on pull request #13027: Use standard library to correctly glob and stop at the correct folder structure when filtering cloud objects

2022-11-01 Thread GitBox
lgtm-com[bot] commented on PR #13027: URL: https://github.com/apache/druid/pull/13027#issuecomment-1299270329 This pull request **introduces 2 alerts** when merging f389e38a107ca575c87e19ebaf3fe8081f636c08 into 176934e849d50a2360f50db7771c1775110308f3 - [view on LGTM.com](https://lgtm.com/

[GitHub] [druid] lgtm-com[bot] commented on pull request #13156: Support for middle manager less druid, tasks launch as k8s jobs

2022-11-01 Thread GitBox
lgtm-com[bot] commented on PR #13156: URL: https://github.com/apache/druid/pull/13156#issuecomment-1299279213 This pull request **introduces 5 alerts** when merging ab612d83fb190f98a106e4ca70059f95f470d986 into 176934e849d50a2360f50db7771c1775110308f3 - [view on LGTM.com](https://lgtm.com/

[GitHub] [druid] didip commented on pull request #13027: Use standard library to correctly glob and stop at the correct folder structure when filtering cloud objects

2022-11-01 Thread GitBox
didip commented on PR #13027: URL: https://github.com/apache/druid/pull/13027#issuecomment-1299285648 @gianm addressed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [druid] techdocsmith commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-01 Thread GitBox
techdocsmith commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1010927683 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol

[GitHub] [druid] gianm commented on a diff in pull request #13271: Use lookup memory footprint in MSQ memory computations.

2022-11-01 Thread GitBox
gianm commented on code in PR #13271: URL: https://github.com/apache/druid/pull/13271#discussion_r1010962046 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/IndexerWorkerContext.java: ## @@ -250,8 +242,8 @@ public FrameContext frameContext(QueryD

[GitHub] [druid] clintropolis opened a new pull request, #13294: fix issue with parquet list conversion of nullable lists with complex nullable elements

2022-11-01 Thread GitBox
clintropolis opened a new pull request, #13294: URL: https://github.com/apache/druid/pull/13294 ### Description This PR fixes a flaw in Parquet list conversion for nullable lists of nullable complex elements (groups with many fields, etc), which is amusingly similar to #5433, which I fix

[GitHub] [druid] dampcake opened a new pull request, #13295: Bump Apache Curator from 5.3.0 to 5.4.0

2022-11-01 Thread GitBox
dampcake opened a new pull request, #13295: URL: https://github.com/apache/druid/pull/13295 ### Description Follow up to #12939. As noted in that PR there are a few fixes in 5.4.0 that should make running on Kubernetes more reliable. Notably: - https://issues.apache.org/jira/browse

[GitHub] [druid] FrankChen021 commented on pull request #13286: PrometheusEmitter NullPointerException fix

2022-11-01 Thread GitBox
FrankChen021 commented on PR #13286: URL: https://github.com/apache/druid/pull/13286#issuecomment-1299470197 > > > > I realized that there are two conditions that may lead to `NPE` in the access identifier > > 1. The `identifier` may be modified by the `emitMetric` thread. Sin

[GitHub] [druid] jon-wei opened a new pull request, #13296: Make RecordSupplierInputSource respect sampler timeout when stream is empty

2022-11-01 Thread GitBox
jon-wei opened a new pull request, #13296: URL: https://github.com/apache/druid/pull/13296 This PR fixes an issue where sampling from a stream input (Kafka, Kinesis) can fail to respect the configured timeout, when the stream has no records available. The entity iterator would poll

[GitHub] [druid] amaechler commented on a diff in pull request #13296: Make RecordSupplierInputSource respect sampler timeout when stream is empty

2022-11-01 Thread GitBox
amaechler commented on code in PR #13296: URL: https://github.com/apache/druid/pull/13296#discussion_r1011099106 ## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/RecordSupplierInputSource.java: ## @@ -123,13 +129,23 @@ CloseableIterator createEntityIter

[GitHub] [druid] kfaraz commented on a diff in pull request #13296: Make RecordSupplierInputSource respect sampler timeout when stream is empty

2022-11-01 Thread GitBox
kfaraz commented on code in PR #13296: URL: https://github.com/apache/druid/pull/13296#discussion_r1011128484 ## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/RecordSupplierInputSource.java: ## @@ -123,13 +129,23 @@ CloseableIterator createEntityIterato

[GitHub] [druid] kfaraz commented on a diff in pull request #13296: Make RecordSupplierInputSource respect sampler timeout when stream is empty

2022-11-01 Thread GitBox
kfaraz commented on code in PR #13296: URL: https://github.com/apache/druid/pull/13296#discussion_r1011128725 ## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/RecordSupplierInputSource.java: ## @@ -123,13 +129,23 @@ CloseableIterator createEntityIterato

[GitHub] [druid] zachjsh commented on a diff in pull request #13165: Druid Catalog basics

2022-11-01 Thread GitBox
zachjsh commented on code in PR #13165: URL: https://github.com/apache/druid/pull/13165#discussion_r1011217376 ## extensions-core/druid-catalog/src/main/java/org/apache/druid/catalog/sync/CatalogUpdateNotifier.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [druid] zachjsh commented on a diff in pull request #13165: Druid Catalog basics

2022-11-01 Thread GitBox
zachjsh commented on code in PR #13165: URL: https://github.com/apache/druid/pull/13165#discussion_r1011219035 ## extensions-core/druid-catalog/src/main/java/org/apache/druid/catalog/storage/sql/CatalogManager.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [druid] jon-wei commented on a diff in pull request #13296: Make RecordSupplierInputSource respect sampler timeout when stream is empty

2022-11-02 Thread GitBox
jon-wei commented on code in PR #13296: URL: https://github.com/apache/druid/pull/13296#discussion_r1011327598 ## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/RecordSupplierInputSource.java: ## @@ -123,13 +129,23 @@ CloseableIterator createEntityIterat

[GitHub] [druid] toughrogrammer commented on issue #10693: index_parallel with single dimension partitioning doesn't honour maxRowsPerSegment/targetRowsPerSegment and creates skewed segments

2022-11-02 Thread GitBox
toughrogrammer commented on issue #10693: URL: https://github.com/apache/druid/issues/10693#issuecomment-1299861725 same issue too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [druid] clintropolis opened a new pull request, #13297: fix nested column range index range computation

2022-11-02 Thread GitBox
clintropolis opened a new pull request, #13297: URL: https://github.com/apache/druid/pull/13297 ### Description Fixes a bug with nested column range index value range computation that can lead to incorrect values matching filters when the range is not present in the nested fields local d

[GitHub] [druid] NikitaElmanov closed issue #13293: Different sending metrics for small and nano-quickstart configurations

2022-11-02 Thread GitBox
NikitaElmanov closed issue #13293: Different sending metrics for small and nano-quickstart configurations URL: https://github.com/apache/druid/issues/13293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [druid] jon-wei commented on a diff in pull request #13296: Make RecordSupplierInputSource respect sampler timeout when stream is empty

2022-11-02 Thread GitBox
jon-wei commented on code in PR #13296: URL: https://github.com/apache/druid/pull/13296#discussion_r1011535164 ## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/RecordSupplierInputSource.java: ## @@ -123,13 +129,23 @@ CloseableIterator createEntityIterat

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011631794 ## docs/development/extensions-core/druid-basic-security.md: ## @@ -182,24 +333,131 @@ druid.auth.authorizer.MyBasicMetadataAuthorizer.type=basic The examples in

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011633095 ## docs/development/extensions-core/druid-basic-security.md: ## @@ -182,24 +333,131 @@ druid.auth.authorizer.MyBasicMetadataAuthorizer.type=basic The examples in

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011633510 ## docs/development/extensions-core/druid-basic-security.md: ## @@ -182,24 +333,131 @@ druid.auth.authorizer.MyBasicMetadataAuthorizer.type=basic The examples in

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011633929 ## docs/development/extensions-core/druid-basic-security.md: ## @@ -182,24 +333,131 @@ druid.auth.authorizer.MyBasicMetadataAuthorizer.type=basic The examples in

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011634342 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011634949 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011639275 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011638968 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011639706 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011640024 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011640442 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011642647 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011643539 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011647933 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011650055 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011651731 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011653009 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011656742 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011659282 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011662538 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] writer-jill commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
writer-jill commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011674193 ## docs/operations/auth-ldap.md: ## @@ -22,182 +23,279 @@ title: "LDAP auth" ~ under the License. --> +You can use [Lightweight Directory Access Protocol (

[GitHub] [druid] tijoparacka commented on a diff in pull request #13245: Update LDAP configuration docs

2022-11-02 Thread GitBox
tijoparacka commented on code in PR #13245: URL: https://github.com/apache/druid/pull/13245#discussion_r1011770709 ## docs/development/extensions-core/druid-basic-security.md: ## @@ -182,24 +333,131 @@ druid.auth.authorizer.MyBasicMetadataAuthorizer.type=basic The examples in

[GitHub] [druid] 599166320 commented on pull request #13286: PrometheusEmitter NullPointerException fix

2022-11-02 Thread GitBox
599166320 commented on PR #13286: URL: https://github.com/apache/druid/pull/13286#issuecomment-1300421150 @FrankChen021 I debugged. If `druid.emitter.prometheus.namespace=xxx` is not configured, the value of `namespace` will be at least `druid`. In order to make the code more concise and c

[GitHub] [druid] FrankChen021 commented on pull request #13286: PrometheusEmitter NullPointerException fix

2022-11-02 Thread GitBox
FrankChen021 commented on PR #13286: URL: https://github.com/apache/druid/pull/13286#issuecomment-1300427015 Thanks for the cleanup. We also need to remove the `Nullable` annotation from the `namespace` since it won't be null at all. -- This is an automated message from the Apache Git

[GitHub] [druid] kfaraz commented on a diff in pull request #13297: fix nested column range index range computation

2022-11-02 Thread GitBox
kfaraz commented on code in PR #13297: URL: https://github.com/apache/druid/pull/13297#discussion_r1011888371 ## processing/src/main/java/org/apache/druid/segment/nested/NestedFieldLiteralColumnIndexSupplier.java: ## @@ -223,16 +214,41 @@ private IntIntPair getLocalRangeFromDic

<    1   2   3   4   5   6   7   8   9   10   >