[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-19 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r295142028 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -348,21

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r291723621 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -252,12

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r291728738 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -348,21

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r291740382 ## File path: core/src/test/java/org/apache/druid/math/expr/ParserTest.java ## @@

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r291479711 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -20,22

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r291733116 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@ -23,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r291722111 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -56,23

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r291724317 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -348,21

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r291721149 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -56,23

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r291478867 ## File path: core/src/main/java/org/apache/druid/math/expr/ApplyFunction.java ## @@

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289998102 ## File path: core/src/main/java/org/apache/druid/math/expr/ApplyFunction.java ## @@

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-07 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r291473134 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@ -23,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-03 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r290005426 ## File path: core/src/main/java/org/apache/druid/math/expr/Parser.java ## @@ -60,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-03 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289998102 ## File path: core/src/main/java/org/apache/druid/math/expr/ApplyFunction.java ## @@

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-03 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r28388 ## File path: core/src/main/java/org/apache/druid/math/expr/CartesianList.java ## @@

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-03 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289989041 ## File path: core/src/main/java/org/apache/druid/math/expr/ApplyFunction.java ## @@

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-01 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289611329 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -252,12

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-01 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289611040 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -205,6

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-01 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289611025 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -118,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-01 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289610990 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -241,6

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-01 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289610990 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -241,6

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-06-01 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289610969 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -118,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289517157 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -348,16

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289507079 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -118,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288732868 ## File path: core/src/main/java/org/apache/druid/math/expr/ExprEval.java ## @@ -87,9

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289508279 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -178,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288263123 ## File path:

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288739565 ## File path: core/src/main/java/org/apache/druid/math/expr/Parser.java ## @@ -141,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288731396 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -213,7

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288719530 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@ -23,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289509283 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -205,6

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288730317 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@ -23,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289513984 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -241,6

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289525216 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -1453,4

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288725691 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -148,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288723606 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -118,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288720307 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@ -23,13

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289516752 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -330,10

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288723761 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -118,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288731915 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -241,6

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289516306 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -252,12

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288725888 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -178,11

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

2019-05-31 Thread GitBox
himanshug commented on a change in pull request #7588: multi-value string column support for expressions URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288263051 ## File path: