[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

thesmallstar commented on a change in pull request #1290: URL: https://github.com/apache/fineract/pull/1290#discussion_r478860118 ## File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/RecurringDepositTest.java ## @@ -2774,11 +2774,11 @@

[GitHub] [fineract] fynmanoj opened a new pull request #1303: FINERACT-1120-TFA-authentication-issue-fix

fynmanoj opened a new pull request #1303: URL: https://github.com/apache/fineract/pull/1303 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure these boxes are checked b

[GitHub] [fineract] fynmanoj opened a new pull request #1302: FINERACT-1120-TFA-authentication-issue-fix

fynmanoj opened a new pull request #1302: URL: https://github.com/apache/fineract/pull/1302 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure these boxes are checked b

[GitHub] [fineract] fynmanoj opened a new pull request #1301: FINERACT-1120-TFA-authentication-issue-fix

fynmanoj opened a new pull request #1301: URL: https://github.com/apache/fineract/pull/1301 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure these boxes are checked b

[GitHub] [fineract] vidakovic merged pull request #1300: FINERACT-1134: Backport FINERACT-1129 fix to release branch 1.4.0

vidakovic merged pull request #1300: URL: https://github.com/apache/fineract/pull/1300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[fineract] branch 1.4.0 updated (64b8673 -> 11676d1)

This is an automated email from the ASF dual-hosted git repository. aleks pushed a change to branch 1.4.0 in repository https://gitbox.apache.org/repos/asf/fineract.git. from 64b8673 Merge pull request #1298 from vidakovic/feature/FINERACT-1134 add bcfbd6d FINERACT-1134: Backport FINE

[fineract] 01/01: FINERACT-1134: Backport FINERACT-1129 fix to release branch 1.4.0

This is an automated email from the ASF dual-hosted git repository. aleks pushed a commit to branch 1.4.0 in repository https://gitbox.apache.org/repos/asf/fineract.git commit 11676d17c4b8e1957da1788e698a7a8818687f02 Merge: 64b8673 bcfbd6d Author: Aleksandar Vidakovic AuthorDate: Fri Aug 28 06:0

[GitHub] [fineract] xurror commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

xurror commented on a change in pull request #1290: URL: https://github.com/apache/fineract/pull/1290#discussion_r478707601 ## File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/RecurringDepositTest.java ## @@ -2774,11 +2774,11 @@ public

[GitHub] [fineract] vidakovic opened a new pull request #1300: FINERACT-1134: Backport FINERACT-1129 fix to release branch 1.4.0

vidakovic opened a new pull request #1300: URL: https://github.com/apache/fineract/pull/1300 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure these boxes are checked

[fineract] branch develop updated (11e4ce9 -> 300a02b)

This is an automated email from the ASF dual-hosted git repository. aleks pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from 11e4ce9 FINERACT-1120: TFA authentication issue fix add 89e4e54 FINERACT-1129: create Gradle release task -

[GitHub] [fineract] vidakovic merged pull request #1299: FINERACT-1129: create Gradle release task - fix source distribution

vidakovic merged pull request #1299: URL: https://github.com/apache/fineract/pull/1299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[fineract] 01/01: FINERACT-1129: create Gradle release task - fix source distribution

This is an automated email from the ASF dual-hosted git repository. aleks pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git commit 300a02b6b0f61184759c475b250bdee59699175e Merge: 11e4ce9 89e4e54 Author: Aleksandar Vidakovic AuthorDate: Fri Aug 28 04

[GitHub] [fineract] vidakovic opened a new pull request #1299: FINERACT-1129: create Gradle release task - fix source distribution

vidakovic opened a new pull request #1299: URL: https://github.com/apache/fineract/pull/1299 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure these boxes are checked

[fineract] branch develop updated (9ef10c9 -> 11e4ce9)

This is an automated email from the ASF dual-hosted git repository. aleks pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from 9ef10c9 FINERACT-1088: Fixing error message from SMS campaigns add 7650897 FINERACT-1120-TFA-authentication-

[fineract] 01/01: FINERACT-1120: TFA authentication issue fix

This is an automated email from the ASF dual-hosted git repository. aleks pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git commit 11e4ce92edaa2ef5acab54796ace5a5aa0c9f7ae Merge: 9ef10c9 7650897 Author: Aleksandar Vidakovic AuthorDate: Thu Aug 27 23

[GitHub] [fineract] vidakovic merged pull request #1297: FINERACT-1120-TFA-authentication-issue-fix

vidakovic merged pull request #1297: URL: https://github.com/apache/fineract/pull/1297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[fineract] branch 1.4.0 updated: FINERACT-1134: Backport FINERACT-1129 to release branch 1.4.0

This is an automated email from the ASF dual-hosted git repository. aleks pushed a commit to branch 1.4.0 in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/1.4.0 by this push: new 78816d3 FINERACT-1134: Backport FINERACT-1129 to

[GitHub] [fineract] vidakovic merged pull request #1298: FINERACT-1134: Backport FINERACT-1129 to release branch 1.4.0

vidakovic merged pull request #1298: URL: https://github.com/apache/fineract/pull/1298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] awasum commented on pull request #1296: Fineract-1135 error at loan repayment

awasum commented on pull request #1296: URL: https://github.com/apache/fineract/pull/1296#issuecomment-682184132 Minor feedback for now and the future, Always use the issue number in all caps when using it in a commit message: `FINERACT-1135: Fix Error at Loan Repayment` will be commit mes

[fineract] branch 1.4.0 updated: FINERACT-1133 Added Mustache templates

This is an automated email from the ASF dual-hosted git repository. aleks pushed a commit to branch 1.4.0 in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/1.4.0 by this push: new 09bd459 FINERACT-1133 Added Mustache templates

[GitHub] [fineract] vidakovic merged pull request #1295: FINERACT-1133 [Backport PR] Added Mustache templates

vidakovic merged pull request #1295: URL: https://github.com/apache/fineract/pull/1295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] awasum merged pull request #1288: FINERACT-1088: Fixing error message from SMS campaigns

awasum merged pull request #1288: URL: https://github.com/apache/fineract/pull/1288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[fineract] branch develop updated: FINERACT-1088: Fixing error message from SMS campaigns

This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 9ef10c9 FINERACT-1088: Fixing error message

[GitHub] [fineract] vidakovic opened a new pull request #1298: FINERACT-1134: Backport FINERACT-1129 to release branch 1.4.0

vidakovic opened a new pull request #1298: URL: https://github.com/apache/fineract/pull/1298 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure these boxes are checked

[fineract] branch develop updated (a52526b -> e6d09d6)

This is an automated email from the ASF dual-hosted git repository. aleks pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from a52526b Added and Enforced RedundantModifier Checkstyle(2)(Fineract-821) add e6d09d6 FINERACT-1129: Gradle

[GitHub] [fineract] vidakovic merged pull request #1292: FINERACT-1129: Gradle task to create release package

vidakovic merged pull request #1292: URL: https://github.com/apache/fineract/pull/1292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] Grandolf49 commented on pull request #1285: FINERACT-1101 [Backport PR] Added Mustache templates to Swagger Codegen

Grandolf49 commented on pull request #1285: URL: https://github.com/apache/fineract/pull/1285#issuecomment-682148814 @vidakovic #1292 LGTM This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [fineract] fynmanoj commented on pull request #1297: FINERACT-1120-TFA-authentication-issue-fix

fynmanoj commented on pull request #1297: URL: https://github.com/apache/fineract/pull/1297#issuecomment-682140215 Kindly review and merge This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-682100056 @vorburger @ptuomola @xurror @awasum can you review this one? This is an automated message from the Ap

[fineract] branch develop updated (946bff4 -> a52526b)

This is an automated email from the ASF dual-hosted git repository. ptuomola pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from 946bff4 FINERACT-1128: Switching build script from httpie to curl to allow retries add a52526b Added and

[GitHub] [fineract] ptuomola merged pull request #1294: Added and Enforced RedundantModifier Checkstyle(2)(Fineract-821)

ptuomola merged pull request #1294: URL: https://github.com/apache/fineract/pull/1294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [fineract] thesmallstar commented on pull request #1294: Added and Enforced RedundantModifier Checkstyle(2)(Fineract-821)

thesmallstar commented on pull request #1294: URL: https://github.com/apache/fineract/pull/1294#issuecomment-682098338 @ptuomola @vorburger merge this? This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract] maektwain commented on pull request #1297: FINERACT-1120-TFA-authentication-issue-fix

maektwain commented on pull request #1297: URL: https://github.com/apache/fineract/pull/1297#issuecomment-682078879 Ah thanks for working on it This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [fineract] fynmanoj closed pull request #1297: FINERACT-1120-TFA-authentication-issue-fix

fynmanoj closed pull request #1297: URL: https://github.com/apache/fineract/pull/1297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [fineract] vidakovic commented on pull request #1292: FINERACT-1129: Gradle task to create release package

vidakovic commented on pull request #1292: URL: https://github.com/apache/fineract/pull/1292#issuecomment-682036066 @ptuomola @vorburger do you have anything else that's urgent to add to this improvement? If not I'd like to merge this to develop and port it back to branch 1.4.0.

[GitHub] [fineract] fynmanoj opened a new pull request #1297: FINERACT-1120-TFA-authentication-issue-fix

fynmanoj opened a new pull request #1297: URL: https://github.com/apache/fineract/pull/1297 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket In TFA the authToken was an instance of AnonymousAuthenticatio

[GitHub] [fineract] francisguchie opened a new pull request #1296: Fineract-1135 error at loan repayment

francisguchie opened a new pull request #1296: URL: https://github.com/apache/fineract/pull/1296 ## Description https://issues.apache.org/jira/browse/FINERACT-1135 ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] C

[GitHub] [fineract] xurror merged pull request #1289: FINERACT-1128: Switching build script from httpie to curl to allow retries

xurror merged pull request #1289: URL: https://github.com/apache/fineract/pull/1289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[fineract] branch develop updated: FINERACT-1128: Switching build script from httpie to curl to allow retries

This is an automated email from the ASF dual-hosted git repository. kaze pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 946bff4 FINERACT-1128: Switching build script

[GitHub] [fineract] Grandolf49 opened a new pull request #1295: FINERACT-1133 [Backport PR] Added Mustache templates

Grandolf49 opened a new pull request #1295: URL: https://github.com/apache/fineract/pull/1295 ## Description This is a backport PR for `1.4.0` branch. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Commit messag

[GitHub] [fineract] thesmallstar closed pull request #1294: Added and Enforced RedundantModifier Checkstyle(2)(Fineract-821)

thesmallstar closed pull request #1294: URL: https://github.com/apache/fineract/pull/1294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fineract] thesmallstar commented on pull request #1294: Added and Enforced RedundantModifier Checkstyle(2)(Fineract-821)

thesmallstar commented on pull request #1294: URL: https://github.com/apache/fineract/pull/1294#issuecomment-681834430 Closing and reopening, This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [fineract] thesmallstar commented on a change in pull request #1286: Removed string concatenated SQL & sqlSearch from Staff (Fineract-854)

thesmallstar commented on a change in pull request #1286: URL: https://github.com/apache/fineract/pull/1286#discussion_r478280829 ## File path: fineract-provider/src/main/java/org/apache/fineract/organisation/staff/api/StaffApiResource.java ## @@ -118,7 +118,6 @@ public StaffA

[GitHub] [fineract] vidakovic commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package

vidakovic commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478252724 ## File path: README.md ## @@ -353,6 +353,41 @@ Releasing [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents t

[GitHub] [fineract] vidakovic commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package

vidakovic commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478248382 ## File path: README.md ## @@ -353,6 +353,41 @@ Releasing [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents t

[GitHub] [fineract] vidakovic commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package

vidakovic commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478241724 ## File path: README.md ## @@ -353,6 +353,41 @@ Releasing [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents t

[GitHub] [fineract] ptuomola commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package

ptuomola commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478230261 ## File path: README.md ## @@ -353,6 +353,41 @@ Releasing [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents th

[GitHub] [fineract] ptuomola commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package

ptuomola commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478228878 ## File path: fineract-provider/gradle.properties ## @@ -16,5 +16,5 @@ # specific language governing permissions and limitations # under the License.

[GitHub] [fineract] ptuomola commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package

ptuomola commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478228042 ## File path: README.md ## @@ -353,6 +353,41 @@ Releasing [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents th

[GitHub] [fineract] vidakovic commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package

vidakovic commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478224103 ## File path: fineract-provider/gradle.properties ## @@ -16,5 +16,5 @@ # specific language governing permissions and limitations # under the License.

[GitHub] [fineract] vidakovic commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package

vidakovic commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478221642 ## File path: README.md ## @@ -353,6 +353,41 @@ Releasing [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents t

[GitHub] [fineract] vidakovic commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package

vidakovic commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478220925 ## File path: README.md ## @@ -353,6 +353,41 @@ Releasing [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents t

[GitHub] [fineract] vidakovic commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package

vidakovic commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478218228 ## File path: README.md ## @@ -353,6 +353,41 @@ Releasing [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents t