jdailey commented on PR #3851:
URL: https://github.com/apache/fineract/pull/3851#issuecomment-2048729770
The ticket wasn't linked properly to the changes. @alberto-art3ch .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
jdailey pushed a change to tag 1.10
in repository https://gitbox.apache.org/repos/asf/fineract.git
at fe85677d6 (commit)
No new revisions were added by this update.
alberto-art3ch opened a new pull request, #3859:
URL: https://github.com/apache/fineract/pull/3859
## Description
There is a NoSuchElementException when the Loan COB is executed in some
specific scenario.
[FINERACT-1926](https://issues.apache.org/jira/browse/FINERACT-1926)
alberto-art3ch commented on code in PR #3856:
URL: https://github.com/apache/fineract/pull/3856#discussion_r1560068715
##
integration-tests/src/test/java/org/apache/fineract/integrationtests/investor/externalassetowner/InitiateExternalAssetOwnerTransferTest.java:
##
@@ -933,6
alberto-art3ch commented on code in PR #3836:
URL: https://github.com/apache/fineract/pull/3836#discussion_r1560064338
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelRepaymentPeriod.java:
##
@@ -55,6 +55,13 @@
This is an automated email from the ASF dual-hosted git repository.
adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new fe85677d6 FINERACT-1971: Fix loan cob
adamsaghy merged PR #3858:
URL: https://github.com/apache/fineract/pull/3858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
adamsaghy pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
from d7a4e0e95 FINERACT-1932: Fineract modularization - fineract-branch
add a7ad33abf FINERACT-2042: Fix
adamsaghy merged PR #3855:
URL: https://github.com/apache/fineract/pull/3855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adamsaghy commented on code in PR #3854:
URL: https://github.com/apache/fineract/pull/3854#discussion_r1559279265
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountAssociationsReadPlatformServiceImpl.java:
##
@@ -18,86 +18,101 @@
*/
adamsaghy commented on code in PR #3854:
URL: https://github.com/apache/fineract/pull/3854#discussion_r1559280017
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountAssociationsReadPlatformServiceImpl.java:
##
@@ -18,86 +18,101 @@
*/
adamsaghy commented on code in PR #3854:
URL: https://github.com/apache/fineract/pull/3854#discussion_r1559279265
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountAssociationsReadPlatformServiceImpl.java:
##
@@ -18,86 +18,101 @@
*/
adamsaghy commented on code in PR #3856:
URL: https://github.com/apache/fineract/pull/3856#discussion_r1559251985
##
fineract-provider/src/test/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStepTest.java:
##
@@ -175,4 +184,27 @@ public void
adamsaghy commented on code in PR #3856:
URL: https://github.com/apache/fineract/pull/3856#discussion_r1559247899
##
fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java:
##
@@ -49,10 +52,13 @@ public Loan execute(Loan loan) {
adamsaghy commented on code in PR #3856:
URL: https://github.com/apache/fineract/pull/3856#discussion_r1559247899
##
fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java:
##
@@ -49,10 +52,13 @@ public Loan execute(Loan loan) {
adamsaghy commented on code in PR #3856:
URL: https://github.com/apache/fineract/pull/3856#discussion_r1559243519
##
fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java:
##
@@ -71,4 +77,12 @@ public String getEnumStyledName()
adamsaghy commented on code in PR #3856:
URL: https://github.com/apache/fineract/pull/3856#discussion_r1559242511
##
integration-tests/src/test/java/org/apache/fineract/integrationtests/investor/externalassetowner/InitiateExternalAssetOwnerTransferTest.java:
##
@@ -933,6
adamsaghy commented on code in PR #3854:
URL: https://github.com/apache/fineract/pull/3854#discussion_r1559165827
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/jobs/executestandinginstructions/ExecuteStandingInstructionsTasklet.java:
##
@@ -151,17
adamsaghy commented on code in PR #3854:
URL: https://github.com/apache/fineract/pull/3854#discussion_r1559166553
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/jobs/executestandinginstructions/ExecuteStandingInstructionsTasklet.java:
##
@@ -151,17
adamsaghy commented on code in PR #3854:
URL: https://github.com/apache/fineract/pull/3854#discussion_r1559161789
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/jobs/executestandinginstructions/ExecuteStandingInstructionsTasklet.java:
##
@@ -113,8
adamsaghy opened a new pull request, #3858:
URL: https://github.com/apache/fineract/pull/3858
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy commented on code in PR #3836:
URL: https://github.com/apache/fineract/pull/3836#discussion_r1559021163
##
integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java:
##
@@ -3819,6 +3819,126 @@ public
adamsaghy commented on code in PR #3836:
URL: https://github.com/apache/fineract/pull/3836#discussion_r1559020673
##
integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java:
##
@@ -3819,6 +3819,126 @@ public
adamsaghy commented on code in PR #3836:
URL: https://github.com/apache/fineract/pull/3836#discussion_r1559017008
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelRepaymentPeriod.java:
##
@@ -55,6 +55,13 @@ public
24 matches
Mail list logo
