adamsaghy commented on code in PR #3926:
URL: https://github.com/apache/fineract/pull/3926#discussion_r1635307544
##
fineract-core/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java:
##
@@ -102,6 +103,11 @@ public CommandProcessingResult
alberto-art3ch commented on code in PR #3926:
URL: https://github.com/apache/fineract/pull/3926#discussion_r1635299863
##
fineract-core/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java:
##
@@ -102,6 +103,11 @@ public
alberto-art3ch commented on code in PR #3926:
URL: https://github.com/apache/fineract/pull/3926#discussion_r1635299487
##
fineract-core/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java:
##
@@ -102,6 +103,11 @@ public
adamsaghy commented on code in PR #3926:
URL: https://github.com/apache/fineract/pull/3926#discussion_r1635254306
##
fineract-core/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java:
##
@@ -102,6 +103,11 @@ public CommandProcessingResult
adamsaghy commented on code in PR #3926:
URL: https://github.com/apache/fineract/pull/3926#discussion_r1635251820
##
fineract-core/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java:
##
@@ -102,6 +103,11 @@ public CommandProcessingResult
adamsaghy opened a new pull request, #3928:
URL: https://github.com/apache/fineract/pull/3928
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy opened a new pull request, #3927:
URL: https://github.com/apache/fineract/pull/3927
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy merged PR #3925:
URL: https://github.com/apache/fineract/pull/3925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adamsaghy merged PR #3919:
URL: https://github.com/apache/fineract/pull/3919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adamsaghy commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634957165
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -4796,33 +4434,11 @@ public LoanTransaction
adamsaghy commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634938390
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -3663,14 +3407,10 @@ private ChangedTransactionDetail
adamsaghy commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634900201
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -3292,54 +3069,40 @@ private boolean
adamsaghy commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634888930
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -3292,54 +3069,40 @@ private boolean
kjozsa commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634761490
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -3286,60 +3063,36 @@ private void handleLoanOverpayment(LocalDate
janez89 commented on code in PR #3919:
URL: https://github.com/apache/fineract/pull/3919#discussion_r1634744121
##
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculationResult.java:
##
@@ -16,29 +16,28 @@
* specific language
adamsaghy commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634743321
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -3286,60 +3063,36 @@ private void handleLoanOverpayment(LocalDate
adamsaghy commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634742472
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -3286,60 +3063,36 @@ private void handleLoanOverpayment(LocalDate
kjozsa commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634660945
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -769,10 +773,6 @@ public ChangedTransactionDetail
adamsaghy commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634527467
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -769,10 +773,6 @@ public ChangedTransactionDetail
adamsaghy commented on code in PR #3924:
URL: https://github.com/apache/fineract/pull/3924#discussion_r1634523217
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -208,106 +187,123 @@ public class Loan extends
alberto-art3ch opened a new pull request, #3926:
URL: https://github.com/apache/fineract/pull/3926
## Description
Seems when too long idempotency id was added, HTTP 403 was raised, but the
name and message is weird. Check and fix it
galovics merged PR #3916:
URL: https://github.com/apache/fineract/pull/3916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ruchiD opened a new pull request, #3925:
URL: https://github.com/apache/fineract/pull/3925
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy merged PR #3923:
URL: https://github.com/apache/fineract/pull/3923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adamsaghy merged PR #3914:
URL: https://github.com/apache/fineract/pull/3914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kjozsa opened a new pull request, #3924:
URL: https://github.com/apache/fineract/pull/3924
## Description
This PR is part of a larger changeset, covered by the ticket FINERACT-2090,
aiming to seriously improve the Loan module's code quality. These changes focus
solely on cleaning up
marta-jankovics commented on PR #3922:
URL: https://github.com/apache/fineract/pull/3922#issuecomment-2158596534
@galovics please see the description on the ticket
https://issues.apache.org/jira/browse/FINERACT-2091
this PR is the first part of introducing string type primary keys
--
adamsaghy closed pull request #3914: FINERACT-1932: Fineract modularization -
fineract-loan
URL: https://github.com/apache/fineract/pull/3914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
adamsaghy merged PR #3921:
URL: https://github.com/apache/fineract/pull/3921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
galovics commented on code in PR #3916:
URL: https://github.com/apache/fineract/pull/3916#discussion_r1633140965
##
integration-tests/ReadMe.md:
##
@@ -0,0 +1,17 @@
+# Run integration tests
+
+## Prerequisites
+- A running Fineract instance is required
+
+## Default
galovics commented on code in PR #3921:
URL: https://github.com/apache/fineract/pull/3921#discussion_r1633137949
##
fineract-core/src/main/java/org/apache/fineract/portfolio/note/domain/NoteType.java:
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
adamsaghy opened a new pull request, #3923:
URL: https://github.com/apache/fineract/pull/3923
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy commented on code in PR #3919:
URL: https://github.com/apache/fineract/pull/3919#discussion_r1632987113
##
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculator.java:
##
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache
janez89 commented on code in PR #3919:
URL: https://github.com/apache/fineract/pull/3919#discussion_r1632981353
##
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculator.java:
##
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache
janez89 commented on code in PR #3919:
URL: https://github.com/apache/fineract/pull/3919#discussion_r1632955579
##
fineract-progressive-loan/src/test/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculatorTest.java:
##
@@ -6,9 +6,9 @@
* to you under the Apache
adamsaghy commented on code in PR #3919:
URL: https://github.com/apache/fineract/pull/3919#discussion_r1632920757
##
fineract-progressive-loan/src/test/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculatorTest.java:
##
@@ -6,9 +6,9 @@
* to you under the Apache
adamsaghy commented on code in PR #3919:
URL: https://github.com/apache/fineract/pull/3919#discussion_r1632919185
##
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculator.java:
##
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache
adamsaghy commented on code in PR #3919:
URL: https://github.com/apache/fineract/pull/3919#discussion_r1632916918
##
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculationResult.java:
##
@@ -16,29 +16,28 @@
* specific language
marta-jankovics commented on code in PR #3921:
URL: https://github.com/apache/fineract/pull/3921#discussion_r1632892593
##
fineract-core/src/main/java/org/apache/fineract/portfolio/note/domain/NoteType.java:
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software
galovics commented on code in PR #3921:
URL: https://github.com/apache/fineract/pull/3921#discussion_r1632256881
##
fineract-core/src/main/java/org/apache/fineract/portfolio/note/domain/NoteType.java:
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
galovics commented on PR #3922:
URL: https://github.com/apache/fineract/pull/3922#issuecomment-2156511841
@marta-jankovics do you mind explaining why this is needed? The JIRA ticket
referenced is literally empty and the changeset is huge. Also, I see an
unrelated commit, pls clean that up
marta-jankovics opened a new pull request, #3922:
URL: https://github.com/apache/fineract/pull/3922
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
marta-jankovics opened a new pull request, #3921:
URL: https://github.com/apache/fineract/pull/3921
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
vidakovic commented on PR #3918:
URL: https://github.com/apache/fineract/pull/3918#issuecomment-2155889671
Just one caveat: we can run ON JDK 21, but we can not compile TO JDK 21
language version... Eclipse Link is only supporting Java 17. FYI
--
This is an automated message from the
adamsaghy closed pull request #3920: Test pr
URL: https://github.com/apache/fineract/pull/3920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adamsaghy opened a new pull request, #3920:
URL: https://github.com/apache/fineract/pull/3920
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy closed pull request #3910: FINERACT-1932: Fineract modularization -
custom modules
URL: https://github.com/apache/fineract/pull/3910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
janez89 opened a new pull request, #3919:
URL: https://github.com/apache/fineract/pull/3919
## Description
EMI Calculation with 100% code coverage and without caller side logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
IOhacker commented on PR #3918:
URL: https://github.com/apache/fineract/pull/3918#issuecomment-2154045087
@jdailey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
IOhacker opened a new pull request, #3918:
URL: https://github.com/apache/fineract/pull/3918
## Description
Describe the changes made and why they were made.
Upgrade JDK 17 LTS to JDK 21 LTS
Upgrade Gradle file (Jib) for building in a JDK 21 LTS docker image.
Upgrade
IOhacker closed pull request #3917: FINERACT-2094 Upgrade to JDK 21 LTS
URL: https://github.com/apache/fineract/pull/3917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
IOhacker opened a new pull request, #3917:
URL: https://github.com/apache/fineract/pull/3917
## Description
Describe the changes made and why they were made.
Upgrade JDK 17 LTS to JDK 21 LTS
Upgrade Gradle file (Jib) for building in a JDK 21 LTS docker image.
Upgrade
adamsaghy opened a new pull request, #3916:
URL: https://github.com/apache/fineract/pull/3916
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy merged PR #3909:
URL: https://github.com/apache/fineract/pull/3909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adamsaghy commented on code in PR #3909:
URL: https://github.com/apache/fineract/pull/3909#discussion_r1629893918
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/mapper/LoanChargeMapper.java:
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software
adamsaghy commented on code in PR #3909:
URL: https://github.com/apache/fineract/pull/3909#discussion_r1629887892
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/mapper/LoanChargeMapper.java:
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software
vidakovic commented on code in PR #3909:
URL: https://github.com/apache/fineract/pull/3909#discussion_r1629802832
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/mapper/LoanChargeMapper.java:
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software
vidakovic commented on code in PR #3909:
URL: https://github.com/apache/fineract/pull/3909#discussion_r1629794928
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/command/LoanChargeCommand.java:
##
@@ -18,44 +18,26 @@
*/
package
adamsaghy commented on PR #3909:
URL: https://github.com/apache/fineract/pull/3909#issuecomment-2152809122
@taskain7 @vidakovic @kjozsa @ruchiD @alberto-art3ch Please as your time
lets you give me a review. I know this is a monster PR, but it was
unfortunately required to have a clearer
adamsaghy commented on code in PR #3909:
URL: https://github.com/apache/fineract/pull/3909#discussion_r1629405267
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanDisbursementDetailsAssembler.java:
##
@@ -0,0 +1,83 @@
+/**
+ * Licensed to
adamsaghy commented on code in PR #3909:
URL: https://github.com/apache/fineract/pull/3909#discussion_r1629405267
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanDisbursementDetailsAssembler.java:
##
@@ -0,0 +1,83 @@
+/**
+ * Licensed to
adamsaghy merged PR #3913:
URL: https://github.com/apache/fineract/pull/3913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vidakovic commented on PR #3915:
URL: https://github.com/apache/fineract/pull/3915#issuecomment-2151720891
@Zeyad2003 let's organize a call... I have some more information for you.
Let's leave this PR for the moment as it is, please do not merge.
--
This is an automated message from the
Zeyad2003 opened a new pull request, #3915:
URL: https://github.com/apache/fineract/pull/3915
- Accept fields as a query parameter to filter the response based on its
content.
- Use Jackson dynamic filter with `@JsonFilter` to filter the response data
within `fields` query parameter.
github-actions[bot] closed pull request #3331: FINERACT-1956: Added the
skeleton structure necessary to publish doc …
URL: https://github.com/apache/fineract/pull/3331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] closed pull request #3630: FINERACT-2005: Prohibit password
re-use
URL: https://github.com/apache/fineract/pull/3630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alberto-art3ch commented on PR #3914:
URL: https://github.com/apache/fineract/pull/3914#issuecomment-2148028562
> LGTM, Please check if we need to update persistence.xml of all the modules
that depend on fineract-loan , with the domain entities that are now moved to
fineract-loan.
borikas commented on PR #3854:
URL: https://github.com/apache/fineract/pull/3854#issuecomment-2147437664
> > > @adamsaghy I'm sorry for the delay. (I thought I could quickly deal
with the problem and then write back, but no). I'm a bit stuck with these two
tests right now:
adamsaghy commented on PR #3854:
URL: https://github.com/apache/fineract/pull/3854#issuecomment-2147340113
> > @adamsaghy I'm sorry for the delay. (I thought I could quickly deal with
the problem and then write back, but no). I'm a bit stuck with these two tests
right now:
borikas commented on PR #3854:
URL: https://github.com/apache/fineract/pull/3854#issuecomment-2147331661
> @adamsaghy I'm sorry for the delay. (I thought I could quickly deal with
the problem and then write back, but no). I'm a bit stuck with these two tests
right now:
kjozsa commented on code in PR #3909:
URL: https://github.com/apache/fineract/pull/3909#discussion_r1624569729
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanDisbursementDetailsAssembler.java:
##
@@ -0,0 +1,83 @@
+/**
+ * Licensed to
ruchiD commented on code in PR #3913:
URL: https://github.com/apache/fineract/pull/3913#discussion_r1624405631
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -1389,6 +1387,12 @@ private void applyPeriodicAccruals(final
adamsaghy commented on code in PR #3913:
URL: https://github.com/apache/fineract/pull/3913#discussion_r1624305864
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -1389,6 +1387,12 @@ private void applyPeriodicAccruals(final
adamsaghy commented on code in PR #3913:
URL: https://github.com/apache/fineract/pull/3913#discussion_r1623632657
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##
@@ -1389,6 +1389,11 @@ private void applyPeriodicAccruals(final
alberto-art3ch opened a new pull request, #3914:
URL: https://github.com/apache/fineract/pull/3914
## Description
Update to fineract-loan module - used as Loan domain module classes,
interfaces and services
[FINERACT-1932](https://issues.apache.org/jira/browse/FINERACT-1932)
ruchiD opened a new pull request, #3913:
URL: https://github.com/apache/fineract/pull/3913
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
IOhacker closed pull request #3912: FINERACT-2089 Upgrade java
dependencies/libraries
URL: https://github.com/apache/fineract/pull/3912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
IOhacker commented on PR #3912:
URL: https://github.com/apache/fineract/pull/3912#issuecomment-2141286437
I will close this PR, the org.owasp.antisamy:antisamy is a dependency of
org.owasp.esapi:esapi and the com.nimbusds:nimbus-jose-jwt is dependency of
IOhacker closed pull request #3912: FINERACT-2089 Upgrade java
dependencies/libraries
URL: https://github.com/apache/fineract/pull/3912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
IOhacker commented on PR #3912:
URL: https://github.com/apache/fineract/pull/3912#issuecomment-2141069262
@jdailey @adamsaghy @vidakovic @galovics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
IOhacker opened a new pull request, #3912:
URL: https://github.com/apache/fineract/pull/3912
## Description
FINERACT-2089 Upgrade java dependencies/libraries
Ignore if these details are present on the associated [Apache Fineract JIRA
FintecheandoMX closed pull request #3911: FINERACT-2089 Upgrade java
dependencies/libraries
URL: https://github.com/apache/fineract/pull/3911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
IOhacker opened a new pull request, #3911:
URL: https://github.com/apache/fineract/pull/3911
## Description
FINERACT-2089 Upgrade java dependencies/libraries
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy commented on PR #3906:
URL: https://github.com/apache/fineract/pull/3906#issuecomment-2140594729
> Can we remove quartz dependency? For now, let's keep the quartz
dependency "as is" and make a note that this CVE doesn't apply. But didn't we
already deprecate the quartz when we
IOhacker merged PR #3906:
URL: https://github.com/apache/fineract/pull/3906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jdailey commented on PR #3906:
URL: https://github.com/apache/fineract/pull/3906#issuecomment-2140348701
Can we remove quartz dependency? For now, let's keep the quartz dependency
"as is" and make a note that this CVE doesn't apply. But didn't we already
deprecate the quartz when we
IOhacker commented on code in PR #3906:
URL: https://github.com/apache/fineract/pull/3906#discussion_r1620856965
##
buildSrc/src/main/groovy/org.apache.fineract.dependencies.gradle:
##
@@ -68,7 +68,7 @@ dependencyManagement {
exclude 'org.codehaus.groovy:groovy'
marta-jankovics opened a new pull request, #3910:
URL: https://github.com/apache/fineract/pull/3910
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy opened a new pull request, #3909:
URL: https://github.com/apache/fineract/pull/3909
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy merged PR #3908:
URL: https://github.com/apache/fineract/pull/3908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adamsaghy commented on PR #3881:
URL: https://github.com/apache/fineract/pull/3881#issuecomment-2137810696
@wkigenyi Seems the cashier transaction API does not working with postgres
database. Can you please take a look on it? It might requires different SQL for
postgres database. You can
wkigenyi commented on PR #3881:
URL: https://github.com/apache/fineract/pull/3881#issuecomment-2137783428
@adamsaghy I have 1/8 failing
org.apache.fineract.client.util.CallFailedRuntimeException: HTTP failed:
Request{method=GET,
adamsaghy merged PR #3907:
URL: https://github.com/apache/fineract/pull/3907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adamsaghy opened a new pull request, #3908:
URL: https://github.com/apache/fineract/pull/3908
…oned tags
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy commented on PR #3908:
URL: https://github.com/apache/fineract/pull/3908#issuecomment-2137643916
@jdailey FYI
@vidakovic FYI
@galovics FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
adamsaghy commented on PR #3881:
URL: https://github.com/apache/fineract/pull/3881#issuecomment-2137593747
> @adamsaghy why are the last two checks here taking more than 24 hours ?
1.Fineract Build & Test - PostgreSQL / build 2.Fineract Docker build -
PostgreSQL / build
Seems they
wkigenyi commented on PR #3881:
URL: https://github.com/apache/fineract/pull/3881#issuecomment-2137571822
@adamsaghy why are the last two checks here taking more than 24 hours ?
1.Fineract Build & Test - PostgreSQL / build
2.Fineract Docker build - PostgreSQL / build
--
This is an
adamsaghy commented on code in PR #3907:
URL: https://github.com/apache/fineract/pull/3907#discussion_r1618789219
##
integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java:
##
@@ -4106,6 +4108,184 @@ public
somasorosdpc opened a new pull request, #3907:
URL: https://github.com/apache/fineract/pull/3907
## Description
* Add integration test case for chargeback on progressive loan
Ignore if these details are present on the associated [Apache Fineract JIRA
adamsaghy commented on code in PR #3906:
URL: https://github.com/apache/fineract/pull/3906#discussion_r1618690282
##
buildSrc/src/main/groovy/org.apache.fineract.dependencies.gradle:
##
@@ -68,7 +68,7 @@ dependencyManagement {
exclude 'org.codehaus.groovy:groovy'
1 - 100 of 4279 matches
Mail list logo
