[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-21 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r369155919 ## File path: src/c_api/c_api.cc ## @@ -563,11 +587,21 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-21 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r369155919 ## File path: src/c_api/c_api.cc ## @@ -563,11 +587,21 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-21 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r369154109 ## File path: src/c_api/c_api.cc ## @@ -408,24 +452,13 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-21 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r369153621 ## File path: src/c_api/c_api.cc ## @@ -164,39 +186,60 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-21 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r369133681 ## File path: include/mxnet/lib_api.h ## @@ -740,68 +787,81 @@ class Registry { typedef int

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367714197 ## File path: src/c_api/c_api.cc ## @@ -450,32 +480,59 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367713381 ## File path: include/mxnet/lib_api.h ## @@ -833,20 +891,26 @@ extern "C" { #else void

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367713125 ## File path: include/mxnet/lib_api.h ## @@ -833,20 +891,26 @@ extern "C" { #else void

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367711041 ## File path: include/mxnet/lib_api.h ## @@ -763,9 +818,9 @@ typedef int

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367703387 ## File path: src/c_api/c_api.cc ## @@ -685,28 +757,26 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367703437 ## File path: src/c_api/c_api.cc ## @@ -685,28 +757,26 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367703072 ## File path: src/c_api/c_api.cc ## @@ -450,32 +480,59 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367702747 ## File path: src/c_api/c_api.cc ## @@ -635,11 +698,20 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367701262 ## File path: src/c_api/c_api.cc ## @@ -450,32 +480,59 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367700687 ## File path: src/c_api/c_api.cc ## @@ -97,9 +97,31 @@ inline int

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367700150 ## File path: include/mxnet/lib_api.h ## @@ -982,17 +1045,22 @@ extern "C" { // create

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367698887 ## File path: include/mxnet/lib_api.h ## @@ -602,12 +649,18 @@ class CustomOp { isSGop

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367697443 ## File path: include/mxnet/lib_api.h ## @@ -566,16 +609,20 @@ typedef MXReturnValue

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367697443 ## File path: include/mxnet/lib_api.h ## @@ -566,16 +609,20 @@ typedef MXReturnValue

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367696078 ## File path: include/mxnet/lib_api.h ## @@ -215,25 +225,43 @@ struct MXTensor {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367696078 ## File path: include/mxnet/lib_api.h ## @@ -215,25 +225,43 @@ struct MXTensor {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-15 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367251787 ## File path: src/c_api/c_api.cc ## @@ -720,8 +751,11 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-15 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367251499 ## File path: src/c_api/c_api.cc ## @@ -720,8 +751,11 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-15 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367251499 ## File path: src/c_api/c_api.cc ## @@ -720,8 +751,11 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-13 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r366123444 ## File path: src/c_api/c_api.cc ## @@ -720,8 +751,11 @@ int MXLoadLib(const char *path) {