[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-09-09 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r216173282 ## File path: include/mxnet/ndarray.h ## @@ -831,7 +855,7 @@ class NDArray { Chunk(const

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-09-09 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r216173212 ## File path: include/mxnet/tensor_blob.h ## @@ -89,7 +92,8 @@ class TBlob { template

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-11 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209430981 ## File path: python/mxnet/_ctypes/ndarray.py ## @@ -31,21 +31,24 @@ class NDArrayBase(object):

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-11 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209430981 ## File path: python/mxnet/_ctypes/ndarray.py ## @@ -31,21 +31,24 @@ class NDArrayBase(object):

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-10 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209416606 ## File path: include/mxnet/c_api.h ## @@ -737,6 +741,57 @@ MXNET_DLL int

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-10 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209416606 ## File path: include/mxnet/c_api.h ## @@ -737,6 +741,57 @@ MXNET_DLL int

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-10 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209416606 ## File path: include/mxnet/c_api.h ## @@ -737,6 +741,57 @@ MXNET_DLL int

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-10 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209413382 ## File path: include/mxnet/c_api.h ## @@ -737,6 +741,57 @@ MXNET_DLL int

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-10 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209298986 ## File path: python/mxnet/_ctypes/ndarray.py ## @@ -31,21 +31,24 @@ class NDArrayBase(object):

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-10 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209298810 ## File path: python/mxnet/_ctypes/ndarray.py ## @@ -31,21 +31,24 @@ class NDArrayBase(object):

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-10 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209298235 ## File path: include/mxnet/c_api.h ## @@ -737,6 +741,57 @@ MXNET_DLL int

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-10 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209298039 ## File path: include/mxnet/c_api.h ## @@ -737,6 +741,57 @@ MXNET_DLL int

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-09 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209143790 ## File path: src/c_api/c_api.cc ## @@ -494,6 +494,57 @@ int MXNDArrayGetData(NDArrayHandle

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-09 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209143649 ## File path: python/mxnet/ndarray/ndarray.py ## @@ -3851,3 +3898,117 @@ def histogram(a, bins=10,

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-09 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209143480 ## File path: include/mxnet/c_api.h ## @@ -737,6 +741,57 @@ MXNET_DLL int

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-09 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209143434 ## File path: include/mxnet/c_api.h ## @@ -737,6 +741,57 @@ MXNET_DLL int

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-09 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209143369 ## File path: python/mxnet/_ctypes/ndarray.py ## @@ -31,21 +31,24 @@ class NDArrayBase(object):

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-09 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209142905 ## File path: python/mxnet/_ctypes/ndarray.py ## @@ -31,21 +31,24 @@ class NDArrayBase(object):

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-09 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209127635 ## File path: python/mxnet/_ctypes/ndarray.py ## @@ -31,21 +31,24 @@ class NDArrayBase(object):

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-09 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r209027699 ## File path: python/mxnet/_ctypes/ndarray.py ## @@ -31,21 +31,24 @@ class NDArrayBase(object):

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-08 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r208659503 ## File path: python/mxnet/_ctypes/ndarray.py ## @@ -31,21 +31,24 @@ class NDArrayBase(object):

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-08 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r208658830 ## File path: include/mxnet/c_api.h ## @@ -737,6 +741,57 @@ MXNET_DLL int

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-08 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r208659199 ## File path: include/mxnet/tensor_blob.h ## @@ -104,6 +104,14 @@ class TBlob { :

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-08 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r208659252 ## File path: include/mxnet/tensor_blob.h ## @@ -104,6 +104,14 @@ class TBlob { :

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-06 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r207953711 ## File path: python/mxnet/_ctypes/ndarray.py ## @@ -31,10 +31,10 @@ class NDArrayBase(object):

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-06 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r207954135 ## File path: src/ndarray/ndarray.cc ## @@ -312,6 +312,46 @@ NDArray NDArray::data_ndarray() const

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-06 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r207954074 ## File path: src/ndarray/ndarray.cc ## @@ -312,6 +312,46 @@ NDArray NDArray::data_ndarray() const

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-06 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r207953809 ## File path: python/mxnet/cython/ndarray.pyx ## @@ -52,12 +53,15 @@ cdef class NDArrayBase:

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

2018-08-06 Thread GitBox
tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r207954223 ## File path: src/ndarray/ndarray.cc ## @@ -312,6 +312,46 @@ NDArray NDArray::data_ndarray() const