xiaoxiang781216 merged PR #11423:
URL: https://github.com/apache/nuttx/pull/11423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1439382280
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1439381968
##
drivers/mtd/Kconfig:
##
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the XX
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1437750494
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
acassis commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1437749238
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed
acassis commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1435880084
##
drivers/mtd/Kconfig:
##
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the X
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1435124953
##
drivers/mtd/Kconfig:
##
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the XX
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1435117709
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
acassis commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1435077054
##
drivers/mtd/Kconfig:
##
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the X
TimJTi commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1866742724
I'm seeing issues, perhaps because of adding the erase function (which also
takes a while and I still think is unnecessary) but perhaps something else.
I will mark it ready for review ag
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433920441
##
drivers/mtd/Kconfig:
##
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the XX
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433920441
##
drivers/mtd/Kconfig:
##
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the XX
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433915389
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433917123
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433912215
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433867605
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433864257
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
xiaoxiang781216 commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433800036
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * L
slorquet commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433794899
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed
xiaoxiang781216 commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433785235
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * L
xiaoxiang781216 commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433785235
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * L
slorquet commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433764849
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed
slorquet commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433764849
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed
xiaoxiang781216 commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433356999
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * L
xiaoxiang781216 commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433353129
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * L
xiaoxiang781216 commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433352237
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * L
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1432999629
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433008934
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433006013
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433006847
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433006013
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1433003076
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1432999629
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1432995814
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1432993953
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1432992830
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1432992830
##
drivers/mtd/at25ee.c:
##
@@ -0,0 +1,1033 @@
+/
+ * drivers/mtd/at25ee.c
+ *
+ * Licensed t
TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1432991702
##
drivers/mtd/Kconfig:
##
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the XX
acassis commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1432927238
##
drivers/mtd/Kconfig:
##
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the X
TimJTi commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1864404767
Pushed minor update with SPI_SETDELAY functionality, to speed up accesses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
TimJTi commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1863229133
> > I still can't see the error in the CI logs thought? May be I "can't see
for looking"?
>
> Errors and warnings reported by Kconfig are not printed in CI and this is
the root of t
raiden00pl commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1863227146
> I still can't see the error in the CI logs thought? May be I "can't see
for looking"?
Errors and warning reported by Kconfig are not printed in CI and this is the
root of the
TimJTi commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1863218200
Thank you! I was 99% sure it was Kconfig related but couldn't spot the
error. This has bitten me before :(
1. I still can't see the error in the CI logs thought? May be I "can't see
raiden00pl commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1863210185
according to the first failure reported by CI
https://github.com/apache/nuttx/actions/runs/7265338667/job/19794901605?pr=11423#step:7:75,
you can try compile this locally:
```
TimJTi commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1863099584
Thanks for taking time to reply. I am finding some logical/programmatic
errors at the moment so will leave it as a draft and once I am sure it is 100%
working on my test bed I will go thro
slorquet commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1863095849
I edited my message to remove my remark because I missed that you had
already run it. I have no miraculous way to run it, and I still get errors
after sending a checked pull request.
TimJTi commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1863077891
I very definitely do run checkpatch.sh before subbitting a PR.
If I run:
`./tools/checkpatch.sh -f drivers/mtd/at25ee.c`
I get NO ERRORS!!!
It had found loads, wh
slorquet commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1863066028
Yes, the CI as implemented in this project is the worst user experience I
have experimented EVER. And I mean that litterally. It is an absolute NIGHTMARE
of inconsistent web pages with r
TimJTi commented on PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#issuecomment-1863032289
As per usual ABSOLUTELY NO IDEA why this is failing CI. It passes
checkpatch. No clues in CI output is NOT helpful.
--
This is an automated message from the Apache Git Service.
To respon
TimJTi opened a new pull request, #11423:
URL: https://github.com/apache/nuttx/pull/11423
## Summary
Adds MTD driver for AT25 SPI EEPROM devices, based on character driver code
by @slorquet and the existing at24xx.c block driver code
## Impact
None.
## Testing
Custom b
50 matches
Mail list logo
