xiaoxiang781216 merged pull request #49:
URL: https://github.com/apache/incubator-nuttx-testing/pull/49
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git
The following commit(s) were added to refs/heads/master by this push:
new 03707e5
Ouss4 commented on pull request #1312:
URL: https://github.com/apache/incubator-nuttx/pull/1312#issuecomment-652384926
@xiaoxiang781216 This change, and commit
https://github.com/apache/incubator-nuttx/commit/d17b963bcab98e2d2f641623547837a8d3fe94cd
breaks some default configurations, for
davids5 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448291057
##
File path: include/nuttx/compiler.h
##
@@ -255,15 +255,6 @@
# undef CONFIG_PTR_IS_NOT_INT
#endif
-/* GCC supports inlined functions for
jerpelea commented on pull request #49:
URL:
https://github.com/apache/incubator-nuttx-testing/pull/49#issuecomment-652315886
thanks
This is an automated message from the Apache Git Service.
To respond to the message,
jerpelea commented on pull request #315:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/315#issuecomment-652326090
please add commit message
This is an automated message from the Apache Git Service.
To respond to
davids5 commented on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652365645
@xiaoxiang781216 that seems limited to gnu and would not be in alignment
with not using compiler specific macros in code other than compiler.h.
anchao commented on a change in pull request #1345:
URL: https://github.com/apache/incubator-nuttx/pull/1345#discussion_r448308618
##
File path: tools/Makefile.unix
##
@@ -421,7 +421,7 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
cp -f uImage /tftpboot/uImage; \
anchao commented on a change in pull request #1345:
URL: https://github.com/apache/incubator-nuttx/pull/1345#discussion_r448308618
##
File path: tools/Makefile.unix
##
@@ -421,7 +421,7 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
cp -f uImage /tftpboot/uImage; \
xiaoxiang781216 edited a comment on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652375887
> @xiaoxiang781216 that seems limited to gnu and would not be in alignment
with not using compiler specific macros in code other than compiler.h.
xiaoxiang781216 edited a comment on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652375887
> @xiaoxiang781216 that seems limited to gnu and would not be in alignment
with not using compiler specific macros in code other than compiler.h.
xiaoxiang781216 opened a new pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344
## Summary
## Impact
No, since nobody reference these variables.
## Testing
This is an
anchao opened a new pull request #1345:
URL: https://github.com/apache/incubator-nuttx/pull/1345
## Summary
1. make/POSTBUILD: make BIN directory configurable
enhance the post build can support configurable BIN directory
2. make/export: export post build script
post
davids5 commented on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652353953
>nsh> cat /proc/version
NuttX version 9.0.0 ac6183365a-dirty Jul 1 2020 18:33:52
nsh> uname -a
NuttX 9.0.0 ac6183365a-dirty Jul 1 2020 18:33:34 sim sim
xiaoxiang781216 commented on pull request #315:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/315#issuecomment-652383413
@jerpelea done.
This is an automated message from the Apache Git Service.
To respond to the
davids5 commented on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652386557
@xiaoxiang781216 that make much more sense then your last suggestion.
This is an automated message
xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448336994
##
File path: include/nuttx/compiler.h
##
@@ -255,15 +255,6 @@
# undef CONFIG_PTR_IS_NOT_INT
#endif
-/* GCC supports inlined
Ouss4 commented on a change in pull request #1345:
URL: https://github.com/apache/incubator-nuttx/pull/1345#discussion_r448274174
##
File path: tools/Makefile.unix
##
@@ -421,7 +421,7 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
cp -f uImage /tftpboot/uImage; \
xiaoxiang781216 commented on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652375887
> @xiaoxiang781216 that seems limited to gnu and would not be in alignment
with not using compiler specific macros in code other than compiler.h.
All
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 651eefc fs: Rename link to symlink
add 3db090a S32K - Expand FlexTimer header file and add PWM
Ouss4 merged pull request #1339:
URL: https://github.com/apache/incubator-nuttx/pull/1339
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
xiaoxiang781216 commented on pull request #1312:
URL: https://github.com/apache/incubator-nuttx/pull/1312#issuecomment-652408911
But I can build stm32f4discovery:audio without any problem, here is my gcc
version:
```
arm-none-eabi-gcc -v
Using built-in specs.
davids5 edited a comment on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652353953
>nsh> cat /proc/version
NuttX version 9.0.0 ac6183365a-dirty Jul 1 2020 18:33:52
nsh> uname -a
NuttX 9.0.0 ac6183365a-dirty Jul 1 2020 18:33:34 sim
xiaoxiang781216 edited a comment on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652362444
> > nsh> cat /proc/version
> > NuttX version 9.0.0 ac6183365a-dirty Jul 1 2020 18:33:52
> > nsh> uname -a
> > NuttX 9.0.0 ac6183365a-dirty Jul
xiaoxiang781216 commented on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652362444
> > nsh> cat /proc/version
> > NuttX version 9.0.0 ac6183365a-dirty Jul 1 2020 18:33:52
> > nsh> uname -a
> > NuttX 9.0.0 ac6183365a-dirty Jul 1 2020
davids5 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448307162
##
File path: include/nuttx/compiler.h
##
@@ -255,15 +255,6 @@
# undef CONFIG_PTR_IS_NOT_INT
#endif
-/* GCC supports inlined functions for
xiaoxiang781216 edited a comment on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652375887
> @xiaoxiang781216 that seems limited to gnu and would not be in alignment
with not using compiler specific macros in code other than compiler.h.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 989d1ae import: add hex/raw
xiaoxiang781216 merged pull request #313:
URL: https://github.com/apache/incubator-nuttx-apps/pull/313
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 51388de make/import: add
xiaoxiang781216 merged pull request #312:
URL: https://github.com/apache/incubator-nuttx-apps/pull/312
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jerpelea merged pull request #1343:
URL: https://github.com/apache/incubator-nuttx/pull/1343
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 651eefc fs: Rename link to symlink
jerpelea merged pull request #317:
URL: https://github.com/apache/incubator-nuttx-apps/pull/317
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 95d7e9b nshlib: Call symlink
xiaoxiang781216 commented on pull request #1344:
URL: https://github.com/apache/incubator-nuttx/pull/1344#issuecomment-652339778
> @xiaoxiang781216 Should this be removed or used?
> Printing the version of a compiler and the git hash allows us to due post
postmortem debugging.
> if
Ouss4 commented on pull request #1312:
URL: https://github.com/apache/incubator-nuttx/pull/1312#issuecomment-652422093
For me it's gcc version 10.1.0
There are also the Github checks that aren't having any issue with this. So
this might be my GCC version, I'll look into it.
patacongo commented on pull request #316:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/316#issuecomment-652507257
@xiaoxiang781216 I will go ahead and merge this now. it still cannot pass
the PR checks because some defconfig files set appliation C++ settings that no
longer
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new b217de7 apps: Remove all stuff
patacongo commented on pull request #1347:
URL: https://github.com/apache/incubator-nuttx/pull/1347#issuecomment-652517087
I will be merging this change very early after a few checks succeed. That
is because the PR checks are all broken without this change.
[PS: I was producing
patacongo edited a comment on pull request #1328:
URL: https://github.com/apache/incubator-nuttx/pull/1328#issuecomment-652525167
> But I feel like we should figure out the cancellation stuff before I do
any of that.
>
> > There is a complexity... pthread_exit() is also called from
anchao commented on pull request #1346:
URL: https://github.com/apache/incubator-nuttx/pull/1346#issuecomment-652428408
Related code involves macro definition of mixed case, I think we can ignore
this check
```
patacongo edited a comment on pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652442424
> > Look how I did the pthread startup function in PR #1328. This is EXACTLY
the same issue. I created a user-space pthread_startup (NOT and OS startup
patacongo merged pull request #316:
URL: https://github.com/apache/incubator-nuttx-apps/pull/316
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 49020ac boards: Remove the unused
patacongo merged pull request #1347:
URL: https://github.com/apache/incubator-nuttx/pull/1347
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
patacongo commented on a change in pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341#discussion_r448365342
##
File path: sched/task/task_start.c
##
@@ -138,13 +138,14 @@ void nxtask_start(void)
if ((tcb->cmn.flags & TCB_FLAG_TTYPE_MASK) !=
antmerlino edited a comment on pull request #1328:
URL: https://github.com/apache/incubator-nuttx/pull/1328#issuecomment-652509617
> > There is a complexity... pthread_exit() is also called from within the
OS from task_cancelpt.c, pthread_cancel.c, pthread_create.c, sig_default.c,
antmerlino commented on pull request #1328:
URL: https://github.com/apache/incubator-nuttx/pull/1328#issuecomment-652509617
> > There is a complexity... pthread_exit() is also called from within the
OS from task_cancelpt.c, pthread_cancel.c, pthread_create.c, sig_default.c,
xiaoxiang781216 commented on pull request #1347:
URL: https://github.com/apache/incubator-nuttx/pull/1347#issuecomment-652514559
@patacongo this is the final patch for FLAT/PROTECTED builtin constructor
centralization.
This
patacongo edited a comment on pull request #1328:
URL: https://github.com/apache/incubator-nuttx/pull/1328#issuecomment-652525167
> But I feel like we should figure out the cancellation stuff before I do
any of that.
>
> > There is a complexity... pthread_exit() is also called from
anchao opened a new pull request #1346:
URL: https://github.com/apache/incubator-nuttx/pull/1346
## Summary
sched/kthread: extend kthread_create() to support configurable stack
Extended parameter to support configurable stack
unify the semantics with nxthread_create()
##
patacongo commented on pull request #1346:
URL: https://github.com/apache/incubator-nuttx/pull/1346#issuecomment-652467695
We have already gone throught this before with PR #1099 . I will not accept
this change. The mechanism to provide a configurable status is already in
place.
patacongo closed pull request #1346:
URL: https://github.com/apache/incubator-nuttx/pull/1346
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 opened a new pull request #1347:
URL: https://github.com/apache/incubator-nuttx/pull/1347
since cxx initialization is controlled by CONFIG_HAVE_CXXINITIALIZE now
Signed-off-by: Xiang Xiao
Change-Id: I39438dc3006d0a0b810052ecef50cd3c92f09d83
## Summary
xiaoxiang781216 commented on pull request #316:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/316#issuecomment-652513951
Yes, here is the patch: https://github.com/apache/incubator-nuttx/pull/1347
This is an
xiaoxiang781216 edited a comment on pull request #316:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/316#issuecomment-652528829
@davids5 the change is compatable as before since all config which utilize
the global constructor should already define CONFIG_HAVE_CXXINITIALIZE. The
davids5 commented on pull request #1347:
URL: https://github.com/apache/incubator-nuttx/pull/1347#issuecomment-652536203
@xiaoxiang781216 - there is still a lot of misleading documentation (some
are past release notes.) but this is really wrong now
patacongo commented on pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652431823
> To follow the Linux approach, the major change is the build system:
> 1.Statically link crt0.o into each ELF binary
> 2.__start call constructors,
patacongo commented on pull request #316:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/316#issuecomment-652508861
> This will break all all PR checks until all of the relevant defconfig
files are updated in the incubator_nuttx repository.
I will submit the the PR that
patacongo commented on a change in pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341#discussion_r448495517
##
File path: libs/libc/sched/task_startup.c
##
@@ -39,19 +39,101 @@
#include
+#include
#include
#include
-#include
+#ifndef
xiaoxiang781216 commented on pull request #1347:
URL: https://github.com/apache/incubator-nuttx/pull/1347#issuecomment-652534830
Yes, you are right. I forget this file because this is a new board just
upstreamed one month ago. The fix is here:
xiaoxiang781216 commented on pull request #316:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/316#issuecomment-652418299
> This should NOT me merged
[apache/incubator-nuttx#1341](https://github.com/apache/incubator-nuttx/pull/1341)
is stalled. It is the wrong approach .
patacongo commented on pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652442424
> > Look how I did the pthread startup function in PR #1328. This is EXACTLY
the same issue. I created a user-space pthread_startup (NOT and OS startup
function) in
patacongo edited a comment on pull request #1346:
URL: https://github.com/apache/incubator-nuttx/pull/1346#issuecomment-652467695
We have already gone throught this before with PR #1099 . I will not accept
this change. The mechanism to provide a configurable status is already in
place.
patacongo commented on pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652486768
@xiaoxiang781216 I think this change then resolves Issue #1265. Is that
correct? If so then that issue should be closed.
patacongo commented on a change in pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341#discussion_r448451990
##
File path: libs/libxx/Kconfig
##
@@ -22,6 +22,14 @@ config HAVE_CXX
if HAVE_CXX
+config HAVE_CXXINITIALIZE
+ bool "Have C++
patacongo commented on a change in pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341#discussion_r448451990
##
File path: libs/libxx/Kconfig
##
@@ -22,6 +22,14 @@ config HAVE_CXX
if HAVE_CXX
+config HAVE_CXXINITIALIZE
+ bool "Have C++
xiaoxiang781216 edited a comment on pull request #316:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/316#issuecomment-652418299
> This should NOT me merged
[apache/incubator-nuttx#1341](https://github.com/apache/incubator-nuttx/pull/1341)
is stalled. It is the wrong approach .
davids5 commented on pull request #316:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/316#issuecomment-652522526
@xiaoxiang781216 would you be kind enough to fill in the #Impact section and
give porting instruction?
xiaoxiang781216 commented on pull request #316:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/316#issuecomment-652528829
@davids5 the change is compatable as before since all config which utilize
the global constructor should already define CONFIG_HAVE_CXXINITIALIZE. The
user
xiaoxiang781216 opened a new pull request #1348:
URL: https://github.com/apache/incubator-nuttx/pull/1348
## Summary
forget in commit 49020acfdc2a846d0d2c8021b83a41ff9e6178c9
## Impact
## Testing
patacongo merged pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
patacongo commented on pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652433392
I will go ahead and merge this change. I do not think it is a worthwhile
change since it does not improve the OS architecture except in some special
cases. So
davids5 commented on pull request #1340:
URL: https://github.com/apache/incubator-nuttx/pull/1340#issuecomment-652525636
@xiaoxiang781216 Any reason not to merge this it is breaking C++ build
This is an automated message
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 310b572 board/olimex-stm32-p407:
patacongo merged pull request #1348:
URL: https://github.com/apache/incubator-nuttx/pull/1348
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
davids5 commented on a change in pull request #1331:
URL: https://github.com/apache/incubator-nuttx/pull/1331#discussion_r448361873
##
File path: tools/Makefile.unix
##
@@ -31,7 +31,7 @@ endif
# In case we cannot get version information from GIT
-ifneq
patacongo edited a comment on pull request #1341:
URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652442424
> > Look how I did the pthread startup function in PR #1328. This is EXACTLY
the same issue. I created a user-space pthread_startup (NOT and OS startup
xiaoxiang781216 edited a comment on pull request #1347:
URL: https://github.com/apache/incubator-nuttx/pull/1347#issuecomment-652518941
> I will be merging this change very early after a few checks succeed. That
is because the PR checks are all broken without this change.
>
> [PS: I
xiaoxiang781216 commented on pull request #1347:
URL: https://github.com/apache/incubator-nuttx/pull/1347#issuecomment-652518941
> machine
mayn't faster than you, I made this path a few days before:).
This is an
xiaoxiang781216 edited a comment on pull request #1346:
URL: https://github.com/apache/incubator-nuttx/pull/1346#issuecomment-652574377
> No.. no duplicate functionality
If so, should we provide a patch to remove kthread_create and change all
place to task_init/task_activate?
btashton commented on a change in pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#discussion_r448557702
##
File path: tools/check-nuttx-release.sh
##
@@ -0,0 +1,101 @@
+#!/bin/bash
+
+URL=$1
+
+function download_release() {
Review comment:
adamfeuer commented on pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#issuecomment-652627665
@btashton @Ouss4 Thanks for the improvements! Here's what I did:
* added the `set -e`
* added the trap to remove the tempdir
* added a license header
*
patacongo edited a comment on pull request #1328:
URL: https://github.com/apache/incubator-nuttx/pull/1328#issuecomment-652639845
>
>
> @gregory-nutt
>
> I have some changes to what you have so far that address build issues.
However, I can't open a PR against your branch on
patacongo edited a comment on pull request #1328:
URL: https://github.com/apache/incubator-nuttx/pull/1328#issuecomment-652639845
>
>
> @gregory-nutt
>
> I have some changes to what you have so far that address build issues.
However, I can't open a PR against your branch on
xiaoxiang781216 edited a comment on pull request #1346:
URL: https://github.com/apache/incubator-nuttx/pull/1346#issuecomment-652574377
> No.. no duplicate functionality
If so, should we provide a patch to remove all kthread_create and change to
task_init/task_activate?
antmerlino commented on pull request #1328:
URL: https://github.com/apache/incubator-nuttx/pull/1328#issuecomment-652611920
@gregory-nutt
I have some changes to what you have so far that address build issues.
However, I can't open a PR against your branch on your repo.
Can
adamfeuer commented on a change in pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#discussion_r448583054
##
File path: tools/check-nuttx-release.sh
##
@@ -0,0 +1,101 @@
+#!/bin/bash
+
+URL=$1
+
+function download_release() {
Review comment:
adamfeuer commented on a change in pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#discussion_r448586763
##
File path: tools/check-nuttx-release.sh
##
@@ -0,0 +1,95 @@
+#!/bin/bash
Review comment:
@Ouss4 will fix
patacongo edited a comment on pull request #1346:
URL: https://github.com/apache/incubator-nuttx/pull/1346#issuecomment-652567672
No.. no duplicate functionality. There is no functionality added by this PR
that does not already exist in the OS. Perhaps you would would want your own
adamfeuer commented on a change in pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#discussion_r448593346
##
File path: tools/check-nuttx-release.sh
##
@@ -0,0 +1,101 @@
+#!/bin/bash
+
+URL=$1
+
+function download_release() {
Review comment:
xiaoxiang781216 commented on pull request #1347:
URL: https://github.com/apache/incubator-nuttx/pull/1347#issuecomment-652547462
OK, I will provide a patch clear the documentation, but keep ReleaseNotes as
it since ReleaseNotes describe the history of software and should only be
appended
btashton commented on a change in pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#discussion_r448559105
##
File path: tools/check-nuttx-release.sh
##
@@ -0,0 +1,101 @@
+#!/bin/bash
+
+URL=$1
+
+function download_release() {
Review comment:
btashton commented on a change in pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#discussion_r448572250
##
File path: tools/check-nuttx-release.sh
##
@@ -0,0 +1,101 @@
+#!/bin/bash
+
+URL=$1
+
+function download_release() {
Review comment:
Ouss4 commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-652605913
I restarted the checks multiple times but the issue persists. I pulled this
change locally, it builds cleanly. Also my refresh.sh does not produce a
different
Ouss4 commented on a change in pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#discussion_r448582459
##
File path: tools/check-nuttx-release.sh
##
@@ -0,0 +1,95 @@
+#!/bin/bash
Review comment:
License header missing.
Ouss4 commented on a change in pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#discussion_r448590103
##
File path: tools/check-nuttx-release.sh
##
@@ -0,0 +1,96 @@
+#!/bin/bash
+set -e
+
+URL=$1
+TEMPDIR="dist.apache.org"
+ORIGINAL_DIR="$(pwd)"
adamfeuer edited a comment on pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#issuecomment-652627665
@btashton @Ouss4 Thanks for the improvements! Here's what I did:
* added the `set -e`
* added the trap to remove the tempdir
* added a license
patacongo commented on pull request #1328:
URL: https://github.com/apache/incubator-nuttx/pull/1328#issuecomment-652639845
>
>
> @gregory-nutt
>
> I have some changes to what you have so far that address build issues.
However, I can't open a PR against your branch on your
1 - 100 of 157 matches
Mail list logo
