[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3992: Refine tls_info_s and task_info_s

2021-07-01 Thread GitBox
yamt commented on a change in pull request #3992: URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r662033896 ## File path: sched/group/group_create.c ## @@ -138,6 +139,9 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype) return -ENOMEM;

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3992: Refine tls_info_s and task_info_s

2021-07-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3992: URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r662071744 ## File path: sched/group/group_create.c ## @@ -138,6 +139,9 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype) retu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3992: Refine tls_info_s and task_info_s

2021-07-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3992: URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r662071744 ## File path: sched/group/group_create.c ## @@ -138,6 +139,9 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype) retu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3992: Refine tls_info_s and task_info_s

2021-07-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3992: URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r662071744 ## File path: sched/group/group_create.c ## @@ -138,6 +139,9 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype) retu

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3992: Refine tls_info_s and task_info_s

2021-07-01 Thread GitBox
yamt commented on a change in pull request #3992: URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r662109387 ## File path: sched/group/group_create.c ## @@ -138,6 +139,9 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype) return -ENOMEM;

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3992: Refine tls_info_s and task_info_s

2021-07-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3992: URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r662146909 ## File path: sched/group/group_create.c ## @@ -138,6 +139,9 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype) retu

[incubator-nuttx] branch master updated (b45ccad -> 1b5341f)

2021-07-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b45ccad xtensa/esp32: Adds support for SERIAL_TXDMA. add 1b5341f boards/bl602: Fix uart_nx.c:419:

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4010: boards/bl602: Fix uart_nx.c:419: undefined reference to `uart_bth4_register

2021-07-01 Thread GitBox
xiaoxiang781216 commented on pull request #4010: URL: https://github.com/apache/incubator-nuttx/pull/4010#issuecomment-872104454 I will merge this patch directly since the CI is in the broken state. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4010: boards/bl602: Fix uart_nx.c:419: undefined reference to `uart_bth4_register

2021-07-01 Thread GitBox
xiaoxiang781216 merged pull request #4010: URL: https://github.com/apache/incubator-nuttx/pull/4010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3992: Refine tls_info_s and task_info_s

2021-07-01 Thread GitBox
yamt commented on a change in pull request #3992: URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r662177338 ## File path: sched/group/group_create.c ## @@ -138,6 +139,9 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype) return -ENOMEM;

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4012: fs: move out nx_close from filelock

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4012: URL: https://github.com/apache/incubator-nuttx/pull/4012 ## Summary fs: move out nx_close from filelock ## Impact file_close ## Testing -- This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4014: net/tcp: fix tcp crash when net meet popen syscall

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4014: URL: https://github.com/apache/incubator-nuttx/pull/4014 ## Summary net/tcp: fix tcp crash when net meet popen syscall tcp_close_monitor should free all the connevents which belong to current psock ## Impact ##

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4018: libs/libc/spawn: fix posix_spawn_file_actions_adddup2 alloc size error

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4018: URL: https://github.com/apache/incubator-nuttx/pull/4018 ## Summary libs/libc/spawn: fix posix_spawn_file_actions_adddup2 alloc size error ## Impact ## Testing -- This is an automated message from the Apache Git S

[GitHub] [incubator-nuttx] Virus-V opened a new pull request #4011: netlink: fix compile error when enable netlink

2021-07-01 Thread GitBox
Virus-V opened a new pull request #4011: URL: https://github.com/apache/incubator-nuttx/pull/4011 ## Summary Fix compile error when enable netlink ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4016: Add heap & stack check to idle thread

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4016: URL: https://github.com/apache/incubator-nuttx/pull/4016 ## Summary Add heap & stack check to idle thread ## Impact idle ## Testing -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4013: arm: fix enable interrupt too earlier caused system crash

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4013: URL: https://github.com/apache/incubator-nuttx/pull/4013 ## Summary arm: fix enable interrupt too earlier caused system crash reason: msr cpsr, r2 /* Set the CPSR */ // interrupt hanppend, context switc

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4017: rpmsg_socket: fix rpmsg_socket_device_destroy() multi-access

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4017: URL: https://github.com/apache/incubator-nuttx/pull/4017 ## Summary rpmsg_socket: fix rpmsg_socket_device_destroy() multi-access Reason: When user call rpmsg_socket_close() at the same time rpmsg_socket_ns_unbind() is called

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4019: Fix ascan report error

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4019: URL: https://github.com/apache/incubator-nuttx/pull/4019 ## Summary Fix ascan report error ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4015: modify sim clock to PC abs time

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4015: URL: https://github.com/apache/incubator-nuttx/pull/4015 ## Summary modify sim clock to PC abs time ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4021: sched/waitpid: handle waitpid waitting tcb->group is NULL

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4021: URL: https://github.com/apache/incubator-nuttx/pull/4021 sched/waitpid: handle waitpid waitting tcb->group is NULL ## Summary Fail case: exit -> nxtask_terminate -> nxtask_exithook -> nxsched_release_tcb

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4020: SMP related small changes

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4020: URL: https://github.com/apache/incubator-nuttx/pull/4020 ## Summary SMP related small changes add [CPUx] to syslog SMP should depends on ARCH_INTERRUPTSTACK ## Impact ## Testing -- This is an automated message from

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #4014: net/tcp: fix tcp crash when net meet popen syscall

2021-07-01 Thread GitBox
yamt commented on a change in pull request #4014: URL: https://github.com/apache/incubator-nuttx/pull/4014#discussion_r662205684 ## File path: net/tcp/tcp_monitor.c ## @@ -346,15 +346,13 @@ void tcp_close_monitor(FAR struct socket *psock) /* Find and free the the connection

[GitHub] [incubator-nuttx] acassis commented on pull request #4000: driver/fakesensor: fix bugs.

2021-07-01 Thread GitBox
acassis commented on pull request #4000: URL: https://github.com/apache/incubator-nuttx/pull/4000#issuecomment-872170372 hi @buyuer why did you decide to close it? Did you manage to fix the issue other way? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-nuttx] julianoes commented on pull request #3976: STM32F7 SDMMC fixes

2021-07-01 Thread GitBox
julianoes commented on pull request #3976: URL: https://github.com/apache/incubator-nuttx/pull/3976#issuecomment-872173428 Thanks for the review and merging @xiaoxiang781216! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4000: driver/fakesensor: fix bugs.

2021-07-01 Thread GitBox
xiaoxiang781216 commented on pull request #4000: URL: https://github.com/apache/incubator-nuttx/pull/4000#issuecomment-872180952 @acassis here is the fix https://github.com/apache/incubator-nuttx/pull/4007 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4011: netlink: fix compile error when enable netlink

2021-07-01 Thread GitBox
xiaoxiang781216 merged pull request #4011: URL: https://github.com/apache/incubator-nuttx/pull/4011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated: netlink: fix compile error when enable netlink

2021-07-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 94f45d5 netlink: fix compile error

[GitHub] [incubator-nuttx] acassis commented on pull request #4000: driver/fakesensor: fix bugs.

2021-07-01 Thread GitBox
acassis commented on pull request #4000: URL: https://github.com/apache/incubator-nuttx/pull/4000#issuecomment-872185967 thank you @xiaoxiang781216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-nuttx] yamt opened a new pull request #4022: tcp_close: Fix a race with passive close

2021-07-01 Thread GitBox
yamt opened a new pull request #4022: URL: https://github.com/apache/incubator-nuttx/pull/4022 ## Summary tcp_close disposes the connection immediately if it's called in TCP_LAST_ACK. If it happens, we will end up with responding the last ACK with a RST. This commit fixes

[GitHub] [incubator-nuttx] fjpanag opened a new pull request #4023: lpc17_40_progmem: fixed compilation issues.

2021-07-01 Thread GitBox
fjpanag opened a new pull request #4023: URL: https://github.com/apache/incubator-nuttx/pull/4023 ## Summary Fixes a couple of issues with the PROGMEM driver of the LPC17xx and LPC40xx MCUs. 1. The file `lpc17_40_progmem.c` was incorrectly build only when `CONFIG_MTD_PROGMEM` was

[GitHub] [incubator-nuttx] standby24x7 opened a new pull request #4024: efm32: Fix missing closing bracket

2021-07-01 Thread GitBox
standby24x7 opened a new pull request #4024: URL: https://github.com/apache/incubator-nuttx/pull/4024 This patch fixes missing closing bracket and semicolon. Signed-off-by: Masanari Iida ## Summary This patch adds missing closing bracket and semicolon. ## Impact I

[GitHub] [incubator-nuttx] fjpanag commented on pull request #4023: lpc17_40_progmem: fixed compilation issues.

2021-07-01 Thread GitBox
fjpanag commented on pull request #4023: URL: https://github.com/apache/incubator-nuttx/pull/4023#issuecomment-872211627 Regarding the style issue, I don't think that it can be fixed. I think the cast confuses the tool? -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx-apps] slorquet commented on pull request #710: system/popen: Follow up task_spawn change from kernel

2021-07-01 Thread GitBox
slorquet commented on pull request #710: URL: https://github.com/apache/incubator-nuttx-apps/pull/710#issuecomment-872214822 I disagree that the impact in minor. This breaks ALL users that use their own apps that copied the builitin mechanism from the official app repo. -- This i

[GitHub] [incubator-nuttx] imchangchang opened a new issue #4025: Compile error with CONFIG_DEBUG_PWM_INFO

2021-07-01 Thread GitBox
imchangchang opened a new issue #4025: URL: https://github.com/apache/incubator-nuttx/issues/4025 Platform: stm32h7 In https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/stm32h7/stm32_pwm.c, the ```pwm_dumpregs``` function's [definition](https://github.com/apache/in

[GitHub] [incubator-nuttx] GUIDINGLI commented on a change in pull request #4014: net/tcp: fix tcp crash when net meet popen syscall

2021-07-01 Thread GitBox
GUIDINGLI commented on a change in pull request #4014: URL: https://github.com/apache/incubator-nuttx/pull/4014#discussion_r662264165 ## File path: net/tcp/tcp_monitor.c ## @@ -346,15 +346,13 @@ void tcp_close_monitor(FAR struct socket *psock) /* Find and free the the connec

[GitHub] [incubator-nuttx] davids5 merged pull request #4024: efm32: Fix missing closing bracket

2021-07-01 Thread GitBox
davids5 merged pull request #4024: URL: https://github.com/apache/incubator-nuttx/pull/4024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[incubator-nuttx] branch master updated (94f45d5 -> 8394149)

2021-07-01 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 94f45d5 netlink: fix compile error when enable netlink add 8394149 efm32: Fix missing closing bracke

[GitHub] [incubator-nuttx] Donny9 opened a new pull request #4026: sched/idle: disable sched when idle call nx_bringup

2021-07-01 Thread GitBox
Donny9 opened a new pull request #4026: URL: https://github.com/apache/incubator-nuttx/pull/4026 ## Summary Because idle task will call mm_malloc to create some task and will take sem of mm. But if smp enable, the sem of mm may be taken by other cpu, so idle may be block because tak

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4027: sched: Restore the prototype of task_spawn

2021-07-01 Thread GitBox
xiaoxiang781216 opened a new pull request #4027: URL: https://github.com/apache/incubator-nuttx/pull/4027 ## Summary which was changed in this commit: ``` commit ae216cf9e92e91b4b74d91d3fbd9079839df13ba Author: Xiang Xiao Date: Wed May 12 11:34:50 2021 +0800 sche

[incubator-nuttx] branch master updated: lpc17_40_progmem: fixed compilation issues.

2021-07-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new de21340 lpc17_40_progmem: fixed com

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4023: lpc17_40_progmem: fixed compilation issues.

2021-07-01 Thread GitBox
xiaoxiang781216 merged pull request #4023: URL: https://github.com/apache/incubator-nuttx/pull/4023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] Donny9 opened a new pull request #4028: syslog: fix log confusion when multi task writing together

2021-07-01 Thread GitBox
Donny9 opened a new pull request #4028: URL: https://github.com/apache/incubator-nuttx/pull/4028 ## Summary Let's to do "syslog_write_t sc_write" function to fix log confusion when multi task writing together for syslog and ramlog. ## Impact normal output log for multi task environ

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #791: Revert "Follow up task_spawn change from kernel side"

2021-07-01 Thread GitBox
xiaoxiang781216 opened a new pull request #791: URL: https://github.com/apache/incubator-nuttx-apps/pull/791 ## Summary since the prototype of task_spawn restore to the origin This reverts commit 58293abb8e896bb04f3a76bf8b48206debe68f26. Depends on https://github.com/apache/incubato

[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #791: Revert "Follow up task_spawn change from kernel side"

2021-07-01 Thread GitBox
davids5 commented on pull request #791: URL: https://github.com/apache/incubator-nuttx-apps/pull/791#issuecomment-872287470 @xiaoxiang781216 I understand that @slorquet took issue with this change. It was done in master not the last release correct? Even if it were in the last release. It

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4029: mm: fix memory corruption when loop create/exit thread in SMP mode

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4029: URL: https://github.com/apache/incubator-nuttx/pull/4029 ## Summary Root casue: when do thread exit, need add free stack operation to mm_delaylist, but in SMP mode, CPU0 thread1 exit, at this time, CPU1 call malloc and free mm_de

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4030: Fix procfs memory corruption when meet long string, add thread run time to procfs

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4030: URL: https://github.com/apache/incubator-nuttx/pull/4030 ## Summary Fix procfs memory corruption when meet long string, add thread run time to procfs ## Impact ## Testing -- This is an automated message from the Apache G

[GitHub] [incubator-nuttx] Donny9 opened a new pull request #4031: fs/fs_dup2: (sanity check )correct check before calling dup

2021-07-01 Thread GitBox
Donny9 opened a new pull request #4031: URL: https://github.com/apache/incubator-nuttx/pull/4031 ## Summary fs/fs_dup2: correct check before calling dup. ## Impact Sanity check ## Testing daily test. -- This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #791: Revert "Follow up task_spawn change from kernel side"

2021-07-01 Thread GitBox
xiaoxiang781216 commented on pull request #791: URL: https://github.com/apache/incubator-nuttx-apps/pull/791#issuecomment-872289412 > @xiaoxiang781216 I understand that @slorquet took issue with this change. It was done in master not the last release correct? Even if it were in the last r

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #791: Revert "Follow up task_spawn change from kernel side"

2021-07-01 Thread GitBox
xiaoxiang781216 edited a comment on pull request #791: URL: https://github.com/apache/incubator-nuttx-apps/pull/791#issuecomment-872289412 > @xiaoxiang781216 I understand that @slorquet took issue with this change. It was done in master not the last release correct? Even if it were in the

[incubator-nuttx-apps] branch master updated: netutils/ftpc: ftpc_getfile: Fixed permission check and resume offset.

2021-07-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 5b1a4a3 netutils/ftpc: ftpc_ge

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #790: netutils/ftpc: ftpc_getfile: Fixed permission check and resume offset.

2021-07-01 Thread GitBox
xiaoxiang781216 merged pull request #790: URL: https://github.com/apache/incubator-nuttx-apps/pull/790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-nuttx] Donny9 opened a new pull request #4032: syslog: fix crash when print localtime by syslog

2021-07-01 Thread GitBox
Donny9 opened a new pull request #4032: URL: https://github.com/apache/incubator-nuttx/pull/4032 ## Summary syslog: fix crash when print localtime by syslog test need to enable config: CONFIG_LIBC_LOCATIME=y CONFIG_SYSLOG_TIMESTAMP_FORMATTED=y CONFIG_SYSLOG_TIMESTAMP_LOCAL

[GitHub] [incubator-nuttx] Donny9 opened a new pull request #4033: fs/procfs: add StackAlloc field for task stack info

2021-07-01 Thread GitBox
Donny9 opened a new pull request #4033: URL: https://github.com/apache/incubator-nuttx/pull/4033 ## Summary fs/procfs: add StackAlloc field for task stack info ## Impact debug ## Testing daily test -- This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4034: syslog: add CPU id to system when open CONFIG_SMP

2021-07-01 Thread GitBox
GUIDINGLI opened a new pull request #4034: URL: https://github.com/apache/incubator-nuttx/pull/4034 ## Summary syslog: add CPU id to system when open CONFIG_SMP Change-Id: Ie8aaf44583ff4146b79b1392d1410b31806a81e8 Signed-off-by: ligd ## Impact ## Testi

[GitHub] [incubator-nuttx] Donny9 opened a new pull request #4035: work_queue: schedule the work queue using the timer mechanism

2021-07-01 Thread GitBox
Donny9 opened a new pull request #4035: URL: https://github.com/apache/incubator-nuttx/pull/4035 ## Summary work_queue: schedule the work queue using the timer mechanism. ## Impact ## Testing daily test. -- This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-nuttx-apps] slorquet commented on pull request #791: Revert "Follow up task_spawn change from kernel side"

2021-07-01 Thread GitBox
slorquet commented on pull request #791: URL: https://github.com/apache/incubator-nuttx-apps/pull/791#issuecomment-872334098 @davids5 yep no issue with this technical change, it saves a bit of stack and is more posix compliant posix_spawn has the *pid parameter, but the function her

[GitHub] [incubator-nuttx-apps] slorquet edited a comment on pull request #791: Revert "Follow up task_spawn change from kernel side"

2021-07-01 Thread GitBox
slorquet edited a comment on pull request #791: URL: https://github.com/apache/incubator-nuttx-apps/pull/791#issuecomment-872334098 @davids5 yep no issue with this technical change, it saves a bit of stack posix_spawn has the *pid parameter, but the function here is task_spawn, whic

[GitHub] [incubator-nuttx] slorquet commented on pull request #4027: sched: Restore the prototype of task_spawn

2021-07-01 Thread GitBox
slorquet commented on pull request #4027: URL: https://github.com/apache/incubator-nuttx/pull/4027#issuecomment-872335793 Well, the change is not bad, so it may not be required to revert it. I was surprised by this break but this is more a "future documentation" issue. -- This is an a

[GitHub] [incubator-nuttx-apps] slorquet edited a comment on pull request #791: Revert "Follow up task_spawn change from kernel side"

2021-07-01 Thread GitBox
slorquet edited a comment on pull request #791: URL: https://github.com/apache/incubator-nuttx-apps/pull/791#issuecomment-872334098 @davids5 yep no issue with this technical change, it saves a bit of stack posix_spawn has the *pid parameter, but the function here is task_spawn, whic

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #4027: sched: Restore the prototype of task_spawn

2021-07-01 Thread GitBox
hartmannathan commented on a change in pull request #4027: URL: https://github.com/apache/incubator-nuttx/pull/4027#discussion_r662388058 ## File path: libs/libc/spawn/lib_task_spawn.c ## @@ -0,0 +1,76 @@ +/***

[GitHub] [incubator-nuttx-apps] hartmannathan commented on a change in pull request #791: Revert "Follow up task_spawn change from kernel side"

2021-07-01 Thread GitBox
hartmannathan commented on a change in pull request #791: URL: https://github.com/apache/incubator-nuttx-apps/pull/791#discussion_r662393172 ## File path: system/popen/popen.c ## @@ -253,12 +253,8 @@ FILE *popen(FAR const char *command, FAR const char *mode) errcode = posix

[GitHub] [incubator-nuttx-apps] hartmannathan commented on a change in pull request #791: Revert "Follow up task_spawn change from kernel side"

2021-07-01 Thread GitBox
hartmannathan commented on a change in pull request #791: URL: https://github.com/apache/incubator-nuttx-apps/pull/791#discussion_r662393302 ## File path: system/system/system.c ## @@ -137,12 +137,8 @@ int system(FAR const char *cmd) errcode = posix_spawn(&pid, argv[0], NU

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3983: arch/sim: Implement mm_mallinfo and malloc_size for the custom heap

2021-07-01 Thread GitBox
davids5 commented on a change in pull request #3983: URL: https://github.com/apache/incubator-nuttx/pull/3983#discussion_r662396415 ## File path: include/malloc.h ## @@ -31,6 +31,8 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #4035: work_queue: schedule the work queue using the timer mechanism

2021-07-01 Thread GitBox
hartmannathan commented on a change in pull request #4035: URL: https://github.com/apache/incubator-nuttx/pull/4035#discussion_r662398941 ## File path: sched/wqueue/kwork_thread.c ## @@ -0,0 +1,297 @@ +/***

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #4035: work_queue: schedule the work queue using the timer mechanism

2021-07-01 Thread GitBox
hartmannathan commented on a change in pull request #4035: URL: https://github.com/apache/incubator-nuttx/pull/4035#discussion_r662406603 ## File path: sched/wqueue/kwork_queue.c ## @@ -148,16 +107,39 @@ static void work_qqueue(FAR struct kwork_wqueue_s *wqueue, int work_queue

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #4035: work_queue: schedule the work queue using the timer mechanism

2021-07-01 Thread GitBox
hartmannathan commented on pull request #4035: URL: https://github.com/apache/incubator-nuttx/pull/4035#issuecomment-872362903 If I understand correctly, this PR does 2 things: 1) Unifies the HP and LP work queue logic 2) Modifies the "delay" feature so it uses a WD timer inste

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #4036: drivers/sensors/hyt271: Fix typos in comments and identifier

2021-07-01 Thread GitBox
hartmannathan opened a new pull request #4036: URL: https://github.com/apache/incubator-nuttx/pull/4036 ## Summary drivers/sensors/hyt271.c: - struct hyt271_dev_s: Identifier `lock_measure_cylce` was misspelled. Fix to `lock_measure_cycle` and update all instances in the file.

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4035: work_queue: schedule the work queue using the timer mechanism

2021-07-01 Thread GitBox
gustavonihei commented on a change in pull request #4035: URL: https://github.com/apache/incubator-nuttx/pull/4035#discussion_r662442605 ## File path: sched/wqueue/kwork_thread.c ## @@ -0,0 +1,297 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4035: work_queue: schedule the work queue using the timer mechanism

2021-07-01 Thread GitBox
gustavonihei commented on a change in pull request #4035: URL: https://github.com/apache/incubator-nuttx/pull/4035#discussion_r662449541 ## File path: sched/wqueue/kwork_thread.c ## @@ -0,0 +1,297 @@ +/

[incubator-nuttx] branch master updated (de21340 -> ee81b5a)

2021-07-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from de21340 lpc17_40_progmem: fixed compilation issues. add ee81b5a drivers/sensors/hyt271: Fix typos

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4036: drivers/sensors/hyt271: Fix typos in comments and identifier

2021-07-01 Thread GitBox
xiaoxiang781216 merged pull request #4036: URL: https://github.com/apache/incubator-nuttx/pull/4036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4027: sched: Restore the prototype of task_spawn

2021-07-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #4027: URL: https://github.com/apache/incubator-nuttx/pull/4027#discussion_r662487245 ## File path: libs/libc/spawn/lib_task_spawn.c ## @@ -0,0 +1,76 @@ +/*

[incubator-nuttx] branch master updated (ee81b5a -> 1d0ade6)

2021-07-01 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from ee81b5a drivers/sensors/hyt271: Fix typos in comments and identifier add 1d0ade6 libc: Remove the du

[GitHub] [incubator-nuttx] davids5 merged pull request #4008: libc: Remove the duplication lib_xxx macro

2021-07-01 Thread GitBox
davids5 merged pull request #4008: URL: https://github.com/apache/incubator-nuttx/pull/4008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3953: Minor fix for local time process

2021-07-01 Thread GitBox
davids5 commented on a change in pull request #3953: URL: https://github.com/apache/incubator-nuttx/pull/3953#discussion_r662515753 ## File path: libs/libc/time/lib_localtime.c ## @@ -363,9 +365,9 @@ FAR char *tzname[2] = static int_fast32_t detzcode(FAR const char *codep);

[GitHub] [incubator-nuttx] davids5 merged pull request #4009: Move aligned_alloc, posix_memalign and valloc from mm/umm to libs/libc/stdlib

2021-07-01 Thread GitBox
davids5 merged pull request #4009: URL: https://github.com/apache/incubator-nuttx/pull/4009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[incubator-nuttx] branch master updated (1d0ade6 -> 187538c)

2021-07-01 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 1d0ade6 libc: Remove the duplication lib_xxx macro add 187538c Move aligned_alloc, posix_memalign an

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4020: SMP should depends on ARCH_INTERRUPTSTACK

2021-07-01 Thread GitBox
gustavonihei commented on a change in pull request #4020: URL: https://github.com/apache/incubator-nuttx/pull/4020#discussion_r662523339 ## File path: sched/Kconfig ## @@ -268,13 +268,25 @@ config SMP default n depends on ARCH_HAVE_MULTICPU depends on AR

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #4021: sched/waitpid: handle waitpid waitting tcb->group is NULL

2021-07-01 Thread GitBox
davids5 commented on a change in pull request #4021: URL: https://github.com/apache/incubator-nuttx/pull/4021#discussion_r662526374 ## File path: sched/sched/sched_waitid.c ## @@ -167,9 +167,11 @@ int nx_waitid(int idtype, id_t id, FAR siginfo_t *info, int options) */

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #4020: SMP should depends on ARCH_INTERRUPTSTACK

2021-07-01 Thread GitBox
davids5 commented on a change in pull request #4020: URL: https://github.com/apache/incubator-nuttx/pull/4020#discussion_r662531394 ## File path: sched/Kconfig ## @@ -268,13 +268,25 @@ config SMP default n depends on ARCH_HAVE_MULTICPU depends on ARCH_HA

[GitHub] [incubator-nuttx] davids5 commented on pull request #4019: Fix asan report error

2021-07-01 Thread GitBox
davids5 commented on pull request #4019: URL: https://github.com/apache/incubator-nuttx/pull/4019#issuecomment-872487461 @GUIDINGLI These changes are only related by the tool. Should they be 3 separate PRs? -- This is an automated message from the Apache Git Service. To respond to the me

[incubator-nuttx] branch master updated (187538c -> 179f599)

2021-07-01 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 187538c Move aligned_alloc, posix_memalign and valloc from mm/umm to libs/libc/stdlib add 179f599 l

[GitHub] [incubator-nuttx] davids5 merged pull request #4018: libs/libc/spawn: fix posix_spawn_file_actions_adddup2 alloc size error

2021-07-01 Thread GitBox
davids5 merged pull request #4018: URL: https://github.com/apache/incubator-nuttx/pull/4018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #4017: rpmsg_socket: fix rpmsg_socket_device_destroy() multi-access

2021-07-01 Thread GitBox
davids5 commented on a change in pull request #4017: URL: https://github.com/apache/incubator-nuttx/pull/4017#discussion_r662534829 ## File path: net/rpmsg/rpmsg_sockif.c ## @@ -386,7 +386,14 @@ static int rpmsg_socket_ept_cb(FAR struct rpmsg_endpoint *ept, static inline void

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #4016: Add heap & stack check to idle thread

2021-07-01 Thread GitBox
davids5 commented on a change in pull request #4016: URL: https://github.com/apache/incubator-nuttx/pull/4016#discussion_r662540025 ## File path: sched/init/nx_start.c ## @@ -789,17 +789,35 @@ void nx_start(void) sinfo("CPU0: Beginning Idle Loop\n"); for (; ; ) { -

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3983: arch/sim: Implement mm_mallinfo and malloc_size for the custom heap

2021-07-01 Thread GitBox
acassis commented on a change in pull request #3983: URL: https://github.com/apache/incubator-nuttx/pull/3983#discussion_r662549960 ## File path: include/malloc.h ## @@ -31,6 +31,8 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3992: Refine tls_info_s and task_info_s

2021-07-01 Thread GitBox
davids5 commented on a change in pull request #3992: URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r662561766 ## File path: sched/group/group_create.c ## @@ -208,6 +212,26 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype) return OK; }

[GitHub] [incubator-nuttx] davids5 commented on pull request #3957: sched/wdog: Remove flags field from wdog_s to save memory

2021-07-01 Thread GitBox
davids5 commented on pull request #3957: URL: https://github.com/apache/incubator-nuttx/pull/3957#issuecomment-872536336 @acassis - Any feedback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #4035: work_queue: schedule the work queue using the timer mechanism

2021-07-01 Thread GitBox
davids5 commented on a change in pull request #4035: URL: https://github.com/apache/incubator-nuttx/pull/4035#discussion_r662477407 ## File path: sched/wqueue/kwork_cancel.c ## @@ -77,18 +77,30 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue, flags = enter_criti

[GitHub] [incubator-nuttx] davids5 commented on pull request #4012: fs: move out nx_close from filelock

2021-07-01 Thread GitBox
davids5 commented on pull request #4012: URL: https://github.com/apache/incubator-nuttx/pull/4012#issuecomment-87209 @GUIDINGLI What problem is is solving how was it tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[incubator-nuttx-apps] branch master updated: examples/watchdog: add depends on CONFIG_WATCHDOG

2021-07-01 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 2f2d3e5 examples/watchdog: add d

[GitHub] [incubator-nuttx-apps] davids5 merged pull request #787: examples/watchdog: add depends on CONFIG_WATCHDOG

2021-07-01 Thread GitBox
davids5 merged pull request #787: URL: https://github.com/apache/incubator-nuttx-apps/pull/787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-nuttx-apps] branch master updated: nshlib: Add 'rm -r' recursive remove directory support

2021-07-01 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 4b8e0fd nshlib: Add 'rm -r' recu

[GitHub] [incubator-nuttx-apps] davids5 merged pull request #786: nshlib: Add 'rm -r' recursive remove directory support

2021-07-01 Thread GitBox
davids5 merged pull request #786: URL: https://github.com/apache/incubator-nuttx-apps/pull/786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-nuttx] moataz-metwally opened a new issue #4037: Raw socket doesnot support non blocking and poll and select or any async read access

2021-07-01 Thread GitBox
moataz-metwally opened a new issue #4037: URL: https://github.com/apache/incubator-nuttx/issues/4037 I worked on a raw sockets and tried to use poll. after some debugging in deep in the network subsystem it turned out that raw socket neither support non blocking access nor poll.

[GitHub] [incubator-nuttx] acassis commented on pull request #3957: sched/wdog: Remove flags field from wdog_s to save memory

2021-07-01 Thread GitBox
acassis commented on pull request #3957: URL: https://github.com/apache/incubator-nuttx/pull/3957#issuecomment-872587969 > @acassis - Any feedback? I think it is fine. It is good way to test if the wdog is active -- This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-nuttx] acassis merged pull request #3957: sched/wdog: Remove flags field from wdog_s to save memory

2021-07-01 Thread GitBox
acassis merged pull request #3957: URL: https://github.com/apache/incubator-nuttx/pull/3957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[incubator-nuttx] branch master updated (179f599 -> d7d3177)

2021-07-01 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 179f599 libs/libc/spawn: fix posix_spawn_file_actions_adddup2 alloc size error add d7d3177 sched/wd

[GitHub] [incubator-nuttx] acassis commented on issue #4037: Raw socket doesnot support non blocking flags including poll and select and any async read access

2021-07-01 Thread GitBox
acassis commented on issue #4037: URL: https://github.com/apache/incubator-nuttx/issues/4037#issuecomment-872589130 Hi @moataz-metwally should be nice if you could contribute some apps/testing/ sample to let it to be tested, do you have a minimum sample that works on Linux and fails on Nu

[incubator-nuttx] branch master updated (d7d3177 -> 5de1501)

2021-07-01 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d7d3177 sched/wdog: Remove flags field from wdog_s to save memory add 5de1501 syslog: add CPU id to

  1   2   >