[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
pussuw commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1098293357 ## sched/addrenv/addrenv.c: ## @@ -79,13 +79,42 @@ static void addrenv_destroy(FAR void *arg) /* Destroy the address environment */ - up_addrenv_destroy(>pgdir);

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1098287198 ## sched/addrenv/addrenv.c: ## @@ -52,6 +53,39 @@ static FAR struct addrenv_s *g_addrenv[CONFIG_SMP_NCPUS];

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8449: build/Kconfig: add BINDIR/APPSBINDIR to support out of tree build

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #8449: URL: https://github.com/apache/nuttx/pull/8449#discussion_r1098274504 ## tools/Win.mk: ## @@ -571,33 +571,38 @@ pass2dep: context tools\mkdeps$(HOSTEXEEXT) # location: https://bitbucket.org/nuttx/tools/downloads/. See #

[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
pussuw commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1098260898 ## sched/addrenv/addrenv.c: ## @@ -0,0 +1,562 @@ +/ + * sched/addrenv/addrenv.c + * + *

[GitHub] [nuttx] anchao commented on a diff in pull request #6718: add CMake build system support (Enhance #3704)

2023-02-06 Thread via GitHub
anchao commented on code in PR #6718: URL: https://github.com/apache/nuttx/pull/6718#discussion_r1098235480 ## CMakeLists.txt: ## @@ -0,0 +1,664 @@ +# ## +# CMakeLists.txt +# +# Licensed to the Apache

[GitHub] [nuttx] anchao commented on a diff in pull request #6718: add CMake build system support (Enhance #3704)

2023-02-06 Thread via GitHub
anchao commented on code in PR #6718: URL: https://github.com/apache/nuttx/pull/6718#discussion_r1098234634 ## CMakeLists.txt: ## @@ -0,0 +1,664 @@ +# ## +# CMakeLists.txt +# +# Licensed to the Apache

[GitHub] [nuttx-apps] anchao opened a new pull request, #1544: build/Kconfig: add BINDIR/APPSBINDIR to support out of tree build

2023-02-06 Thread via GitHub
anchao opened a new pull request, #1544: URL: https://github.com/apache/nuttx-apps/pull/1544 ## Summary build/Kconfig: add BINDIR/APPSBINDIR to support out of tree build First decoupling changes from https://github.com/apache/nuttx/pull/6718 Signed-off-by: chao an

[GitHub] [nuttx] anchao opened a new pull request, #8449: build/Kconfig: add BINDIR/APPSBINDIR to support out of tree build

2023-02-06 Thread via GitHub
anchao opened a new pull request, #8449: URL: https://github.com/apache/nuttx/pull/8449 ## Summary build/Kconfig: add BINDIR/APPSBINDIR to support out of tree build First decoupling changes from https://github.com/apache/nuttx/pull/6718 Signed-off-by: chao an

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8448: net: Remove protocol argument from si_setup callback

2023-02-06 Thread via GitHub
xiaoxiang781216 opened a new pull request, #8448: URL: https://github.com/apache/nuttx/pull/8448 ## Summary since the implementor could get the same value from socket::s_proto ## Impact Minor ## Testing CI -- This is an automated message from the Apache

[GitHub] [nuttx] PeterBee97 opened a new pull request, #8447: Add v4l2_buffer timestamp and sequence

2023-02-06 Thread via GitHub
PeterBee97 opened a new pull request, #8447: URL: https://github.com/apache/nuttx/pull/8447 ## Summary Added timestamp and sequence number to captured frame. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8370: include/sys/socket.h: Add SOCK_CTRL to socket type

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on PR #8370: URL: https://github.com/apache/nuttx/pull/8370#issuecomment-1420183766 > Dear @xiaoxiang781216 san > > > > Dear @xiaoxiang781216 san > > > > @SPRESENSE but how to pass the ioctl to usrsock server now? > > > > > > > > > This fix only

[nuttx] branch master updated (5f9cb6faf4 -> 21d9163aae)

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 5f9cb6faf4 drivers/serial: Fix docstrings on UART interrupt handlers add 247aad82f2 arch/xtensa/esp32s2: Fix

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8428: arch/xtensa/esp32s2: Add support for touch pad interrupts

2023-02-06 Thread via GitHub
xiaoxiang781216 merged PR #8428: URL: https://github.com/apache/nuttx/pull/8428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] anchao commented on pull request #8414: include: Add nitems() definition to sys/param.h

2023-02-06 Thread via GitHub
anchao commented on PR #8414: URL: https://github.com/apache/nuttx/pull/8414#issuecomment-1420176597 If nitems() cannot be used as the system's preferred macro to completely replace ARRAY_SIZE(), is it pointless to exist? -- This is an automated message from the Apache Git Service. To

[GitHub] [nuttx] anchao commented on pull request #8378: tools/makefile: silent all compile output

2023-02-06 Thread via GitHub
anchao commented on PR #8378: URL: https://github.com/apache/nuttx/pull/8378#issuecomment-1420161033 @fjpanag I just checked the shell behavior of sh/bash/zsh, they all work as expected if bash is supported, what system and shell are you using? -- This is an automated message from the

[GitHub] [nuttx] Donny9 commented on a diff in pull request #5999: fs/sync: add sync api

2023-02-06 Thread via GitHub
Donny9 commented on code in PR #5999: URL: https://github.com/apache/nuttx/pull/5999#discussion_r1098141193 ## syscall/syscall.csv: ## @@ -165,6 +165,7 @@ "socketpair","sys/socket.h","defined(CONFIG_NET)","int","int","int","int","int [2]|FAR int *"

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #5999: fs/sync: add sync api

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on PR #5999: URL: https://github.com/apache/nuttx/pull/5999#issuecomment-1420151479 > @xiaoxiang781216 @Donny9 can we close this PR? @pkarashchenko sync is ready for review now. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx] anchao commented on pull request #8378: tools/makefile: silent all compile output

2023-02-06 Thread via GitHub
anchao commented on PR #8378: URL: https://github.com/apache/nuttx/pull/8378#issuecomment-1420150934 @fjpanag From the log information, "\033[1K\r" has not been recognized correctly. It seems that your system supports bash but you are not using it as default SHELL on terminal, right?

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #5999: fs/sync: add sync and syncfs api

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #5999: URL: https://github.com/apache/nuttx/pull/5999#discussion_r1098139509 ## syscall/syscall.csv: ## @@ -165,6 +165,7 @@ "socketpair","sys/socket.h","defined(CONFIG_NET)","int","int","int","int","int [2]|FAR int *"

[GitHub] [nuttx] SPRESENSE commented on pull request #8370: include/sys/socket.h: Add SOCK_CTRL to socket type

2023-02-06 Thread via GitHub
SPRESENSE commented on PR #8370: URL: https://github.com/apache/nuttx/pull/8370#issuecomment-1420115057 Dear @xiaoxiang781216 san > > Dear @xiaoxiang781216 san > > > @SPRESENSE but how to pass the ioctl to usrsock server now? > > > > > > This fix only add a new Socket

[GitHub] [nuttx] flyingfish89 commented on pull request #8441: fix a bug of strtold

2023-02-06 Thread via GitHub
flyingfish89 commented on PR #8441: URL: https://github.com/apache/nuttx/pull/8441#issuecomment-1420051788 > Indeed this PR fixed the issue, and tests were able to move forward. > > However, now there is a new Lua test failing. I guess it is related, but I won't have the time to

[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8446: esp32s3: Add pwm support using LEDC peripheral

2023-02-06 Thread via GitHub
hartmannathan commented on code in PR #8446: URL: https://github.com/apache/nuttx/pull/8446#discussion_r1098091258 ## boards/xtensa/esp32s3/esp32s3-devkit/src/esp32s3_ledc.c: ## @@ -0,0 +1,134 @@ +/ + *

[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: 5f9cb6faf40dec46092474446e3590e381c3ca1b

2023-02-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 4c3956d3 Publishing web:

[GitHub] [nuttx] acassis opened a new pull request, #8446: esp32s3: Add pwm support using LEDC peripheral

2023-02-06 Thread via GitHub
acassis opened a new pull request, #8446: URL: https://github.com/apache/nuttx/pull/8446 ## Summary esp32s3: Add pwm support using LEDC peripheral ## Impact Users will be able to use PWM ## Testing esp32s3-devkit -- This is an automated message from the Apache Git

[GitHub] [nuttx] acassis opened a new pull request, #8445: esp32s2: Add pwm support using LEDC peripheral

2023-02-06 Thread via GitHub
acassis opened a new pull request, #8445: URL: https://github.com/apache/nuttx/pull/8445 ## Summary esp32s2: Add pwm support using LEDC peripheral ## Impact Users will be able to use PWM ## Testing esp32s2-saola-1 -- This is an automated message from the Apache Git

[nuttx] branch master updated: drivers/serial: Fix docstrings on UART interrupt handlers

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5f9cb6faf4 drivers/serial: Fix docstrings on

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8444: drivers/serial: Fix docstrings on UART interrupt handlers

2023-02-06 Thread via GitHub
xiaoxiang781216 merged PR #8444: URL: https://github.com/apache/nuttx/pull/8444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] branch master updated (14f8a6c2dd -> caa16742db)

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 14f8a6c2dd fs: support openat/fchmodat/mkfifoat/fstatat/...at api new 5ac638944b arm/backtrace: fix compile

[nuttx] 04/06: raspberrypi-pico-w/telnet: enable more configs

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 5c047f634f849f3fc9b4c7259a74ccbe24279e69 Author: chao an AuthorDate: Mon Feb 6 17:17:48 2023 +0800

[nuttx] 05/06: arm/rp2040: fix compile warning on boot2 build

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 1b245664ad665679fbee494994e0cf3ed0acea4b Author: chao an AuthorDate: Mon Feb 6 17:29:07 2023 +0800 arm/rp2040:

[nuttx] 03/06: wireless/bcm43xxx/qspi: try tx after rx fails

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 1779433c350f9e64678b77bc11b02e871949f9df Author: chao an AuthorDate: Mon Feb 6 17:05:54 2023 +0800

[nuttx] 06/06: rp2040/raspberrypi-pico-w: update submodule to avoid invaild firmware

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit caa16742dbe0787168004e92ab54d3ba28839b14 Author: chao an AuthorDate: Mon Feb 6 17:52:40 2023 +0800

[nuttx] 02/06: bcm43xxx/bcmf_ioctl.h: pack wl_* structure to avoid unaligned access

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit d5ac2be84f7e615ecd8a7b4280b0cc2c194fea04 Author: chao an AuthorDate: Mon Feb 6 16:50:10 2023 +0800

[GitHub] [nuttx] xiaoxiang781216 closed issue #7475: RaspberryPi-Pico-W is not getting WiFi

2023-02-06 Thread via GitHub
xiaoxiang781216 closed issue #7475: RaspberryPi-Pico-W is not getting WiFi URL: https://github.com/apache/nuttx/issues/7475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8439: rp2040/raspberrypi-pico-w: update submodule to avoid invaild firmware

2023-02-06 Thread via GitHub
xiaoxiang781216 merged PR #8439: URL: https://github.com/apache/nuttx/pull/8439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] 01/06: arm/backtrace: fix compile warning

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 5ac638944b79d225aed1632c13162a891ad99766 Author: chao an AuthorDate: Mon Feb 6 16:47:57 2023 +0800

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8440: fs: support openat/fchmodat/mkfifoat/fstatat/...at api

2023-02-06 Thread via GitHub
xiaoxiang781216 merged PR #8440: URL: https://github.com/apache/nuttx/pull/8440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] branch master updated (dad6b105ca -> 14f8a6c2dd)

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from dad6b105ca tools/Config: silent print of archive objects add 7bbabc74fb fs/dir: provide absolute directory

[nuttx] branch master updated: tools/Config: silent print of archive objects

2023-02-06 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new dad6b105ca tools/Config: silent print of

[GitHub] [nuttx] acassis merged pull request #8443: tools/Config: silent print of archive objects

2023-02-06 Thread via GitHub
acassis merged PR #8443: URL: https://github.com/apache/nuttx/pull/8443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
pussuw commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1097767509 ## sched/addrenv/addrenv.c: ## @@ -0,0 +1,562 @@ +/ + * sched/addrenv/addrenv.c + * + *

[GitHub] [nuttx] hartmannathan commented on pull request #8444: drivers/serial: Fix docstrings on UART interrupt handlers

2023-02-06 Thread via GitHub
hartmannathan commented on PR #8444: URL: https://github.com/apache/nuttx/pull/8444#issuecomment-1419465788 Reviewers: Please ignore the nxstyle errors in `arch/arm/src/phy62xx/uart.c`. Those are too deep to fix in this PR and will require a separate PR. -- This is an automated message

[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1543: bluetooth/nimble: Update to ed083b36cb85c7437b905ee905ea4aed6a1653ad

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on PR #1543: URL: https://github.com/apache/nuttx-apps/pull/1543#issuecomment-1419410425 CI fail is fixed here: https://github.com/apache/mynewt-nimble/pull/1459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[nuttx-apps] branch master updated: testing/drivertest: add timer driver test

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 8a131cb7e testing/drivertest: add timer

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1534: testing/drivertest: add timer driver test

2023-02-06 Thread via GitHub
xiaoxiang781216 merged PR #1534: URL: https://github.com/apache/nuttx-apps/pull/1534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8435: Move SEEK_xxx from unistd.h to sys/types.h

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on PR #8435: URL: https://github.com/apache/nuttx/pull/8435#issuecomment-1419394755 All three header files should define these macro from the spec(glibc do the same thing). To avoid too many duplicaiton, SEEK_xxx macro is mvoed to sys/types.h which is included by

[GitHub] [nuttx] hartmannathan opened a new pull request, #8444: drivers/serial: Fix docstrings on UART interrupt handlers

2023-02-06 Thread via GitHub
hartmannathan opened a new pull request, #8444: URL: https://github.com/apache/nuttx/pull/8444 ## Summary Docstrings on UART/USART interrupt handlers included two wrong function names: `uart_transmitchars` or `uart_receivechar`. These do not exist. The correct names are

[nuttx] branch master updated: tools/Config: stack usage(.su) file should be removed on clean phase

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5e623da2dd tools/Config: stack usage(.su)

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8442: tools/Config: stack usage(.su) file should be removed on clean phase

2023-02-06 Thread via GitHub
xiaoxiang781216 merged PR #8442: URL: https://github.com/apache/nuttx/pull/8442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] fjpanag commented on pull request #8441: fix a bug of strtold

2023-02-06 Thread via GitHub
fjpanag commented on PR #8441: URL: https://github.com/apache/nuttx/pull/8441#issuecomment-1419335030 Indeed this PR fixed the issue, and tests were able to move forward. However, now there is a new Lua test failing. I guess it is related, but I won't have the time to investigate

[GitHub] [nuttx] fjpanag commented on pull request #8378: tools/makefile: silent all compile output

2023-02-06 Thread via GitHub
fjpanag commented on PR #8378: URL: https://github.com/apache/nuttx/pull/8378#issuecomment-1419263730 Also now, setting `V=1` does not produce an output as before. I would expect to have an option to keep the old behaviour as before. The new `V=0` option is unsuitable for me, as

[GitHub] [nuttx] fjpanag commented on pull request #8378: tools/makefile: silent all compile output

2023-02-06 Thread via GitHub
fjpanag commented on PR #8378: URL: https://github.com/apache/nuttx/pull/8378#issuecomment-1419251329 Maybe this commit needs some optimization? When parallelization is enabled in the build (i.e. `-j` make option), the formatting characters are not printed synchronized with the

[GitHub] [nuttx] Donny9 commented on a diff in pull request #8440: fs: support openat/fchmodat/mkfifoat/fstatat/...at api

2023-02-06 Thread via GitHub
Donny9 commented on code in PR #8440: URL: https://github.com/apache/nuttx/pull/8440#discussion_r1097510801 ## libs/libc/unistd/lib_fchownat.c: ## @@ -0,0 +1,85 @@ +/ + * libs/libc/unistd/lib_fchownat.c

[GitHub] [nuttx] Donny9 commented on a diff in pull request #8440: fs: support openat/fchmodat/mkfifoat/fstatat/...at api

2023-02-06 Thread via GitHub
Donny9 commented on code in PR #8440: URL: https://github.com/apache/nuttx/pull/8440#discussion_r1097510492 ## libs/libc/misc/lib_fstatat.c: ## @@ -0,0 +1,84 @@ +/ + * libs/libc/misc/lib_fstatat.c + * +

[GitHub] [nuttx] Donny9 commented on a diff in pull request #8440: fs: support openat/fchmodat/mkfifoat/fstatat/...at api

2023-02-06 Thread via GitHub
Donny9 commented on code in PR #8440: URL: https://github.com/apache/nuttx/pull/8440#discussion_r1097510226 ## include/fcntl.h: ## @@ -112,6 +112,18 @@ #define FD_CLOEXEC 1 +/* The flag for openat, faccessat, ... */ + +#define AT_FDCWD -100 /* Special value

[GitHub] [nuttx] pkarashchenko commented on pull request #8435: include/stdio.h: Duplicate SEEK_xxx definition from unistd.h

2023-02-06 Thread via GitHub
pkarashchenko commented on PR #8435: URL: https://github.com/apache/nuttx/pull/8435#issuecomment-1419209786 But according to https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/fcntl.h.html ``` The header shall define the values used for l_whence, SEEK_SET, SEEK_CUR, and

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8440: fs: support openat/fchmodat/mkfifoat/fstatat/...at api

2023-02-06 Thread via GitHub
pkarashchenko commented on code in PR #8440: URL: https://github.com/apache/nuttx/pull/8440#discussion_r1097449933 ## include/fcntl.h: ## @@ -112,6 +112,18 @@ #define FD_CLOEXEC 1 +/* The flag for openat, faccessat, ... */ + +#define AT_FDCWD -100 /*

[GitHub] [nuttx] anchao opened a new pull request, #8443: tools/Config: silent print of archive objects

2023-02-06 Thread via GitHub
anchao opened a new pull request, #8443: URL: https://github.com/apache/nuttx/pull/8443 ## Summary tools/Config: silent print of archive objects Signed-off-by: chao an ## Impact N/A ## Testing Before: ``` $ make -j AR (add): libapps.a

[GitHub] [nuttx] jerpelea merged pull request #8437: libc: Define _assert/__assert to avoid 3rd libary redefine them

2023-02-06 Thread via GitHub
jerpelea merged PR #8437: URL: https://github.com/apache/nuttx/pull/8437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] branch master updated: libc: Define _assert/__assert to avoid 3rd libary redefine them

2023-02-06 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 65a04c66a2 libc: Define _assert/__assert to

[GitHub] [nuttx-apps] jerpelea commented on pull request #1542: graphics/ft80x: Fix error: implicit declaration of function 'getpid

2023-02-06 Thread via GitHub
jerpelea commented on PR #1542: URL: https://github.com/apache/nuttx-apps/pull/1542#issuecomment-1419110093 it would be nicer to have 2 patches 1 with the actual changes and 1 with the nxstyle fixes -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx] fjpanag commented on pull request #8129: net/tcp: correct behavior of SO_LINGER

2023-02-06 Thread via GitHub
fjpanag commented on PR #8129: URL: https://github.com/apache/nuttx/pull/8129#issuecomment-1419076671 I just had the time to properly test this. It seems to be working nicely, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nuttx] anchao commented on a diff in pull request #8442: tools/Config: stack usage(.su) file should be removed on clean phase

2023-02-06 Thread via GitHub
anchao commented on code in PR #8442: URL: https://github.com/apache/nuttx/pull/8442#discussion_r1097363774 ## tools/Config.mk: ## @@ -570,10 +570,11 @@ define CLEAN $(call DELFILE,$(subst /,\,$(OBJS))) $(Q) if exist $(BIN) (del /f /q $(subst /,\,$(BIN)))

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8442: tools/Config: stack usage(.su) file should be removed on clean phase

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #8442: URL: https://github.com/apache/nuttx/pull/8442#discussion_r1097361270 ## tools/Config.mk: ## @@ -570,10 +570,11 @@ define CLEAN $(call DELFILE,$(subst /,\,$(OBJS))) $(Q) if exist $(BIN) (del /f /q $(subst

[GitHub] [nuttx] anchao commented on a diff in pull request #8439: rp2040/raspberrypi-pico-w: update submodule to avoid invaild firmware

2023-02-06 Thread via GitHub
anchao commented on code in PR #8439: URL: https://github.com/apache/nuttx/pull/8439#discussion_r1097354992 ## arch/arm/src/rp2040/rp2040_serial.c: ## @@ -884,8 +884,7 @@ static bool up_rxavailable(struct uart_dev_s *dev) static void up_send(struct uart_dev_s *dev, int ch)

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8439: rp2040/raspberrypi-pico-w: update submodule to avoid invaild firmware

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #8439: URL: https://github.com/apache/nuttx/pull/8439#discussion_r1097318858 ## arch/arm/src/rp2040/rp2040_serial.c: ## @@ -884,8 +884,7 @@ static bool up_rxavailable(struct uart_dev_s *dev) static void up_send(struct uart_dev_s *dev,

[nuttx] branch master updated: boards: Enable assert for citest

2023-02-06 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new d8a8c2fdd8 boards: Enable assert for citest

[GitHub] [nuttx] masayuki2009 merged pull request #8364: boards: Enable assert for citest

2023-02-06 Thread via GitHub
masayuki2009 merged PR #8364: URL: https://github.com/apache/nuttx/pull/8364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] branch master updated: fix a bug of strtold

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new de21025702 fix a bug of strtold de21025702 is

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8441: fix a bug of strtold

2023-02-06 Thread via GitHub
xiaoxiang781216 merged PR #8441: URL: https://github.com/apache/nuttx/pull/8441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] anchao opened a new pull request, #8442: tools/Config: stack usage(.su) file should be removed on clean phase

2023-02-06 Thread via GitHub
anchao opened a new pull request, #8442: URL: https://github.com/apache/nuttx/pull/8442 ## Summary tools/Config: stack usage(.su) file should be removed on clean phase Signed-off-by: chao an enable CONFIG_STACK_USAGE, garbage persists after distclean: ``` nuttx$

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8440: fs: support openat/fchmodat/mkfifoat/fstatat/...at api

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on PR #8440: URL: https://github.com/apache/nuttx/pull/8440#issuecomment-1418976035 @yamt openat api is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8370: include/sys/socket.h: Add SOCK_CTRL to socket type

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on PR #8370: URL: https://github.com/apache/nuttx/pull/8370#issuecomment-1418961143 > Dear @xiaoxiang781216 san > > > @SPRESENSE but how to pass the ioctl to usrsock server now? > > This fix only add a new Socket Type for requests to Daemons that do

[GitHub] [nuttx] lucasssvaz commented on pull request #8428: arch/xtensa/esp32s2: Add support for touch pad interrupts

2023-02-06 Thread via GitHub
lucasssvaz commented on PR #8428: URL: https://github.com/apache/nuttx/pull/8428#issuecomment-1418955036 > @lucasssvaz why is it as Draft? Bc it required the other PR first. I'll open it now. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #7525: Improvements in TCP connections allocation.

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on PR #7525: URL: https://github.com/apache/nuttx/pull/7525#issuecomment-1418955162 > Hmm, why is this check failing? I think that `checkpatch.sh` picks up other commits than the two actually in this PR? Please rebase your patch to the last master to fix

[GitHub] [nuttx] SPRESENSE commented on pull request #8370: include/sys/socket.h: Add SOCK_CTRL to socket type

2023-02-06 Thread via GitHub
SPRESENSE commented on PR #8370: URL: https://github.com/apache/nuttx/pull/8370#issuecomment-141402 > @SPRESENSE but how to pass the ioctl to usrsock server now? This fix only add a new Socket Type for requests to Daemons that do not use the device's Socket. Therefore, the

[GitHub] [nuttx] flyingfish89 opened a new pull request, #8441: fix a bug of strtold

2023-02-06 Thread via GitHub
flyingfish89 opened a new pull request, #8441: URL: https://github.com/apache/nuttx/pull/8441 ## Summary if input is -1e308,The output should be -1.. but the output is -inf ## Impact ## Testing -- This is an automated message from the Apache Git

[GitHub] [nuttx] fjpanag commented on pull request #7525: Improvements in TCP connections allocation.

2023-02-06 Thread via GitHub
fjpanag commented on PR #7525: URL: https://github.com/apache/nuttx/pull/7525#issuecomment-1418872744 Hmm, why is this check failing? I think that `checkpatch.sh` picks up other commits than the two actually in this PR? -- This is an automated message from the Apache Git Service. To

[GitHub] [nuttx] flyingfish89 commented on pull request #7992: modify the strtof

2023-02-06 Thread via GitHub
flyingfish89 commented on PR #7992: URL: https://github.com/apache/nuttx/pull/7992#issuecomment-1418869296 > @flyingfish89 I just applied this, and the tests now pass. ok.thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [nuttx] fjpanag commented on pull request #7992: modify the strtof

2023-02-06 Thread via GitHub
fjpanag commented on PR #7992: URL: https://github.com/apache/nuttx/pull/7992#issuecomment-1418867515 @flyingfish89 I just applied this, and the tests now pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8364: boards: Enable assert for citest

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on PR #8364: URL: https://github.com/apache/nuttx/pull/8364#issuecomment-1418864075 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nuttx] Donny9 opened a new pull request, #8440: fs: support openat/fchmodat/mkfifoat/fstatat/...at api

2023-02-06 Thread via GitHub
Donny9 opened a new pull request, #8440: URL: https://github.com/apache/nuttx/pull/8440 ## Summary fs: support openat/fchmodat/mkfifoat/fstatat/...at api Refs to: https://linux.die.net/man/2/openat ## Impact support file api with relative directory path spicified dirfd ##

[GitHub] [nuttx-apps] xiaoxiang781216 opened a new pull request, #1543: bluetooth/nimble: Update to ed083b36cb85c7437b905ee905ea4aed6a1653ad

2023-02-06 Thread via GitHub
xiaoxiang781216 opened a new pull request, #1543: URL: https://github.com/apache/nuttx-apps/pull/1543 ## Summary which contain the fix: https://github.com/apache/mynewt-nimble/pull/1457 ## Impact nimble ## Testing CI -- This is an automated message from

[GitHub] [nuttx] masayuki2009 commented on pull request #8364: boards: Enable assert for citest

2023-02-06 Thread via GitHub
masayuki2009 commented on PR #8364: URL: https://github.com/apache/nuttx/pull/8364#issuecomment-1418859292 @xiaoxiang781216 Please remove boards/arm/imx6/sabre-6quad/configs/citest/defconfig from this PR. -- This is an automated message from the Apache Git Service. To respond to

[nuttx] 02/03: boards: sabre-6quad: Update README.txt

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 25a6448a1ab3b001d055ca61edd4a75fc3849a3c Author: Masayuki Ishikawa AuthorDate: Mon Feb 6 14:37:51 2023 +0900

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8438: Update sabre-6quad with QEMU

2023-02-06 Thread via GitHub
xiaoxiang781216 merged PR #8438: URL: https://github.com/apache/nuttx/pull/8438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] 01/03: boards: sabre-6quad: Enable DEBUG_ASSERTION in citest

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 50989430cd1acfb9ee3696dc04b8a19cbc9d8fa9 Author: Masayuki Ishikawa AuthorDate: Mon Feb 6 14:30:44 2023 +0900

[nuttx] branch master updated (9d8f7de81c -> 79704620f8)

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 9d8f7de81c build(deps): bump docker/build-push-action from 3 to 4 new 50989430cd boards: sabre-6quad: Enable

[nuttx] 03/03: tools: ci: Fix testrun/utins/common.py for sabrelite (QEMU)

2023-02-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 79704620f8d7efe34984e67621bfa00ccbf72127 Author: Masayuki Ishikawa AuthorDate: Mon Feb 6 16:44:57 2023 +0900

[GitHub] [nuttx] anchao commented on issue #7475: RaspberryPi-Pico-W is not getting WiFi

2023-02-06 Thread via GitHub
anchao commented on issue #7475: URL: https://github.com/apache/nuttx/issues/7475#issuecomment-1418835020 Please note that the setup process of the cyw43 driver has changed: ``` 1. Download Raspberry Pi Pico SDK and update submodule(cyw43-driver) $ git clone -b 1.4.0

[GitHub] [nuttx] anchao commented on issue #7475: RaspberryPi-Pico-W is not getting WiFi

2023-02-06 Thread via GitHub
anchao commented on issue #7475: URL: https://github.com/apache/nuttx/issues/7475#issuecomment-1418815688 @acassis @TA1DB please help to review PR https://github.com/apache/nuttx/pull/8439 , which fixed CYW43 not working properly on pico-W -- This is an automated message from the Apache

[GitHub] [nuttx] anchao opened a new pull request, #8439: rp2040/raspberrypi-pico-w: update submodule to avoid invaild firmware

2023-02-06 Thread via GitHub
anchao opened a new pull request, #8439: URL: https://github.com/apache/nuttx/pull/8439 ## Summary 1. rp2040/raspberrypi-pico-w: update submodule to avoid invaild firmware The cyw43-driver is a submodule in the pick-sdk, if the submodule is not updated, the dummy firmware

[GitHub] [nuttx] masayuki2009 commented on pull request #8438: Update sabre-6quad with QEMU

2023-02-06 Thread via GitHub
masayuki2009 commented on PR #8438: URL: https://github.com/apache/nuttx/pull/8438#issuecomment-1418806130 @jerpelea Please merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
pussuw commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1097144860 ## binfmt/binfmt_execmodule.c: ## @@ -164,23 +164,23 @@ int exec_module(FAR const struct binary_s *binp, #if defined(CONFIG_ARCH_ADDRENV) && defined(CONFIG_BUILD_KERNEL)

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1097133662 ## binfmt/binfmt_execmodule.c: ## @@ -164,23 +164,23 @@ int exec_module(FAR const struct binary_s *binp, #if defined(CONFIG_ARCH_ADDRENV) &&

[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
pussuw commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1097128890 ## include/nuttx/addrenv.h: ## @@ -218,13 +225,27 @@ (CONFIG_ARCH_PGPOOL_VBASE + CONFIG_ARCH_PGPOOL_SIZE) #endif

[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
pussuw commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1097128601 ## binfmt/binfmt_execmodule.c: ## @@ -164,23 +164,23 @@ int exec_module(FAR const struct binary_s *binp, #if defined(CONFIG_ARCH_ADDRENV) && defined(CONFIG_BUILD_KERNEL)

[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
pussuw commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1097128261 ## include/nuttx/addrenv.h: ## @@ -218,13 +220,24 @@ (CONFIG_ARCH_PGPOOL_VBASE + CONFIG_ARCH_PGPOOL_SIZE) #endif

[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
pussuw commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1097070781 ## binfmt/binfmt_execmodule.c: ## @@ -164,23 +164,23 @@ int exec_module(FAR const struct binary_s *binp, #if defined(CONFIG_ARCH_ADDRENV) && defined(CONFIG_BUILD_KERNEL)

[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-02-06 Thread via GitHub
pussuw commented on code in PR #8355: URL: https://github.com/apache/nuttx/pull/8355#discussion_r1097066421 ## arch/arm/src/armv7-a/arm_addrenv.c: ## @@ -778,22 +671,18 @@ int up_addrenv_clone(const arch_addrenv_t *src, * is created that needs to share the address

  1   2   >