[GitHub] [incubator-pinot] jackjlli opened a new pull request #4561: Add metric on Helix and Pinot controller leadership

jackjlli opened a new pull request #4561: Add metric on Helix and Pinot controller leadership URL: https://github.com/apache/incubator-pinot/pull/4561 This PR adds controller metrics on Helix and Pinot controller leadership.

[incubator-pinot] 01/01: Add metric on Helix and Pinot controller leadership

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch add-partition-leader-metrics in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 8ca22a37397416231ed4cf420049a0218257865a Author: jackjlli AuthorDate: Fri Aug 23 20:48:34

[incubator-pinot] branch add-partition-leader-metrics updated (dd6118a -> 8ca22a3)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-partition-leader-metrics in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard dd6118a Add metric on Helix and Pinot controller leadership new 8ca22a3 Add

[GitHub] [incubator-pinot] xiaohui-sun commented on issue #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout

xiaohui-sun commented on issue #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout URL: https://github.com/apache/incubator-pinot/pull/4554#issuecomment-524516108 LGTM! Congrats on your first PR on ThirdEye. @vincentchenjl

[incubator-pinot] 01/01: Add metric on Helix and Pinot controller leadership

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch add-partition-leader-metrics in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit dd6118a5f8363937f606b54a4e2e9644156c4f30 Author: jackjlli AuthorDate: Fri Aug 23 20:48:34

[incubator-pinot] branch add-partition-leader-metrics created (now dd6118a)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-partition-leader-metrics in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at dd6118a Add metric on Helix and Pinot controller leadership This branch includes the

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout

xiaohui-sun commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout URL: https://github.com/apache/incubator-pinot/pull/4554#discussion_r317343023 ## File path:

[GitHub] [incubator-pinot] mcvsubbu merged pull request #4557: Support transform functions with AVG aggregation function

mcvsubbu merged pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557 This is an automated message from the Apache Git Service. To respond to

[incubator-pinot] branch master updated (f688776 -> 7c7b6cc)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from f688776 Cleanup preprocess (#4552) add 7c7b6cc Support transform functions with AVG aggregation

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4547: [Not ready for review] Indexed table

codecov-io edited a comment on issue #4547: [Not ready for review] Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#issuecomment-523722088 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4547?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4553: Add integration test for ControllerLeaderLocator

codecov-io edited a comment on issue #4553: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#issuecomment-524232323 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

codecov-io edited a comment on issue #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#issuecomment-524196402 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4555?src=pr=h1) Report >

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4560: Fix flaky ControllerInstanceToggleTest

codecov-io edited a comment on issue #4560: Fix flaky ControllerInstanceToggleTest URL: https://github.com/apache/incubator-pinot/pull/4560#issuecomment-524490973 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4560?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4557: Support transform functions with AVG aggregation function

codecov-io edited a comment on issue #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#issuecomment-524487278 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4557?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4552: Cleanup preprocess

codecov-io edited a comment on issue #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#issuecomment-524431113 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4552?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

Jackie-Jiang commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317335494 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator

jackjlli commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r317334696 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator

jackjlli commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r317334710 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator

jackjlli commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r317334621 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4560: Fix flaky ControllerInstanceToggleTest

Jackie-Jiang commented on a change in pull request #4560: Fix flaky ControllerInstanceToggleTest URL: https://github.com/apache/incubator-pinot/pull/4560#discussion_r317333421 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r31739 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4560: Fix flaky ControllerInstanceToggleTest

jackjlli commented on a change in pull request #4560: Fix flaky ControllerInstanceToggleTest URL: https://github.com/apache/incubator-pinot/pull/4560#discussion_r317332807 ## File path:

[incubator-pinot] branch master updated (cf9974c -> f688776)

This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from cf9974c Fixing the issue of selection order-by won't give correct ordering (#4540) add f688776

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4557: Support transform functions with AVG aggregation function

siddharthteotia commented on issue #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#issuecomment-524493483 Addressed the comments This is an automated

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4557: Support transform functions with AVG aggregation function

siddharthteotia commented on a change in pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#discussion_r317331514 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4557: Support transform functions with AVG aggregation function

siddharthteotia commented on a change in pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#discussion_r317331522 ## File path:

[GitHub] [incubator-pinot] jenniferdai merged pull request #4552: Cleanup preprocess

jenniferdai merged pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4557: Support transform functions with AVG aggregation function

siddharthteotia commented on a change in pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#discussion_r317331485 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4557: Support transform functions with AVG aggregation function

siddharthteotia commented on a change in pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#discussion_r317331487 ## File path:

[incubator-pinot] branch cleanup updated (a29f350 -> 3d673ec)

This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from a29f350 Addressing comments add 3d673ec Addressing comments No new revisions were added by

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4560: Fix flaky ControllerInstanceToggleTest

Jackie-Jiang commented on a change in pull request #4560: Fix flaky ControllerInstanceToggleTest URL: https://github.com/apache/incubator-pinot/pull/4560#discussion_r317330182 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317329217 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -400,15

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317329530 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/InternalConfigConstants.java ## @@ -36,4 +36,10

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317328868 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -151,162

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317329142 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -151,162

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317329018 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -151,162

[GitHub] [incubator-pinot] codecov-io commented on issue #4560: Fix flaky ControllerInstanceToggleTest

codecov-io commented on issue #4560: Fix flaky ControllerInstanceToggleTest URL: https://github.com/apache/incubator-pinot/pull/4560#issuecomment-524490973 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4560?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4545: Add APIs to get leader for all tables or a given table

mcvsubbu commented on a change in pull request #4545: Add APIs to get leader for all tables or a given table URL: https://github.com/apache/incubator-pinot/pull/4545#discussion_r316489952 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator

mcvsubbu commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r317328071 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator

mcvsubbu commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r317328280 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator

mcvsubbu commented on a change in pull request #4553: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r317328147 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4560: Fix flaky ControllerInstanceToggleTest

mcvsubbu commented on issue #4560: Fix flaky ControllerInstanceToggleTest URL: https://github.com/apache/incubator-pinot/pull/4560#issuecomment-524488349 I didn't get why liveinstance can be null. Can you add some comments in that regard in the test?

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout

vincentchenjl commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout URL: https://github.com/apache/incubator-pinot/pull/4554#discussion_r317326724 ## File path:

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout

vincentchenjl commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout URL: https://github.com/apache/incubator-pinot/pull/4554#discussion_r317326074 ## File path:

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout

vincentchenjl commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout URL: https://github.com/apache/incubator-pinot/pull/4554#discussion_r317326098 ## File path:

[GitHub] [incubator-pinot] codecov-io commented on issue #4557: Support transform functions with AVG aggregation function

codecov-io commented on issue #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#issuecomment-524487278 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4557?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout

vincentchenjl commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout URL: https://github.com/apache/incubator-pinot/pull/4554#discussion_r317326143 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

Jackie-Jiang commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317325604 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317325242 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317325018 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

Jackie-Jiang commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317324646 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4557: Support transform functions with AVG aggregation function

Jackie-Jiang commented on a change in pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#discussion_r317320415 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4557: Support transform functions with AVG aggregation function

Jackie-Jiang commented on a change in pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#discussion_r317320037 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4557: Support transform functions with AVG aggregation function

Jackie-Jiang commented on a change in pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#discussion_r317320082 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4557: Support transform functions with AVG aggregation function

Jackie-Jiang commented on a change in pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#discussion_r317319927 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4557: Support transform functions with AVG aggregation function

Jackie-Jiang commented on a change in pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#discussion_r317320479 ## File path:

[GitHub] [incubator-pinot] jackjlli opened a new pull request #4560: Fix ControllerInstanceToggleTest

jackjlli opened a new pull request #4560: Fix ControllerInstanceToggleTest URL: https://github.com/apache/incubator-pinot/pull/4560 This PR fixes ControllerInstanceToggleTest. Basically the POST request can receive non-200 status code because the live instance could be null.

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools

snleee commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools URL: https://github.com/apache/incubator-pinot/pull/4556#discussion_r317318140 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools

kishoreg commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools URL: https://github.com/apache/incubator-pinot/pull/4556#discussion_r317314231 ## File path: pinot-tools/pom.xml ## @@ -98,6 +103,21 @@ org.apache.commons

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools

snleee commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools URL: https://github.com/apache/incubator-pinot/pull/4556#discussion_r317312043 ## File path: pinot-tools/pom.xml ## @@ -98,6 +103,21 @@ org.apache.commons

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

codecov-io edited a comment on issue #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#issuecomment-524196402 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4555?src=pr=h1) Report >

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317302567 ## File path:

[GitHub] [incubator-pinot] fx19880617 opened a new issue #4559: Support Json as a new column data type

fx19880617 opened a new issue #4559: Support Json as a new column data type URL: https://github.com/apache/incubator-pinot/issues/4559 This is to support unstructured data with ad-hoc analytics. Note that the purpose of this feature is not for fast query (fast query should always extract

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317301687 ## File path:

[GitHub] [incubator-pinot] mcvsubbu opened a new issue #4558: Support date time columns in metrics aggregation

mcvsubbu opened a new issue #4558: Support date time columns in metrics aggregation URL: https://github.com/apache/incubator-pinot/issues/4558 Metrics aggregation code in MutableSegmentImpl (realtime consuming segment code) currently ignores date time columns. If these columns are

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317300444 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317300490 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317299830 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317299863 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

jackjlli commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317297050 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi…

jackjlli commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317294564 ## File path:

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #4550: Support transform functions with AVG aggregation function

siddharthteotia edited a comment on issue #4550: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4550#issuecomment-524448411 Closing this one after discussing with @Jackie-Jiang. The new PR with fewer changes --

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4557: Support transform functions with AVG aggregation function

siddharthteotia commented on issue #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557#issuecomment-524449136 @Jackie-Jiang , the reason for creating a separate test file is because InnerSegment/InterSegment queries

[GitHub] [incubator-pinot] siddharthteotia closed pull request #4550: Support transform functions with AVG aggregation function

siddharthteotia closed pull request #4550: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4550 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4550: Support transform functions with AVG aggregation function

siddharthteotia commented on issue #4550: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4550#issuecomment-524448411 Closing this one after discussing with @Jackie-Jiang. The new PR here is fewer changes --

[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #4557: Support transform functions with AVG aggregation function

siddharthteotia opened a new pull request #4557: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4557 Support queries like: SELECT AVG(SUB(col1, col2) FROM foo SELECT AVG(SUB(DIV(col1, col2), DIV(col3, col4))) FROM foo

[GitHub] [incubator-pinot] codecov-io commented on issue #4556: Support aws s3 with Parquet in pinot-tools

codecov-io commented on issue #4556: Support aws s3 with Parquet in pinot-tools URL: https://github.com/apache/incubator-pinot/pull/4556#issuecomment-524439907 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4556?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io commented on issue #4552: Cleanup preprocess

codecov-io commented on issue #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#issuecomment-524431113 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4552?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4550: Support transform functions with AVG aggregation function

Jackie-Jiang commented on a change in pull request #4550: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4550#discussion_r317267787 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4550: Support transform functions with AVG aggregation function

Jackie-Jiang commented on a change in pull request #4550: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4550#discussion_r317267787 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4550: Support transform functions with AVG aggregation function

Jackie-Jiang commented on a change in pull request #4550: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4550#discussion_r317267011 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout

jihaozh commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout URL: https://github.com/apache/incubator-pinot/pull/4554#discussion_r317266945 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4550: Support transform functions with AVG aggregation function

Jackie-Jiang commented on a change in pull request #4550: Support transform functions with AVG aggregation function URL: https://github.com/apache/incubator-pinot/pull/4550#discussion_r317266832 ## File path:

[incubator-pinot] branch cleanup updated (4879051 -> a29f350)

This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 4879051 Addressing comments add a29f350 Addressing comments This update added new revisions

[incubator-pinot] branch cleanup updated (4977f94 -> 4879051)

This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 4977f94 Addressing comments add 4879051 Addressing comments No new revisions were added by

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools

fx19880617 commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools URL: https://github.com/apache/incubator-pinot/pull/4556#discussion_r317260114 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools

fx19880617 commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools URL: https://github.com/apache/incubator-pinot/pull/4556#discussion_r317260114 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java

[incubator-pinot] branch support_aws_in_hadoop updated (636204c -> 1e8e8fd)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_aws_in_hadoop in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 636204c Support aws s3 with Parquet in pinot-tools add 1e8e8fd resolve dependency

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools

fx19880617 commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools URL: https://github.com/apache/incubator-pinot/pull/4556#discussion_r317259300 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317259264 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -505,6

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317258735 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -505,6

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317258735 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -505,6

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout

xiaohui-sun commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout URL: https://github.com/apache/incubator-pinot/pull/4554#discussion_r317256900 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout

xiaohui-sun commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout URL: https://github.com/apache/incubator-pinot/pull/4554#discussion_r317244296 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout

xiaohui-sun commented on a change in pull request #4554: [TE] Add timeout for all tasks and clean up RUNNING states if timeout URL: https://github.com/apache/incubator-pinot/pull/4554#discussion_r317255993 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317256899 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -505,6

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317256386 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -505,6

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317255283 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/SegmentPreprocessingMapper.java ## @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317254998 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -404,9

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess

Jackie-Jiang commented on a change in pull request #4552: Cleanup preprocess URL: https://github.com/apache/incubator-pinot/pull/4552#discussion_r317254204 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ## @@ -151,153

  1   2   >