[GitHub] [incubator-pinot] snleee commented on issue #4585: Presence vector

snleee commented on issue #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#issuecomment-534396473 @icefury71 Thanks for the reply. LGTM assuming that you address the comments above (2 spaces, comment on bloom filter etc). I will merge this once that part is

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4579: Misc fixes for aggregation functions

codecov-io edited a comment on issue #4579: Misc fixes for aggregation functions URL: https://github.com/apache/incubator-pinot/pull/4579#issuecomment-527778243 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4579?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API

codecov-io edited a comment on issue #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API URL: https://github.com/apache/incubator-pinot/pull/4362#issuecomment-506464844 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4362?src=pr=h1)

[GitHub] [incubator-pinot] codecov-io commented on issue #4385: Implement OffHeapMutableBytesStore for real-time var-length bytes store

codecov-io commented on issue #4385: Implement OffHeapMutableBytesStore for real-time var-length bytes store URL: https://github.com/apache/incubator-pinot/pull/4385#issuecomment-534350691 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4385?src=pr=h1) Report > Merging

[incubator-pinot] branch aggregation_function updated (6088ad0 -> 400bb61)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch aggregation_function in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 6088ad0 Misc fixes for aggregation functions add a1c5af7 [TE] Return the anomaly

[incubator-pinot] branch mutable_off_heap updated (0615c43 -> 530af50)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch mutable_off_heap in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 0615c43 Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API

[incubator-pinot] branch offheap_var_length_store updated (a342d57 -> 5ee259e)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch offheap_var_length_store in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a342d57 Implement OffHeapMutableBytesStore for real-time var-length bytes store

[incubator-pinot] branch fix_selection_order_by deleted (was c849dd0)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch fix_selection_order_by in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was c849dd0 Put order-by expressions in front of selection expreesions in selection

[incubator-pinot] branch master updated (3668c79 -> f8c2cf3)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3668c79 Documentation update for realtime Pinot (#4630) add f8c2cf3 Put order-by expressions in

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

Jackie-Jiang merged pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629 This is an automated message from the

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

codecov-io edited a comment on issue #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#issuecomment-533946578 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr=h1)

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4593: Do not update download URL and crypter when segment is not refreshed

Jackie-Jiang commented on a change in pull request #4593: Do not update download URL and crypter when segment is not refreshed URL: https://github.com/apache/incubator-pinot/pull/4593#discussion_r327385542 ## File path:

[incubator-pinot] branch master updated (eda4176 -> 3668c79)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from eda4176 [TE] [Notification] Refactor email filters to a generalized alert filter (#4620) add

[GitHub] [incubator-pinot] mcvsubbu merged pull request #4630: Documentation update for realtime Pinot

mcvsubbu merged pull request #4630: Documentation update for realtime Pinot URL: https://github.com/apache/incubator-pinot/pull/4630 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4593: Do not update download URL and crypter when segment is not refreshed

jackjlli commented on a change in pull request #4593: Do not update download URL and crypter when segment is not refreshed URL: https://github.com/apache/incubator-pinot/pull/4593#discussion_r327380362 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4374: Enhance the time boundary service to get consistent result

Jackie-Jiang commented on issue #4374: Enhance the time boundary service to get consistent result URL: https://github.com/apache/incubator-pinot/pull/4374#issuecomment-534331889 Drop this PR. Offline and Realtime table should handle the time value in the same fashion.

[GitHub] [incubator-pinot] Jackie-Jiang closed pull request #4374: Enhance the time boundary service to get consistent result

Jackie-Jiang closed pull request #4374: Enhance the time boundary service to get consistent result URL: https://github.com/apache/incubator-pinot/pull/4374 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch time_boundary deleted (was 8706f3f)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch time_boundary in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 8706f3f Enhance the time boundary service to get consistent result The revisions that were on this

[incubator-pinot] branch fix_selection_order_by updated (72b0af2 -> c849dd0)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch fix_selection_order_by in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 72b0af2 Put order-by expressions in front of selection expreesions in selection

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

Jackie-Jiang commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327378692 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4535: Implement DISTINCT clause

codecov-io edited a comment on issue #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#issuecomment-524000641 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4535?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jackjlli opened a new pull request #4633: Add metrics for the number of partitions for which controller becomes leader

jackjlli opened a new pull request #4633: Add metrics for the number of partitions for which controller becomes leader URL: https://github.com/apache/incubator-pinot/pull/4633 This PR adds metrics to track the number of partitions for which controller becomes leader, so that when the

[incubator-pinot] branch add-metric-on-num-partitions created (now 4845447)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-metric-on-num-partitions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 4845447 Add metrics to track the number of partitions for which controller becomes

[incubator-pinot] 01/01: Add metrics to track the number of partitions for which controller becomes leader

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch add-metric-on-num-partitions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 484544775eaa6999f1649b5d8b704d239c723260 Author: jackjlli AuthorDate: Mon Sep 23 16:43:00

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

Jackie-Jiang commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327371952 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

Jackie-Jiang commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327368606 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

Jackie-Jiang commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327367426 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

siddharthteotia commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327367250 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4593: Do not update download URL and crypter when segment is not refreshed

codecov-io edited a comment on issue #4593: Do not update download URL and crypter when segment is not refreshed URL: https://github.com/apache/incubator-pinot/pull/4593#issuecomment-529022606 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4593?src=pr=h1) Report >

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

npawar commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327357688 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4630: Documentation update for realtime Pinot

codecov-io edited a comment on issue #4630: Documentation update for realtime Pinot URL: https://github.com/apache/incubator-pinot/pull/4630#issuecomment-534214610 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4630?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4593: Do not update download URL and crypter when segment is not refreshed

Jackie-Jiang commented on issue #4593: Do not update download URL and crypter when segment is not refreshed URL: https://github.com/apache/incubator-pinot/pull/4593#issuecomment-534307122 @icefury71 Good suggestion, added.

[incubator-pinot] branch fix_download_uri updated (7dea9a1 -> c9dcabd)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch fix_download_uri in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 7dea9a1 Do not update download URL and crypter when segment is not refreshed add 3c2f0b3

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4630: Documentation update for realtime Pinot

mcvsubbu commented on a change in pull request #4630: Documentation update for realtime Pinot URL: https://github.com/apache/incubator-pinot/pull/4630#discussion_r327341495 ## File path: docs/tableconfig_schema.rst ## @@ -68,26 +72,26 @@ The ``segmentsConfig`` section has

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4630: Documentation update for realtime Pinot

npawar commented on a change in pull request #4630: Documentation update for realtime Pinot URL: https://github.com/apache/incubator-pinot/pull/4630#discussion_r327328868 ## File path: docs/tableconfig_schema.rst ## @@ -207,3 +243,116 @@ The ``metadata`` section is used

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

Jackie-Jiang commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327327233 ## File path:

[incubator-pinot] branch fix_selection_order_by updated (08b4123 -> 72b0af2)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch fix_selection_order_by in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 08b4123 Put order-by expressions in front of selection expreesions in selection

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4630: Documentation update for realtime Pinot

npawar commented on a change in pull request #4630: Documentation update for realtime Pinot URL: https://github.com/apache/incubator-pinot/pull/4630#discussion_r327325844 ## File path: docs/tableconfig_schema.rst ## @@ -68,26 +72,26 @@ The ``segmentsConfig`` section has

[GitHub] [incubator-pinot] chenboat commented on issue #4626: Low level realtime consumer (LLC) got into ERROR state due to thread race condition.

chenboat commented on issue #4626: Low level realtime consumer (LLC) got into ERROR state due to thread race condition. URL: https://github.com/apache/incubator-pinot/issues/4626#issuecomment-534276264 Thanks @mcvsubbu for the replies. > Do you have a feel of why we were waiting so

[GitHub] [incubator-pinot] jenniferdai opened a new pull request #4632: Revert "Set processingException when all queried segments cannot be a…

jenniferdai opened a new pull request #4632: Revert "Set processingException when all queried segments cannot be a… URL: https://github.com/apache/incubator-pinot/pull/4632 …cquired (#3942)" This reverts commit d4f2ecef660ab1d4efa9696a53b0623aac867c3f. Spoke with Sunitha

[incubator-pinot] 01/01: Revert "Set processingException when all queried segments cannot be acquired (#3942)"

This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a commit to branch revert in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 353c7b106179b00e004b3e976bc6068d9b01b950 Author: Jennifer Dai AuthorDate: Mon Sep 23 13:36:40 2019 -0700

[incubator-pinot] branch revert created (now 353c7b1)

This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch revert in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 353c7b1 Revert "Set processingException when all queried segments cannot be acquired (#3942)" This

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

siddharthteotia commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327298760 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4630: Documentation update for realtime Pinot

mcvsubbu commented on a change in pull request #4630: Documentation update for realtime Pinot URL: https://github.com/apache/incubator-pinot/pull/4630#discussion_r327297139 ## File path: docs/architecture.rst ## @@ -122,22 +128,58 @@ strategy and the use case. Data in

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4535: Implement DISTINCT clause

codecov-io edited a comment on issue #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#issuecomment-524000641 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4535?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

siddharthteotia commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327264476 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on issue #4603: Can not find a deserializer for non-concrete Map type

fx19880617 commented on issue #4603: Can not find a deserializer for non-concrete Map type URL: https://github.com/apache/incubator-pinot/issues/4603#issuecomment-534222185 Hi @AnishKanth, could you put the post request you are using? Also have you tried out `pinot-admin` command?

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

Jackie-Jiang commented on issue #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#issuecomment-534221224 @mayankshriv Addressed all the comments. The temporary handling code is manually

[GitHub] [incubator-pinot] AnishKanth commented on issue #4603: Can not find a deserializer for non-concrete Map type

AnishKanth commented on issue #4603: Can not find a deserializer for non-concrete Map type URL: https://github.com/apache/incubator-pinot/issues/4603#issuecomment-534220204 > The docker image that you mentioned is very old one (2 yrs ago) and may contain very old version of Pinot. Can

[GitHub] [incubator-pinot] AnishKanth removed a comment on issue #4603: Can not find a deserializer for non-concrete Map type

AnishKanth removed a comment on issue #4603: Can not find a deserializer for non-concrete Map type URL: https://github.com/apache/incubator-pinot/issues/4603#issuecomment-531136177 Facing the same issue with docker from above mentioned path

[incubator-pinot] branch fix_selection_order_by updated (c93213c -> 08b4123)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch fix_selection_order_by in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard c93213c Put order-by expressions in front of selection expreesions in selection

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4630: Documentation update for realtime Pinot

kishoreg commented on a change in pull request #4630: Documentation update for realtime Pinot URL: https://github.com/apache/incubator-pinot/pull/4630#discussion_r327254171 ## File path: docs/architecture.rst ## @@ -122,22 +128,58 @@ strategy and the use case. Data in

[GitHub] [incubator-pinot] codecov-io commented on issue #4630: Documentation update for realtime Pinot

codecov-io commented on issue #4630: Documentation update for realtime Pinot URL: https://github.com/apache/incubator-pinot/pull/4630#issuecomment-534214610 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4630?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] npawar commented on issue #4602: First pass of GROUP BY with ORDER BY support

npawar commented on issue #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-534213027 > Will performance numbers be shared in this PR, or following PR's? I'll include performance numbers in this PR

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r327250217 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4535: Implement DISTINCT clause

siddharthteotia commented on issue #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#issuecomment-534211898 @Jackie-Jiang , thanks for reviewing. Addressed your latest comments. We can merge this once "code yellow" ends.

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248381 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248481 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248500 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248358 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248334 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DefaultAggregationExecutor.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248459 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248233 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248286 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -174,13

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248314 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -277,6

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248213 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248269 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248187 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248157 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248129 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248106 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248088 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r327248065 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4631: [TE] frontend - harleyjj/rca - make first column scrollable in dimens…

harleyjj opened a new pull request #4631: [TE] frontend - harleyjj/rca - make first column scrollable in dimens… URL: https://github.com/apache/incubator-pinot/pull/4631 …ions-algorithm table This is an automated message

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

mayankshriv commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327240503 ## File path:

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

mayankshriv commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327239638 ## File path:

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

mayankshriv commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327236918 ## File path:

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema

mayankshriv commented on a change in pull request #4629: Put order-by expressions in front of selection expreesions in selection DataSchema URL: https://github.com/apache/incubator-pinot/pull/4629#discussion_r327225380 ## File path:

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #4630: Documentation update for realtime Pinot

mcvsubbu opened a new pull request #4630: Documentation update for realtime Pinot URL: https://github.com/apache/incubator-pinot/pull/4630 Realtime consumption and configuration described. Added a tuning section for realtime Other minor changes that I accumulated over time.

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r327216895 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r327216152 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java