[GitHub] [incubator-pinot] fx19880617 commented on issue #4200: Adding script to build and publish docker image

2019-05-28 Thread GitBox
fx19880617 commented on issue #4200: Adding script to build and publish docker image URL: https://github.com/apache/incubator-pinot/pull/4200#issuecomment-496780996 I think we should maintain an official Pinot dockerhub account and make docker image publish as part of the release process.

[GitHub] [incubator-pinot] fx19880617 commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy

2019-05-28 Thread GitBox
fx19880617 commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy URL: https://github.com/apache/incubator-pinot/issues/4248#issuecomment-496779259 also cc @icefury71 ^^ This is an automated

[GitHub] [incubator-pinot] fx19880617 commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy

2019-05-28 Thread GitBox
fx19880617 commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy URL: https://github.com/apache/incubator-pinot/issues/4248#issuecomment-496767998 Got it. @jamesyfshao ^^ This is an automated

[GitHub] [incubator-pinot] jitendratheta commented on issue #4243: Add support for passing headers in pinot client

2019-05-28 Thread GitBox
jitendratheta commented on issue #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#issuecomment-496766967 > Thanks @jitendratheta for the explanation. It looks good to me overall. Have a few more questions before I sign off to

[GitHub] [incubator-pinot] snleee commented on issue #4252: pinot_kafka_0.9.0.1 module

2019-05-28 Thread GitBox
snleee commented on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-496749877 > > > > What is the plan on the naming for the module for different Kafka version implementation? I think that we should keep one implementation for

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy

2019-05-28 Thread GitBox
Jackie-Jiang commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy URL: https://github.com/apache/incubator-pinot/issues/4248#issuecomment-496748846 @fx19880617 FASTHLL takes String type of serialized HyperLogLog objects, while DISTINCTCOUNTHLL can take

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4252: pinot_kafka_0.9.0.1 module

2019-05-28 Thread GitBox
mcvsubbu commented on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-496747138 > > > What is the plan on the naming for the module for different Kafka version implementation? I think that we should keep one implementation for

[GitHub] [incubator-pinot] snleee commented on issue #4252: pinot_kafka_0.9.0.1 module

2019-05-28 Thread GitBox
snleee commented on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-496746913 > > What is the plan on the naming for the module for different Kafka version implementation? I think that we should keep one implementation for each

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4252: pinot_kafka_0.9.0.1 module

2019-05-28 Thread GitBox
mcvsubbu commented on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-496744869 > What is the plan on the naming for the module for different Kafka version implementation? I think that we should keep one implementation for each

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4254: [TE] frontend - harleyjj/preview - ensure zoom buttons are over shade…

2019-05-28 Thread GitBox
harleyjj opened a new pull request #4254: [TE] frontend - harleyjj/preview - ensure zoom buttons are over shade… URL: https://github.com/apache/incubator-pinot/pull/4254 …d region 1) Targets bounds region to g element "below" where the slider buttons are drawn 2) Moves slider

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4200: Adding script to build and publish docker image

2019-05-28 Thread GitBox
codecov-io edited a comment on issue #4200: Adding script to build and publish docker image URL: https://github.com/apache/incubator-pinot/pull/4200#issuecomment-496096212 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4200?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] fx19880617 edited a comment on issue #4248: Alternative HyperLogLog implementation with higher accuracy

2019-05-28 Thread GitBox
fx19880617 edited a comment on issue #4248: Alternative HyperLogLog implementation with higher accuracy URL: https://github.com/apache/incubator-pinot/issues/4248#issuecomment-496738719 Could you elaborate more on the performance and do you do the performance testing? Below is how

[GitHub] [incubator-pinot] fx19880617 commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy

2019-05-28 Thread GitBox
fx19880617 commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy URL: https://github.com/apache/incubator-pinot/issues/4248#issuecomment-496738719 Could you elaborate more on the performance and do you do the performance testing? Below is how we use

[GitHub] [incubator-pinot] jackjlli opened a new pull request #4253: Add pre-compute Hadoop job

2019-05-28 Thread GitBox
jackjlli opened a new pull request #4253: Add pre-compute Hadoop job URL: https://github.com/apache/incubator-pinot/pull/4253 We’ve seen some requests from client that we add partitioning, sorting and resizing functionalities in/before the actual Pinot related Hadoop jobs. And without

[GitHub] [incubator-pinot] snleee commented on issue #4252: pinot_kafka_0.9.0.1 module

2019-05-28 Thread GitBox
snleee commented on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-496737902 What is the plan on the naming for the module for different Kafka version implementation? I think that we should keep one implementation for each

[GitHub] [incubator-pinot] snleee edited a comment on issue #4252: pinot_kafka_0.9.0.1 module

2019-05-28 Thread GitBox
snleee edited a comment on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-496737902 What is the plan on the naming for the module for different Kafka version implementation? I think that we should keep one implementation for

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy

2019-05-28 Thread GitBox
Jackie-Jiang commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy URL: https://github.com/apache/incubator-pinot/issues/4248#issuecomment-496734814 @jamesyfshao If you are using FASTHLL, please check out the documentation change in #4251 as we are moving

[GitHub] [incubator-pinot] fx19880617 commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy

2019-05-28 Thread GitBox
fx19880617 commented on issue #4248: Alternative HyperLogLog implementation with higher accuracy URL: https://github.com/apache/incubator-pinot/issues/4248#issuecomment-496734462 @jamesyfshao just fyi, I think mobile analytics is using fasthll right now

[GitHub] [incubator-pinot] codecov-io commented on issue #4252: pinot_kafka_0.9.0.1 module

2019-05-28 Thread GitBox
codecov-io commented on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-496732583 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4252?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4047: Create leadControllerResource in helix cluster

2019-05-28 Thread GitBox
codecov-io edited a comment on issue #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#issuecomment-479147030 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4047?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
codecov-io edited a comment on issue #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#issuecomment-496646145 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4235?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] npawar opened a new pull request #4252: Kafka 0 9 0 1 module

2019-05-28 Thread GitBox
npawar opened a new pull request #4252: Kafka 0 9 0 1 module URL: https://github.com/apache/incubator-pinot/pull/4252 Step 3 of https://github.com/apache/incubator-pinot/issues/3998 As discussed in the issue, we are planning to move out kafka stream implementation related classes into

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
codecov-io edited a comment on issue #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#issuecomment-496646145 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4235?src=pr=h1) Report > :exclamation: No

[GitHub] [incubator-pinot] codecov-io commented on issue #4251: Update the documentation for FASTHLL

2019-05-28 Thread GitBox
codecov-io commented on issue #4251: Update the documentation for FASTHLL URL: https://github.com/apache/incubator-pinot/pull/4251#issuecomment-496721397 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4251?src=pr=h1) Report > Merging

[incubator-pinot] 01/01: Release branch only:Upgrade helix to 0.8.4 for release

2019-05-28 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch helix_084_release_branch in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 1ebcfd99fedad43c655462433cda31aec1bfac04 Author: Neha Pawar AuthorDate: Tue May 28

[incubator-pinot] branch helix_084_release_branch created (now 1ebcfd9)

2019-05-28 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a change to branch helix_084_release_branch in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 1ebcfd9 Release branch only:Upgrade helix to 0.8.4 for release This branch includes

[incubator-pinot] branch create-lead-controller-resource updated (668f727 -> 02cd55b)

2019-05-28 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch create-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 668f727 Create leadControllerResource in Helix cluster add 02cd55b Create

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

2019-05-28 Thread GitBox
codecov-io edited a comment on issue #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager URL: https://github.com/apache/incubator-pinot/pull/4245#issuecomment-49942 #

[incubator-pinot] branch master updated: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager (#4245)

2019-05-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 106c5a0 Make

[incubator-pinot] branch leader_callback deleted (was eb861e0)

2019-05-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch leader_callback in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was eb861e0 Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

2019-05-28 Thread GitBox
Jackie-Jiang merged pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager URL: https://github.com/apache/incubator-pinot/pull/4245 This is an automated message from the

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
jackjlli commented on a change in pull request #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#discussion_r288329485 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
jackjlli commented on a change in pull request #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#discussion_r288329472 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
jackjlli commented on a change in pull request #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#discussion_r288329447 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
jackjlli commented on a change in pull request #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#discussion_r288329418 ## File path:

[incubator-pinot] branch fasthll_doc created (now f51b5d8)

2019-05-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch fasthll_doc in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at f51b5d8 Update the documentation for FASTHLL This branch includes the following new commits:

[incubator-pinot] 01/01: Update the documentation for FASTHLL

2019-05-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch fasthll_doc in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit f51b5d89ca30d2219fd36289ada312bbb3401801 Author: Jackie (Xiaotian) Jiang AuthorDate: Tue May 28 15:26:22

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4251: Update the documentation for FASTHLL

2019-05-28 Thread GitBox
Jackie-Jiang opened a new pull request #4251: Update the documentation for FASTHLL URL: https://github.com/apache/incubator-pinot/pull/4251 For serialized HyperLogLog, FASTHLL performs worse than DISTINCTCOUNTHLL, which is counter-intuitive. Update the documentation for that, and will

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4250: SoC - Separate out Tuning from Translator

2019-05-28 Thread GitBox
akshayrai opened a new pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250 Currently tuning is tied together with the translator. Each time we need to tune the detection, we have to call the translator which tries to

[GitHub] [incubator-pinot] kishoreg commented on issue #4243: Add support for passing headers in pinot client

2019-05-28 Thread GitBox
kishoreg commented on issue #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#issuecomment-496711434 Thanks @jitendratheta for the explanation. It looks good to me overall. Have a few more questions before I sign off to make

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

2019-05-28 Thread GitBox
Jackie-Jiang commented on a change in pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager URL: https://github.com/apache/incubator-pinot/pull/4245#discussion_r288323758 ## File path:

[incubator-pinot] branch leader_callback updated (2398fbe -> eb861e0)

2019-05-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch leader_callback in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 2398fbe Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

2019-05-28 Thread GitBox
Jackie-Jiang commented on a change in pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager URL: https://github.com/apache/incubator-pinot/pull/4245#discussion_r288322881 ## File path:

[incubator-pinot] branch master updated: [TE] make holter winters rule to return the current timeseries (#4249)

2019-05-28 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 1ca1436 [TE] make holter winters rule

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4249: [TE] make holter winters rule to return the current timeseries

2019-05-28 Thread GitBox
xiaohui-sun merged pull request #4249: [TE] make holter winters rule to return the current timeseries URL: https://github.com/apache/incubator-pinot/pull/4249 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] xiaohui-sun commented on issue #4249: [TE] make holter winters rule to return the current timeseries

2019-05-28 Thread GitBox
xiaohui-sun commented on issue #4249: [TE] make holter winters rule to return the current timeseries URL: https://github.com/apache/incubator-pinot/pull/4249#issuecomment-496708820 LTGM This is an automated message from the

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4247: [TE] Destroy PhantomJS process after 3 minutes timeout

2019-05-28 Thread GitBox
xiaohui-sun merged pull request #4247: [TE] Destroy PhantomJS process after 3 minutes timeout URL: https://github.com/apache/incubator-pinot/pull/4247 This is an automated message from the Apache Git Service. To respond to

[incubator-pinot] branch master updated: [TE] Destroy PhantomJS process after 3 minutes timeout (#4247)

2019-05-28 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new a22bf9c [TE] Destroy PhantomJS process

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
mcvsubbu commented on a change in pull request #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#discussion_r288316724 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
mcvsubbu commented on a change in pull request #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#discussion_r288315963 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
mcvsubbu commented on a change in pull request #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#discussion_r288315265 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
mcvsubbu commented on a change in pull request #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#discussion_r288313295 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4047: Create leadControllerResource in helix cluster

2019-05-28 Thread GitBox
codecov-io edited a comment on issue #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#issuecomment-479147030 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4047?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4243: Add support for passing headers in pinot client

2019-05-28 Thread GitBox
mcvsubbu commented on issue #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#issuecomment-496697329 @kishoreg if you are ok with this, please go ahead and approve it, thanks.

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

2019-05-28 Thread GitBox
jackjlli commented on a change in pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager URL: https://github.com/apache/incubator-pinot/pull/4245#discussion_r288307838 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

2019-05-28 Thread GitBox
jackjlli commented on a change in pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager URL: https://github.com/apache/incubator-pinot/pull/4245#discussion_r288308343 ## File path:

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4249: [TE] make holter winters rule to return the current timeseries

2019-05-28 Thread GitBox
jihaozh opened a new pull request #4249: [TE] make holter winters rule to return the current timeseries URL: https://github.com/apache/incubator-pinot/pull/4249 make holter winters rule to return the current time series so that in the preview UI it can show the current time series.

[incubator-pinot] branch create-lead-controller-resource updated (c12ff31 -> 668f727)

2019-05-28 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch create-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit c12ff31 Create leadControllerResource in Helix cluster add 668f727 Create

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
codecov-io edited a comment on issue #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-495985716 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3723?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jihaozh merged pull request #4237: [TE] frontend - harleyjj/edit-alert - use new yaml components in edit…

2019-05-28 Thread GitBox
jihaozh merged pull request #4237: [TE] frontend - harleyjj/edit-alert - use new yaml components in edit… URL: https://github.com/apache/incubator-pinot/pull/4237 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch master updated: [TE] frontend - harleyjj/edit-alert - use new yaml components in edit-alert (#4237)

2019-05-28 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 447f7fc [TE] frontend -

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4047: Create leadControllerResource in helix cluster

2019-05-28 Thread GitBox
codecov-io edited a comment on issue #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#issuecomment-479147030 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4047?src=pr=h1) Report > Merging

[incubator-pinot] branch cleanup-autogen-files updated (bbd9208 -> 3522e64)

2019-05-28 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch cleanup-autogen-files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit bbd9208 Address comments. Make default no profile for building thrift add 3522e64

[GitHub] [incubator-pinot] fx19880617 commented on issue #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
fx19880617 commented on issue #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-496670577 Updated pom file to let thrift generate java code during maven compile time all the time.

[incubator-pinot] branch create-lead-controller-resource updated (871fb40 -> c12ff31)

2019-05-28 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch create-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 871fb40 Create leadControllerResource in Helix cluster add cb7dab4 add more

[GitHub] [incubator-pinot] codecov-io commented on issue #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

2019-05-28 Thread GitBox
codecov-io commented on issue #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager URL: https://github.com/apache/incubator-pinot/pull/4245#issuecomment-49942 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4245?src=pr=h1)

[GitHub] [incubator-pinot] Jackie-Jiang opened a new issue #4248: Alternative HyperLogLog implementation with higher accuracy

2019-05-28 Thread GitBox
Jackie-Jiang opened a new issue #4248: Alternative HyperLogLog implementation with higher accuracy URL: https://github.com/apache/incubator-pinot/issues/4248 Current HyperLogLog implementation is fairly old:

[GitHub] [incubator-pinot] walterddr commented on issue #4219: Support SQL in Pinot.

2019-05-28 Thread GitBox
walterddr commented on issue #4219: Support SQL in Pinot. URL: https://github.com/apache/incubator-pinot/issues/4219#issuecomment-496665580 Thanks @kishoreg, I am not familiar with the usage of per-segment data stats in Calcite and not sure if that can be easily supported. Thank you

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4243: Add support for passing headers in pinot client

2019-05-28 Thread GitBox
codecov-io edited a comment on issue #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#issuecomment-496501504 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4243?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
codecov-io edited a comment on issue #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-495985716 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3723?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jitendratheta edited a comment on issue #4243: Add support for passing headers in pinot client

2019-05-28 Thread GitBox
jitendratheta edited a comment on issue #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#issuecomment-496656697 > Since this is not common to pass additional headers from the client, keep the existing methods and just add the

[GitHub] [incubator-pinot] jitendratheta commented on issue #4243: Add support for passing headers in pinot client

2019-05-28 Thread GitBox
jitendratheta commented on issue #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#issuecomment-496656697 > Since this is not common to pass additional headers from the client, keep the existing methods and just add the new

[GitHub] [incubator-pinot] jitendratheta commented on a change in pull request #4243: Add support for passing headers in pinot client

2019-05-28 Thread GitBox
jitendratheta commented on a change in pull request #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288264618 ## File path:

[incubator-pinot] branch leader_callback updated (78b8719 -> 2398fbe)

2019-05-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch leader_callback in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 78b8719 Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

[GitHub] [incubator-pinot] jitendratheta commented on a change in pull request #4243: Add support for passing headers in pinot client

2019-05-28 Thread GitBox
jitendratheta commented on a change in pull request #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288264306 ## File path: pinot-api/src/test/java/org/apache/pinot/client/PreparedStatementTest.java

[incubator-pinot] branch cleanup-autogen-files updated (5d8354f -> bbd9208)

2019-05-28 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch cleanup-autogen-files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 5d8354f Address comments. Make default no profile for building thrift add bbd9208

[incubator-pinot] branch cleanup-autogen-files updated (7b18740 -> 5d8354f)

2019-05-28 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch cleanup-autogen-files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 7b18740 Fixing compatibility issue with thrift v0.12.0 add 5d8354f Address comments.

[GitHub] [incubator-pinot] codecov-io commented on issue #4235: Add config to disable HLC realtime segment completion

2019-05-28 Thread GitBox
codecov-io commented on issue #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235#issuecomment-496646145 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4235?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] fx19880617 edited a comment on issue #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
fx19880617 edited a comment on issue #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-496643715 `mvn clean` will remove the generated java files, which means that it won't compile with `mvn clean install`. One

[GitHub] [incubator-pinot] fx19880617 commented on issue #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
fx19880617 commented on issue #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-496643715 `mvn clean` will remove the generated java files, which means that it won't compile with `mvn clean install`. One option is

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4240: Skip pipeline validation when disabling it

2019-05-28 Thread GitBox
xiaohui-sun merged pull request #4240: Skip pipeline validation when disabling it URL: https://github.com/apache/incubator-pinot/pull/4240 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-pinot] branch master updated: Skip pipeline validation when disabling it (#4240)

2019-05-28 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 4694f67 Skip pipeline validation when

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4247: [TE] Destroy PhantomJS process after 3 minutes timeout

2019-05-28 Thread GitBox
xiaohui-sun opened a new pull request #4247: [TE] Destroy PhantomJS process after 3 minutes timeout URL: https://github.com/apache/incubator-pinot/pull/4247 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

2019-05-28 Thread GitBox
mayankshriv commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r288246450 ## File path:

[GitHub] [incubator-pinot] codecov-io commented on issue #4244: Add support for custom record-readers in the create-segment tool

2019-05-28 Thread GitBox
codecov-io commented on issue #4244: Add support for custom record-readers in the create-segment tool URL: https://github.com/apache/incubator-pinot/pull/4244#issuecomment-496634004 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4244?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] snleee commented on issue #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
snleee commented on issue #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-496632786 @fx19880617 Does `mvn clean` removes java files that are created and copied? Also, please wait until we make sure that

[GitHub] [incubator-pinot] cyenjung commented on a change in pull request #4213: [TE] Refactor cube algorithm for adding ratio cube in the future.

2019-05-28 Thread GitBox
cyenjung commented on a change in pull request #4213: [TE] Refactor cube algorithm for adding ratio cube in the future. URL: https://github.com/apache/incubator-pinot/pull/4213#discussion_r288235556 ## File path:

[GitHub] [incubator-pinot] cyenjung commented on a change in pull request #4213: [TE] Refactor cube algorithm for adding ratio cube in the future.

2019-05-28 Thread GitBox
cyenjung commented on a change in pull request #4213: [TE] Refactor cube algorithm for adding ratio cube in the future. URL: https://github.com/apache/incubator-pinot/pull/4213#discussion_r288235595 ## File path:

[GitHub] [incubator-pinot] cyenjung commented on a change in pull request #4213: [TE] Refactor cube algorithm for adding ratio cube in the future.

2019-05-28 Thread GitBox
cyenjung commented on a change in pull request #4213: [TE] Refactor cube algorithm for adding ratio cube in the future. URL: https://github.com/apache/incubator-pinot/pull/4213#discussion_r288235645 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
Jackie-Jiang commented on a change in pull request #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#discussion_r288234241 ## File path: .travis.yml ## @@ -20,6 +20,13 @@ cache: addons: firefox: latest

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
Jackie-Jiang commented on a change in pull request #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#discussion_r288234574 ## File path: .travis_test.sh ## @@ -58,12 +58,12 @@ fi passed=0 # Only run

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
Jackie-Jiang commented on a change in pull request #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#discussion_r288234624 ## File path: .travis_test.sh ## @@ -58,12 +58,12 @@ fi passed=0 # Only run

[GitHub] [incubator-pinot] snleee commented on a change in pull request #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
snleee commented on a change in pull request #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#discussion_r288233977 ## File path: .travis.yml ## @@ -20,6 +20,13 @@ cache: addons: firefox: latest

[GitHub] [incubator-pinot] cyenjung opened a new pull request #4246: [TE] Cube algorithm for ratio metrics

2019-05-28 Thread GitBox
cyenjung opened a new pull request #4246: [TE] Cube algorithm for ratio metrics URL: https://github.com/apache/incubator-pinot/pull/4246 __Changes__ 1. Implement ratio cube related classes. 2. Add new unit tests for ratio cube. __Tests__ 1. Passed the existing and new unit

[incubator-pinot] branch leader_callback updated (2568a63 -> 78b8719)

2019-05-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch leader_callback in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 2568a63 Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

[incubator-pinot] branch leader_callback created (now 2568a63)

2019-05-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch leader_callback in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 2568a63 Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

2019-05-28 Thread GitBox
Jackie-Jiang opened a new pull request #4245: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager URL: https://github.com/apache/incubator-pinot/pull/4245 ControllerLeadershipManager should be registered to PARTICIPANT HelixManager instead of

[incubator-pinot] 01/01: Make ControllerLeadershipManager thread-safe and register it to PARTICIPANT HelixManager

2019-05-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch leader_callback in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 2568a63818f0dde543b979223ad453d8ca559251 Author: Jackie (Xiaotian) Jiang AuthorDate: Tue May 28

[GitHub] [incubator-pinot] fx19880617 commented on issue #3723: Remove auto-gen class files that were checked-in

2019-05-28 Thread GitBox
fx19880617 commented on issue #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-496622057 Upgraded libthrift to 0.12.0 so we could compile the java code generated by thrift 0.12.0. Tested backward-compatibility

[incubator-pinot] branch createSegments updated (ee551e2 -> 27545ba)

2019-05-28 Thread sunithabeeram
This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a change to branch createSegments in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard ee551e2 Add support for custom record-readers in the create-segment tool add 27545ba

  1   2   >