Jackie-Jiang commented on issue #6093:
URL:
https://github.com/apache/incubator-pinot/issues/6093#issuecomment-703984609
Enhance star-tree to skip matching-all predicate on non-star-tree dimension:
#6109
This is an
Jackie-Jiang opened a new pull request #6109:
URL: https://github.com/apache/incubator-pinot/pull/6109
## Description
For #6093
Currently in order to use the star-tree index, all the predicates must be
applied to the star-tree dimensions. This could limit the usage of star-tree
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch enhance_star_tree
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 6519f22 Enhance star-tree to skip matching-all predicate on
non-star-tree dimension
This
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch enhance_star_tree
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 6519f22df04d8174715530f16c101ae86841024b
Author: Xiaotian (Jackie) Jiang
AuthorDate: Mon Oct 5
Jackie-Jiang closed issue #6092:
URL: https://github.com/apache/incubator-pinot/issues/6092
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from be99d78 Add the primary key reading from the GenericRow (#6102)
add b658925 Allow modifying/removing
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 24147dd [Issue 6068] Fixing the calls to Helix to throw exception if
zk conne… (#6069)
add be99d78
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 24147dd [Issue 6068] Fixing the calls to Helix to throw exception if
zk conne… (#6069)
add be99d78
Jackie-Jiang merged pull request #6100:
URL: https://github.com/apache/incubator-pinot/pull/6100
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Jackie-Jiang removed a comment on pull request #6100:
URL: https://github.com/apache/incubator-pinot/pull/6100#issuecomment-703974794
For #6092
Currently we allow generating new star-trees during the segment reload when
there is no existing ones.
This PR adds the support of
Jackie-Jiang commented on pull request #6100:
URL: https://github.com/apache/incubator-pinot/pull/6100#issuecomment-703974794
For #6092
Currently we allow generating new star-trees during the segment reload when
there is no existing ones.
This PR adds the support of modifying or
Jackie-Jiang merged pull request #6102:
URL: https://github.com/apache/incubator-pinot/pull/6102
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
yupeng9 commented on pull request #6102:
URL: https://github.com/apache/incubator-pinot/pull/6102#issuecomment-703956599
@Jackie-Jiang done. Thanks for taking another look
This is an automated message from the Apache Git
mcvsubbu merged pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 24147dd [Issue 6068] Fixing the
Jackie-Jiang commented on a change in pull request #6102:
URL: https://github.com/apache/incubator-pinot/pull/6102#discussion_r499935781
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##
@@ -123,6 +124,15 @@ public void putValue(String
Jackie-Jiang commented on pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#issuecomment-703951253
@mcvsubbu The unexpected behavior I was referring to is that we explicitly
set retry in the method, but Helix won't do the retry, and won't throw
exception when
adriancole commented on a change in pull request #6039:
URL: https://github.com/apache/incubator-pinot/pull/6039#discussion_r499930870
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##
@@ -350,6 +350,8 @@ private void
adriancole commented on a change in pull request #6039:
URL: https://github.com/apache/incubator-pinot/pull/6039#discussion_r499929548
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/services/ServiceRole.java
##
@@ -22,5 +22,5 @@
* ServiceRole defines a role that
adriancole commented on a change in pull request #6039:
URL: https://github.com/apache/incubator-pinot/pull/6039#discussion_r499929479
##
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/service/PinotServiceManager.java
##
@@ -92,6 +92,8 @@ public String
Jackie-Jiang merged pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 11ff74a Making pushType non-mandatory
yupeng9 commented on pull request #6102:
URL: https://github.com/apache/incubator-pinot/pull/6102#issuecomment-703942976
@Jackie-Jiang thanks for the review. Comments addressed.
This is an automated message from the Apache
icefury71 commented on pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703941715
Removed the default value based on this conversation. We're now back to the
old behaviour where push type is not mandatory and no default value assigned.
yupeng9 commented on a change in pull request #6102:
URL: https://github.com/apache/incubator-pinot/pull/6102#discussion_r499923780
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/PrimaryKey.java
##
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache
jackjlli commented on pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703938464
@icefury71 The 4th item I pasted above is the one we should be cautious
about:
mcvsubbu commented on pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#issuecomment-703938266
> @mcvsubbu We want both `getChildNames()` and `getChildren()` to have the
same behavior, and should throw exception on failures. Since Helix does not
have the correct
mcvsubbu commented on pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703937589
ah ok, I was thinking push-frequency
This is an automated message from the Apache Git Service.
To
icefury71 commented on pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703935277
> @mcvsubbu @jackjlli @snleee The mandatory check is just introduced in
#6073, and might break the existing use cases without the push type configured
(correct me if
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 93238c9 add upsert related configs (#6096)
add 2afea5c Fix missing segment count reporting for
fx19880617 merged pull request #6103:
URL: https://github.com/apache/incubator-pinot/pull/6103
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Jackie-Jiang commented on pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703932617
@mcvsubbu @jackjlli @snleee The mandatory check is just introduced in #6073,
and might break the existing use cases without the push type configured
(correct me if
Jackie-Jiang commented on pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#issuecomment-703929767
@mcvsubbu We want both `getChildNames()` and `getChildren()` to have the
same behavior, and should throw exception on failures. Since Helix does not
have the
Jackie-Jiang commented on a change in pull request #6105:
URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r499909017
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionUtils.java
##
@@ -56,6 +61,12 @@ private FunctionUtils()
snleee commented on pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703925780
If we want to remove the mandatory check, we should adjust codes to align
all the usage with falling back to the default behavior. We can make `APPEND`
as the default
Jackie-Jiang commented on a change in pull request #6046:
URL: https://github.com/apache/incubator-pinot/pull/6046#discussion_r499902967
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/BaseRecordExtractor.java
##
@@ -0,0 +1,174 @@
+/**
+ * Licensed to
suvodeep-pyne commented on pull request #6108:
URL: https://github.com/apache/incubator-pinot/pull/6108#issuecomment-703922813
Yes. That is correct. This streamlines access to the datalayer classes which
is currently behind a static interface wall.
jackjlli commented on pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703921970
The config `segmentPushType` is needed at least in the following scenarios:
1. Retention manager needs it to purge segments:
Jackie-Jiang commented on a change in pull request #6102:
URL: https://github.com/apache/incubator-pinot/pull/6102#discussion_r499901568
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/PrimaryKey.java
##
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache
mcvsubbu commented on a change in pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#discussion_r499900482
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java
##
@@ -305,7 +308,7 @@ public static Schema
yupeng9 commented on issue #5942:
URL:
https://github.com/apache/incubator-pinot/issues/5942#issuecomment-703891914
+1
Another use case is the upcoming upsert. There are several expectations for
upsert table like primary key in schema, replica group setup, routing by
replicas
suvodeep-pyne opened a new pull request #6108:
URL: https://github.com/apache/incubator-pinot/pull/6108
Changes
- Moved DataSourceModule outside to ThirdEyePersistenceModule
- Refactored module logic to leverage Guice to inject dependencies
- Making all services singletons on Guice
npawar commented on pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703889578
Along with this, I think we also need to make APPEND the default? I remember
there were some retention related issues.
From retention manager
```
String
icefury71 opened a new pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107
## Description
As part of #5942 pushType was made mandatory for offline tables my mistake.
Removing this mandate.
## Upgrade Notes
Does this PR prevent a zero down-time
npawar commented on a change in pull request #6105:
URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r499821865
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java
##
@@ -0,0 +1,133 @@
+/**
+ * Licensed to
Jackie-Jiang commented on a change in pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#discussion_r499809705
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java
##
@@ -305,7 +308,7 @@ public static
Jackie-Jiang commented on a change in pull request #6103:
URL: https://github.com/apache/incubator-pinot/pull/6103#discussion_r499804758
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##
@@ -269,6 +270,7 @@
deemoliu opened a new issue #6106:
URL: https://github.com/apache/incubator-pinot/issues/6106
When construct a Pinot schema using
[schemaBuilder](https://github.com/apache/incubator-pinot/blob/master/pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java#L474),
the maxLength of
fx19880617 commented on a change in pull request #6103:
URL: https://github.com/apache/incubator-pinot/pull/6103#discussion_r499786861
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##
@@ -269,6 +270,7 @@
Jackie-Jiang commented on a change in pull request #6103:
URL: https://github.com/apache/incubator-pinot/pull/6103#discussion_r499783811
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##
@@ -269,6 +270,7 @@
mcvsubbu commented on a change in pull request #6039:
URL: https://github.com/apache/incubator-pinot/pull/6039#discussion_r499763424
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##
@@ -350,6 +350,8 @@ private void
Jackie-Jiang merged pull request #6096:
URL: https://github.com/apache/incubator-pinot/pull/6096
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from e4d7a10 Add a property to set the s3 endpoint (#6104)
add 93238c9 add upsert related configs (#6096)
mayankshriv commented on pull request #6039:
URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-703762755
I put some more thought on this, and still unable to convince myself about
ServiceManager controlling when the service should announce health status
(especially
KKcorps commented on a change in pull request #6105:
URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r499737262
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java
##
@@ -0,0 +1,133 @@
+/**
+ * Licensed to
KKcorps commented on a change in pull request #6105:
URL: https://github.com/apache/incubator-pinot/pull/6105#discussion_r499735864
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionUtils.java
##
@@ -42,6 +42,11 @@ private FunctionUtils() {
KKcorps commented on pull request #6105:
URL: https://github.com/apache/incubator-pinot/pull/6105#issuecomment-703750862
@SandishKumarHN Can you also add some tests for these functions along with
an example in the description?
codecov-commenter commented on pull request #6105:
URL: https://github.com/apache/incubator-pinot/pull/6105#issuecomment-703732970
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6105?src=pr=h1)
Report
> Merging
mcvsubbu commented on pull request #6020:
URL: https://github.com/apache/incubator-pinot/pull/6020#issuecomment-703717382
> @mcvsubbu The issue is the changes are needed for new /Brokers api.
> The plan is to call the API to fetch the brokers for a tenant from JDBC
driver. The current
mcvsubbu commented on pull request #6020:
URL: https://github.com/apache/incubator-pinot/pull/6020#issuecomment-703716431
> @mcvsubbu I don't think this change will add more watchers though. These
watchers are always set by Helix, and we are just registering some extra
callbacks to Helix
SandishKumarHN opened a new pull request #6105:
URL: https://github.com/apache/incubator-pinot/pull/6105
Inbuilt functions - Scalar funtions for array columns
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 1126cac [TE] move dashboard resources for refactoring (#6058)
add e4d7a10 Add a property to set the
fx19880617 merged pull request #6104:
URL: https://github.com/apache/incubator-pinot/pull/6104
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
fx19880617 commented on a change in pull request #6104:
URL: https://github.com/apache/incubator-pinot/pull/6104#discussion_r499382289
##
File path:
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java
##
@@ -93,7 +95,16 @@
64 matches
Mail list logo
