[GitHub] massakam commented on issue #3092: Fix process of calculating msgBacklog included in stats

2018-11-28 Thread GitBox
massakam commented on issue #3092: Fix process of calculating msgBacklog included in stats URL: https://github.com/apache/pulsar/pull/3092#issuecomment-442735667 rerun cpp tests This is an automated message from the Apache Gi

[GitHub] massakam opened a new pull request #3092: Fix process of calculating msgBacklog included in stats

2018-11-28 Thread GitBox
massakam opened a new pull request #3092: Fix process of calculating msgBacklog included in stats URL: https://github.com/apache/pulsar/pull/3092 `msgBacklog` included in the stats of the topic sometimes remains 1 even though all messages have been consumed. Normally, the number of

[GitHub] merlimat closed pull request #3084: Fixed C++ CMake dependency and enabled parallel build

2018-11-28 Thread GitBox
merlimat closed pull request #3084: Fixed C++ CMake dependency and enabled parallel build URL: https://github.com/apache/pulsar/pull/3084 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[pulsar] branch master updated: Fixed C++ CMake dependency and enabled parallel build (#3084)

2018-11-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d18c07b Fixed C++ CMake dependency and enabled

[GitHub] sijie closed pull request #3091: Add pulsar-build:manylinux-cp37-cp37m to pushed docker images

2018-11-28 Thread GitBox
sijie closed pull request #3091: Add pulsar-build:manylinux-cp37-cp37m to pushed docker images URL: https://github.com/apache/pulsar/pull/3091 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[pulsar] branch master updated: Add pulsar-build:manylinux-cp37-cp37m to pushed docker images (#3091)

2018-11-28 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9195d07 Add pulsar-build:manylinux-cp37-cp37m to

[GitHub] sijie closed pull request #3085: Removed AspectJ build plugin from pulsar-broker

2018-11-28 Thread GitBox
sijie closed pull request #3085: Removed AspectJ build plugin from pulsar-broker URL: https://github.com/apache/pulsar/pull/3085 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[pulsar] branch master updated: Removed AspectJ build plugin from pulsar-broker (#3085)

2018-11-28 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a2fd124 Removed AspectJ build plugin from pulsar

[GitHub] sijie closed pull request #3089: PIP-25: Added token authentication docs

2018-11-28 Thread GitBox
sijie closed pull request #3089: PIP-25: Added token authentication docs URL: https://github.com/apache/pulsar/pull/3089 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull re

[pulsar] branch master updated: PIP-25: Added token authentication docs (#3089)

2018-11-28 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f9ea60e PIP-25: Added token authentication docs

[GitHub] merlimat closed pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat closed pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[pulsar] branch master updated: PIP-25: C++ / Python / Go implementation for token authentication (#3067)

2018-11-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 019ae66 PIP-25: C++ / Python / Go implementatio

[GitHub] massakam commented on issue #3091: Add pulsar-build:manylinux-cp37-cp37m to pushed docker images

2018-11-28 Thread GitBox
massakam commented on issue #3091: Add pulsar-build:manylinux-cp37-cp37m to pushed docker images URL: https://github.com/apache/pulsar/pull/3091#issuecomment-442697441 rerun cpp tests This is an automated message from the Apa

[GitHub] jerrypeng commented on issue #3088: Improve and correct status for function, sources, sinks

2018-11-28 Thread GitBox
jerrypeng commented on issue #3088: Improve and correct status for function, sources, sinks URL: https://github.com/apache/pulsar/pull/3088#issuecomment-442685798 Not sure why github isn't showing renaming (and few changes) of FunctionsImpl -> FunctionsImplBase as a simple diff. Perhaps t

[GitHub] jerrypeng commented on a change in pull request #3088: Improve and correct status for function, sources, sinks

2018-11-28 Thread GitBox
jerrypeng commented on a change in pull request #3088: Improve and correct status for function, sources, sinks URL: https://github.com/apache/pulsar/pull/3088#discussion_r237335424 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java ###

[GitHub] srkukarni commented on a change in pull request #3088: Improve and correct status for function, sources, sinks

2018-11-28 Thread GitBox
srkukarni commented on a change in pull request #3088: Improve and correct status for function, sources, sinks URL: https://github.com/apache/pulsar/pull/3088#discussion_r237333916 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java ###

[GitHub] codelipenghui commented on issue #3077: The client has not received the message yet but message already send to the dead letter topic.

2018-11-28 Thread GitBox
codelipenghui commented on issue #3077: The client has not received the message yet but message already send to the dead letter topic. URL: https://github.com/apache/pulsar/issues/3077#issuecomment-442680031 PR #3079 for fix this issue --

[GitHub] massakam opened a new pull request #3091: Add pulsar-build:manylinux-cp37-cp37m to pushed docker images

2018-11-28 Thread GitBox
massakam opened a new pull request #3091: Add pulsar-build:manylinux-cp37-cp37m to pushed docker images URL: https://github.com/apache/pulsar/pull/3091 When we run `pulsar-client-cpp/docker/create-images.sh`, the following six docker images are created. ``` pulsar-build:manylinux-cp2

[GitHub] sijie commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report

2018-11-28 Thread GitBox
sijie commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report URL: https://github.com/apache/pulsar/issues/3083#issuecomment-442668962 @merlimat : so fix NoopLoadManager? This is an aut

[GitHub] drdrill edited a comment on issue #3068: Maven Build Error 2.2.0

2018-11-28 Thread GitBox
drdrill edited a comment on issue #3068: Maven Build Error 2.2.0 URL: https://github.com/apache/pulsar/issues/3068#issuecomment-442668479 Yes. My only point, stated indirectly, was to suggest removing the references in the Apache-Pulsar pom.xml to bintray to eliminated any ambiguity or

[GitHub] drdrill commented on issue #3068: Maven Build Error 2.2.0

2018-11-28 Thread GitBox
drdrill commented on issue #3068: Maven Build Error 2.2.0 URL: https://github.com/apache/pulsar/issues/3068#issuecomment-442668479 Yes. My only point, stated indirectly, was to suggest removing the references in the Apache-Pulsar pom.xml to bintray to eliminated any ambiguity or unnece

[GitHub] codelipenghui commented on issue #3042: Get stats on a exist topic but got topic not found error

2018-11-28 Thread GitBox
codelipenghui commented on issue #3042: Get stats on a exist topic but got topic not found error URL: https://github.com/apache/pulsar/issues/3042#issuecomment-442665036 @sijie I will fix it later This is an automated message

[GitHub] merlimat commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report

2018-11-28 Thread GitBox
merlimat commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report URL: https://github.com/apache/pulsar/issues/3083#issuecomment-442663229 The ModularLoadManager has a lot of features that are unnecessary in standalone mode. In fact, with standalone,

[GitHub] rdhabalia edited a comment on issue #3083: Emhancement | NoopLoadManager could have more details for load report

2018-11-28 Thread GitBox
rdhabalia edited a comment on issue #3083: Emhancement | NoopLoadManager could have more details for load report URL: https://github.com/apache/pulsar/issues/3083#issuecomment-442661845 if we not going to use `NoOpLoadManager` then probably we can revert back #2487 ? -

[GitHub] rdhabalia commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report

2018-11-28 Thread GitBox
rdhabalia commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report URL: https://github.com/apache/pulsar/issues/3083#issuecomment-442661845 if we not going to use `NoOpLoadManager` then probably we can revert back #2487 --

[GitHub] cckellogg commented on issue #3090: kubernetes create function silently fails when broker/worker does not have the right permissions

2018-11-28 Thread GitBox
cckellogg commented on issue #3090: kubernetes create function silently fails when broker/worker does not have the right permissions URL: https://github.com/apache/pulsar/issues/3090#issuecomment-442656790 stack trace: 23:51:57.621 [FunctionActionerThread] INFO org.apache.pulsar.functi

[GitHub] cckellogg opened a new issue #3090: kubernetes create function silently fails when broker/worker does not have the right permissions

2018-11-28 Thread GitBox
cckellogg opened a new issue #3090: kubernetes create function silently fails when broker/worker does not have the right permissions URL: https://github.com/apache/pulsar/issues/3090 Expected behavior When a function fails to create all resources in k8s the cli should return an

[GitHub] merlimat commented on issue #3038: Remove Log4J 1.x from the bin distribution

2018-11-28 Thread GitBox
merlimat commented on issue #3038: Remove Log4J 1.x from the bin distribution URL: https://github.com/apache/pulsar/pull/3038#issuecomment-442655049 run integration tests This is an automated message from the Apache Git Servic

[GitHub] merlimat opened a new pull request #3089: PIP-25: Added token authentication docs

2018-11-28 Thread GitBox
merlimat opened a new pull request #3089: PIP-25: Added token authentication docs URL: https://github.com/apache/pulsar/pull/3089 ### Motivation Added client and admin documentation token based authentication. This is

[GitHub] foreversunyao commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report

2018-11-28 Thread GitBox
foreversunyao commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report URL: https://github.com/apache/pulsar/issues/3083#issuecomment-442652729 @sijie @rdhabalia @merlimat Sure, I'll give it a shot. Firstly, I need the conclusion for the dir

[GitHub] merlimat commented on issue #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat commented on issue #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#issuecomment-442651918 run java8 tests run cpp tests This is an autom

[GitHub] jerrypeng opened a new pull request #3088: Improve and correct status for function, sources, sinks

2018-11-28 Thread GitBox
jerrypeng opened a new pull request #3088: Improve and correct status for function, sources, sinks URL: https://github.com/apache/pulsar/pull/3088 ### Modifications 1. Cleanup function status. Create own class instead of using protobuf 2. Create classes for source and sink status

[GitHub] rdhabalia commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report

2018-11-28 Thread GitBox
rdhabalia commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report URL: https://github.com/apache/pulsar/issues/3083#issuecomment-442638800 @merlimat in my opinion, I think we should not use separate `NoopLoadManager` for standalone broker but we shou

[GitHub] merlimat commented on issue #3084: Fixed C++ CMake dependency and enabled parallel build

2018-11-28 Thread GitBox
merlimat commented on issue #3084: Fixed C++ CMake dependency and enabled parallel build URL: https://github.com/apache/pulsar/pull/3084#issuecomment-442638689 run integration tests This is an automated message from t

[GitHub] ivankelly opened a new issue #3087: javadoc doesn't respect the docusaurus versioning

2018-11-28 Thread GitBox
ivankelly opened a new issue #3087: javadoc doesn't respect the docusaurus versioning URL: https://github.com/apache/pulsar/issues/3087 http://pulsar.apache.org/docs/en/client-libraries/ points to http://pulsar.apache.org/api/client http://pulsar.apache.org/docs/en/next/client-libraries

[GitHub] merlimat commented on issue #2910: Avoid double encoding for subscription name in pulsar-admin

2018-11-28 Thread GitBox
merlimat commented on issue #2910: Avoid double encoding for subscription name in pulsar-admin URL: https://github.com/apache/pulsar/pull/2910#issuecomment-442637019 @rdhabalia It looks there is a test failure at `AdminApiTest.persistentTopics` ``` 20:07:37.433 [pulsar-web-3570:o

[GitHub] merlimat closed pull request #3043: Set not just resource requests but also limits

2018-11-28 Thread GitBox
merlimat closed pull request #3043: Set not just resource requests but also limits URL: https://github.com/apache/pulsar/pull/3043 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[pulsar] branch master updated: Set not just resource requests but also limits (#3043)

2018-11-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5c2b13e Set not just resource requests but also

[pulsar] branch master updated: Issue #2582: Schema javadoc missing from client api docs (#3086)

2018-11-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5858df0 Issue #2582: Schema javadoc missing fro

[GitHub] merlimat closed issue #2582: Schema javadoc missing from client api docs

2018-11-28 Thread GitBox
merlimat closed issue #2582: Schema javadoc missing from client api docs URL: https://github.com/apache/pulsar/issues/2582 This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] merlimat closed pull request #3086: Issue #2582: Schema javadoc missing from client api docs

2018-11-28 Thread GitBox
merlimat closed pull request #3086: Issue #2582: Schema javadoc missing from client api docs URL: https://github.com/apache/pulsar/pull/3086 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] merlimat commented on issue #3085: Removed AspectJ build plugin from pulsar-broker

2018-11-28 Thread GitBox
merlimat commented on issue #3085: Removed AspectJ build plugin from pulsar-broker URL: https://github.com/apache/pulsar/pull/3085#issuecomment-442635872 run integration tests This is an automated message from the Apache Git

[GitHub] sijie closed issue #2394: NonPersistentTopicTest#testMsgDropStat

2018-11-28 Thread GitBox
sijie closed issue #2394: NonPersistentTopicTest#testMsgDropStat URL: https://github.com/apache/pulsar/issues/2394 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] sijie commented on issue #2394: NonPersistentTopicTest#testMsgDropStat

2018-11-28 Thread GitBox
sijie commented on issue #2394: NonPersistentTopicTest#testMsgDropStat URL: https://github.com/apache/pulsar/issues/2394#issuecomment-442633481 closed it as discussed. This is an automated message from the Apache Git Service.

[GitHub] cbornet edited a comment on issue #3059: Behavior of redelivery and ackTimeout in Java client

2018-11-28 Thread GitBox
cbornet edited a comment on issue #3059: Behavior of redelivery and ackTimeout in Java client URL: https://github.com/apache/pulsar/issues/3059#issuecomment-442631911 Was it really better before ? The message "0" is sent the first time at 34:26 and the second time at 34:35 where one would

[GitHub] cbornet commented on issue #3059: Behavior of redelivery and ackTimeout in Java client

2018-11-28 Thread GitBox
cbornet commented on issue #3059: Behavior of redelivery and ackTimeout in Java client URL: https://github.com/apache/pulsar/issues/3059#issuecomment-442631911 Was it really better before ? The message "0" is sent the first time at 34:26 and the second time at 34:35 where one would have ex

[GitHub] sijie closed issue #2751: null payload or property values generated NullPointerException in server

2018-11-28 Thread GitBox
sijie closed issue #2751: null payload or property values generated NullPointerException in server URL: https://github.com/apache/pulsar/issues/2751 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #2751: null payload or property values generated NullPointerException in server

2018-11-28 Thread GitBox
sijie commented on issue #2751: null payload or property values generated NullPointerException in server URL: https://github.com/apache/pulsar/issues/2751#issuecomment-442630802 This is fixed by #3034 This is an automated me

[GitHub] sijie commented on issue #2942: Intermittent test failure in TestS3Offload

2018-11-28 Thread GitBox
sijie commented on issue #2942: Intermittent test failure in TestS3Offload URL: https://github.com/apache/pulsar/issues/2942#issuecomment-442630269 @merlimat to read the whole thread This is an automated message from the Apach

[GitHub] sijie commented on issue #2957: Add Connect and Read timeout to pulsar admin

2018-11-28 Thread GitBox
sijie commented on issue #2957: Add Connect and Read timeout to pulsar admin URL: https://github.com/apache/pulsar/pull/2957#issuecomment-442629319 @aahmed-se to rebase the PR This is an automated message from the Apache Git S

[GitHub] rdhabalia commented on issue #2394: NonPersistentTopicTest#testMsgDropStat

2018-11-28 Thread GitBox
rdhabalia commented on issue #2394: NonPersistentTopicTest#testMsgDropStat URL: https://github.com/apache/pulsar/issues/2394#issuecomment-442620944 is it still happening, if not then we can close it for now? This is an automat

[GitHub] sijie commented on issue #342: Broker change dynamic configuration based on ZK latency to reduce zk-load

2018-11-28 Thread GitBox
sijie commented on issue #342: Broker change dynamic configuration based on ZK latency to reduce zk-load URL: https://github.com/apache/pulsar/issues/342#issuecomment-442620112 @rdhabalia are you guys actively working on this? ---

[GitHub] sijie commented on issue #346: Broker stop produces a consumer reset

2018-11-28 Thread GitBox
sijie commented on issue #346: Broker stop produces a consumer reset URL: https://github.com/apache/pulsar/issues/346#issuecomment-442619850 close it due to inactivities in this thread. feel free to reopen it if it reoccurs

[GitHub] sijie closed issue #382: Broker LoadFactor CPU NaN

2018-11-28 Thread GitBox
sijie closed issue #382: Broker LoadFactor CPU NaN URL: https://github.com/apache/pulsar/issues/382 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL abo

[GitHub] sijie commented on issue #382: Broker LoadFactor CPU NaN

2018-11-28 Thread GitBox
sijie commented on issue #382: Broker LoadFactor CPU NaN URL: https://github.com/apache/pulsar/issues/382#issuecomment-442619553 This is fixed by #2618 This is an automated message from the Apache Git Service. To respond to t

[GitHub] sijie commented on issue #386: Partitions in partitioned topic should be automatically distributed to multiple brokers

2018-11-28 Thread GitBox
sijie commented on issue #386: Partitions in partitioned topic should be automatically distributed to multiple brokers URL: https://github.com/apache/pulsar/issues/386#issuecomment-442619035 @merlimat is there any thing we need to do more in this task? -

[GitHub] sijie commented on issue #2394: NonPersistentTopicTest#testMsgDropStat

2018-11-28 Thread GitBox
sijie commented on issue #2394: NonPersistentTopicTest#testMsgDropStat URL: https://github.com/apache/pulsar/issues/2394#issuecomment-442618262 @rdhabalia any ideas about the fix here? This is an automated message from the Apa

[GitHub] sijie closed issue #2402: Document TLS version and ciphersuite configuration for server and proxy

2018-11-28 Thread GitBox
sijie closed issue #2402: Document TLS version and ciphersuite configuration for server and proxy URL: https://github.com/apache/pulsar/issues/2402 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #2402: Document TLS version and ciphersuite configuration for server and proxy

2018-11-28 Thread GitBox
sijie commented on issue #2402: Document TLS version and ciphersuite configuration for server and proxy URL: https://github.com/apache/pulsar/issues/2402#issuecomment-442618062 This issue was fixed by #3057 This is an automa

[GitHub] sijie commented on issue #2404: Document proxy auth data forwarding

2018-11-28 Thread GitBox
sijie commented on issue #2404: Document proxy auth data forwarding URL: https://github.com/apache/pulsar/issues/2404#issuecomment-442617947 @rdhabalia @merlimat @maskit since you guys might be more familiar with Athenz, I am wondering if anyone of you can help with task. or even commenting

[GitHub] sijie commented on issue #3042: Get stats on a exist topic but got topic not found error

2018-11-28 Thread GitBox
sijie commented on issue #3042: Get stats on a exist topic but got topic not found error URL: https://github.com/apache/pulsar/issues/3042#issuecomment-442616535 @codelipenghui it sounds like there is no stats available for that topic. so it might be a simple fix to return some empty stats

[GitHub] sijie commented on issue #3059: Behavior of redelivery and ackTimeout in Java client

2018-11-28 Thread GitBox
sijie commented on issue #3059: Behavior of redelivery and ackTimeout in Java client URL: https://github.com/apache/pulsar/issues/3059#issuecomment-442614802 @jiazhai can you take a look at this? as @codelipenghui pointed out, it seems to be a regression from #2590 --

[GitHub] sijie commented on issue #3068: Maven Build Error 2.2.0

2018-11-28 Thread GitBox
sijie commented on issue #3068: Maven Build Error 2.2.0 URL: https://github.com/apache/pulsar/issues/3068#issuecomment-442614528 @drdrill does matteo's comment make sense to you? This is an automated message from the Apache Gi

[GitHub] sijie commented on issue #3074: pulsar-client produce topic -f file in cluster error if you use relative path

2018-11-28 Thread GitBox
sijie commented on issue #3074: pulsar-client produce topic -f file in cluster error if you use relative path URL: https://github.com/apache/pulsar/issues/3074#issuecomment-442613806 @Hanqingkuo are you interested in contributing a bug fix for this?

[GitHub] sijie commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report

2018-11-28 Thread GitBox
sijie commented on issue #3083: Emhancement | NoopLoadManager could have more details for load report URL: https://github.com/apache/pulsar/issues/3083#issuecomment-442612675 @foreversunyao are you interested in contributing an improvement to this?

[GitHub] sijie closed pull request #3076: QueryState now spits out FunctionState

2018-11-28 Thread GitBox
sijie closed pull request #3076: QueryState now spits out FunctionState URL: https://github.com/apache/pulsar/pull/3076 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull req

[pulsar] branch master updated: QueryState now spits out FunctionState (#3076)

2018-11-28 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new aaf1996 QueryState now spits out FunctionState (

[GitHub] sijie opened a new pull request #3086: Issue #2582: Schema javadoc missing from client api docs

2018-11-28 Thread GitBox
sijie opened a new pull request #3086: Issue #2582: Schema javadoc missing from client api docs URL: https://github.com/apache/pulsar/pull/3086 *Motivation* Fixes #2582 Schema javadoc is missing from client api docs

[GitHub] merlimat commented on issue #3084: Fixed C++ CMake dependency and enabled parallel build

2018-11-28 Thread GitBox
merlimat commented on issue #3084: Fixed C++ CMake dependency and enabled parallel build URL: https://github.com/apache/pulsar/pull/3084#issuecomment-442597997 run cpp tests run integration tests This is an automated messa

[GitHub] merlimat closed pull request #2888: PIP-25: Token based authentication

2018-11-28 Thread GitBox
merlimat closed pull request #2888: PIP-25: Token based authentication URL: https://github.com/apache/pulsar/pull/2888 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull requ

[pulsar] branch master updated: PIP-25: Token based authentication (#2888)

2018-11-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a99f733 PIP-25: Token based authentication (#28

[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-11-28 Thread GitBox
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/pulsar/pull/2570#issuecomment-442595486 doesn't seem to be needed any more. This is an automated m

[GitHub] sijie closed pull request #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-11-28 Thread GitBox
sijie closed pull request #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/pulsar/pull/2570 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie closed issue #2081: Improve documentation about `--inputs` and `--customSerdeInputs` for pulsar functions

2018-11-28 Thread GitBox
sijie closed issue #2081: Improve documentation about `--inputs` and `--customSerdeInputs` for pulsar functions URL: https://github.com/apache/pulsar/issues/2081 This is an automated message from the Apache Git Service. To r

[GitHub] sijie commented on issue #1334: Experimental settings to achieve 5 ms latency

2018-11-28 Thread GitBox
sijie commented on issue #1334: Experimental settings to achieve 5 ms latency URL: https://github.com/apache/pulsar/issues/1334#issuecomment-442595034 > What's the order for Pulsar, when we disable forced fsync (and also when its on)? pulsar's replication mechanism is handled by book

[GitHub] merlimat commented on issue #3058: Add pull-mode on Websockets

2018-11-28 Thread GitBox
merlimat commented on issue #3058: Add pull-mode on Websockets URL: https://github.com/apache/pulsar/pull/3058#issuecomment-442582155 @cbornet The approach LGTM 👍 This is an automated message from the Apache Git Service. To r

[GitHub] merlimat commented on issue #2888: PIP-25: Token based authentication

2018-11-28 Thread GitBox
merlimat commented on issue #2888: PIP-25: Token based authentication URL: https://github.com/apache/pulsar/pull/2888#issuecomment-442580950 run cpp tests This is an automated message from the Apache Git Service. To respond to

[GitHub] merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#discussion_r237231978 ## File path: pulsar-client-cpp/python/src/authentication.cc ## @@ -32,6 +32,59 @@

[GitHub] merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#discussion_r237231482 ## File path: pulsar-client-cpp/lib/c/c_Authentication.cc ## @@ -23,6 +23,8 @@ #

[GitHub] merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#discussion_r237231354 ## File path: pulsar-client-cpp/tests/AuthTokenTest.cc ## @@ -0,0 +1,206 @@ +/** +

[GitHub] merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#discussion_r237230330 ## File path: pulsar-client-cpp/python/pulsar_test.py ## @@ -793,6 +793,43 @@ def t

[GitHub] merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#discussion_r237230147 ## File path: pulsar-client-cpp/pulsar-test-service-start.sh ## @@ -44,6 +44,14 @@

[GitHub] merlimat opened a new pull request #3085: Removed AspectJ build plugin from pulsar-broker

2018-11-28 Thread GitBox
merlimat opened a new pull request #3085: Removed AspectJ build plugin from pulsar-broker URL: https://github.com/apache/pulsar/pull/3085 ### Motivation In #3023 I had moved AspectJ to `pulsar-zookeeper-utils` module. Now the build plugin is not needed anymore in `pulsar-broker`. -

[GitHub] merlimat opened a new pull request #3084: Fixed C++ CMake dependency and enabled parallel build

2018-11-28 Thread GitBox
merlimat opened a new pull request #3084: Fixed C++ CMake dependency and enabled parallel build URL: https://github.com/apache/pulsar/pull/3084 ### Motivation The tests binary was not setting the dependency correctly and would fail to compile in parallel (trying to link before the l

[GitHub] merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#discussion_r237223642 ## File path: pulsar-client-cpp/tests/CMakeLists.txt ## @@ -25,4 +25,4 @@ add_execu

[GitHub] merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#discussion_r237219337 ## File path: pulsar-client-cpp/include/pulsar/Authentication.h ## @@ -114,6 +115,4

[GitHub] merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#discussion_r237219337 ## File path: pulsar-client-cpp/include/pulsar/Authentication.h ## @@ -114,6 +115,4

[GitHub] merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication

2018-11-28 Thread GitBox
merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#discussion_r237219337 ## File path: pulsar-client-cpp/include/pulsar/Authentication.h ## @@ -114,6 +115,4

[GitHub] sijie commented on issue #3061: [conf] keep bookkeeper.conf insync with 4.7.2 bookkeeper's conf template

2018-11-28 Thread GitBox
sijie commented on issue #3061: [conf] keep bookkeeper.conf insync with 4.7.2 bookkeeper's conf template URL: https://github.com/apache/pulsar/pull/3061#issuecomment-442565108 run integration tests This is an automated messag

[GitHub] sijie commented on a change in pull request #3079: Change un-ack messages tracking behavior

2018-11-28 Thread GitBox
sijie commented on a change in pull request #3079: Change un-ack messages tracking behavior URL: https://github.com/apache/pulsar/pull/3079#discussion_r237218108 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java ## @@ -256,4 +

[GitHub] sijie commented on a change in pull request #3079: Change un-ack messages tracking behavior

2018-11-28 Thread GitBox
sijie commented on a change in pull request #3079: Change un-ack messages tracking behavior URL: https://github.com/apache/pulsar/pull/3079#discussion_r237218565 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -826,14 +831,1

[GitHub] sijie commented on a change in pull request #3079: Change un-ack messages tracking behavior

2018-11-28 Thread GitBox
sijie commented on a change in pull request #3079: Change un-ack messages tracking behavior URL: https://github.com/apache/pulsar/pull/3079#discussion_r237218303 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java ## @@ -256,4 +

[pulsar] branch master updated: Don't overwrite integration tests longs if container restarted (#3080)

2018-11-28 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2df5540 Don't overwrite integration tests longs

[GitHub] sijie closed pull request #3080: Don't overwrite integration tests longs if container restarted

2018-11-28 Thread GitBox
sijie closed pull request #3080: Don't overwrite integration tests longs if container restarted URL: https://github.com/apache/pulsar/pull/3080 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] merlimat closed pull request #3081: Disable retry on integration tests

2018-11-28 Thread GitBox
merlimat closed pull request #3081: Disable retry on integration tests URL: https://github.com/apache/pulsar/pull/3081 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull requ

[pulsar] branch master updated: Disable retry on integration tests (#3081)

2018-11-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f74b939 Disable retry on integration tests (#30

[GitHub] ivankelly closed pull request #2733: Extra logging for offloaders

2018-11-28 Thread GitBox
ivankelly closed pull request #2733: Extra logging for offloaders URL: https://github.com/apache/pulsar/pull/2733 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (

[pulsar] branch master updated: Extra logging for offloaders (#2733)

2018-11-28 Thread ivank
This is an automated email from the ASF dual-hosted git repository. ivank pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4358a98 Extra logging for offloaders (#2733) 435

[GitHub] ivankelly commented on issue #3081: Disable retry on integration tests

2018-11-28 Thread GitBox
ivankelly commented on issue #3081: Disable retry on integration tests URL: https://github.com/apache/pulsar/pull/3081#issuecomment-442502010 rerun cpp tests This is an automated message from the Apache Git Service. To respond

[GitHub] foreversunyao opened a new issue #3083: Emhancement | NoopLoadManager could have more details for load report

2018-11-28 Thread GitBox
foreversunyao opened a new issue #3083: Emhancement | NoopLoadManager could have more details for load report URL: https://github.com/apache/pulsar/issues/3083 Expected behavior when run pulsar-admin broker-stats load-report, should return load information even run as standalon

  1   2   >