[GitHub] [pulsar] Anonymitaet commented on issue #12637: PIP 87: Upgrade Pulsar Website Framework

2021-11-07 Thread GitBox
Anonymitaet commented on issue #12637: URL: https://github.com/apache/pulsar/issues/12637#issuecomment-962896130 @codelipenghui thanks for reminding me, I've corrected the URL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] Anonymitaet opened a new issue #12661: PIP 98: Redesign Pulsar Information Architecture

2021-11-07 Thread GitBox
Anonymitaet opened a new issue #12661: URL: https://github.com/apache/pulsar/issues/12661 Design proposal, solution, implementation progress, and all details are available [here](https://docs.google.com/document/d/1O19v1znrNkoahFpsr8puVQ_20jDQfUjC2eRxdFOL91U/edit). -- This is an

[GitHub] [pulsar] codelipenghui commented on pull request #12439: [Issue 12271][Modernizer] Add Maven Modernizer plugin to pulsar-metadata module

2021-11-07 Thread GitBox
codelipenghui commented on pull request #12439: URL: https://github.com/apache/pulsar/pull/12439#issuecomment-962891234 @jadireddi Could you please rebase your branch? #12270 already introduced `maven-modernizer-plugin.version` in the pom.xml. -- This is an automated message from the

[GitHub] [pulsar] liangyepianzhou removed a comment on pull request #12636: [Transaction]Stop TB recovering with exception

2021-11-07 Thread GitBox
liangyepianzhou removed a comment on pull request #12636: URL: https://github.com/apache/pulsar/pull/12636#issuecomment-962404540 There is a problem here: When a NonRecoverableLedgerException appears, do we need to move the cusor in the FillEntryQueueCallback of TransactionBufferd or

[pulsar] branch master updated (e476735 -> 9b69069)

2021-11-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e476735 [Authorization] Support GET_METADATA topic op after enable auth (#12656) add 9b69069 [Modernizer]

[GitHub] [pulsar] codelipenghui merged pull request #12657: [Modernizer] Apply Modernizer plugin for pulsar broker common module and fix violation.

2021-11-07 Thread GitBox
codelipenghui merged pull request #12657: URL: https://github.com/apache/pulsar/pull/12657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12658: [broker] Avoid unnecessary recalculation of maxSubscriptionsPerTopic in AbstractTopic

2021-11-07 Thread GitBox
codelipenghui commented on a change in pull request #12658: URL: https://github.com/apache/pulsar/pull/12658#discussion_r744466377 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/PolicyHierarchyValue.java ## @@ -0,0 +1,76 @@ +/** + * Licensed

[GitHub] [pulsar] wolfstudy commented on pull request #12660: Add docs for nack backoff policy

2021-11-07 Thread GitBox
wolfstudy commented on pull request #12660: URL: https://github.com/apache/pulsar/pull/12660#issuecomment-962884129 cc @Anonymitaet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] wolfstudy opened a new pull request #12660: Add docs for nack backoff policy

2021-11-07 Thread GitBox
wolfstudy opened a new pull request #12660: URL: https://github.com/apache/pulsar/pull/12660 Signed-off-by: xiaolongran ### Motivation In https://github.com/apache/pulsar/pull/12566, we impl the `NegativeAckRedeliveryBackoff` and the pr will add docs for this.

[pulsar] branch master updated: [Authorization] Support GET_METADATA topic op after enable auth (#12656)

2021-11-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e476735 [Authorization] Support GET_METADATA

[GitHub] [pulsar] codelipenghui merged pull request #12656: [Authorization] Support GET_METADATA topic op after enable auth

2021-11-07 Thread GitBox
codelipenghui merged pull request #12656: URL: https://github.com/apache/pulsar/pull/12656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] massakam commented on a change in pull request #12401: [PIP 79][common,broker,client] Change PartitionedTopicStats to aggregate by producerName

2021-11-07 Thread GitBox
massakam commented on a change in pull request #12401: URL: https://github.com/apache/pulsar/pull/12401#discussion_r77195 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/GracefulExecutorServicesShutdownTest.java ## @@ -152,7 +153,8 @@ public

[GitHub] [pulsar] massakam commented on a change in pull request #12401: [PIP 79][common,broker,client] Change PartitionedTopicStats to aggregate by producerName

2021-11-07 Thread GitBox
massakam commented on a change in pull request #12401: URL: https://github.com/apache/pulsar/pull/12401#discussion_r744416170 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest2.java ## @@ -2231,4 +2232,170 @@ public void

[pulsar] branch master updated: Fix StringIndexOutOfBoundsException in org.apache.pulsar.broker.resources.NamespaceResources#pathIsFromNamespace (#12659)

2021-11-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 213f14c Fix StringIndexOutOfBoundsException in

[GitHub] [pulsar] massakam commented on a change in pull request #12401: [PIP 79][common,broker,client] Change PartitionedTopicStats to aggregate by producerName

2021-11-07 Thread GitBox
massakam commented on a change in pull request #12401: URL: https://github.com/apache/pulsar/pull/12401#discussion_r744409675 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest2.java ## @@ -2231,4 +2232,170 @@ public void

[GitHub] [pulsar] merlimat merged pull request #12659: Fix StringIndexOutOfBoundsException in NamespaceResources#pathIsFromNamespace

2021-11-07 Thread GitBox
merlimat merged pull request #12659: URL: https://github.com/apache/pulsar/pull/12659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] wolfstudy merged pull request #661: Remove unused dependency in `oauth2` module

2021-11-07 Thread GitBox
wolfstudy merged pull request #661: URL: https://github.com/apache/pulsar-client-go/pull/661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-go] branch master updated: remove unused dependency (#661)

2021-11-07 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new fe3b7c4 remove unused dependency (#661)

[GitHub] [pulsar-client-go] wolfstudy merged pull request #660: Support nack backoff policy for SDK

2021-11-07 Thread GitBox
wolfstudy merged pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-go] branch master updated: Support nack backoff policy for SDK (#660)

2021-11-07 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 567263f Support nack backoff policy for

[GitHub] [pulsar-client-go] zymap commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-07 Thread GitBox
zymap commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r742825857 ## File path: pulsar/consumer_regex.go ## @@ -183,6 +183,22 @@ func (c *regexConsumer) AckID(msgID MessageID) { } func (c *regexConsumer)

[GitHub] [pulsar] congbobo184 commented on pull request #11933: [Transaction] Add transaction perf

2021-11-07 Thread GitBox
congbobo184 commented on pull request #11933: URL: https://github.com/apache/pulsar/pull/11933#issuecomment-962788146 @eolivelli please review again, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] 315157973 commented on pull request #12517: PIP 92: part-2 Topic policy across multiple clusters

2021-11-07 Thread GitBox
315157973 commented on pull request #12517: URL: https://github.com/apache/pulsar/pull/12517#issuecomment-962787072 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] congbobo184 commented on a change in pull request #12521: [Transaction]Txn client check timeout

2021-11-07 Thread GitBox
congbobo184 commented on a change in pull request #12521: URL: https://github.com/apache/pulsar/pull/12521#discussion_r744378008 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java ## @@ -757,12 +758,31 @@ public void

[GitHub] [pulsar] nodece commented on pull request #12625: [Sink] Fix the parse the cleanupSubscription and processingGuarantees fields

2021-11-07 Thread GitBox
nodece commented on pull request #12625: URL: https://github.com/apache/pulsar/pull/12625#issuecomment-962756843 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] punish-yh closed pull request #12639: Update io-cdc-debezium.md

2021-11-07 Thread GitBox
punish-yh closed pull request #12639: URL: https://github.com/apache/pulsar/pull/12639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] MarvinCai commented on pull request #12657: [Modernizer] Apply Modernizer plugin for pulsar broker common module and fix violation.

2021-11-07 Thread GitBox
MarvinCai commented on pull request #12657: URL: https://github.com/apache/pulsar/pull/12657#issuecomment-962753054 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin

2021-11-07 Thread GitBox
yuruguo removed a comment on pull request #12315: URL: https://github.com/apache/pulsar/pull/12315#issuecomment-962739386 @hangc0276 @gaoran10 please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-07 Thread GitBox
codelipenghui commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r743374976 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java ## @@ -856,8 +858,13 @@ default void delete(String

[GitHub] [pulsar] yuruguo removed a comment on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin

2021-11-07 Thread GitBox
yuruguo removed a comment on pull request #12315: URL: https://github.com/apache/pulsar/pull/12315#issuecomment-962293794 @hangc0276 @gaoran10 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] yuruguo commented on pull request #12315: [pulsar-admin] Perfect judgment conditions of pulsar-admin

2021-11-07 Thread GitBox
yuruguo commented on pull request #12315: URL: https://github.com/apache/pulsar/pull/12315#issuecomment-962739386 @hangc0276 @gaoran10 please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Jason918 commented on pull request #12659: Fix StringIndexOutOfBoundsException in NamespaceResources#pathIsFromNamespace

2021-11-07 Thread GitBox
Jason918 commented on pull request #12659: URL: https://github.com/apache/pulsar/pull/12659#issuecomment-962739144 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] yuruguo removed a comment on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation

2021-11-07 Thread GitBox
yuruguo removed a comment on pull request #12656: URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962701662 @merlimat @hangc0276 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] yuruguo commented on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation

2021-11-07 Thread GitBox
yuruguo commented on pull request #12656: URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962701662 @merlimat @hangc0276 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] yuruguo commented on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation

2021-11-07 Thread GitBox
yuruguo commented on pull request #12656: URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962695425 > @yuruguo Could you please help add a test? The change looks good to me. Okay :) Done, PTAL -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] yuruguo commented on a change in pull request #12535: [pulsar-admin] Add --all option to get all version schema of topic

2021-11-07 Thread GitBox
yuruguo commented on a change in pull request #12535: URL: https://github.com/apache/pulsar/pull/12535#discussion_r744287470 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java ## @@ -51,13 +52,24 @@ public CmdSchemas(Supplier admin) {

[GitHub] [pulsar] yuruguo removed a comment on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation

2021-11-07 Thread GitBox
yuruguo removed a comment on pull request #12656: URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962586654 @lhotari @codelipenghui @gaoran10 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-07 Thread GitBox
gaoran10 commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r744285199 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1141,6 +1143,48 @@ public long

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-07 Thread GitBox
gaoran10 commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r744280486 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java ## @@ -856,8 +858,13 @@ default void delete(String

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-07 Thread GitBox
gaoran10 commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r744277998 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1141,6 +1144,53 @@ public long

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-07 Thread GitBox
gaoran10 commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r744277998 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1141,6 +1144,53 @@ public long

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-07 Thread GitBox
gaoran10 commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r744277998 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1141,6 +1144,53 @@ public long

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-07 Thread GitBox
gaoran10 commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r744277301 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1141,6 +1144,53 @@ public long

[GitHub] [pulsar] Jason918 opened a new pull request #12659: Fix StringIndexOutOfBoundsException in NamespaceResources#pathIsFromNamespace

2021-11-07 Thread GitBox
Jason918 opened a new pull request #12659: URL: https://github.com/apache/pulsar/pull/12659 ### Motivation The `NamespaceResources#pathIsFromNamespace` throws StringIndexOutOfBoundsException when path is "/admin/policies". PS. It happens in some test case, I am not sure

[GitHub] [pulsar] Jason918 opened a new pull request #12658: [broker] Avoid unnecessary recalculation of maxSubscriptionsPerTopic in AbstractTopic

2021-11-07 Thread GitBox
Jason918 opened a new pull request #12658: URL: https://github.com/apache/pulsar/pull/12658 ### Motivation Currently, `AbstractTopic#maxSubscriptionsPerTopic` stores the value of namespace level policy, but we have broker level setting in

[GitHub] [pulsar] MarvinCai opened a new pull request #12657: [Modernizer] Apply Modernizer plugin for pulsar broker common module and fix violation.

2021-11-07 Thread GitBox
MarvinCai opened a new pull request #12657: URL: https://github.com/apache/pulsar/pull/12657 Master Issue: #12271 ### Motivation Apply Maven Modernizer plugin to enforce we move away from legacy APIs. ### Modifications Add Maven Modernizer plugin in pulsar-broker-common

[pulsar] 02/02: [Python Schema] Python schema support custom Avro configurations for Enum type (#12642)

2021-11-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit b8ea17a07a8161990e79598debddaf1cc65d502b Author: ran AuthorDate: Sun Nov 7 21:24:33 2021 +0800 [Python

[pulsar] branch branch-2.8 updated (52764ce -> b8ea17a)

2021-11-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 52764ce revert the wrong modification in org.apache.pulsar.broker.namespace.OwnershipCache#checkOwnership

[pulsar] 01/02: PulsarAdmin: Fix last exit code storage (#12581)

2021-11-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 4e4f49d283b83e7310e909a2d9c5d960793486b1 Author: Thomas Leplus AuthorDate: Fri Nov 5 20:11:19 2021 -0700

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12641: [cli] Enable CLI to publish non-batched messages

2021-11-07 Thread GitBox
codelipenghui commented on a change in pull request #12641: URL: https://github.com/apache/pulsar/pull/12641#discussion_r744258801 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdProduce.java ## @@ -107,6 +107,9 @@ description =

[pulsar] branch master updated: [broker] remove useless method "PersistentTopic#getPersistentTopic" (#12655)

2021-11-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 40356eb [broker] remove useless method

[GitHub] [pulsar] codelipenghui merged pull request #12655: [broker] remove useless method "PersistentTopic#getPersistentTopic"

2021-11-07 Thread GitBox
codelipenghui merged pull request #12655: URL: https://github.com/apache/pulsar/pull/12655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated: [Python Schema] Python schema support custom Avro configurations for Enum type (#12642)

2021-11-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e7389ed [Python Schema] Python schema support

[GitHub] [pulsar] codelipenghui merged pull request #12642: [Python Schema] Python schema support custom Avro configurations for Enum type

2021-11-07 Thread GitBox
codelipenghui merged pull request #12642: URL: https://github.com/apache/pulsar/pull/12642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Jason918 commented on a change in pull request #12654: Remove unused listeners if it have no listeners.

2021-11-07 Thread GitBox
Jason918 commented on a change in pull request #12654: URL: https://github.com/apache/pulsar/pull/12654#discussion_r744246481 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java ## @@ -474,7 +475,13 @@ public

[GitHub] [pulsar] yuruguo removed a comment on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation

2021-11-07 Thread GitBox
yuruguo removed a comment on pull request #12656: URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962591280 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation

2021-11-07 Thread GitBox
yuruguo commented on pull request #12656: URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962591280 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] yuruguo removed a comment on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation

2021-11-07 Thread GitBox
yuruguo removed a comment on pull request #12656: URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962584862 @lhotari @eolivelli @codelipenghui @freeznet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] yuruguo commented on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation

2021-11-07 Thread GitBox
yuruguo commented on pull request #12656: URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962586654 @lhotari @codelipenghui @gaoran10 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] yuruguo commented on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation

2021-11-07 Thread GitBox
yuruguo commented on pull request #12656: URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962584862 @lhotari @eolivelli @codelipenghui @freeznet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] yuruguo opened a new pull request #12656: [Authorization] Fix not support GET_METADATA topic operation

2021-11-07 Thread GitBox
yuruguo opened a new pull request #12656: URL: https://github.com/apache/pulsar/pull/12656 ### Motivation Currently, we can get the internal stats of a topic through `bin/pulsar-admin topics stats-internal tn1/ns1/tp1` and also get ledger metadata by specifying flag `--metadata`.

[GitHub] [pulsar] eolivelli commented on a change in pull request #12654: Remove unused listeners if it have no listeners.

2021-11-07 Thread GitBox
eolivelli commented on a change in pull request #12654: URL: https://github.com/apache/pulsar/pull/12654#discussion_r744232276 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java ## @@ -474,7 +475,13 @@ public

[GitHub] [pulsar] github-actions[bot] commented on pull request #12655: [broker] remove useless method "PersistentTopic#getPersistentTopic"

2021-11-07 Thread GitBox
github-actions[bot] commented on pull request #12655: URL: https://github.com/apache/pulsar/pull/12655#issuecomment-962581860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] Jason918 opened a new pull request #12655: [broker] remove useless method "PersistentTopic#getPersistentTopic"

2021-11-07 Thread GitBox
Jason918 opened a new pull request #12655: URL: https://github.com/apache/pulsar/pull/12655 ### Motivation Method `PersistentTopic#getPersistentTopic` is totally useless and is not called anywhere. I don't see any chance it could be used. ### Modifications

[GitHub] [pulsar] Jason918 opened a new pull request #12654: Remove unused listeners if it have no listeners.

2021-11-07 Thread GitBox
Jason918 opened a new pull request #12654: URL: https://github.com/apache/pulsar/pull/12654 ### Motivation Remove unused listeners if it have no listeners, avoid the map (`SystemTopicBasedTopicPoliciesService#listeners`) from keep growing. ###

[GitHub] [pulsar] yuruguo commented on a change in pull request #12535: [pulsar-admin] Add --all option to get all version schema of topic

2021-11-07 Thread GitBox
yuruguo commented on a change in pull request #12535: URL: https://github.com/apache/pulsar/pull/12535#discussion_r744219865 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java ## @@ -51,13 +52,24 @@ public CmdSchemas(Supplier admin) {

[GitHub] [pulsar] huangdx0726 commented on pull request #12653: remove redundant code

2021-11-07 Thread GitBox
huangdx0726 commented on pull request #12653: URL: https://github.com/apache/pulsar/pull/12653#issuecomment-962557037 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go