[GitHub] [pulsar] gaozhangmin commented on a change in pull request #13720: fix checkReplication NPE

2022-01-11 Thread GitBox
gaozhangmin commented on a change in pull request #13720: URL: https://github.com/apache/pulsar/pull/13720#discussion_r782786485 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -1383,7 +1383,8 @@ public void

[GitHub] [pulsar] nodece commented on a change in pull request #13596: [Broker] Add operation timeout to metadata store

2022-01-11 Thread GitBox
nodece commented on a change in pull request #13596: URL: https://github.com/apache/pulsar/pull/13596#discussion_r782783571 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java ## @@ -186,6 +188,12 @@ protected void

[GitHub] [pulsar] RobertIndie commented on pull request #13702: [WIP][Test] Fix flaky-test: MultiTopicsReaderTest.testMultiTopic

2022-01-11 Thread GitBox
RobertIndie commented on pull request #13702: URL: https://github.com/apache/pulsar/pull/13702#issuecomment-1010730931 https://github.com/apache/pulsar/pull/13634 can fix this issue. So close this pr. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] RobertIndie closed pull request #13702: [WIP][Test] Fix flaky-test: MultiTopicsReaderTest.testMultiTopic

2022-01-11 Thread GitBox
RobertIndie closed pull request #13702: URL: https://github.com/apache/pulsar/pull/13702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Jason918 commented on issue #13706: NPE while checkReplication

2022-01-11 Thread GitBox
Jason918 commented on issue #13706: URL: https://github.com/apache/pulsar/issues/13706#issuecomment-1010728048 @Shoothzj Does this happen in some unit test case ? It should not happen if the topic is properly init. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Jason918 commented on a change in pull request #13720: fix checkReplication NPE

2022-01-11 Thread GitBox
Jason918 commented on a change in pull request #13720: URL: https://github.com/apache/pulsar/pull/13720#discussion_r782774992 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -1383,7 +1383,8 @@ public void

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13596: [Broker] Add operation timeout to metadata store

2022-01-11 Thread GitBox
codelipenghui commented on a change in pull request #13596: URL: https://github.com/apache/pulsar/pull/13596#discussion_r782771994 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java ## @@ -186,6 +188,12 @@ protected void

[GitHub] [pulsar] bin-albin opened a new issue #13721: The topic monitoring information is incorrect

2022-01-11 Thread GitBox
bin-albin opened a new issue #13721: URL: https://github.com/apache/pulsar/issues/13721 **Describe the bug** In the Grafana control panel, my topic number is in the tens of millions, but the actual cluster is in the tens of thousands. Other indicators are also incorrect, such as

[GitHub] [pulsar] yuruguo removed a comment on pull request #13711: [Broker] Add deleteSubscriptionDispatchRate method for v1 namespace

2022-01-11 Thread GitBox
yuruguo removed a comment on pull request #13711: URL: https://github.com/apache/pulsar/pull/13711#issuecomment-1010498459 @codelipenghui @hangc0276 @Technoboy- ptal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] liudezhi2098 commented on pull request #13707: [PIP-130] Apply redelivery backoff policy for ack timeout

2022-01-11 Thread GitBox
liudezhi2098 commented on pull request #13707: URL: https://github.com/apache/pulsar/pull/13707#issuecomment-1010719903 @codelipenghui @hangc0276 @wolfstudy PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] Jason918 commented on a change in pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
Jason918 commented on a change in pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#discussion_r782767023 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -1438,45 +1438,15 @@ public void

[GitHub] [pulsar] github-actions[bot] commented on pull request #13720: fix npe

2022-01-11 Thread GitBox
github-actions[bot] commented on pull request #13720: URL: https://github.com/apache/pulsar/pull/13720#issuecomment-1010710856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] gaozhangmin opened a new pull request #13720: fix npe

2022-01-11 Thread GitBox
gaozhangmin opened a new pull request #13720: URL: https://github.com/apache/pulsar/pull/13720 Fixes #13706 ### Motivation From previous code, there are chances policies.replication_clusters maybe null. We should check if it's null.

[GitHub] [pulsar-client-go] caibirdme commented on issue #702: consume panic

2022-01-11 Thread GitBox
caibirdme commented on issue #702: URL: https://github.com/apache/pulsar-client-go/issues/702#issuecomment-1010706063 > How lenth with your entry?Please give me more case~ @caibirdme It's a bug report from tencent cloud user, @wolfstudy can reproduce it -- This is an automated

[GitHub] [pulsar] nodece edited a comment on pull request #13709: [Doc] redelivery backoff policy for ack timeout

2022-01-11 Thread GitBox
nodece edited a comment on pull request #13709: URL: https://github.com/apache/pulsar/pull/13709#issuecomment-1010702239 @Anonymitaet @liudezhi2098 Looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] nodece commented on pull request #13709: [Doc] redelivery backoff policy for ack timeout

2022-01-11 Thread GitBox
nodece commented on pull request #13709: URL: https://github.com/apache/pulsar/pull/13709#issuecomment-1010702239 @liudezhi2098 Looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-client-go] EAHITechnology commented on issue #702: consume panic

2022-01-11 Thread GitBox
EAHITechnology commented on issue #702: URL: https://github.com/apache/pulsar-client-go/issues/702#issuecomment-1010695378 How lenth with your entry?Please give me more case~ @caibirdme -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #703: Fix stuck when reconnect broker

2022-01-11 Thread GitBox
wolfstudy commented on pull request #703: URL: https://github.com/apache/pulsar-client-go/pull/703#issuecomment-1010697007 @cckellogg Choose to reuse the current code logic for processing. When receiving the CommandCloseProducer or CommandCloseConsumer cmd, set the current connection

[GitHub] [pulsar] michaeljmarshall commented on pull request #13245: Make sure the client can get response when encounter producer busy exception.

2022-01-11 Thread GitBox
michaeljmarshall commented on pull request #13245: URL: https://github.com/apache/pulsar/pull/13245#issuecomment-1010693291 @wolfstudy - note that a 2.7.2 broker has the behavior that @codelipenghui is proposing here. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-client-go] EAHITechnology commented on issue #702: consume panic

2022-01-11 Thread GitBox
EAHITechnology commented on issue #702: URL: https://github.com/apache/pulsar-client-go/issues/702#issuecomment-1010692161 It seems like GetPayloadSize() return a error lenth -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] AnonHxy commented on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy commented on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1010674724 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] AnonHxy removed a comment on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy removed a comment on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1010639232 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] nodece commented on a change in pull request #13297: Add schema compatibility strategy on topic level

2022-01-11 Thread GitBox
nodece commented on a change in pull request #13297: URL: https://github.com/apache/pulsar/pull/13297#discussion_r782734904 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java ## @@ -3491,5 +3492,114 @@ public void

[GitHub] [pulsar] nodece commented on a change in pull request #13297: Add schema compatibility strategy on topic level

2022-01-11 Thread GitBox
nodece commented on a change in pull request #13297: URL: https://github.com/apache/pulsar/pull/13297#discussion_r782734029 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java ## @@ -181,11 +211,48 @@ protected void

[GitHub] [pulsar] nodece commented on a change in pull request #13297: Add schema compatibility strategy on topic level

2022-01-11 Thread GitBox
nodece commented on a change in pull request #13297: URL: https://github.com/apache/pulsar/pull/13297#discussion_r782733069 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/schema/compatibility/SchemaTypeCompatibilityCheckTest.java ## @@ -35,33 +42,24 @@ import

[GitHub] [pulsar] AnonHxy commented on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy commented on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1010639232 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] AnonHxy removed a comment on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy removed a comment on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1010602876 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[pulsar-client-go] branch master updated (ff7a962 -> 2bcf7c7)

2022-01-11 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git. from ff7a962 Revert "Use a separate gorutine to handle the logic of reconnect" (#700) add 2bcf7c7 Fix data

[GitHub] [pulsar-client-go] wolfstudy merged pull request #701: Fix data race while accessing connection in partitionProducer

2022-01-11 Thread GitBox
wolfstudy merged pull request #701: URL: https://github.com/apache/pulsar-client-go/pull/701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] gaoran10 edited a comment on pull request #13298: [11646][Pulsar Java client] Fix ConfigurationDataUtils loadConf strategy

2022-01-11 Thread GitBox
gaoran10 edited a comment on pull request #13298: URL: https://github.com/apache/pulsar/pull/13298#issuecomment-1008335611 Maybe we could add a construct method for `DeadLetterPolicy`, then we could use the conf to set `DeadLetterPolicy`. -- This is an automated message from the Apache

[GitHub] [pulsar] codelipenghui commented on pull request #13337: Fix delete namespace with 'Cannot delete non empty bundle' issue.

2022-01-11 Thread GitBox
codelipenghui commented on pull request #13337: URL: https://github.com/apache/pulsar/pull/13337#issuecomment-1010603851 @shibd Could you please help review this PR again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] AnonHxy removed a comment on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy removed a comment on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1010570516 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] AnonHxy commented on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy commented on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1010602876 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated (9032a9a -> 2a7515f)

2022-01-11 Thread linlin
This is an automated email from the ASF dual-hosted git repository. linlin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 9032a9a Enable CheckStyle Plugin in managed-ledger module (#13619) add 2a7515f Fix bug :Infinity value for

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #701: Fix data race while accessing connection in partitionProducer

2022-01-11 Thread GitBox
wolfstudy commented on a change in pull request #701: URL: https://github.com/apache/pulsar-client-go/pull/701#discussion_r782684668 ## File path: pulsar/producer_partition.go ## @@ -800,7 +801,7 @@ func (p *partitionProducer) ReceivedSendReceipt(response

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #703: Fix stuck when reconnect broker

2022-01-11 Thread GitBox
wolfstudy commented on a change in pull request #703: URL: https://github.com/apache/pulsar-client-go/pull/703#discussion_r782681463 ## File path: pulsar/internal/connection.go ## @@ -163,6 +163,9 @@ type connection struct { consumerHandlersLock sync.RWMutex

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #703: Fix stuck when reconnect broker

2022-01-11 Thread GitBox
wolfstudy commented on a change in pull request #703: URL: https://github.com/apache/pulsar-client-go/pull/703#discussion_r782679888 ## File path: pulsar/internal/connection.go ## @@ -163,6 +163,9 @@ type connection struct { consumerHandlersLock sync.RWMutex

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #703: Fix stuck when reconnect broker

2022-01-11 Thread GitBox
wolfstudy commented on a change in pull request #703: URL: https://github.com/apache/pulsar-client-go/pull/703#discussion_r782679888 ## File path: pulsar/internal/connection.go ## @@ -163,6 +163,9 @@ type connection struct { consumerHandlersLock sync.RWMutex

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #703: Fix stuck when reconnect broker

2022-01-11 Thread GitBox
wolfstudy commented on a change in pull request #703: URL: https://github.com/apache/pulsar-client-go/pull/703#discussion_r782679888 ## File path: pulsar/internal/connection.go ## @@ -163,6 +163,9 @@ type connection struct { consumerHandlersLock sync.RWMutex

[GitHub] [pulsar] 315157973 merged pull request #13609: Fix bug :Infinity value for CPU or Bandwidth usage

2022-01-11 Thread GitBox
315157973 merged pull request #13609: URL: https://github.com/apache/pulsar/pull/13609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #703: Fix stuck when reconnect broker

2022-01-11 Thread GitBox
wolfstudy commented on a change in pull request #703: URL: https://github.com/apache/pulsar-client-go/pull/703#discussion_r782672593 ## File path: pulsar/internal/connection_pool.go ## @@ -75,13 +75,15 @@ func (p *connectionPool) GetConnection(logicalAddr *url.URL,

[GitHub] [pulsar] gaozhangmin commented on issue #13706: NPE while checkReplication

2022-01-11 Thread GitBox
gaozhangmin commented on issue #13706: URL: https://github.com/apache/pulsar/issues/13706#issuecomment-1010578314 I will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] AnonHxy commented on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy commented on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1010570516 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] AnonHxy removed a comment on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy removed a comment on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1010486184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13709: [Doc] redelivery backoff policy for ack timeout

2022-01-11 Thread GitBox
Anonymitaet commented on a change in pull request #13709: URL: https://github.com/apache/pulsar/pull/13709#discussion_r782665029 ## File path: site2/docs/concepts-messaging.md ## @@ -194,16 +194,41 @@ But this is not flexible enough. A better way is to use the **redelivery

[GitHub] [pulsar] AnonHxy commented on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy commented on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1010568783 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] vhaisong opened a new issue #13719: [Doc] Incorrect description in https://pulsar.apache.org/docs/en/concepts-messaging/#retry-letter-topic

2022-01-11 Thread GitBox
vhaisong opened a new issue #13719: URL: https://github.com/apache/pulsar/issues/13719 ### What issue do you find in Pulsar docs? In https://pulsar.apache.org/docs/en/concepts-messaging/#retry-letter-topic, it said "For many online business systems, a message is re-consumed due to

[GitHub] [pulsar] Anonymitaet commented on pull request #13709: [Doc] redelivery backoff policy for ack timeout

2022-01-11 Thread GitBox
Anonymitaet commented on pull request #13709: URL: https://github.com/apache/pulsar/pull/13709#issuecomment-1010547809 @nodece can you review this PR from the technical perspective? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] liudezhi2098 removed a comment on pull request #13619: Enable CheckStyle Plugin in managed-ledger module

2022-01-11 Thread GitBox
liudezhi2098 removed a comment on pull request #13619: URL: https://github.com/apache/pulsar/pull/13619#issuecomment-1007225675 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] Shoothzj merged pull request #13619: Enable CheckStyle Plugin in managed-ledger module

2022-01-11 Thread GitBox
Shoothzj merged pull request #13619: URL: https://github.com/apache/pulsar/pull/13619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on pull request #13619: Enable CheckStyle Plugin in managed-ledger module

2022-01-11 Thread GitBox
codelipenghui commented on pull request #13619: URL: https://github.com/apache/pulsar/pull/13619#issuecomment-1010544178 @Shoothzj It's ok, the `OffloadHandle` introduced by streaming offloading, and it only is used in streaming offload, and its internal component, so we can change the

[GitHub] [pulsar] Shoothzj commented on pull request #13715: Fix some typos

2022-01-11 Thread GitBox
Shoothzj commented on pull request #13715: URL: https://github.com/apache/pulsar/pull/13715#issuecomment-1010543109 @pkumar-singh Could you please rebase your code to paas the ci? I saw you code base is 2021 Aug -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] lordcheng10 commented on pull request #13609: Fix bug :Infinity value for CPU or Bandwidth usage

2022-01-11 Thread GitBox
lordcheng10 commented on pull request #13609: URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1010539146 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] github-actions[bot] removed a comment on pull request #13715: Fix some typos

2022-01-11 Thread GitBox
github-actions[bot] removed a comment on pull request #13715: URL: https://github.com/apache/pulsar/pull/13715#issuecomment-1010413464 @pkumar-singh:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] leizhiyuan commented on issue #13718: should we add a metrics to show the top storage in bookeeper

2022-01-11 Thread GitBox
leizhiyuan commented on issue #13718: URL: https://github.com/apache/pulsar/issues/13718#issuecomment-1010531324 if is not necessary, I can read zookeeper of bk directly, use the metadata to analyze -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] equanz edited a comment on pull request #13644: Rename test file name from `*Test2.java` to `*Test.java` to run all tests correctly

2022-01-11 Thread GitBox
equanz edited a comment on pull request #13644: URL: https://github.com/apache/pulsar/pull/13644#issuecomment-1009726741 > why change `NamespacesBase` After enabling `*Test2.java` cases, I found some bugs. This PR includes these fixes. * For

[GitHub] [pulsar] leizhiyuan opened a new issue #13718: should we add a metrics to show the top storage in bookeeper

2022-01-11 Thread GitBox
leizhiyuan opened a new issue #13718: URL: https://github.com/apache/pulsar/issues/13718 **Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] pulsar_storage_size only shows

[GitHub] [pulsar] yuruguo commented on pull request #13711: [Broker] Add deleteSubscriptionDispatchRate method for v1 namespace

2022-01-11 Thread GitBox
yuruguo commented on pull request #13711: URL: https://github.com/apache/pulsar/pull/13711#issuecomment-1010498459 @codelipenghui @hangc0276 @Technoboy- ptal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] yuruguo removed a comment on pull request #13711: [Broker] Add deleteSubscriptionDispatchRate method for v1 namespace

2022-01-11 Thread GitBox
yuruguo removed a comment on pull request #13711: URL: https://github.com/apache/pulsar/pull/13711#issuecomment-1010145135 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] merlimat opened a new issue #13717: PIP-135: Include MetadataStore backend for Etcd

2022-01-11 Thread GitBox
merlimat opened a new issue #13717: URL: https://github.com/apache/pulsar/issues/13717 ## Motivation Since all the pieces that composed the proposal in PIP-45 were finally merged and are currently ready for 2.10 release, it is now possible to add other metadata backends that

[GitHub] [pulsar] AnonHxy commented on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy commented on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1010486184 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] dlg99 opened a new pull request #13716: Updating dependencies (guava and what brought in older guava) to get rid of the guava-related CVE-2018-10237 and CVE-2020-8908

2022-01-11 Thread GitBox
dlg99 opened a new pull request #13716: URL: https://github.com/apache/pulsar/pull/13716 Updating dependencies (guava and what brought in older guava) to get rid of the guava-related CVE-2018-10237 and CVE-2020-8908 pulsar-io/canal is excluded (no fix available and guava is bundled

[pulsar] branch master updated (c9728ab -> 7f4583b)

2022-01-11 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c9728ab [pulsar-client-tools] Support Disable Replication in Pulsar Client Tools (#13659) add 7f4583b [ci]

[GitHub] [pulsar] merlimat merged pull request #13675: [ci] Split broker admin tests to unitgroup3

2022-01-11 Thread GitBox
merlimat merged pull request #13675: URL: https://github.com/apache/pulsar/pull/13675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (104adbe -> c9728ab)

2022-01-11 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 104adbe Upgrade BK to 4.14.4 and Grpc to 1.42.1 (#13714) add c9728ab [pulsar-client-tools] Support Disable

[GitHub] [pulsar] merlimat merged pull request #13659: [pulsar-client-tools] Support Disable Replication in Pulsar Client Tools

2022-01-11 Thread GitBox
merlimat merged pull request #13659: URL: https://github.com/apache/pulsar/pull/13659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] merlimat commented on issue #13661: [PIP] Pulsar consumer support auto acknowledge.

2022-01-11 Thread GitBox
merlimat commented on issue #13661: URL: https://github.com/apache/pulsar/issues/13661#issuecomment-1010443775 @gaozhangmin > Pulsar should support auto commit offset in background like what KAFKA did. But why? The problem with Kafka acks is that if you ack each

[GitHub] [pulsar] merlimat commented on a change in pull request #13704: [Transaction] Duplicate TYPE of Prometheus metrics

2022-01-11 Thread GitBox
merlimat commented on a change in pull request #13704: URL: https://github.com/apache/pulsar/pull/13704#discussion_r782587532 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TransactionAggregator.java ## @@ -36,6 +38,11 @@ @Slf4j public

[pulsar] branch master updated (adcf554 -> 104adbe)

2022-01-11 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from adcf554 Enable CheckStyle Plugin in pulsar-config-validation (#13676) add 104adbe Upgrade BK to 4.14.4 and

[GitHub] [pulsar] merlimat merged pull request #13714: Upgrade BK to 4.14.4 and Grpc to 1.42.1

2022-01-11 Thread GitBox
merlimat merged pull request #13714: URL: https://github.com/apache/pulsar/pull/13714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] github-actions[bot] commented on pull request #13715: Fix some typos

2022-01-11 Thread GitBox
github-actions[bot] commented on pull request #13715: URL: https://github.com/apache/pulsar/pull/13715#issuecomment-1010413464 @pkumar-singh:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] pkumar-singh opened a new pull request #13715: Fix some typos

2022-01-11 Thread GitBox
pkumar-singh opened a new pull request #13715: URL: https://github.com/apache/pulsar/pull/13715 **Motivation** Fix some typos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize

2022-01-11 Thread GitBox
lordcheng10 commented on pull request #13529: URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1010383678 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13679: Support dynamic update cache config

2022-01-11 Thread GitBox
lordcheng10 removed a comment on pull request #13679: URL: https://github.com/apache/pulsar/pull/13679#issuecomment-1010383352 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] lordcheng10 commented on pull request #13679: Support dynamic update cache config

2022-01-11 Thread GitBox
lordcheng10 commented on pull request #13679: URL: https://github.com/apache/pulsar/pull/13679#issuecomment-1010383352 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] lordcheng10 commented on pull request #13609: Fix bug :Infinity value for CPU or Bandwidth usage

2022-01-11 Thread GitBox
lordcheng10 commented on pull request #13609: URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1010382799 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] lordcheng10 commented on pull request #13681: Collect broker dispatch latency in prometheus

2022-01-11 Thread GitBox
lordcheng10 commented on pull request #13681: URL: https://github.com/apache/pulsar/pull/13681#issuecomment-1010382123 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] eolivelli commented on a change in pull request #3823: [Issue 3822] [pulsar-io] Add a Pulsar IO connector for Alluxio sink

2022-01-11 Thread GitBox
eolivelli commented on a change in pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#discussion_r782515490 ## File path: pulsar-io/alluxio/pom.xml ## @@ -0,0 +1,161 @@ + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [pulsar] github-actions[bot] commented on pull request #13714: Upgrade BK to 4.14.4

2022-01-11 Thread GitBox
github-actions[bot] commented on pull request #13714: URL: https://github.com/apache/pulsar/pull/13714#issuecomment-1010307865 @merlimat:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] merlimat opened a new pull request #13714: Upgrade BK to 4.14.4

2022-01-11 Thread GitBox
merlimat opened a new pull request #13714: URL: https://github.com/apache/pulsar/pull/13714 ### Motivation Upgrade to BookKeeper 4.14.4: https://github.com/apache/bookkeeper/pulls?q=is%3Apr+is%3Aclosed+label%3Arelease%2F4.14.4 -- This is an automated message from the Apache

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #703: Fix stuck when reconnect broker

2022-01-11 Thread GitBox
cckellogg commented on a change in pull request #703: URL: https://github.com/apache/pulsar-client-go/pull/703#discussion_r782392829 ## File path: pulsar/internal/connection.go ## @@ -163,6 +163,9 @@ type connection struct { consumerHandlersLock sync.RWMutex

[GitHub] [pulsar] tonyvelichko opened a new issue #13713: [2.7.4] NPE while open reader to pulsar topic

2022-01-11 Thread GitBox
tonyvelichko opened a new issue #13713: URL: https://github.com/apache/pulsar/issues/13713 **Describe the bug** Opening the reader to the topic produces NPE, and causes the exception on the client-side **Exclusive consumer is already connected** ```16:08:18.406

[GitHub] [pulsar] yuruguo commented on pull request #13711: [Broker] Add deleteSubscriptionDispatchRate method for v1 namespace

2022-01-11 Thread GitBox
yuruguo commented on pull request #13711: URL: https://github.com/apache/pulsar/pull/13711#issuecomment-1010145135 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-client-go] GPrabhudas closed pull request #704: Reader subscribe all partitions

2022-01-11 Thread GitBox
GPrabhudas closed pull request #704: URL: https://github.com/apache/pulsar-client-go/pull/704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] GPrabhudas opened a new pull request #704: Reader subscribe all partitions

2022-01-11 Thread GitBox
GPrabhudas opened a new pull request #704: URL: https://github.com/apache/pulsar-client-go/pull/704 <-- ### Contribution Checklist - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue

[GitHub] [pulsar] e-marchand-exensa opened a new issue #13712: [2.8.2] error while create opSendMsg by batch message container - zstd overflow detected

2022-01-11 Thread GitBox
e-marchand-exensa opened a new issue #13712: URL: https://github.com/apache/pulsar/issues/13712 **Describe the bug** Just trying to upgrade from Pulsar 2.6.4 to 2.8.2, running into this exception very quickly on a standalone test (from scratch, so no backlog or anything). ```

[GitHub] [pulsar] yuruguo opened a new pull request #13711: [Broker] Add deleteSubscriptionDispatchRate method for v1 namespace

2022-01-11 Thread GitBox
yuruguo opened a new pull request #13711: URL: https://github.com/apache/pulsar/pull/13711 ### Motivation Currently, the CLI supports `set`/`get`/`remove` operation to the `subscriptionDispatchRate` of `v1/namespace` and `v2/namespace`, and the server provides corresponding processing

[GitHub] [pulsar] AnonHxy opened a new pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-11 Thread GitBox
AnonHxy opened a new pull request #13710: URL: https://github.com/apache/pulsar/pull/13710 ### Motivation * This is one of the serial topic policy optimization with HierarchyTopicPolicies. ### Modifications * Add new field compactionThreshold in

[GitHub] [pulsar] BewareMyPower commented on pull request #13627: [C++] PIP 37: Support large message size

2022-01-11 Thread GitBox
BewareMyPower commented on pull request #13627: URL: https://github.com/apache/pulsar/pull/13627#issuecomment-1009991985 Hi @merlimat , could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] mattisonchao removed a comment on issue #13591: [PIP 132] Include message header size when check maxMessageSize for non-batch message on the client side.

2022-01-11 Thread GitBox
mattisonchao removed a comment on issue #13591: URL: https://github.com/apache/pulsar/issues/13591#issuecomment-1004483145 Hi, @Jason918 I think we can deprecate ``maxMessageSize `` to ``maxPayloadSize``, and add ``maxHeaderSize `` to limit header size. after then, we can use

[GitHub] [pulsar-client-go] caibirdme commented on issue #702: consume panic

2022-01-11 Thread GitBox
caibirdme commented on issue #702: URL: https://github.com/apache/pulsar-client-go/issues/702#issuecomment-1009981539 @cckellogg @merlimat @sijie @freeznet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize

2022-01-11 Thread GitBox
lordcheng10 commented on pull request #13529: URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1009980281 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13679: Support dynamic update cache config

2022-01-11 Thread GitBox
lordcheng10 edited a comment on pull request #13679: URL: https://github.com/apache/pulsar/pull/13679#issuecomment-1009979758 > A general comment about this implementation. > > Referring everything to the Service Configuration is a waste of resource and we should avoid this

[GitHub] [pulsar] lordcheng10 commented on pull request #13679: Support dynamic update cache config

2022-01-11 Thread GitBox
lordcheng10 commented on pull request #13679: URL: https://github.com/apache/pulsar/pull/13679#issuecomment-1009979758 > A general comment about this implementation. > > Referring everything to the Service Configuration is a waste of resource and we should avoid this especially

[GitHub] [pulsar] lordcheng10 commented on pull request #13679: Support dynamic update cache config

2022-01-11 Thread GitBox
lordcheng10 commented on pull request #13679: URL: https://github.com/apache/pulsar/pull/13679#issuecomment-1009979238 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] github-actions[bot] commented on pull request #13709: [Doc] redelivery backoff policy for ack timeout

2022-01-11 Thread GitBox
github-actions[bot] commented on pull request #13709: URL: https://github.com/apache/pulsar/pull/13709#issuecomment-1009973153 @liudezhi2098:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] liudezhi2098 opened a new pull request #13709: [Doc] redelivery backoff policy for ack timeout

2022-01-11 Thread GitBox
liudezhi2098 opened a new pull request #13709: URL: https://github.com/apache/pulsar/pull/13709 This PR adds docs for [[PIP-130] Apply redelivery backoff policy for ack timeout _#13707_ ]( https://github.com/apache/pulsar/pull/13707 ) Preview looks good:

[GitHub] [pulsar] liudezhi2098 commented on pull request #13707: [PIP-130] Apply redelivery backoff policy for ack timeout

2022-01-11 Thread GitBox
liudezhi2098 commented on pull request #13707: URL: https://github.com/apache/pulsar/pull/13707#issuecomment-1009958949 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] meklu opened a new pull request #13708: docker-compose: Fix startup issues on SELinux

2022-01-11 Thread GitBox
meklu opened a new pull request #13708: URL: https://github.com/apache/pulsar/pull/13708 If you don't set the SELinux context of volumes in compose files, there will be access errors all over the place. This change addresses that issue in the kitchen-sink sample compose file.

[pulsar] branch master updated: Enable CheckStyle Plugin in pulsar-config-validation (#13676)

2022-01-11 Thread shoothzj
This is an automated email from the ASF dual-hosted git repository. shoothzj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new adcf554 Enable CheckStyle Plugin in

  1   2   >