[pulsar] branch master updated (5a33d10 -> 8574639)

2022-01-19 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5a33d10 Getting rid of CVEs in batch-data-generator (#13820) add 8574639 Getitng rid of CVEs in InfluxDB

[pulsar] branch master updated (8a452b7 -> 5a33d10)

2022-01-19 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8a452b7 Getting rid of CVes brought in with aerospike (#13819) add 5a33d10 Getting rid of CVEs in

[GitHub] [pulsar] Shawyeok closed issue #13741: Consumer already closed with system topic

2022-01-19 Thread GitBox
Shawyeok closed issue #13741: URL: https://github.com/apache/pulsar/issues/13741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Shawyeok commented on issue #13741: Consumer already closed with system topic

2022-01-19 Thread GitBox
Shawyeok commented on issue #13741: URL: https://github.com/apache/pulsar/issues/13741#issuecomment-1017206489 @mattisonchao @yuvalgut It is duplicate with #12024, and fixed by #12044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] mattisonchao commented on a change in pull request #13853: [Broker] Fix call sync method in async rest api for internalTriggerCompaction

2022-01-19 Thread GitBox
mattisonchao commented on a change in pull request #13853: URL: https://github.com/apache/pulsar/pull/13853#discussion_r788462577 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3543,98 +3543,88 @@ protected void

[pulsar] branch master updated (fae5599 -> 8a452b7)

2022-01-19 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from fae5599 fix(conf): update OffloadDriver values hint in broker conf (#13815) add 8a452b7 Getting rid of CVes

[GitHub] [pulsar] codelipenghui merged pull request #13822: Getting rid of CVEs in Solr connector

2022-01-19 Thread GitBox
codelipenghui merged pull request #13822: URL: https://github.com/apache/pulsar/pull/13822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (f551fdc -> fae5599)

2022-01-19 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f551fdc [broker] Fix topic produced through REST not support Authorization (#13771) add fae5599 fix(conf):

[GitHub] [pulsar] codelipenghui merged pull request #13820: Getting rid of CVEs in batch-data-generator

2022-01-19 Thread GitBox
codelipenghui merged pull request #13820: URL: https://github.com/apache/pulsar/pull/13820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #13821: Getting rid of CVEs in InfluxDB connector

2022-01-19 Thread GitBox
codelipenghui merged pull request #13821: URL: https://github.com/apache/pulsar/pull/13821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #13819: Getting rid of CVEs brought in with aerospike

2022-01-19 Thread GitBox
codelipenghui merged pull request #13819: URL: https://github.com/apache/pulsar/pull/13819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #13815: fix(conf): update OffloadDriver values hint in broker conf

2022-01-19 Thread GitBox
codelipenghui merged pull request #13815: URL: https://github.com/apache/pulsar/pull/13815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] casuallc commented on pull request #13373: Support rename the file has been processed.

2022-01-19 Thread GitBox
casuallc commented on pull request #13373: URL: https://github.com/apache/pulsar/pull/13373#issuecomment-1017203259 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] nicoloboschi commented on pull request #13842: [owasp] make CI fails if distribution/offloaders check does not pass

2022-01-19 Thread GitBox
nicoloboschi commented on pull request #13842: URL: https://github.com/apache/pulsar/pull/13842#issuecomment-1017202140 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] liudezhi2098 opened a new pull request #13853: [Broker] Fix call sync method in async rest api for internalTriggerCompaction

2022-01-19 Thread GitBox
liudezhi2098 opened a new pull request #13853: URL: https://github.com/apache/pulsar/pull/13853 ### Motivation Avoid call sync method in async rest API for PersistentTopicsBase#internalTriggerCompaction. ### Modifications - *Use async instead of sync method.*

[GitHub] [pulsar] mattisonchao commented on pull request #13845: [Broker] Fix call sync method in async rest api for internalUnloadTopic

2022-01-19 Thread GitBox
mattisonchao commented on pull request #13845: URL: https://github.com/apache/pulsar/pull/13845#issuecomment-1017199549 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] XuanYang-cn opened a new issue #13852: Writing local data to ZooKeeper because maximum change 33235.83459104782% exceeded threshold 10%

2022-01-19 Thread GitBox
XuanYang-cn opened a new issue #13852: URL: https://github.com/apache/pulsar/issues/13852 **Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '' 3. Scroll down to

[pulsar] branch master updated (96e98fc -> f551fdc)

2022-01-19 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 96e98fc Rename test file name from `*Test2.java` to `*Test.java` to run all tests correctly (#13644) add

[pulsar] branch branch-2.9 updated: Fix SystemTopicBasedTopicPoliciesService NPE issue. (#13840)

2022-01-19 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.9 by this push: new 85bd12a Fix

[GitHub] [pulsar] codelipenghui merged pull request #13771: [broker] Fix topic produced through REST not support Authorization

2022-01-19 Thread GitBox
codelipenghui merged pull request #13771: URL: https://github.com/apache/pulsar/pull/13771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #13840: [Branch-2.9] Fix SystemTopicBasedTopicPoliciesService NPE issue.

2022-01-19 Thread GitBox
codelipenghui merged pull request #13840: URL: https://github.com/apache/pulsar/pull/13840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] BewareMyPower commented on issue #13849: Flaky-test: C++ ProducerTest.testSendAsyncCloseAsyncConcurrentlyWithLazyProducers

2022-01-19 Thread GitBox
BewareMyPower commented on issue #13849: URL: https://github.com/apache/pulsar/issues/13849#issuecomment-1017187508 I'll take a look when I'm free. BTW, this flaky test might be introduced from https://github.com/apache/pulsar/pull/11570, it would be better if @Vanlightly could

[GitHub] [pulsar] mattisonchao commented on pull request #13805: [Broker] Fix call sync method in async rest api for ``internalDeletePartitionedTopic``

2022-01-19 Thread GitBox
mattisonchao commented on pull request #13805: URL: https://github.com/apache/pulsar/pull/13805#issuecomment-1017185815 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] tjiuming edited a comment on pull request #13833: Offloader metrics

2022-01-19 Thread GitBox
tjiuming edited a comment on pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#issuecomment-1017182206 > > Motivation > > Currently, there is no offload metrics for tiered storage, so it is very hard for us to debug the performance issues. For example , we can not

[GitHub] [pulsar] tjiuming commented on pull request #13833: Offloader metrics

2022-01-19 Thread GitBox
tjiuming commented on pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#issuecomment-1017182206 > > Motivation > > Currently, there is no offload metrics for tiered storage, so it is very hard for us to debug the performance issues. For example , we can not find why

[GitHub] [pulsar] Jason918 commented on a change in pull request #13225: PIP-135: Added Etcd MetadataStore implementation

2022-01-19 Thread GitBox
Jason918 commented on a change in pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#discussion_r788423233 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java ## @@ -0,0 +1,433 @@ +/** + * Licensed to the

[pulsar] branch branch-2.9 updated: Upgrade BK to 4.14.4 and Grpc to 1.42.1 (#13714)

2022-01-19 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.9 by this push: new 9bfbd08 Upgrade BK to 4.14.4 and Grpc

[GitHub] [pulsar] liangyepianzhou edited a comment on issue #13792: Got END_TXN response for request 2036419640951504857 error UnknownError

2022-01-19 Thread GitBox
liangyepianzhou edited a comment on issue #13792: URL: https://github.com/apache/pulsar/issues/13792#issuecomment-1017167591 ### Problem Description 1. TransactionBufferHandlerImpl sends EndTxn request, at this time topic is unloading. 2. The default timeout is 3 seconds, and a

[GitHub] [pulsar] liangyepianzhou edited a comment on issue #13792: Got END_TXN response for request 2036419640951504857 error UnknownError

2022-01-19 Thread GitBox
liangyepianzhou edited a comment on issue #13792: URL: https://github.com/apache/pulsar/issues/13792#issuecomment-1017167591 ### Problem Description 1. TransactionBufferHandlerImpl sends EndTxn request, at this time topic is unloading. 2. The default timeout is 3 seconds, and a

[GitHub] [pulsar] liangyepianzhou commented on issue #13792: Got END_TXN response for request 2036419640951504857 error UnknownError

2022-01-19 Thread GitBox
liangyepianzhou commented on issue #13792: URL: https://github.com/apache/pulsar/issues/13792#issuecomment-1017167591 ### Problem Description 1. TransactionBufferHandlerImpl sends EndTxn request, at this time topic is unloading. 2. The default timeout is 3 seconds, and a timeout

[pulsar] branch master updated (07541e3 -> 96e98fc)

2022-01-19 Thread hrsakai
This is an automated email from the ASF dual-hosted git repository. hrsakai pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 07541e3 [Metadata] Print thread dump to log when Zookeeper session expires to detect possible deadlocks (#13124)

[GitHub] [pulsar] mattisonchao commented on pull request #13845: [Broker] Fix call sync method in async rest api for internalUnloadTopic

2022-01-19 Thread GitBox
mattisonchao commented on pull request #13845: URL: https://github.com/apache/pulsar/pull/13845#issuecomment-1017166800 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] nodece commented on a change in pull request #13297: Add schema compatibility strategy on topic level

2022-01-19 Thread GitBox
nodece commented on a change in pull request #13297: URL: https://github.com/apache/pulsar/pull/13297#discussion_r788400784 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java ## @@ -205,6 +217,33 @@ protected void

[GitHub] [pulsar] hrsakai merged pull request #13644: Rename test file name from `*Test2.java` to `*Test.java` to run all tests correctly

2022-01-19 Thread GitBox
hrsakai merged pull request #13644: URL: https://github.com/apache/pulsar/pull/13644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] mattisonchao commented on a change in pull request #13846: [Broker] Fix call sync method in async rest api for internalGetSubscriptions

2022-01-19 Thread GitBox
mattisonchao commented on a change in pull request #13846: URL: https://github.com/apache/pulsar/pull/13846#discussion_r788393831 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1044,72 +1044,81 @@ protected void

[GitHub] [pulsar] lmj199053 opened a new issue #13851: Transaction pending ack generate managedLedgerStats fail!

2022-01-19 Thread GitBox
lmj199053 opened a new issue #13851: URL: https://github.com/apache/pulsar/issues/13851 I use the helm to deploy the pulsar 2.8.3. This is the broker's log. 06:30:43.212 [prometheus-stats-42-1] WARN org.apache.pulsar.broker.stats.prometheus.TransactionAggregator - Transaction

[GitHub] [pulsar] shibd commented on pull request #13850: Fix: LockManagerTest.updateValue is flaky

2022-01-19 Thread GitBox
shibd commented on pull request #13850: URL: https://github.com/apache/pulsar/pull/13850#issuecomment-1017159190 @Jason918 @Technoboy- @codelipenghui Hi, Can you help me review it again? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Jason918 commented on a change in pull request #13297: Add schema compatibility strategy on topic level

2022-01-19 Thread GitBox
Jason918 commented on a change in pull request #13297: URL: https://github.com/apache/pulsar/pull/13297#discussion_r788386805 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java ## @@ -205,6 +217,33 @@ protected void

[GitHub] [pulsar] shibd opened a new pull request #13850: fix: LockManagerTest.updateValue is flaky

2022-01-19 Thread GitBox
shibd opened a new pull request #13850: URL: https://github.com/apache/pulsar/pull/13850 ### Motivation #13663 Flaky-test: org.apache.pulsar.metadata.LockManagerTest.updateValue The reasons are discussed in detail in this PR(#13725) This is mainly caused by the callback

[GitHub] [pulsar] mattisonchao commented on a change in pull request #13805: [Broker] Fix call sync method in async rest api for ``internalDeletePartitionedTopic``

2022-01-19 Thread GitBox
mattisonchao commented on a change in pull request #13805: URL: https://github.com/apache/pulsar/pull/13805#discussion_r788375447 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java ## @@ -866,23 +866,42 @@ public void

[GitHub] [pulsar] liudezhi2098 commented on pull request #13771: [broker] Fix topic produced through REST not support Authorization

2022-01-19 Thread GitBox
liudezhi2098 commented on pull request #13771: URL: https://github.com/apache/pulsar/pull/13771#issuecomment-1017148616 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[pulsar] branch master updated (5ce099b -> 07541e3)

2022-01-19 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5ce099b [Doc] add descriptions for dispatchThrottlingRate related configuration (#13829) add 07541e3

[GitHub] [pulsar] lhotari commented on a change in pull request #13130: [Issue 13129] [pulsar-metadata] Add watchdog thread in metadata store and track long running tasks.

2022-01-19 Thread GitBox
lhotari commented on a change in pull request #13130: URL: https://github.com/apache/pulsar/pull/13130#discussion_r788366446 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java ## @@ -317,7 +346,33 @@ public void

[GitHub] [pulsar] lhotari merged pull request #13124: [Metadata] Log thread dump when Zookeeper session expires to help detect possible deadlocks

2022-01-19 Thread GitBox
lhotari merged pull request #13124: URL: https://github.com/apache/pulsar/pull/13124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on issue #13849: Flaky-test: C++ ProducerTest.testSendAsyncCloseAsyncConcurrentlyWithLazyProducers

2022-01-19 Thread GitBox
lhotari commented on issue #13849: URL: https://github.com/apache/pulsar/issues/13849#issuecomment-1017138912 @BewareMyPower Do you have a chance to check this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] lhotari opened a new issue #13849: Flaky-test: C++ ProducerTest.testSendAsyncCloseAsyncConcurrentlyWithLazyProducers

2022-01-19 Thread GitBox
lhotari opened a new issue #13849: URL: https://github.com/apache/pulsar/issues/13849 ProducerTest.testSendAsyncCloseAsyncConcurrentlyWithLazyProducers fails sporadically. [example failure](https://github.com/apache/pulsar/runs/4877678504?check_suite_focus=true#step:11:748)

[GitHub] [pulsar] liangyuanpeng edited a comment on issue #13721: The topic monitoring information is incorrect

2022-01-19 Thread GitBox
liangyuanpeng edited a comment on issue #13721: URL: https://github.com/apache/pulsar/issues/13721#issuecomment-1017138047 Is it possible of try to upgrade pulsar to 2.8.x or more hight version for check it? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] liangyuanpeng commented on issue #13721: The topic monitoring information is incorrect

2022-01-19 Thread GitBox
liangyuanpeng commented on issue #13721: URL: https://github.com/apache/pulsar/issues/13721#issuecomment-1017138047 Is it possible of try to upgrade pulsar to 2.8.x or more hight version for check it. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] mattisonchao commented on a change in pull request #13845: [Broker] Fix call sync method in async rest api for internalUnloadTopic

2022-01-19 Thread GitBox
mattisonchao commented on a change in pull request #13845: URL: https://github.com/apache/pulsar/pull/13845#discussion_r788363349 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -714,70 +714,73 @@ protected void

[GitHub] [pulsar] RobertIndie commented on pull request #13786: [WebSocket] Add configuration metadata store url setting in websocket

2022-01-19 Thread GitBox
RobertIndie commented on pull request #13786: URL: https://github.com/apache/pulsar/pull/13786#issuecomment-1017133730 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] michaeljmarshall commented on pull request #13833: Offloader metrics

2022-01-19 Thread GitBox
michaeljmarshall commented on pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#issuecomment-1017131613 > Motivation > Currently, there is no offload metrics for tiered storage, so it is very hard for us to debug the performance issues. For example , we can not find

[GitHub] [pulsar] nodece commented on a change in pull request #13297: Add schema compatibility strategy on topic level

2022-01-19 Thread GitBox
nodece commented on a change in pull request #13297: URL: https://github.com/apache/pulsar/pull/13297#discussion_r788359343 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java ## @@ -205,6 +217,33 @@ protected void

[GitHub] [pulsar] michaeljmarshall opened a new pull request #13848: Remove unnecessary documentation of pulsar-dashboard

2022-01-19 Thread GitBox
michaeljmarshall opened a new pull request #13848: URL: https://github.com/apache/pulsar/pull/13848 ### Motivation `pulsar-dashboard` and its docker image were removed a while ago: https://github.com/apache/pulsar/pull/11284 and https://github.com/apache/pulsar/pull/11657.

[GitHub] [pulsar] michaeljmarshall commented on pull request #13376: Make Docker images non-root, by default, and OpenShift compliant

2022-01-19 Thread GitBox
michaeljmarshall commented on pull request #13376: URL: https://github.com/apache/pulsar/pull/13376#issuecomment-1017118608 @Anonymitaet and @eolivelli - in my most recent commit, I added documentation for this feature and how to debug in light of it. A majority of the documentation is in

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13845: [Broker] Fix call sync method in async rest api for internalUnloadTopic

2022-01-19 Thread GitBox
codelipenghui commented on a change in pull request #13845: URL: https://github.com/apache/pulsar/pull/13845#discussion_r788346085 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -714,70 +714,73 @@ protected void

[GitHub] [pulsar] lhotari commented on a change in pull request #13839: [Broker] Use shared executors for broker and geo-replication clients

2022-01-19 Thread GitBox
lhotari commented on a change in pull request #13839: URL: https://github.com/apache/pulsar/pull/13839#discussion_r788347481 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -245,6 +245,13 @@ ) private int

[pulsar-client-go] branch master updated: Fix negative WaitGroup counter issue (#712)

2022-01-19 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 90305e8 Fix negative WaitGroup counter

[GitHub] [pulsar-client-go] wolfstudy closed issue #711: Send func panic

2022-01-19 Thread GitBox
wolfstudy closed issue #711: URL: https://github.com/apache/pulsar-client-go/issues/711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] wolfstudy merged pull request #712: Fix negative WaitGroup counter issue

2022-01-19 Thread GitBox
wolfstudy merged pull request #712: URL: https://github.com/apache/pulsar-client-go/pull/712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on a change in pull request #13839: [Broker] Use shared executors for broker and geo-replication clients

2022-01-19 Thread GitBox
lhotari commented on a change in pull request #13839: URL: https://github.com/apache/pulsar/pull/13839#discussion_r788342535 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -245,6 +245,13 @@ ) private int

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13840: [Branch-2.9] Fix SystemTopicBasedTopicPoliciesService NPE issue.

2022-01-19 Thread GitBox
codelipenghui commented on a change in pull request #13840: URL: https://github.com/apache/pulsar/pull/13840#discussion_r788342101 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java ## @@ -234,6 +233,7 @@

[GitHub] [pulsar] dlg99 commented on a change in pull request #13716: Updating dependencies (guava and what brought in older guava) to get rid of the guava-related CVE-2018-10237 and CVE-2020-8908

2022-01-19 Thread GitBox
dlg99 commented on a change in pull request #13716: URL: https://github.com/apache/pulsar/pull/13716#discussion_r788341052 ## File path: pom.xml ## @@ -576,26 +576,10 @@ flexible messaging model and an intuitive client API. org.eclipse.jetty -

[GitHub] [pulsar] dlg99 commented on pull request #13716: Updating dependencies (guava and what brought in older guava) to get rid of the guava-related CVE-2018-10237 and CVE-2020-8908

2022-01-19 Thread GitBox
dlg99 commented on pull request #13716: URL: https://github.com/apache/pulsar/pull/13716#issuecomment-1017109161 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] lhotari commented on a change in pull request #13839: [Broker] Use shared executors for broker and geo-replication clients

2022-01-19 Thread GitBox
lhotari commented on a change in pull request #13839: URL: https://github.com/apache/pulsar/pull/13839#discussion_r788340956 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -245,6 +245,13 @@ ) private int

[GitHub] [pulsar] dlg99 commented on a change in pull request #13716: Updating dependencies (guava and what brought in older guava) to get rid of the guava-related CVE-2018-10237 and CVE-2020-8908

2022-01-19 Thread GitBox
dlg99 commented on a change in pull request #13716: URL: https://github.com/apache/pulsar/pull/13716#discussion_r788340186 ## File path: pulsar-io/flume/pom.xml ## @@ -106,7 +125,7 @@ com.google.guava guava -18.0 +

[GitHub] [pulsar] dlg99 commented on a change in pull request #13716: Updating dependencies (guava and what brought in older guava) to get rid of the guava-related CVE-2018-10237 and CVE-2020-8908

2022-01-19 Thread GitBox
dlg99 commented on a change in pull request #13716: URL: https://github.com/apache/pulsar/pull/13716#discussion_r788338669 ## File path: src/owasp-dependency-check-suppressions.xml ## @@ -41,4 +41,96 @@ org\.apache\.zookeeper:.*:3\.6\.2 .* - \ No newline at end

[GitHub] [pulsar] dlg99 commented on pull request #13820: Getting rid of CVEs in batch-data-generator

2022-01-19 Thread GitBox
dlg99 commented on pull request #13820: URL: https://github.com/apache/pulsar/pull/13820#issuecomment-1017104230 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] dlg99 commented on pull request #13821: Getting rid of CVEs in InfluxDB connector

2022-01-19 Thread GitBox
dlg99 commented on pull request #13821: URL: https://github.com/apache/pulsar/pull/13821#issuecomment-1017104029 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] lhotari commented on a change in pull request #13716: Updating dependencies (guava and what brought in older guava) to get rid of the guava-related CVE-2018-10237 and CVE-2020-8908

2022-01-19 Thread GitBox
lhotari commented on a change in pull request #13716: URL: https://github.com/apache/pulsar/pull/13716#discussion_r788334656 ## File path: src/owasp-dependency-check-suppressions.xml ## @@ -41,4 +41,96 @@ org\.apache\.zookeeper:.*:3\.6\.2 .* - \ No newline at end

[GitHub] [pulsar] lhotari commented on a change in pull request #13716: Updating dependencies (guava and what brought in older guava) to get rid of the guava-related CVE-2018-10237 and CVE-2020-8908

2022-01-19 Thread GitBox
lhotari commented on a change in pull request #13716: URL: https://github.com/apache/pulsar/pull/13716#discussion_r788333123 ## File path: pom.xml ## @@ -576,26 +576,10 @@ flexible messaging model and an intuitive client API. org.eclipse.jetty -

[GitHub] [pulsar] Jason918 commented on a change in pull request #13297: Add schema compatibility strategy on topic level

2022-01-19 Thread GitBox
Jason918 commented on a change in pull request #13297: URL: https://github.com/apache/pulsar/pull/13297#discussion_r788332153 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java ## @@ -205,6 +217,33 @@ protected void

[GitHub] [pulsar] lhotari commented on a change in pull request #13716: Updating dependencies (guava and what brought in older guava) to get rid of the guava-related CVE-2018-10237 and CVE-2020-8908

2022-01-19 Thread GitBox
lhotari commented on a change in pull request #13716: URL: https://github.com/apache/pulsar/pull/13716#discussion_r788331695 ## File path: pulsar-io/flume/pom.xml ## @@ -106,7 +125,7 @@ com.google.guava guava -18.0 +

[GitHub] [pulsar-client-go] oryx2 commented on a change in pull request #611: feat: support multiple schema version for producer and consumer

2022-01-19 Thread GitBox
oryx2 commented on a change in pull request #611: URL: https://github.com/apache/pulsar-client-go/pull/611#discussion_r788329960 ## File path: pulsar/consumer_partition.go ## @@ -143,10 +144,61 @@ type partitionConsumer struct { dlq *dlqRouter log

[GitHub] [pulsar-client-go] oryx2 commented on a change in pull request #611: feat: support multiple schema version for producer and consumer

2022-01-19 Thread GitBox
oryx2 commented on a change in pull request #611: URL: https://github.com/apache/pulsar-client-go/pull/611#discussion_r788329230 ## File path: pulsar/consumer_partition.go ## @@ -143,10 +144,61 @@ type partitionConsumer struct { dlq *dlqRouter log

[GitHub] [pulsar-client-go] oryx2 commented on a change in pull request #611: feat: support multiple schema version for producer and consumer

2022-01-19 Thread GitBox
oryx2 commented on a change in pull request #611: URL: https://github.com/apache/pulsar-client-go/pull/611#discussion_r788328382 ## File path: pulsar/internal/lookup_service.go ## @@ -358,6 +378,9 @@ func (h *httpLookupService) GetTopicsOfNamespace(namespace string, mode

[GitHub] [pulsar] Jason918 commented on a change in pull request #13805: [Broker] Fix call sync method in async rest api for ``internalDeletePartitionedTopic``

2022-01-19 Thread GitBox
Jason918 commented on a change in pull request #13805: URL: https://github.com/apache/pulsar/pull/13805#discussion_r788318539 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java ## @@ -866,23 +866,42 @@ public void

[GitHub] [pulsar] RobertIndie commented on pull request #13786: [WebSocket] Add configuration metadata store url setting in websocket

2022-01-19 Thread GitBox
RobertIndie commented on pull request #13786: URL: https://github.com/apache/pulsar/pull/13786#issuecomment-1017077718 > Hi @RobertIndie I've removed `doc-required` and added `doc-added` since the doc has been added. Please pay attention to this next time, thanks! Thanks. >

[GitHub] [pulsar] Anonymitaet commented on pull request #13811: [WIP][Doc] add docs for shedding strategy

2022-01-19 Thread GitBox
Anonymitaet commented on pull request #13811: URL: https://github.com/apache/pulsar/pull/13811#issuecomment-1017072416 @hangc0276 @Huanli-Meng @momo-jun could you please help review? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar-client-go] oryx2 commented on a change in pull request #611: feat: support multiple schema version for producer and consumer

2022-01-19 Thread GitBox
oryx2 commented on a change in pull request #611: URL: https://github.com/apache/pulsar-client-go/pull/611#discussion_r788311692 ## File path: pulsar/producer_partition.go ## @@ -397,19 +460,48 @@ func (p *partitionProducer) internalSend(request *sendRequest) { msg :=

[GitHub] [pulsar] zxJin-x commented on a change in pull request #13502: Optimize the exception log is not printed

2022-01-19 Thread GitBox
zxJin-x commented on a change in pull request #13502: URL: https://github.com/apache/pulsar/pull/13502#discussion_r787294027 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsServlet.java ## @@ -100,8 +100,7 @@ protected void

[GitHub] [pulsar] gaozhangmin commented on pull request #12025: violation of isolation when using bookie affinity group

2022-01-19 Thread GitBox
gaozhangmin commented on pull request #12025: URL: https://github.com/apache/pulsar/pull/12025#issuecomment-1017070420 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] gaoran10 commented on a change in pull request #13837: [Broker] Avoid thread deadlock problem when creating topic policy reader

2022-01-19 Thread GitBox
gaoran10 commented on a change in pull request #13837: URL: https://github.com/apache/pulsar/pull/13837#discussion_r788306929 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/util/RetryUtil.java ## @@ -43,26 +43,28 @@

[GitHub] [pulsar] gaoran10 commented on a change in pull request #13837: [Broker] Avoid thread deadlock problem when creating topic policy reader

2022-01-19 Thread GitBox
gaoran10 commented on a change in pull request #13837: URL: https://github.com/apache/pulsar/pull/13837#discussion_r788306929 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/util/RetryUtil.java ## @@ -43,26 +43,28 @@

[GitHub] [pulsar] gaoran10 commented on a change in pull request #13771: [broker] Fix topic produced through REST not support Authorization

2022-01-19 Thread GitBox
gaoran10 commented on a change in pull request #13771: URL: https://github.com/apache/pulsar/pull/13771#discussion_r788305055 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicsAuthTest.java ## @@ -0,0 +1,236 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] gaoran10 commented on a change in pull request #13771: [broker] Fix topic produced through REST not support Authorization

2022-01-19 Thread GitBox
gaoran10 commented on a change in pull request #13771: URL: https://github.com/apache/pulsar/pull/13771#discussion_r788303818 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicsAuthTest.java ## @@ -0,0 +1,236 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] Anonymitaet commented on pull request #13844: Fix managed cursor acknowledgment state metric names

2022-01-19 Thread GitBox
Anonymitaet commented on pull request #13844: URL: https://github.com/apache/pulsar/pull/13844#issuecomment-1017058969 Hi @Demogorgon314 can you review this PR from the technical perspective? Thanks -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13838: [DOCS] Update Messaging doc

2022-01-19 Thread GitBox
Anonymitaet commented on a change in pull request #13838: URL: https://github.com/apache/pulsar/pull/13838#discussion_r788299243 ## File path: site2/docs/concepts-messaging.md ## @@ -202,46 +214,66 @@

[pulsar] branch master updated (d42d30e -> 5ce099b)

2022-01-19 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from d42d30e Enable check style plugin in pulsar sql module (#13781) add 5ce099b [Doc] add descriptions for

[GitHub] [pulsar] Anonymitaet merged pull request #13829: [Doc] add descriptions for dispatchThrottlingRate related configuration

2022-01-19 Thread GitBox
Anonymitaet merged pull request #13829: URL: https://github.com/apache/pulsar/pull/13829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nlu90 commented on pull request #13748: fix checkstyle for tired-storage, websocket and bc modules

2022-01-19 Thread GitBox
nlu90 commented on pull request #13748: URL: https://github.com/apache/pulsar/pull/13748#issuecomment-1017048452 @codelipenghui Please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Anonymitaet commented on pull request #13829: [Doc] add descriptions for dispatchThrottlingRate related configuration

2022-01-19 Thread GitBox
Anonymitaet commented on pull request #13829: URL: https://github.com/apache/pulsar/pull/13829#issuecomment-1017047533 @Demogorgon314 can you review this PR from the technical perspective? Thanks -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #13771: [broker] Fix topic produced through REST not support Authorization

2022-01-19 Thread GitBox
Demogorgon314 commented on a change in pull request #13771: URL: https://github.com/apache/pulsar/pull/13771#discussion_r788292373 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicsAuthTest.java ## @@ -0,0 +1,244 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #13771: [broker] Fix topic produced through REST not support Authorization

2022-01-19 Thread GitBox
Demogorgon314 commented on a change in pull request #13771: URL: https://github.com/apache/pulsar/pull/13771#discussion_r788291010 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicsAuthTest.java ## @@ -0,0 +1,244 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] Anonymitaet closed issue #13818: [Doc] Broken links on "concepts-messaging" page

2022-01-19 Thread GitBox
Anonymitaet closed issue #13818: URL: https://github.com/apache/pulsar/issues/13818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] mattisonchao opened a new pull request #13847: [Broker] Fix call sync method in async rest api for internalGetManagedLedgerInfo

2022-01-19 Thread GitBox
mattisonchao opened a new pull request #13847: URL: https://github.com/apache/pulsar/pull/13847 ### Motivation Avoid call sync method in async rest API for PersistentTopicsBase#internalGetManagedLedgerInfo. ### Modifications - Use async instead of sync method.

[pulsar] branch master updated (d9faf78 -> d42d30e)

2022-01-19 Thread shoothzj
This is an automated email from the ASF dual-hosted git repository. shoothzj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from d9faf78 enable checkStyle plugin in pulsar-sql module (#13783) add d42d30e Enable check style plugin in

[GitHub] [pulsar] xiaobing0508 commented on issue #13835: Bookies quarantine problems.

2022-01-19 Thread GitBox
xiaobing0508 commented on issue #13835: URL: https://github.com/apache/pulsar/issues/13835#issuecomment-1017033147 So the setting won't cause this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[pulsar] branch master updated (b0c7259 -> d9faf78)

2022-01-19 Thread shoothzj
This is an automated email from the ASF dual-hosted git repository. shoothzj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b0c7259 Remove --illegal-access errors resulting from Google Guice (upgrade to 5.0.1) (#13810) add d9faf78

[GitHub] [pulsar] mattisonchao opened a new pull request #13846: [Broker] Fix call sync method in async rest api for internalGetSubscriptions

2022-01-19 Thread GitBox
mattisonchao opened a new pull request #13846: URL: https://github.com/apache/pulsar/pull/13846 ### Motivation Avoid call sync method in async rest API for PersistentTopicsBase#internalGetSubscriptions. ### Modifications - Use async instead of sync method. ###

[GitHub] [pulsar] Shoothzj merged pull request #13781: Enable check style plugin in pulsar sql module

2022-01-19 Thread GitBox
Shoothzj merged pull request #13781: URL: https://github.com/apache/pulsar/pull/13781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >