[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #15474: [fix][broker] Fix cannot cleanup expired ledger by trim ledgers

2022-05-06 Thread GitBox
gaozhangmin commented on code in PR #15474: URL: https://github.com/apache/pulsar/pull/15474#discussion_r867295498 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -2287,20 +2289,22 @@ public void

[GitHub] [pulsar] Shoothzj opened a new pull request, #15483: [security] Remove sensitive msg from consumer/producer stats log

2022-05-06 Thread GitBox
Shoothzj opened a new pull request, #15483: URL: https://github.com/apache/pulsar/pull/15483 ### Motivation Currently, we are print password field to consumer/producer stats log ### Modification - add missed `@JsonIgnore` on field and getMethod - delete unused

[GitHub] [pulsar] lhotari commented on pull request #15264: [improve][build] PIP-156 Build Pulsar Server on Java 17

2022-05-06 Thread GitBox
lhotari commented on PR #15264: URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1120134526 There's also a need to simplify the pom.xml . Previous the build has been compatible with Java 8 & Java 11 and that has been handled with the jdk11 maven profile. Since Java 17+ will be

[GitHub] [pulsar] lhotari commented on pull request #15264: [improve][build] PIP-156 Build Pulsar Server on Java 17

2022-05-06 Thread GitBox
lhotari commented on PR #15264: URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1120133602 > Thank you for further simplifying this CI test workflow change. I am ok with that. @heesung-sn I have synchronized my changes to this PR. I reverted the change that

[GitHub] [pulsar] liudezhi2098 commented on pull request #15467: [enhancement][function-work] Suggestion put authenticateMetricsEndpoint in functions_worker.yml

2022-05-06 Thread GitBox
liudezhi2098 commented on PR #15467: URL: https://github.com/apache/pulsar/pull/15467#issuecomment-1120132719 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] poorbarcode commented on pull request #15479: [improve][client] Stop flush ack when the client reconnects.

2022-05-06 Thread GitBox
poorbarcode commented on PR #15479: URL: https://github.com/apache/pulsar/pull/15479#issuecomment-1120124366 > Do you mean we prevent the flush when consumers close? When close consumer, will trig flush once:

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #15457: [broker]Fix subscribeRateLimiter not close

2022-05-06 Thread GitBox
AnonHxy commented on code in PR #15457: URL: https://github.com/apache/pulsar/pull/15457#discussion_r867296763 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -446,13 +442,21 @@ public void publishMessage(ByteBuf

[GitHub] [pulsar] Jason918 commented on a diff in pull request #15412: [fix][Broker] NarUnpacker create directory and file without permission check

2022-05-06 Thread GitBox
Jason918 commented on code in PR #15412: URL: https://github.com/apache/pulsar/pull/15412#discussion_r863791836 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/RocksdbMetadataStore.java: ## @@ -220,6 +223,8 @@ private RocksdbMetadataStore(String metadataURL,

[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #15474: [fix][broker] Fix cannot cleanup expired ledger by trim ledgers

2022-05-06 Thread GitBox
gaozhangmin commented on code in PR #15474: URL: https://github.com/apache/pulsar/pull/15474#discussion_r867295498 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -2287,20 +2289,22 @@ public void

[GitHub] [pulsar] Nicklee007 commented on pull request #15474: [fix][broker] Fix cannot cleanup expired ledger by trim ledgers

2022-05-06 Thread GitBox
Nicklee007 commented on PR #15474: URL: https://github.com/apache/pulsar/pull/15474#issuecomment-1120120685 @mattisonchao For clean expire ledger data, and the loaded topic need at least one ledger, this PR changes the behavior of rollCurrentLedgerIfFull, readd

[GitHub] [pulsar] mattisonchao commented on pull request #15479: [improve][client] Stop flush ack when the client reconnects.

2022-05-06 Thread GitBox
mattisonchao commented on PR #15479: URL: https://github.com/apache/pulsar/pull/15479#issuecomment-1120120255 Hi, @poorbarcode Do you mean we prevent the flush when consumers close? I think we could add a parameter like if allowed force flush like this to solve this problem.

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #15457: [broker]Fix subscribeRateLimiter not close

2022-05-06 Thread GitBox
AnonHxy commented on code in PR #15457: URL: https://github.com/apache/pulsar/pull/15457#discussion_r867294077 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/SubscribeRateLimiter.java: ## @@ -140,6 +140,9 @@ private synchronized void

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #15457: [broker]Fix subscribeRateLimiter not close

2022-05-06 Thread GitBox
AnonHxy commented on code in PR #15457: URL: https://github.com/apache/pulsar/pull/15457#discussion_r867294077 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/SubscribeRateLimiter.java: ## @@ -140,6 +140,9 @@ private synchronized void

[GitHub] [pulsar] Nicklee007 commented on pull request #15474: [fix][broker] Fix cannot cleanup expired ledger by trim ledgers

2022-05-06 Thread GitBox
Nicklee007 commented on PR #15474: URL: https://github.com/apache/pulsar/pull/15474#issuecomment-1120119651 > Good catch. This patch solved the problem to some extent, I think the solution is that the newly created persistent subscription 'cursor position' is always greater than

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15472: [Fix][txn] Make transaction stats consistent at end txn

2022-05-06 Thread GitBox
liangyepianzhou commented on code in PR #15472: URL: https://github.com/apache/pulsar/pull/15472#discussion_r867293738 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java: ## @@ -374,8 +374,8 @@ public

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15410: [improve][CLI] Support filtering system topic when get list.

2022-05-06 Thread GitBox
Technoboy- commented on code in PR #15410: URL: https://github.com/apache/pulsar/pull/15410#discussion_r867293733 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/NonPersistentTopics.java: ## @@ -428,6 +430,8 @@ public void getList( final List

[GitHub] [pulsar] mattisonchao closed pull request #15479: [improve][client] Stop flush ack when the client reconnects.

2022-05-06 Thread GitBox
mattisonchao closed pull request #15479: [improve][client] Stop flush ack when the client reconnects. URL: https://github.com/apache/pulsar/pull/15479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] momo-jun commented on issue #14705: what is the mean skipListArenaChunkSize,skipListArenaMaxAllocSize,skipListSizeLimit

2022-05-06 Thread GitBox
momo-jun commented on issue #14705: URL: https://github.com/apache/pulsar/issues/14705#issuecomment-1120115329 Hi @armandxu, the explanation for `skipListArenaChunkSize` and `skipListArenaMaxAllocSize` can also be found in https://pulsar.apache.org/docs/en/reference-configuration/.

[GitHub] [pulsar] Jason918 commented on a diff in pull request #15457: [broker]Fix subscribeRateLimiter not close

2022-05-06 Thread GitBox
Jason918 commented on code in PR #15457: URL: https://github.com/apache/pulsar/pull/15457#discussion_r867289507 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/SubscribeRateLimiter.java: ## @@ -140,6 +140,9 @@ private synchronized void

[GitHub] [pulsar] mattisonchao commented on issue #15452: allowAutoTopicCreation has weird behavior

2022-05-06 Thread GitBox
mattisonchao commented on issue #15452: URL: https://github.com/apache/pulsar/issues/15452#issuecomment-1120115004 Hi, @KannarFr Could you try using `pulsar-admin` to test it? it's not related to `pulsarctl.` @nodece Could you have time to help check this issue? /cc

[GitHub] [pulsar] Nicklee007 commented on pull request #13974: [broker] clean inactive bundle from bundleData in loadData and bundlesCache

2022-05-06 Thread GitBox
Nicklee007 commented on PR #13974: URL: https://github.com/apache/pulsar/pull/13974#issuecomment-1120112856 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] shibd opened a new pull request, #15482: [Connector] Add getSinkConfig method to SinkContext

2022-05-06 Thread GitBox
shibd opened a new pull request, #15482: URL: https://github.com/apache/pulsar/pull/15482 ### Motivation The configuration of SinkConfig is rich, and the user can flexibly specify it when registry the sink. But some sinks do not support these configurations, for example we want to

[GitHub] [pulsar] Nicklee007 commented on pull request #13974: [broker] clean inactive bundle from bundleData in loadData and bundlesCache

2022-05-06 Thread GitBox
Nicklee007 commented on PR #13974: URL: https://github.com/apache/pulsar/pull/13974#issuecomment-1120112628 > @Nicklee007 I just left one little comment, please address the comment and resolve the conflicts. Thanks a lot. @hangc0276 Has resolve the conflicts and update the import

[pulsar] branch master updated: [CLEANUP] delete unused log4j.properties in pulsar proxy (#15199)

2022-05-06 Thread shoothzj
This is an automated email from the ASF dual-hosted git repository. shoothzj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9b4df2cb528 [CLEANUP] delete unused

[GitHub] [pulsar] Shoothzj merged pull request #15199: [CLEANUP] delete unused log4j.properties in pulsar proxy

2022-05-06 Thread GitBox
Shoothzj merged PR #15199: URL: https://github.com/apache/pulsar/pull/15199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] momo-jun commented on pull request #15481: [fix][doc] Remove tab style for data offload tutorials

2022-05-06 Thread GitBox
momo-jun commented on PR #15481: URL: https://github.com/apache/pulsar/pull/15481#issuecomment-1120111674 @liangyepianzhou @Anonymitaet can you pls review this doc PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] github-actions[bot] commented on issue #13788: Broker keep logging Mark deleting an already mark-deleted position

2022-05-06 Thread GitBox
github-actions[bot] commented on issue #13788: URL: https://github.com/apache/pulsar/issues/13788#issuecomment-1120110226 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on pull request #14903: [metadata] fix MetadataStore#put may get unexcepted exception

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #14903: URL: https://github.com/apache/pulsar/pull/14903#issuecomment-1120109916 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #15027: Having two KeyValue classes is confusing

2022-05-06 Thread GitBox
github-actions[bot] commented on issue #15027: URL: https://github.com/apache/pulsar/issues/15027#issuecomment-1120109849 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #15035: [Doc] Java client examples for protobuf native schema

2022-05-06 Thread GitBox
github-actions[bot] commented on issue #15035: URL: https://github.com/apache/pulsar/issues/15035#issuecomment-1120109835 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on pull request #15481: [fix][doc] Remove tab style for data offload tutorials

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #15481: URL: https://github.com/apache/pulsar/pull/15481#issuecomment-1120109719 @momo-jun:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] github-actions[bot] commented on pull request #15481: [fix][doc] Remove tab style for data offload tutorials

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #15481: URL: https://github.com/apache/pulsar/pull/15481#issuecomment-1120109618 @momo-jun:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] momo-jun opened a new pull request, #15481: [fix][doc] Remove tab style for data offload tutorials

2022-05-06 Thread GitBox
momo-jun opened a new pull request, #15481: URL: https://github.com/apache/pulsar/pull/15481 ### Motivation The current tutorials for data offload use the docusaurus tab style to contain content for both HDFS and NFS. However, it is misleading people because the headings shown in

[pulsar] branch master updated: PIP-74 add support consumer client memory limit (#15216)

2022-05-06 Thread jianghaiting
This is an automated email from the ASF dual-hosted git repository. jianghaiting pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1a098d5418b PIP-74 add support consumer

[GitHub] [pulsar] Jason918 merged pull request #15216: [PIP-74] Support consumer client memory limit

2022-05-06 Thread GitBox
Jason918 merged PR #15216: URL: https://github.com/apache/pulsar/pull/15216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Jason918 commented on a diff in pull request #15216: [PIP-74] Support consumer client memory limit

2022-05-06 Thread GitBox
Jason918 commented on code in PR #15216: URL: https://github.com/apache/pulsar/pull/15216#discussion_r867287493 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MemoryLimitController.java: ## @@ -45,11 +60,18 @@ public boolean tryReserveMemory(long size) {

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15472: [Fix][txn] Make transaction stats consistent at end txn

2022-05-06 Thread GitBox
liangyepianzhou commented on code in PR #15472: URL: https://github.com/apache/pulsar/pull/15472#discussion_r867287216 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java: ## @@ -374,8 +374,8 @@ public

[GitHub] [pulsar] AnonHxy commented on pull request #15457: [broker]Fix subscribeRateLimiter not close

2022-05-06 Thread GitBox
AnonHxy commented on PR #15457: URL: https://github.com/apache/pulsar/pull/15457#issuecomment-1120106234 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] poorbarcode commented on pull request #15479: [improve][client] Stop flush ack when the client reconnects.

2022-05-06 Thread GitBox
poorbarcode commented on PR #15479: URL: https://github.com/apache/pulsar/pull/15479#issuecomment-1120105589 This may lead to an increased probability of repeated consumption (the client can stop at any time, resulting in the loss of requests already submitted by the user). We should do

[GitHub] [pulsar] Nicklee007 commented on pull request #13974: [broker] clean inactive bundle from bundleData in loadData and bundlesCache

2022-05-06 Thread GitBox
Nicklee007 commented on PR #13974: URL: https://github.com/apache/pulsar/pull/13974#issuecomment-1120105521 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] poorbarcode commented on pull request #15474: [fix][broker] Fix cannot cleanup expired ledger by trim ledgers

2022-05-06 Thread GitBox
poorbarcode commented on PR #15474: URL: https://github.com/apache/pulsar/pull/15474#issuecomment-1120102937 Good catch. This patch solved the problem to some extent, I think the solution is that the newly created persistent subscription 'cursor position' is always greater than

[GitHub] [pulsar] casuallc opened a new issue, #15480: ClassCastException when create message instance

2022-05-06 Thread GitBox
casuallc opened a new issue, #15480: URL: https://github.com/apache/pulsar/issues/15480 **Describe the bug** Message instance create exception when doing open-messaging tests. May be thread safe error. **Screenshots**

[pulsar] branch master updated: Revert "Fix: LockManagerTest.updateValue is flaky (#13911)" (#15235)

2022-05-06 Thread mattisonchao
This is an automated email from the ASF dual-hosted git repository. mattisonchao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 306a0a11c94 Revert "Fix:

[GitHub] [pulsar] mattisonchao merged pull request #15235: Revert "Fix: LockManagerTest.updateValue is flaky (#13911)"

2022-05-06 Thread GitBox
mattisonchao merged PR #15235: URL: https://github.com/apache/pulsar/pull/15235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] mattisonchao opened a new pull request, #15479: [improve][client] Stop flush ack when the client reconnects.

2022-05-06 Thread GitBox
mattisonchao opened a new pull request, #15479: URL: https://github.com/apache/pulsar/pull/15479 ### Motivation Current, we use PersistentAcknowledgmentsGroupingTracker#isDuplicate to do our best effort to deduplicate messages. the original comments as below: ``` Since

[GitHub] [pulsar] zbentley commented on pull request #15436: [python] [build system] Improve MacOS Wheel Building with Pyenv and Rosetta

2022-05-06 Thread GitBox
zbentley commented on PR #15436: URL: https://github.com/apache/pulsar/pull/15436#issuecomment-1120076870 @merlimat when convenient could you attach one of the pyenv build log files mentioned in the error snippet you posted? -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] heesung-sn commented on pull request #15264: [improve][build] PIP-156 Build Pulsar Server on Java 17

2022-05-06 Thread GitBox
heesung-sn commented on PR #15264: URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1120050175 > @heesung-sn I reviewed the changes and since it would have been too hard to explain the details, I have push changes to an experiment that I'm running in my fork, it's

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #15462: Document waitTimeoutOnBackpressureMillis parameter for the BK client

2022-05-06 Thread GitBox
michaeljmarshall commented on code in PR #15462: URL: https://github.com/apache/pulsar/pull/15462#discussion_r867244689 ## conf/broker.conf: ## @@ -930,6 +930,22 @@ bookkeeperExplicitLacIntervalInMills=0 # Expose bookkeeper client managed ledger stats to prometheus. default is

[GitHub] [pulsar] github-actions[bot] commented on pull request #15478: PIP-117: Change Pulsar standalone defaults

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #15478: URL: https://github.com/apache/pulsar/pull/15478#issuecomment-1120041222 @merlimat:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] merlimat opened a new pull request, #15478: PIP-117: Change Pulsar standalone defaults

2022-05-06 Thread GitBox
merlimat opened a new pull request, #15478: URL: https://github.com/apache/pulsar/pull/15478 Master Issue: #13302 ### Motivation * Change standalone metadata impl from ZooKeeper to RocksDB * Pulsar functions package backend --> Change from using DistributedLog to

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#b5f8647)

2022-05-06 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 2ab4a760eb Docs sync done from

[GitHub] [pulsar] b0mbays opened a new issue, #15477: Python Pulsar-Client: Import error with Python 3.10

2022-05-06 Thread GitBox
b0mbays opened a new issue, #15477: URL: https://github.com/apache/pulsar/issues/15477 **Describe the bug** Hi, we're experiencing an import error when using Python 3.10 on OSX 11 and 12. We're installing the python pulsar-client-2.10.0 and having the same error on two machines:

[GitHub] [pulsar] Nicklee007 commented on pull request #13974: [broker] clean inactive bundle from bundleData in loadData and bundlesCache

2022-05-06 Thread GitBox
Nicklee007 commented on PR #13974: URL: https://github.com/apache/pulsar/pull/13974#issuecomment-1119807389 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] dlg99 commented on pull request #15462: Document waitTimeoutOnBackpressureMillis parameter for the BK client

2022-05-06 Thread GitBox
dlg99 commented on PR #15462: URL: https://github.com/apache/pulsar/pull/15462#issuecomment-1119805655 @michaeljmarshall @eolivelli it is just a conf file change now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[pulsar] branch master updated (cfbc9ea1b2a -> b5f8647ef9c)

2022-05-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from cfbc9ea1b2a [Function] Integrate package management service to pulsar functionWorker (#14450) add b5f8647ef9c

[GitHub] [pulsar] merlimat merged pull request #15459: [Python] Removed scripts to create wheel files in vagrant VMs

2022-05-06 Thread GitBox
merlimat merged PR #15459: URL: https://github.com/apache/pulsar/pull/15459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] merlimat merged pull request #14450: [Function] Integrate package management service to pulsar functionWorker

2022-05-06 Thread GitBox
merlimat merged PR #14450: URL: https://github.com/apache/pulsar/pull/14450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (ac6bd3c71e2 -> cfbc9ea1b2a)

2022-05-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from ac6bd3c71e2 [PIP 81] Part-1 Split createNewMetadataLedger into multiple methods for reuse (#15425) add

[GitHub] [pulsar] merlimat closed issue #14224: Integrate package service with function

2022-05-06 Thread GitBox
merlimat closed issue #14224: Integrate package service with function URL: https://github.com/apache/pulsar/issues/14224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] Nicklee007 commented on pull request #13974: [broker] clean inactive bundle from bundleData in loadData and bundlesCache

2022-05-06 Thread GitBox
Nicklee007 commented on PR #13974: URL: https://github.com/apache/pulsar/pull/13974#issuecomment-1119795186 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #15472: [Fix][txn] Make transaction stats consistent at end txn

2022-05-06 Thread GitBox
poorbarcode commented on code in PR #15472: URL: https://github.com/apache/pulsar/pull/15472#discussion_r866987981 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java: ## @@ -374,8 +374,8 @@ public

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #15472: [Fix][txn] Make transaction stats consistent at end txn

2022-05-06 Thread GitBox
poorbarcode commented on code in PR #15472: URL: https://github.com/apache/pulsar/pull/15472#discussion_r866987981 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java: ## @@ -374,8 +374,8 @@ public

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #15472: [Fix][txn] Make transaction stats consistent at end txn

2022-05-06 Thread GitBox
poorbarcode commented on code in PR #15472: URL: https://github.com/apache/pulsar/pull/15472#discussion_r866984589 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java: ## @@ -374,8 +374,8 @@ public

[GitHub] [pulsar] Paninka opened a new issue, #15476: JDBC Postgresql Error: This connection has been closed

2022-05-06 Thread GitBox
Paninka opened a new issue, #15476: URL: https://github.com/apache/pulsar/issues/15476 **Describe the bug** I'm using the JDBC driver to sink Postgresql, and when Postgresql stops It says that "This connection has been closed". When Postgresql starts again the sink doesn't work and it

[GitHub] [pulsar] horizonzy opened a new issue, #15475: PulsarAdmin maybe create nonPartitionTopic and partitionedTopic for same topic.

2022-05-06 Thread GitBox
horizonzy opened a new issue, #15475: URL: https://github.com/apache/pulsar/issues/15475 **Describe the bug** In PersistentTopics, there are two methods `createNonPartitionedTopic` and `createPartitionedTopic`. There is race condition, maybe create nonpartitioned and partitioned

[GitHub] [pulsar] Nicklee007 opened a new pull request, #15474: [fix][broker] Fix cannot cleanup expired ledger by trim ledgers

2022-05-06 Thread GitBox
Nicklee007 opened a new pull request, #15474: URL: https://github.com/apache/pulsar/pull/15474 Fixes #15473 ### Motivation The pr [#10087](https://github.com/apache/pulsar/pull/10087) has fixed some case expired data cannot cleanup, but in some other case the bug reappeared .

[GitHub] [pulsar] Nicklee007 opened a new issue, #15473: [Bug][broker] expired ledger cannot be cleanup when ledger consumed completely

2022-05-06 Thread GitBox
Nicklee007 opened a new issue, #15473: URL: https://github.com/apache/pulsar/issues/15473 **Describe the bug** In some case, expired ledger data cannot be cleanup when the topic has not new message and ledger consumed completely, because the slowestReaderPosition which set to the new

[GitHub] [pulsar] AnonHxy commented on pull request #15457: [broker]Fix subscribeRateLimiter not close

2022-05-06 Thread GitBox
AnonHxy commented on PR #15457: URL: https://github.com/apache/pulsar/pull/15457#issuecomment-1119746077 PTAL again, thx @poorbarcode @michaeljmarshall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #15410: [improve][CLI] Support filtering system topic when get list.

2022-05-06 Thread GitBox
gaoran10 commented on code in PR #15410: URL: https://github.com/apache/pulsar/pull/15410#discussion_r866943573 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/NonPersistentTopics.java: ## @@ -428,6 +430,8 @@ public void getList( final List

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #15457: [broker]Fix subscribeRateLimiter not close

2022-05-06 Thread GitBox
AnonHxy commented on code in PR #15457: URL: https://github.com/apache/pulsar/pull/15457#discussion_r866904843 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3090,6 +3094,7 @@ private void

[GitHub] [pulsar] hangc0276 commented on pull request #14887: [feature][admin] Support reset cluster replicator cursor

2022-05-06 Thread GitBox
hangc0276 commented on PR #14887: URL: https://github.com/apache/pulsar/pull/14887#issuecomment-1119700628 @mattisonchao Would you please rebase the master ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] poorbarcode commented on pull request #15468: Use unique consumer name when create sub

2022-05-06 Thread GitBox
poorbarcode commented on PR #15468: URL: https://github.com/apache/pulsar/pull/15468#issuecomment-1119696812 > Why break the subscribe rate limit policy? Maybe rewrite `ConsumerIdentifier.equals()` can solve the problem, but be compatible if the user has already set the

[GitHub] [pulsar] Shoothzj commented on issue #15471: NPE during get topic stats

2022-05-06 Thread GitBox
Shoothzj commented on issue #15471: URL: https://github.com/apache/pulsar/issues/15471#issuecomment-1119695125 @Technoboy- @equanz It's caused by using null value for comparator. When `isSupportsPartialProducer ` is false, `PublisherStatsImpl::getProducerName` return null. -- This is an

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #15137: [PIP-153][optimize][txn] Optimize metadataPositions in MLPendingAckStore

2022-05-06 Thread GitBox
codelipenghui commented on code in PR #15137: URL: https://github.com/apache/pulsar/pull/15137#discussion_r866894314 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java: ## @@ -292,6 +250,69 @@ public void

[GitHub] [pulsar] poorbarcode commented on pull request #15468: Use unique consumer name when create sub

2022-05-06 Thread GitBox
poorbarcode commented on PR #15468: URL: https://github.com/apache/pulsar/pull/15468#issuecomment-1119687627 > Why break the subscribe rate limit policy? In original design: the consumer returned by

[pulsar] branch master updated: [PIP 81] Part-1 Split createNewMetadataLedger into multiple methods for reuse (#15425)

2022-05-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ac6bd3c71e2 [PIP 81] Part-1 Split

[GitHub] [pulsar] codelipenghui merged pull request #15425: [PIP 81] Part-1 Split createNewMetadataLedger into multiple methods for reuse

2022-05-06 Thread GitBox
codelipenghui merged PR #15425: URL: https://github.com/apache/pulsar/pull/15425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] 315157973 commented on pull request #15425: [PIP 81] Part-1 Split createNewMetadataLedger into multiple methods for reuse

2022-05-06 Thread GitBox
315157973 commented on PR #15425: URL: https://github.com/apache/pulsar/pull/15425#issuecomment-1119680595 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #15472: [Fix][txn] Make transaction stats consistent at end txn

2022-05-06 Thread GitBox
codelipenghui commented on code in PR #15472: URL: https://github.com/apache/pulsar/pull/15472#discussion_r866875690 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java: ## @@ -374,8 +374,8 @@ public

[pulsar-client-go] branch master updated: Add consumer state check when request commands (#772)

2022-05-06 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 1e37f2f Add consumer state check when

[GitHub] [pulsar-client-go] wolfstudy merged pull request #772: Add consumer state check when request commands

2022-05-06 Thread GitBox
wolfstudy merged PR #772: URL: https://github.com/apache/pulsar-client-go/pull/772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] poorbarcode commented on pull request #15457: [broker]Fix subscribeRateLimiter not close

2022-05-06 Thread GitBox
poorbarcode commented on PR #15457: URL: https://github.com/apache/pulsar/pull/15457#issuecomment-1119663684 Method `updateSubscribeRateLimiter` should complement unit tests. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[pulsar] branch asf-site updated: Publish new charts to https://pulsar.apache.org/charts/

2022-05-06 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 98f6eea19db Publish new charts to

[pulsar-helm-chart] branch master updated: Add support for Horizontal Pod Autoscaling for Broker and Proxy. (#262)

2022-05-06 Thread addisonj
This is an automated email from the ASF dual-hosted git repository. addisonj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new bfb6985 Add support for

[pulsar-helm-chart] tag pulsar-2.9.3 created (now bfb6985)

2022-05-06 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to tag pulsar-2.9.3 in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git at bfb6985 (commit) No new revisions were added by this update.

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #15457: [broker]Fix subscribeRateLimiter not close

2022-05-06 Thread GitBox
poorbarcode commented on code in PR #15457: URL: https://github.com/apache/pulsar/pull/15457#discussion_r866861957 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -446,13 +442,21 @@ public void publishMessage(ByteBuf

[pulsar] branch master updated: [improve][doc] Support configurable transactionBufferClientOperationTimeoutInMills (#15438)

2022-05-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5c2700babdd [improve][doc] Support

[GitHub] [pulsar] codelipenghui merged pull request #15438: [improve][doc] Support configurable transactionBufferClientOperationTimeoutInMills

2022-05-06 Thread GitBox
codelipenghui merged PR #15438: URL: https://github.com/apache/pulsar/pull/15438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Shoothzj commented on issue #15471: NPE during get topic stats

2022-05-06 Thread GitBox
Shoothzj commented on issue #15471: URL: https://github.com/apache/pulsar/issues/15471#issuecomment-1119648292 @Technoboy- Sorry for misleading, we use pulsar nightly code for some tests. Not tests in pulsar repo. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] wolfstudy commented on pull request #15468: Use unique consumer name when create sub

2022-05-06 Thread GitBox
wolfstudy commented on PR #15468: URL: https://github.com/apache/pulsar/pull/15468#issuecomment-1119645915 > Hi @wolfstudy > > It seems rude to do so. It breaks the subscribe rate limit policy. > >

[GitHub] [pulsar] wolfstudy commented on pull request #15468: Use unique consumer name when create sub

2022-05-06 Thread GitBox
wolfstudy commented on PR #15468: URL: https://github.com/apache/pulsar/pull/15468#issuecomment-1119645406 > consumerName Why break the subscribe rate limit policy? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] codelipenghui commented on pull request #15413: [Java Client] Fix wrong behavior of deduplication for key based batching

2022-05-06 Thread GitBox
codelipenghui commented on PR #15413: URL: https://github.com/apache/pulsar/pull/15413#issuecomment-1119645118 Oh, I see. I thought the PR was for support deduplication for key-based batching before. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Technoboy- commented on issue #15471: NPE during get topic stats

2022-05-06 Thread GitBox
Technoboy- commented on issue #15471: URL: https://github.com/apache/pulsar/issues/15471#issuecomment-1119644311 Which test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] codelipenghui commented on pull request #15410: [improve][CLI] Support filtering system topic when get list.

2022-05-06 Thread GitBox
codelipenghui commented on PR #15410: URL: https://github.com/apache/pulsar/pull/15410#issuecomment-1119641820 @Jason918 Please help review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated (a1fb200ff70 -> da3f0172406)

2022-05-06 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from a1fb200ff70 [PIP-152] Support subscription level dispatch rate limiter setting. (#15295) add da3f0172406

[GitHub] [pulsar] lhotari merged pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy

2022-05-06 Thread GitBox
lhotari merged PR #15340: URL: https://github.com/apache/pulsar/pull/15340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-go] branch master updated: Calling internalFlushCurrentBatch will be forwaded to internalFlushCurrentBatches if the associated batch builder contains multi batches(KeyBasedBatchBuilder)

2022-05-06 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new ee379ac Calling

[GitHub] [pulsar-client-go] wolfstudy merged pull request #750: [Issue 749]Fix panic caused by flushing current batch with an incorrect internal function.

2022-05-06 Thread GitBox
wolfstudy merged PR #750: URL: https://github.com/apache/pulsar-client-go/pull/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] wolfstudy closed issue #749: Panic occurred when a producer associated with a KeyBasedBatchBuilder.

2022-05-06 Thread GitBox
wolfstudy closed issue #749: Panic occurred when a producer associated with a KeyBasedBatchBuilder. URL: https://github.com/apache/pulsar-client-go/issues/749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-client-go] wolfstudy closed pull request #760: [Issue 733] Fix using closed connection in producer/consumer.

2022-05-06 Thread GitBox
wolfstudy closed pull request #760: [Issue 733] Fix using closed connection in producer/consumer. URL: https://github.com/apache/pulsar-client-go/pull/760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   >