[GitHub] [pulsar-client-go] shibd commented on issue #931: [feature request] Support producer access mode.

2023-01-08 Thread GitBox
shibd commented on issue #931: URL: https://github.com/apache/pulsar-client-go/issues/931#issuecomment-1375004165 I will work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19151: [improve][broker] Add parameter check for create/update cluster.

2023-01-08 Thread GitBox
mattisonchao commented on code in PR #19151: URL: https://github.com/apache/pulsar/pull/19151#discussion_r1064238426 ## pulsar-common/src/test/java/org/apache/pulsar/common/policies/data/ClusterDataTest.java: ## @@ -109,4 +110,80 @@ public void simple() {

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #19151: [improve][broker] Add parameter check for create/update cluster.

2023-01-08 Thread GitBox
gaoran10 commented on code in PR #19151: URL: https://github.com/apache/pulsar/pull/19151#discussion_r1064176398 ## pulsar-common/src/test/java/org/apache/pulsar/common/policies/data/ClusterDataTest.java: ## @@ -109,4 +110,80 @@ public void simple() {

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #19153: [improve] added TopicEventListener / topic events for the BrokerService

2023-01-08 Thread GitBox
BewareMyPower commented on code in PR #19153: URL: https://github.com/apache/pulsar/pull/19153#discussion_r1064155534 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicEventsListener.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [pulsar] BewareMyPower commented on pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-08 Thread GitBox
BewareMyPower commented on PR #19147: URL: https://github.com/apache/pulsar/pull/19147#issuecomment-1374850627 @eolivelli IMO, the interceptor should not be a fail-fast component. `Throwable` is caught for all other similar components currently. In addition to the `ConsumerInterceptor`

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #19153: [improve] added TopicEventListener / topic events for the BrokerService

2023-01-08 Thread GitBox
BewareMyPower commented on code in PR #19153: URL: https://github.com/apache/pulsar/pull/19153#discussion_r1064151149 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicEventsListener.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [pulsar-site] sekikn opened a new pull request, #365: [fix][doc] Fix JDK version for release process

2023-01-08 Thread GitBox
sekikn opened a new pull request, #365: URL: https://github.com/apache/pulsar-site/pull/365 [The release process document says JDK 11 is required](https://pulsar.apache.org/contribute/release-process/#preparation), but 17 is supposed to be required for recent releases actually. -- This

[GitHub] [pulsar] asafm commented on a diff in pull request #19047: [improve][broker]PIP-214 Add broker level metrics statistics and expose to prometheus

2023-01-08 Thread GitBox
asafm commented on code in PR #19047: URL: https://github.com/apache/pulsar/pull/19047#discussion_r1064149370 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java: ## @@ -358,6 +358,101 @@ public void testPerTopicStats() throws Exception {

[GitHub] [pulsar-site] sekikn opened a new pull request, #364: [fix][doc] Correct configuration requirements for the HDFS sinks

2023-01-08 Thread GitBox
sekikn opened a new pull request, #364: URL: https://github.com/apache/pulsar-site/pull/364 [The HDFS2 sink documentation refers to the `filenamePrefix` configuration as "(Required) true, if compression is set to None"](https://pulsar.apache.org/docs/next/io-hdfs2-sink/#property), but

[GitHub] [pulsar-test-infra] dependabot[bot] opened a new pull request, #94: Bump json5 from 2.2.1 to 2.2.3 in /gh-actions-artifact-client

2023-01-08 Thread GitBox
dependabot[bot] opened a new pull request, #94: URL: https://github.com/apache/pulsar-test-infra/pull/94 Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. Release notes Sourced from https://github.com/json5/json5/releases;>json5's releases. v2.2.3

[GitHub] [pulsar-site] momo-jun commented on pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-08 Thread GitBox
momo-jun commented on PR #349: URL: https://github.com/apache/pulsar-site/pull/349#issuecomment-1374830527 @asafm thanks for the reminder. I attached two more screenshots. The `index.js` update works as follows.

[GitHub] [pulsar-site] asafm commented on a diff in pull request #363: Indicate metrics are reset upon restart and mark the one the don't

2023-01-08 Thread GitBox
asafm commented on code in PR #363: URL: https://github.com/apache/pulsar-site/pull/363#discussion_r1064136730 ## versioned_docs/version-2.10.x/admin-api-topics.md: ## @@ -384,7 +390,7 @@ You can check the following statistics of a given non-partitioned topic. -

[GitHub] [pulsar-site] asafm commented on a diff in pull request #363: Indicate metrics are reset upon restart and mark the one the don't

2023-01-08 Thread GitBox
asafm commented on code in PR #363: URL: https://github.com/apache/pulsar-site/pull/363#discussion_r1064136677 ## versioned_docs/version-2.10.x/admin-api-topics.md: ## @@ -314,9 +320,9 @@ You can check the following statistics of a given non-partitioned topic. -

[GitHub] [pulsar-site] asafm commented on a diff in pull request #363: Indicate metrics are reset upon restart and mark the one the don't

2023-01-08 Thread GitBox
asafm commented on code in PR #363: URL: https://github.com/apache/pulsar-site/pull/363#discussion_r1064136644 ## versioned_docs/version-2.10.x/admin-api-topics.md: ## @@ -300,7 +306,7 @@ You can check the following statistics of a given non-partitioned topic. -

[GitHub] [pulsar-site] asafm commented on a diff in pull request #363: Indicate metrics are reset upon restart and mark the one the don't

2023-01-08 Thread GitBox
asafm commented on code in PR #363: URL: https://github.com/apache/pulsar-site/pull/363#discussion_r1064136616 ## versioned_docs/version-2.10.x/admin-api-topics.md: ## @@ -290,7 +290,13 @@ admin.topics().unload(topic); You can check the following statistics of a given

[GitHub] [pulsar-site] asafm commented on a diff in pull request #363: Indicate metrics are reset upon restart and mark the one the don't

2023-01-08 Thread GitBox
asafm commented on code in PR #363: URL: https://github.com/apache/pulsar-site/pull/363#discussion_r1064136099 ## docs/administration-stats.md: ## @@ -67,7 +74,7 @@ The following table outlines the stats of a topic. For more details about how to | lastAckedTimestamp

[GitHub] [pulsar-site] asafm commented on a diff in pull request #363: Indicate metrics are reset upon restart and mark the one the don't

2023-01-08 Thread GitBox
asafm commented on code in PR #363: URL: https://github.com/apache/pulsar-site/pull/363#discussion_r1064136009 ## docs/administration-stats.md: ## @@ -8,32 +8,39 @@ sidebar_label: "Pulsar statistics" The following table outlines the stats of a topic. For more details about

[GitHub] [pulsar-site] asafm commented on a diff in pull request #363: Indicate metrics are reset upon restart and mark the one the don't

2023-01-08 Thread GitBox
asafm commented on code in PR #363: URL: https://github.com/apache/pulsar-site/pull/363#discussion_r1064135963 ## docs/administration-stats.md: ## @@ -8,32 +8,39 @@ sidebar_label: "Pulsar statistics" The following table outlines the stats of a topic. For more details about

[GitHub] [pulsar-site] asafm commented on a diff in pull request #363: Indicate metrics are reset upon restart and mark the one the don't

2023-01-08 Thread GitBox
asafm commented on code in PR #363: URL: https://github.com/apache/pulsar-site/pull/363#discussion_r1064135891 ## docs/administration-stats.md: ## @@ -8,32 +8,39 @@ sidebar_label: "Pulsar statistics" The following table outlines the stats of a topic. For more details about

[GitHub] [pulsar] aloyszhang merged pull request #19132: [fix][broker] fix ttl expiration block due to no-recoverable exception even if autoSkipNonRecoverableData=true

2023-01-08 Thread GitBox
aloyszhang merged PR #19132: URL: https://github.com/apache/pulsar/pull/19132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] aloyszhang closed issue #19131: [Bug] ttl expiration block due to no-recoverable exception even if autoSkipNonRecoverableData=true

2023-01-08 Thread GitBox
aloyszhang closed issue #19131: [Bug] ttl expiration block due to no-recoverable exception even if autoSkipNonRecoverableData=true URL: https://github.com/apache/pulsar/issues/19131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar-test-infra] dependabot[bot] opened a new pull request, #93: Bump json5 from 1.0.1 to 1.0.2 in /paths-filter

2023-01-08 Thread GitBox
dependabot[bot] opened a new pull request, #93: URL: https://github.com/apache/pulsar-test-infra/pull/93 Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. Release notes Sourced from https://github.com/json5/json5/releases;>json5's releases. v1.0.2

[GitHub] [pulsar-site] asafm commented on pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-08 Thread GitBox
asafm commented on PR #349: URL: https://github.com/apache/pulsar-site/pull/349#issuecomment-1374776374 @momo-jun There should be other screenshots as 3 sections were changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar-site] asafm commented on pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-08 Thread GitBox
asafm commented on PR #349: URL: https://github.com/apache/pulsar-site/pull/349#issuecomment-1374776161 @DaveDuggins, Can you please change the title and summary to reflect the content and intent of this PR? I think another PR you had got the description and title mixed into here by

[GitHub] [pulsar] asafm commented on issue #19149: [Doc] add guide for how to monitor Pulsar stats

2023-01-08 Thread GitBox
asafm commented on issue #19149: URL: https://github.com/apache/pulsar/issues/19149#issuecomment-1374774505 > I'm working on a PR for fixing a small portion of that. https://github.com/apache/pulsar-site/pull/363 -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-site] asafm opened a new pull request, #363: Indicate metrics are reset upon restart and mark the one the don't

2023-01-08 Thread GitBox
asafm opened a new pull request, #363: URL: https://github.com/apache/pulsar-site/pull/363 Topic Stats metrics are mainly reset to 0 when the broker restarts, aside from a few gauges which do not reset as they take their values from persistent storage (BK). This is now indicated to

[GitHub] [pulsar] Jason918 commented on pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-07 Thread GitBox
Jason918 commented on PR #19147: URL: https://github.com/apache/pulsar/pull/19147#issuecomment-1374744241 > So, IMO, the exception of BrokerInterceptor should not affect the Broker process. @aloyszhang I agree this should be the default behavior. But it would be better if

[GitHub] [pulsar] horizonzy commented on a diff in pull request #19156: [fix][broker] Support zookeeper read-only config.

2023-01-07 Thread GitBox
horizonzy commented on code in PR #19156: URL: https://github.com/apache/pulsar/pull/19156#discussion_r1064095973 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ## @@ -461,6 +467,15 @@ The delayed message index bucket time step(in

[GitHub] [pulsar] Jason918 commented on a diff in pull request #19156: [fix][broker] Support zookeeper read-only config.

2023-01-07 Thread GitBox
Jason918 commented on code in PR #19156: URL: https://github.com/apache/pulsar/pull/19156#discussion_r1064095716 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ## @@ -461,6 +467,15 @@ The delayed message index bucket time step(in

[GitHub] [pulsar-site] momo-jun opened a new pull request, #362: [improve][doc] Landing page

2023-01-07 Thread GitBox
momo-jun opened a new pull request, #362: URL: https://github.com/apache/pulsar-site/pull/362 ### Modifications 1. Update links on the doc landing page in previous versions 2.10.x, 2.9.x, and 2.8.x, to sync with the latest (master).

[GitHub] [pulsar] Jason918 merged pull request #19152: [revert] "[fix][broker] change name limitTime to limitTimeInSec (#19053)"

2023-01-07 Thread GitBox
Jason918 merged PR #19152: URL: https://github.com/apache/pulsar/pull/19152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] horizonzy opened a new pull request, #19156: [fix][broker] Support zookeeper read-only config.

2023-01-07 Thread GitBox
horizonzy opened a new pull request, #19156: URL: https://github.com/apache/pulsar/pull/19156 Fixes #16489 Master Issue: #16489 ### Motivation Export config `metadataStoreAllowReadOnlyOperations` and `zooKeeperAllowReadOnlyOperations`. ### Does this

[GitHub] [pulsar-site] momo-jun commented on pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-07 Thread GitBox
momo-jun commented on PR #349: URL: https://github.com/apache/pulsar-site/pull/349#issuecomment-1374706225 @tisonkun thanks for the fix. @DaveDuggins I attached the screenshots of my local preview. You can check it out and see whether it is expected or still needs adjustments.

[GitHub] [pulsar] lordcheng10 commented on pull request #19135: [branch-2.8][cherry-pick] Cleanup state when lock revalidation gets LockBusyException

2023-01-07 Thread GitBox
lordcheng10 commented on PR #19135: URL: https://github.com/apache/pulsar/pull/19135#issuecomment-1374694544 > @lordcheng10 can we add the test to coverage of this change? Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] AnonHxy commented on pull request #19132: [fix][broker] fix ttl expiration block due to no-recoverable exception even if autoSkipNonRecoverableData=true

2023-01-07 Thread GitBox
AnonHxy commented on PR #19132: URL: https://github.com/apache/pulsar/pull/19132#issuecomment-1374691995 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] HQebupt commented on pull request #19152: [revert] "[fix][broker] change name limitTime to limitTimeInSec (#19053)"

2023-01-07 Thread GitBox
HQebupt commented on PR #19152: URL: https://github.com/apache/pulsar/pull/19152#issuecomment-1374689177 @StevenLuMT FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] codecov-commenter commented on pull request #19132: [fix][broker] fix ttl expiration block due to no-recoverable exception even if autoSkipNonRecoverableData=true

2023-01-07 Thread GitBox
codecov-commenter commented on PR #19132: URL: https://github.com/apache/pulsar/pull/19132#issuecomment-1374689143 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19132?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] github-actions[bot] commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

2023-01-07 Thread GitBox
github-actions[bot] commented on PR #16780: URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1374686850 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #18224: [Bug] deliverAfter not work

2023-01-07 Thread GitBox
github-actions[bot] commented on issue #18224: URL: https://github.com/apache/pulsar/issues/18224#issuecomment-1374686319 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18510: PIP-210: Retry producing on next partition if possible when a partition is not available

2023-01-07 Thread GitBox
github-actions[bot] commented on issue #18510: URL: https://github.com/apache/pulsar/issues/18510#issuecomment-1374686148 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on pull request #18550: [fix][ml] Ensure ManagedLedger readEntryOps can be finished within `readEntryTimeoutSeconds`

2023-01-07 Thread GitBox
github-actions[bot] commented on PR #18550: URL: https://github.com/apache/pulsar/pull/18550#issuecomment-1374686112 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on pull request #18642: [fix][test] ZKSessionTest.testReacquireLocksAfterSessionLost fail easily

2023-01-07 Thread GitBox
github-actions[bot] commented on PR #18642: URL: https://github.com/apache/pulsar/pull/18642#issuecomment-1374686070 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #18813: pulsar-perf: improve error message when trying to run a transaction on a non-transactional broker.

2023-01-07 Thread GitBox
github-actions[bot] commented on issue #18813: URL: https://github.com/apache/pulsar/issues/18813#issuecomment-1374685967 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] tisonkun commented on issue #18026: [Doc][improve] Auto-detect broken links and integrate into CI process

2023-01-07 Thread GitBox
tisonkun commented on issue #18026: URL: https://github.com/apache/pulsar/issues/18026#issuecomment-1374684593 I'm adding Docu's builtin support now. Integrate into CI can be a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] tisonkun commented on issue #7971: pulsar-client not usable in a jpms (java modules) setup

2023-01-07 Thread GitBox
tisonkun commented on issue #7971: URL: https://github.com/apache/pulsar/issues/7971#issuecomment-1374684450 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun closed issue #7971: pulsar-client not usable in a jpms (java modules) setup

2023-01-07 Thread GitBox
tisonkun closed issue #7971: pulsar-client not usable in a jpms (java modules) setup URL: https://github.com/apache/pulsar/issues/7971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] aloyszhang commented on pull request #19132: [fix][broker] fix ttl expiration block due to no-recoverable exception even if autoSkipNonRecoverableData=true

2023-01-07 Thread GitBox
aloyszhang commented on PR #19132: URL: https://github.com/apache/pulsar/pull/19132#issuecomment-1374483149 @AnonHxy PTAL again, thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] aloyszhang commented on pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-07 Thread GitBox
aloyszhang commented on PR #19147: URL: https://github.com/apache/pulsar/pull/19147#issuecomment-1374482198 @eolivelli Thanks for your reminder. BrokerInterceptor is a 3rd party extension and may have a variety of implementations and exceptions. If every interceptor exception may fail

[GitHub] [pulsar-client-node] shibd commented on issue #281: Failed to create producer: ConnectError when upgrading to 1.8.0

2023-01-07 Thread GitBox
shibd commented on issue #281: URL: https://github.com/apache/pulsar-client-node/issues/281#issuecomment-1374451272 When I use `pulsar+ssl:`, I get the same result as you: `Error: Failed to create producer: ConnectError` The essential reason should be this: ``` Response failed

[GitHub] [pulsar-client-node] shibd commented on issue #281: Failed to create producer: ConnectError when upgrading to 1.8.0

2023-01-07 Thread GitBox
shibd commented on issue #281: URL: https://github.com/apache/pulsar-client-node/issues/281#issuecomment-1374450723 Hi, @ericallam Need to confirm, are you getting an auth `AuthenticationError`? In my environment I reproduce and I get an `AuthenticationError` I get the error log:

[GitHub] [pulsar] aloyszhang commented on pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-07 Thread GitBox
aloyszhang commented on PR #19147: URL: https://github.com/apache/pulsar/pull/19147#issuecomment-1374414582 > I wonder if we should catch exceptions for all the methods in BrokerInterceptor. Sure, we can unify the exception processing for all methods. -- This is an automated

[GitHub] [pulsar] eolivelli commented on a diff in pull request #19153: [improve] added TopicEventListener / topic events for the BrokerService

2023-01-06 Thread GitBox
eolivelli commented on code in PR #19153: URL: https://github.com/apache/pulsar/pull/19153#discussion_r1063965653 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicEventsListener.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [pulsar] codecov-commenter commented on pull request #19152: [revert] "[fix][broker] change name limitTime to limitTimeInSec (#19053)"

2023-01-06 Thread GitBox
codecov-commenter commented on PR #19152: URL: https://github.com/apache/pulsar/pull/19152#issuecomment-1374397124 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19152?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] lhotari commented on pull request #19152: [revert] "[fix][broker] change name limitTime to limitTimeInSec (#19053)"

2023-01-06 Thread GitBox
lhotari commented on PR #19152: URL: https://github.com/apache/pulsar/pull/19152#issuecomment-1374396302 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Jason918 commented on pull request #19053: [fix][broker] change name limitTime to limitTimeInSec

2023-01-06 Thread GitBox
Jason918 commented on PR #19053: URL: https://github.com/apache/pulsar/pull/19053#issuecomment-1374374079 @StevenLuMT The right way is to keep compatibility, you can take the old `getLimit` for reference. 1. add getLimitTimeInSec in `BacklogQuota` 2. Deprecate getLimitTime in

[GitHub] [pulsar] mattisonchao commented on pull request #19086: [fix][broker] Reject create non existent persistent partitions.

2023-01-06 Thread GitBox
mattisonchao commented on PR #19086: URL: https://github.com/apache/pulsar/pull/19086#issuecomment-1374371113 I use the workaround method to fix the restful endpoint `updatePartitionedTopic`. It's ugly though. I will refactor it in the next PR. @eolivelli @codelipenghui

[GitHub] [pulsar] horizonzy commented on issue #16489: Pulsar no longer works when zookeeper global goes into read only

2023-01-06 Thread GitBox
horizonzy commented on issue #16489: URL: https://github.com/apache/pulsar/issues/16489#issuecomment-1374359937 https://user-images.githubusercontent.com/22524871/211128337-e0a8e0ea-e353-48c9-bab1-089cc2df3390.png;> The logs show that the connect request is without the param

[GitHub] [pulsar] github-actions[bot] commented on issue #17878: [Doc] Fix Admin Interface docs for Managing partitioned topics

2023-01-06 Thread GitBox
github-actions[bot] commented on issue #17878: URL: https://github.com/apache/pulsar/issues/17878#issuecomment-1374347014 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18501: [Bug] Incompatible schema when having Avro schema without nullable string fields

2023-01-06 Thread GitBox
github-actions[bot] commented on issue #18501: URL: https://github.com/apache/pulsar/issues/18501#issuecomment-1374346744 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18673: [Bug] BookieRackAffinityMapping is not compatible with custom BookieId

2023-01-06 Thread GitBox
github-actions[bot] commented on issue #18673: URL: https://github.com/apache/pulsar/issues/18673#issuecomment-1374346671 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18743: [Bug] Consumer subscription failed. If some partitions on a topic are on a dead broker

2023-01-06 Thread GitBox
github-actions[bot] commented on issue #18743: URL: https://github.com/apache/pulsar/issues/18743#issuecomment-1374346637 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18797: [Bug] Pulsar zookeeper frequently generates log and snapshot files during operation

2023-01-06 Thread GitBox
github-actions[bot] commented on issue #18797: URL: https://github.com/apache/pulsar/issues/18797#issuecomment-1374346599 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18799: PIP-227: New API for closing the consumer after waiting for the job to complete

2023-01-06 Thread GitBox
github-actions[bot] commented on issue #18799: URL: https://github.com/apache/pulsar/issues/18799#issuecomment-1374346579 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar-test-infra] dependabot[bot] opened a new pull request, #92: Bump json5 from 2.1.3 to 2.2.3 in /test-reporter/reports/jest

2023-01-06 Thread GitBox
dependabot[bot] opened a new pull request, #92: URL: https://github.com/apache/pulsar-test-infra/pull/92 Bumps [json5](https://github.com/json5/json5) from 2.1.3 to 2.2.3. Release notes Sourced from https://github.com/json5/json5/releases;>json5's releases. v2.2.3

[GitHub] [pulsar] michaeljmarshall commented on issue #19155: Improve getManagedLedgerOffloader equality check for OffloadPoliciesImpl

2023-01-06 Thread GitBox
michaeljmarshall commented on issue #19155: URL: https://github.com/apache/pulsar/issues/19155#issuecomment-1374247194 Also, it looks like there is a resource leak in the `ledgerOffloaderMap`. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] michaeljmarshall commented on issue #19155: Improve getManagedLedgerOffloader equality check for OffloadPoliciesImpl

2023-01-06 Thread GitBox
michaeljmarshall commented on issue #19155: URL: https://github.com/apache/pulsar/issues/19155#issuecomment-1374230183 Notes: one of the objects is created here

[GitHub] [pulsar] michaeljmarshall opened a new issue, #19155: Improve getManagedLedgerOffloader equality check for OffloadPoliciesImpl

2023-01-06 Thread GitBox
michaeljmarshall opened a new issue, #19155: URL: https://github.com/apache/pulsar/issues/19155 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation The equality check on the

[GitHub] [pulsar] heesung-sn opened a new pull request, #19154: [improve][broker] PIP-192 Moved the common broker load data feature(weightedMaxEMA) to BrokerLoadData

2023-01-06 Thread GitBox
heesung-sn opened a new pull request, #19154: URL: https://github.com/apache/pulsar/pull/19154 Master Issue: https://github.com/apache/pulsar/issues/16691 ### Motivation We will start raising PRs to implement PIP-192,

[GitHub] [pulsar] dlg99 opened a new pull request, #19153: [improve] added TopicEventListener / topic events for the BrokerService

2023-01-06 Thread GitBox
dlg99 opened a new pull request, #19153: URL: https://github.com/apache/pulsar/pull/19153 ### Motivation Topic events for KOP ### Modifications Added TopicEventsListener interface, topic events dispatching for the BrokerService ### Verifying this change -

[GitHub] [pulsar] michaeljmarshall commented on pull request #19053: [fix][broker] change name limitTime to limitTimeInSec

2023-01-06 Thread GitBox
michaeljmarshall commented on PR #19053: URL: https://github.com/apache/pulsar/pull/19053#issuecomment-1374055378 Reverting with #19152. I support working to improve the clarify of our names, but we need to be careful not to break any deployments. -- This is an automated message from the

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19152: Revert "[fix][broker] change name limitTime to limitTimeInSec (#19053)"

2023-01-06 Thread GitBox
michaeljmarshall opened a new pull request, #19152: URL: https://github.com/apache/pulsar/pull/19152 This reverts commit fd5037ddeab4746202539509818f2b7977698537. ### Motivation As described in https://github.com/apache/pulsar/pull/19053#pullrequestreview-1234929550, the

[GitHub] [pulsar-client-python] erichare commented on a diff in pull request #81: #27 Add a version attribute

2023-01-06 Thread GitBox
erichare commented on code in PR #81: URL: https://github.com/apache/pulsar-client-python/pull/81#discussion_r1063566322 ## pulsar/__init__.py: ## @@ -62,6 +62,11 @@ from datetime import timedelta +# Get the pulsar version from version.txt +with open("version.txt") as f:

[GitHub] [pulsar-client-python] tisonkun commented on a diff in pull request #81: #27 Add a version attribute

2023-01-06 Thread GitBox
tisonkun commented on code in PR #81: URL: https://github.com/apache/pulsar-client-python/pull/81#discussion_r1063564911 ## pulsar/__init__.py: ## @@ -62,6 +62,11 @@ from datetime import timedelta +# Get the pulsar version from version.txt +with open("version.txt") as f:

[GitHub] [pulsar] mattisonchao closed issue #18991: [Draft] PIP-233 Introduce the `OsResourceManager` to control operating systems resources.

2023-01-06 Thread GitBox
mattisonchao closed issue #18991: [Draft] PIP-233 Introduce the `OsResourceManager` to control operating systems resources. URL: https://github.com/apache/pulsar/issues/18991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] mattisonchao closed pull request #18990: [improve][broker] Add oshi library to help control OS resources.

2023-01-06 Thread GitBox
mattisonchao closed pull request #18990: [improve][broker] Add oshi library to help control OS resources. URL: https://github.com/apache/pulsar/pull/18990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-client-cpp] RobertIndie opened a new pull request, #169: [feat] Add producer interceptor

2023-01-06 Thread GitBox
RobertIndie opened a new pull request, #169: URL: https://github.com/apache/pulsar-client-cpp/pull/169 Master Issue: #150 ### Motivation This is the producer interceptor implementation of #150. ### Modifications * Add ProducerInterceptor interface *

[GitHub] [pulsar-client-node] ericallam opened a new issue, #281: Failed to create producer: ConnectError when upgrading to 1.8.0

2023-01-06 Thread GitBox
ericallam opened a new issue, #281: URL: https://github.com/apache/pulsar-client-node/issues/281 Hi there, I'm just attempting to upgrade to 1.8.0 (from 1.7.0) and I'm now getting a `Failed to create producer: ConnectError` error when creating a producer. If I downgrade back to 1.7.0 the

[GitHub] [pulsar] codecov-commenter commented on pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-06 Thread GitBox
codecov-commenter commented on PR #19147: URL: https://github.com/apache/pulsar/pull/19147#issuecomment-1373687371 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19147?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] ethqunzhong commented on issue #18895: [Bug] NoClassDefFoundError BlobStoreBackedReadHandleImpl

2023-01-06 Thread GitBox
ethqunzhong commented on issue #18895: URL: https://github.com/apache/pulsar/issues/18895#issuecomment-1373576218 it seems load `tiered-storage-jcloud-2.10.2.nar` incorrect. how about use the default config `offloadersDirectory=offloaders` and unzip offloads into this path then try

[GitHub] [pulsar] codecov-commenter commented on pull request #19151: [improve][broker] Add parameter check for create/update cluster.

2023-01-06 Thread GitBox
codecov-commenter commented on PR #19151: URL: https://github.com/apache/pulsar/pull/19151#issuecomment-1373546242 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19151?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] mattisonchao closed pull request #19151: [improve][broker] Add parameter check for create/update cluster.

2023-01-06 Thread GitBox
mattisonchao closed pull request #19151: [improve][broker] Add parameter check for create/update cluster. URL: https://github.com/apache/pulsar/pull/19151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-client-cpp] shibd commented on pull request #139: [feat] Support Dead Letter Topic.

2023-01-06 Thread GitBox
shibd commented on PR #139: URL: https://github.com/apache/pulsar-client-cpp/pull/139#issuecomment-1373407356 @BewareMyPower @Anonymitaet Thanks for your reviews. All suggestions have been fixed. PTAL. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #139: [feat] Support Dead Letter Topic.

2023-01-06 Thread GitBox
shibd commented on code in PR #139: URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1063275274 ## tests/DeadLetterQueueTest.cc: ## @@ -0,0 +1,390 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [pulsar] mattisonchao commented on pull request #19151: [improve][broker] Add parameter check for create/update cluster.

2023-01-06 Thread GitBox
mattisonchao commented on PR #19151: URL: https://github.com/apache/pulsar/pull/19151#issuecomment-1373393442 @codelipenghui @eolivelli @Jason918 @congbobo184 @nicoloboschi Would you guys mind taking a look? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] mattisonchao opened a new pull request, #19151: [improve][broker] Add parameter check for create/update cluster.

2023-01-06 Thread GitBox
mattisonchao opened a new pull request, #19151: URL: https://github.com/apache/pulsar/pull/19151 ### Motivation In the current implementation, we didn't have any cluster data check for `create/update` cluster. it may cause some problems when the user sets the wrong URL. ###

[GitHub] [pulsar-site] tisonkun commented on pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-06 Thread GitBox
tisonkun commented on PR #349: URL: https://github.com/apache/pulsar-site/pull/349#issuecomment-1373391394 FYI I pushed a commit 5d335be2c6b3351dbc63ae3845ced1c6869fb123 to fix the broken links. @DaveDuggins please ensure previews look good before requesting review :) -- This is an

[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #139: [feat] Support Dead Letter Topic.

2023-01-06 Thread GitBox
shibd commented on code in PR #139: URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1063266384 ## tests/DeadLetterQueueTest.cc: ## @@ -0,0 +1,390 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [pulsar] aloyszhang commented on a diff in pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-06 Thread GitBox
aloyszhang commented on code in PR #19147: URL: https://github.com/apache/pulsar/pull/19147#discussion_r1063265999 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -1157,7 +1157,11 @@ protected void handleSubscribe(final CommandSubscribe

[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #139: [feat] Support Dead Letter Topic.

2023-01-06 Thread GitBox
shibd commented on code in PR #139: URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1063260550 ## lib/ConsumerImpl.cc: ## @@ -527,6 +544,10 @@ void ConsumerImpl::messageReceived(const ClientConnectionPtr& cnx, const proto::

[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #139: [feat] Support Dead Letter Topic.

2023-01-06 Thread GitBox
shibd commented on code in PR #139: URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1063259612 ## lib/ConsumerImpl.cc: ## @@ -1526,4 +1577,96 @@ void ConsumerImpl::cancelTimers() noexcept { checkExpiredChunkedTimer_->cancel(ec); } +void

[GitHub] [pulsar] BaoHuaWang opened a new issue, #19150: [Bug] pulsar-2.10.2 Please redo the lookup. Request is denied: namespace=public/default

2023-01-06 Thread GitBox
BaoHuaWang opened a new issue, #19150: URL: https://github.com/apache/pulsar/issues/19150 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 2023-01-06T16:32:02,267+0800

[GitHub] [pulsar] asafm commented on issue #19149: [Doc] add guide for how to monitor Pulsar stats

2023-01-06 Thread GitBox
asafm commented on issue #19149: URL: https://github.com/apache/pulsar/issues/19149#issuecomment-1373329860 I'm actually working on a PR for fixing some of that . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] Anonymitaet opened a new issue, #19149: [Doc] add guide for how to monitor Pulsar stats

2023-01-06 Thread GitBox
Anonymitaet opened a new issue, #19149: URL: https://github.com/apache/pulsar/issues/19149 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs?

[GitHub] [pulsar] thetumbled opened a new issue, #19148: [Bug] [client] transactional consumer do not work though corresponding TP has been recovered.

2023-01-05 Thread GitBox
thetumbled opened a new issue, #19148: URL: https://github.com/apache/pulsar/issues/19148 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version master branch. ### Minimal

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-05 Thread GitBox
BewareMyPower commented on code in PR #19147: URL: https://github.com/apache/pulsar/pull/19147#discussion_r1063211689 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -1157,7 +1157,11 @@ protected void handleSubscribe(final CommandSubscribe

[GitHub] [pulsar-client-go] nodece commented on issue #936: [feature request] Support SNAPPY CompressionType

2023-01-05 Thread GitBox
nodece commented on issue #936: URL: https://github.com/apache/pulsar-client-go/issues/936#issuecomment-1373279732 Snappy depends on cgo, we should avoid using cgo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-client-node] Mporsi closed issue #260: How do i install libpulsar@2.10.2 through homebrew

2023-01-05 Thread GitBox
Mporsi closed issue #260: How do i install libpulsar@2.10.2 through homebrew URL: https://github.com/apache/pulsar-client-node/issues/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar-client-node] Mporsi commented on issue #260: How do i install libpulsar@2.10.2 through homebrew

2023-01-05 Thread GitBox
Mporsi commented on issue #260: URL: https://github.com/apache/pulsar-client-node/issues/260#issuecomment-1373275773 Awesome @shibd ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-05 Thread GitBox
congbobo184 commented on code in PR #19147: URL: https://github.com/apache/pulsar/pull/19147#discussion_r1063201039 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -1157,7 +1157,11 @@ protected void handleSubscribe(final CommandSubscribe

[GitHub] [pulsar-site] RobertIndie merged pull request #360: Add the release note for Nodejs client 1.8.0

2023-01-05 Thread GitBox
RobertIndie merged PR #360: URL: https://github.com/apache/pulsar-site/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    13   14   15   16   17   18   19   20   21   22   >