Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-05-03 Thread via GitHub
lhotari commented on PR #22607: URL: https://github.com/apache/pulsar/pull/22607#issuecomment-2093242915 > Based on the review results, let's continue to use compile scope. When using the pulsar dependency, the downstream users must unify the slf4j version in the project. @nodece

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-05-03 Thread via GitHub
nodece commented on PR #22607: URL: https://github.com/apache/pulsar/pull/22607#issuecomment-2093193496 Based on the review results, let's continue to use compile scope. When using the pulsar dependency, the downstream users must unify the slf4j version in the project. -- This is an

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-05-03 Thread via GitHub
nodece closed pull request #22607: [fix][build] Switch slf4j scope to provided from compile URL: https://github.com/apache/pulsar/pull/22607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-05-02 Thread via GitHub
nodece commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1588611172 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-05-02 Thread via GitHub
lhotari commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1588143914 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
nodece commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1583308460 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
lhotari commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1583197077 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
lhotari commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1583197077 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
lhotari commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1583195671 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
BewareMyPower commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1582731198 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
lhotari commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1582686634 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
BewareMyPower commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1582592478 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
BewareMyPower commented on PR #22607: URL: https://github.com/apache/pulsar/pull/22607#issuecomment-2081964237 It seems some tests failed even in the 5th rerun, could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
shoothzj commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1582575529 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
shoothzj commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1582575529 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-29 Thread via GitHub
nodece commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r1582572984 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-28 Thread via GitHub
lhotari commented on code in PR #22607: URL: https://github.com/apache/pulsar/pull/22607#discussion_r158278 ## pom.xml: ## @@ -765,18 +765,21 @@ flexible messaging model and an intuitive client API. org.slf4j slf4j-api ${slf4j.version} +

Re: [PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-28 Thread via GitHub
nodece commented on PR #22607: URL: https://github.com/apache/pulsar/pull/22607#issuecomment-2081573945 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the