[GitHub] [pulsar-site] xiaogang-sn commented on a diff in pull request #510: [improve][doc] Add instructions for enabling replicated subscription

2023-04-10 Thread via GitHub
xiaogang-sn commented on code in PR #510: URL: https://github.com/apache/pulsar-site/pull/510#discussion_r1161590735 ## docs/client-libraries-cluster-level-failover.md: ## @@ -26,7 +26,8 @@ For more information about cluster-level failover, including concepts, benefits, *

[GitHub] [pulsar-client-node] RobertIndie commented on a diff in pull request #309: [Fix] Fix message listener doesn't respect receiver queue size

2023-04-10 Thread via GitHub
RobertIndie commented on code in PR #309: URL: https://github.com/apache/pulsar-client-node/pull/309#discussion_r1161600987 ## src/Consumer.cc: ## @@ -55,21 +56,34 @@ void Consumer::Init(Napi::Env env, Napi::Object exports) { struct MessageListenerProxyData {

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #20040: [improve][client] PIP-224: Add getLastMessageIds API

2023-04-10 Thread via GitHub
codelipenghui commented on code in PR #20040: URL: https://github.com/apache/pulsar/pull/20040#discussion_r1161606167 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java: ## @@ -536,19 +537,38 @@ CompletableFuture reconsumeLaterCumulativeAsync(Message

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20040: [improve][client] PIP-224: Add getLastMessageIds API

2023-04-10 Thread via GitHub
BewareMyPower commented on code in PR #20040: URL: https://github.com/apache/pulsar/pull/20040#discussion_r1161609338 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java: ## @@ -536,19 +537,38 @@ CompletableFuture reconsumeLaterCumulativeAsync(Message

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20009: PIP-254: Support configuring client version

2023-04-10 Thread via GitHub
BewareMyPower commented on code in PR #20009: URL: https://github.com/apache/pulsar/pull/20009#discussion_r1161626720 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java: ## @@ -410,4 +410,27 @@ public ClientBuilder socks5ProxyPassword(String

[GitHub] [pulsar-client-node] BewareMyPower commented on a diff in pull request #309: [Fix] Fix message listener doesn't respect receiver queue size

2023-04-10 Thread via GitHub
BewareMyPower commented on code in PR #309: URL: https://github.com/apache/pulsar-client-node/pull/309#discussion_r1161643305 ## src/Consumer.cc: ## @@ -55,21 +56,34 @@ void Consumer::Init(Napi::Env env, Napi::Object exports) { struct MessageListenerProxyData {

[GitHub] [pulsar] jiangpengcheng commented on pull request #20000: [fix][fn] Support multiple input topics for Go runtime

2023-04-10 Thread via GitHub
jiangpengcheng commented on PR #2: URL: https://github.com/apache/pulsar/pull/2#issuecomment-1501696923 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] tisonkun commented on issue #20041: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql

2023-04-10 Thread via GitHub
tisonkun commented on issue #20041: URL: https://github.com/apache/pulsar/issues/20041#issuecomment-1501602244 Anyway, this seems to be a usage problem instead of an issue. Moved to the Q discussion forum. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun added a comment to the discussion: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql

2023-04-10 Thread GitBox
GitHub user tisonkun added a comment to the discussion: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql Also, the root cause is: ``` pulsar-sql | at org.apache.pulsar.client.admin.internal.PulsarAdminBuilderImpl.authentication(PulsarAdminBuilderImpl.java:94)

[GitHub] [pulsar] tisonkun closed issue #20041: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql

2023-04-10 Thread via GitHub
tisonkun closed issue #20041: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql URL: https://github.com/apache/pulsar/issues/20041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] svabra added a comment to the discussion: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql

2023-04-10 Thread GitBox
GitHub user svabra added a comment to the discussion: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql I was wondering. If the CLI is triggering the Gateway, which includes the REST service according to this [presentation](https://youtu.be/DnXu0Q0mvTM?t=962), then

[GitHub] [pulsar] tisonkun added a comment to the discussion: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql

2023-04-10 Thread GitBox
GitHub user tisonkun added a comment to the discussion: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql The error logs said "IllegalArgumentException", maybe you can change: ``` pulsar.nar-extraction-directory=System.getProperty("java.io.tmpdir") ``` to ```

[GitHub] [pulsar] tisonkun added a comment to the discussion: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql

2023-04-10 Thread GitBox
GitHub user tisonkun added a comment to the discussion: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql Anyway, this seems to be a usage problem instead of an issue. Moved to the Q discussion forum. GitHub link:

[GitHub] [pulsar] tisonkun commented on issue #20041: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql

2023-04-10 Thread via GitHub
tisonkun commented on issue #20041: URL: https://github.com/apache/pulsar/issues/20041#issuecomment-1501601837 Also, the root cause is: ``` pulsar-sql | at org.apache.pulsar.client.admin.internal.PulsarAdminBuilderImpl.authentication(PulsarAdminBuilderImpl.java:94) pulsar-sql |

[GitHub] [pulsar-site] Anonymitaet opened a new pull request, #510: [improve][doc] Add instructions for enabling replicated subscription

2023-04-10 Thread via GitHub
Anonymitaet opened a new pull request, #510: URL: https://github.com/apache/pulsar-site/pull/510 Fix https://github.com/apache/pulsar/issues/20051 - [x] `doc` @hangc0276 thanks for your technical explanations! Ping @D-2-Ed for review, thanks! -- This is an automated

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #20009: PIP-254: Support configuring client version

2023-04-10 Thread via GitHub
codelipenghui commented on code in PR #20009: URL: https://github.com/apache/pulsar/pull/20009#discussion_r1161581756 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java: ## @@ -410,4 +410,27 @@ public ClientBuilder socks5ProxyPassword(String

[GitHub] [pulsar-site] Anonymitaet commented on pull request #510: [improve][doc] Add instructions for enabling replicated subscription

2023-04-10 Thread via GitHub
Anonymitaet commented on PR #510: URL: https://github.com/apache/pulsar-site/pull/510#issuecomment-1501611850 Previews look good: https://user-images.githubusercontent.com/50226895/230875130-02e09e54-89f0-4deb-aa70-679a6417f62d.png;>

[GitHub] [pulsar] Anonymitaet commented on issue #20051: [Doc] Missing broker.conf entry for GEO replicated subscription

2023-04-10 Thread via GitHub
Anonymitaet commented on issue #20051: URL: https://github.com/apache/pulsar/issues/20051#issuecomment-1501613311 Fix in https://github.com/apache/pulsar-site/pull/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-site] Anonymitaet commented on pull request #510: [improve][doc] Add instructions for enabling replicated subscription

2023-04-10 Thread via GitHub
Anonymitaet commented on PR #510: URL: https://github.com/apache/pulsar-site/pull/510#issuecomment-1501613011 For reviewers: I'll apply the same doc changes to 2.11.x and 2.10.x if this PR LGTY. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-site] Anonymitaet commented on pull request #510: [improve][doc] Add instructions for enabling replicated subscription

2023-04-10 Thread via GitHub
Anonymitaet commented on PR #510: URL: https://github.com/apache/pulsar-site/pull/510#issuecomment-1501613951 @hangc0276 @xiaogang-sn Could you please review this PR from a technical perspective? TIA! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] jdfrozen commented on issue #14982: acknowledgmentAtBatchIndexLevelEnabled will still receive duplicate messages when unload topic

2023-04-10 Thread via GitHub
jdfrozen commented on issue #14982: URL: https://github.com/apache/pulsar/issues/14982#issuecomment-1501651275 2.8.4 duplicated delayed messages when unload topic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #510: [improve][doc] Add instructions for enabling replicated subscription

2023-04-10 Thread via GitHub
Anonymitaet commented on code in PR #510: URL: https://github.com/apache/pulsar-site/pull/510#discussion_r1161615807 ## docs/client-libraries-cluster-level-failover.md: ## @@ -26,7 +26,8 @@ For more information about cluster-level failover, including concepts, benefits, *

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #510: [improve][doc] Add instructions for enabling replicated subscription

2023-04-10 Thread via GitHub
Anonymitaet commented on code in PR #510: URL: https://github.com/apache/pulsar-site/pull/510#discussion_r1161615807 ## docs/client-libraries-cluster-level-failover.md: ## @@ -26,7 +26,8 @@ For more information about cluster-level failover, including concepts, benefits, *

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20040: [improve][client] PIP-224: Add getLastMessageIds API

2023-04-10 Thread via GitHub
BewareMyPower commented on code in PR #20040: URL: https://github.com/apache/pulsar/pull/20040#discussion_r1161624425 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java: ## @@ -536,19 +537,38 @@ CompletableFuture reconsumeLaterCumulativeAsync(Message

[GitHub] [pulsar] coderzc commented on a diff in pull request #20031: [fix] [cli] Fix Broker crashed by too much memory usage of pulsar tools

2023-04-10 Thread via GitHub
coderzc commented on code in PR #20031: URL: https://github.com/apache/pulsar/pull/20031#discussion_r1161472533 ## conf/pulsar_tools_env.sh: ## @@ -42,6 +42,18 @@ # PULSAR_GLOBAL_ZK_CONF= # Extra options to be passed to the jvm +# Discard parameter "-Xms" of $PULSAR_MEM,

[GitHub] [pulsar] Anonymitaet commented on issue #20036: [Doc] color code

2023-04-10 Thread via GitHub
Anonymitaet commented on issue #20036: URL: https://github.com/apache/pulsar/issues/20036#issuecomment-1501469268 @momo-jun OK, thanks! Updating the color text to black text is a better way since black text and the image in NEXT and 2.11.x matches our current design style (while the

[GitHub] [pulsar] coderzc commented on a diff in pull request #20031: [fix] [cli] Fix Broker crashed by too much memory usage of pulsar tools

2023-04-10 Thread via GitHub
coderzc commented on code in PR #20031: URL: https://github.com/apache/pulsar/pull/20031#discussion_r1161472533 ## conf/pulsar_tools_env.sh: ## @@ -42,6 +42,18 @@ # PULSAR_GLOBAL_ZK_CONF= # Extra options to be passed to the jvm +# Discard parameter "-Xms" of $PULSAR_MEM,

[GitHub] [pulsar] tisonkun closed issue #19363: [Bug] pulsar-sink nested avro

2023-04-10 Thread via GitHub
tisonkun closed issue #19363: [Bug] pulsar-sink nested avro URL: https://github.com/apache/pulsar/issues/19363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pulsar] tisonkun commented on issue #19363: [Bug] pulsar-sink nested avro

2023-04-10 Thread via GitHub
tisonkun commented on issue #19363: URL: https://github.com/apache/pulsar/issues/19363#issuecomment-1501489462 The repo link is broken and 2.9.x is end of life. Closing as stale. But if it's still relevant to maintained version (ATM 2.10 and 2.11), please open a new issue with error

[GitHub] [pulsar] gaozhangmin opened a new pull request, #20052: Pulsar Dynamic Configuration Feature for Broker-level Configuration

2023-04-10 Thread via GitHub
gaozhangmin opened a new pull request, #20052: URL: https://github.com/apache/pulsar/pull/20052 ### Motivation Currently, Pulsar's Dynamic Configuration Feature only supports cluster-level configuration, meaning that any changes made to the dynamic configuration apply to all brokers

[GitHub] [pulsar] github-actions[bot] commented on pull request #20052: Pulsar Dynamic Configuration Feature for Broker-level Configuration

2023-04-10 Thread via GitHub
github-actions[bot] commented on PR #20052: URL: https://github.com/apache/pulsar/pull/20052#issuecomment-1501492591 @gaozhangmin Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [

[GitHub] [pulsar] poorbarcode commented on pull request #18981: [improve][client]PIP-230 Throw exception when MessageIdImpl and BatchMessageIdImpl compare with each other

2023-04-10 Thread via GitHub
poorbarcode commented on PR #18981: URL: https://github.com/apache/pulsar/pull/18981#issuecomment-1501514465 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #19618: [feat][proxy] Add proxyVersion to CommandConnect; expose in stats

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19618: URL: https://github.com/apache/pulsar/pull/19618#issuecomment-1501513977 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #19026: [fix][proxy] Update clientAuthData in ProxyConnection as needed

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19026: URL: https://github.com/apache/pulsar/pull/19026#issuecomment-1501516224 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #19626: [fix][broker] Only send AuthChallenge when client supports it

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19626: URL: https://github.com/apache/pulsar/pull/19626#issuecomment-1501515813 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #12351: [feat] [pulsar-admin] Add remove-clusters command for namespace

2023-04-10 Thread via GitHub
poorbarcode commented on PR #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-1501517511 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #12599: [feat] [client] Enable custom Encrypt/Decrypt Methods for ReaderImplementation.

2023-04-10 Thread via GitHub
poorbarcode commented on PR #12599: URL: https://github.com/apache/pulsar/pull/12599#issuecomment-1501518509 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #19501: [fix][broker] unify topic-level policies enable judgment conditions

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19501: URL: https://github.com/apache/pulsar/pull/19501#issuecomment-1501537704 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #19348: [fix][broker] fix incorrect unack stats when dup ack a message

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19348: URL: https://github.com/apache/pulsar/pull/19348#issuecomment-1501542840 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] github-actions[bot] commented on pull request #14286: [fix][cursor] Fix enable maxPosition cursor will read in deap loop

2023-04-10 Thread via GitHub
github-actions[bot] commented on PR #14286: URL: https://github.com/apache/pulsar/pull/14286#issuecomment-1501569855 @congbobo184 Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [

[GitHub] [pulsar] poorbarcode commented on pull request #15144: [fix] [client] NotifyPendingReceivedCallback when zeroConsumerImpl received batch message firstly then close consumer

2023-04-10 Thread via GitHub
poorbarcode commented on PR #15144: URL: https://github.com/apache/pulsar/pull/15144#issuecomment-1501570391 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] tisonkun commented on issue #19912: PIP-261: Restructure Getting Started section

2023-04-10 Thread via GitHub
tisonkun commented on issue #19912: URL: https://github.com/apache/pulsar/issues/19912#issuecomment-1501458624 Hi @asafm! Thanks for starting this thread. I reviewed this proposal in two aspects. ## Content For three journeys in the proposal, we have contents for two of

[GitHub] [pulsar] tisonkun commented on pull request #20016: [feat][sql] Bump Trino version to 368 and fix Decimal breaking change

2023-04-10 Thread via GitHub
tisonkun commented on PR #20016: URL: https://github.com/apache/pulsar/pull/20016#issuecomment-1501480354 Merging... Thanks for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] tisonkun merged pull request #20016: [feat][sql] Bump Trino version to 368 and fix Decimal breaking change

2023-04-10 Thread via GitHub
tisonkun merged PR #20016: URL: https://github.com/apache/pulsar/pull/20016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated: [feat][sql] Bump Trino version to 368 and fix Decimal breaking change (#20016)

2023-04-10 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 470b674016c [feat][sql] Bump Trino version to

[GitHub] [pulsar] poorbarcode commented on pull request #20049: [improve] [broker] Upgrade the BookKeeper dependency to 4.16.0

2023-04-10 Thread via GitHub
poorbarcode commented on PR #20049: URL: https://github.com/apache/pulsar/pull/20049#issuecomment-1501497950 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] poorbarcode commented on pull request #13080: [feat] [broker] support broker isolation for uniform load shedder strategy

2023-04-10 Thread via GitHub
poorbarcode commented on PR #13080: URL: https://github.com/apache/pulsar/pull/13080#issuecomment-1501519358 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] github-actions[bot] commented on pull request #13080: [feat] [broker] support broker isolation for uniform load shedder strategy

2023-04-10 Thread via GitHub
github-actions[bot] commented on PR #13080: URL: https://github.com/apache/pulsar/pull/13080#issuecomment-1501519622 @rdhabalia Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ]

[GitHub] [pulsar] poorbarcode commented on pull request #19465: [fix][admin] Report earliest msg in partitioned backlog

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19465: URL: https://github.com/apache/pulsar/pull/19465#issuecomment-1501541527 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] Anonymitaet commented on pull request #19888: [feat][fn] PIP-257: Support mounting k8s ServiceAccount for OIDC auth

2023-04-10 Thread via GitHub
Anonymitaet commented on PR #19888: URL: https://github.com/apache/pulsar/pull/19888#issuecomment-1501545677 Hi @michaeljmarshall thanks for bringing this feature! I see this PR is labeled with doc-required, for these new configurations, do we need to add some instructions and usage

[GitHub] [pulsar] poorbarcode commented on pull request #14560: Ignoring flow control message when resetCursorInProgress=TRUE

2023-04-10 Thread via GitHub
poorbarcode commented on PR #14560: URL: https://github.com/apache/pulsar/pull/14560#issuecomment-1501550051 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #14286: [fix][cursor] Fix enable maxPosition cursor will read in deap loop

2023-04-10 Thread via GitHub
poorbarcode commented on PR #14286: URL: https://github.com/apache/pulsar/pull/14286#issuecomment-1501569100 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #15628: Fix delay messages are expired by TTL policy

2023-04-10 Thread via GitHub
poorbarcode commented on PR #15628: URL: https://github.com/apache/pulsar/pull/15628#issuecomment-1501575654 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #15628: Fix delay messages are expired by TTL policy

2023-04-10 Thread via GitHub
poorbarcode commented on code in PR #15628: URL: https://github.com/apache/pulsar/pull/15628#discussion_r1161560793 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java: ## @@ -77,8 +77,10 @@ public boolean

[GitHub] [pulsar] poorbarcode commented on pull request #17524: [fix][broker]One topic can be close multiple times concurrently

2023-04-10 Thread via GitHub
poorbarcode commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-1501577805 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] sindhushreem commented on issue #20013: CVE-2022-1471 identified on pulsar client for snakeyaml's SafeConstructor usage mandate

2023-04-10 Thread via GitHub
sindhushreem commented on issue #20013: URL: https://github.com/apache/pulsar/issues/20013#issuecomment-1501585368 @lhotari We do have snake yaml direct dependency in buildtools pom.xml . -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] TakaHiR07 opened a new pull request, #20053: [fix] [txn] update txn status concurrently throw exception

2023-04-10 Thread via GitHub
TakaHiR07 opened a new pull request, #20053: URL: https://github.com/apache/pulsar/pull/20053 ### Motivation When updateTxnStatus concurrently, there is a case only one succeed, others may throw exception. If the newStatus == txnMeta.status(), it should also succeed.

[GitHub] [pulsar] tisonkun commented on issue #19456: Flaky-test: MetadataStoreStatsTest.testMetadataStoreStats

2023-04-10 Thread via GitHub
tisonkun commented on issue #19456: URL: https://github.com/apache/pulsar/issues/19456#issuecomment-1501490520 @niharrathod are you working on this issue? I can assign it to you if you're still willing to continue :) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] poorbarcode commented on pull request #19571: [improve][broker] Reduce object creation of EntryBatchIndexesAcks

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19571: URL: https://github.com/apache/pulsar/pull/19571#issuecomment-1501531407 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] poorbarcode commented on pull request #18007: [fix][broker] Reduce unnecessary persistence of markdelete

2023-04-10 Thread via GitHub
poorbarcode commented on PR #18007: URL: https://github.com/apache/pulsar/pull/18007#issuecomment-1501544929 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #16792: [improve][broker] enhance grant permission module to reduce zk metadata

2023-04-10 Thread via GitHub
poorbarcode commented on PR #16792: URL: https://github.com/apache/pulsar/pull/16792#issuecomment-1501548259 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #15594: [improve][client] Throw more meaningful derived exception instead of PulsarClientException

2023-04-10 Thread via GitHub
poorbarcode commented on PR #15594: URL: https://github.com/apache/pulsar/pull/15594#issuecomment-1501547582 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar-client-go] BewareMyPower commented on a diff in pull request #1002: [feat][txn]Implement transactional consumer/producer API

2023-04-10 Thread via GitHub
BewareMyPower commented on code in PR #1002: URL: https://github.com/apache/pulsar-client-go/pull/1002#discussion_r1161505707 ## pulsar/producer_partition.go: ## @@ -1067,6 +1108,20 @@ func (p *partitionProducer) SendAsync(ctx context.Context, msg *ProducerMessage, func (p

[GitHub] [pulsar] poorbarcode commented on pull request #13298: [fix][client] Fix ConfigurationDataUtils loadConf strategy

2023-04-10 Thread via GitHub
poorbarcode commented on PR #13298: URL: https://github.com/apache/pulsar/pull/13298#issuecomment-1501567586 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #15494: [fix][broker] fix ns total size stats

2023-04-10 Thread via GitHub
poorbarcode commented on PR #15494: URL: https://github.com/apache/pulsar/pull/15494#issuecomment-1501571068 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #17485: PIP-211 [feat][tiered-storage] Introduce offload throttling, Part 1

2023-04-10 Thread via GitHub
poorbarcode commented on PR #17485: URL: https://github.com/apache/pulsar/pull/17485#issuecomment-1501578534 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20050: [fix] [ml] Fix uncompleted future when remove cursor

2023-04-10 Thread via GitHub
poorbarcode commented on code in PR #20050: URL: https://github.com/apache/pulsar/pull/20050#discussion_r1161502480 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/MetaStoreImpl.java: ## @@ -302,16 +302,17 @@ public void asyncRemoveCursor(String ledgerName,

[GitHub] [pulsar] poorbarcode commented on pull request #15852: [fix][client] `ZeroQueueConsumer` may not increase the permit after unloading the topic.

2023-04-10 Thread via GitHub
poorbarcode commented on PR #15852: URL: https://github.com/apache/pulsar/pull/15852#issuecomment-1501515145 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #19498: [fix][client] fix receive dumplicated messages after seek to a timestamp in MultiTo…

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19498: URL: https://github.com/apache/pulsar/pull/19498#issuecomment-1501538346 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #19344: [improve] [ml] Reduce the lock time when calculating backlog size

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19344: URL: https://github.com/apache/pulsar/pull/19344#issuecomment-1501543710 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #17846: [feature][compact] Enhanced topic compression

2023-04-10 Thread via GitHub
poorbarcode commented on PR #17846: URL: https://github.com/apache/pulsar/pull/17846#issuecomment-1501546499 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus

2023-04-10 Thread via GitHub
poorbarcode commented on PR #15965: URL: https://github.com/apache/pulsar/pull/15965#issuecomment-1501580835 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] tisonkun commented on issue #20041: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql

2023-04-10 Thread via GitHub
tisonkun commented on issue #20041: URL: https://github.com/apache/pulsar/issues/20041#issuecomment-1501598862 The error logs said "IllegalArgumentException", maybe you can change: ``` pulsar.nar-extraction-directory=System.getProperty("java.io.tmpdir") ``` to ```

[GitHub] [pulsar-client-go] gaoran10 opened a new pull request, #1006: [feat][schema] Support the schema type ProtoNativeSchema

2023-04-10 Thread via GitHub
gaoran10 opened a new pull request, #1006: URL: https://github.com/apache/pulsar-client-go/pull/1006 ### Motivation The pulsar-client-go supports ProtoSchema based on the Avro format, users must provide the schema definition string when using struct schema(JSON, Avro, Proto), it's

[GitHub] [pulsar-client-go] tisonkun opened a new pull request, #1007: ci: stablize golangci-lint task

2023-04-10 Thread via GitHub
tisonkun opened a new pull request, #1007: URL: https://github.com/apache/pulsar-client-go/pull/1007 This closes #1005. ### Modifications *Describe the modifications you've done.* ### Verifying this change - [x] Make sure that the change passes the CI checks.

[GitHub] [pulsar-client-go] tisonkun commented on pull request #1004: test: test ci lint

2023-04-10 Thread via GitHub
tisonkun commented on PR #1004: URL: https://github.com/apache/pulsar-client-go/pull/1004#issuecomment-1501827529 I'm taking over #1005 and open a new PR at #1007. Welcome to give a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar-client-go] tisonkun closed pull request #1004: test: test ci lint

2023-04-10 Thread via GitHub
tisonkun closed pull request #1004: test: test ci lint URL: https://github.com/apache/pulsar-client-go/pull/1004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] codecov-commenter commented on pull request #20009: PIP-254: Support configuring client version

2023-04-10 Thread via GitHub
codecov-commenter commented on PR #20009: URL: https://github.com/apache/pulsar/pull/20009#issuecomment-1501838882 ## [Codecov](https://codecov.io/gh/apache/pulsar/pull/20009?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] tisonkun commented on issue #19905: [Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files

2023-04-10 Thread via GitHub
tisonkun commented on issue #19905: URL: https://github.com/apache/pulsar/issues/19905#issuecomment-1501840947 @lhotari any feedback or new instance? I don't find a similar case now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20030: [fix][metrics] Fix the reason label of authentication metrics

2023-04-10 Thread via GitHub
mattisonchao commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1161752440 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderBasic.java: ## @@ -104,10 +105,11 @@ public String

[GitHub] [pulsar] mattisonchao commented on pull request #20030: [fix][metrics] Fix the reason label of authentication metrics

2023-04-10 Thread via GitHub
mattisonchao commented on PR #20030: URL: https://github.com/apache/pulsar/pull/20030#issuecomment-1501868653 @michaeljmarshall would you mind to taking a look here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] mattisonchao commented on pull request #20050: [fix] [ml] Fix uncompleted future when remove cursor

2023-04-10 Thread via GitHub
mattisonchao commented on PR #20050: URL: https://github.com/apache/pulsar/pull/20050#issuecomment-1501869814 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] tisonkun commented on issue #19785: [Bug] pulsar admin client in pulsar-client-all logs a ClassNotFoundException at startup

2023-04-10 Thread via GitHub
tisonkun commented on issue #19785: URL: https://github.com/apache/pulsar/issues/19785#issuecomment-1501875429 This should be expected. The class `org.conscrypt.Conscrypt` is not shaded, and it's logically different from the Netty's one. Please check if it's a non-fatal exception and

[GitHub] [pulsar] jeantil edited a discussion: pulsar admin client in pulsar-client-all logs a ClassNotFoundException at startup

2023-04-10 Thread GitBox
GitHub user jeantil edited a discussion: pulsar admin client in pulsar-client-all logs a ClassNotFoundException at startup ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 2.11.0 ### Minimal

[GitHub] [pulsar] tisonkun closed issue #19785: [Bug] pulsar admin client in pulsar-client-all logs a ClassNotFoundException at startup

2023-04-10 Thread via GitHub
tisonkun closed issue #19785: [Bug] pulsar admin client in pulsar-client-all logs a ClassNotFoundException at startup URL: https://github.com/apache/pulsar/issues/19785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] tisonkun added a comment to the discussion: [Bug] pulsar admin client in pulsar-client-all logs a ClassNotFoundException at startup

2023-04-10 Thread GitBox
GitHub user tisonkun added a comment to the discussion: [Bug] pulsar admin client in pulsar-client-all logs a ClassNotFoundException at startup This should be expected. The class `org.conscrypt.Conscrypt` is not shaded, and it's logically different from the Netty's one. Please check if it's

[GitHub] [pulsar] tisonkun commented on issue #20013: CVE-2022-1471 identified on pulsar client for snakeyaml's SafeConstructor usage mandate

2023-04-10 Thread via GitHub
tisonkun commented on issue #20013: URL: https://github.com/apache/pulsar/issues/20013#issuecomment-1501879975 > in buildtools pom.xml Yes. It's unnormal. We should remove it or move it to the `dependencyManagement` group. > and parent pom.xml No. It's only in the

[GitHub] [pulsar] tisonkun commented on issue #20013: CVE-2022-1471 identified on pulsar client for snakeyaml's SafeConstructor usage mandate

2023-04-10 Thread via GitHub
tisonkun commented on issue #20013: URL: https://github.com/apache/pulsar/issues/20013#issuecomment-1501881962 > 2.15 hasn't been released yet, it's currently 2.15.0-rc2 . > Perhaps we should consider Jackson 2.15 for Pulsar 3.0 ? Yeah. I noticed that jackson 2.15 is unreleased

[GitHub] [pulsar] shibd commented on issue #18616: PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2023-04-10 Thread via GitHub
shibd commented on issue #18616: URL: https://github.com/apache/pulsar/issues/18616#issuecomment-1501882347 > @BewareMyPower : serializing and deserializing is expensive and on top of that having different APIs for different use cases is creating a really bad experience for users, and I

[GitHub] [pulsar] shibd commented on a diff in pull request #20040: [improve][client] PIP-224: Add getLastMessageIds API

2023-04-10 Thread via GitHub
shibd commented on code in PR #20040: URL: https://github.com/apache/pulsar/pull/20040#discussion_r1161756544 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TopicsConsumerImplTest.java: ## @@ -1170,6 +1193,20 @@ public void testGetLastMessageId() throws Exception

[GitHub] [pulsar-client-go] shibd commented on pull request #1007: ci: stablize golangci-lint task

2023-04-10 Thread via GitHub
shibd commented on PR #1007: URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1501891144 @tisonkun Please help explain why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] codecov-commenter commented on pull request #19815: [fix] [txn] fix consumer can receive aborted txn message when readType is replay

2023-04-10 Thread via GitHub
codecov-commenter commented on PR #19815: URL: https://github.com/apache/pulsar/pull/19815#issuecomment-1501992460 ## [Codecov](https://codecov.io/gh/apache/pulsar/pull/19815?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] poorbarcode commented on pull request #19432: [improve] Allow to build and push multi-arch Docker images

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19432: URL: https://github.com/apache/pulsar/pull/19432#issuecomment-1502057131 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #20026: [improve][broker] Prevent range conflicts with Key Shared sticky consumers when TCP/IP connections get orphaned

2023-04-10 Thread via GitHub
michaeljmarshall commented on code in PR #20026: URL: https://github.com/apache/pulsar/pull/20026#discussion_r1162017346 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/HashRangeExclusiveStickyKeyConsumerSelector.java: ## @@ -52,8 +54,23 @@ public

[pulsar] branch master updated: [feat] PIP-257: Add AuthenticationProviderOpenID (#19849)

2023-04-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 11751b7da23 [feat] PIP-257: Add

[GitHub] [pulsar] michaeljmarshall merged pull request #19849: [feat] PIP-257: Add AuthenticationProviderOpenID

2023-04-10 Thread via GitHub
michaeljmarshall merged PR #19849: URL: https://github.com/apache/pulsar/pull/19849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] poorbarcode commented on pull request #17964: [improvement][pulsar-broker] Admin API should be able to return messages in human-readable formats.

2023-04-10 Thread via GitHub
poorbarcode commented on PR #17964: URL: https://github.com/apache/pulsar/pull/17964#issuecomment-1502051004 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] poorbarcode commented on pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19944: URL: https://github.com/apache/pulsar/pull/19944#issuecomment-1502062686 Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged. - The PR of type `feature` is deferred to `3.1.0`

[GitHub] [pulsar] svabra added a comment to the discussion: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql

2023-04-10 Thread GitBox
GitHub user svabra added a comment to the discussion: [Bug] Failed to pull-up docker-compose for broker, bookie, zk and pulsar-sql @tisonkun thanks for having a look. Yes, as Java Developer I know. But, think of it not for me, but for people new to Pulsar and PulsarSQL. Why are we not

[GitHub] [pulsar-helm-chart] chrisjohnson00 commented on pull request #356: fix: proxy should not use priviledged port numbers

2023-04-10 Thread via GitHub
chrisjohnson00 commented on PR #356: URL: https://github.com/apache/pulsar-helm-chart/pull/356#issuecomment-1502215114 > > Oh, I hadn't noticed that both the service and the deployment shared these values. Wouldn't this make it a breaking change since the service ports would change? I'd

  1   2   3   >