[GitHub] [pulsar] Technoboy- closed pull request #19191: [fix][client] Fix producer could send timeout when enable batching

2023-01-11 Thread GitBox
Technoboy- closed pull request #19191: [fix][client] Fix producer could send timeout when enable batching URL: https://github.com/apache/pulsar/pull/19191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] github-actions[bot] commented on issue #18880: [Bug] The topic message storageSize is 0, Cannot skip msgBacklog for consumer

2023-01-11 Thread GitBox
github-actions[bot] commented on issue #18880: URL: https://github.com/apache/pulsar/issues/18880#issuecomment-1379715054 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18893: Schema Events

2023-01-11 Thread GitBox
github-actions[bot] commented on issue #18893: URL: https://github.com/apache/pulsar/issues/18893#issuecomment-1379715025 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar-client-node] shibd commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-11 Thread GitBox
shibd commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1379712158 Hi, @ericallam Thanks for your feedback. https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1378497083 I also used the cloud environment test, and

[GitHub] [pulsar] congbobo184 commented on issue #19169: [Bug][txn] exclusive subscription would lead to high cpu usage when do tailing-read

2023-01-11 Thread GitBox
congbobo184 commented on issue #19169: URL: https://github.com/apache/pulsar/issues/19169#issuecomment-1379696469 @TakaHiR07 https://github.com/apache/pulsar/pull/14286 has not been fixed. this problem is the same as https://github.com/apache/pulsar/pull/14286 -- This is an automated

[GitHub] [pulsar] tisonkun commented on issue #17900: Data driven pages - How to Submit New Content

2023-01-11 Thread GitBox
tisonkun commented on issue #17900: URL: https://github.com/apache/pulsar/issues/17900#issuecomment-1379683056 I'm going to write down my understanding about the technical part to update content on the website in this week or the next. About the approval process, I'll submit a

[GitHub] [pulsar] tisonkun commented on issue #18960: [Doc] Documentation site search navigates to the end of the page

2023-01-11 Thread GitBox
tisonkun commented on issue #18960: URL: https://github.com/apache/pulsar/issues/18960#issuecomment-1379681387 OK. I get the point now. I have met this issue ever that the anchor doesn't work as expected. It may not be caused by the search mechanism but by anchor resolution. cc

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19197: [feat][broker] Update AuthenticationProvider to simplify HTTP Authn

2023-01-11 Thread GitBox
michaeljmarshall opened a new pull request, #19197: URL: https://github.com/apache/pulsar/pull/19197 PIP: https://github.com/apache/pulsar/issues/12105 ### Motivation This is the first of several PRs to implement [PIP 97](https://github.com/apache/pulsar/issues/12105).

[GitHub] [pulsar] zbentley opened a new issue, #19196: [Doc] 2.10* docs provide incorrect command for `namespace set-backlog-quota`

2023-01-11 Thread GitBox
zbentley opened a new issue, #19196: URL: https://github.com/apache/pulsar/issues/19196 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? [This

[GitHub] [pulsar-client-node] ericallam commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-11 Thread GitBox
ericallam commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1379490483 I have 1.7.0 working just fine locally, but it's connecting to a local docker container running and I don't use any authentication. This has only started once I've tried to

[GitHub] [pulsar-client-node] ericallam commented on issue #283: Advice for how to install this package in a Docker container

2023-01-11 Thread GitBox
ericallam commented on issue #283: URL: https://github.com/apache/pulsar-client-node/issues/283#issuecomment-1379478768 Not sure if it'll help but here is the issue where nodejs discusses replacing OpenSSL 1.1 with 3.0: https://github.com/nodejs/node/issues/40106 -- This is an automated

[GitHub] [pulsar-client-node] ericallam commented on issue #283: Advice for how to install this package in a Docker container

2023-01-11 Thread GitBox
ericallam commented on issue #283: URL: https://github.com/apache/pulsar-client-node/issues/283#issuecomment-1379474549 And for reference here is the Dockerfile: https://gist.github.com/ericallam/a59beb06dfaeb586fbd3a20d1ffd5eb8 -- This is an automated message from the Apache Git

[GitHub] [pulsar-client-node] ericallam commented on issue #283: Advice for how to install this package in a Docker container

2023-01-11 Thread GitBox
ericallam commented on issue #283: URL: https://github.com/apache/pulsar-client-node/issues/283#issuecomment-1379466260 Here's the segment log: ``` 8:25:40 PM: Connecting to pulsar instance at pulsar+ssl://..snio.cloud:6651... 8:25:40 PM:  Connected to pulsar at

[GitHub] [pulsar] zbentley opened a new issue, #19195: "latest" tag in Docker Hub points to a 6 month old version, but 2.11.0 image is 2 days old

2023-01-11 Thread GitBox
zbentley opened a new issue, #19195: URL: https://github.com/apache/pulsar/issues/19195 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version "latest" docker image. ###

[GitHub] [pulsar] michaeljmarshall merged pull request #19184: [fix][broker] Pass subName for subscription operations in ServerCnx

2023-01-11 Thread GitBox
michaeljmarshall merged PR #19184: URL: https://github.com/apache/pulsar/pull/19184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] clayburn opened a new pull request, #19194: [improve][ci] Gradle Enterprise Configuration Tweaks

2023-01-11 Thread GitBox
clayburn opened a new pull request, #19194: URL: https://github.com/apache/pulsar/pull/19194 ### Motivation This change updates the Gradle Enterprise configuration in a few small ways to keep the configuration up to date with best practices. ### Modifications

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #18810: [improve][broker] PIP-192: Implement broker registry for new load manager

2023-01-11 Thread GitBox
heesung-sn commented on code in PR #18810: URL: https://github.com/apache/pulsar/pull/18810#discussion_r1067328842 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] poorbarcode commented on pull request #19193: [fix] [doc] fix multiple apis in the automatically generated documentation use the same anchor point

2023-01-11 Thread GitBox
poorbarcode commented on PR #19193: URL: https://github.com/apache/pulsar/pull/19193#issuecomment-1379281827 Hi @dave2wave > These look like actual API changes. Please explain. Already changed the plain to only modify Swagger annotations. please take a look again -- This

[GitHub] [pulsar] poorbarcode opened a new pull request, #19193: [fix] [doc] [fix] [doc] fix multiple apis in the automatically generated documentation use the same anchor point

2023-01-11 Thread GitBox
poorbarcode opened a new pull request, #19193: URL: https://github.com/apache/pulsar/pull/19193 ### Motivation Now that site [admin-rest-api](https://pulsar.apache.org/admin-rest-api) is automatically generated through swagger, each API in the site has its own link that we can walk

[GitHub] [pulsar] dave2wave commented on issue #19187: PIP-240: A new API to unload subscriptions

2023-01-11 Thread GitBox
dave2wave commented on issue #19187: URL: https://github.com/apache/pulsar/issues/19187#issuecomment-1379204318 I think that the terminology of `unload` is wrong. These are `reset` operations. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar-client-go] RTodorov opened a new issue, #941: How to use pulsartracing given it's an internal package

2023-01-11 Thread GitBox
RTodorov opened a new issue, #941: URL: https://github.com/apache/pulsar-client-go/issues/941 Hi there, I'm trying to produce tracing spans alongside my messages and seems like `pulsartracing` would do the job quite well. The problem is that, according to the documentation

[GitHub] [pulsar] eolivelli commented on issue #19187: PIP-240: A new API to unload subscriptions

2023-01-11 Thread GitBox
eolivelli commented on issue #19187: URL: https://github.com/apache/pulsar/issues/19187#issuecomment-1379146832 In my experience if a subscription is stuck, the problems are: - the client has some problems - 99.9% - there is a bug in Pulsar - 0.1% Unloading a topic is an

[GitHub] [pulsar-client-node] shibd commented on issue #283: Advice for how to install this package in a Docker container

2023-01-11 Thread GitBox
shibd commented on issue #283: URL: https://github.com/apache/pulsar-client-node/issues/283#issuecomment-1379131405 Hi, @ericallam You can add flow code and share Segmentation fault info: ``` const SegfaultHandler = require('segfault-handler');

[GitHub] [pulsar] yicding commented on issue #1949: Zookeeper won't start on IPV6 machines - UnknownHostException

2023-01-11 Thread GitBox
yicding commented on issue #1949: URL: https://github.com/apache/pulsar/issues/1949#issuecomment-1379070428 > Yes, I am able to reach now ..I have configured 3 zookeeper in a cluster and connection is successful > > 10:58:33.434

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19159: [improve][broker]Use cursor.isActive instead to judge if cursor is active

2023-01-11 Thread GitBox
michaeljmarshall commented on code in PR #19159: URL: https://github.com/apache/pulsar/pull/19159#discussion_r1067192865 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -3663,7 +3663,7 @@ Pair getFirstPositionAndCounter() {

[GitHub] [pulsar-client-python] erichare commented on a diff in pull request #81: Add a version attribute

2023-01-11 Thread GitBox
erichare commented on code in PR #81: URL: https://github.com/apache/pulsar-client-python/pull/81#discussion_r1067185272 ## pkg/mac/build-mac-wheels.sh: ## @@ -25,7 +25,7 @@ cd "${ROOT_DIR}" source pkg/mac/common.sh -PYTHON_CLIENT_VERSION=$(cat version.txt | xargs)

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19159: [improve][broker]Use cursor.isActive instead to judge if cursor is active

2023-01-11 Thread GitBox
michaeljmarshall commented on code in PR #19159: URL: https://github.com/apache/pulsar/pull/19159#discussion_r1067185187 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -3663,7 +3663,7 @@ Pair getFirstPositionAndCounter() {

[GitHub] [pulsar] codecov-commenter commented on pull request #19190: [fix] Some typos in Cmd classes

2023-01-11 Thread GitBox
codecov-commenter commented on PR #19190: URL: https://github.com/apache/pulsar/pull/19190#issuecomment-1379037854 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19190?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar-client-node] shibd commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-11 Thread GitBox
shibd commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1378999302 Hi, @ericallam Thanks for your feedback. I just wanted to confirm. Before v1.7.0, the same program and environment could run normally? I haven't tested with a

[GitHub] [pulsar-site] tisonkun merged pull request #377: Update the site for release 2.11.0

2023-01-11 Thread GitBox
tisonkun merged PR #377: URL: https://github.com/apache/pulsar-site/pull/377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tisonkun commented on pull request #19190: [fix] Some typos in Cmd classes

2023-01-11 Thread GitBox
tisonkun commented on PR #19190: URL: https://github.com/apache/pulsar/pull/19190#issuecomment-1378984490 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-site] Technoboy- closed pull request #376: Update the site for release 2.11.0

2023-01-11 Thread GitBox
Technoboy- closed pull request #376: Update the site for release 2.11.0 URL: https://github.com/apache/pulsar-site/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] lhotari commented on pull request #19160: [improve][misc] Use shared Jackson ObjectMapper to reduce overhead and remove ThreadLocal solution

2023-01-11 Thread GitBox
lhotari commented on PR #19160: URL: https://github.com/apache/pulsar/pull/19160#issuecomment-1378862088 > @lhotari I see the improvement here, a couple of comments: > > * wouldn't be better to only expose the read/write method + `unsafeGetInstance` ? My concern is that you could

[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #373: Update release note for 2.11.0

2023-01-11 Thread GitBox
tisonkun commented on code in PR #373: URL: https://github.com/apache/pulsar-site/pull/373#discussion_r1067072726 ## release-notes/versioned/client-cpp-2.11.0.md: ## @@ -0,0 +1,35 @@ +--- +id: client-cpp-2.11.0 Review Comment: @BewareMyPower @codelipenghui IIRC we don't

[GitHub] [pulsar-site] tisonkun merged pull request #375: Add swagger file for 2.11.0

2023-01-11 Thread GitBox
tisonkun merged PR #375: URL: https://github.com/apache/pulsar-site/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tisonkun closed issue #6415: Pulsar Multi Cluster on Kubernetes (AWS)

2023-01-11 Thread GitBox
tisonkun closed issue #6415: Pulsar Multi Cluster on Kubernetes (AWS) URL: https://github.com/apache/pulsar/issues/6415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] tisonkun commented on issue #6415: Pulsar Multi Cluster on Kubernetes (AWS)

2023-01-11 Thread GitBox
tisonkun commented on issue #6415: URL: https://github.com/apache/pulsar/issues/6415#issuecomment-1378843316 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. @michaeljmarshall @MarvinCai does

[GitHub] [pulsar] tisonkun commented on issue #6830: Encryption support in Kafka Adaptor

2023-01-11 Thread GitBox
tisonkun commented on issue #6830: URL: https://github.com/apache/pulsar/issues/6830#issuecomment-1378841653 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. IIRC kafka adapter is no longer maintained. --

[GitHub] [pulsar] tisonkun closed issue #6830: Encryption support in Kafka Adaptor

2023-01-11 Thread GitBox
tisonkun closed issue #6830: Encryption support in Kafka Adaptor URL: https://github.com/apache/pulsar/issues/6830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] tisonkun commented on issue #6885: Slash "/" should be prevented in topic names

2023-01-11 Thread GitBox
tisonkun commented on issue #6885: URL: https://github.com/apache/pulsar/issues/6885#issuecomment-1378841172 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git

[GitHub] [pulsar] tisonkun closed issue #6885: Slash "/" should be prevented in topic names

2023-01-11 Thread GitBox
tisonkun closed issue #6885: Slash "/" should be prevented in topic names URL: https://github.com/apache/pulsar/issues/6885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] tisonkun closed issue #5119: Consumers remain even though connections were already closed

2023-01-11 Thread GitBox
tisonkun closed issue #5119: Consumers remain even though connections were already closed URL: https://github.com/apache/pulsar/issues/5119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tisonkun commented on issue #5119: Consumers remain even though connections were already closed

2023-01-11 Thread GitBox
tisonkun commented on issue #5119: URL: https://github.com/apache/pulsar/issues/5119#issuecomment-1378840748 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun closed issue #5394: Add ability to truncate raw partition after compaction

2023-01-11 Thread GitBox
tisonkun closed issue #5394: Add ability to truncate raw partition after compaction URL: https://github.com/apache/pulsar/issues/5394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] tisonkun commented on issue #5394: Add ability to truncate raw partition after compaction

2023-01-11 Thread GitBox
tisonkun commented on issue #5394: URL: https://github.com/apache/pulsar/issues/5394#issuecomment-1378840352 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git

[GitHub] [pulsar] tisonkun closed issue #3343: Proxy shouldn't require both brokerWebServiceURL & brokerServiceURL if http is being used for lookup

2023-01-11 Thread GitBox
tisonkun closed issue #3343: Proxy shouldn't require both brokerWebServiceURL & brokerServiceURL if http is being used for lookup URL: https://github.com/apache/pulsar/issues/3343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] tisonkun commented on issue #3343: Proxy shouldn't require both brokerWebServiceURL & brokerServiceURL if http is being used for lookup

2023-01-11 Thread GitBox
tisonkun commented on issue #3343: URL: https://github.com/apache/pulsar/issues/3343#issuecomment-1378839036 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git

[GitHub] [pulsar] tisonkun commented on issue #3351: brokerWebServiceURL should not be required in proxy conf

2023-01-11 Thread GitBox
tisonkun commented on issue #3351: URL: https://github.com/apache/pulsar/issues/3351#issuecomment-1378838861 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git

[GitHub] [pulsar] tisonkun closed issue #3351: brokerWebServiceURL should not be required in proxy conf

2023-01-11 Thread GitBox
tisonkun closed issue #3351: brokerWebServiceURL should not be required in proxy conf URL: https://github.com/apache/pulsar/issues/3351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] tisonkun closed issue #4850: Generate publish time of message at broker side

2023-01-11 Thread GitBox
tisonkun closed issue #4850: Generate publish time of message at broker side URL: https://github.com/apache/pulsar/issues/4850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] tisonkun commented on issue #4900: Dispatch throttling might prevent consumers from receiving messages

2023-01-11 Thread GitBox
tisonkun commented on issue #4900: URL: https://github.com/apache/pulsar/issues/4900#issuecomment-1378838416 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun commented on issue #4850: Generate publish time of message at broker side

2023-01-11 Thread GitBox
tisonkun commented on issue #4850: URL: https://github.com/apache/pulsar/issues/4850#issuecomment-1378838651 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git

[GitHub] [pulsar] tisonkun closed issue #4900: Dispatch throttling might prevent consumers from receiving messages

2023-01-11 Thread GitBox
tisonkun closed issue #4900: Dispatch throttling might prevent consumers from receiving messages URL: https://github.com/apache/pulsar/issues/4900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] tisonkun closed issue #4908: admin.topics.createNonPartitionedTopic issue when disable allowAutoTopicCreation

2023-01-11 Thread GitBox
tisonkun closed issue #4908: admin.topics.createNonPartitionedTopic issue when disable allowAutoTopicCreation URL: https://github.com/apache/pulsar/issues/4908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] tisonkun commented on issue #4908: admin.topics.createNonPartitionedTopic issue when disable allowAutoTopicCreation

2023-01-11 Thread GitBox
tisonkun commented on issue #4908: URL: https://github.com/apache/pulsar/issues/4908#issuecomment-1378838098 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git

[GitHub] [pulsar] tisonkun closed issue #3288: [feature request] allow consumers joining in standby state in failover subscription

2023-01-11 Thread GitBox
tisonkun closed issue #3288: [feature request] allow consumers joining in standby state in failover subscription URL: https://github.com/apache/pulsar/issues/3288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] tisonkun commented on issue #3288: [feature request] allow consumers joining in standby state in failover subscription

2023-01-11 Thread GitBox
tisonkun commented on issue #3288: URL: https://github.com/apache/pulsar/issues/3288#issuecomment-1378837073 Closed as stale. May be fixed by #11974. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] tisonkun commented on issue #19122: no org_apache_pulsar_shade_netty_tcnative_x86_64 in java.library.path

2023-01-11 Thread GitBox
tisonkun commented on issue #19122: URL: https://github.com/apache/pulsar/issues/19122#issuecomment-1378835803 @BewareMyPower @merlimat @nicoloboschi do we provide compatibility to run on Win? If we don't maintain it, I'd prefer to close as won't fix or if @tianjingle can provide a patch

[GitHub] [pulsar-client-node] ericallam commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-11 Thread GitBox
ericallam commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1378823571 I don't think this is an macOS issue. I tried running 1.8.0 in a docker container (built and run on linux) and I'm getting a similar error: ```

[GitHub] [pulsar] yyj8 commented on pull request #19047: [improve][broker]PIP-214 Add broker level metrics statistics and expose to prometheus

2023-01-11 Thread GitBox
yyj8 commented on PR #19047: URL: https://github.com/apache/pulsar/pull/19047#issuecomment-1378818840 > Don't forget about the comment line Modification completed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] yyj8 commented on a diff in pull request #19047: [improve][broker]PIP-214 Add broker level metrics statistics and expose to prometheus

2023-01-11 Thread GitBox
yyj8 commented on code in PR #19047: URL: https://github.com/apache/pulsar/pull/19047#discussion_r1067043480 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java: ## @@ -358,6 +358,101 @@ public void testPerTopicStats() throws Exception {

[GitHub] [pulsar] yyj8 commented on a diff in pull request #19047: [improve][broker]PIP-214 Add broker level metrics statistics and expose to prometheus

2023-01-11 Thread GitBox
yyj8 commented on code in PR #19047: URL: https://github.com/apache/pulsar/pull/19047#discussion_r1067042957 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java: ## @@ -358,6 +358,101 @@ public void testPerTopicStats() throws Exception {

[GitHub] [pulsar] AnonHxy opened a new pull request, #19191: [fix][client] Fix producer could send timeout when enable batching

2023-01-11 Thread GitBox
AnonHxy opened a new pull request, #19191: URL: https://github.com/apache/pulsar/pull/19191 Fixes https://github.com/apache/pulsar/issues/19189 ### Motivation Fixes https://github.com/apache/pulsar/issues/19189 ### Modifications Trigger send if

[GitHub] [pulsar] Nicklee007 opened a new pull request, #19190: [typos]fix some typos in cmd

2023-01-11 Thread GitBox
Nicklee007 opened a new pull request, #19190: URL: https://github.com/apache/pulsar/pull/19190 ### Motivation Fix some typos ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` (Please explain

[GitHub] [pulsar] AnonHxy opened a new issue, #19189: [Bug] producer send timeout when enable batching

2023-01-11 Thread GitBox
AnonHxy opened a new issue, #19189: URL: https://github.com/apache/pulsar/issues/19189 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version lastest master ### Minimal

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

2023-01-11 Thread GitBox
Nicklee007 commented on PR #16563: URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1378735150 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-node] ericallam commented on issue #283: Advice for how to install this package in a Docker container

2023-01-11 Thread GitBox
ericallam commented on issue #283: URL: https://github.com/apache/pulsar-client-node/issues/283#issuecomment-1378712685 I just confirmed that i am getting a segfault (pulled the image and in a run the following code in a node repl) ```js const Pulsar = require("pulsar-client");

[GitHub] [pulsar] AnonHxy commented on pull request #19173: [fix][broker] Fix bk config file path in pulsarStandalone

2023-01-11 Thread GitBox
AnonHxy commented on PR #19173: URL: https://github.com/apache/pulsar/pull/19173#issuecomment-1378694433 It not very clear about this change, so I colse it now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] AnonHxy closed pull request #19173: [fix][broker] Fix bk config file path in pulsarStandalone

2023-01-11 Thread GitBox
AnonHxy closed pull request #19173: [fix][broker] Fix bk config file path in pulsarStandalone URL: https://github.com/apache/pulsar/pull/19173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tisonkun merged pull request #19188: [fix][cli] Shell syntax

2023-01-11 Thread GitBox
tisonkun merged PR #19188: URL: https://github.com/apache/pulsar/pull/19188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tisonkun commented on pull request #19188: [fix][cli] Shell syntax

2023-01-11 Thread GitBox
tisonkun commented on PR #19188: URL: https://github.com/apache/pulsar/pull/19188#issuecomment-1378651069 Thanks for your review! Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] gaozhangmin merged pull request #19159: [improve][broker]Use cursor.isActive instead to judge if cursor is active

2023-01-11 Thread GitBox
gaozhangmin merged PR #19159: URL: https://github.com/apache/pulsar/pull/19159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-11 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066889404 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/CombinedSegmentDelayedIndexQueue.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] codecov-commenter commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

2023-01-11 Thread GitBox
codecov-commenter commented on PR #16563: URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1378606842 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

2023-01-11 Thread GitBox
Nicklee007 commented on PR #16563: URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1378588143 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

2023-01-11 Thread GitBox
Nicklee007 commented on PR #16563: URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1378587400 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] gaozhangmin merged pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

2023-01-11 Thread GitBox
gaozhangmin merged PR #16780: URL: https://github.com/apache/pulsar/pull/16780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on a diff in pull request #19161: [improve][common] Add and register Jackson Java 8 support modules to Pulsar

2023-01-11 Thread GitBox
lhotari commented on code in PR #19161: URL: https://github.com/apache/pulsar/pull/19161#discussion_r1066849141 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/ObjectMapperFactory.java: ## @@ -109,7 +112,10 @@ @Slf4j public class ObjectMapperFactory { public

[GitHub] [pulsar] liangyepianzhou merged pull request #19181: [branch-2.10][fix] Fix the compile issue of Branch-2.10

2023-01-11 Thread GitBox
liangyepianzhou merged PR #19181: URL: https://github.com/apache/pulsar/pull/19181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #139: [feat] Support Dead Letter Topic.

2023-01-11 Thread GitBox
shibd commented on code in PR #139: URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1066823262 ## tests/DeadLetterQueueTest.cc: ## @@ -0,0 +1,438 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [pulsar-client-go] aristotelism commented on pull request #914: Move out the auth package from internal

2023-01-11 Thread GitBox
aristotelism commented on PR #914: URL: https://github.com/apache/pulsar-client-go/pull/914#issuecomment-1378531671 @liangyuanpeng hi , is it possible to create a release with this change? Thanks -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-client-node] ericallam opened a new issue, #283: Advice for how to install this package in a Docker container

2023-01-11 Thread GitBox
ericallam opened a new issue, #283: URL: https://github.com/apache/pulsar-client-node/issues/283 I'm using Pulsar in [trigger.dev](https://github.com/triggerdotdev/trigger.dev) and I'm trying to deploy a Node.js web service that has a dependency on this package in a Docker container. I'm

[GitHub] [pulsar] lhotari commented on a diff in pull request #19161: [improve][common] Add and register Jackson Java 8 support modules to Pulsar

2023-01-11 Thread GitBox
lhotari commented on code in PR #19161: URL: https://github.com/apache/pulsar/pull/19161#discussion_r1066794043 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/ObjectMapperFactory.java: ## @@ -109,7 +112,10 @@ @Slf4j public class ObjectMapperFactory { public

[GitHub] [pulsar-client-node] ericallam commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-11 Thread GitBox
ericallam commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1378497083 Okay I'm working on testing this now. I started with Building from source using the steps in the README on the `master` branch without the fix to make sure I could reproduce

[GitHub] [pulsar] tisonkun opened a new pull request, #19188: [fix][cli] Shell syntax

2023-01-11 Thread GitBox
tisonkun opened a new pull request, #19188: URL: https://github.com/apache/pulsar/pull/19188 ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency)

[GitHub] [pulsar] tisonkun commented on a diff in pull request #16143: [improve][broker]Specify default nar tmp dir

2023-01-11 Thread GitBox
tisonkun commented on code in PR #16143: URL: https://github.com/apache/pulsar/pull/16143#discussion_r1066779453 ## bin/pulsar: ## @@ -307,6 +307,9 @@ if [[ -z "$IS_JAVA_8" ]]; then OPTS="$OPTS --add-opens jdk.management/com.sun.management.internal=ALL-UNNAMED" fi +#

[GitHub] [pulsar] TakaHiR07 commented on issue #19169: [Bug][txn] exclusive subscription would lead to high cpu usage when do tailing-read

2023-01-11 Thread GitBox
TakaHiR07 commented on issue #19169: URL: https://github.com/apache/pulsar/issues/19169#issuecomment-1378480776 @congbobo184 Can you help take a look of this problem ? Is this problem the same as https://github.com/apache/pulsar/pull/14286 described, and has not been fix ? -- This is an

[GitHub] [pulsar] Nicklee007 commented on a diff in pull request #16143: [improve][broker]Specify default nar tmp dir

2023-01-11 Thread GitBox
Nicklee007 commented on code in PR #16143: URL: https://github.com/apache/pulsar/pull/16143#discussion_r1066774533 ## bin/pulsar: ## @@ -307,6 +307,9 @@ if [[ -z "$IS_JAVA_8" ]]; then OPTS="$OPTS --add-opens jdk.management/com.sun.management.internal=ALL-UNNAMED" fi +#

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

2023-01-11 Thread GitBox
Nicklee007 commented on PR #16780: URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1378462160 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-11 Thread GitBox
gaoran10 commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066734215 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/CombinedSegmentDelayedIndexQueue.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-11 Thread GitBox
gaoran10 commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066725325 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-11 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066718099 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/CombinedSegmentDelayedIndexQueue.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-11 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066708378 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-11 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066708787 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/DelayedIndexQueue.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-11 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066708378 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

2023-01-11 Thread GitBox
Nicklee007 commented on PR #16780: URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1378402562 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-11 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066704678 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/TripleLongPriorityDelayedIndexQueue.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] coderzc commented on pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-11 Thread GitBox
coderzc commented on PR #19138: URL: https://github.com/apache/pulsar/pull/19138#issuecomment-1378393653 > After `BucketDelayedDeliveryTracker.recover`, part of the delayed messages will be put into the delayed message queue, but these messages may be reread by the managed cursor. Will

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #169: [feat] Add producer interceptor

2023-01-11 Thread GitBox
BewareMyPower commented on code in PR #169: URL: https://github.com/apache/pulsar-client-cpp/pull/169#discussion_r1066698932 ## include/pulsar/ProducerConfiguration.h: ## @@ -532,6 +533,10 @@ class PULSAR_PUBLIC ProducerConfiguration { */ ProducerAccessMode

[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #169: [feat] Add producer interceptor

2023-01-11 Thread GitBox
shibd commented on code in PR #169: URL: https://github.com/apache/pulsar-client-cpp/pull/169#discussion_r108816 ## include/pulsar/ProducerConfiguration.h: ## @@ -532,6 +533,10 @@ class PULSAR_PUBLIC ProducerConfiguration { */ ProducerAccessMode getAccessMode()

<    9   10   11   12   13   14   15   16   17   18   >