nodece opened a new pull request, #19266:
URL: https://github.com/apache/pulsar/pull/19266
### Motivation
Fix [CVE-2019-17571](https://www.cve.org/CVERecord?id=CVE-2019-17571)
```
Introduced through:
org.apache.pulsar:pulsar-io-jdbc-openmldb@2.12.0-SNAPSHOT ›
Technoboy- commented on code in PR #19166:
URL: https://github.com/apache/pulsar/pull/19166#discussion_r1073060471
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##
@@ -408,89 +409,160 @@ protected CompletableFuture
momo-jun opened a new pull request, #385:
URL: https://github.com/apache/pulsar-site/pull/385
Add the release blog for Pulsar version 2.11.0.
https://user-images.githubusercontent.com/60642177/213074789-94c8eb5b-b640-4bde-baef-17aa76078153.png;>
--
This is an automated message
codelipenghui opened a new issue, #19265:
URL: https://github.com/apache/pulsar/issues/19265
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Example failure
shibd commented on PR #147:
URL:
https://github.com/apache/pulsar-client-cpp/pull/147#issuecomment-1386382721
Blocked by #176 and #154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
shibd opened a new pull request, #176:
URL: https://github.com/apache/pulsar-client-cpp/pull/176
### Motivation
Currently, Reader does not support the `readNextAsync ` interface.
### Modifications
- Modify the `Consumer:receiveAsync` method to pass the parameter
Demogorgon314 commented on code in PR #19153:
URL: https://github.com/apache/pulsar/pull/19153#discussion_r1070934942
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -283,6 +286,8 @@ public class BrokerService implements Closeable {
codecov-commenter commented on PR #19154:
URL: https://github.com/apache/pulsar/pull/19154#issuecomment-1386271258
#
[Codecov](https://codecov.io/gh/apache/pulsar/pull/19154?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
heesung-sn commented on code in PR #19154:
URL: https://github.com/apache/pulsar/pull/19154#discussion_r1072701722
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/data/BrokerLoadData.java:
##
@@ -95,17 +124,35 @@ private void
hyperevo commented on issue #945:
URL:
https://github.com/apache/pulsar-client-go/issues/945#issuecomment-1386250861
Note, this base64 encoding behavior is also inconsistent with the python
client when using the same avro schema. The python consumer expects the byte
field of the avro
hyperevo opened a new issue, #945:
URL: https://github.com/apache/pulsar-client-go/issues/945
Expected behavior
Situation:
1. Using an avro schema definition where at least one field is of type byte.
2. Providing data, in the form of a native golang struct with a
codecov-commenter commented on PR #19197:
URL: https://github.com/apache/pulsar/pull/19197#issuecomment-1386167346
#
[Codecov](https://codecov.io/gh/apache/pulsar/pull/19197?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
michaeljmarshall commented on code in PR #19197:
URL: https://github.com/apache/pulsar/pull/19197#discussion_r1072885676
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java:
##
@@ -160,6 +163,20 @@ public String
lhotari commented on PR #19263:
URL: https://github.com/apache/pulsar/pull/19263#issuecomment-1386095634
To experiment, I enabled it for my fork at
https://app.codecov.io/github/lhotari/pulsar/flags . For apache/pulsar , I
don't have access so I'll have to create a ASF ticket for handling
lhotari commented on PR #19263:
URL: https://github.com/apache/pulsar/pull/19263#issuecomment-1386089839
@aymkhalil The docs for the flags feature in Codecov:
https://docs.codecov.com/docs/flags . It seems that the full feature is
disabled by default.
--
This is an automated message
lhotari commented on PR #19264:
URL: https://github.com/apache/pulsar/pull/19264#issuecomment-1386075732
I made this a draft until I have properly tested this change and fixed the
remaining issue.
--
This is an automated message from the Apache Git Service.
To respond to the message,
lhotari commented on PR #19263:
URL: https://github.com/apache/pulsar/pull/19263#issuecomment-1386074189
> I wonder if including integration tests in the code coverage report would
hide gaps in unit test coverage (unless the latter coverage metric was already
broken :/)
>
> Is there
michaeljmarshall commented on code in PR #19197:
URL: https://github.com/apache/pulsar/pull/19197#discussion_r1072833121
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java:
##
@@ -52,54 +49,12 @@ public
michaeljmarshall commented on code in PR #19197:
URL: https://github.com/apache/pulsar/pull/19197#discussion_r1072488581
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java:
##
@@ -52,54 +49,12 @@ public
aymkhalil commented on PR #19263:
URL: https://github.com/apache/pulsar/pull/19263#issuecomment-1386059133
I wonder if including integration tests in the code coverage report would
hide gaps in unit test coverage (unless the latter coverage metric was already
broken :/)
Is there a
lhotari commented on PR #19263:
URL: https://github.com/apache/pulsar/pull/19263#issuecomment-1386018657
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov-commenter commented on PR #19153:
URL: https://github.com/apache/pulsar/pull/19153#issuecomment-1386006792
#
[Codecov](https://codecov.io/gh/apache/pulsar/pull/19153?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
dlg99 commented on code in PR #19153:
URL: https://github.com/apache/pulsar/pull/19153#discussion_r1072747996
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -283,6 +286,8 @@ public class BrokerService implements Closeable {
nicoloboschi commented on code in PR #19258:
URL: https://github.com/apache/pulsar/pull/19258#discussion_r1072601878
##
pulsar-common/src/main/java/org/apache/pulsar/common/util/FutureUtil.java:
##
@@ -258,4 +259,25 @@ public static CompletionException
dlg99 commented on code in PR #19153:
URL: https://github.com/apache/pulsar/pull/19153#discussion_r1072594874
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -402,6 +407,60 @@ public BrokerService(PulsarService pulsar, EventLoopGroup
lhotari commented on PR #19264:
URL: https://github.com/apache/pulsar/pull/19264#issuecomment-1385820240
@yaalsn Please review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lhotari commented on PR #19263:
URL: https://github.com/apache/pulsar/pull/19263#issuecomment-1385819776
#19264 will also be needed to fix coverage results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lhotari opened a new pull request, #19264:
URL: https://github.com/apache/pulsar/pull/19264
### Motivation
Currently, jacoco code coverage doesn't get reported for classes that reside
in a project other than the test class.
Jacoco includes another goal "report-aggregate" which
lhotari commented on PR #19263:
URL: https://github.com/apache/pulsar/pull/19263#issuecomment-1385795480
Codecov results of the currently running PR build in the fork will be
available at
https://app.codecov.io/github/lhotari/pulsar/commit/23c1865976414a166e4ff2d6c5874937390cfc9e
--
lhotari commented on PR #19263:
URL: https://github.com/apache/pulsar/pull/19263#issuecomment-1385780263
Example of code coverage results for an earlier experiment:
https://app.codecov.io/github/lhotari/pulsar/commit/369dec198b5cf6b98cd5c52a0c32126974a8e9ac/tree
--
This is an automated
eolivelli commented on PR #19153:
URL: https://github.com/apache/pulsar/pull/19153#issuecomment-1385770466
we should VOTE the PIP before merging this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lhotari commented on issue #19083:
URL: https://github.com/apache/pulsar/issues/19083#issuecomment-1385759121
Another with with a different stacktrace.
https://github.com/lhotari/pulsar/actions/runs/3941348137/jobs/6743859727#step:11:901
```
lhotari commented on code in PR #19258:
URL: https://github.com/apache/pulsar/pull/19258#discussion_r1072491819
##
pulsar-common/src/main/java/org/apache/pulsar/common/util/FutureUtil.java:
##
@@ -258,4 +259,25 @@ public static CompletionException
michaeljmarshall commented on code in PR #19197:
URL: https://github.com/apache/pulsar/pull/19197#discussion_r1072488581
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java:
##
@@ -52,54 +49,12 @@ public
michaeljmarshall commented on code in PR #19197:
URL: https://github.com/apache/pulsar/pull/19197#discussion_r1072480950
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java:
##
@@ -52,54 +49,12 @@ public
eolivelli commented on code in PR #19153:
URL: https://github.com/apache/pulsar/pull/19153#discussion_r1072464772
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -402,6 +407,60 @@ public BrokerService(PulsarService pulsar,
michaeljmarshall commented on code in PR #19197:
URL: https://github.com/apache/pulsar/pull/19197#discussion_r1072462807
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java:
##
@@ -52,54 +49,12 @@ public
pgier closed issue #19218: pulsar-shell CTRL-C should be interpreted as cancel
the current command and should not exit the shell
URL: https://github.com/apache/pulsar/issues/19218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pgier commented on issue #19218:
URL: https://github.com/apache/pulsar/issues/19218#issuecomment-1385722332
Ah sorry, I didn't search well enough for existing issues. I wasn't using
the latest master when I noticed the issue, and didn't realize this is already
fixed.
--
This is an
michaeljmarshall commented on code in PR #19197:
URL: https://github.com/apache/pulsar/pull/19197#discussion_r1072446569
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java:
##
@@ -160,6 +163,20 @@ public String
nicoloboschi commented on code in PR #19258:
URL: https://github.com/apache/pulsar/pull/19258#discussion_r1072437151
##
pulsar-common/src/main/java/org/apache/pulsar/common/util/FutureUtil.java:
##
@@ -258,4 +259,25 @@ public static CompletionException
nicoloboschi commented on code in PR #19258:
URL: https://github.com/apache/pulsar/pull/19258#discussion_r1072436392
##
pulsar-common/src/main/java/org/apache/pulsar/common/util/FutureUtil.java:
##
@@ -258,4 +259,25 @@ public static CompletionException
shibd commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1072415206
##
.github/workflows/ci-pr-validation.yml:
##
@@ -167,6 +167,14 @@ jobs:
docker run -i -v $PWD:/pulsar-client-node build:latest \
shibd commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1072407893
##
pkg/linux/Dockerfile_linux_glibc:
##
@@ -17,15 +17,19 @@
# under the License.
#
-ARG NODE_VERSION
+FROM centos:7
-FROM node:${NODE_VERSION}-buster
shibd commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1072396071
##
tests/load-test.sh:
##
@@ -0,0 +1,42 @@
+#!/bin/bash
Review Comment:
Yes, But `docker-load-test` and `load-test.sh` are only used to test
Linux-related
shibd commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1072393932
##
tests/docker-load-test.sh:
##
@@ -0,0 +1,35 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
Technoboy- closed pull request #18934: [fix][sql] Fix presto license issue
URL: https://github.com/apache/pulsar/pull/18934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
shibd commented on PR #157:
URL:
https://github.com/apache/pulsar-client-cpp/pull/157#issuecomment-1385632278
Job failure seems to have a flaky test, can help review and rerun the job?
@BewareMyPower
--
This is an automated message from the Apache Git Service.
To respond to the
shibd commented on code in PR #175:
URL: https://github.com/apache/pulsar-client-cpp/pull/175#discussion_r1072378044
##
lib/BatchMessageAcker.h:
##
@@ -37,14 +37,16 @@ class BatchMessageAcker {
// by deserializing from raw bytes.
Review Comment:
The modification of
Technoboy- closed pull request #19246: [improve] [broker] Introduce
`metadataStoreAllowReadOnlyOperations` to deprecate
`zookeeperAllowReadOnlyOperations`
URL: https://github.com/apache/pulsar/pull/19246
--
This is an automated message from the Apache Git Service.
To respond to the message,
shibd commented on PR #175:
URL:
https://github.com/apache/pulsar-client-cpp/pull/175#issuecomment-1385625892
I have a question:
> It's because when a batched message id is constructed from
deserialization, there is no getBitSet implementation of the internal acker.
Is the
Technoboy- closed pull request #19255: [improve][websocket][branch-2.11] Add
ping support
URL: https://github.com/apache/pulsar/pull/19255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Technoboy- merged PR #19254:
URL: https://github.com/apache/pulsar/pull/19254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lhotari commented on PR #19263:
URL: https://github.com/apache/pulsar/pull/19263#issuecomment-1385624273
@yaalsn Please review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lhotari opened a new pull request, #19263:
URL: https://github.com/apache/pulsar/pull/19263
### Motivation
Code coverage metrics don't currently consider integration tests and systems
tests that are run as part of the Pulsar CI pipeline. There hasn't been a way
to measure the total
etcZYP opened a new pull request, #19262:
URL: https://github.com/apache/pulsar/pull/19262
Fixes #18932
### Motivation
Pulsar add the jcommander as dependency in pulsar-common module, but it
should be an optional dependency because most
lhotari merged PR #19252:
URL: https://github.com/apache/pulsar/pull/19252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eolivelli opened a new issue, #19261:
URL: https://github.com/apache/pulsar/issues/19261
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Motivation
Currently (Pulsar 2.11) it is
codecov-commenter commented on PR #19252:
URL: https://github.com/apache/pulsar/pull/19252#issuecomment-1385469935
#
[Codecov](https://codecov.io/gh/apache/pulsar/pull/19252?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
lhotari commented on PR #19257:
URL: https://github.com/apache/pulsar/pull/19257#issuecomment-1385465831
> @lhotari this change is not a change over the tests but it is about
Production code, I suggest to change the title
It's merged already so renaming won't help. :(
--
This is
eolivelli commented on PR #19257:
URL: https://github.com/apache/pulsar/pull/19257#issuecomment-1385463363
@lhotari this change is not a change over the tests but it is about
Production code, I suggest to change the title
--
This is an automated message from the Apache Git Service.
To
eolivelli commented on code in PR #19258:
URL: https://github.com/apache/pulsar/pull/19258#discussion_r1072233224
##
pulsar-common/src/main/java/org/apache/pulsar/common/util/FutureUtil.java:
##
@@ -258,4 +259,25 @@ public static CompletionException
asafm commented on PR #15163:
URL: https://github.com/apache/pulsar/pull/15163#issuecomment-1385449819
I'm researching integrating OTel into Pulsar and making it the one library
for all metric usages. I aim to use Meter to be able to report metrics for a
function and have libraries use the
lhotari commented on code in PR #19252:
URL: https://github.com/apache/pulsar/pull/19252#discussion_r1072224895
##
build/run_integration_group.sh:
##
@@ -64,6 +64,20 @@ mvn_run_integration_test() {
clean_arg="clean"
shift
fi
+ local use_fail_fast=1
+ if [[
lhotari commented on code in PR #19252:
URL: https://github.com/apache/pulsar/pull/19252#discussion_r1072223615
##
build/run_integration_group.sh:
##
@@ -64,6 +64,20 @@ mvn_run_integration_test() {
clean_arg="clean"
shift
fi
+ local use_fail_fast=1
+ if [[
lhotari merged PR #19257:
URL: https://github.com/apache/pulsar/pull/19257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lhotari closed issue #19216: Flaky-test: ProxyPrometheusMetricsTest.testMetrics
URL: https://github.com/apache/pulsar/issues/19216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
nicoloboschi commented on code in PR #19252:
URL: https://github.com/apache/pulsar/pull/19252#discussion_r1072214554
##
build/run_integration_group.sh:
##
@@ -64,6 +64,20 @@ mvn_run_integration_test() {
clean_arg="clean"
shift
fi
+ local use_fail_fast=1
+ if
Nicklee007 opened a new pull request, #19260:
URL: https://github.com/apache/pulsar/pull/19260
### Motivation
Some pulsar client concurrent lookup request may get different broker for
assignment when we set bundle affinity broker
and unload the bundle.
The
github-actions[bot] commented on PR #19259:
URL: https://github.com/apache/pulsar/pull/19259#issuecomment-1385402397
@chncaption Please add the following content to your PR description and
select a checkbox:
```
- [ ] `doc`
- [ ] `doc-required`
- [ ] `doc-not-needed`
- [ ]
BewareMyPower merged PR #126:
URL: https://github.com/apache/pulsar-client-cpp/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
BewareMyPower merged PR #287:
URL: https://github.com/apache/pulsar-client-node/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nicoloboschi opened a new pull request, #19258:
URL: https://github.com/apache/pulsar/pull/19258
### Motivation
In the transaction coordinator code, most of the async execution doesn't
properly runtime exceptions that might happens.
The exception is not logged and the
BewareMyPower commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1072132828
##
.github/workflows/ci-pr-validation.yml:
##
@@ -167,6 +167,14 @@ jobs:
docker run -i -v $PWD:/pulsar-client-node build:latest \
BewareMyPower commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1072132122
##
pkg/linux/Dockerfile_linux_glibc:
##
@@ -17,15 +17,19 @@
# under the License.
#
-ARG NODE_VERSION
+FROM centos:7
-FROM
BewareMyPower commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1072129496
##
tests/load-test.sh:
##
@@ -0,0 +1,42 @@
+#!/bin/bash
Review Comment:
`run-unit-tests.sh` is also Linux-related workflows.
BewareMyPower commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1072129496
##
tests/load-test.sh:
##
@@ -0,0 +1,42 @@
+#!/bin/bash
Review Comment:
`run-unit-tests.sh` is also for Linux.
BewareMyPower commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1072120707
##
tests/docker-load-test.sh:
##
@@ -0,0 +1,35 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
BewareMyPower commented on code in PR #288:
URL:
https://github.com/apache/pulsar-client-node/pull/288#discussion_r1072120707
##
tests/docker-load-test.sh:
##
@@ -0,0 +1,35 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
codecov-commenter commented on PR #19257:
URL: https://github.com/apache/pulsar/pull/19257#issuecomment-1385316033
#
[Codecov](https://codecov.io/gh/apache/pulsar/pull/19257?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
BewareMyPower opened a new pull request, #175:
URL: https://github.com/apache/pulsar-client-cpp/pull/175
### Motivation
Currently the main branch is broken by the concurrent merge of
https://github.com/apache/pulsar-client-cpp/pull/153 and
lhotari commented on PR #19252:
URL: https://github.com/apache/pulsar/pull/19252#issuecomment-1385293622
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lhotari commented on PR #19257:
URL: https://github.com/apache/pulsar/pull/19257#issuecomment-1385292876
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lhotari opened a new pull request, #19257:
URL: https://github.com/apache/pulsar/pull/19257
Fixes #19216
### Motivation
See #19216 and #19062 . Fixes a problem with pulsar-proxy flakiness related
to metrics.
### Modifications
- revert #19062 change that caused
lhotari commented on PR #19062:
URL: https://github.com/apache/pulsar/pull/19062#issuecomment-1385212474
I'm working on a revisited change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
izumo27 commented on PR #126:
URL:
https://github.com/apache/pulsar-client-cpp/pull/126#issuecomment-1385199683
> could you describe how to generate this certificates?
The certificates I added for man-in-the-middle attacks is the same as the
certificates in pulsar repository.
lhotari commented on PR #19062:
URL: https://github.com/apache/pulsar/pull/19062#issuecomment-1385190017
This change has to be reverted or revisited since it's causing a lot of
build failures. The issue is #19216.
Counters registered in static field initializers such as
lhotari commented on issue #19216:
URL: https://github.com/apache/pulsar/issues/19216#issuecomment-1385186334
This problem seems to be caused by #19062 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
splio-rbechon commented on issue #505:
URL: https://github.com/apache/pulsar-manager/issues/505#issuecomment-1385176693
Hello @malaskowski
It seems that there is an issue in startup script. Database can't be created
because binary path is not in the environment variable PATH.
nodece opened a new pull request, #19256:
URL: https://github.com/apache/pulsar/pull/19256
### Motivation
#19203 introduces `webSocketPingDurationSeconds` config, but didn't add this
config to the proxy and broker config class.
### Modifications
- Add
BewareMyPower commented on code in PR #154:
URL: https://github.com/apache/pulsar-client-cpp/pull/154#discussion_r1072023978
##
tests/ReaderTest.cc:
##
@@ -36,10 +36,69 @@ using namespace pulsar;
static std::string serviceUrl = "pulsar://localhost:6650";
static const
BewareMyPower commented on code in PR #154:
URL: https://github.com/apache/pulsar-client-cpp/pull/154#discussion_r1072008463
##
lib/ClientConnection.h:
##
@@ -65,6 +65,10 @@ class ConsumerImpl;
typedef std::shared_ptr ConsumerImplPtr;
typedef std::weak_ptr
nodece opened a new pull request, #19255:
URL: https://github.com/apache/pulsar/pull/19255
### Motivation
Cherry-pick #19203 to branch-2.11.
### Documentation
- [ ] `doc`
- [ ] `doc-required`
- [x] `doc-not-needed`
- [ ] `doc-complete`
###
BewareMyPower closed issue #87: [feature request] C++ and Python support batch
index acknowledgment
URL: https://github.com/apache/pulsar-client-cpp/issues/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
BewareMyPower merged PR #151:
URL: https://github.com/apache/pulsar-client-cpp/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
BewareMyPower merged PR #171:
URL: https://github.com/apache/pulsar-client-cpp/pull/171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
BewareMyPower commented on PR #139:
URL:
https://github.com/apache/pulsar-client-cpp/pull/139#issuecomment-1385127794
I have left the last comments. This PR overall LGTM. Please avoid committing
such a huge patch next time. If a PR contains many code changes, it would be
very hard to
BewareMyPower commented on code in PR #139:
URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1071989431
##
tests/DeadLetterQueueTest.cc:
##
@@ -0,0 +1,399 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license
shibd commented on code in PR #139:
URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1071990162
##
include/pulsar/ConsumerConfiguration.h:
##
@@ -554,6 +593,8 @@ class PULSAR_PUBLIC ConsumerConfiguration {
bool isStartMessageIdInclusive() const;
nicoloboschi commented on issue #19218:
URL: https://github.com/apache/pulsar/issues/19218#issuecomment-1385104892
I was using a wrong artifact. It works fine also with the artifact here:
https://pulsar.apache.org/download/
Have you tried with a command that hangs ? For example, with
701 - 800 of 133596 matches
Mail list logo
