[GitHub] jerrypeng commented on issue #1833: adding worker to instance health check

jerrypeng commented on issue #1833: adding worker to instance health check URL: https://github.com/apache/incubator-pulsar/pull/1833#issuecomment-391221899 @srkukarni I have added the check for python as well. Please review again

[GitHub] srkukarni commented on a change in pull request #1833: adding worker to instance health check

srkukarni commented on a change in pull request #1833: adding worker to instance health check URL: https://github.com/apache/incubator-pulsar/pull/1833#discussion_r190090206 ## File path: pulsar-functions/proto/src/main/proto/InstanceCommunication.proto ## @@ -65,7 +65,12

[GitHub] jerrypeng commented on issue #1833: adding worker to instance health check

jerrypeng commented on issue #1833: adding worker to instance health check URL: https://github.com/apache/incubator-pulsar/pull/1833#issuecomment-391187925 @srkukarni I have refactored based on our discussion This is an automa

[GitHub] bruth commented on issue #1764: WIP - Pulsar Go client library

bruth commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-391183835 Great changes. > This I think is more related to cgo and MacOS. I have the same but it was working on linux. Good to know. I will be

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r190093869 ## File path: pulsar-client-go/pulsar/logger.go ## @@ -0,0 +1,48 @@ +// +// Licensed to the Apache Software Fou

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r190093775 ## File path: pulsar-client-go/pulsar/logger.go ## @@ -0,0 +1,48 @@ +// +// Licensed to the Apache Software Fou

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r190093685 ## File path: pulsar-client-go/pulsar/logger.go ## @@ -0,0 +1,48 @@ +// +// Licensed to the Apache Software Fou

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r190093609 ## File path: pulsar-client-go/pulsar/logger.go ## @@ -0,0 +1,48 @@ +// +// Licensed to the Apache Software Fou

[GitHub] jerrypeng commented on a change in pull request #1833: adding worker to instance health check

jerrypeng commented on a change in pull request #1833: adding worker to instance health check URL: https://github.com/apache/incubator-pulsar/pull/1833#discussion_r190091037 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/ThreadRuntime.java

[GitHub] srkukarni commented on a change in pull request #1833: adding worker to instance health check

srkukarni commented on a change in pull request #1833: adding worker to instance health check URL: https://github.com/apache/incubator-pulsar/pull/1833#discussion_r190090344 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/ThreadRuntime.java

[GitHub] srkukarni commented on a change in pull request #1833: adding worker to instance health check

srkukarni commented on a change in pull request #1833: adding worker to instance health check URL: https://github.com/apache/incubator-pulsar/pull/1833#discussion_r190090206 ## File path: pulsar-functions/proto/src/main/proto/InstanceCommunication.proto ## @@ -65,7 +65,12

[GitHub] merlimat opened a new pull request #1834: Added Homebrew recipe for C++ client library

merlimat opened a new pull request #1834: Added Homebrew recipe for C++ client library URL: https://github.com/apache/incubator-pulsar/pull/1834 ### Motivation Added recipe to build C++ client library on Mac for Homebrew. First step is to include the recipe here. The final go

[GitHub] merlimat commented on issue #1764: WIP - Pulsar Go client library

merlimat commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-391173087 > Rename MessageBuilder to a ProducerMessage since it is no longer implements a builder pattern? Yes, I didn't want to call it `Message`

[GitHub] jerrypeng commented on issue #1833: adding worker to instance health check

jerrypeng commented on issue #1833: adding worker to instance health check URL: https://github.com/apache/incubator-pulsar/pull/1833#issuecomment-391169292 @srkukarni @sijie please review This is an automated message from the

[GitHub] jerrypeng opened a new pull request #1833: adding worker to instance health check

jerrypeng opened a new pull request #1833: adding worker to instance health check URL: https://github.com/apache/incubator-pulsar/pull/1833 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Modificati

[GitHub] jerrypeng closed pull request #1828: instance worker health check

jerrypeng closed pull request #1828: instance worker health check URL: https://github.com/apache/incubator-pulsar/pull/1828 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Don't set Pulsar Memory if variable is already set (#1831)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 928ba3d Don't set Pulsar Memory if var

[GitHub] sijie closed pull request #1831: Don't set Pulsar Memory if variable is already set

sijie closed pull request #1831: Don't set Pulsar Memory if variable is already set URL: https://github.com/apache/incubator-pulsar/pull/1831 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] merlimat commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected

merlimat commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#discussion_r190065269 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java ##

[GitHub] jai1 commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected

jai1 commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#discussion_r190063721 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java ##

[GitHub] merlimat commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected

merlimat commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#discussion_r190061354 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java ##

[GitHub] jai1 commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected

jai1 commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#discussion_r190060863 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java ##

[GitHub] merlimat commented on a change in pull request #1832: Update topic names

merlimat commented on a change in pull request #1832: Update topic names URL: https://github.com/apache/incubator-pulsar/pull/1832#discussion_r190031416 ## File path: site/docs/latest/adaptors/KafkaWrapper.md ## @@ -81,7 +74,7 @@ instead of `org.apache.kafka.clients.produce

[GitHub] merlimat closed pull request #1827: Added option for custom loggers in C++ and C APIs

merlimat closed pull request #1827: Added option for custom loggers in C++ and C APIs URL: https://github.com/apache/incubator-pulsar/pull/1827 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[incubator-pulsar] branch master updated: Added option for custom loggers in C++ and C APIs (#1827)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 26b181e Added option for custom logge

[GitHub] srkukarni commented on issue #1831: Don't set Pulsar Memory if variable is already set

srkukarni commented on issue #1831: Don't set Pulsar Memory if variable is already set URL: https://github.com/apache/incubator-pulsar/pull/1831#issuecomment-391099823 @sijie changed This is an automated message from the Apa

[incubator-pulsar] branch master updated: Add Pulsar Functions API docs to site build (#1830)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6ea9d85 Add Pulsar Functions API docs

[GitHub] merlimat closed pull request #1830: Add Pulsar Functions API docs to site build

merlimat closed pull request #1830: Add Pulsar Functions API docs to site build URL: https://github.com/apache/incubator-pulsar/pull/1830 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] sijie commented on a change in pull request #1831: Don't set Pulsar Memory if variable is already set

sijie commented on a change in pull request #1831: Don't set Pulsar Memory if variable is already set URL: https://github.com/apache/incubator-pulsar/pull/1831#discussion_r190008560 ## File path: conf/pulsar_tools_env.sh ## @@ -42,7 +42,9 @@ # PULSAR_GLOBAL_ZK_CONF= #

[GitHub] lucperkins opened a new pull request #1832: Update topic names

lucperkins opened a new pull request #1832: Update topic names URL: https://github.com/apache/incubator-pulsar/pull/1832 This PR updates all example topic names in the docs to use the new system (default tenant and namespace, no cluster component, etc.)

[GitHub] srkukarni commented on issue #1831: Don't set Pulsar Memory if variable is already set

srkukarni commented on issue #1831: Don't set Pulsar Memory if variable is already set URL: https://github.com/apache/incubator-pulsar/pull/1831#issuecomment-391091707 @sijie This is an automated message from the Apache Git

[GitHub] srkukarni opened a new pull request #1831: Don't set Pulsar Memory if variable is already set

srkukarni opened a new pull request #1831: Don't set Pulsar Memory if variable is already set URL: https://github.com/apache/incubator-pulsar/pull/1831 ### Motivation This allows users to be able to increase memory for certain admin commands by overriding PULSAR_MEM in their command lin

[GitHub] srkukarni commented on issue #1816: Removed internal shading

srkukarni commented on issue #1816: Removed internal shading URL: https://github.com/apache/incubator-pulsar/pull/1816#issuecomment-391086277 retest this please This is an automated message from the Apache Git Service. To resp

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-390793348 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-391073380 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] lucperkins opened a new pull request #1830: Add Pulsar Functions API docs to site build

lucperkins opened a new pull request #1830: Add Pulsar Functions API docs to site build URL: https://github.com/apache/incubator-pulsar/pull/1830 This is an automated message from the Apache Git Service. To respond to the me

[incubator-pulsar] branch master updated: In S3 offloader, dont use InputStream#available for stream length (#1807)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 48e1131 In S3 offloader, dont use Inp

[GitHub] merlimat closed pull request #1807: In S3 offloader, dont use InputStream#available for stream length

merlimat closed pull request #1807: In S3 offloader, dont use InputStream#available for stream length URL: https://github.com/apache/incubator-pulsar/pull/1807 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of p

[GitHub] srkukarni commented on issue #1816: Removed internal shading

srkukarni commented on issue #1816: Removed internal shading URL: https://github.com/apache/incubator-pulsar/pull/1816#issuecomment-391052398 retest this please This is an automated message from the Apache Git Service. To resp

[GitHub] ivankelly opened a new pull request #1829: Integration test for s3offload

ivankelly opened a new pull request #1829: Integration test for s3offload URL: https://github.com/apache/incubator-pulsar/pull/1829 Starts a cluster with s3offload enabled. Write enough entries to roll the ledger. Offload. Manually delete the first ledger. Reboot cluster to clear cache

[GitHub] merlimat closed pull request #1800: Docker testing init script has wrong service url

merlimat closed pull request #1800: Docker testing init script has wrong service url URL: https://github.com/apache/incubator-pulsar/pull/1800 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[incubator-pulsar] branch master updated: Docker testing init script has wrong service url (#1800)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e98d50a Docker testing init script ha

[GitHub] srkukarni commented on issue #1816: Removed internal shading

srkukarni commented on issue #1816: Removed internal shading URL: https://github.com/apache/incubator-pulsar/pull/1816#issuecomment-391033267 retest this please This is an automated message from the Apache Git Service. To resp

[GitHub] ivankelly commented on issue #1806: Use our own minimal S3Mock rather than findify S3Mock

ivankelly commented on issue #1806: Use our own minimal S3Mock rather than findify S3Mock URL: https://github.com/apache/incubator-pulsar/pull/1806#issuecomment-391030648 test failing, looks legit. Will look into it. This is

[GitHub] ivankelly commented on issue #1807: In S3 offloader, dont use InputStream#available for stream length

ivankelly commented on issue #1807: In S3 offloader, dont use InputStream#available for stream length URL: https://github.com/apache/incubator-pulsar/pull/1807#issuecomment-391017684 retest this please // BatchMessageTest.testBatchAndNonBatchCumulativeAcks & c++ --

[GitHub] merlimat closed pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength

merlimat closed pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength URL: https://github.com/apache/incubator-pulsar/pull/1799 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[incubator-pulsar] branch master updated: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength (#1799)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ca9099d BlockAwareSegmentInputStreamI

[GitHub] merlimat commented on a change in pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength

merlimat commented on a change in pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength URL: https://github.com/apache/incubator-pulsar/pull/1799#discussion_r189908975 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/im

[GitHub] ivankelly commented on issue #1800: Docker testing init script has wrong service url

ivankelly commented on issue #1800: Docker testing init script has wrong service url URL: https://github.com/apache/incubator-pulsar/pull/1800#issuecomment-390998058 retest this please // ReplicatorTest.testCloseReplicatorStartProducer --

[incubator-pulsar] branch master updated: Use exact dependency version in LICENSE file and use check-binary-license to enforce (#1820)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5ce4065 Use exact dependency version

[GitHub] merlimat closed pull request #1820: Use exact dependency version in LICENSE file and use check-binary-license to enforce

merlimat closed pull request #1820: Use exact dependency version in LICENSE file and use check-binary-license to enforce URL: https://github.com/apache/incubator-pulsar/pull/1820 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed belo

[GitHub] ivankelly commented on a change in pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength

ivankelly commented on a change in pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength URL: https://github.com/apache/incubator-pulsar/pull/1799#discussion_r189886758 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/i

[incubator-pulsar] branch asf-site updated: Updated site at revision 3e04726

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new c4013e1 Updated site at revision