[GitHub] rdhabalia closed pull request #1987: add admin-api to update function with url

2018-06-21 Thread GitBox
rdhabalia closed pull request #1987: add admin-api to update function with url URL: https://github.com/apache/incubator-pulsar/pull/1987 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: add admin-api to update function with url (#1987)

2018-06-21 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 358b68d add admin-api to update fu

[GitHub] merlimat commented on issue #1821: Closing client when Proxyconnection is disconnected

2018-06-21 Thread GitBox
merlimat commented on issue #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#issuecomment-399337112 We can merge this now, though we should try to revisit the changes in #1707 for 2.2 -

[GitHub] merlimat commented on a change in pull request #1993: Helm charts for deployment on GKE

2018-06-21 Thread GitBox
merlimat commented on a change in pull request #1993: Helm charts for deployment on GKE URL: https://github.com/apache/incubator-pulsar/pull/1993#discussion_r197350153 ## File path: deployment/kubernetes/helm/pulsar/Chart.yaml ## @@ -0,0 +1,24 @@ +# +# Licensed to the Apac

[GitHub] merlimat commented on a change in pull request #1993: Helm charts for deployment on GKE

2018-06-21 Thread GitBox
merlimat commented on a change in pull request #1993: Helm charts for deployment on GKE URL: https://github.com/apache/incubator-pulsar/pull/1993#discussion_r197349300 ## File path: deployment/kubernetes/helm/pulsar/Chart.yaml ## @@ -0,0 +1,24 @@ +# +# Licensed to the Apac

[incubator-pulsar] branch master updated: Remove pulsar-common dependency from pulsar-io-core module and cleanup pulsar-common dependency references (#2020)

2018-06-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7c3a324 Remove pulsar-common dependenc

[GitHub] sijie closed pull request #2020: Remove pulsar-common dependency from pulsar-io-core module and cleanup pulsar-common dependency references

2018-06-21 Thread GitBox
sijie closed pull request #2020: Remove pulsar-common dependency from pulsar-io-core module and cleanup pulsar-common dependency references URL: https://github.com/apache/incubator-pulsar/pull/2020 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, i

[GitHub] merlimat closed pull request #1895: Pulsar proxy configuration docs

2018-06-21 Thread GitBox
merlimat closed pull request #1895: Pulsar proxy configuration docs URL: https://github.com/apache/incubator-pulsar/pull/1895 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[incubator-pulsar] branch master updated: Pulsar proxy configuration docs (#1895)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new bf3ff19 Pulsar proxy configuration do

[incubator-pulsar] branch master updated: Added Go client library links to navigation bar (#2016)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7b72a97 Added Go client library links

[GitHub] merlimat closed pull request #2016: Added Go client library links to navigation bar

2018-06-21 Thread GitBox
merlimat closed pull request #2016: Added Go client library links to navigation bar URL: https://github.com/apache/incubator-pulsar/pull/2016 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] sijie commented on issue #2005: Added REST/CLI tools to manage bookies rack placement config

2018-06-21 Thread GitBox
sijie commented on issue #2005: Added REST/CLI tools to manage bookies rack placement config URL: https://github.com/apache/incubator-pulsar/pull/2005#issuecomment-399299706 @merlimat seems RackAwareTest is broken. This is an

[GitHub] sijie opened a new pull request #2020: Remove pulsar-common dependency from pulsar-io-core module and cleanup pulsar-common dependency references

2018-06-21 Thread GitBox
sijie opened a new pull request #2020: Remove pulsar-common dependency from pulsar-io-core module and cleanup pulsar-common dependency references URL: https://github.com/apache/incubator-pulsar/pull/2020 *Motivation* With pulsar-common shading in pulsar-client, conflicts observed

[GitHub] merlimat opened a new pull request #2019: Added message parser to decode raw headers and payload without a Consumer instance

2018-06-21 Thread GitBox
merlimat opened a new pull request #2019: Added message parser to decode raw headers and payload without a Consumer instance URL: https://github.com/apache/incubator-pulsar/pull/2019 ### Motivation Generalized the method to decode the raw headers and payload. This will make possible

[GitHub] sijie commented on a change in pull request #1995: [WIP] Migrate to test containers Part 5

2018-06-21 Thread GitBox
sijie commented on a change in pull request #1995: [WIP] Migrate to test containers Part 5 URL: https://github.com/apache/incubator-pulsar/pull/1995#discussion_r197323561 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/TestCLI.java ## @@

[GitHub] sijie commented on a change in pull request #1995: [WIP] Migrate to test containers Part 5

2018-06-21 Thread GitBox
sijie commented on a change in pull request #1995: [WIP] Migrate to test containers Part 5 URL: https://github.com/apache/incubator-pulsar/pull/1995#discussion_r197323768 ## File path: tests/pom.xml ## @@ -28,13 +28,15 @@ pulsar 2.1.0-incubating-SNAPSHOT +

[GitHub] sijie commented on a change in pull request #1995: [WIP] Migrate to test containers Part 5

2018-06-21 Thread GitBox
sijie commented on a change in pull request #1995: [WIP] Migrate to test containers Part 5 URL: https://github.com/apache/incubator-pulsar/pull/1995#discussion_r197323695 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/TestCompaction.java

[GitHub] sijie commented on a change in pull request #1995: [WIP] Migrate to test containers Part 5

2018-06-21 Thread GitBox
sijie commented on a change in pull request #1995: [WIP] Migrate to test containers Part 5 URL: https://github.com/apache/incubator-pulsar/pull/1995#discussion_r197323598 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/TestCLI.java ## @@

[incubator-pulsar] branch master updated: Use single instances for compression codec providers (#2017)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 471d35b Use single instances for comp

[GitHub] merlimat closed pull request #2017: Use single instances for compression codec providers

2018-06-21 Thread GitBox
merlimat closed pull request #2017: Use single instances for compression codec providers URL: https://github.com/apache/incubator-pulsar/pull/2017 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[GitHub] sijie commented on issue #1987: add admin-api to update function with url

2018-06-21 Thread GitBox
sijie commented on issue #1987: add admin-api to update function with url URL: https://github.com/apache/incubator-pulsar/pull/1987#issuecomment-399285663 @jerrypeng can you review this? This is an automated message from the A

[GitHub] sijie commented on issue #2001: adding pulsar io docs

2018-06-21 Thread GitBox
sijie commented on issue #2001: adding pulsar io docs URL: https://github.com/apache/incubator-pulsar/pull/2001#issuecomment-399285563 @srkukarni can you review this again? This is an automated message from the Apache Git Ser

[GitHub] sijie commented on issue #2016: Added Go client library links to navigation bar

2018-06-21 Thread GitBox
sijie commented on issue #2016: Added Go client library links to navigation bar URL: https://github.com/apache/incubator-pulsar/pull/2016#issuecomment-399285498 retest this please This is an automated message from the Apache G

[GitHub] srkukarni closed pull request #2018: Revert "Functions schema integration (#1845)"

2018-06-21 Thread GitBox
srkukarni closed pull request #2018: Revert "Functions schema integration (#1845)" URL: https://github.com/apache/incubator-pulsar/pull/2018 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Revert "Functions schema integration (#1845)" (#2018)

2018-06-21 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4c5c3cf Revert "Functions schema i

[GitHub] sijie opened a new pull request #2018: Revert "Functions schema integration (#1845)"

2018-06-21 Thread GitBox
sijie opened a new pull request #2018: Revert "Functions schema integration (#1845)" URL: https://github.com/apache/incubator-pulsar/pull/2018 ### Motivation The problem introduced at 97b56cf04dfca81c937a4b640bc8cfc5470d66cb is when making SerDe extending Schema. It introduc

[GitHub] srkukarni commented on issue #1895: Pulsar proxy configuration docs

2018-06-21 Thread GitBox
srkukarni commented on issue #1895: Pulsar proxy configuration docs URL: https://github.com/apache/incubator-pulsar/pull/1895#issuecomment-399263460 retest this please This is an automated message from the Apache Git Service.

[GitHub] srkukarni commented on issue #1895: Pulsar proxy configuration docs

2018-06-21 Thread GitBox
srkukarni commented on issue #1895: Pulsar proxy configuration docs URL: https://github.com/apache/incubator-pulsar/pull/1895#issuecomment-399263552 retest this please This is an automated message from the Apache Git Service.

[incubator-pulsar] branch asf-site updated: Updated site at revision d02ea01

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 42cfd34 Updated site at revision

[incubator-pulsar] branch master updated: Add trademark for "Apache Pulsar" on website footer (#2015)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new d02ea01 Add trademark for "Apache Pul

[GitHub] merlimat closed pull request #2015: Add trademark for "Apache Pulsar" on website footer

2018-06-21 Thread GitBox
merlimat closed pull request #2015: Add trademark for "Apache Pulsar" on website footer URL: https://github.com/apache/incubator-pulsar/pull/2015 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] merlimat closed pull request #2014: Removed links to github from download page

2018-06-21 Thread GitBox
merlimat closed pull request #2014: Removed links to github from download page URL: https://github.com/apache/incubator-pulsar/pull/2014 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Removed links to github from download page (#2014)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8284fa1 Removed links to github from

[GitHub] merlimat opened a new pull request #2017: Use single instances for compression codec providers

2018-06-21 Thread GitBox
merlimat opened a new pull request #2017: Use single instances for compression codec providers URL: https://github.com/apache/incubator-pulsar/pull/2017 ### Motivation Reduce number of instances of compression codecs since the implementations are sharable across threads anyway. ---

[GitHub] sijie commented on issue #2005: Added REST/CLI tools to manage bookies rack placement config

2018-06-21 Thread GitBox
sijie commented on issue #2005: Added REST/CLI tools to manage bookies rack placement config URL: https://github.com/apache/incubator-pulsar/pull/2005#issuecomment-399244626 retest this please This is an automated message fro

[incubator-pulsar] branch asf-site updated: Updated site at revision 8599151

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new f79042b Updated site at revision

[GitHub] bardock commented on issue #2013: Unable to consume messages from a partition

2018-06-21 Thread GitBox
bardock commented on issue #2013: Unable to consume messages from a partition URL: https://github.com/apache/incubator-pulsar/issues/2013#issuecomment-399220238 No, it didn't On Thu, Jun 21, 2018, 16:36 Sijie Guo wrote: > did the problem occur again after you resubscribe?

[GitHub] merlimat commented on issue #1895: Pulsar proxy configuration docs

2018-06-21 Thread GitBox
merlimat commented on issue #1895: Pulsar proxy configuration docs URL: https://github.com/apache/incubator-pulsar/pull/1895#issuecomment-399219893 retest this please This is an automated message from the Apache Git Service. T

[GitHub] sijie commented on issue #2013: Unable to consume messages from a partition

2018-06-21 Thread GitBox
sijie commented on issue #2013: Unable to consume messages from a partition URL: https://github.com/apache/incubator-pulsar/issues/2013#issuecomment-399218582 did the problem occur again after you resubscribe? This is an auto

[GitHub] merlimat opened a new pull request #2016: Added Go client library links to navigation bar

2018-06-21 Thread GitBox
merlimat opened a new pull request #2016: Added Go client library links to navigation bar URL: https://github.com/apache/incubator-pulsar/pull/2016 ### Motivation Added Go links on navigation bar with other client libraries ---

[GitHub] sijie closed pull request #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map

2018-06-21 Thread GitBox
sijie closed pull request #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map URL: https://github.com/apache/incubator-pulsar/pull/2004 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[incubator-pulsar] branch master updated: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map (#2004)

2018-06-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8599151 Issue 1943: remove serializabl

[GitHub] sijie closed issue #1943: Non serializable client builder

2018-06-21 Thread GitBox
sijie closed issue #1943: Non serializable client builder URL: https://github.com/apache/incubator-pulsar/issues/1943 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub a

[GitHub] sijie commented on issue #2009: Unable to get messages from non-persistent topics

2018-06-21 Thread GitBox
sijie commented on issue #2009: Unable to get messages from non-persistent topics URL: https://github.com/apache/incubator-pulsar/issues/2009#issuecomment-399211974 @jiazhai can you help check if regex subscription works for non-persistent?

[GitHub] sijie commented on issue #2005: Added REST/CLI tools to manage bookies rack placement config

2018-06-21 Thread GitBox
sijie commented on issue #2005: Added REST/CLI tools to manage bookies rack placement config URL: https://github.com/apache/incubator-pulsar/pull/2005#issuecomment-399211359 this is great! it would be good to a smoke test for the cmd tools and documentation about it in followup PRs. -

[GitHub] sijie commented on issue #1943: Non serializable client builder

2018-06-21 Thread GitBox
sijie commented on issue #1943: Non serializable client builder URL: https://github.com/apache/incubator-pulsar/issues/1943#issuecomment-399207937 > but it will less robust that calling method to set each options in case of name changes. that's true. I am using jackson object mapper

[GitHub] merlimat opened a new pull request #2015: Add trademark for "Apache Pulsar" on website footer

2018-06-21 Thread GitBox
merlimat opened a new pull request #2015: Add trademark for "Apache Pulsar" on website footer URL: https://github.com/apache/incubator-pulsar/pull/2015 ### Motivation The footer should contain the "Apache Pulsar" trademark mention. ---

[incubator-pulsar] 01/01: Add trademark for "Apache Pulsar" on website footer

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch merlimat-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git commit 2583357880d57081316da904b549e1ade249e914 Author: Matteo Merli AuthorDate: Thu Jun 21 11:52:48 2018 -

[incubator-pulsar] branch merlimat-patch-1 created (now 2583357)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch merlimat-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git. at 2583357 Add trademark for "Apache Pulsar" on website footer This branch includes the following

[GitHub] merlimat opened a new pull request #2014: Removed links to github from download page

2018-06-21 Thread GitBox
merlimat opened a new pull request #2014: Removed links to github from download page URL: https://github.com/apache/incubator-pulsar/pull/2014 ### Motivation We need to link to internal release notes instead of pointing to github page. ---

[GitHub] sijie commented on issue #1821: Closing client when Proxyconnection is disconnected

2018-06-21 Thread GitBox
sijie commented on issue #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#issuecomment-399204369 @jai1 still looks good to me. @merlimat can you review this? since you have some comments there. -

[GitHub] cckellogg commented on issue #1993: Helm charts for deployment on GKE

2018-06-21 Thread GitBox
cckellogg commented on issue #1993: Helm charts for deployment on GKE URL: https://github.com/apache/incubator-pulsar/pull/1993#issuecomment-399202566 @DanielFerreiraJorge it's looking good. Do you think it would be helpful to add an example gke-values.yaml file to show people how to overri

[GitHub] jerrypeng commented on a change in pull request #2001: adding pulsar io docs

2018-06-21 Thread GitBox
jerrypeng commented on a change in pull request #2001: adding pulsar io docs URL: https://github.com/apache/incubator-pulsar/pull/2001#discussion_r197222988 ## File path: site/_data/cli/pulsar-admin.yaml ## @@ -510,6 +510,164 @@ commands: argument: cluster-name - n

[GitHub] jerrypeng commented on a change in pull request #2001: adding pulsar io docs

2018-06-21 Thread GitBox
jerrypeng commented on a change in pull request #2001: adding pulsar io docs URL: https://github.com/apache/incubator-pulsar/pull/2001#discussion_r197222880 ## File path: site/_data/cli/pulsar-admin.yaml ## @@ -510,6 +510,164 @@ commands: argument: cluster-name - n

[GitHub] merlimat commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
merlimat commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197205608 ## File path: pulsar-client-cpp/include/pulsar/MessageId.h ## @@ -34,6 +34,16 @@ class MessageId {

[incubator-pulsar] branch master updated: Enable C++ message listener to receive messages even if receiver queue size is zero (#2010)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0c1cc54 Enable C++ message listener t

[GitHub] merlimat closed pull request #2010: Enable C++ message listener to receive messages even if receiver queu…

2018-06-21 Thread GitBox
merlimat closed pull request #2010: Enable C++ message listener to receive messages even if receiver queu… URL: https://github.com/apache/incubator-pulsar/pull/2010 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[incubator-pulsar] branch master updated: Pulsar Go client docs (#1838)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 94418bb Pulsar Go client docs (#1838)

[GitHub] merlimat closed pull request #1838: Pulsar Go client docs

2018-06-21 Thread GitBox
merlimat closed pull request #1838: Pulsar Go client docs URL: https://github.com/apache/incubator-pulsar/pull/1838 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[incubator-pulsar] branch master updated: Fix: set visibility, exclude-libs options to CMAKE_CXX_FLAGS (#1997)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ef92062 Fix: set visibility,exclude-

[GitHub] merlimat closed pull request #1997: Fix: set visibility, exclude-libs options to CMAKE_CXX_FLAGS

2018-06-21 Thread GitBox
merlimat closed pull request #1997: Fix: set visibility,exclude-libs options to CMAKE_CXX_FLAGS URL: https://github.com/apache/incubator-pulsar/pull/1997 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of proven

[incubator-pulsar] branch master updated: add consumer.seek in python client (#2008)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a545c2e add consumer.seek in python c

[GitHub] merlimat closed pull request #2008: Cpp client: add consumer.seek in python client

2018-06-21 Thread GitBox
merlimat closed pull request #2008: Cpp client: add consumer.seek in python client URL: https://github.com/apache/incubator-pulsar/pull/2008 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] merlimat commented on a change in pull request #2011: Cpp client: python client wrapper for reader hasMessageAvaliable

2018-06-21 Thread GitBox
merlimat commented on a change in pull request #2011: Cpp client: python client wrapper for reader hasMessageAvaliable URL: https://github.com/apache/incubator-pulsar/pull/2011#discussion_r197198935 ## File path: pulsar-client-cpp/lib/c/c_Reader.cc ## @@ -52,3 +52,11 @@ vo

[GitHub] merlimat closed pull request #2012: Downgrade pulsar-client CLI consume warning message (#1485)

2018-06-21 Thread GitBox
merlimat closed pull request #2012: Downgrade pulsar-client CLI consume warning message (#1485) URL: https://github.com/apache/incubator-pulsar/pull/2012 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[incubator-pulsar] branch master updated: Downgrade pulsar-client CLI consume warning message (#1485) (#2012)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b7e3fdd Downgrade pulsar-client CLI c

[GitHub] ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197187834 ## File path: pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc ## @@ -0,0 +1,625 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197182992 ## File path: pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc ## @@ -0,0 +1,625 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197186768 ## File path: pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc ## @@ -0,0 +1,625 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197186917 ## File path: pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc ## @@ -0,0 +1,625 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197152025 ## File path: pulsar-client-cpp/lib/ClientImpl.cc ## @@ -209,6 +211,40 @@ void ClientImpl::handleReade

[GitHub] ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197183363 ## File path: pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc ## @@ -0,0 +1,625 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197184786 ## File path: pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc ## @@ -0,0 +1,625 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197184059 ## File path: pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc ## @@ -0,0 +1,625 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
ivankelly commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197187559 ## File path: pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc ## @@ -0,0 +1,625 @@ +/** + * Licensed

[GitHub] sijie commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map

2018-06-21 Thread GitBox
sijie commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map URL: https://github.com/apache/incubator-pulsar/pull/2004#issuecomment-399147589 retest this please ---

[GitHub] bardock opened a new issue #2013: Unable to consume messages from a partition

2018-06-21 Thread GitBox
bardock opened a new issue #2013: Unable to consume messages from a partition URL: https://github.com/apache/incubator-pulsar/issues/2013 We have several shared subscriptions of partitioned topics and we found some cases where a subscription's clients are not receiving messages from a speci

[GitHub] zhaijack commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
zhaijack commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197172461 ## File path: pulsar-client-cpp/include/pulsar/Message.h ## @@ -46,6 +46,16 @@ class Message { M

[GitHub] ivankelly opened a new pull request #2012: Downgrade pulsar-client CLI consume warning message (#1485)

2018-06-21 Thread GitBox
ivankelly opened a new pull request #2012: Downgrade pulsar-client CLI consume warning message (#1485) URL: https://github.com/apache/incubator-pulsar/pull/2012 Previously this log would spam the stdout if there were no messages coming in. The message wasn't even factually correct, as th

[GitHub] zhaijack commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

2018-06-21 Thread GitBox
zhaijack commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197128237 ## File path: pulsar-client-cpp/include/pulsar/MessageId.h ## @@ -34,6 +34,16 @@ class MessageId {

[GitHub] zhaijack opened a new pull request #2011: Cpp client: python client wrapper for reader hasMessageAvaliable

2018-06-21 Thread GitBox
zhaijack opened a new pull request #2011: Cpp client: python client wrapper for reader hasMessageAvaliable URL: https://github.com/apache/incubator-pulsar/pull/2011 In PR #1861, we support hasMessageAvaliable in reader of cpp client. this is the following work to add wrapper for python.

[GitHub] DanielFerreiraJorge commented on a change in pull request #1993: Helm charts for deployment on GKE

2018-06-21 Thread GitBox
DanielFerreiraJorge commented on a change in pull request #1993: Helm charts for deployment on GKE URL: https://github.com/apache/incubator-pulsar/pull/1993#discussion_r197112332 ## File path: deployment/kubernetes/helm/pulsar/values.yaml ## @@ -0,0 +1,388 @@ +# +# License

[GitHub] massakam opened a new pull request #2010: Enable C++ message listener to receive messages even if receiver queu…

2018-06-21 Thread GitBox
massakam opened a new pull request #2010: Enable C++ message listener to receive messages even if receiver queu… URL: https://github.com/apache/incubator-pulsar/pull/2010 …e size is zero The same issue as https://github.com/apache/incubator-pulsar/pull/1977 existed in the C++ client

[GitHub] Programmer74 opened a new issue #2009: Unable to get messages from non-persistent topics while using wildcard subscription

2018-06-21 Thread GitBox
Programmer74 opened a new issue #2009: Unable to get messages from non-persistent topics while using wildcard subscription URL: https://github.com/apache/incubator-pulsar/issues/2009 ### Issue I am unable to get messages from non-persistent topics while using wildcard subscription.

[GitHub] jai1 commented on issue #1821: Closing client when Proxyconnection is disconnected

2018-06-21 Thread GitBox
jai1 commented on issue #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#issuecomment-399038185 @sijie - Can you review this PR so that we can merge it This

[GitHub] sijie commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map

2018-06-21 Thread GitBox
sijie commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map URL: https://github.com/apache/incubator-pulsar/pull/2004#issuecomment-399021297 @merlimat I set `FAIL_ON_UNKNOWN_PROPERTIES` to true and add a test case to

[GitHub] sijie commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map

2018-06-21 Thread GitBox
sijie commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map URL: https://github.com/apache/incubator-pulsar/pull/2004#issuecomment-399018095 > one option to detect spelling mistakes (or variable name changes) would b

[GitHub] zhaijack opened a new pull request #2008: Cpp client: add consumer.seek in python client

2018-06-21 Thread GitBox
zhaijack opened a new pull request #2008: Cpp client: add consumer.seek in python client URL: https://github.com/apache/incubator-pulsar/pull/2008 In PR #1863, we support seek in consumer of cpp client. This is the following work to add wrapper for python. change: - add python wrappe

[GitHub] hrsakai commented on issue #1997: Fix: set visibility, exclude-libs options to CMAKE_CXX_FLAGS

2018-06-21 Thread GitBox
hrsakai commented on issue #1997: Fix: set visibility,exclude-libs options to CMAKE_CXX_FLAGS URL: https://github.com/apache/incubator-pulsar/pull/1997#issuecomment-399017862 retest this please This is an automated message f

[incubator-pulsar] branch master updated: Improve pulsar-client shading (#2006)

2018-06-21 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new edaaafc Improve pulsar-client shad

[GitHub] srkukarni closed pull request #2006: Improve pulsar-client shading

2018-06-21 Thread GitBox
srkukarni closed pull request #2006: Improve pulsar-client shading URL: https://github.com/apache/incubator-pulsar/pull/2006 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] merlimat commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map

2018-06-21 Thread GitBox
merlimat commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map URL: https://github.com/apache/incubator-pulsar/pull/2004#issuecomment-399002273 Another consideration is that, with this change, the variable names beco

[GitHub] merlimat commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map

2018-06-21 Thread GitBox
merlimat commented on issue #2004: Issue 1943: remove serializable from builders and add loadData to load configuration from a config map URL: https://github.com/apache/incubator-pulsar/pull/2004#issuecomment-399001572 @sijie one option to detect spelling mistakes (or variable name changes)

[GitHub] merlimat closed pull request #2002: Enable CRC32-C by default in BK client

2018-06-21 Thread GitBox
merlimat closed pull request #2002: Enable CRC32-C by default in BK client URL: https://github.com/apache/incubator-pulsar/pull/2002 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

[incubator-pulsar] branch master updated: Enable CRC32-C by default in BK client (#2002)

2018-06-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8cc296e Enable CRC32-C by default in

[GitHub] merlimat closed issue #1371: Switch default digest type for BookKeeper to CRC32c

2018-06-21 Thread GitBox
merlimat closed issue #1371: Switch default digest type for BookKeeper to CRC32c URL: https://github.com/apache/incubator-pulsar/issues/1371 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] Programmer74 opened a new issue #2007: Implement an easier way to get the topic information from consumed message

2018-06-21 Thread GitBox
Programmer74 opened a new issue #2007: Implement an easier way to get the topic information from consumed message URL: https://github.com/apache/incubator-pulsar/issues/2007 ### Improvement request I create a consumer, which is subscribed to several topics using ```topicsPattern```: