[GitHub] srkukarni commented on issue #1520: Pulsar Connect

srkukarni commented on issue #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#issuecomment-379434630 @merlimat I've addressed your comments. Please take a look again. Thanks! This is an

[GitHub] srkukarni commented on a change in pull request #1520: Pulsar Connect

srkukarni commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179909351 ## File path: pulsar-connect/twitter/pom.xml ## @@ -0,0 +1,49 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] merlimat opened a new pull request #1523: Use signSafeMod in RoundRobinPartitionMessageRouter

merlimat opened a new pull request #1523: Use signSafeMod in RoundRobinPartitionMessageRouter URL: https://github.com/apache/incubator-pulsar/pull/1523 ### Motivation I have seen this errors in master with the round-robin message router (used with `perf-producer`) : ```

[GitHub] merlimat opened a new pull request #1521: Removed contention between producers on ManagedLedger addEntry

merlimat opened a new pull request #1521: Removed contention between producers on ManagedLedger addEntry URL: https://github.com/apache/incubator-pulsar/pull/1521 ### Motivation When there are multiple producers writing on the same topic and there are many entries/second (little

[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904692 ## File path: pulsar-connect/twitter/src/main/java/org/apache/pulsar/connect/twitter/TwitterFireHoseConfigKeys.java ## @@

[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904748 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java ## @@ -0,0 +1,46 @@ +/** + *

[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904588 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java ## @@ -0,0 +1,46 @@ +/** + *

[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904923 ## File path: pulsar-connect/twitter/pom.xml ## @@ -0,0 +1,49 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] merlimat commented on a change in pull request #1520: Pulsar Connect

merlimat commented on a change in pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520#discussion_r179904898 ## File path: pulsar-connect/pom.xml ## @@ -0,0 +1,59 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] srkukarni opened a new pull request #1520: Pulsar Connect

srkukarni opened a new pull request #1520: Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1520 ### Motivation A significant barrier for adoption of Pulsar is the lack of connectors moving data in and out of Pulsar. This pr attempts to provide an interface for

[GitHub] merlimat commented on issue #1506: Underscore `_` should be allowed as property name

merlimat commented on issue #1506: Underscore `_` should be allowed as property name URL: https://github.com/apache/incubator-pulsar/issues/1506#issuecomment-379410968 Added test case in #1516 This is an automated message

[GitHub] merlimat closed pull request #1516: Added test to ensure property name can contain '_' characters.

merlimat closed pull request #1516: Added test to ensure property name can contain '_' characters. URL: https://github.com/apache/incubator-pulsar/pull/1516 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Added test to ensure property name can contain '_' characters. (#1516)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3ae5115 Added test to ensure

[GitHub] merlimat closed issue #1506: Underscore `_` should be allowed as property name

merlimat closed issue #1506: Underscore `_` should be allowed as property name URL: https://github.com/apache/incubator-pulsar/issues/1506 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] merlimat closed pull request #1381: Schema registry 4/N

merlimat closed pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[incubator-pulsar] branch master updated: Schema registry 4/N (#1381)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1eb8068 Schema registry 4/N (#1381)

[GitHub] merlimat commented on issue #1516: Added test to ensure property name can contain '_' characters.

merlimat commented on issue #1516: Added test to ensure property name can contain '_' characters. URL: https://github.com/apache/incubator-pulsar/pull/1516#issuecomment-379402597 retest this please This is an automated

[GitHub] merlimat commented on issue #1516: Added test to ensure property name can contain '_' characters.

merlimat commented on issue #1516: Added test to ensure property name can contain '_' characters. URL: https://github.com/apache/incubator-pulsar/pull/1516#issuecomment-379402597 retest this please This is an automated

[GitHub] mgodave commented on issue #1505: Proxy admin web requests

mgodave commented on issue #1505: Proxy admin web requests URL: https://github.com/apache/incubator-pulsar/pull/1505#issuecomment-379398871 That's fine. I still need to test something so don't merge either way. On Fri, Apr 6, 2018 at 4:10 PM, Matteo Merli

[GitHub] merlimat commented on issue #1505: Proxy admin web requests

merlimat commented on issue #1505: Proxy admin web requests URL: https://github.com/apache/incubator-pulsar/pull/1505#issuecomment-379398302 > testOutOfOrderDeletePersistenceIntoLedgerWithClose failed This PR was branched when we had the master broken

[GitHub] sijie commented on issue #1381: Schema registry 4/N

sijie commented on issue #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#issuecomment-379391812 retest this please This is an automated message from the Apache Git Service. To respond to

[incubator-pulsar] branch master updated: Readme for integration tests (#1518)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new cc28dd0 Readme for integration tests

[GitHub] merlimat closed pull request #1514: Compaction allows keyless messages to pass through

merlimat closed pull request #1514: Compaction allows keyless messages to pass through URL: https://github.com/apache/incubator-pulsar/pull/1514 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] merlimat closed pull request #1518: Readme for integration tests

merlimat closed pull request #1518: Readme for integration tests URL: https://github.com/apache/incubator-pulsar/pull/1518 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Compaction allows keyless messages to pass through (#1514)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 346f831 Compaction allows keyless

[GitHub] merlimat opened a new pull request #1519: Avoid contention in ManagedCursorImpl generated by locking on pendingMarkDeleteOps

merlimat opened a new pull request #1519: Avoid contention in ManagedCursorImpl generated by locking on pendingMarkDeleteOps URL: https://github.com/apache/incubator-pulsar/pull/1519 ### Motivation I have spotted contention in broker threads, that ultimately leads to bumps in the

[GitHub] merlimat closed pull request #1501: Rest endpoint to query compaction status

merlimat closed pull request #1501: Rest endpoint to query compaction status URL: https://github.com/apache/incubator-pulsar/pull/1501 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Rest endpoint to query compaction status (#1501)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6f36aee Rest endpoint to query

[incubator-pulsar] branch master updated: Also log bookkeeper (and managed ledger) in tests (#1512)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c2fb795 Also log bookkeeper (and

[GitHub] merlimat closed pull request #1512: Also log bookkeeper (and managed ledger) in tests

merlimat closed pull request #1512: Also log bookkeeper (and managed ledger) in tests URL: https://github.com/apache/incubator-pulsar/pull/1512 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] ivankelly opened a new pull request #1518: Readme for integration tests

ivankelly opened a new pull request #1518: Readme for integration tests URL: https://github.com/apache/incubator-pulsar/pull/1518 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] merlimat closed pull request #1504: Enable FQFN specification for the Pulsar Functions CLI

merlimat closed pull request #1504: Enable FQFN specification for the Pulsar Functions CLI URL: https://github.com/apache/incubator-pulsar/pull/1504 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: Enable FQFN specification for the Pulsar Functions CLI (#1504)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9d23892 Enable FQFN specification

[GitHub] ivankelly commented on issue #1512: Also log bookkeeper (and managed ledger) in tests

ivankelly commented on issue #1512: Also log bookkeeper (and managed ledger) in tests URL: https://github.com/apache/incubator-pulsar/pull/1512#issuecomment-379355022 retest this please // c++ test timed out "Build timed out (after 200 minutes). Marking the build as aborted."

[GitHub] ivankelly opened a new issue #1517: Reader#hasMessageAvailable can report false when it should be true

ivankelly opened a new issue #1517: Reader#hasMessageAvailable can report false when it should be true URL: https://github.com/apache/incubator-pulsar/issues/1517 Expected behavior true Actual behavior false Steps to reproduce 1. Write to a

[incubator-pulsar] branch master updated: Message deduplication documentation (#1271)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ec210cb Message deduplication

[GitHub] merlimat closed pull request #1271: Message deduplication documentation

merlimat closed pull request #1271: Message deduplication documentation URL: https://github.com/apache/incubator-pulsar/pull/1271 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat closed pull request #1498: Enable Pulsar Functions to access entire user config map

merlimat closed pull request #1498: Enable Pulsar Functions to access entire user config map URL: https://github.com/apache/incubator-pulsar/pull/1498 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Enable Pulsar Functions to access entire user config map (#1498)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b5781a1 Enable Pulsar Functions to

[incubator-pulsar] branch master updated: Pulsar Functions diagrams (#1502)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 125ca58 Pulsar Functions diagrams

[GitHub] merlimat closed pull request #1502: Pulsar Functions diagrams

merlimat closed pull request #1502: Pulsar Functions diagrams URL: https://github.com/apache/incubator-pulsar/pull/1502 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] lucperkins commented on issue #1502: Pulsar Functions diagrams

lucperkins commented on issue #1502: Pulsar Functions diagrams URL: https://github.com/apache/incubator-pulsar/pull/1502#issuecomment-379338645 @srkukarni We're unblocked on CI now, so this is ready to merge This is an

[incubator-pulsar] branch master updated: Consolidate Pair implementations (#1515)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6e8b5bf Consolidate Pair

[GitHub] merlimat closed pull request #1515: Consolidate Pair implementations

merlimat closed pull request #1515: Consolidate Pair implementations URL: https://github.com/apache/incubator-pulsar/pull/1515 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] merlimat opened a new pull request #1516: Added test to ensure property name can contain '_' characters.

merlimat opened a new pull request #1516: Added test to ensure property name can contain '_' characters. URL: https://github.com/apache/incubator-pulsar/pull/1516 ### Motivation As reported in #1506, in 1.22 we still have inconsistencies between what's allowed as a valid property

[GitHub] mgodave opened a new pull request #1515: Consolidate Pair implementations

mgodave opened a new pull request #1515: Consolidate Pair implementations URL: https://github.com/apache/incubator-pulsar/pull/1515 ### Motivation While working in the codebase I noticed that there were at least three different implementations of a "Pair" type being used. I

[GitHub] merlimat commented on a change in pull request #1513: Managed ledger uses ReadHandle in read path

merlimat commented on a change in pull request #1513: Managed ledger uses ReadHandle in read path URL: https://github.com/apache/incubator-pulsar/pull/1513#discussion_r179807644 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryCacheImpl.java

[GitHub] mgodave commented on a change in pull request #1505: Proxy admin web requests

mgodave commented on a change in pull request #1505: Proxy admin web requests URL: https://github.com/apache/incubator-pulsar/pull/1505#discussion_r179798442 ## File path: pulsar-proxy/pom.xml ## @@ -70,6 +70,11 @@ jetty-servlets + +

[GitHub] mgodave commented on a change in pull request #1505: Proxy admin web requests

mgodave commented on a change in pull request #1505: Proxy admin web requests URL: https://github.com/apache/incubator-pulsar/pull/1505#discussion_r179798302 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/AdminProxyHandler.java ## @@ -0,0 +1,83 @@

[GitHub] mgodave commented on a change in pull request #1505: Proxy admin web requests

mgodave commented on a change in pull request #1505: Proxy admin web requests URL: https://github.com/apache/incubator-pulsar/pull/1505#discussion_r179798123 ## File path: pulsar-proxy/pom.xml ## @@ -70,6 +70,11 @@ jetty-servlets + +

[GitHub] mgodave commented on a change in pull request #1505: Proxy admin web requests

mgodave commented on a change in pull request #1505: Proxy admin web requests URL: https://github.com/apache/incubator-pulsar/pull/1505#discussion_r179798017 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java ## @@ -121,6

[GitHub] merlimat closed pull request #1399: Integration smoke test for pulsar

merlimat closed pull request #1399: Integration smoke test for pulsar URL: https://github.com/apache/incubator-pulsar/pull/1399 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Integration smoke test for pulsar (#1399)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 013ea05 Integration smoke test for

[GitHub] ivankelly commented on issue #1512: Also log bookkeeper (and managed ledger) in tests

ivankelly commented on issue #1512: Also log bookkeeper (and managed ledger) in tests URL: https://github.com/apache/incubator-pulsar/pull/1512#issuecomment-379259622 retest this please // BrokerClientIntegrationTest.testUnsupportedBatchMessageConsumer

[GitHub] ivankelly commented on issue #1513: Managed ledger uses ReadHandle in read path

ivankelly commented on issue #1513: Managed ledger uses ReadHandle in read path URL: https://github.com/apache/incubator-pulsar/pull/1513#issuecomment-379259720 retest this please // BrokerBkEnsemblesTests.testSkipCorruptDataLedger

[GitHub] ivankelly opened a new pull request #1514: Compaction allows keyless messages to pass through

ivankelly opened a new pull request #1514: Compaction allows keyless messages to pass through URL: https://github.com/apache/incubator-pulsar/pull/1514 If a message has no key it's impossible to know if a later message supercedes it, so in this case, it should be simply passed through

[GitHub] ivankelly commented on issue #1512: Also log bookkeeper (and managed ledger) in tests

ivankelly commented on issue #1512: Also log bookkeeper (and managed ledger) in tests URL: https://github.com/apache/incubator-pulsar/pull/1512#issuecomment-379243136 retest this please // ReplicatorTest.testCloseReplicatorStartProducer

[GitHub] ivankelly commented on issue #1501: Rest endpoint to query compaction status

ivankelly commented on issue #1501: Rest endpoint to query compaction status URL: https://github.com/apache/incubator-pulsar/pull/1501#issuecomment-379243015 retest this please // PersistentQueueE2ETest.testCancelReadRequestOnLastDisconnect

[GitHub] ivankelly opened a new pull request #1513: Managed ledger uses ReadHandle in read path

ivankelly opened a new pull request #1513: Managed ledger uses ReadHandle in read path URL: https://github.com/apache/incubator-pulsar/pull/1513 BookKeeper 4.6 introduced a new API for reading, called ReadHandle. This API is an small interface, unlike LedgerHandle, so it is possible

[GitHub] zubchenok commented on issue #1506: Underscore `_` should be allowed as property name

zubchenok commented on issue #1506: Underscore `_` should be allowed as property name URL: https://github.com/apache/incubator-pulsar/issues/1506#issuecomment-379233042 Before closing the issue, run the unit test against 1.22 release to double check that the unit test reproduces the

[GitHub] zubchenok commented on issue #1506: Underscore `_` should be allowed as property name

zubchenok commented on issue #1506: Underscore `_` should be allowed as property name URL: https://github.com/apache/incubator-pulsar/issues/1506#issuecomment-379232768 I use 1.22 release. So seems it is already fixed in the current source.

[GitHub] ivankelly opened a new pull request #1512: Also log bookkeeper (and managed ledger) in tests

ivankelly opened a new pull request #1512: Also log bookkeeper (and managed ledger) in tests URL: https://github.com/apache/incubator-pulsar/pull/1512 Root level is warn, so we need to explicitly set org.apache.bookkeeper to info to see the logs.

[GitHub] ivankelly opened a new issue #1511: PIP-17 : Tiered storage (Master Issue)

ivankelly opened a new issue #1511: PIP-17 : Tiered storage (Master Issue) URL: https://github.com/apache/incubator-pulsar/issues/1511 Storing backlogs on bookies for a long time can get expensive. If there are other cheaper forms of storage available (S3/HDFS), capex can be reduced

[GitHub] ivankelly commented on issue #1399: Integration smoke test for pulsar

ivankelly commented on issue #1399: Integration smoke test for pulsar URL: https://github.com/apache/incubator-pulsar/pull/1399#issuecomment-379208812 finally This is an automated message from the Apache Git Service. To

[GitHub] ivankelly commented on issue #1501: Rest endpoint to query compaction status

ivankelly commented on issue #1501: Rest endpoint to query compaction status URL: https://github.com/apache/incubator-pulsar/pull/1501#issuecomment-379204955 retest this please // flake in c++ AuthPluginTest.testAthenz This

[GitHub] ivankelly commented on issue #1399: Integration smoke test for pulsar

ivankelly commented on issue #1399: Integration smoke test for pulsar URL: https://github.com/apache/incubator-pulsar/pull/1399#issuecomment-379194411 retest this please // flake on PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition (java8) // flake on

[GitHub] sijie opened a new issue #1510: java.lang.IllegalArgumentException on refreshing stats

sijie opened a new issue #1510: java.lang.IllegalArgumentException on refreshing stats URL: https://github.com/apache/incubator-pulsar/issues/1510 Found following stacktrace when running `AdminApiTest#partitionedTopics` ``` 00:55:33.359