[incubator-pulsar] branch master updated: Added Kafka Source and Kafka Sink to Pulsar Connect (#1557)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 616e2a2 Added Kafka Source and Kafka

[GitHub] merlimat closed pull request #1557: Added Kafka Source and Kafka Sink to Pulsar Connect

merlimat closed pull request #1557: Added Kafka Source and Kafka Sink to Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1557 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] zhaijack commented on a change in pull request #1538: Add rate limit for client lookup requests

zhaijack commented on a change in pull request #1538: Add rate limit for client lookup requests URL: https://github.com/apache/incubator-pulsar/pull/1538#discussion_r181269469 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java ## @@

[GitHub] merlimat commented on issue #1562: Converted to v2 topic names test related to ProducerConsumerBase

merlimat commented on issue #1562: Converted to v2 topic names test related to ProducerConsumerBase URL: https://github.com/apache/incubator-pulsar/pull/1562#issuecomment-380984325 retest this please This is an automated

[GitHub] merlimat commented on issue #1562: Converted to v2 topic names test related to ProducerConsumerBase

merlimat commented on issue #1562: Converted to v2 topic names test related to ProducerConsumerBase URL: https://github.com/apache/incubator-pulsar/pull/1562#issuecomment-380946821 retest this please This is an automated

[GitHub] merlimat commented on issue #1566: Provide unshaded pulsar-kafka-client

merlimat commented on issue #1566: Provide unshaded pulsar-kafka-client URL: https://github.com/apache/incubator-pulsar/pull/1566#issuecomment-380978713 @sijie We should probably update the docs in `./site/docs/latest/adaptors/KafkaWrapper.md` to mention this artifact as well.

[GitHub] merlimat commented on issue #1551: Json schema codec

merlimat commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380977903 > I suppose I could hack in a default "is compatible" check that literally checks if they are equal which would require schema updates to happen via the

[GitHub] sijie closed pull request #1563: Added RabbitMQ source to Pulsar Connect

sijie closed pull request #1563: Added RabbitMQ source to Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1563 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Added RabbitMQ source to Pulsar Connect (#1563)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9f62c3a Added RabbitMQ source to

[GitHub] sijie opened a new pull request #1566: Provide unshaded pulsar-kafka-client

sijie opened a new pull request #1566: Provide unshaded pulsar-kafka-client URL: https://github.com/apache/incubator-pulsar/pull/1566 Similar as the original pulsar-client. It is good to provide unshaded pulsar-kafka-client, so when migrating from kafka to pulsar, there would be a change

[GitHub] srkukarni commented on issue #1557: Added Kafka Source and Kafka Sink to Pulsar Connect

srkukarni commented on issue #1557: Added Kafka Source and Kafka Sink to Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1557#issuecomment-380969294 retest this please This is an automated message from

[GitHub] rdhabalia opened a new pull request #1565: Introduce admin api to get broker and namespace-isolation policy map

rdhabalia opened a new pull request #1565: Introduce admin api to get broker and namespace-isolation policy map URL: https://github.com/apache/incubator-pulsar/pull/1565 ### Motivation Right now, with multiple namespace-isolation-policies, it is little bit tricky to find out list

[GitHub] sijie commented on a change in pull request #1564: Support short topic name in cpp client

sijie commented on a change in pull request #1564: Support short topic name in cpp client URL: https://github.com/apache/incubator-pulsar/pull/1564#discussion_r181237995 ## File path: pulsar-client-cpp/lib/TopicName.cc ## @@ -52,8 +52,19 @@ TopicName::TopicName() {} bool

[GitHub] sijie opened a new pull request #1564: Support short topic name in cpp client

sijie opened a new pull request #1564: Support short topic name in cpp client URL: https://github.com/apache/incubator-pulsar/pull/1564 This related to #1535 - support short topic name in cpp client. This is an automated

[GitHub] merlimat closed pull request #1547: Make client keepAliveInterval configurable in client side

merlimat closed pull request #1547: Make client keepAliveInterval configurable in client side URL: https://github.com/apache/incubator-pulsar/pull/1547 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] srkukarni commented on issue #1563: Added RabbitMQ source to Pulsar Connect

srkukarni commented on issue #1563: Added RabbitMQ source to Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1563#issuecomment-380947768 @merlimat @sijie This is an automated message from the Apache Git

[GitHub] sijie closed issue #1536: Add "default" tenant & "default" namespace

sijie closed issue #1536: Add "default" tenant & "default" namespace URL: https://github.com/apache/incubator-pulsar/issues/1536 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-pulsar] branch master updated: Issue #1536: Introduce Short Topic Name (#1535)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 61de30d Issue #1536: Introduce Short

[GitHub] sijie closed pull request #1535: Issue #1536: Introduce Short Topic Name

sijie closed pull request #1535: Issue #1536: Introduce Short Topic Name URL: https://github.com/apache/incubator-pulsar/pull/1535 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat commented on issue #1562: Converted to v2 topic names test related to ProducerConsumerBase

merlimat commented on issue #1562: Converted to v2 topic names test related to ProducerConsumerBase URL: https://github.com/apache/incubator-pulsar/pull/1562#issuecomment-380946821 retest this please This is an automated

[GitHub] mgodave commented on a change in pull request #1551: Json schema codec

mgodave commented on a change in pull request #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#discussion_r181219020 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleTypedProducerConsumerTest.java ## @@ -0,0

[GitHub] mgodave commented on a change in pull request #1551: Json schema codec

mgodave commented on a change in pull request #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#discussion_r181219020 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleTypedProducerConsumerTest.java ## @@ -0,0

[GitHub] mgodave commented on issue #1551: Json schema codec

mgodave commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380936892 I suppose I could hack in a default "is compatible" check that literally checks if they are equal which would require schema updates to happen via the REST

[GitHub] mgodave commented on issue #1551: Json schema codec

mgodave commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380928449 > * When we attempt to create the producer, we should validate the schema this producer is about to start sending is compatible with the last schema we have

[GitHub] sijie commented on a change in pull request #1535: Issue #1536: Introduce Short Topic Name

sijie commented on a change in pull request #1535: Issue #1536: Introduce Short Topic Name URL: https://github.com/apache/incubator-pulsar/pull/1535#discussion_r181198970 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java ## @@

[GitHub] sijie commented on a change in pull request #1535: Issue #1536: Introduce Short Topic Name

sijie commented on a change in pull request #1535: Issue #1536: Introduce Short Topic Name URL: https://github.com/apache/incubator-pulsar/pull/1535#discussion_r181195826 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java ## @@

[GitHub] sijie commented on issue #1440: Update default values for a few publisher settings

sijie commented on issue #1440: Update default values for a few publisher settings URL: https://github.com/apache/incubator-pulsar/pull/1440#issuecomment-380919510 managed ledger closed test failed. seems like a flaky test. rebased to latest master.

[GitHub] merlimat commented on a change in pull request #1535: Issue #1536: Introduce Short Topic Name

merlimat commented on a change in pull request #1535: Issue #1536: Introduce Short Topic Name URL: https://github.com/apache/incubator-pulsar/pull/1535#discussion_r181197109 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java ## @@

[incubator-pulsar] branch master updated: Honor User specified Subscription Types while running functions (#1560)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1fc4b35 Honor User specified

[GitHub] sijie closed pull request #1560: Honor User specified Subscription Types while running functions

sijie closed pull request #1560: Honor User specified Subscription Types while running functions URL: https://github.com/apache/incubator-pulsar/pull/1560 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie closed pull request #1561: Utility for integration tests to wait for ZK

sijie closed pull request #1561: Utility for integration tests to wait for ZK URL: https://github.com/apache/incubator-pulsar/pull/1561 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie commented on a change in pull request #1538: Add rate limit for client lookup requests

sijie commented on a change in pull request #1538: Add rate limit for client lookup requests URL: https://github.com/apache/incubator-pulsar/pull/1538#discussion_r181181049 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java ## @@

[GitHub] sijie commented on a change in pull request #1538: Add rate limit for client lookup requests

sijie commented on a change in pull request #1538: Add rate limit for client lookup requests URL: https://github.com/apache/incubator-pulsar/pull/1538#discussion_r181183798 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java ## @@

[GitHub] sijie commented on a change in pull request #1538: Add rate limit for client lookup requests

sijie commented on a change in pull request #1538: Add rate limit for client lookup requests URL: https://github.com/apache/incubator-pulsar/pull/1538#discussion_r181183133 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java

[GitHub] sijie commented on a change in pull request #1538: Add rate limit for client lookup requests

sijie commented on a change in pull request #1538: Add rate limit for client lookup requests URL: https://github.com/apache/incubator-pulsar/pull/1538#discussion_r181180624 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java ## @@

[GitHub] sijie commented on a change in pull request #1538: Add rate limit for client lookup requests

sijie commented on a change in pull request #1538: Add rate limit for client lookup requests URL: https://github.com/apache/incubator-pulsar/pull/1538#discussion_r181184955 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java ## @@

[GitHub] merlimat commented on a change in pull request #1562: Converted to v2 topic names test related to ProducerConsumerBase

merlimat commented on a change in pull request #1562: Converted to v2 topic names test related to ProducerConsumerBase URL: https://github.com/apache/incubator-pulsar/pull/1562#discussion_r181184646 ## File path:

[GitHub] merlimat commented on a change in pull request #1562: Converted to v2 topic names test related to ProducerConsumerBase

merlimat commented on a change in pull request #1562: Converted to v2 topic names test related to ProducerConsumerBase URL: https://github.com/apache/incubator-pulsar/pull/1562#discussion_r181183241 ## File path:

[GitHub] sijie commented on a change in pull request #1562: Converted to v2 topic names test related to ProducerConsumerBase

sijie commented on a change in pull request #1562: Converted to v2 topic names test related to ProducerConsumerBase URL: https://github.com/apache/incubator-pulsar/pull/1562#discussion_r181179101 ## File path:

[GitHub] srkukarni commented on issue #1557: Added Kafka Source and Kafka Sink to Pulsar Connect

srkukarni commented on issue #1557: Added Kafka Source and Kafka Sink to Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1557#issuecomment-380899820 @merlimat I've standardized the versions used by both modules. Please take a look again. Thanks!

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181171240 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181173676 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181176581 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181176505 ## File path: managed-ledger/src/main/proto/MLDataFormats.proto ## @@ -27,6 +27,7 @@ message

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181167383 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181176228 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181168613 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181175295 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181176348 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181167564 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java

[incubator-pulsar] branch master updated: Documentation for non-persistent topics (#1468)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fafc963 Documentation for

[GitHub] merlimat closed pull request #1468: Documentation for non-persistent topics

merlimat closed pull request #1468: Documentation for non-persistent topics URL: https://github.com/apache/incubator-pulsar/pull/1468 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat commented on a change in pull request #1535: Issue #1536: Introduce Short Topic Name

merlimat commented on a change in pull request #1535: Issue #1536: Introduce Short Topic Name URL: https://github.com/apache/incubator-pulsar/pull/1535#discussion_r181172292 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java ## @@

[GitHub] merlimat commented on issue #1561: Utility for integration tests to wait for ZK

merlimat commented on issue #1561: Utility for integration tests to wait for ZK URL: https://github.com/apache/incubator-pulsar/pull/1561#issuecomment-380890956 retest this please This is an automated message from the Apache

[GitHub] merlimat commented on a change in pull request #1551: Json schema codec

merlimat commented on a change in pull request #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#discussion_r181162646 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleTypedProducerConsumerTest.java ## @@ -0,0

[GitHub] merlimat commented on a change in pull request #1551: Json schema codec

merlimat commented on a change in pull request #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#discussion_r181162788 ## File path: pulsar-client/pom.xml ## @@ -97,6 +97,12 @@ 4.4.9 + Review comment: The version

[GitHub] merlimat commented on a change in pull request #1551: Json schema codec

merlimat commented on a change in pull request #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#discussion_r181163341 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/Message.java ## @@ -63,7 +63,7 @@ */

[GitHub] sijie commented on issue #1551: Json schema codec

sijie commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380883551 @mgodave works for me. +1 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie closed pull request #1550: Issue #1517: make getLastConfirmedEntry in ManagedLedgerImpl return real LAC

sijie closed pull request #1550: Issue #1517: make getLastConfirmedEntry in ManagedLedgerImpl return real LAC URL: https://github.com/apache/incubator-pulsar/pull/1550 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[incubator-pulsar] branch master updated: Issue #1517: make getLastConfirmedEntry in ManagedLedgerImpl return real LAC (#1550)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2de50a7 Issue #1517: make

[incubator-pulsar] branch master updated: Use `AtomicInteger` in LoggingFunction (#1558)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 199961e Use `AtomicInteger` in

[GitHub] merlimat closed pull request #1558: Use `AtomicInteger` in LoggingFunction

merlimat closed pull request #1558: Use `AtomicInteger` in LoggingFunction URL: https://github.com/apache/incubator-pulsar/pull/1558 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat commented on a change in pull request #1557: Added Kafka Source and Kafka Sink to Pulsar Connect

merlimat commented on a change in pull request #1557: Added Kafka Source and Kafka Sink to Pulsar Connect URL: https://github.com/apache/incubator-pulsar/pull/1557#discussion_r181147097 ## File path: pom.xml ## @@ -144,6 +144,7 @@ flexible messaging model and an intuitive

[GitHub] merlimat closed pull request #1559: Allow proxy to come up before any brokers have

merlimat closed pull request #1559: Allow proxy to come up before any brokers have URL: https://github.com/apache/incubator-pulsar/pull/1559 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Allow proxy to come up before any brokers have (#1559)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1c9c074 Allow proxy to come up

[GitHub] mgodave commented on issue #1551: Json schema codec

mgodave commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380866438 @sijie circling back on your tutorial comment, I merely added some more files to an existing set of examples. I agree that this should not live under test

[GitHub] srkukarni commented on issue #1560: Honor User specified Subscription Types while running functions

srkukarni commented on issue #1560: Honor User specified Subscription Types while running functions URL: https://github.com/apache/incubator-pulsar/pull/1560#issuecomment-380864475 retest this please This is an automated

[GitHub] merlimat opened a new pull request #1562: Converted to v2 topic names test related to ProducerConsumerBase

merlimat opened a new pull request #1562: Converted to v2 topic names test related to ProducerConsumerBase URL: https://github.com/apache/incubator-pulsar/pull/1562 ### Motivation This is the first set of changes to convert unit tests to use v2 topic names. The PR contains

[GitHub] mgodave commented on issue #1551: Json schema codec

mgodave commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380845432 Yeah, I had hoped to take a look yesterday evening but fell asleep. Looking now. re: example under "test", I honestly didn't look, I copied an existing

[GitHub] ivankelly opened a new pull request #1561: Utility for integration tests to wait for ZK

ivankelly opened a new pull request #1561: Utility for integration tests to wait for ZK URL: https://github.com/apache/incubator-pulsar/pull/1561 Utility to allow an integration test to wait for zookeeper to come up before proceeding.

[GitHub] srkukarni commented on issue #1560: Honor User specified Subscription Types while running functions

srkukarni commented on issue #1560: Honor User specified Subscription Types while running functions URL: https://github.com/apache/incubator-pulsar/pull/1560#issuecomment-380825894 @sijie @merlimat This is an automated

[GitHub] srkukarni opened a new pull request #1560: Honor User specified Subscription Types while running functions

srkukarni opened a new pull request #1560: Honor User specified Subscription Types while running functions URL: https://github.com/apache/incubator-pulsar/pull/1560 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to

[GitHub] sijie commented on issue #1535: Issue #1536: Introduce Short Topic Name

sijie commented on issue #1535: Issue #1536: Introduce Short Topic Name URL: https://github.com/apache/incubator-pulsar/pull/1535#issuecomment-380743572 @merlimat this is ready for reviews This is an automated message from

[GitHub] sijie commented on issue #1551: Json schema codec

sijie commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380743237 @mgodave "javax/validation/constraints/NotBlank" not found - it sounds strange to me. This is

[GitHub] sijie closed pull request #1548: Fixed race condition intruduced managed ledger addEntry introduced in #1521

sijie closed pull request #1548: Fixed race condition intruduced managed ledger addEntry introduced in #1521 URL: https://github.com/apache/incubator-pulsar/pull/1548 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[incubator-pulsar] branch master updated: Fixed race condition intruduced managed ledger addEntry introduced in #1521 (#1548)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new aff6c04 Fixed race condition

[incubator-pulsar] branch master updated: remove unnecessary proto def in FunctionsConfig (#1531)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0fd4e84 remove unnecessary proto def

[GitHub] sijie closed pull request #1531: remove unnecessary proto def in FunctionsConfig

sijie closed pull request #1531: remove unnecessary proto def in FunctionsConfig URL: https://github.com/apache/incubator-pulsar/pull/1531 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jerrypeng commented on issue #1531: remove unnecessary proto def in FunctionsConfig

jerrypeng commented on issue #1531: remove unnecessary proto def in FunctionsConfig URL: https://github.com/apache/incubator-pulsar/pull/1531#issuecomment-380694622 @sijie can we merge this? This is an automated message from

[GitHub] jerrypeng commented on issue #1552: renaming/changing FunctionConfig

jerrypeng commented on issue #1552: renaming/changing FunctionConfig URL: https://github.com/apache/incubator-pulsar/pull/1552#issuecomment-380694542 @sijie I have rebased This is an automated message from the Apache Git