[GitHub] rdhabalia opened a new pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-10 Thread GitBox
rdhabalia opened a new pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg URL: https://github.com/apache/incubator-pulsar/pull/2549 ### Motivation As discussed at #2438 and #2474, we would like to fix function assignment approach

[GitHub] rdhabalia commented on issue #2535: Add ledger op timeout to avoid topics stuck on ledger-creation

2018-09-10 Thread GitBox
rdhabalia commented on issue #2535: Add ledger op timeout to avoid topics stuck on ledger-creation URL: https://github.com/apache/incubator-pulsar/pull/2535#issuecomment-419817615 @merlimat can you please review it as we want to use this patch in our current deployed-release.

[GitHub] codelipenghui commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…

2018-09-09 Thread GitBox
codelipenghui commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC… URL: https://github.com/apache/incubator-pulsar/pull/2543#discussion_r216212676 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/

[GitHub] snoodleboot commented on issue #271: Consider using gRPC as an externally exposed API

2018-09-09 Thread GitBox
snoodleboot commented on issue #271: Consider using gRPC as an externally exposed API URL: https://github.com/apache/incubator-pulsar/issues/271#issuecomment-419781785 I would love to see this! I can understand about pub/sub. It really doesn't serve the same purpose as Pulsar or any distr

[GitHub] rdhabalia opened a new pull request #2548: Stop all functions gracefully on closing worker-service

2018-09-09 Thread GitBox
rdhabalia opened a new pull request #2548: Stop all functions gracefully on closing worker-service URL: https://github.com/apache/incubator-pulsar/pull/2548 ### Motivation Right now, if stopping [WorkerService](https://github.com/apache/incubator-pulsar/blob/master/pulsar-functions/

[GitHub] YuiFn closed pull request #2547: Merge pull request #1 from apache/master

2018-09-09 Thread GitBox
YuiFn closed pull request #2547: Merge pull request #1 from apache/master URL: https://github.com/apache/incubator-pulsar/pull/2547 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] YuiFn opened a new pull request #2547: Merge pull request #1 from apache/master

2018-09-09 Thread GitBox
YuiFn opened a new pull request #2547: Merge pull request #1 from apache/master URL: https://github.com/apache/incubator-pulsar/pull/2547 merge remote ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve.

[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types

2018-09-09 Thread GitBox
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-419754258 run java8 tests run integration tests This is an automated message fro

[GitHub] sijie closed pull request #2511: [documentation] Add section about licensing at contribution guide

2018-09-09 Thread GitBox
sijie closed pull request #2511: [documentation] Add section about licensing at contribution guide URL: https://github.com/apache/incubator-pulsar/pull/2511 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[GitHub] sijie closed pull request #2529: Added cmake install for lib and headers

2018-09-09 Thread GitBox
sijie closed pull request #2529: Added cmake install for lib and headers URL: https://github.com/apache/incubator-pulsar/pull/2529 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419746688 Sure. We can reorganize modules to do that. but it will take some time to make sure it doesn’t break others like CI, release process

[GitHub] kramasamy commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
kramasamy commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419744589 Another options is move the dockerfile to the top. Duplicating code and config will be difficult to manage as time goes on

[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419743264 you can point to a location of a dockerfile. But in the dockerfile defintion, you can’t access files not in the same dir as the docke

[GitHub] cckellogg edited a comment on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
cckellogg edited a comment on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419742245 Is that a maven issue? There is a way to point to a specific file when doing a docker build "$ docker build -f /path/

[GitHub] cckellogg commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
cckellogg commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419742245 Is that a maven issue? There is a way to point to a specific file when do a docker build "$ docker build -f /path/to/a/Docker

[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419741657 We can’t do it, because docker doesn’t allow accessing files outside the dockerfile directory. To deliver this ASAP, we have to copy

[GitHub] kramasamy commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
kramasamy commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419741204 @sijie @merlimat - these code seems to be copy of the code under /dashboard. This is not a clean way to do this - since any chang

[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-09 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419740749 @cckellogg not sure if we can easily change to sqlite. It is probably ok, however I would not suggest changing it right now. Because

[GitHub] david-streamlio commented on issue #2546: Elastic connector

2018-09-09 Thread GitBox
david-streamlio commented on issue #2546: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2546#issuecomment-419734115 How do I view the actual cause of the error.. org.apache.pulsar.tests.integration.docker.ContainerExecException: /pulsar/bin/pulsar-admin sink

[GitHub] srkukarni commented on issue #2546: Elastic connector

2018-09-09 Thread GitBox
srkukarni commented on issue #2546: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2546#issuecomment-419724450 run integration tests This is an automated message from the Apache Git Service. To respond

[GitHub] merlimat commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…

2018-09-08 Thread GitBox
merlimat commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC… URL: https://github.com/apache/incubator-pulsar/pull/2543#discussion_r216139475 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/Pulsa

[GitHub] merlimat commented on issue #2529: Added cmake install for lib and headers

2018-09-08 Thread GitBox
merlimat commented on issue #2529: Added cmake install for lib and headers URL: https://github.com/apache/incubator-pulsar/pull/2529#issuecomment-419668830 run java8 tests This is an automated message from the Apache Git Servi

[GitHub] merlimat commented on issue #2511: [documentation] Add section about licensing at contribution guide

2018-09-08 Thread GitBox
merlimat commented on issue #2511: [documentation] Add section about licensing at contribution guide URL: https://github.com/apache/incubator-pulsar/pull/2511#issuecomment-419668698 run java8 tests This is an automated messag

[GitHub] merlimat closed pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-08 Thread GitBox
merlimat closed pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] merlimat closed pull request #2542: Fix status code of REST API to get partitioned topic stats

2018-09-08 Thread GitBox
merlimat closed pull request #2542: Fix status code of REST API to get partitioned topic stats URL: https://github.com/apache/incubator-pulsar/pull/2542 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[GitHub] merlimat closed pull request #2540: Enable C++ AuthFactory to parse Athenz params string

2018-09-08 Thread GitBox
merlimat closed pull request #2540: Enable C++ AuthFactory to parse Athenz params string URL: https://github.com/apache/incubator-pulsar/pull/2540 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[GitHub] srkukarni commented on a change in pull request #2546: Elastic connector

2018-09-07 Thread GitBox
srkukarni commented on a change in pull request #2546: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2546#discussion_r216108285 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java ##

[GitHub] srkukarni commented on a change in pull request #2546: Elastic connector

2018-09-07 Thread GitBox
srkukarni commented on a change in pull request #2546: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2546#discussion_r216108235 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java ##

[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types

2018-09-07 Thread GitBox
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-419588399 retest this please This is an automated message from the Apache Git Servi

[GitHub] sijie commented on issue #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-07 Thread GitBox
sijie commented on issue #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#issuecomment-419588318 run integration tests This is an

[GitHub] david-streamlio opened a new pull request #2546: Elastic connector

2018-09-07 Thread GitBox
david-streamlio opened a new pull request #2546: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2546 ### Motivation Added a sink connector that writes JSON documents into ElasticSearch ### Modifications Added new pulsar-io module and associated in

[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-07 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419582422 @cckellogg ^^ This is an automated message from the Apache Git Servi

[GitHub] sijie opened a new pull request #2545: [docker] introduce a pulsar standalone image

2018-09-07 Thread GitBox
sijie opened a new pull request #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545 ## Motivation `pulsar` and `pulsar-all` are designed for running pulsar components on production. although it can be used for running sta

[GitHub] david-streamlio closed pull request #2539: Elastic connector

2018-09-07 Thread GitBox
david-streamlio closed pull request #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull requ

[GitHub] david-streamlio commented on issue #2539: Elastic connector

2018-09-07 Thread GitBox
david-streamlio commented on issue #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539#issuecomment-419580734 Going to create a new PR for this This is an automated message from the Apache Git Se

[GitHub] jerrypeng closed pull request #2534: set correct guice version to prevent dependency inject errors in docker container

2018-09-07 Thread GitBox
jerrypeng closed pull request #2534: set correct guice version to prevent dependency inject errors in docker container URL: https://github.com/apache/incubator-pulsar/pull/2534 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] jerrypeng closed pull request #2515: support nested fields in Pulsar presto connector

2018-09-07 Thread GitBox
jerrypeng closed pull request #2515: support nested fields in Pulsar presto connector URL: https://github.com/apache/incubator-pulsar/pull/2515 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] sijie commented on issue #2516: Fix: get function status with auth enable

2018-09-07 Thread GitBox
sijie commented on issue #2516: Fix: get function status with auth enable URL: https://github.com/apache/incubator-pulsar/pull/2516#issuecomment-419541323 @jerrypeng can you review this one? This is an automated message from t

[GitHub] sijie closed pull request #2525: fixed zookeeper name references in helm charts.

2018-09-07 Thread GitBox
sijie closed pull request #2525: fixed zookeeper name references in helm charts. URL: https://github.com/apache/incubator-pulsar/pull/2525 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] sijie commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…

2018-09-07 Thread GitBox
sijie commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC… URL: https://github.com/apache/incubator-pulsar/pull/2543#discussion_r216063192 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ServiceUr

[GitHub] sijie commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…

2018-09-07 Thread GitBox
sijie commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC… URL: https://github.com/apache/incubator-pulsar/pull/2543#discussion_r216063470 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarCl

[GitHub] sijie commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-07 Thread GitBox
sijie commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#discussion_r216062802 ## File path: pulsar-functions/java-examples/pom.xml ## @@ -41,

[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types

2018-09-07 Thread GitBox
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-419529566 retest this please This is an automated message from the Apache Git Servi

[GitHub] sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-07 Thread GitBox
sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419524091 @dave2wave yes. there was already an email thread about "how to label milestone". I was hoping the discussion regar

[GitHub] dave2wave commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-07 Thread GitBox
dave2wave commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419521175 I think that the topic being discussed - how to tag and build a release including the policies should be surfac

[GitHub] maskit commented on issue #2544: Readd MockBookKeeper to Pulsar

2018-09-07 Thread GitBox
maskit commented on issue #2544: Readd MockBookKeeper to Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2544#issuecomment-419520495 Do the namespaces have to be "org.apache.bookkeeper.client"? These mocks are now Pulsar's, right? (Am I the only one who read the subject a

[GitHub] srkukarni commented on issue #2525: fixed zookeeper name references in helm charts.

2018-09-07 Thread GitBox
srkukarni commented on issue #2525: fixed zookeeper name references in helm charts. URL: https://github.com/apache/incubator-pulsar/pull/2525#issuecomment-419519461 run integration tests This is an automated message from the

[GitHub] jerrypeng commented on issue #2534: set correct guice version to prevent dependency inject errors in docker container

2018-09-07 Thread GitBox
jerrypeng commented on issue #2534: set correct guice version to prevent dependency inject errors in docker container URL: https://github.com/apache/incubator-pulsar/pull/2534#issuecomment-419519288 rerun java8 tests This is

[GitHub] maskit commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-07 Thread GitBox
maskit commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419516617 Alright, it seems like I need to read what the script actually does. Although I haven't read the script at a

[GitHub] vli02 commented on issue #2525: fixed zookeeper name references in helm charts.

2018-09-07 Thread GitBox
vli02 commented on issue #2525: fixed zookeeper name references in helm charts. URL: https://github.com/apache/incubator-pulsar/pull/2525#issuecomment-419514407 Can someone re-run the failed check? This is an automated message

[GitHub] ivankelly opened a new pull request #2544: Readd MockBookKeeper to Pulsar

2018-09-07 Thread GitBox
ivankelly opened a new pull request #2544: Readd MockBookKeeper to Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2544 These mocks were moved out of pulsar to the bookkeeper project a few months ago. While it is good to have mocks generally available for bookkeeper, if the

[GitHub] merlimat commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-07 Thread GitBox
merlimat commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#discussion_r216012606 ## File path: pulsar-functions/java-examples/pom.xml ## @@ -

[GitHub] srkukarni commented on a change in pull request #2539: Elastic connector

2018-09-07 Thread GitBox
srkukarni commented on a change in pull request #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539#discussion_r216009801 ## File path: pulsar-io/pom.xml ## @@ -42,6 +42,8 @@ hdfs jdbc data-genenator +hdfs Review comment:

[GitHub] sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-07 Thread GitBox
sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419482578 i think there is a confusion here. There is no policy coded into the script. It is still left to the community to c

[GitHub] david-streamlio opened a new pull request #2539: Elastic connector

2018-09-07 Thread GitBox
david-streamlio opened a new pull request #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539 ### Motivation Added a sink connector that writes JSON documents into ElasticSearch ### Modifications Added new pulsar-io module and associated in

[GitHub] maskit commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-07 Thread GitBox
maskit commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419464632 > agreed. that's what I stated in the mail thread. what I need is a clear policy. the tool here is adding enforcem

[GitHub] david-streamlio closed pull request #2539: Elastic connector

2018-09-07 Thread GitBox
david-streamlio closed pull request #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull requ

[GitHub] ivankelly commented on issue #240: Intermittent test failures in ManagedLedgerErrorsTest.recoverLongTimeAfterMultipleWriteErrors

2018-09-07 Thread GitBox
ivankelly commented on issue #240: Intermittent test failures in ManagedLedgerErrorsTest.recoverLongTimeAfterMultipleWriteErrors URL: https://github.com/apache/incubator-pulsar/issues/240#issuecomment-419445815 I repro'd on a checkout from when this was reported, and it looks like a legit

[GitHub] massakam commented on issue #2542: Fix status code of REST API to get partitioned topic stats

2018-09-07 Thread GitBox
massakam commented on issue #2542: Fix status code of REST API to get partitioned topic stats URL: https://github.com/apache/incubator-pulsar/pull/2542#issuecomment-419422773 rerun java8 tests This is an automated message fro

[GitHub] codelipenghui opened a new pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…

2018-09-07 Thread GitBox
codelipenghui opened a new pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC… URL: https://github.com/apache/incubator-pulsar/pull/2543 Support build Pulsar client with serviceUrlProvider method. ### Motivation With serviceUrlProvider we

[GitHub] hrsakai commented on issue #2541: Enclose client_auth_params value in single quotes

2018-09-07 Thread GitBox
hrsakai commented on issue #2541: Enclose client_auth_params value in single quotes URL: https://github.com/apache/incubator-pulsar/pull/2541#issuecomment-41937 I may have misunderstood, so I close this once. This is an

[GitHub] hrsakai closed pull request #2541: Enclose client_auth_params value in single quotes

2018-09-07 Thread GitBox
hrsakai closed pull request #2541: Enclose client_auth_params value in single quotes URL: https://github.com/apache/incubator-pulsar/pull/2541 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] massakam opened a new pull request #2542: Fix status code of REST API to get partitioned topic stats

2018-09-07 Thread GitBox
massakam opened a new pull request #2542: Fix status code of REST API to get partitioned topic stats URL: https://github.com/apache/incubator-pulsar/pull/2542 ### Motivation If trying to get stats of partitioned topic whose internal topics have not been generated, `500 Internal Serv

[GitHub] jerrypeng commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-06 Thread GitBox
jerrypeng commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#discussion_r215860896 ## File path: pulsar-functions/instance/src/main/java/org/apache/pul

[GitHub] sijie commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-06 Thread GitBox
sijie commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#discussion_r215859148 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/

[GitHub] jerrypeng commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-06 Thread GitBox
jerrypeng commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#discussion_r215858084 ## File path: pulsar-functions/instance/src/main/java/org/apache/pul

[GitHub] hrsakai commented on issue #2541: Enclose client_auth_params value in single quotes

2018-09-06 Thread GitBox
hrsakai commented on issue #2541: Enclose client_auth_params value in single quotes URL: https://github.com/apache/incubator-pulsar/pull/2541#issuecomment-419331776 run java8 tests This is an automated message from the Apache

[GitHub] hrsakai opened a new pull request #2541: Enclose client_auth_params value in single quotes

2018-09-06 Thread GitBox
hrsakai opened a new pull request #2541: Enclose client_auth_params value in single quotes URL: https://github.com/apache/incubator-pulsar/pull/2541 ### Motivation Currently, we can't specify json string to `clientAuthenticationParameters` in `functions_worker.yaml` because we can't pa

[GitHub] massakam opened a new pull request #2540: Enable C++ AuthFactory to parse Athenz params string

2018-09-06 Thread GitBox
massakam opened a new pull request #2540: Enable C++ AuthFactory to parse Athenz params string URL: https://github.com/apache/incubator-pulsar/pull/2540 ### Motivation Currently, we can not create an Athenz authentication object using the following C++ method: ```cpp Authentic

[GitHub] jerrypeng commented on issue #2534: set correct guice version to prevent dependency inject errors in docker container

2018-09-06 Thread GitBox
jerrypeng commented on issue #2534: set correct guice version to prevent dependency inject errors in docker container URL: https://github.com/apache/incubator-pulsar/pull/2534#issuecomment-419325076 rerun java8 tests This is

[GitHub] jerrypeng commented on issue #2534: set correct guice version to prevent dependency inject errors in docker container

2018-09-06 Thread GitBox
jerrypeng commented on issue #2534: set correct guice version to prevent dependency inject errors in docker container URL: https://github.com/apache/incubator-pulsar/pull/2534#issuecomment-419325104 rerun integration tests Th

[GitHub] sijie commented on issue #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-06 Thread GitBox
sijie commented on issue #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#issuecomment-419324584 run java8 tests This is an automa

[GitHub] sijie commented on issue #2539: Elastic connector

2018-09-06 Thread GitBox
sijie commented on issue #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539#issuecomment-419324538 @david-streamlio it doesn't seem to have the elastic connector code. did you commit to your branch? ---

[GitHub] david-streamlio opened a new pull request #2539: Elastic connector

2018-09-06 Thread GitBox
david-streamlio opened a new pull request #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539 ### Motivation Added a sink connector that writes JSON documents into ElasticSearch ### Modifications Added new pulsar-io module and associated in

[GitHub] srkukarni closed pull request #2532: When WindowConfig is set, automatically default autoAck to false

2018-09-06 Thread GitBox
srkukarni closed pull request #2532: When WindowConfig is set, automatically default autoAck to false URL: https://github.com/apache/incubator-pulsar/pull/2532 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of p

[GitHub] sijie commented on issue #2538: [io] jdbc connector uses Schema.AUTO

2018-09-06 Thread GitBox
sijie commented on issue #2538: [io] jdbc connector uses Schema.AUTO URL: https://github.com/apache/incubator-pulsar/pull/2538#issuecomment-419296875 This PR is based on #2537 This is an automated message from the Apache Git

[GitHub] sijie opened a new pull request #2538: [io] jdbc connector uses Schema.AUTO

2018-09-06 Thread GitBox
sijie opened a new pull request #2538: [io] jdbc connector uses Schema.AUTO URL: https://github.com/apache/incubator-pulsar/pull/2538 ### Motivation in #2537 , we are enabling `Schema.AUTO` in functions and connectors. This change is changing JDBC connector to use `Schema.AUTO`

[GitHub] sijie opened a new pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-06 Thread GitBox
sijie opened a new pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537 ### Motivation For connectors like JDBC connector, we will be using `GenericRecord` for mapping individ

[GitHub] srkukarni commented on issue #2532: When WindowConfig is set, automatically default autoAck to false

2018-09-06 Thread GitBox
srkukarni commented on issue #2532: When WindowConfig is set, automatically default autoAck to false URL: https://github.com/apache/incubator-pulsar/pull/2532#issuecomment-419288497 run java8 tests This is an automated messag

[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types

2018-09-06 Thread GitBox
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-419287810 run java8 tests run integration tests This is an automated message fro

[GitHub] rdhabalia closed pull request #2536: Remove bad-checkin test files

2018-09-06 Thread GitBox
rdhabalia closed pull request #2536: Remove bad-checkin test files URL: https://github.com/apache/incubator-pulsar/pull/2536 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] rdhabalia commented on issue #2536: Remove bad-checkin test files

2018-09-06 Thread GitBox
rdhabalia commented on issue #2536: Remove bad-checkin test files URL: https://github.com/apache/incubator-pulsar/pull/2536#issuecomment-419279571 Oh, I didn't see the comments earlier.. This is an automated message from the A

[GitHub] merlimat commented on issue #2536: Remove bad-checkin test files

2018-09-06 Thread GitBox
merlimat commented on issue #2536: Remove bad-checkin test files URL: https://github.com/apache/incubator-pulsar/pull/2536#issuecomment-419277916 @rdhabalia These files were checked on purpose, to have integration test when downgrading ZK from 3.5 to 3.4 ---

[GitHub] jerrypeng commented on issue #2534: set correct guice version to prevent dependency inject errors in docker container

2018-09-06 Thread GitBox
jerrypeng commented on issue #2534: set correct guice version to prevent dependency inject errors in docker container URL: https://github.com/apache/incubator-pulsar/pull/2534#issuecomment-419273365 rerun java8 tests This

[GitHub] rdhabalia opened a new pull request #2536: Remove bad-checkin test files

2018-09-06 Thread GitBox
rdhabalia opened a new pull request #2536: Remove bad-checkin test files URL: https://github.com/apache/incubator-pulsar/pull/2536 ### Motivation Remove bad-checkin from #2473 This is an automated message from the A

[GitHub] rdhabalia opened a new pull request #2535: Add ledger op timeout to avoid topics stuck on ledger-creation

2018-09-06 Thread GitBox
rdhabalia opened a new pull request #2535: Add ledger op timeout to avoid topics stuck on ledger-creation URL: https://github.com/apache/incubator-pulsar/pull/2535 ### Motivation Frequently, we are having issue where many topics across the all brokers get stuck on creating-ledger st

[GitHub] grantwwu commented on issue #2217: Add v2 to Admin API REST documentation

2018-09-06 Thread GitBox
grantwwu commented on issue #2217: Add v2 to Admin API REST documentation URL: https://github.com/apache/incubator-pulsar/issues/2217#issuecomment-419264204 This appears to have been done already by someone else, cheers This

[GitHub] grantwwu closed issue #2217: Add v2 to Admin API REST documentation

2018-09-06 Thread GitBox
grantwwu closed issue #2217: Add v2 to Admin API REST documentation URL: https://github.com/apache/incubator-pulsar/issues/2217 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types

2018-09-06 Thread GitBox
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-419243923 retest this please This is an automated message from the Apache Git Servi

[GitHub] jerrypeng opened a new pull request #2534: set correct guice version to prevent dependency inject errors in docker container

2018-09-06 Thread GitBox
jerrypeng opened a new pull request #2534: set correct guice version to prevent dependency inject errors in docker container URL: https://github.com/apache/incubator-pulsar/pull/2534 ### Motivation Dependency injection errors are thrown while starting up in docker container when usi

[GitHub] dsambandam opened a new issue #2533: can't generate ca key using the open ssl cnf file suggested for TLS Auth

2018-09-06 Thread GitBox
dsambandam opened a new issue #2533: can't generate ca key using the open ssl cnf file suggested for TLS Auth URL: https://github.com/apache/incubator-pulsar/issues/2533 Expected behavior Tell us what should happen Actual behavior can't generate ca key using the o

[GitHub] srkukarni commented on issue #2532: When WindowConfig is set, automatically default autoAck to false

2018-09-06 Thread GitBox
srkukarni commented on issue #2532: When WindowConfig is set, automatically default autoAck to false URL: https://github.com/apache/incubator-pulsar/pull/2532#issuecomment-419227691 run java8 tests This is an automated messag

[GitHub] aahmed-se commented on issue #687: Provide configuration for stats update frequency for test clusters

2018-09-06 Thread GitBox
aahmed-se commented on issue #687: Provide configuration for stats update frequency for test clusters URL: https://github.com/apache/incubator-pulsar/issues/687#issuecomment-419206943 what is the config ? This is an automate

[GitHub] srkukarni opened a new pull request #2532: When WindowConfig is set, automatically default autoAck to false

2018-09-06 Thread GitBox
srkukarni opened a new pull request #2532: When WindowConfig is set, automatically default autoAck to false URL: https://github.com/apache/incubator-pulsar/pull/2532 ### Motivation We set the value of autoAck true by default. This is done so because users should not need to set anot

[GitHub] srkukarni closed pull request #2523: Fix validator logic to differentiate between serializer and deserializer

2018-09-06 Thread GitBox
srkukarni closed pull request #2523: Fix validator logic to differentiate between serializer and deserializer URL: https://github.com/apache/incubator-pulsar/pull/2523 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the s

[GitHub] jerrypeng commented on a change in pull request #2515: support nested fields in Pulsar presto connector

2018-09-06 Thread GitBox
jerrypeng commented on a change in pull request #2515: support nested fields in Pulsar presto connector URL: https://github.com/apache/incubator-pulsar/pull/2515#discussion_r215725765 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/AvroSchemaHandle

[GitHub] jerrypeng commented on a change in pull request #2515: support nested fields in Pulsar presto connector

2018-09-06 Thread GitBox
jerrypeng commented on a change in pull request #2515: support nested fields in Pulsar presto connector URL: https://github.com/apache/incubator-pulsar/pull/2515#discussion_r215725500 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/AvroSchemaHandle

[GitHub] srkukarni closed pull request #2409: Added HDFS Sink

2018-09-06 Thread GitBox
srkukarni closed pull request #2409: Added HDFS Sink URL: https://github.com/apache/incubator-pulsar/pull/2409 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fro

[GitHub] sijie commented on a change in pull request #2515: support nested fields in Pulsar presto connector

2018-09-06 Thread GitBox
sijie commented on a change in pull request #2515: support nested fields in Pulsar presto connector URL: https://github.com/apache/incubator-pulsar/pull/2515#discussion_r215721822 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/AvroSchemaHandler.ja

[GitHub] sijie commented on a change in pull request #2515: support nested fields in Pulsar presto connector

2018-09-06 Thread GitBox
sijie commented on a change in pull request #2515: support nested fields in Pulsar presto connector URL: https://github.com/apache/incubator-pulsar/pull/2515#discussion_r215721946 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/JSONSchemaHandler.ja

<    1   2   3   4   5   6   7   8   9   10   >