[GitHub] merlimat closed pull request #1775: adding check for auto ack flag

2018-05-14 Thread GitBox
merlimat closed pull request #1775: adding check for auto ack flag URL: https://github.com/apache/incubator-pulsar/pull/1775 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] merlimat closed pull request #1769: refactor source and sink classname to be pulsar source and sink when not set

2018-05-14 Thread GitBox
merlimat closed pull request #1769: refactor source and sink classname to be pulsar source and sink when not set URL: https://github.com/apache/incubator-pulsar/pull/1769 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for th

[GitHub] lucperkins opened a new pull request #1776: Fix NPE in Pulsar Functions CLI

2018-05-14 Thread GitBox
lucperkins opened a new pull request #1776: Fix NPE in Pulsar Functions CLI URL: https://github.com/apache/incubator-pulsar/pull/1776 As it stands, an NPE is thrown if you try to `create` or `localrun` a function with neither a class name nor a function name supplied, as the CLI will attem

[GitHub] jerrypeng opened a new pull request #1777: Functions API compatibility patch for 2.0

2018-05-14 Thread GitBox
jerrypeng opened a new pull request #1777: Functions API compatibility patch for 2.0 URL: https://github.com/apache/incubator-pulsar/pull/1777 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] jerrypeng commented on issue #1777: Functions API compatibility patch for 2.0

2018-05-14 Thread GitBox
jerrypeng commented on issue #1777: Functions API compatibility patch for 2.0 URL: https://github.com/apache/incubator-pulsar/pull/1777#issuecomment-388975597 @merlimat @sijie @srkukarni please review and make sure that all API breaking changes are in the PR ---

[GitHub] lucperkins opened a new pull request #1778: Vendored imports

2018-05-14 Thread GitBox
lucperkins opened a new pull request #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] lucperkins commented on issue #1778: Vendored imports

2018-05-14 Thread GitBox
lucperkins commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-388980736 This PR was meant to be targeted to @merlimat's local branch. Closing this PR here. This i

[GitHub] lucperkins closed pull request #1778: Vendored imports

2018-05-14 Thread GitBox
lucperkins closed pull request #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (f

[GitHub] lucperkins opened a new pull request #1778: Vendored imports

2018-05-14 Thread GitBox
lucperkins opened a new pull request #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778 This PR adds vendored dependencies for the Pulsar Go client, in keeping with best practices for Go. The vendoring strategy here uses the [dep](https://github.com/golang/de

[GitHub] merlimat commented on issue #1764: WIP - Pulsar Go client library

2018-05-14 Thread GitBox
merlimat commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-388982480 @bruth @lucperkins some more polishing and added `context.Context` arg to `Send()`, `Receive()` and `Next()` calls. Please take another look. -

[GitHub] merlimat closed pull request #1777: Functions API compatibility patch for 2.0

2018-05-14 Thread GitBox
merlimat closed pull request #1777: Functions API compatibility patch for 2.0 URL: https://github.com/apache/incubator-pulsar/pull/1777 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat closed pull request #1771: setting auto ack to be true for sources and sinks

2018-05-14 Thread GitBox
merlimat closed pull request #1771: setting auto ack to be true for sources and sinks URL: https://github.com/apache/incubator-pulsar/pull/1771 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] bruth commented on issue #1764: WIP - Pulsar Go client library

2018-05-14 Thread GitBox
bruth commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-389009412 @merlimat Looks good. I noticed that the `Ack` calls don't take a context, but they (in theory) should. Since they interface with C, I realize that

[GitHub] sijie opened a new pull request #1779: Provide a vagrant file to launch a linux vm for running integration tests

2018-05-14 Thread GitBox
sijie opened a new pull request #1779: Provide a vagrant file to launch a linux vm for running integration tests URL: https://github.com/apache/incubator-pulsar/pull/1779 *Motivation* Currently all pulsar's integration tests and bc tests are docker based and written using arquill

[GitHub] sijie commented on issue #1779: Provide a vagrant file to launch a linux vm for running integration tests

2018-05-14 Thread GitBox
sijie commented on issue #1779: Provide a vagrant file to launch a linux vm for running integration tests URL: https://github.com/apache/incubator-pulsar/pull/1779#issuecomment-389024374 This is same as apache/bookkeeper#1401

[GitHub] sijie commented on issue #1776: Fix NPE in Pulsar Functions CLI

2018-05-14 Thread GitBox
sijie commented on issue #1776: Fix NPE in Pulsar Functions CLI URL: https://github.com/apache/incubator-pulsar/pull/1776#issuecomment-389024676 @jerrypeng @srkukarni ^^ This is an automated message from the Apache Git Service

[GitHub] hrsakai opened a new pull request #1780: Move isConnected method into each interface class

2018-05-14 Thread GitBox
hrsakai opened a new pull request #1780: Move isConnected method into each interface class URL: https://github.com/apache/incubator-pulsar/pull/1780 ### Motivation We want to check connection status with a broker on an application side. ### Modifications Move isConnecte

[GitHub] hrsakai commented on issue #1780: Move isConnected method into each interface class

2018-05-14 Thread GitBox
hrsakai commented on issue #1780: Move isConnected method into each interface class URL: https://github.com/apache/incubator-pulsar/pull/1780#issuecomment-389035885 retest this please This is an automated message from the Apa

[GitHub] zhaijack commented on issue #1768: InputStream to read from S3

2018-05-14 Thread GitBox
zhaijack commented on issue #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768#issuecomment-389039504 retest this please This is an automated message from the Apache Git Service. To re

[GitHub] jerrypeng opened a new pull request #1781: fixing behavior when configs are empty

2018-05-14 Thread GitBox
jerrypeng opened a new pull request #1781: fixing behavior when configs are empty URL: https://github.com/apache/incubator-pulsar/pull/1781 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] zhaijack commented on issue #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-14 Thread GitBox
zhaijack commented on issue #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#issuecomment-388581902 retest this please = org.apache.pulsar.tests.integration.TestSmoke.testPublishAndConsume ---

[GitHub] zhaijack commented on issue #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-14 Thread GitBox
zhaijack commented on issue #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#issuecomment-388556466 retest this please === org.apache.pulsar.tests.integration.TestSmoke.testPublishAndConsume -

[GitHub] sijie closed pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-15 Thread GitBox
sijie closed pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] sijie closed pull request #1768: InputStream to read from S3

2018-05-15 Thread GitBox
sijie closed pull request #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull requ

[GitHub] merlimat commented on issue #1764: WIP - Pulsar Go client library

2018-05-15 Thread GitBox
merlimat commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-389239317 > I noticed that the Ack calls don't take a context, but they (in theory) should. Since they interface with C, I realize that doesn't translate

[GitHub] merlimat closed pull request #1780: Move isConnected method into each interface class

2018-05-15 Thread GitBox
merlimat closed pull request #1780: Move isConnected method into each interface class URL: https://github.com/apache/incubator-pulsar/pull/1780 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] sijie closed pull request #1776: Fix NPE in Pulsar Functions CLI

2018-05-15 Thread GitBox
sijie closed pull request #1776: Fix NPE in Pulsar Functions CLI URL: https://github.com/apache/incubator-pulsar/pull/1776 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] haphut opened a new pull request #1782: Download dependencies over HTTPS instead of HTTP

2018-05-15 Thread GitBox
haphut opened a new pull request #1782: Download dependencies over HTTPS instead of HTTP URL: https://github.com/apache/incubator-pulsar/pull/1782 ### Motivation Currently the dependencies are downloaded over HTTP without committed checksums making the build process vulnerable to [

[GitHub] merlimat closed pull request #1779: Provide a vagrant file to launch a linux vm for running integration tests

2018-05-15 Thread GitBox
merlimat closed pull request #1779: Provide a vagrant file to launch a linux vm for running integration tests URL: https://github.com/apache/incubator-pulsar/pull/1779 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the s

[GitHub] bruth commented on issue #1764: WIP - Pulsar Go client library

2018-05-15 Thread GitBox
bruth commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-389285771 @merlimat Interesting, thanks for the explanation. > we just rely on best-effort acks So in other words, the command is sent to the se

[GitHub] merlimat closed pull request #1782: Download dependencies over HTTPS instead of HTTP

2018-05-15 Thread GitBox
merlimat closed pull request #1782: Download dependencies over HTTPS instead of HTTP URL: https://github.com/apache/incubator-pulsar/pull/1782 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] lucperkins commented on issue #1778: Vendored imports

2018-05-15 Thread GitBox
lucperkins commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389330350 Hmmm. I'm not sure if Go vendoring really works with "the Apache way" given the need for license headers. I'll do some digging and see how other projects m

[GitHub] merlimat commented on issue #1764: WIP - Pulsar Go client library

2018-05-15 Thread GitBox
merlimat commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-389330502 @bruth We have already seen it's not useful to have sync acks (given that anyway there's no ack on the ack). Since we're already moving that API

[GitHub] bruth commented on issue #1764: WIP - Pulsar Go client library

2018-05-15 Thread GitBox
bruth commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-389338759 @merlimat Sounds good. I will do another pass tomorrow morning, but the code looks good to me. Maybe you can try to convince a few others in the ch

[GitHub] sijie commented on issue #1778: Vendored imports

2018-05-15 Thread GitBox
sijie commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389342683 @lucperkins can't you just exclude vendor directory from license header checking? This is an au

[GitHub] merlimat opened a new pull request #1783: Fix build with boost >= 1.66

2018-05-15 Thread GitBox
merlimat opened a new pull request #1783: Fix build with boost >= 1.66 URL: https://github.com/apache/incubator-pulsar/pull/1783 ### Motivation The SSL context object constructor taking an `io_service` was already deprecated in boost 1.54 and it has been removed in boost 1.66.

[GitHub] merlimat commented on issue #1778: Vendored imports

2018-05-15 Thread GitBox
merlimat commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389343716 An alternative is to do `go get -d ./...` to fetch all dependencies This is an automated mess

[GitHub] zhaijack opened a new pull request #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader

2018-05-15 Thread GitBox
zhaijack opened a new pull request #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1784 impl deleteOffloaded() for S3ManagedLedgerOffloader Master issue #1511

[GitHub] merlimat commented on issue #1783: Fix build with boost >= 1.66

2018-05-15 Thread GitBox
merlimat commented on issue #1783: Fix build with boost >= 1.66 URL: https://github.com/apache/incubator-pulsar/pull/1783#issuecomment-389355000 retest this please This is an automated message from the Apache Git Service. To r

[GitHub] hrsakai commented on issue #1783: Fix build with boost >= 1.66

2018-05-15 Thread GitBox
hrsakai commented on issue #1783: Fix build with boost >= 1.66 URL: https://github.com/apache/incubator-pulsar/pull/1783#issuecomment-389369105 retest this please This is an automated message from the Apache Git Service. To re

[GitHub] hrsakai opened a new pull request #1785: Fix sidebar link

2018-05-15 Thread GitBox
hrsakai opened a new pull request #1785: Fix sidebar link URL: https://github.com/apache/incubator-pulsar/pull/1785 Fix #1772 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] haphut opened a new pull request #1786: Remove duplicated dependency

2018-05-15 Thread GitBox
haphut opened a new pull request #1786: Remove duplicated dependency URL: https://github.com/apache/incubator-pulsar/pull/1786 ### Motivation When running `docker/build.sh`, Maven lets out the following warning: ``` [WARNING] Some problems were encountered while building the eff

[GitHub] merlimat closed pull request #1781: fixing behavior when configs are empty

2018-05-15 Thread GitBox
merlimat closed pull request #1781: fixing behavior when configs are empty URL: https://github.com/apache/incubator-pulsar/pull/1781 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

[GitHub] merlimat opened a new pull request #1787: Fixes in CMakeFiles to automate build on macos

2018-05-15 Thread GitBox
merlimat opened a new pull request #1787: Fixes in CMakeFiles to automate build on macos URL: https://github.com/apache/incubator-pulsar/pull/1787 ### Motivation Couple of fixes to improve cmake libraries discovery on MacOS. --

[GitHub] merlimat closed pull request #1786: Remove duplicated dependency

2018-05-15 Thread GitBox
merlimat closed pull request #1786: Remove duplicated dependency URL: https://github.com/apache/incubator-pulsar/pull/1786 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] jerrypeng opened a new pull request #1788: adding windowing function CLI option descriptions

2018-05-16 Thread GitBox
jerrypeng opened a new pull request #1788: adding windowing function CLI option descriptions URL: https://github.com/apache/incubator-pulsar/pull/1788 This is an automated message from the Apache Git Service. To respond to t

[GitHub] jerrypeng commented on issue #1788: adding windowing function CLI option descriptions

2018-05-16 Thread GitBox
jerrypeng commented on issue #1788: adding windowing function CLI option descriptions URL: https://github.com/apache/incubator-pulsar/pull/1788#issuecomment-389419490 @srkukarni @sijie please review This is an automated messa

[GitHub] ivankelly opened a new pull request #1789: Ability to disable test retries from commandline

2018-05-16 Thread GitBox
ivankelly opened a new pull request #1789: Ability to disable test retries from commandline URL: https://github.com/apache/incubator-pulsar/pull/1789 Sometimes it's useful to be able to disable retries when testing sometime, for example, if you want to find flakes, or you have a test

[GitHub] ivankelly opened a new pull request #1790: ReadHandle implementation backed by S3

2018-05-16 Thread GitBox
ivankelly opened a new pull request #1790: ReadHandle implementation backed by S3 URL: https://github.com/apache/incubator-pulsar/pull/1790 Implementation of bookkeeper ReadHandle, which reads from an S3 object. Master Issue: #1511

[GitHub] ivankelly commented on issue #1790: ReadHandle implementation backed by S3

2018-05-16 Thread GitBox
ivankelly commented on issue #1790: ReadHandle implementation backed by S3 URL: https://github.com/apache/incubator-pulsar/pull/1790#issuecomment-389486668 @zhaijack @sijie @merlimat This is an automated message from the Apac

[GitHub] ivankelly commented on a change in pull request #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader

2018-05-16 Thread GitBox
ivankelly commented on a change in pull request #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1784#discussion_r188593231 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedL

[GitHub] merlimat closed pull request #1789: Ability to disable test retries from commandline

2018-05-16 Thread GitBox
merlimat closed pull request #1789: Ability to disable test retries from commandline URL: https://github.com/apache/incubator-pulsar/pull/1789 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] merlimat commented on issue #1783: Fix build with boost >= 1.66

2018-05-16 Thread GitBox
merlimat commented on issue #1783: Fix build with boost >= 1.66 URL: https://github.com/apache/incubator-pulsar/pull/1783#issuecomment-389574675 retest this please This is an automated message from the Apache Git Service. To r

[GitHub] merlimat commented on issue #1783: Fix build with boost >= 1.66

2018-05-16 Thread GitBox
merlimat commented on issue #1783: Fix build with boost >= 1.66 URL: https://github.com/apache/incubator-pulsar/pull/1783#issuecomment-389574675 retest this please This is an automated message from the Apache Git Service. To r

[GitHub] merlimat commented on issue #1785: Fix sidebar link

2018-05-16 Thread GitBox
merlimat commented on issue #1785: Fix sidebar link URL: https://github.com/apache/incubator-pulsar/pull/1785#issuecomment-389582838 retest this please This is an automated message from the Apache Git Service. To respond to th

[GitHub] lucperkins commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
lucperkins commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389598169 @merlimat True, but in the Go community that's considered sub-standard practice because there are no versions, which means that someone could make a breaki

[GitHub] merlimat commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
merlimat commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389599125 Oh, true. Isn't there a way to just pin the version of the dependencies? This is an automated

[GitHub] sijie closed pull request #1790: ReadHandle implementation backed by S3

2018-05-16 Thread GitBox
sijie closed pull request #1790: ReadHandle implementation backed by S3 URL: https://github.com/apache/incubator-pulsar/pull/1790 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreig

[GitHub] sijie commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
sijie commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389601498 I think you can pin a revision or tag (but I can be wrong) This is an automated message from the

[GitHub] lucperkins opened a new pull request #1791: [WIP] Pulsar Functions windowing documentation

2018-05-16 Thread GitBox
lucperkins opened a new pull request #1791: [WIP] Pulsar Functions windowing documentation URL: https://github.com/apache/incubator-pulsar/pull/1791 This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat closed issue #1772: Getting started/Pulsar 2.0 : URL broken

2018-05-16 Thread GitBox
merlimat closed issue #1772: Getting started/Pulsar 2.0 : URL broken URL: https://github.com/apache/incubator-pulsar/issues/1772 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] merlimat closed pull request #1783: Fix build with boost >= 1.66

2018-05-16 Thread GitBox
merlimat closed pull request #1783: Fix build with boost >= 1.66 URL: https://github.com/apache/incubator-pulsar/pull/1783 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] merlimat closed pull request #1785: Fix sidebar link

2018-05-16 Thread GitBox
merlimat closed pull request #1785: Fix sidebar link URL: https://github.com/apache/incubator-pulsar/pull/1785 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fro

[GitHub] jerrypeng commented on issue #1788: adding windowing function CLI option descriptions

2018-05-16 Thread GitBox
jerrypeng commented on issue #1788: adding windowing function CLI option descriptions URL: https://github.com/apache/incubator-pulsar/pull/1788#issuecomment-389668373 retest this please This is an automated message from the A

[GitHub] jerrypeng opened a new pull request #1792: Modifying sink interface to be generic

2018-05-16 Thread GitBox
jerrypeng opened a new pull request #1792: Modifying sink interface to be generic URL: https://github.com/apache/incubator-pulsar/pull/1792 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] jerrypeng commented on issue #1792: Modifying sink interface to be generic

2018-05-16 Thread GitBox
jerrypeng commented on issue #1792: Modifying sink interface to be generic URL: https://github.com/apache/incubator-pulsar/pull/1792#issuecomment-389671734 @srkukarni @sijie @rdhabalia please review This is an automated messag

[GitHub] merlimat closed pull request #1787: Fixes in CMakeFiles to automate build on macos

2018-05-16 Thread GitBox
merlimat closed pull request #1787: Fixes in CMakeFiles to automate build on macos URL: https://github.com/apache/incubator-pulsar/pull/1787 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] merlimat commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
merlimat commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389687657 @lucperkins @sijie I have removed the only one dependency in the latest updates to #1764. We shouldn't need this for now. --

[GitHub] merlimat commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
merlimat commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389687657 @lucperkins @sijie I have removed the only dependency in the latest updates to #1764. We shouldn't need this for now. --

[GitHub] lucperkins closed pull request #1778: Vendored imports

2018-05-16 Thread GitBox
lucperkins closed pull request #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (f

[GitHub] lucperkins commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
lucperkins commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389688423 @merlimat 👍 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] merlimat opened a new pull request #1793: Added docker files and script to build static client library and Python bindings on Linux

2018-05-16 Thread GitBox
merlimat opened a new pull request #1793: Added docker files and script to build static client library and Python bindings on Linux URL: https://github.com/apache/incubator-pulsar/pull/1793 ### Motivation To generate a statically linked `libpulsar.so` for Linux, we need to have all

[GitHub] lucperkins commented on issue #1788: adding windowing function CLI option descriptions

2018-05-16 Thread GitBox
lucperkins commented on issue #1788: adding windowing function CLI option descriptions URL: https://github.com/apache/incubator-pulsar/pull/1788#issuecomment-389699047 @jerrypeng FYI I'm going to add a description for `--autoAck` in a different PR.

[GitHub] lucperkins commented on issue #1763: Document Python dependencies

2018-05-16 Thread GitBox
lucperkins commented on issue #1763: Document Python dependencies URL: https://github.com/apache/incubator-pulsar/pull/1763#issuecomment-389699189 retest this please This is an automated message from the Apache Git Service. To

[GitHub] lucperkins commented on issue #1466: Topic compaction documentation (WIP)

2018-05-16 Thread GitBox
lucperkins commented on issue #1466: Topic compaction documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1466#issuecomment-389700478 @ivankelly This is ready for review. This is an automated message from

[GitHub] merlimat opened a new pull request #1794: Create shared library that only exports API symbols

2018-05-16 Thread GitBox
merlimat opened a new pull request #1794: Create shared library that only exports API symbols URL: https://github.com/apache/incubator-pulsar/pull/1794 ### Motivation Pass the `-fvisibility=hidden -Wl,--exclude-libs,ALL` flags to the linker when creating `libpulsar.so`. That will en

[GitHub] merlimat closed pull request #1794: Create shared library that only exports API symbols

2018-05-16 Thread GitBox
merlimat closed pull request #1794: Create shared library that only exports API symbols URL: https://github.com/apache/incubator-pulsar/pull/1794 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] merlimat commented on issue #1793: Added docker files and script to build static client library and Python bindings on Linux

2018-05-16 Thread GitBox
merlimat commented on issue #1793: Added docker files and script to build static client library and Python bindings on Linux URL: https://github.com/apache/incubator-pulsar/pull/1793#issuecomment-389718864 retest this please

[GitHub] zhaijack commented on issue #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader

2018-05-16 Thread GitBox
zhaijack commented on issue #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1784#issuecomment-389731608 @ivankelly Thanks, updated. This is an automated

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-16 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-388097238 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-16 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-389739626 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] massakam opened a new pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-16 Thread GitBox
massakam opened a new pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795 ### Motivation I noticed that messages with the same key might be routed to different partitions when MurmurHash3 was selected as a hashing scheme in the

[GitHub] nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188861733 ## File path: pulsar-client-cpp/tests/HashTest.cc ## @@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash) {

[GitHub] nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188861733 ## File path: pulsar-client-cpp/tests/HashTest.cc ## @@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash) {

[GitHub] massakam commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
massakam commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188864565 ## File path: pulsar-client-cpp/tests/HashTest.cc ## @@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash) {

[GitHub] zhaijack commented on issue #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader

2018-05-17 Thread GitBox
zhaijack commented on issue #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1784#issuecomment-389781122 @sijie Would you please help review this? This is

[GitHub] sijie closed pull request #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader

2018-05-17 Thread GitBox
sijie closed pull request #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1784 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] ivankelly opened a new issue #1796: Proxy cannot be configured to work as proxy for both admin and client requests

2018-05-17 Thread GitBox
ivankelly opened a new issue #1796: Proxy cannot be configured to work as proxy for both admin and client requests URL: https://github.com/apache/incubator-pulsar/issues/1796 Expected behavior When I start a proxy, I should be able to point both a client and an admin client at

[GitHub] massakam commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
massakam commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188892224 ## File path: pulsar-client-cpp/tests/HashTest.cc ## @@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash) {

[GitHub] ivankelly opened a new issue #1797: Proxy doesn't strip the request URL for admin requests correctly

2018-05-17 Thread GitBox
ivankelly opened a new issue #1797: Proxy doesn't strip the request URL for admin requests correctly URL: https://github.com/apache/incubator-pulsar/issues/1797 Expected behavior Using proxy to do admin tasks should work. Actual behavior On client ``` or

[GitHub] nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188907542 ## File path: pulsar-client-cpp/tests/HashTest.cc ## @@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash) {

[GitHub] sijie commented on issue #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
sijie commented on issue #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#issuecomment-389914752 we might consider porting this change back for 2.0.1? This is an automated message

[GitHub] sijie closed pull request #1788: adding windowing function CLI option descriptions

2018-05-17 Thread GitBox
sijie closed pull request #1788: adding windowing function CLI option descriptions URL: https://github.com/apache/incubator-pulsar/pull/1788 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] merlimat closed pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
merlimat closed pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] ivankelly opened a new pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength

2018-05-17 Thread GitBox
ivankelly opened a new pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength URL: https://github.com/apache/incubator-pulsar/pull/1799 LedgerEntry#getLength() returns the length of the ledger up to and including the length of the entry, not the length o

[GitHub] ivankelly opened a new pull request #1798: S3ManagedLedgerOffloader should require region or endpoint

2018-05-17 Thread GitBox
ivankelly opened a new pull request #1798: S3ManagedLedgerOffloader should require region or endpoint URL: https://github.com/apache/incubator-pulsar/pull/1798 The S3 client requires one of the two, but never both. Previously we were throwing an error if region was not specified, even th

[GitHub] ivankelly opened a new pull request #1800: Docker testing init script has wrong service url

2018-05-17 Thread GitBox
ivankelly opened a new pull request #1800: Docker testing init script has wrong service url URL: https://github.com/apache/incubator-pulsar/pull/1800 The script was initializing the broker server url with a http url, using the binary protocol port. This patch fixes that and also logs

[GitHub] ivankelly opened a new pull request #1801: Log4j2.yaml configures loggers incorrectly

2018-05-17 Thread GitBox
ivankelly opened a new pull request #1801: Log4j2.yaml configures loggers incorrectly URL: https://github.com/apache/incubator-pulsar/pull/1801 log4j2.yaml has a list of loggers. However, this is not a yaml list, but a yaml map, so the configuration only picks up the last one. Thi

[GitHub] ivankelly opened a new pull request #1802: Utilities to update configuration for integration tests

2018-05-17 Thread GitBox
ivankelly opened a new pull request #1802: Utilities to update configuration for integration tests URL: https://github.com/apache/incubator-pulsar/pull/1802 This patch provides two utility methods. One of them allows the update of a key value properties type configuration, such as broker

[GitHub] merlimat closed pull request #1792: Modifying sink interface to be generic

2018-05-17 Thread GitBox
merlimat closed pull request #1792: Modifying sink interface to be generic URL: https://github.com/apache/incubator-pulsar/pull/1792 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

<    1   2   3   4   5   6   7   8   9   10   >