[GitHub] [incubator-tvm] wrongtest commented on a change in pull request #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime

2020-01-15 Thread GitBox
wrongtest commented on a change in pull request #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime URL: https://github.com/apache/incubator-tvm/pull/4459#discussion_r367271436 ## File path: src/contrib/tf_op/tvm_dso_op_kernels.cc ## @@ -0,0 +1,285

[GitHub] [incubator-tvm] wrongtest commented on a change in pull request #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime

2020-01-15 Thread GitBox
wrongtest commented on a change in pull request #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime URL: https://github.com/apache/incubator-tvm/pull/4459#discussion_r367269079 ## File path: python/tvm/contrib/tf_op/module.py ## @@ -0,0 +1,104 @@ +#

[GitHub] [incubator-tvm] hlu1 commented on issue #4723: [Relay] Port relay.backend.build to c++

2020-01-15 Thread GitBox
hlu1 commented on issue #4723: [Relay] Port relay.backend.build to c++ URL: https://github.com/apache/incubator-tvm/pull/4723#issuecomment-575019899 Sorry I missed a few things at the beginning and just added them. Do you mean translating this part line by line,

[GitHub] [incubator-tvm] yzhliu commented on issue #4684: [Arith] add SizeVar representing non-neg valued variable in a tensor shape

2020-01-15 Thread GitBox
yzhliu commented on issue #4684: [Arith] add SizeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-574999427 Thanks @tqchen I'll take a look into the IndexVar and send another pr

[incubator-tvm] branch master updated (d756d3c -> 3a672e3)

2020-01-15 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from d756d3c [REFACTOR][IR] Introduce include/tvm/target (#4721) add 3a672e3 [Arith] add SizeVar

[GitHub] [incubator-tvm] yzhliu merged pull request #4684: [Arith] add SizeVar representing non-neg valued variable in a tensor shape

2020-01-15 Thread GitBox
yzhliu merged pull request #4684: [Arith] add SizeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684 This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] wweic opened a new pull request #4724: [Relay][Op] Add type check to dense

2020-01-15 Thread GitBox
wweic opened a new pull request #4724: [Relay][Op] Add type check to dense URL: https://github.com/apache/incubator-tvm/pull/4724 Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is

[GitHub] [incubator-tvm] tqchen merged pull request #4721: [REFACTOR] Introduce include/tvm/target

2020-01-15 Thread GitBox
tqchen merged pull request #4721: [REFACTOR] Introduce include/tvm/target URL: https://github.com/apache/incubator-tvm/pull/4721 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-tvm] branch master updated (51b5153 -> d756d3c)

2020-01-15 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 51b5153 [VERSION] Update mainline version to 0.7.dev0 (#4720) add d756d3c [REFACTOR][IR] Introduce

[GitHub] [incubator-tvm] tqchen merged pull request #4720: [VERSION] Update mainline version to 0.7.dev0

2020-01-15 Thread GitBox
tqchen merged pull request #4720: [VERSION] Update mainline version to 0.7.dev0 URL: https://github.com/apache/incubator-tvm/pull/4720 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-tvm] branch master updated (0ec27f4 -> 51b5153)

2020-01-15 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 0ec27f4 [REFACTOR][FFI] Make more clear naming for C API Type codes. (#4715) add 51b5153 [VERSION]

[GitHub] [incubator-tvm] vexilligera edited a comment on issue #4676: Building TVM from source for Windows with LLVM support

2020-01-15 Thread GitBox
vexilligera edited a comment on issue #4676: Building TVM from source for Windows with LLVM support URL: https://github.com/apache/incubator-tvm/issues/4676#issuecomment-574577227 Hi, I am building MXNet with TVM on Windows to support TVMOps. Building LLVM from source with Visual Studio

[GitHub] [incubator-tvm] vexilligera edited a comment on issue #4676: Building TVM from source for Windows with LLVM support

2020-01-15 Thread GitBox
vexilligera edited a comment on issue #4676: Building TVM from source for Windows with LLVM support URL: https://github.com/apache/incubator-tvm/issues/4676#issuecomment-574577227 Hi, I am building MXNet with TVM on Windows to support TVMOps. Building LLVM from source with Visual Studio

[incubator-tvm] branch master updated (49d3144 -> 0ec27f4)

2020-01-15 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 49d3144 [REFACTOR] Move support related code to include/tvm/support (#4716) add 0ec27f4

[GitHub] [incubator-tvm] tqchen merged pull request #4715: [REFACTOR][FFI] Make more clear naming for C API Type codes.

2020-01-15 Thread GitBox
tqchen merged pull request #4715: [REFACTOR][FFI] Make more clear naming for C API Type codes. URL: https://github.com/apache/incubator-tvm/pull/4715 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-tvm] MarisaKirisame edited a comment on issue #3914: [Relay] Add more check to type relation.

2020-01-15 Thread GitBox
MarisaKirisame edited a comment on issue #3914: [Relay] Add more check to type relation. URL: https://github.com/apache/incubator-tvm/pull/3914#issuecomment-574962702 @wweic sorry for the delay, I am busy submitting to ICML, please go ahead.

[GitHub] [incubator-tvm] MarisaKirisame commented on issue #3914: [Relay] Add more check to type relation.

2020-01-15 Thread GitBox
MarisaKirisame commented on issue #3914: [Relay] Add more check to type relation. URL: https://github.com/apache/incubator-tvm/pull/3914#issuecomment-574962702 @wweic sorry for the delay, I am busy submitting to ICML. This

[GitHub] [incubator-tvm] hlu1 opened a new pull request #4723: [Relay] Port relay.backend.build to c++

2020-01-15 Thread GitBox
hlu1 opened a new pull request #4723: [Relay] Port relay.backend.build to c++ URL: https://github.com/apache/incubator-tvm/pull/4723 `relay.backend.build` is implemented in python and is used in C++ in

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4564: [Doc] Introduction to module serialization

2020-01-15 Thread GitBox
FrozenGene commented on a change in pull request #4564: [Doc] Introduction to module serialization URL: https://github.com/apache/incubator-tvm/pull/4564#discussion_r367205537 ## File path: docs/dev/introduction_to_module_serialization.rst ## @@ -0,0 +1,227 @@ +..

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4564: [Doc] Introduction to module serialization

2020-01-15 Thread GitBox
FrozenGene commented on a change in pull request #4564: [Doc] Introduction to module serialization URL: https://github.com/apache/incubator-tvm/pull/4564#discussion_r367205537 ## File path: docs/dev/introduction_to_module_serialization.rst ## @@ -0,0 +1,227 @@ +..

[GitHub] [incubator-tvm] wweic commented on issue #4693: [runtime][refactor] Unify vm and interpreter objects

2020-01-15 Thread GitBox
wweic commented on issue #4693: [runtime][refactor] Unify vm and interpreter objects URL: https://github.com/apache/incubator-tvm/pull/4693#issuecomment-574952009 I'll take a look soon. This is an automated message from the

[GitHub] [incubator-tvm] wweic commented on issue #3914: [Relay] Add more check to type relation.

2020-01-15 Thread GitBox
wweic commented on issue #3914: [Relay] Add more check to type relation. URL: https://github.com/apache/incubator-tvm/pull/3914#issuecomment-574951703 @tqchen Yes, I'll send a follow up PR. This is an automated message from

[GitHub] [incubator-tvm] shoubhik commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-15 Thread GitBox
shoubhik commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367201345 ## File path: python/tvm/relay/frontend/mxnet.py ## @@ -14,12 +14,14 @@ # KIND, either express or implied. See

[GitHub] [incubator-tvm] apivovarov edited a comment on issue #2561: [Relay/TOPI][Op] Add batch_matmul in relay and TOPI

2020-01-15 Thread GitBox
apivovarov edited a comment on issue #2561: [Relay/TOPI][Op] Add batch_matmul in relay and TOPI URL: https://github.com/apache/incubator-tvm/pull/2561#issuecomment-574948299 In some cases relay.build hangs. The issue caused by `topi/python/topi/x86/dense.py` [Line

[GitHub] [incubator-tvm] apivovarov edited a comment on issue #2561: [Relay/TOPI][Op] Add batch_matmul in relay and TOPI

2020-01-15 Thread GitBox
apivovarov edited a comment on issue #2561: [Relay/TOPI][Op] Add batch_matmul in relay and TOPI URL: https://github.com/apache/incubator-tvm/pull/2561#issuecomment-574948299 In some cases relay.build hangs. The issue caused by `topi/python/topi/x86/dense.py` Line 194`. More info

[GitHub] [incubator-tvm] apivovarov commented on issue #2561: [Relay/TOPI][Op] Add batch_matmul in relay and TOPI

2020-01-15 Thread GitBox
apivovarov commented on issue #2561: [Relay/TOPI][Op] Add batch_matmul in relay and TOPI URL: https://github.com/apache/incubator-tvm/pull/2561#issuecomment-574948299 I some cases relay.build hangs. The issue caused by `topi/python/topi/x86/dense.py` Line 194`. More info

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-15 Thread GitBox
liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367195032 ## File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py ## @@ -21,52 +21,95 @@ import numpy as np from

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-15 Thread GitBox
liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367197041 ## File path: python/tvm/relay/frontend/mxnet.py ## @@ -180,6 +190,17 @@ def _mx_conv2d(inputs, attrs):

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-15 Thread GitBox
liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367198080 ## File path: python/tvm/relay/frontend/mxnet.py ## @@ -1075,6 +1098,377 @@ def _mx_cond(inputs, attrs,

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-15 Thread GitBox
liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367192729 ## File path: python/tvm/relay/frontend/mxnet.py ## @@ -14,12 +14,14 @@ # KIND, either express or implied. See

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect

2020-01-15 Thread GitBox
liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367196432 ## File path: src/relay/qnn/op/convolution.cc ## @@ -57,7 +57,7 @@ bool QnnConv2DRel(const Array& types, int

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4698: [Runtime] EdgeTPU runtime for Coral Boards

2020-01-15 Thread GitBox
tmoreau89 commented on issue #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698#issuecomment-574944892 @ZihengJiang I should have addressed all of your comments by now; let me know if you're happy with the changes

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards

2020-01-15 Thread GitBox
tmoreau89 commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698#discussion_r367197404 ## File path: python/tvm/contrib/tflite_runtime.py ## @@ -18,7 +18,7 @@ from .._ffi.function

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards

2020-01-15 Thread GitBox
tmoreau89 commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698#discussion_r367197362 ## File path: src/runtime/contrib/tflite/tflite_runtime.cc ## @@ -92,20 +91,23 @@ DataType

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards

2020-01-15 Thread GitBox
tmoreau89 commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698#discussion_r367186135 ## File path: python/tvm/contrib/tflite_runtime.py ## @@ -27,16 +27,25 @@ def

[GitHub] [incubator-tvm] hcho3 edited a comment on issue #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant

2020-01-15 Thread GitBox
hcho3 edited a comment on issue #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant URL: https://github.com/apache/incubator-tvm/pull/4707#issuecomment-574931580 Looks like this change breaks the following snippet:

[GitHub] [incubator-tvm] hcho3 commented on issue #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant

2020-01-15 Thread GitBox
hcho3 commented on issue #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant URL: https://github.com/apache/incubator-tvm/pull/4707#issuecomment-574931580 Looks like this change breaks the following snippet:

[GitHub] [incubator-tvm] hcho3 closed pull request #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant

2020-01-15 Thread GitBox
hcho3 closed pull request #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant URL: https://github.com/apache/incubator-tvm/pull/4707 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen commented on issue #4693: [runtime][refactor] Unify vm and interpreter objects

2020-01-15 Thread GitBox
tqchen commented on issue #4693: [runtime][refactor] Unify vm and interpreter objects URL: https://github.com/apache/incubator-tvm/pull/4693#issuecomment-574930323 would be great if @wweic can also take a look This is an

[GitHub] [incubator-tvm] tqchen commented on issue #4722: [REFACTOR][ARITH] Unified IR, introduce arith subfolder.

2020-01-15 Thread GitBox
tqchen commented on issue #4722: [REFACTOR][ARITH] Unified IR, introduce arith subfolder. URL: https://github.com/apache/incubator-tvm/pull/4722#issuecomment-574928302 cc @yzhliu @ZihengJiang @wweic @zhiics This is an

[GitHub] [incubator-tvm] tqchen opened a new pull request #4722: [REFACTOR][ARITH] Unified IR, introduce arith subfolder.

2020-01-15 Thread GitBox
tqchen opened a new pull request #4722: [REFACTOR][ARITH] Unified IR, introduce arith subfolder. URL: https://github.com/apache/incubator-tvm/pull/4722 Spread the arithmetic.h into several components and move into arith subfolder. The arith namespace will be used for arithmetic

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4698: [Runtime] EdgeTPU runtime for Coral Boards

2020-01-15 Thread GitBox
tmoreau89 commented on issue #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698#issuecomment-574923602 @ZihengJiang thanks for the feedback! The TFLite Interpreter still has `AllocateTensors`; however I wan't sure if we'd ever need to

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.

2020-01-15 Thread GitBox
tmoreau89 commented on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#issuecomment-574923019 Thanks for this useful feature @huajsj . I think that in the long terms this pass will

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.

2020-01-15 Thread GitBox
tmoreau89 commented on a change in pull request #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#discussion_r367177369 ## File path: vta/python/vta/top/graphpack.py ## @@

[GitHub] [incubator-tvm] tqchen closed pull request #4650: [Bugfix] Support for placeholders defining tensor shapes

2020-01-15 Thread GitBox
tqchen closed pull request #4650: [Bugfix] Support for placeholders defining tensor shapes URL: https://github.com/apache/incubator-tvm/pull/4650 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen commented on issue #4650: [Bugfix] Support for placeholders defining tensor shapes

2020-01-15 Thread GitBox
tqchen commented on issue #4650: [Bugfix] Support for placeholders defining tensor shapes URL: https://github.com/apache/incubator-tvm/pull/4650#issuecomment-574918973 close for now as this is a feature that we do not yet look into bring Thanks @dpankratz !

[GitHub] [incubator-tvm] tqchen opened a new pull request #4721: [REFACTOR][IR] Introduce include/tvm/target

2020-01-15 Thread GitBox
tqchen opened a new pull request #4721: [REFACTOR][IR] Introduce include/tvm/target URL: https://github.com/apache/incubator-tvm/pull/4721 As part of Unified IR infra. Introduce target folder to store all the compilation target related information.

[GitHub] [incubator-tvm] tqchen commented on issue #4721: [REFACTOR][IR] Introduce include/tvm/target

2020-01-15 Thread GitBox
tqchen commented on issue #4721: [REFACTOR][IR] Introduce include/tvm/target URL: https://github.com/apache/incubator-tvm/pull/4721#issuecomment-574917332 cc @zhiics @yzhliu @ZihengJiang This is an automated message from the

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4564: [Doc] Introduction to module serialization

2020-01-15 Thread GitBox
zhiics commented on a change in pull request #4564: [Doc] Introduction to module serialization URL: https://github.com/apache/incubator-tvm/pull/4564#discussion_r367162864 ## File path: docs/dev/introduction_to_module_serialization.rst ## @@ -0,0 +1,227 @@ +.. Licensed

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4564: [Doc] Introduction to module serialization

2020-01-15 Thread GitBox
zhiics commented on a change in pull request #4564: [Doc] Introduction to module serialization URL: https://github.com/apache/incubator-tvm/pull/4564#discussion_r367165589 ## File path: docs/dev/introduction_to_module_serialization.rst ## @@ -0,0 +1,227 @@ +.. Licensed

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4564: [Doc] Introduction to module serialization

2020-01-15 Thread GitBox
zhiics commented on a change in pull request #4564: [Doc] Introduction to module serialization URL: https://github.com/apache/incubator-tvm/pull/4564#discussion_r367164474 ## File path: docs/dev/introduction_to_module_serialization.rst ## @@ -0,0 +1,227 @@ +.. Licensed

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4564: [Doc] Introduction to module serialization

2020-01-15 Thread GitBox
zhiics commented on a change in pull request #4564: [Doc] Introduction to module serialization URL: https://github.com/apache/incubator-tvm/pull/4564#discussion_r367163440 ## File path: docs/dev/introduction_to_module_serialization.rst ## @@ -0,0 +1,227 @@ +.. Licensed

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4564: [Doc] Introduction to module serialization

2020-01-15 Thread GitBox
zhiics commented on a change in pull request #4564: [Doc] Introduction to module serialization URL: https://github.com/apache/incubator-tvm/pull/4564#discussion_r367163646 ## File path: docs/dev/introduction_to_module_serialization.rst ## @@ -0,0 +1,227 @@ +.. Licensed

[GitHub] [incubator-tvm] tqchen commented on issue #4500: [VTA][Python] Instruction Level Metal Test Infrastructure

2020-01-15 Thread GitBox
tqchen commented on issue #4500: [VTA][Python] Instruction Level Metal Test Infrastructure URL: https://github.com/apache/incubator-tvm/pull/4500#issuecomment-574902734 @tmoreau89 @BenjaminTu would be great if we can followup on this thread

[GitHub] [incubator-tvm] tqchen closed pull request #3940: WIP add transfer learning codes

2020-01-15 Thread GitBox
tqchen closed pull request #3940: WIP add transfer learning codes URL: https://github.com/apache/incubator-tvm/pull/3940 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] tqchen closed pull request #4067: [Relay] Add print_ir parameter to build_config to print the IR between passes

2020-01-15 Thread GitBox
tqchen closed pull request #4067: [Relay] Add print_ir parameter to build_config to print the IR between passes URL: https://github.com/apache/incubator-tvm/pull/4067 This is an automated message from the Apache Git

[GitHub] [incubator-tvm] tqchen commented on issue #4277: [ARM][Topi] Improving Int8 Perf in Spatial Conv2D schedule.

2020-01-15 Thread GitBox
tqchen commented on issue #4277: [ARM][Topi] Improving Int8 Perf in Spatial Conv2D schedule. URL: https://github.com/apache/incubator-tvm/pull/4277#issuecomment-574902187 @FrozenGene @anijain2305 would be great if we can followup on this thread

[GitHub] [incubator-tvm] tqchen commented on issue #3858: [AutoTVM][TOPI] AutoTVM support for NHWC con2d

2020-01-15 Thread GitBox
tqchen commented on issue #3858: [AutoTVM][TOPI] AutoTVM support for NHWC con2d URL: https://github.com/apache/incubator-tvm/pull/3858#issuecomment-574901363 superseded by #3859 This is an automated message from the Apache

[GitHub] [incubator-tvm] tqchen closed pull request #3914: [Relay] Add more check to type relation.

2020-01-15 Thread GitBox
tqchen closed pull request #3914: [Relay] Add more check to type relation. URL: https://github.com/apache/incubator-tvm/pull/3914 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] tqchen commented on issue #3914: [Relay] Add more check to type relation.

2020-01-15 Thread GitBox
tqchen commented on issue #3914: [Relay] Add more check to type relation. URL: https://github.com/apache/incubator-tvm/pull/3914#issuecomment-574901114 close for now due to inactive status, @wweic can you simply take over and send another patch?

[GitHub] [incubator-tvm] tqchen closed pull request #3858: [AutoTVM][TOPI] AutoTVM support for NHWC con2d

2020-01-15 Thread GitBox
tqchen closed pull request #3858: [AutoTVM][TOPI] AutoTVM support for NHWC con2d URL: https://github.com/apache/incubator-tvm/pull/3858 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4693: [runtime][refactor] Unify vm and interpreter objects

2020-01-15 Thread GitBox
tqchen commented on a change in pull request #4693: [runtime][refactor] Unify vm and interpreter objects URL: https://github.com/apache/incubator-tvm/pull/4693#discussion_r367156258 ## File path: include/tvm/runtime/common_object.h ## @@ -0,0 +1,71 @@ +/* + * Licensed to

[GitHub] [incubator-tvm] tqchen commented on issue #4684: [Arith] add SizeVar representing non-neg valued variable in a tensor shape

2020-01-15 Thread GitBox
tqchen commented on issue #4684: [Arith] add SizeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-574899548 cc @yzhliu feel free to merge after fixing the nits. BTW, it also reminds me if we would like to bring

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4684: [Arith] add SizeVar representing non-neg valued variable in a tensor shape

2020-01-15 Thread GitBox
tqchen commented on a change in pull request #4684: [Arith] add SizeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r367154337 ## File path: python/tvm/api.py ## @@ -192,6 +192,25 @@ def

[GitHub] [incubator-tvm] yzhliu commented on issue #4684: [Arith] add SizeVar representing non-neg valued variable in a tensor shape

2020-01-15 Thread GitBox
yzhliu commented on issue #4684: [Arith] add SizeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-574898431 @tqchen I have address the comments and changed the name

[GitHub] [incubator-tvm] tqchen closed issue #2030: [RFC] Mechanism to plugin intrinsic information

2020-01-15 Thread GitBox
tqchen closed issue #2030: [RFC] Mechanism to plugin intrinsic information URL: https://github.com/apache/incubator-tvm/issues/2030 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] tqchen edited a comment on issue #2030: [RFC] Mechanism to plugin intrinsic information

2020-01-15 Thread GitBox
tqchen edited a comment on issue #2030: [RFC] Mechanism to plugin intrinsic information URL: https://github.com/apache/incubator-tvm/issues/2030#issuecomment-574897907 close this for now. Thanks @xqdan The new Unified IR RFC #4617 covers this aspect, by using relay's Op as a

[GitHub] [incubator-tvm] tqchen commented on issue #2030: [RFC] Mechanism to plugin intrinsic information

2020-01-15 Thread GitBox
tqchen commented on issue #2030: [RFC] Mechanism to plugin intrinsic information URL: https://github.com/apache/incubator-tvm/issues/2030#issuecomment-574897907 close this for now. The new Unified IR RFC #4617 covers this aspect, by using relay's Op as a single source to register

[GitHub] [incubator-tvm] tqchen commented on issue #4717: [AutoTVM] Failed to run autotvm example on GEMM

2020-01-15 Thread GitBox
tqchen commented on issue #4717: [AutoTVM] Failed to run autotvm example on GEMM URL: https://github.com/apache/incubator-tvm/issues/4717#issuecomment-574897183 Thanks for asking the question, please open a new trouble shooting thread on https://discuss.tvm.ai/

[GitHub] [incubator-tvm] tqchen closed issue #4717: [AutoTVM] Failed to run autotvm example on GEMM

2020-01-15 Thread GitBox
tqchen closed issue #4717: [AutoTVM] Failed to run autotvm example on GEMM URL: https://github.com/apache/incubator-tvm/issues/4717 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] tqchen opened a new pull request #4720: [VERSION] Update mainline version to 0.7.dev0

2020-01-15 Thread GitBox
tqchen opened a new pull request #4720: [VERSION] Update mainline version to 0.7.dev0 URL: https://github.com/apache/incubator-tvm/pull/4720 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen opened a new pull request #4719: [COMMUNITY] @FrozenGene -> committer

2020-01-15 Thread GitBox
tqchen opened a new pull request #4719: [COMMUNITY] @FrozenGene -> committer URL: https://github.com/apache/incubator-tvm/pull/4719 Please join us to welcome @FrozenGene as a new committer He as been an active advocator of TVM. He has helped reviewed many code related to backend

[incubator-tvm] branch master updated (b0b51f2 -> 49d3144)

2020-01-15 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from b0b51f2 [REFACTOR][IR] attrs.h -> ir (#4709) add 49d3144 [REFACTOR] Move support related code to

[GitHub] [incubator-tvm] comaniac opened a new pull request #4718: [Docs] Bring Your Own Codegen Guide -- Part 2

2020-01-15 Thread GitBox
comaniac opened a new pull request #4718: [Docs] Bring Your Own Codegen Guide -- Part 2 URL: https://github.com/apache/incubator-tvm/pull/4718 This continues #4602. Do not merge before #4602. This is an automated message

[GitHub] [incubator-tvm] Airtnp opened a new issue #4717: [AutoTVM] Failed to run autotvm example on GEMM

2020-01-15 Thread GitBox
Airtnp opened a new issue #4717: [AutoTVM] Failed to run autotvm example on GEMM URL: https://github.com/apache/incubator-tvm/issues/4717 I was trying to use code from https://zhuanlan.zhihu.com/p/75203171 (it's a Chinese post, but it's essential the same as [Writing tunable template and

[GitHub] [incubator-tvm] soiferj commented on issue #4548: Windows support for autotvm - Do not merge

2020-01-15 Thread GitBox
soiferj commented on issue #4548: Windows support for autotvm - Do not merge URL: https://github.com/apache/incubator-tvm/pull/4548#issuecomment-574865203 I've taken a look :) I'm not super familiar with a lot of the areas that you touched, but I think we can move this from a draft PR to

[GitHub] [incubator-tvm] jmorrill commented on issue #4548: Windows support for autotvm - Do not merge

2020-01-15 Thread GitBox
jmorrill commented on issue #4548: Windows support for autotvm - Do not merge URL: https://github.com/apache/incubator-tvm/pull/4548#issuecomment-574863098 > @jmorrill how would you feel about working toward merging this into public TVM? It's important functionality. I think that

[GitHub] [incubator-tvm] tqchen commented on issue #4716: [REFACTOR] Move support related code to include/tvm/support

2020-01-15 Thread GitBox
tqchen commented on issue #4716: [REFACTOR] Move support related code to include/tvm/support URL: https://github.com/apache/incubator-tvm/pull/4716#issuecomment-574839896 cc @yzhliu @ZihengJiang This is an automated message

[GitHub] [incubator-tvm] tqchen opened a new pull request #4716: [REFACTOR] Move support related code to include/tvm/support

2020-01-15 Thread GitBox
tqchen opened a new pull request #4716: [REFACTOR] Move support related code to include/tvm/support URL: https://github.com/apache/incubator-tvm/pull/4716 - tvm/logging.h -> tvm/support/logging.h - remove tvm/base.h, move with into tvm/support/with.h

[GitHub] [incubator-tvm] tqchen commented on issue #4715: [REFACTOR][FFI] Make more clear naming for C API Type codes.

2020-01-15 Thread GitBox
tqchen commented on issue #4715: [REFACTOR][FFI] Make more clear naming for C API Type codes. URL: https://github.com/apache/incubator-tvm/pull/4715#issuecomment-574830804 cc @yzhliu @icemelon9 @ZihengJiang This is an

[GitHub] [incubator-tvm] shoubhik commented on issue #4714: Mxnet parser for Qnn dialect

2020-01-15 Thread GitBox
shoubhik commented on issue #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#issuecomment-574790244 @anijain2305 , @jackwish can you take a look at this. This is an automated message

[GitHub] [incubator-tvm] shoubhik opened a new pull request #4714: Mxnet parser for Qnn dialect

2020-01-15 Thread GitBox
shoubhik opened a new pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714 In this parser, I am including the changes needed for QNN dialect for Mxnet. It has been tested with most of the open-source Mxnet models.

[incubator-tvm] branch master updated (83da72f -> b0b51f2)

2020-01-15 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 83da72f [Relay][Frontend][TFLite] Add constant input support for elemwise ops (#4666) add b0b51f2

[GitHub] [incubator-tvm] zhiics merged pull request #4709: [REFACTOR][IR] attrs.h -> ir

2020-01-15 Thread GitBox
zhiics merged pull request #4709: [REFACTOR][IR] attrs.h -> ir URL: https://github.com/apache/incubator-tvm/pull/4709 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] tqchen commented on issue #4444: [TEST][FLAKY] test_adaptive_pool FAILED

2020-01-15 Thread GitBox
tqchen commented on issue #: [TEST][FLAKY] test_adaptive_pool FAILED URL: https://github.com/apache/incubator-tvm/issues/#issuecomment-574750940 @kevinthesun do you have any updates? This is an automated message from

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4670: [Relay] Bias missing in final layer of Mobilenet?

2020-01-15 Thread GitBox
tqchen edited a comment on issue #4670: [Relay] Bias missing in final layer of Mobilenet? URL: https://github.com/apache/incubator-tvm/issues/4670#issuecomment-574749839 Yes, we should add it, a PR is more than welcomed This

[GitHub] [incubator-tvm] tqchen commented on issue #4666: [Relay][Frontend][TFLite] Add constant input support for elemwise ops

2020-01-15 Thread GitBox
tqchen commented on issue #4666: [Relay][Frontend][TFLite] Add constant input support for elemwise ops URL: https://github.com/apache/incubator-tvm/pull/4666#issuecomment-574749534 Thanks @wyc-ruiker @FrozenGene This is an

[GitHub] [incubator-tvm] tqchen commented on issue #4670: [Relay] Bias missing in final layer of Mobilenet?

2020-01-15 Thread GitBox
tqchen commented on issue #4670: [Relay] Bias missing in final layer of Mobilenet? URL: https://github.com/apache/incubator-tvm/issues/4670#issuecomment-574749839 Yes, we should add it, PRs is more than welcomed This is an

[incubator-tvm] branch master updated (02c6767 -> 83da72f)

2020-01-15 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 02c6767 [Relay][Frontend][TF] fix _parse_param bug (#4711) add 83da72f [Relay][Frontend][TFLite] Add

[GitHub] [incubator-tvm] tqchen merged pull request #4666: [Relay][Frontend][TFLite] Add constant input support for elemwise ops

2020-01-15 Thread GitBox
tqchen merged pull request #4666: [Relay][Frontend][TFLite] Add constant input support for elemwise ops URL: https://github.com/apache/incubator-tvm/pull/4666 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant

2020-01-15 Thread GitBox
kevinthesun commented on a change in pull request #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant URL: https://github.com/apache/incubator-tvm/pull/4707#discussion_r366892830 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -2400,9 +2400,7 @@

[incubator-tvm] branch master updated (4eecd2a -> 02c6767)

2020-01-15 Thread kevinthesun
This is an automated email from the ASF dual-hosted git repository. kevinthesun pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 4eecd2a link the math library by default (#4713) add 02c6767 [Relay][Frontend][TF] fix

[GitHub] [incubator-tvm] kevinthesun commented on issue #4711: [Relay][Frontend][TF] fix _parse_param bug

2020-01-15 Thread GitBox
kevinthesun commented on issue #4711: [Relay][Frontend][TF] fix _parse_param bug URL: https://github.com/apache/incubator-tvm/pull/4711#issuecomment-574673496 Thanks @LiangHao151941 @cchung100m This is an automated message

[GitHub] [incubator-tvm] vexilligera commented on issue #4676: Building TVM from source for Windows with LLVM support

2020-01-15 Thread GitBox
vexilligera commented on issue #4676: Building TVM from source for Windows with LLVM support URL: https://github.com/apache/incubator-tvm/issues/4676#issuecomment-574577227 Hi, I am building MXNet with TVM on Windows to support TVMOps. Building LLVM from source with Visual Studio 2017 or

[GitHub] [incubator-tvm] FrozenGene commented on issue #4670: [Relay] Bias missing in final layer of Mobilenet?

2020-01-15 Thread GitBox
FrozenGene commented on issue #4670: [Relay] Bias missing in final layer of Mobilenet? URL: https://github.com/apache/incubator-tvm/issues/4670#issuecomment-574566289 Yes. I think we miss it. This is an automated message