[tvm] branch main updated (df6ccae -> f974166)

2020-11-25 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from df6ccae [Frontend][Relay][Parser] fix unparsable yolo formals (#6963) add f974166 Don't fuse take with dynamic

[GitHub] [tvm] masahi commented on pull request #6979: Don't fuse take with dynamic inputs

2020-11-25 Thread GitBox
masahi commented on pull request #6979: URL: https://github.com/apache/tvm/pull/6979#issuecomment-734108686 thanks @mbrookhart This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tvm] masahi merged pull request #6979: Don't fuse take with dynamic inputs

2020-11-25 Thread GitBox
masahi merged pull request #6979: URL: https://github.com/apache/tvm/pull/6979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm-vta] dsteger commented on pull request #15: scripts: update processor core ip version

2020-11-25 Thread GitBox
dsteger commented on pull request #15: URL: https://github.com/apache/tvm-vta/pull/15#issuecomment-734048628 @tmoreau89 I don't mind at all. Already done. =) Ty This is an automated message from the Apache Git Service. To

[GitHub] [tvm] ZihengJiang commented on pull request #6980: HAGO: An Automated Hardware-Aware Quantization Framework

2020-11-25 Thread GitBox
ZihengJiang commented on pull request #6980: URL: https://github.com/apache/tvm/pull/6980#issuecomment-734040804 @FrozenGene Sounds good. Thanks! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] FrozenGene commented on pull request #6980: HAGO: An Automated Hardware-Aware Quantization Framework

2020-11-25 Thread GitBox
FrozenGene commented on pull request #6980: URL: https://github.com/apache/tvm/pull/6980#issuecomment-734040341 @ZihengJiang As this is WIP, is it better to mark this pr as draft pr? when it is ready, we could start to review it.

[GitHub] [tvm] ZihengJiang opened a new pull request #6980: HAGO: An Automated Hardware-Aware Quantization Framework

2020-11-25 Thread GitBox
ZihengJiang opened a new pull request #6980: URL: https://github.com/apache/tvm/pull/6980 This PR implements the automated quantization framework described in the [RFC](https://discuss.tvm.apache.org/t/rfc-search-based-automated-quantization/5483). More detail can be found in the [paper

[tvm] branch main updated (c58b20b -> df6ccae)

2020-11-25 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from c58b20b [AutoScheduler] Check duplicated names in the compute dag (#6973) add df6ccae [Frontend][Relay][Parser] fix

[GitHub] [tvm] zhiics closed issue #6962: [Frontend][Relay] YOLO module is unparsable

2020-11-25 Thread GitBox
zhiics closed issue #6962: URL: https://github.com/apache/tvm/issues/6962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] zhiics merged pull request #6963: [Frontend][Relay][Parser] fix unparsable yolo formals

2020-11-25 Thread GitBox
zhiics merged pull request #6963: URL: https://github.com/apache/tvm/pull/6963 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] masahi commented on a change in pull request #6979: Don't fuse take with dynamic inputs

2020-11-25 Thread GitBox
masahi commented on a change in pull request #6979: URL: https://github.com/apache/tvm/pull/6979#discussion_r530706418 ## File path: python/tvm/topi/transform.py ## @@ -426,6 +426,28 @@ def take(a, indices, axis=None, mode="clip"): return cpp.take(a, indices, int(axis),

[GitHub] [tvm] masahi commented on a change in pull request #6979: Don't fuse take with dynamic inputs

2020-11-25 Thread GitBox
masahi commented on a change in pull request #6979: URL: https://github.com/apache/tvm/pull/6979#discussion_r530706227 ## File path: python/tvm/relay/op/_transform.py ## @@ -332,6 +332,25 @@ def take_shape_func(attrs, inputs, out_ndims): return

[GitHub] [tvm] mbrookhart closed pull request #6906: [WIP] Various bugs in passes

2020-11-25 Thread GitBox
mbrookhart closed pull request #6906: URL: https://github.com/apache/tvm/pull/6906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] mbrookhart opened a new pull request #6979: Don't fuse take with dynamic inputs

2020-11-25 Thread GitBox
mbrookhart opened a new pull request #6979: URL: https://github.com/apache/tvm/pull/6979 Follow up to #6906 This stops fusion on take if it's inputs are dynamic and adds a regression test. This is an automated

[GitHub] [tvm] zhiics commented on a change in pull request #6978: [Relay][Topi][Dynamic] Add a Sort op and use the legalization pass to perform dynamic topk on GPU

2020-11-25 Thread GitBox
zhiics commented on a change in pull request #6978: URL: https://github.com/apache/tvm/pull/6978#discussion_r530659622 ## File path: python/tvm/topi/cuda/sort.py ## @@ -593,3 +694,76 @@ def schedule_topk(outs): The computation schedule for the op. """ return

[GitHub] [tvm] mbrookhart commented on a change in pull request #6978: [Relay][Topi][Dynamic] Add a Sort op and use the legalization pass to perform dynamic topk on GPU

2020-11-25 Thread GitBox
mbrookhart commented on a change in pull request #6978: URL: https://github.com/apache/tvm/pull/6978#discussion_r530658429 ## File path: python/tvm/topi/cuda/sort.py ## @@ -593,3 +694,76 @@ def schedule_topk(outs): The computation schedule for the op. """

[GitHub] [tvm] tqchen commented on pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-25 Thread GitBox
tqchen commented on pull request #6917: URL: https://github.com/apache/tvm/pull/6917#issuecomment-733959781 LGTM now, @FrozenGene please take another look This is an automated message from the Apache Git Service. To respond

[GitHub] [tvm] mbrookhart commented on pull request #6906: [WIP] Various bugs in passes

2020-11-25 Thread GitBox
mbrookhart commented on pull request #6906: URL: https://github.com/apache/tvm/pull/6906#issuecomment-733958301 I've been working on other things, sorry for the delay on this. take with dynamic input shapes is a bit of an issue because take folds the input shape into the compute:

[GitHub] [tvm] zhiics commented on a change in pull request #6978: [Relay][Topi][Dynamic] Add a Sort op and use the legalization pass to perform dynamic topk on GPU

2020-11-25 Thread GitBox
zhiics commented on a change in pull request #6978: URL: https://github.com/apache/tvm/pull/6978#discussion_r530653838 ## File path: python/tvm/topi/cuda/sort.py ## @@ -593,3 +694,76 @@ def schedule_topk(outs): The computation schedule for the op. """ return

[GitHub] [tvm] jwfromm commented on a change in pull request #6978: [Relay][Topi][Dynamic] Add a Sort op and use the legalization pass to perform dynamic topk on GPU

2020-11-25 Thread GitBox
jwfromm commented on a change in pull request #6978: URL: https://github.com/apache/tvm/pull/6978#discussion_r530650365 ## File path: python/tvm/topi/sort.py ## @@ -161,3 +203,25 @@ def topk(data, k=1, axis=-1, ret_type="both", is_ascend=False, dtype="int64"):

[GitHub] [tvm] mbrookhart opened a new pull request #6978: [Relay][Topi][Dynamic] Add a Sort op and use the legalization pass to perform dynamic topk on GPU

2020-11-25 Thread GitBox
mbrookhart opened a new pull request #6978: URL: https://github.com/apache/tvm/pull/6978 @zhiics @icemelon9 @jroesch After several weeks of intermittently banging my head against dynamic topi composition and a direct tir topk op for GPU, I spent this morning banging out a

[GitHub] [tvm] tmoreau89 commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
tmoreau89 commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733942969 @tqchen if we go towards putting hardware sources under VTA, we may want to rename that repo to something like tvm-hardware or something similar under which apps and VTA sources

[GitHub] [tvm] manupa-arm commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530634569 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map

[GitHub] [tvm] manupa-arm commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530634569 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map

[GitHub] [tvm] manupa-arm commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530634569 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map

[GitHub] [tvm] areusch commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
areusch commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530632362 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map for

[GitHub] [tvm] manupa-arm commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530629583 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map

[GitHub] [tvm] tqchen edited a comment on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
tqchen edited a comment on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733932171 Re the hw related component, how about we put it into the https://github.com/apache/tvm-vta repo? Given that infrastructure are already setup for testing in the VTA

[GitHub] [tvm] manupa-arm commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530629583 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map

[GitHub] [tvm] tqchen edited a comment on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
tqchen edited a comment on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733932171 Re the hw related component, how about we put it into the https://github.com/apache/tvm-vta repo? Given that infrastructure are already setup for testing in the VTA

[GitHub] [tvm] dsteger opened a new pull request #6977: bumping vta version

2020-11-25 Thread GitBox
dsteger opened a new pull request #6977: URL: https://github.com/apache/tvm/pull/6977 Bumping VTA to support Xilinx 2020.1 tools. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] tqchen commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
tqchen commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733932171 Re the hw related component, how about we put it into the https://github.com/apache/tvm-vta repo? Given that infrastructure are already setup for testing in the VTA component. We

[tvm-vta] branch main updated (ce8efad -> 519263c)

2020-11-25 Thread moreau
This is an automated email from the ASF dual-hosted git repository. moreau pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm-vta.git. from ce8efad Update to reflect repo name change (#16) add 519263c scripts: update processor core ip version (#15)

[GitHub] [tvm-vta] tmoreau89 commented on pull request #15: scripts: update processor core ip version

2020-11-25 Thread GitBox
tmoreau89 commented on pull request #15: URL: https://github.com/apache/tvm-vta/pull/15#issuecomment-733921651 @dsteger do you mind creating a PR in TVM to bump the submodule version of VTA? This is an automated message

[GitHub] [tvm-vta] tmoreau89 merged pull request #15: scripts: update processor core ip version

2020-11-25 Thread GitBox
tmoreau89 merged pull request #15: URL: https://github.com/apache/tvm-vta/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] zhiics commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
zhiics commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530613957 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map for

[GitHub] [tvm] tmoreau89 commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
tmoreau89 commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733919317 As @giuseros pointed out, an RFC about this work would be nice for longer term conversations. I'm hoping this PR can be merged soon for the TVM conf demo, but we should have

[tvm-site] branch asf-site updated: Build at Wed Nov 25 14:54:39 EST 2020

2020-11-25 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/tvm-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 071b2f0 Build at Wed Nov 25 14:54:39 EST

[tvm-site] branch main updated: minor tweak

2020-11-25 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm-site.git The following commit(s) were added to refs/heads/main by this push: new 3896941 minor tweak 3896941 is described below

[GitHub] [tvm] manupa-arm commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530609743 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map

[GitHub] [tvm-vta] dsteger opened a new pull request #17: vta: Update VTA to use load_pad_2d in compute

2020-11-25 Thread GitBox
dsteger opened a new pull request #17: URL: https://github.com/apache/tvm-vta/pull/17 Update compute instruction VTA_MEM_ID_ACC to load using the load_pad_2d method instead of the load_2d. This resolves failing unit testing "test_padded_load()". You will also notice that the indexs

[GitHub] [tvm] comaniac commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
comaniac commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733913265 > @comaniac thank you for the feedback. The decision to add the Verilog sources in a 3rd party submodule came from TVM industry contributor concerns about leaving hardware sources

[GitHub] [tvm] giuseros commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
giuseros commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733910886 @vegaluisjose , it is ok for me too. Although, I would suggest to move the RFC on the discuss forum to get more visibility and comments

[GitHub] [tvm] vegaluisjose edited a comment on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
vegaluisjose edited a comment on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733843930 > Hi @vegaluisjose , > > This looks very interesting! I would suggest to move the RFC discussion in https://discuss.tvm.apache.org/. Meanwhile, let me double

[GitHub] [tvm] zhiics commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
zhiics commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530601970 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map for

[GitHub] [tvm] tkonolige commented on a change in pull request #6889: [TOPI] sparse_dense Op sparse_data input added

2020-11-25 Thread GitBox
tkonolige commented on a change in pull request #6889: URL: https://github.com/apache/tvm/pull/6889#discussion_r530599568 ## File path: python/tvm/topi/cuda/sparse.py ## @@ -362,6 +363,7 @@ def _alter_sparse_dense_layout(_attrs, inputs, _tinfos, _out_type): sparse_dense

[GitHub] [tvm] zhiics commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
zhiics commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733908298 @vegaluisjose sounds good to me. Thanks. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] vegaluisjose edited a comment on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
vegaluisjose edited a comment on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733884979 Hi @comaniac , thank you for your feedback -- answers inline > Thanks for this interesting idea and implementation! Hopefully we can get this in. Meanwhile, we

[GitHub] [tvm] vegaluisjose commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
vegaluisjose commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733901174 Alright guys, sounds like we have a plan. I will move the Python test that I have in `hw-widgets` to follow what we have with other [external

[tvm] branch main updated (79454af -> c58b20b)

2020-11-25 Thread lmzheng
This is an automated email from the ASF dual-hosted git repository. lmzheng pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 79454af [AutoScheduler] Print the time used for measurement (#6972) add c58b20b [AutoScheduler] Check duplicated

[GitHub] [tvm] merrymercy merged pull request #6973: [AutoScheduler] Check duplicated names in the compute dag

2020-11-25 Thread GitBox
merrymercy merged pull request #6973: URL: https://github.com/apache/tvm/pull/6973 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[tvm] branch main updated (c39b8c5 -> 79454af)

2020-11-25 Thread lmzheng
This is an automated email from the ASF dual-hosted git repository. lmzheng pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from c39b8c5 [CI] Disable ASF header checking on untracked files (#6975) add 79454af [AutoScheduler] Print the time

[GitHub] [tvm] merrymercy merged pull request #6972: [AutoScheduler] Print the time used for measurement

2020-11-25 Thread GitBox
merrymercy merged pull request #6972: URL: https://github.com/apache/tvm/pull/6972 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] areusch commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
areusch commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530590667 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map for

[GitHub] [tvm] areusch commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
areusch commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530590667 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map for

[GitHub] [tvm] zhiics commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
zhiics commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530589674 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map for

[GitHub] [tvm] vegaluisjose commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
vegaluisjose commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733895668 > @vegaluisjose thanks for the explanation. It's now much more reasonable for me as I was thinking this is a general backend for everyone. In terms of being an example, this

[GitHub] [tvm] zhiics commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
zhiics commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733895297 ahh, just saw @tmoreau89's comment on the separation. This is an automated message from the Apache Git Service. To

[GitHub] [tvm] tmoreau89 commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
tmoreau89 commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733895010 I agree on adding a test case - @vegaluisjose do you mind adding one to make sure this example doesn't bitrot? I believe that the default CPU docker images are already build

[GitHub] [tvm] zhiics commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
zhiics commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733895030 @vegaluisjose thanks for the effort. I think this is a quite interesting implementation and yet another use case of BYOC. It is more like the json runtime example we had before but

[GitHub] [tvm] tmoreau89 commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
tmoreau89 commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733894434 @comaniac thank you for the feedback. The decision to add the Verilog sources in a 3rd party submodule came from TVM industry contributor concerns about leaving hardware sources

[GitHub] [tvm] areusch commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
areusch commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530584966 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map for

[GitHub] [tvm] vegaluisjose commented on a change in pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
vegaluisjose commented on a change in pull request #6971: URL: https://github.com/apache/tvm/pull/6971#discussion_r530584053 ## File path: src/relay/backend/contrib/verilator/codegen.cc ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [tvm] vegaluisjose commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
vegaluisjose commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733884979 Hi @comaniac , thank you for your feedback -- answers inline > Thanks for this interesting idea and implementation! Hopefully we can get this in. Meanwhile, we should

[GitHub] [tvm] manupa-arm commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6917: URL: https://github.com/apache/tvm/pull/6917#discussion_r530573119 ## File path: src/target/source/codegen_c_host.cc ## @@ -57,6 +60,48 @@ void CodeGenCHost::AddFunction(const PrimFunc& f) { CodeGenC::AddFunction(f);

[GitHub] [tvm] manupa-arm commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6917: URL: https://github.com/apache/tvm/pull/6917#discussion_r530573119 ## File path: src/target/source/codegen_c_host.cc ## @@ -57,6 +60,48 @@ void CodeGenCHost::AddFunction(const PrimFunc& f) { CodeGenC::AddFunction(f);

[GitHub] [tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-25 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/tvm/pull/6917#discussion_r530562921 ## File path: src/target/source/codegen_c_host.cc ## @@ -57,6 +60,48 @@ void CodeGenCHost::AddFunction(const PrimFunc& f) { CodeGenC::AddFunction(f); }

[GitHub] [tvm] comaniac commented on a change in pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
comaniac commented on a change in pull request #6971: URL: https://github.com/apache/tvm/pull/6971#discussion_r530549060 ## File path: src/relay/backend/contrib/verilator/codegen.cc ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [tvm] manupa-arm commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6655: URL: https://github.com/apache/tvm/pull/6655#discussion_r530543348 ## File path: src/relay/transforms/annotate_target.cc ## @@ -128,14 +143,31 @@ class AnnotateTargetRewriter : public ExprRewriter { * \return An

[GitHub] [tvm] manupa-arm commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6655: URL: https://github.com/apache/tvm/pull/6655#discussion_r530541955 ## File path: src/relay/transforms/annotate_target.cc ## @@ -128,14 +143,31 @@ class AnnotateTargetRewriter : public ExprRewriter { * \return An

[GitHub] [tvm] manupa-arm commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6655: URL: https://github.com/apache/tvm/pull/6655#discussion_r530541955 ## File path: src/relay/transforms/annotate_target.cc ## @@ -128,14 +143,31 @@ class AnnotateTargetRewriter : public ExprRewriter { * \return An

[GitHub] [tvm] vegaluisjose commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
vegaluisjose commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733843930 > Hi @vegaluisjose , > > This looks very interesting! I would suggest to move the RFC discussion in https://discuss.tvm.apache.org/. Meanwhile, let me double check I

[GitHub] [tvm] zhiics commented on a change in pull request #6655: [BYOC] Added "include_non_call_ops" parameter to AnnotateTarget pass

2020-11-25 Thread GitBox
zhiics commented on a change in pull request #6655: URL: https://github.com/apache/tvm/pull/6655#discussion_r530535123 ## File path: src/relay/transforms/annotate_target.cc ## @@ -128,14 +143,31 @@ class AnnotateTargetRewriter : public ExprRewriter { * \return An

[GitHub] [tvm] manupa-arm commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6917: URL: https://github.com/apache/tvm/pull/6917#discussion_r530530023 ## File path: src/target/source/codegen_c_host.cc ## @@ -57,6 +60,48 @@ void CodeGenCHost::AddFunction(const PrimFunc& f) { CodeGenC::AddFunction(f);

[GitHub] [tvm] manupa-arm commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6917: URL: https://github.com/apache/tvm/pull/6917#discussion_r530530023 ## File path: src/target/source/codegen_c_host.cc ## @@ -57,6 +60,48 @@ void CodeGenCHost::AddFunction(const PrimFunc& f) { CodeGenC::AddFunction(f);

[GitHub] [tvm] zhiics commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
zhiics commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530524813 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map for

[GitHub] [tvm] manupa-arm commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6917: URL: https://github.com/apache/tvm/pull/6917#discussion_r530530023 ## File path: src/target/source/codegen_c_host.cc ## @@ -57,6 +60,48 @@ void CodeGenCHost::AddFunction(const PrimFunc& f) { CodeGenC::AddFunction(f);

[GitHub] [tvm] zhiics commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
zhiics commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530524813 ## File path: include/tvm/ir/module.h ## @@ -56,11 +56,14 @@ class IRModuleNode : public Object { Map type_definitions; /*! \brief The source map for

[GitHub] [tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-25 Thread GitBox
areusch commented on a change in pull request #6917: URL: https://github.com/apache/tvm/pull/6917#discussion_r530501677 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -244,6 +250,43 @@ void GraphRuntime::ShareParams(const GraphRuntime& other, dmlc::Stream* strm) {

[GitHub] [tvm] zhiics commented on a change in pull request #6963: [Frontend][Relay][Parser] fix unparsable yolo formals

2020-11-25 Thread GitBox
zhiics commented on a change in pull request #6963: URL: https://github.com/apache/tvm/pull/6963#discussion_r530490107 ## File path: tests/python/frontend/darknet/test_forward.py ## @@ -59,6 +70,10 @@ def _get_tvm_output(net, data, build_dtype="float32", states=None):

[GitHub] [tvm] manupa-arm commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530488232 ## File path: python/tvm/micro/build.py ## @@ -162,7 +158,12 @@ def build_static_runtime( libs.append(compiler.library(lib_build_dir, lib_srcs,

[GitHub] [tvm] manupa-arm commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

2020-11-25 Thread GitBox
manupa-arm commented on a change in pull request #6950: URL: https://github.com/apache/tvm/pull/6950#discussion_r530488232 ## File path: python/tvm/micro/build.py ## @@ -162,7 +158,12 @@ def build_static_runtime( libs.append(compiler.library(lib_build_dir, lib_srcs,

[GitHub] [tvm] ANSHUMAN87 commented on pull request #6889: [TOPI] sparse_dense Op sparse_data input added

2020-11-25 Thread GitBox
ANSHUMAN87 commented on pull request #6889: URL: https://github.com/apache/tvm/pull/6889#issuecomment-733774476 @tkonolige : All your comments are addressed. Would you please check and approve. So that we can proceed with this PR!

[GitHub] [tvm] mbaret closed pull request #6888: Refactor compile_engine to introduce TETranslator

2020-11-25 Thread GitBox
mbaret closed pull request #6888: URL: https://github.com/apache/tvm/pull/6888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] mbaret commented on pull request #6888: Refactor compile_engine to introduce TETranslator

2020-11-25 Thread GitBox
mbaret commented on pull request #6888: URL: https://github.com/apache/tvm/pull/6888#issuecomment-733746340 Given the existing two scheduling strategies (AutoTVM/Ansor) can't make particularly good use of this refactor, I'll close this for now and just make it a standalone pass for my

[tvm] branch main updated: [CI] Disable ASF header checking on untracked files (#6975)

2020-11-25 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new c39b8c5 [CI] Disable ASF header checking on untracked

[GitHub] [tvm] tqchen merged pull request #6975: [CI] Disable ASF header checking on untracked files

2020-11-25 Thread GitBox
tqchen merged pull request #6975: URL: https://github.com/apache/tvm/pull/6975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] tqchen commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-25 Thread GitBox
tqchen commented on a change in pull request #6917: URL: https://github.com/apache/tvm/pull/6917#discussion_r530398968 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -244,6 +250,43 @@ void GraphRuntime::ShareParams(const GraphRuntime& other, dmlc::Stream* strm) {

[GitHub] [tvm] tqchen commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

2020-11-25 Thread GitBox
tqchen commented on a change in pull request #6917: URL: https://github.com/apache/tvm/pull/6917#discussion_r530398968 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -244,6 +250,43 @@ void GraphRuntime::ShareParams(const GraphRuntime& other, dmlc::Stream* strm) {

[tvm-site] branch asf-site updated: Build at Wed Nov 25 09:04:19 EST 2020

2020-11-25 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/tvm-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 4b30928 Build at Wed Nov 25 09:04:19 EST

[tvm-site] branch main updated: fix typo in maillist addresses (#21)

2020-11-25 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm-site.git The following commit(s) were added to refs/heads/main by this push: new 0a198c1 fix typo in maillist addresses (#21)

[GitHub] [tvm] tqchen closed issue #6974: The way to get graph json ?

2020-11-25 Thread GitBox
tqchen closed issue #6974: URL: https://github.com/apache/tvm/issues/6974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] tqchen commented on issue #6974: The way to get graph json ?

2020-11-25 Thread GitBox
tqchen commented on issue #6974: URL: https://github.com/apache/tvm/issues/6974#issuecomment-733708368 thanks for asking the question, this question is better suited on https://discuss.tvm.apache.org/, please open a new thread there

[GitHub] [tvm] mshawcroft commented on pull request #6976: build: Do not ASF check files not under version control

2020-11-25 Thread GitBox
mshawcroft commented on pull request #6976: URL: https://github.com/apache/tvm/pull/6976#issuecomment-733677988 Manupa pushed the same fix just before me ,https://github.com/apache/tvm/pull/6975 This is an automated message

[GitHub] [tvm] mshawcroft closed pull request #6976: build: Do not ASF check files not under version control

2020-11-25 Thread GitBox
mshawcroft closed pull request #6976: URL: https://github.com/apache/tvm/pull/6976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] mshawcroft opened a new pull request #6976: build: Do not ASF check files not under version control

2020-11-25 Thread GitBox
mshawcroft opened a new pull request #6976: URL: https://github.com/apache/tvm/pull/6976 The current behaviour of checking all files in the tree irrespective of whether they are under version control means that it is not possible to run the toplevel build and test in the same tree

[GitHub] [tvm] giuseros commented on pull request #6971: [Hardware][Verilator] Integrating and simulating hardware accelerators in TVM

2020-11-25 Thread GitBox
giuseros commented on pull request #6971: URL: https://github.com/apache/tvm/pull/6971#issuecomment-733654476 Hi @vegaluisjose , This looks very interesting! I would suggest to move the RFC discussion in https://discuss.tvm.apache.org/. Meanwhile, let me double check I understood

[GitHub] [tvm] manupa-arm opened a new pull request #6975: [CI] Disable ASF header checking on untracked files

2020-11-25 Thread GitBox
manupa-arm opened a new pull request #6975: URL: https://github.com/apache/tvm/pull/6975 * This patch will disable checking for ASF header in untracked files that are never going to make its way into the repo. * That would help developers to have their untracked local files.

[GitHub] [tvm] zhxfl opened a new issue #6974: The way to get graph json ?

2020-11-25 Thread GitBox
zhxfl opened a new issue #6974: URL: https://github.com/apache/tvm/issues/6974 The way to get json without "relay.build" api ? tests/cpp/build_module_test.cc : 129 This is an automated message from the Apache Git