[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r818759960 ## File path: src/tir/ir/expr.cc ## @@ -1056,12 +1058,28 @@ TVM_STATIC_IR_FUNCTOR(ReprPrinter, vtable) .set_dispatch([](const ObjectRef& node,

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r818725019 ## File path: include/tvm/tir/builtin.h ## @@ -105,10 +105,10 @@ TVM_DLL const Op& large_uint_imm(); TVM_DLL const Op& q_multiply_shift(); /*! - *

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r818717609 ## File path: src/tir/ir/buffer.cc ## @@ -407,22 +515,31 @@ PrimExpr Buffer::access_ptr(int access_mask, DataType ptr_type, int content_lane

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r818706698 ## File path: src/printer/tvmscript_printer.cc ## @@ -1008,8 +1013,59 @@ Doc TVMScriptPrinter::VisitStmt_(const BufferRealizeNode* op) { return Doc();

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r810385743 ## File path: src/target/source/codegen_c.cc ## @@ -158,78 +158,52 @@ void CodeGenC::PrintSSAAssign(const std::string& target, const std::string& src, }

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r810384766 ## File path: src/tir/transforms/vectorize_loop.cc ## @@ -62,30 +62,89 @@ class VecAllocAccess : public StmtExprMutator { public:

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r810384190 ## File path: tests/python/unittest/test_tir_transform_lower_cross_thread_reduction.py ## @@ -25,7 +25,14 @@ def _check(original, transformed): mod

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r808071250 ## File path: src/tir/analysis/device_constraint_utils.cc ## @@ -223,6 +225,23 @@ class ApplyDeviceConstraintsMutator : public StmtExprMutator {

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r807377035 ## File path: tests/python/unittest/test_tir_transform_instrument_bound_checkers.py ## @@ -94,7 +94,7 @@ def test_out_of_bounds_vectorize_llvm(nn,

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r807375704 ## File path: src/tir/transforms/merge_dynamic_shared_memory_allocations.cc ## @@ -294,22 +308,61 @@ class DynamicSharedMemoryRewriter : public

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r807371988 ## File path: src/tir/transforms/split_host_device.cc ## @@ -155,10 +160,27 @@ class VarUseDefAnalysis : public StmtExprMutator { } PrimExpr

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r807370425 ## File path: python/tvm/script/tir/special_stmt.py ## @@ -132,6 +132,7 @@ def match_buffer( align=-1, offset_factor=0,

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r807365129 ## File path: include/tvm/tir/function.h ## @@ -136,15 +157,31 @@ class PrimFunc : public BaseFunc { public: /*! * \brief Constructor + * *

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r807356985 ## File path: include/tvm/tir/buffer.h ## @@ -98,10 +113,17 @@ class BufferNode : public Object { } bool SEqualReduce(const BufferNode* other,

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r805056854 ## File path: include/tvm/tir/buffer.h ## @@ -55,8 +55,22 @@ class BufferNode : public Object { Var data; /*! \brief data type in the content of the

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r805050148 ## File path: include/tvm/tir/function.h ## @@ -91,11 +91,23 @@ class PrimFuncNode : public BaseFuncNode { */ Map buffer_map; + /*! \brief The

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r805042526 ## File path: include/tvm/te/schedule.h ## @@ -771,6 +835,36 @@ class Singleton : public IterVarRelation { TVM_DEFINE_OBJECT_REF_METHODS(Singleton,

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r783315315 ## File path: include/tvm/tir/buffer.h ## @@ -55,8 +55,48 @@ class BufferNode : public Object { Var data; /*! \brief data type in the content of the

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r782420647 ## File path: include/tvm/tir/buffer.h ## @@ -55,8 +55,48 @@ class BufferNode : public Object { Var data; /*! \brief data type in the content of the

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r780353202 ## File path: include/tvm/tir/buffer.h ## @@ -55,8 +55,48 @@ class BufferNode : public Object { Var data; /*! \brief data type in the content of the

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r780353202 ## File path: include/tvm/tir/buffer.h ## @@ -55,8 +55,48 @@ class BufferNode : public Object { Var data; /*! \brief data type in the content of the

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r779831427 ## File path: python/tvm/te/schedule.py ## @@ -519,9 +523,149 @@ def rolling_buffer(self): """ _ffi_api.StageRollingBuffer(self) +

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r779824817 ## File path: src/tir/transforms/lower_custom_datatypes.cc ## @@ -103,32 +103,59 @@ class CustomDatatypesLowerer : public StmtExprMutator { } }

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r779822646 ## File path: include/tvm/tir/buffer.h ## @@ -55,8 +55,48 @@ class BufferNode : public Object { Var data; /*! \brief data type in the content of the

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r777575815 ## File path: src/tir/transforms/inject_virtual_thread.cc ## @@ -354,46 +391,44 @@ class VTInjector : public StmtExprMutator { } // Allocate Stmt

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r777557743 ## File path: src/tir/transforms/arg_binder.cc ## @@ -184,38 +194,41 @@ void ArgBinder::BindDLTensor(const Buffer& buffer, const PrimExpr& device_type,

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r777520439 ## File path: python/tvm/tir/ir_builder.py ## @@ -442,26 +447,23 @@ def pointer(self, content_type, name="ptr", scope=""): ptr : BufferVar

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r777520439 ## File path: python/tvm/tir/ir_builder.py ## @@ -442,26 +447,23 @@ def pointer(self, content_type, name="ptr", scope=""): ptr : BufferVar

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770698252 ## File path: src/tir/ir/index_map.cc ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770692650 ## File path: src/tir/transforms/ir_utils.cc ## @@ -111,26 +111,56 @@ class IRConvertSSA final : public StmtExprMutator { return

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770692302 ## File path: src/tir/transforms/ir_utils.cc ## @@ -111,26 +111,56 @@ class IRConvertSSA final : public StmtExprMutator { return

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770661440 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -931,15 +931,15 @@ llvm::Value* CodeGenLLVM::CreateIntrinsic(const CallNode* op) { } else if

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770653917 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -1189,14 +1189,24 @@ llvm::Value* CodeGenLLVM::VisitExpr_(const LetNode* op) { } llvm::Value*

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770649373 ## File path: src/te/schedule/schedule_ops.cc ## @@ -343,12 +367,16 @@ Stmt ScheduleOps(Schedule sch, Map dom_map_, bool debug_keep_tri Stage s =

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770123610 ## File path: src/tir/ir/index_map.cc ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770119853 ## File path: src/tir/ir/index_map.cc ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770107423 ## File path: python/tvm/te/schedule.py ## @@ -519,9 +523,149 @@ def rolling_buffer(self): """ _ffi_api.StageRollingBuffer(self) +

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770098174 ## File path: include/tvm/tir/index_map.h ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770081720 ## File path: include/tvm/tir/index_map.h ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r770049796 ## File path: include/tvm/tir/expr.h ## @@ -610,6 +610,14 @@ class BufferLoadNode : public PrimExprNode { /*! \brief The indices location to be loaded.

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r769882395 ## File path: include/tvm/tir/buffer.h ## @@ -127,7 +174,7 @@ class BufferNode : public Object { * without adjusting for number of lanes. (e.g. The

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r769831152 ## File path: include/tvm/tir/buffer.h ## @@ -55,8 +55,48 @@ class BufferNode : public Object { Var data; /*! \brief data type in the content of the

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r769798693 ## File path: include/tvm/tir/buffer.h ## @@ -88,6 +128,8 @@ class BufferNode : public Object { v->Visit("data", ); v->Visit("dtype", );

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r769793275 ## File path: include/tvm/te/schedule.h ## @@ -466,9 +498,27 @@ class StageNode : public Object { * while origin_op remains fixed. */

[GitHub] [tvm] Lunderberg commented on a change in pull request #9727: [TE][TIR] Implement layout transformations, non-flat memory buffers

Lunderberg commented on a change in pull request #9727: URL: https://github.com/apache/tvm/pull/9727#discussion_r769791881 ## File path: include/tvm/te/schedule.h ## @@ -256,6 +257,37 @@ class Stage : public ObjectRef { * \return reference to self. */ TVM_DLL Stage&