[jira] [Commented] (AIRFLOW-5272) Flower is not working with Redis Sentinel

2019-08-22 Thread Liang Chen (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913053#comment-16913053 ] Liang Chen commented on AIRFLOW-5272: - I figured it out, two workaround: 1. export

[jira] [Created] (AIRFLOW-5282) KubernetesExecutor hangs when kubernetes API times out

2019-08-22 Thread Roland de Boo (Jira)
Roland de Boo created AIRFLOW-5282: -- Summary: KubernetesExecutor hangs when kubernetes API times out Key: AIRFLOW-5282 URL: https://issues.apache.org/jira/browse/AIRFLOW-5282 Project: Apache Airflow

[GitHub] [airflow] Fokko opened a new pull request #5881: [AIRFLOW-5284] Replace warn by warning

2019-08-22 Thread GitBox
Fokko opened a new pull request #5881: [AIRFLOW-5284] Replace warn by warning URL: https://github.com/apache/airflow/pull/5881 Got a deprecation message in the logs while debugging some code: ``` dag_processing.py:689: DeprecationWarning: The 'warn' method is deprecated, use

[jira] [Commented] (AIRFLOW-5282) KubernetesExecutor hangs when kubernetes API times out

2019-08-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913098#comment-16913098 ] ASF GitHub Bot commented on AIRFLOW-5282: - rolanddb commented on pull request #5880:

[GitHub] [airflow] rolanddb opened a new pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError

2019-08-22 Thread GitBox
rolanddb opened a new pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError URL: https://github.com/apache/airflow/pull/5880 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] feluelle commented on issue #5881: [AIRFLOW-5284] Replace warn by warning

2019-08-22 Thread GitBox
feluelle commented on issue #5881: [AIRFLOW-5284] Replace warn by warning URL: https://github.com/apache/airflow/pull/5881#issuecomment-523810814 We have multiple uses of `log.warn`. Can you fix them all together? :) See:

[jira] [Updated] (AIRFLOW-5282) KubernetesExecutor hangs when kubernetes API times out

2019-08-22 Thread Roland de Boo (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roland de Boo updated AIRFLOW-5282: --- Description: While migrating to a different Kubernetes cluster, we observe that the

[jira] [Commented] (AIRFLOW-5284) Replace warn by warning

2019-08-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913100#comment-16913100 ] ASF GitHub Bot commented on AIRFLOW-5284: - Fokko commented on pull request #5881:

[jira] [Commented] (AIRFLOW-5284) Replace warn by warning

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913099#comment-16913099 ] ASF subversion and git services commented on AIRFLOW-5284: -- Commit

[jira] [Closed] (AIRFLOW-5271) EmrCreateJobFlowOperator throwing error in airflow 1.10.4 version

2019-08-22 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor closed AIRFLOW-5271. -- Resolution: Information Provided If you have followed the steps in the updating

[jira] [Comment Edited] (AIRFLOW-5272) Flower is not working with Redis Sentinel

2019-08-22 Thread Liang Chen (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913053#comment-16913053 ] Liang Chen edited comment on AIRFLOW-5272 at 8/22/19 7:21 AM: -- I figured

[jira] [Comment Edited] (AIRFLOW-5272) Flower is not working with Redis Sentinel

2019-08-22 Thread Liang Chen (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913053#comment-16913053 ] Liang Chen edited comment on AIRFLOW-5272 at 8/22/19 7:22 AM: -- I figured

[jira] [Created] (AIRFLOW-5283) Separate scheduling jobs from executing jobs

2019-08-22 Thread Gero Vermaas (Jira)
Gero Vermaas created AIRFLOW-5283: - Summary: Separate scheduling jobs from executing jobs Key: AIRFLOW-5283 URL: https://issues.apache.org/jira/browse/AIRFLOW-5283 Project: Apache Airflow

[jira] [Created] (AIRFLOW-5284) Replace warn by warning

2019-08-22 Thread Fokko Driesprong (Jira)
Fokko Driesprong created AIRFLOW-5284: - Summary: Replace warn by warning Key: AIRFLOW-5284 URL: https://issues.apache.org/jira/browse/AIRFLOW-5284 Project: Apache Airflow Issue Type:

[GitHub] [airflow] akki opened a new pull request #5882: [AIRFLOW-XXX] Add Agoda to the users list in README

2019-08-22 Thread GitBox
akki opened a new pull request #5882: [AIRFLOW-XXX] Add Agoda to the users list in README URL: https://github.com/apache/airflow/pull/5882 Here at Agoda, we love using (and, whenever possible, contributing back to) Airflow in our data pipeline team. Kudos to the Airflow community for

[GitHub] [airflow] BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test

2019-08-22 Thread GitBox
BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523859176 @potiuk @Fokko @ashb had a think about it. Pytest requires test class names to start with `Test`

[GitHub] [airflow] ashb commented on issue #5857: [AIRFLOW-5251] add missing typing-extensions dep for py37

2019-08-22 Thread GitBox
ashb commented on issue #5857: [AIRFLOW-5251] add missing typing-extensions dep for py37 URL: https://github.com/apache/airflow/pull/5857#issuecomment-523866254 Thanks @houqp (for this and the related PR). Once this is green I'll merge.

[GitHub] [airflow] BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test

2019-08-22 Thread GitBox
BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523868192 Okay, isn't that up to the reviewer to correct? If we were to implement some name enforcement utility, we'd

[GitHub] [airflow] ashb commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test

2019-08-22 Thread GitBox
ashb commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523869438 > Okay, isn't that up to the reviewer to correct? It is, but the less load we can place on the reviewers the

[GitHub] [airflow] ashb commented on issue #5756: [AIRFLOW-5138] Don't override user's warning settings in airflow.configuration

2019-08-22 Thread GitBox
ashb commented on issue #5756: [AIRFLOW-5138] Don't override user's warning settings in airflow.configuration URL: https://github.com/apache/airflow/pull/5756#issuecomment-523879124 "FutureWarning" is proabably right for some of the use cases here (wrong config file, etc) but there are

[GitHub] [airflow] Fokko merged pull request #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test

2019-08-22 Thread GitBox
Fokko merged pull request #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847 This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] ashb commented on a change in pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError

2019-08-22 Thread GitBox
ashb commented on a change in pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError URL: https://github.com/apache/airflow/pull/5880#discussion_r316573609 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -776,11 +776,13 @@

[GitHub] [airflow] ashb commented on a change in pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError

2019-08-22 Thread GitBox
ashb commented on a change in pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError URL: https://github.com/apache/airflow/pull/5880#discussion_r316577541 ## File path: airflow/contrib/executors/kubernetes_executor.py ## @@ -797,6 +799,10

[GitHub] [airflow] Fokko merged pull request #5873: [AIRFLOW-5269] Reuse session in Scheduler Job from health endpoint

2019-08-22 Thread GitBox
Fokko merged pull request #5873: [AIRFLOW-5269] Reuse session in Scheduler Job from health endpoint URL: https://github.com/apache/airflow/pull/5873 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (AIRFLOW-5269) Reuse existing session of '/health' endpoint to get most recent Scheduler Job

2019-08-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913192#comment-16913192 ] ASF GitHub Bot commented on AIRFLOW-5269: - Fokko commented on pull request #5873:

[GitHub] [airflow] ashb commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test

2019-08-22 Thread GitBox
ashb commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523860392 Am I right in thinking that if the name is wrong then py-test will simply "ignore" the tests and not run it? That's

[GitHub] [airflow] BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test

2019-08-22 Thread GitBox
BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523863081 Pytest docs regarding test classes: - Collects test prefixed test functions or methods inside Test prefixed

[GitHub] [airflow] ashb commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-22 Thread GitBox
ashb commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-523870661 Another idea: right now the `airflow webserver` cycles the gunicorn workers every 120s (by default) -- if

[GitHub] [airflow] BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test

2019-08-22 Thread GitBox
BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523877875 Okay. I rebased and resolved all conflicts the gcp package created. Good to merge?

[jira] [Commented] (AIRFLOW-5283) Separate scheduling jobs from executing jobs

2019-08-22 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913218#comment-16913218 ] Ash Berlin-Taylor commented on AIRFLOW-5283: Look at the "catchup" setting (either globally

[GitHub] [airflow] kaxil commented on issue #5882: [AIRFLOW-XXX] Add Agoda to the users list in README

2019-08-22 Thread GitBox
kaxil commented on issue #5882: [AIRFLOW-XXX] Add Agoda to the users list in README URL: https://github.com/apache/airflow/pull/5882#issuecomment-523860915 Welcome @akki . Glad that you love Airflow :) This is an automated

[GitHub] [airflow] kaxil merged pull request #5882: [AIRFLOW-XXX] Add Agoda to the users list in README

2019-08-22 Thread GitBox
kaxil merged pull request #5882: [AIRFLOW-XXX] Add Agoda to the users list in README URL: https://github.com/apache/airflow/pull/5882 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] ashb commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test

2019-08-22 Thread GitBox
ashb commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523863349 In the past we add tests but because of bad naming they never ran, which is almost worse than not adding tests.

[jira] [Resolved] (AIRFLOW-5276) Remove unused helpers from airflow.utils.helpers

2019-08-22 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-5276. Fix Version/s: 1.10.5 Resolution: Fixed > Remove unused helpers from

[GitHub] [airflow] Fokko commented on issue #5881: [AIRFLOW-5284] Replace warn by warning

2019-08-22 Thread GitBox
Fokko commented on issue #5881: [AIRFLOW-5284] Replace warn by warning URL: https://github.com/apache/airflow/pull/5881#issuecomment-523819770 I've replaced the other ones as well. I'm always a bit hesitant to do this, since the `except` branch isn't always covered by tests.

[jira] [Resolved] (AIRFLOW-5269) Reuse existing session of '/health' endpoint to get most recent Scheduler Job

2019-08-22 Thread Fokko Driesprong (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-5269. --- Resolution: Fixed > Reuse existing session of '/health' endpoint to get most

[GitHub] [airflow] shaikshakeel commented on issue #5415: AIRFLOW-4791 add "schema" keyword arg to SnowflakeOperator

2019-08-22 Thread GitBox
shaikshakeel commented on issue #5415: AIRFLOW-4791 add "schema" keyword arg to SnowflakeOperator URL: https://github.com/apache/airflow/pull/5415#issuecomment-523837495 Hi @jgysland I was trying to connect to snowflake using schema, I was unable to connect it is throwing error

[GitHub] [airflow] mrshu commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

2019-08-22 Thread GitBox
mrshu commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name URL: https://github.com/apache/airflow/pull/5879#issuecomment-523861473 @ashb I am also happy to just update the docs if you think that would be better -- it's just that I haven't found this

[jira] [Commented] (AIRFLOW-5279) Should use links instead of buttons for Airflow modals

2019-08-22 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913239#comment-16913239 ] Ash Berlin-Taylor commented on AIRFLOW-5279: Dang again? I thought we fixed that once

[jira] [Commented] (AIRFLOW-1498) Add Google Analytics to Airflow

2019-08-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913240#comment-16913240 ] ASF GitHub Bot commented on AIRFLOW-1498: - ashb commented on pull request #5850: [AIRFLOW-1498]

[GitHub] [airflow] ashb merged pull request #5850: [AIRFLOW-1498] Add analytics script

2019-08-22 Thread GitBox
ashb merged pull request #5850: [AIRFLOW-1498] Add analytics script URL: https://github.com/apache/airflow/pull/5850 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] rolanddb commented on issue #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError

2019-08-22 Thread GitBox
rolanddb commented on issue #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError URL: https://github.com/apache/airflow/pull/5880#issuecomment-523866851 @andy-g14 I added the timeout configuration from your unit test as a default. This works at runtime, but tests are

[jira] [Commented] (AIRFLOW-1498) Add Google Analytics to Airflow

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913241#comment-16913241 ] ASF subversion and git services commented on AIRFLOW-1498: -- Commit

[GitHub] [airflow] BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test

2019-08-22 Thread GitBox
BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523872982 Ok, some more examples: - `Call` in `tests/operators/test_python_operator.py` - `StubClass` in

[jira] [Commented] (AIRFLOW-5241) Make all test class names consistent by starting with Test

2019-08-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913269#comment-16913269 ] ASF GitHub Bot commented on AIRFLOW-5241: - Fokko commented on pull request #5847:

[jira] [Commented] (AIRFLOW-5241) Make all test class names consistent by starting with Test

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913271#comment-16913271 ] ASF subversion and git services commented on AIRFLOW-5241: -- Commit

[jira] [Commented] (AIRFLOW-5269) Reuse existing session of '/health' endpoint to get most recent Scheduler Job

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913215#comment-16913215 ] ASF subversion and git services commented on AIRFLOW-5269: -- Commit

[GitHub] [airflow] kaxil commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-22 Thread GitBox
kaxil commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-523847270 > fileloc is not stored in DB for subdag, because subdag does not have a row in DB. subdag's fileloc is

[GitHub] [airflow] ashb commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test

2019-08-22 Thread GitBox
ashb commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523855410 @BasPH when you come to rename tests/core.py, be aware that one or two other test files do `from tests.core import

[GitHub] [airflow] ashb commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

2019-08-22 Thread GitBox
ashb commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name URL: https://github.com/apache/airflow/pull/5879#issuecomment-523868615 https://airflow.apache.org/howto/connection/aws.html (which should be docs/source/howto/connection/aws.rst)

[GitHub] [airflow] villasv opened a new pull request #5883: [AIRFLOW-5194] Add error handler to action log

2019-08-22 Thread GitBox
villasv opened a new pull request #5883: [AIRFLOW-5194] Add error handler to action log URL: https://github.com/apache/airflow/pull/5883 ### Jira - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-5194) issues and references them in

[jira] [Commented] (AIRFLOW-5194) Make @cli_utils.action_logging silent about missing log table

2019-08-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913251#comment-16913251 ] ASF GitHub Bot commented on AIRFLOW-5194: - villasv commented on pull request #5883:

[GitHub] [airflow] ashb merged pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators

2019-08-22 Thread GitBox
ashb merged pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators URL: https://github.com/apache/airflow/pull/5645 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (AIRFLOW-5027) Generalized CloudWatch log grabbing for ECS and SageMaker operators

2019-08-22 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-5027. Fix Version/s: 1.10.5 Resolution: Done > Generalized CloudWatch log

[GitHub] [airflow] ashb commented on a change in pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError

2019-08-22 Thread GitBox
ashb commented on a change in pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError URL: https://github.com/apache/airflow/pull/5880#discussion_r316747088 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -776,7 +776,9 @@

[GitHub] [airflow] ashb commented on a change in pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError

2019-08-22 Thread GitBox
ashb commented on a change in pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError URL: https://github.com/apache/airflow/pull/5880#discussion_r316746816 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -776,7 +776,9 @@

[jira] [Commented] (AIRFLOW-1498) Add Google Analytics to Airflow

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913389#comment-16913389 ] ASF subversion and git services commented on AIRFLOW-1498: -- Commit

[jira] [Commented] (AIRFLOW-5027) Generalized CloudWatch log grabbing for ECS and SageMaker operators

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913393#comment-16913393 ] ASF subversion and git services commented on AIRFLOW-5027: -- Commit

[jira] [Commented] (AIRFLOW-5027) Generalized CloudWatch log grabbing for ECS and SageMaker operators

2019-08-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913392#comment-16913392 ] ASF GitHub Bot commented on AIRFLOW-5027: - ashb commented on pull request #5645: [AIRFLOW-5027]

[jira] [Commented] (AIRFLOW-4027) Make experimental api tests more stateless

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913386#comment-16913386 ] ASF subversion and git services commented on AIRFLOW-4027: -- Commit

[jira] [Commented] (AIRFLOW-5276) Remove unused helpers from airflow.utils.helpers

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913388#comment-16913388 ] ASF subversion and git services commented on AIRFLOW-5276: -- Commit

[jira] [Commented] (AIRFLOW-4013) Mark success/failed is picking all execution date

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913387#comment-16913387 ] ASF subversion and git services commented on AIRFLOW-4013: -- Commit

[jira] [Commented] (AIRFLOW-5182) "KubernetesOperator" isn't implemented

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913385#comment-16913385 ] ASF subversion and git services commented on AIRFLOW-5182: -- Commit

[jira] [Commented] (AIRFLOW-5284) Replace warn by warning

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913390#comment-16913390 ] ASF subversion and git services commented on AIRFLOW-5284: -- Commit

[jira] [Assigned] (AIRFLOW-5278) Add a mark failure button under mark success button in the tree view

2019-08-22 Thread Sean McQueen (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean McQueen reassigned AIRFLOW-5278: - Assignee: Sean McQueen > Add a mark failure button under mark success button in the

[GitHub] [airflow] ashb commented on issue #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError

2019-08-22 Thread GitBox
ashb commented on issue #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError URL: https://github.com/apache/airflow/pull/5880#issuecomment-523960429 The problem in the other PR seemed to be around putting a default value in our config template (which is actually a

[jira] [Commented] (AIRFLOW-5269) Reuse existing session of '/health' endpoint to get most recent Scheduler Job

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913225#comment-16913225 ] ASF subversion and git services commented on AIRFLOW-5269: -- Commit

[GitHub] [airflow] andy-g14 commented on issue #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError

2019-08-22 Thread GitBox
andy-g14 commented on issue #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError URL: https://github.com/apache/airflow/pull/5880#issuecomment-523960010 @rolanddb , you will need to provide the value as json string, i.e enclosed in single quotes. it works for me this

[GitHub] [airflow] StevenReitsma commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators

2019-08-22 Thread GitBox
StevenReitsma commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators URL: https://github.com/apache/airflow/pull/5645#discussion_r316674469 ## File path: airflow/contrib/operators/ecs_operator.py ## @@ -96,6 +111,10 @@ def

[jira] [Commented] (AIRFLOW-1733) BashOperator readline can hang

2019-08-22 Thread Dan Davydov (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913307#comment-16913307 ] Dan Davydov commented on AIRFLOW-1733: -- I believe I fixed this already... closing > BashOperator

[jira] [Resolved] (AIRFLOW-1733) BashOperator readline can hang

2019-08-22 Thread Dan Davydov (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Davydov resolved AIRFLOW-1733. -- Resolution: Fixed > BashOperator readline can hang > -- > >

[jira] [Resolved] (AIRFLOW-2023) Add debug information to help determine lagging scheduler file processing

2019-08-22 Thread Dan Davydov (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Davydov resolved AIRFLOW-2023. -- Resolution: Fixed > Add debug information to help determine lagging scheduler file

[GitHub] [airflow] OmerJog commented on issue #5559: [AIRFLOW-4930] Send druid ingestion spec as data, not json

2019-08-22 Thread GitBox
OmerJog commented on issue #5559: [AIRFLOW-4930] Send druid ingestion spec as data, not json URL: https://github.com/apache/airflow/pull/5559#issuecomment-523908039 @ashb @kaxil @potiuk can review? This is an automated

[jira] [Commented] (AIRFLOW-953) Tasks marked as successful should have complete state set

2019-08-22 Thread Dan Davydov (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913312#comment-16913312 ] Dan Davydov commented on AIRFLOW-953: - Good point, I meant for tasks that were not previously

[jira] [Commented] (AIRFLOW-5284) Replace warn by warning

2019-08-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913285#comment-16913285 ] ASF GitHub Bot commented on AIRFLOW-5284: - kaxil commented on pull request #5881:

[jira] [Commented] (AIRFLOW-5284) Replace warn by warning

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913286#comment-16913286 ] ASF subversion and git services commented on AIRFLOW-5284: -- Commit

[jira] [Resolved] (AIRFLOW-5284) Replace warn by warning

2019-08-22 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-5284. - Fix Version/s: 1.10.5 2.0.0 Resolution: Fixed > Replace warn by

[GitHub] [airflow] kaxil merged pull request #5881: [AIRFLOW-5284] Replace warn by warning

2019-08-22 Thread GitBox
kaxil merged pull request #5881: [AIRFLOW-5284] Replace warn by warning URL: https://github.com/apache/airflow/pull/5881 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (AIRFLOW-4846) Allow specification of an existing secret containing git credentials for init containers

2019-08-22 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4846. Fix Version/s: 1.10.5 Resolution: Fixed > Allow specification of an

[GitHub] [airflow] ashb commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators

2019-08-22 Thread GitBox
ashb commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators URL: https://github.com/apache/airflow/pull/5645#discussion_r316671749 ## File path: airflow/contrib/operators/ecs_operator.py ## @@ -96,6 +111,10 @@ def

[GitHub] [airflow] StevenReitsma commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators

2019-08-22 Thread GitBox
StevenReitsma commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators URL: https://github.com/apache/airflow/pull/5645#discussion_r316671744 ## File path: airflow/contrib/operators/ecs_operator.py ## @@ -96,6 +111,10 @@ def

[jira] [Resolved] (AIRFLOW-3542) next_ds semantics broken for manually triggered runs

2019-08-22 Thread Dan Davydov (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Davydov resolved AIRFLOW-3542. -- Fix Version/s: 1.10.0 Resolution: Fixed > next_ds semantics broken for manually

[jira] [Updated] (AIRFLOW-953) Tasks marked as successful should have complete state set

2019-08-22 Thread Dan Davydov (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Davydov updated AIRFLOW-953: Description: Tasks marked as successful should have start/end_date/duration/operator set .

[GitHub] [airflow] potiuk merged pull request #5790: [AIRFLOW-5180] Added static checks (yamllint) + auto-licences for yaml

2019-08-22 Thread GitBox
potiuk merged pull request #5790: [AIRFLOW-5180] Added static checks (yamllint) + auto-licences for yaml URL: https://github.com/apache/airflow/pull/5790 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (AIRFLOW-5180) Add static checks for Yaml files (yamllint + LICENCE check)

2019-08-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913344#comment-16913344 ] ASF GitHub Bot commented on AIRFLOW-5180: - potiuk commented on pull request #5790:

[jira] [Commented] (AIRFLOW-5180) Add static checks for Yaml files (yamllint + LICENCE check)

2019-08-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913345#comment-16913345 ] ASF subversion and git services commented on AIRFLOW-5180: -- Commit

[GitHub] [airflow] StevenReitsma commented on issue #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators

2019-08-22 Thread GitBox
StevenReitsma commented on issue #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators URL: https://github.com/apache/airflow/pull/5645#issuecomment-523933990 @ashb Made the change and Travis is green again. PTAL :)

[jira] [Commented] (AIRFLOW-1288) Bad owners field in DAGs breaks Airflow front page

2019-08-22 Thread Dan Davydov (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913309#comment-16913309 ] Dan Davydov commented on AIRFLOW-1288: -- Yeah I think this is what one of our users did. > Bad

[GitHub] [airflow] ashb commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators

2019-08-22 Thread GitBox
ashb commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators URL: https://github.com/apache/airflow/pull/5645#discussion_r316680688 ## File path: airflow/contrib/operators/ecs_operator.py ## @@ -96,6 +111,10 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5647: [AIRFLOW-3628] Add smtp_mime_from

2019-08-22 Thread GitBox
ashb commented on a change in pull request #5647: [AIRFLOW-3628] Add smtp_mime_from URL: https://github.com/apache/airflow/pull/5647#discussion_r316682319 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -349,6 +349,7 @@ smtp_ssl = False smtp_port = 25

[jira] [Closed] (AIRFLOW-684) Add task log pagination to webservers

2019-08-22 Thread Dan Davydov (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Davydov closed AIRFLOW-684. --- Resolution: Fixed Already accomplished by some of the new log readers > Add task log pagination to

[GitHub] [airflow] ashb commented on a change in pull request #5841: [AIRFLOW-3705] Fix PostgresHook get_conn to use conn_name_attr

2019-08-22 Thread GitBox
ashb commented on a change in pull request #5841: [AIRFLOW-3705] Fix PostgresHook get_conn to use conn_name_attr URL: https://github.com/apache/airflow/pull/5841#discussion_r316688934 ## File path: tests/hooks/test_postgres_hook.py ## @@ -39,7 +39,10 @@ def setUp(self):

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-22 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r316701217 ## File path: BREEZE.rst ## @@ -0,0 +1,766 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] ashb commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators

2019-08-22 Thread GitBox
ashb commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators URL: https://github.com/apache/airflow/pull/5645#discussion_r316653947 ## File path: airflow/contrib/operators/ecs_operator.py ## @@ -96,6 +111,10 @@ def

[GitHub] [airflow] StevenReitsma commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators

2019-08-22 Thread GitBox
StevenReitsma commented on a change in pull request #5645: [AIRFLOW-5027] Get logs from CloudWatch for ECSOperators URL: https://github.com/apache/airflow/pull/5645#discussion_r316670866 ## File path: airflow/contrib/operators/ecs_operator.py ## @@ -96,6 +111,10 @@ def

[GitHub] [airflow] OmerJog commented on issue #5647: [AIRFLOW-3628] Add smtp_mime_from

2019-08-22 Thread GitBox
OmerJog commented on issue #5647: [AIRFLOW-3628] Add smtp_mime_from URL: https://github.com/apache/airflow/pull/5647#issuecomment-523905091 @ashb @feng-tao can review? This is an automated message from the Apache Git Service.

[GitHub] [airflow] dimberman commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-22 Thread GitBox
dimberman commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r316675736 ## File path: BREEZE.rst ## @@ -0,0 +1,766 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] dimberman commented on issue #4932: [AIRFLOW-3611] Breeze

2019-08-22 Thread GitBox
dimberman commented on issue #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#issuecomment-523904652 Wooo! Ok I'm gonna roll up my sleeves this morning and dive in on this one. This is an

[GitHub] [airflow] ashb commented on a change in pull request #5668: [AIRFLOW-4316] support setting kubernetes_environment_variables config section from env var

2019-08-22 Thread GitBox
ashb commented on a change in pull request #5668: [AIRFLOW-4316] support setting kubernetes_environment_variables config section from env var URL: https://github.com/apache/airflow/pull/5668#discussion_r316690777 ## File path: tests/operators/test_email_operator.py ## @@

[GitHub] [airflow] dimberman commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-22 Thread GitBox
dimberman commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r316676511 ## File path: BREEZE.rst ## @@ -0,0 +1,766 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

  1   2   >