[GitHub] boyuanzz opened a new pull request #4: Fix typo

2018-09-07 Thread GitBox
boyuanzz opened a new pull request #4: Fix typo URL: https://github.com/apache/beam-wheels/pull/4 r: @charlesccychen This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] charlesccychen closed pull request #4: Fix typo

2018-09-07 Thread GitBox
charlesccychen closed pull request #4: Fix typo URL: https://github.com/apache/beam-wheels/pull/4 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), th

[GitHub] charlesccychen commented on issue #4: Fix typo

2018-09-07 Thread GitBox
charlesccychen commented on issue #4: Fix typo URL: https://github.com/apache/beam-wheels/pull/4#issuecomment-419583863 Thanks! This LGTM. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] charlesccychen removed a comment on issue #4: Fix typo

2018-09-07 Thread GitBox
charlesccychen removed a comment on issue #4: Fix typo URL: https://github.com/apache/beam-wheels/pull/4#issuecomment-419594519 @asfgit merge This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] charlesccychen commented on issue #4: Fix typo

2018-09-07 Thread GitBox
charlesccychen commented on issue #4: Fix typo URL: https://github.com/apache/beam-wheels/pull/4#issuecomment-419594519 @asfgit merge This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] boyuanzz opened a new pull request #5: Drop RC tag

2018-09-10 Thread GitBox
boyuanzz opened a new pull request #5: Drop RC tag URL: https://github.com/apache/beam-wheels/pull/5 We are going to drop RC tag in order to make it installable trough pypi r: @pabloem cc: @charlesccychen This is an au

[GitHub] pabloem commented on issue #5: Drop RC tag

2018-09-11 Thread GitBox
pabloem commented on issue #5: Drop RC tag URL: https://github.com/apache/beam-wheels/pull/5#issuecomment-420347288 LGTM For posterity, we do this to simplify the release process. It can be reverted later if necessary. Thi

[GitHub] pabloem closed pull request #5: Drop RC tag

2018-09-11 Thread GitBox
pabloem closed pull request #5: Drop RC tag URL: https://github.com/apache/beam-wheels/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the di

[GitHub] charlesccychen commented on issue #5: Drop RC tag

2018-09-11 Thread GitBox
charlesccychen commented on issue #5: Drop RC tag URL: https://github.com/apache/beam-wheels/pull/5#issuecomment-420351130 Thanks Boyuan! For more context, this fixes an issue where pip install of wheel packages didn't work because of the RC tag which was present upon uploading to PyPI.

[GitHub] aaltay closed pull request #2: Add travis build config files and upload artifacts into dist.apache.org

2018-08-14 Thread GitBox
aaltay closed pull request #2: Add travis build config files and upload artifacts into dist.apache.org URL: https://github.com/apache/beam-wheels/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[GitHub] [beam] robertwb commented on issue #10843: [BEAM-8201] Pass all other endpoints through provisioning service.

2020-02-26 Thread GitBox
robertwb commented on issue #10843: [BEAM-8201] Pass all other endpoints through provisioning service. URL: https://github.com/apache/beam/pull/10843#issuecomment-591558550 Ping. This is an automated message from the Apache G

[GitHub] [beam] alexvanboxel commented on issue #10796: Refine access level for `sdks/java/extensions/protobuf`

2020-02-26 Thread GitBox
alexvanboxel commented on issue #10796: Refine access level for `sdks/java/extensions/protobuf` URL: https://github.com/apache/beam/pull/10796#issuecomment-591558802 > I just rebased now that the Protobuf extension was fully merged, can we get this one in now @alexvanboxel ? Yes, th

[GitHub] [beam] chamikaramj commented on issue #10834: Logs BQ insert failures

2020-02-26 Thread GitBox
chamikaramj commented on issue #10834: Logs BQ insert failures URL: https://github.com/apache/beam/pull/10834#issuecomment-591558984 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] robertwb merged pull request #10900: [BEAM-9335] update hard-coded coder id when translating Java external transforms

2020-02-26 Thread GitBox
robertwb merged pull request #10900: [BEAM-9335] update hard-coded coder id when translating Java external transforms URL: https://github.com/apache/beam/pull/10900 This is an automated message from the Apache Git Service. T

[GitHub] [beam] je-ik commented on a change in pull request #8774: [BEAM-8550] Requires time sorted input

2020-02-26 Thread GitBox
je-ik commented on a change in pull request #8774: [BEAM-8550] Requires time sorted input URL: https://github.com/apache/beam/pull/8774#discussion_r384664775 ## File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOp

[GitHub] [beam] udim commented on issue #10928: [BEAM-9355] Basic support for NewType

2020-02-26 Thread GitBox
udim commented on issue #10928: [BEAM-9355] Basic support for NewType URL: https://github.com/apache/beam/pull/10928#issuecomment-591561732 Review ping This is an automated message from the Apache Git Service. To respond to th

[GitHub] [beam] robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384666716 ## File path: sdks/python/apache_beam/runners/common.py ## @@ -529,7 +530,7 @@ class SimpleInvoker(DoFnInvok

[GitHub] [beam] robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384665851 ## File path: sdks/python/apache_beam/io/iobase.py ## @@ -1289,9 +1289,9 @@ class RestrictionProgress(object

[GitHub] [beam] robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384669757 ## File path: sdks/python/apache_beam/transforms/external_java.py ## @@ -37,18 +39,19 @@ # Protect agains

[GitHub] [beam] robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384666558 ## File path: sdks/python/apache_beam/runners/common.py ## @@ -375,7 +379,7 @@ class DoFnInvoker(object):

[GitHub] [beam] udim merged pull request #10734: [BEAM-8979] reintroduce mypy-protobuf stub generation

2020-02-26 Thread GitBox
udim merged pull request #10734: [BEAM-8979] reintroduce mypy-protobuf stub generation URL: https://github.com/apache/beam/pull/10734 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] udim merged pull request #10928: [BEAM-9355] Basic support for NewType

2020-02-26 Thread GitBox
udim merged pull request #10928: [BEAM-9355] Basic support for NewType URL: https://github.com/apache/beam/pull/10928 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [beam] chamikaramj commented on issue #9852: [BEAM-8458] Add option to set temp dataset in BigQueryIO.Read

2020-02-26 Thread GitBox
chamikaramj commented on issue #9852: [BEAM-8458] Add option to set temp dataset in BigQueryIO.Read URL: https://github.com/apache/beam/pull/9852#issuecomment-591569326 Run JavaPortabilityApi PreCommit This is an automated me

[GitHub] [beam] chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384678493 ## File path: sdks/python/apache_beam/io/iobase.py ## @@ -1289,9 +1289,9 @@ class RestrictionProgress(object)

[GitHub] [beam] chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384689098 ## File path: sdks/python/apache_beam/transforms/external_java.py ## @@ -37,18 +39,19 @@ # Protect against

[GitHub] [beam] bumblebee-coming commented on issue #10951: [BEAM-8575] Modified the test to work for different runners.

2020-02-26 Thread GitBox
bumblebee-coming commented on issue #10951: [BEAM-8575] Modified the test to work for different runners. URL: https://github.com/apache/beam/pull/10951#issuecomment-591579870 Retest this please This is an automated message fr

[GitHub] [beam] pawelpasterz commented on a change in pull request #10878: Implement precommit portability test to run on java 11

2020-02-26 Thread GitBox
pawelpasterz commented on a change in pull request #10878: Implement precommit portability test to run on java 11 URL: https://github.com/apache/beam/pull/10878#discussion_r384694088 ## File path: runners/google-cloud-dataflow-java/examples/build.gradle ## @@ -97,6 +97,42

[GitHub] [beam] kennknowles opened a new pull request #8223: [BEAM-6441] Revise release branch cut instructions

2020-02-26 Thread GitBox
kennknowles opened a new pull request #8223: [BEAM-6441] Revise release branch cut instructions URL: https://github.com/apache/beam/pull/8223 The current release branch cut script pushes to both the release branch and master without verification. The useful logic it encapsulates is simply

[GitHub] [beam] stale[bot] commented on issue #8223: [BEAM-6441] Revise release branch cut instructions

2020-02-26 Thread GitBox
stale[bot] commented on issue #8223: [BEAM-6441] Revise release branch cut instructions URL: https://github.com/apache/beam/pull/8223#issuecomment-591585140 This pull request is no longer marked as stale. This is an autom

[GitHub] [beam] aaltay merged pull request #10899: [BEAM-8335] Background Caching job

2020-02-26 Thread GitBox
aaltay merged pull request #10899: [BEAM-8335] Background Caching job URL: https://github.com/apache/beam/pull/10899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] iemejia commented on issue #10796: Refine access level for `sdks/java/extensions/protobuf`

2020-02-26 Thread GitBox
iemejia commented on issue #10796: Refine access level for `sdks/java/extensions/protobuf` URL: https://github.com/apache/beam/pull/10796#issuecomment-591586152 > > I just rebased now that the Protobuf extension was fully merged, can we get this one in now @alexvanboxel ? > > Yes, t

[GitHub] [beam] chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384700835 ## File path: sdks/python/apache_beam/runners/common.py ## @@ -375,7 +379,7 @@ class DoFnInvoker(object):

[GitHub] [beam] kennknowles merged pull request #10859: Update Dataflow monitoring URL

2020-02-26 Thread GitBox
kennknowles merged pull request #10859: Update Dataflow monitoring URL URL: https://github.com/apache/beam/pull/10859 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [beam] lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property.

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892#discussion_r384689184 ## File path: sdks/python/apache_beam/runners/direct/test_stream_impl.py

[GitHub] [beam] lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property.

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892#discussion_r384692255 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -

[GitHub] [beam] lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property.

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892#discussion_r384699533 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -

[GitHub] [beam] lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property.

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892#discussion_r384699002 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -

[GitHub] [beam] lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property.

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892#discussion_r384703870 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -

[GitHub] [beam] lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property.

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892#discussion_r384698347 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -

[GitHub] [beam] lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property.

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892#discussion_r384702356 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -

[GitHub] [beam] lukecwik merged pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property.

2020-02-26 Thread GitBox
lukecwik merged pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892 This is an automated message from the Apache Git Service. T

[GitHub] [beam] lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property.

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892#discussion_r384692255 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -

[GitHub] [beam] lukecwik commented on a change in pull request #10878: Implement precommit portability test to run on java 11

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10878: Implement precommit portability test to run on java 11 URL: https://github.com/apache/beam/pull/10878#discussion_r384712207 ## File path: runners/google-cloud-dataflow-java/examples/build.gradle ## @@ -97,6 +97,42 @@ t

[GitHub] [beam] chamikaramj commented on issue #9852: [BEAM-8458] Add option to set temp dataset in BigQueryIO.Read

2020-02-26 Thread GitBox
chamikaramj commented on issue #9852: [BEAM-8458] Add option to set temp dataset in BigQueryIO.Read URL: https://github.com/apache/beam/pull/9852#issuecomment-591606577 Error for failing task seems to be unrelated. Task 'javaPreCommitPortabilityApiJava11' not found in root project 'beam'

[GitHub] [beam] chamikaramj merged pull request #9852: [BEAM-8458] Add option to set temp dataset in BigQueryIO.Read

2020-02-26 Thread GitBox
chamikaramj merged pull request #9852: [BEAM-8458] Add option to set temp dataset in BigQueryIO.Read URL: https://github.com/apache/beam/pull/9852 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [beam] aaltay commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
aaltay commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#issuecomment-591608825 My suggestion, would be to merge this and not change the behavior for 2.20. The reason i

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591610348 Down to 79 errors! Btw, mypy may have revealed some legitimate errors in a recent change: ``` apache_beam/runners/worker/operatio

[GitHub] [beam] angoenka commented on issue #10870: [BEAM-9263] Bump up sdk dataflow environment major versions

2020-02-26 Thread GitBox
angoenka commented on issue #10870: [BEAM-9263] Bump up sdk dataflow environment major versions URL: https://github.com/apache/beam/pull/10870#issuecomment-591623293 Do we need to make service changes before bumping the fn-api version The tests are failing with java.lang.RuntimeEx

[GitHub] [beam] pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK

2020-02-26 Thread GitBox
pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK URL: https://github.com/apache/beam/pull/10979#issuecomment-591637525 Yes, I will be thrilled to review this : ) This is a

[GitHub] [beam] pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591638375 Run Python PreCommit This is an automated mes

[GitHub] [beam] pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK

2020-02-26 Thread GitBox
pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK URL: https://github.com/apache/beam/pull/10979#issuecomment-591638243 Retest this please This is an automated message from

[GitHub] [beam] pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591638734 Retest this please This is an automated messa

[GitHub] [beam] rohdesamuel opened a new pull request #10980: Address leftover styling comments from PR/10892

2020-02-26 Thread GitBox
rohdesamuel opened a new pull request #10980: Address leftover styling comments from PR/10892 URL: https://github.com/apache/beam/pull/10980 Change-Id: Ic8b4f23693d11bf5cd451c27527e6eb924aa8f98 Address leftover styling comments from PR/10892 Tha

[GitHub] [beam] rohdesamuel commented on issue #10980: Address leftover styling comments from PR/10892

2020-02-26 Thread GitBox
rohdesamuel commented on issue #10980: Address leftover styling comments from PR/10892 URL: https://github.com/apache/beam/pull/10980#issuecomment-591640091 R: @lukecwik This is an automated message from the Apache Git Servi

[GitHub] [beam] pabloem commented on issue #10976: Fix kotlin warnings

2020-02-26 Thread GitBox
pabloem commented on issue #10976: Fix kotlin warnings URL: https://github.com/apache/beam/pull/10976#issuecomment-591639909 thanks Alex, Harshit! This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [beam] y1chi commented on issue #10870: [BEAM-9263] Bump up sdk dataflow environment major versions

2020-02-26 Thread GitBox
y1chi commented on issue #10870: [BEAM-9263] Bump up sdk dataflow environment major versions URL: https://github.com/apache/beam/pull/10870#issuecomment-591641587 > Do we need to make service changes before bumping the fn-api version > The tests are failing with I checked with ser

[GitHub] [beam] ameihm0912 commented on issue #10973: KinesisIO retry LimitExceededException

2020-02-26 Thread GitBox
ameihm0912 commented on issue #10973: KinesisIO retry LimitExceededException URL: https://github.com/apache/beam/pull/10973#issuecomment-591642429 > Thank you for contribution! Have you seen this PR #9765 and a discussion over this topic there? I think it tries to solve the similar problem,

[GitHub] [beam] alexvanboxel merged pull request #10796: Refine access level for `sdks/java/extensions/protobuf`

2020-02-26 Thread GitBox
alexvanboxel merged pull request #10796: Refine access level for `sdks/java/extensions/protobuf` URL: https://github.com/apache/beam/pull/10796 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] alexvanboxel commented on issue #10796: Refine access level for `sdks/java/extensions/protobuf`

2020-02-26 Thread GitBox
alexvanboxel commented on issue #10796: Refine access level for `sdks/java/extensions/protobuf` URL: https://github.com/apache/beam/pull/10796#issuecomment-591644791 Jenkins doesn't make sense, doing a pragmatic merge This is

[GitHub] [beam] lukecwik commented on a change in pull request #10980: Address leftover styling comments from PR/10892

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10980: Address leftover styling comments from PR/10892 URL: https://github.com/apache/beam/pull/10980#discussion_r384767097 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -183,9 +182,20 @@ class TestStream

[GitHub] [beam] lukecwik commented on a change in pull request #10980: Address leftover styling comments from PR/10892

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10980: Address leftover styling comments from PR/10892 URL: https://github.com/apache/beam/pull/10980#discussion_r384763184 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -148,9 +148,8 @@ def __lt__(self,

[GitHub] [beam] lukecwik commented on a change in pull request #10980: Address leftover styling comments from PR/10892

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10980: Address leftover styling comments from PR/10892 URL: https://github.com/apache/beam/pull/10980#discussion_r384766435 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -183,9 +182,20 @@ class TestStream

[GitHub] [beam] lukecwik commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
lukecwik commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#issuecomment-591649117 @aaltay Even though I prefer a proper fix, being pragmatic is important. This still ne

[GitHub] [beam] bumblebee-coming commented on issue #10951: [BEAM-8575] Modified the test to work for different runners.

2020-02-26 Thread GitBox
bumblebee-coming commented on issue #10951: [BEAM-8575] Modified the test to work for different runners. URL: https://github.com/apache/beam/pull/10951#issuecomment-591651589 R: @robertwb This is an automated message from the

[GitHub] [beam] ibzib commented on issue #10967: [BEAM-9300] convert struct literal in ZetaSQL

2020-02-26 Thread GitBox
ibzib commented on issue #10967: [BEAM-9300] convert struct literal in ZetaSQL URL: https://github.com/apache/beam/pull/10967#issuecomment-591655184 Got this working now. PTAL @robinyqiu @amaliujia This is an automated messag

[GitHub] [beam] robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384788269 ## File path: sdks/python/apache_beam/transforms/external_java.py ## @@ -37,18 +39,19 @@ # Protect agains

[GitHub] [beam] robertwb commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners.

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners. URL: https://github.com/apache/beam/pull/10951#discussion_r384789304 ## File path: sdks/python/apache_beam/transforms/combiners_test.py ## @@ -482,9 +485,13

[GitHub] [beam] robertwb commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners.

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners. URL: https://github.com/apache/beam/pull/10951#discussion_r384789396 ## File path: sdks/python/apache_beam/transforms/combiners_test.py ## @@ -470,6 +470,9 @

[GitHub] [beam] chamikaramj commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

2020-02-26 Thread GitBox
chamikaramj commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r384729053 ## File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComp

[GitHub] [beam] chamikaramj commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

2020-02-26 Thread GitBox
chamikaramj commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r384675886 ## File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environ

[GitHub] [beam] iemejia commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
iemejia commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591667294 retest this please This is an automated messa

[GitHub] [beam] iht commented on issue #9852: [BEAM-8458] Add option to set temp dataset in BigQueryIO.Read

2020-02-26 Thread GitBox
iht commented on issue #9852: [BEAM-8458] Add option to set temp dataset in BigQueryIO.Read URL: https://github.com/apache/beam/pull/9852#issuecomment-591668641 Thank you! This is an automated message from the Apache Git Serv

[GitHub] [beam] iemejia commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard

2020-02-26 Thread GitBox
iemejia commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard URL: https://github.com/apache/beam/pull/10964#issuecomment-591672273 This build has failed at least 10 times on unrelated flake tests I am going to merge it eagerly, if anything ends up broken I

[GitHub] [beam] iemejia merged pull request #10964: Make logger naming consistent with Apache Beam LOG standard

2020-02-26 Thread GitBox
iemejia merged pull request #10964: Make logger naming consistent with Apache Beam LOG standard URL: https://github.com/apache/beam/pull/10964 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] pabloem commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard

2020-02-26 Thread GitBox
pabloem commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard URL: https://github.com/apache/beam/pull/10964#issuecomment-591672889 fyi henry This is an automated message from the Apache Git S

[GitHub] [beam] iemejia commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard

2020-02-26 Thread GitBox
iemejia commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard URL: https://github.com/apache/beam/pull/10964#issuecomment-591672678 Thanks Pablo! This is an automated message from the Apache G

[GitHub] [beam] pabloem commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard

2020-02-26 Thread GitBox
pabloem commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard URL: https://github.com/apache/beam/pull/10964#issuecomment-591672844 cc: @henryken This is an automated message from the Apache

[GitHub] [beam] aaltay commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
aaltay commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#issuecomment-591677820 > @aaltay Even though I prefer a proper fix, being pragmatic is important. This still ne

[GitHub] [beam] chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384807421 ## File path: sdks/python/apache_beam/transforms/external_java.py ## @@ -37,18 +39,19 @@ # Protect against

[GitHub] [beam] chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384807421 ## File path: sdks/python/apache_beam/transforms/external_java.py ## @@ -37,18 +39,19 @@ # Protect against

[GitHub] [beam] chadrik edited a comment on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik edited a comment on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591610348 Down to 79 errors! Btw, mypy may have revealed some legitimate errors in a recent change: ``` apache_beam/runners/worker/

[GitHub] [beam] aaltay commented on a change in pull request #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
aaltay commented on a change in pull request #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#discussion_r384809280 ## File path: sdks/python/apache_beam/pipeline.py ##

[GitHub] [beam] pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591680118 thanks @bobingm ! Looks good to me. Can you fix the formatting issues, and I'll merge? --

[GitHub] [beam] aaltay merged pull request #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
aaltay merged pull request #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934 This is an automated message from the Apache

[GitHub] [beam] kennknowles commented on issue #10882: Implement java precommit dataflow examples tests to run on java 11

2020-02-26 Thread GitBox
kennknowles commented on issue #10882: Implement java precommit dataflow examples tests to run on java 11 URL: https://github.com/apache/beam/pull/10882#issuecomment-591681112 Sorry - got this mixed up with a similar PR and lost track. --

[GitHub] [beam] kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11

2020-02-26 Thread GitBox
kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11 URL: https://github.com/apache/beam/pull/10882#discussion_r384811472 ## File path: .test-infra/jenkins/job_PreCommit_Java_Examples_Dataflow_Java11.groovy ##

[GitHub] [beam] kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11

2020-02-26 Thread GitBox
kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11 URL: https://github.com/apache/beam/pull/10882#discussion_r384811829 ## File path: .test-infra/jenkins/job_PreCommit_Java_Examples_Dataflow_Java11.groovy ##

[GitHub] [beam] kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11

2020-02-26 Thread GitBox
kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11 URL: https://github.com/apache/beam/pull/10882#discussion_r384811574 ## File path: .test-infra/jenkins/job_PreCommit_Java_Examples_Dataflow_Java11.groovy ##

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591685577 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git

[GitHub] [beam] bobingm commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
bobingm commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591688753 @pabloem the failure is not caused by this PR. ---

[GitHub] [beam] kennknowles commented on a change in pull request #10878: Implement precommit portability test to run on java 11

2020-02-26 Thread GitBox
kennknowles commented on a change in pull request #10878: Implement precommit portability test to run on java 11 URL: https://github.com/apache/beam/pull/10878#discussion_r384828402 ## File path: runners/google-cloud-dataflow-java/examples/build.gradle ## @@ -97,6 +97,42 @

[GitHub] [beam] robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384826746 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@ pub

[GitHub] [beam] robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384820354 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@ pub

[GitHub] [beam] robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384793593 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@ pub

[GitHub] [beam] mf2199 edited a comment on issue #8457: [BEAM-3342] Create a Cloud Bigtable IO connector for Python

2020-02-26 Thread GitBox
mf2199 edited a comment on issue #8457: [BEAM-3342] Create a Cloud Bigtable IO connector for Python URL: https://github.com/apache/beam/pull/8457#issuecomment-590610828 @chamikaramj PTAL. The long standing issue now seems to be resolved. The reason was the namespace conflict between the ex

[GitHub] [beam] pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591699495 I see. Thanks for pointing that out. This is

[GitHub] [beam] pabloem merged pull request #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
pabloem merged pull request #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901 This is an automated message from the Apache Git Service. To respo

[GitHub] [beam] pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591699695 thanks @bobingm This is an automated message

[GitHub] [beam] pawelpasterz commented on a change in pull request #10878: Implement precommit portability test to run on java 11

2020-02-26 Thread GitBox
pawelpasterz commented on a change in pull request #10878: Implement precommit portability test to run on java 11 URL: https://github.com/apache/beam/pull/10878#discussion_r384834326 ## File path: runners/google-cloud-dataflow-java/examples/build.gradle ## @@ -97,6 +97,42

[GitHub] [beam] chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384836306 ## File path: sdks/python/apache_beam/transforms/external_java.py ## @@ -37,18 +39,19 @@ # Protect against

  1   2   3   4   5   6   7   8   9   10   >