[GitHub] mrunalinikankariya commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API

2017-10-12 Thread git
mrunalinikankariya commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API URL: https://github.com/apache/cloudstack/pull/2242#issuecomment-336345491 tag:This is Ready to Merge This is an

[GitHub] rhtyd commented on issue #1558: CLOUDSTACK-10072: Remove unused code from "com.cloud.vm.UserVmManagerImpl"

2017-10-12 Thread git
rhtyd commented on issue #1558: CLOUDSTACK-10072: Remove unused code from "com.cloud.vm.UserVmManagerImpl" URL: https://github.com/apache/cloudstack/pull/1558#issuecomment-336125805 @blueorangutan package This is an

[GitHub] rhtyd commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-10-12 Thread git
rhtyd commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected URL: https://github.com/apache/cloudstack/pull/2258#issuecomment-336125672 @PranaliM the new test has failed, please see the logs and fix the failure

[GitHub] blueorangutan commented on issue #1558: CLOUDSTACK-10072: Remove unused code from "com.cloud.vm.UserVmManagerImpl"

2017-10-12 Thread git
blueorangutan commented on issue #1558: CLOUDSTACK-10072: Remove unused code from "com.cloud.vm.UserVmManagerImpl" URL: https://github.com/apache/cloudstack/pull/1558#issuecomment-336125905 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

2017-10-12 Thread git
rhtyd commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-336125424 @syed looks like we have new conflicts This is an automated message from

[GitHub] DaanHoogland commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data

2017-10-12 Thread git
DaanHoogland commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data URL: https://github.com/apache/cloudstack/pull/2208#issuecomment-336070793 two runs with the same version led to different fails as I suspected. I don't see direct relation to the

[GitHub] borisstoyanov commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
borisstoyanov commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#issuecomment-336061995 @blueorangutan package This is an automated message from

[GitHub] blueorangutan commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
blueorangutan commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#issuecomment-336068676 Packaging result: ?centos6 ?centos7 ?debian. JID-1152 This

[GitHub] blueorangutan commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
blueorangutan commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#issuecomment-336076082 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] agx commented on issue #2083: Iptables speedup

2017-10-12 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-336047386 @DaanHoogland from what I can see to use iptables-conv verbatim we'd mostly need to - [x] not sys.exit(1) from the module - [x] move to using logger instead

[GitHub] agx commented on issue #2083: Iptables speedup

2017-10-12 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-336047386 @DaanHoogland from what I can see to use iptables-conv verbatim we'd mostly need to - [x] not sys.exit(1) from the module - [ ] move to using logger instead

[GitHub] blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations

2017-10-12 Thread git
blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-336071131 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] DaanHoogland commented on issue #2181: CLOUDSTACK-9957 Annotations

2017-10-12 Thread git
DaanHoogland commented on issue #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-336070998 @blueorangutan test This is an automated message from the Apache Git Service. To

[GitHub] agx commented on issue #2083: Iptables speedup

2017-10-12 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-336047386 @DaanHoogland from what I can see to use iptables-conv verbatim we'd mostly need to * not sys.exit(1) from the module (done) * move to using logger instead

[GitHub] blueorangutan commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
blueorangutan commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#issuecomment-336062186 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
borisstoyanov commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#issuecomment-336076028 @blueorangutan test This is an automated message from the

[GitHub] agx commented on issue #2083: Iptables speedup

2017-10-12 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-336047386 @DaanHoogland from what I can see to use iptables-conv verbatim we'd mostly need to - [x] not sys.exit(1) from the module - [ ] move to using logger instead

[GitHub] rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144250258 ## File path: server/src/com/cloud/hypervisor/HypervisorGuruBase.java ## @@ -138,7

[GitHub] SowjanyaPatha commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API

2017-10-12 Thread git
SowjanyaPatha commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API URL: https://github.com/apache/cloudstack/pull/2242#issuecomment-336088845 LGTM for Testing This is an automated

[GitHub] vedulasantosh commented on issue #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

2017-10-12 Thread git
vedulasantosh commented on issue #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds URL: https://github.com/apache/cloudstack/pull/2244#issuecomment-336090373 Test LGTM SSVM log: 2017-10-12 09:23:16,435 WARN [vmware.manager.VmwareStorageManagerImpl]

[GitHub] rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144259524 ## File path: utils/src/main/java/com/cloud/utils/UriUtils.java ## @@ -391,4 +391,57 @@ public

[GitHub] rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144263042 ## File path: utils/src/test/java/com/cloud/utils/UriUtilsTest.java ## @@ -57,4 +60,45 @@ public

[GitHub] borisstoyanov commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.

2017-10-12 Thread git
borisstoyanov commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-336103107 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.

2017-10-12 Thread git
blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-336103201 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings.

2017-10-12 Thread git
rhtyd commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings. URL: https://github.com/apache/cloudstack/pull/2250#issuecomment-336104911 @blueorangutan package This is

[GitHub] rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2)

2017-10-12 Thread git
rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#discussion_r144247590 ## File path: engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java ## @@ -301,13 +306,16 @@ public void

[GitHub] rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2)

2017-10-12 Thread git
rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#discussion_r144248244 ## File path: ui/scripts/configuration.js ## @@ -2766,10 +2776,13 @@

[GitHub] rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2)

2017-10-12 Thread git
rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#discussion_r144248102 ## File path: ui/scripts/configuration.js ## @@ -2766,10 +2776,13 @@

[GitHub] rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144250838 ## File path: utils/src/main/java/com/cloud/utils/UriUtils.java ## @@ -391,4 +391,57

[GitHub] nitin-maharana commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.

2017-10-12 Thread git
nitin-maharana commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-336095574 @borisstoyanov, DONE!! Thanks, Nitin This is

[GitHub] rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144259343 ## File path: server/src/com/cloud/hypervisor/HypervisorGuruBase.java ## @@ -138,7

[GitHub] borisstoyanov commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.

2017-10-12 Thread git
borisstoyanov commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-336097755 thanks @nitin-maharana @blueorangutan package This is

[GitHub] blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.

2017-10-12 Thread git
blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-336097815 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.

2017-10-12 Thread git
blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-336102745 Packaging result: ?centos6 ?centos7 ?debian. JID-1153

[GitHub] fmaximus commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings.

2017-10-12 Thread git
fmaximus commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings. URL: https://github.com/apache/cloudstack/pull/2250#issuecomment-336103994 I've added an extra unit test for the changed code, to keep the history intact in relation to

[GitHub] nitin-maharana commented on a change in pull request #2294: Adding allocated IOPS to storage pool response

2017-10-12 Thread git
nitin-maharana commented on a change in pull request #2294: Adding allocated IOPS to storage pool response URL: https://github.com/apache/cloudstack/pull/2294#discussion_r144201108 ## File path: api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java ## @@

[GitHub] rafaelweingartner commented on a change in pull request #2284: CLOUDSTACK-10103: Cloudian Connector for CloudStack

2017-10-12 Thread git
rafaelweingartner commented on a change in pull request #2284: CLOUDSTACK-10103: Cloudian Connector for CloudStack URL: https://github.com/apache/cloudstack/pull/2284#discussion_r144254195 ## File path:

[GitHub] rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144257564 ## File path: utils/src/main/java/com/cloud/utils/UriUtils.java ## @@ -391,4 +391,57 @@ public

[GitHub] rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144258991 ## File path: utils/src/main/java/com/cloud/utils/UriUtils.java ## @@ -391,4 +391,57

[GitHub] rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144262001 ## File path: utils/src/main/java/com/cloud/utils/UriUtils.java ## @@ -391,4 +391,57

[GitHub] blueorangutan commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings.

2017-10-12 Thread git
blueorangutan commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings. URL: https://github.com/apache/cloudstack/pull/2250#issuecomment-336105047 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2)

2017-10-12 Thread git
rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#discussion_r144247885 ## File path: server/src/com/cloud/network/IpAddressManagerImpl.java ## @@ -1088,6 +1087,7 @@ public void

[GitHub] rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2)

2017-10-12 Thread git
rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#discussion_r144248053 ## File path: ui/scripts/configuration.js ## @@ -2403,13 +2403,20 @@

[GitHub] rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2)

2017-10-12 Thread git
rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#discussion_r144248294 ## File path: ui/scripts/configuration.js ## @@ -3315,6 +3328,13 @@

[GitHub] rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2)

2017-10-12 Thread git
rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#discussion_r144247839 ## File path: server/src/com/cloud/network/IpAddressManagerImpl.java ## @@ -815,7 +814,7 @@ public

[GitHub] rafaelweingartner commented on a change in pull request #2284: CLOUDSTACK-10103: Cloudian Connector for CloudStack

2017-10-12 Thread git
rafaelweingartner commented on a change in pull request #2284: CLOUDSTACK-10103: Cloudian Connector for CloudStack URL: https://github.com/apache/cloudstack/pull/2284#discussion_r144251252 ## File path:

[GitHub] rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144258800 ## File path: server/src/com/cloud/hypervisor/HypervisorGuruBase.java ## @@ -138,7 +143,24 @@

[GitHub] rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144258800 ## File path: server/src/com/cloud/hypervisor/HypervisorGuruBase.java ## @@ -138,7 +143,24 @@

[GitHub] rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144260215 ## File path: utils/src/main/java/com/cloud/utils/UriUtils.java ## @@ -391,4 +391,57

[GitHub] rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144261072 ## File path: utils/src/test/java/com/cloud/utils/UriUtilsTest.java ## @@ -57,4 +60,45 @@ public

[GitHub] rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144261109 ## File path: utils/src/main/java/com/cloud/utils/UriUtils.java ## @@ -391,4 +391,57 @@ public

[GitHub] rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144262446 ## File path: utils/src/test/java/com/cloud/utils/UriUtilsTest.java ## @@ -57,4

[GitHub] rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
rafaelweingartner commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144263495 ## File path: utils/src/test/java/com/cloud/utils/UriUtilsTest.java ## @@ -57,4

[GitHub] blueorangutan commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings.

2017-10-12 Thread git
blueorangutan commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings. URL: https://github.com/apache/cloudstack/pull/2250#issuecomment-336113848 Packaging result: ?centos6 ?centos7 ?debian. JID-1154

[GitHub] blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

2017-10-12 Thread git
blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-336121981 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

2017-10-12 Thread git
rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-336121806 @blueorangutan package This is an

[cloudstack] branch master updated: CLOUDSTACK-10060: ListUsage API always displays the Virtual size as '0' for Usage type=9 (snapshot) (#2257)

2017-10-12 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 189b0e4 CLOUDSTACK-10060: ListUsage API

[GitHub] rhtyd closed pull request #2257: CLOUDSTACK-10060:ListUsage API always displays the Virtual size as '0' for Usage type=9 (snapshot)

2017-10-12 Thread git
rhtyd closed pull request #2257: CLOUDSTACK-10060:ListUsage API always displays the Virtual size as '0' for Usage type=9 (snapshot) URL: https://github.com/apache/cloudstack/pull/2257 This is an automated message from the

[GitHub] rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

2017-10-12 Thread git
rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-336123383 @resmo is that a regression of sorts, we holding this PR?

[GitHub] rhtyd commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API

2017-10-12 Thread git
rhtyd commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API URL: https://github.com/apache/cloudstack/pull/2242#issuecomment-336125126 @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API

2017-10-12 Thread git
blueorangutan commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API URL: https://github.com/apache/cloudstack/pull/2242#issuecomment-336125290 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] nitin-maharana commented on issue #2294: Adding allocated IOPS to storage pool response

2017-10-12 Thread git
nitin-maharana commented on issue #2294: Adding allocated IOPS to storage pool response URL: https://github.com/apache/cloudstack/pull/2294#issuecomment-336030471 Code LGTM. This is an automated message from the Apache Git

[GitHub] blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check

2017-10-12 Thread git
blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-336031058 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check

2017-10-12 Thread git
rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-336031031 @blueorangutan package This is an automated message from the Apache Git Service.

[GitHub] blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

2017-10-12 Thread git
blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-336133578 Packaging result: ?centos6 ?centos7 ?debian. JID-1155

[GitHub] blueorangutan commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API

2017-10-12 Thread git
blueorangutan commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API URL: https://github.com/apache/cloudstack/pull/2242#issuecomment-336136345 Packaging result: ?centos6 ?centos7 ?debian. JID-1156

[GitHub] blueorangutan commented on issue #1558: CLOUDSTACK-10072: Remove unused code from "com.cloud.vm.UserVmManagerImpl"

2017-10-12 Thread git
blueorangutan commented on issue #1558: CLOUDSTACK-10072: Remove unused code from "com.cloud.vm.UserVmManagerImpl" URL: https://github.com/apache/cloudstack/pull/1558#issuecomment-336137123 Packaging result: ?centos6 ?centos7 ?debian. JID-1157

[GitHub] resmo commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

2017-10-12 Thread git
resmo commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-336138819 not sure yet, we are investigating the root cause

[GitHub] syed commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

2017-10-12 Thread git
syed commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-336149555 darn it! I'll resolve it now This is an automated message from the Apache

[GitHub] nitin-maharana commented on issue #2291: Fix validation for parameter "vm.password.length"

2017-10-12 Thread git
nitin-maharana commented on issue #2291: Fix validation for parameter "vm.password.length" URL: https://github.com/apache/cloudstack/pull/2291#issuecomment-336158765 Thanks, @rafaelweingartner for the fix. Code LGTM. Can you please squash both the commits.

[GitHub] rafaelweingartner commented on issue #2291: Fix validation for parameter "vm.password.length"

2017-10-12 Thread git
rafaelweingartner commented on issue #2291: Fix validation for parameter "vm.password.length" URL: https://github.com/apache/cloudstack/pull/2291#issuecomment-336160965 @nitin-maharana sure! I will do that in a sec This

[GitHub] syed commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

2017-10-12 Thread git
syed commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-33613 @rhtyd Done! This is an automated message from the Apache Git Service. To

[GitHub] blueorangutan commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
blueorangutan commented on issue #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#issuecomment-336200645 Trillian test result (tid-1582) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken:

[GitHub] nvazquez opened a new pull request #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-12 Thread git
nvazquez opened a new pull request #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295 JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10109 ### Description This feature allow admins to

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-12 Thread git
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-336210130 @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-12 Thread git
blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-336210180 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-12 Thread git
blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-336217850 Packaging result: ?centos6 ?centos7 ?debian. JID-1158

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-12 Thread git
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-336218792 @blueorangutan test This is an automated

[GitHub] blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-12 Thread git
blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-336219050 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] borisstoyanov commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

2017-10-12 Thread git
borisstoyanov commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-336221412 @blueorangutan test This is an

[GitHub] blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

2017-10-12 Thread git
blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-336221714 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke

[GitHub] fmaximus commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
fmaximus commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144365634 ## File path: server/src/com/cloud/hypervisor/HypervisorGuruBase.java ## @@ -138,7 +143,24 @@

[GitHub] fmaximus commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-12 Thread git
fmaximus commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements URL: https://github.com/apache/cloudstack/pull/2293#discussion_r144369183 ## File path: utils/src/main/java/com/cloud/utils/UriUtils.java ## @@ -391,4 +391,57 @@ public

[GitHub] mike-tutkowski commented on issue #2294: Adding allocated IOPS to storage pool response

2017-10-12 Thread git
mike-tutkowski commented on issue #2294: Adding allocated IOPS to storage pool response URL: https://github.com/apache/cloudstack/pull/2294#issuecomment-336227035 I guess one comment I have is that technically we are supposed to have a JIRA ticket for each PR. Perhaps you could open an

[GitHub] syed commented on a change in pull request #2294: Adding allocated IOPS to storage pool response

2017-10-12 Thread git
syed commented on a change in pull request #2294: Adding allocated IOPS to storage pool response URL: https://github.com/apache/cloudstack/pull/2294#discussion_r144377728 ## File path: api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java ## @@ -288,6

[GitHub] syed commented on issue #2294: Adding allocated IOPS to storage pool response

2017-10-12 Thread git
syed commented on issue #2294: Adding allocated IOPS to storage pool response URL: https://github.com/apache/cloudstack/pull/2294#issuecomment-336230473 @mike-tutkowski I had opened the ticket in jira a while back. I've edited the PR to add the JIRA ticket

[GitHub] mike-tutkowski commented on issue #2294: [CLOUDSTACK-10039] Adding allocated IOPS to storage pool response

2017-10-12 Thread git
mike-tutkowski commented on issue #2294: [CLOUDSTACK-10039] Adding allocated IOPS to storage pool response URL: https://github.com/apache/cloudstack/pull/2294#issuecomment-336232016 Thanks, @syed! This is an automated

[GitHub] nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-12 Thread git
nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-336240972 @borisstoyanov @rhtyd @DaanHoogland Guys, one issue while porting this feature to 4.11 which was not

[GitHub] blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.

2017-10-12 Thread git
blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-336250591 Trillian test result (tid-1584) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations

2017-10-12 Thread git
blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-336258357 Trillian test result (tid-1581) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40655 seconds