[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r584925952 ## File path: processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java ## @@ -70,6 +71,11 @@ default MultiValueDimensionVectorSelector

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r582985342 ## File path: processing/src/main/java/org/apache/druid/segment/vector/VectorColumnSelectorFactory.java ## @@ -62,16 +66,29 @@ default int

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r582966905 ## File path: processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java ## @@ -70,6 +71,11 @@ default MultiValueDimensionVectorSelector

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r582956467 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -74,7 +74,7 @@ public ExprType

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558162034 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -74,7 +74,7 @@ public ExprType

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558143595 ## File path: processing/src/main/java/org/apache/druid/segment/vector/VectorColumnSelectorFactory.java ## @@ -57,6 +57,15 @@ default int

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558138626 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final Supplier

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558136293 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final Supplier

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558133615 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/vector/GroupByVectorColumnProcessorFactory.java ## @@ -64,7 +65,16 @@

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558133615 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/vector/GroupByVectorColumnProcessorFactory.java ## @@ -64,7 +65,16 @@

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558132323 ## File path: processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java ## @@ -27,6 +27,13 @@ { Predicate

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558131456 ## File path: processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java ## @@ -70,6 +71,11 @@ default MultiValueDimensionVectorSelector

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558127972 ## File path: processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java ## @@ -27,6 +27,13 @@ { Predicate

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558124796 ## File path: processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java ## @@ -305,17 +305,29 @@ private static ColumnCapabilities

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558115336 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -74,7 +74,7 @@ public ExprType

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553782719 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -74,7 +74,7 @@ public ExprType

[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

gianm commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553782719 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -74,7 +74,7 @@ public ExprType