[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r335410227
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1071 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r335410227
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1071 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r335209789
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1071 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r335153151 ## File path: core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java ## @@ -0,0 +1,1071 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.java.util.common.guava; + +import com.google.common.collect.Lists; +import com.google.common.collect.Ordering; +import org.apache.druid.java.util.common.RE; +import org.apache.druid.java.util.common.logger.Logger; +import org.apache.druid.utils.JvmUtils; + +import javax.annotation.Nullable; +import java.io.IOException; +import java.util.ArrayDeque; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; +import java.util.Objects; +import java.util.PriorityQueue; +import java.util.Queue; +import java.util.concurrent.ArrayBlockingQueue; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.ForkJoinPool; +import java.util.concurrent.RecursiveAction; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; +import java.util.concurrent.atomic.AtomicReference; +import java.util.function.BinaryOperator; + +/** + * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke, small-batch parallel merge combinining sequence Review comment: heh, thanks for reminding me to add some actually useful text here, I was also going to mention that functionally it is like a composite of `MergeSequence` and `CombiningSequence` :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334718832
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334715834
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1071 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334671393
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334669013
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1071 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334651727
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334650588
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334215299
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334214819
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334214819
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334214750
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334213579
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334213350
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334213291
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334213235
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334213235
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334213120
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334213134
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334213067
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334212863
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334212848
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334212125
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r334212125
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1077 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAtNanos;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAtNanos = System.nanoTime() +
TimeUnit.NANOSECONDS.convert(timeoutMillis, TimeUnit.MILLISECONDS);
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAtNanos,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAtNanos, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAtNanos,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r333918526
##
File path:
server/src/main/java/org/apache/druid/guice/DruidProcessingModule.java
##
@@ -135,6 +136,26 @@ public ExecutorService getProcessingExecutorService(
);
}
+ @Provides
+ @ManageLifecycle
+ public LifecycleForkJoinPoolProvider
getMergeProcessingPoolProvider(DruidProcessingConfig config)
+ {
+return new LifecycleForkJoinPoolProvider(
+config.getNumThreadsMergePool(),
+ForkJoinPool.defaultForkJoinWorkerThreadFactory, // todo: ?
Review comment:
Ah, no this was for whether or not I was going to set custom thread names as
@drcrallen did in #5913, see here
https://github.com/apache/incubator-druid/pull/5913/files#diff-fa77f3240f159148c9eac7faa94c516fR47.
I've decided against it for now and removed the todo since all of the logs are
debug level other than the unhandled exception handler I just added, but am
open to discussion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r333918605 ## File path: docs/configuration/index.md ## @@ -1435,6 +1435,12 @@ The broker uses processing configs for nested groupBy queries. And, if you use g |`druid.processing.columnCache.sizeBytes`|Maximum size in bytes for the dimension value lookup cache. Any value greater than `0` enables the cache. It is currently disabled by default. Enabling the lookup cache can significantly improve the performance of aggregators operating on dimension values, such as the JavaScript aggregator, or cardinality aggregator, but can slow things down if the cache hit rate is low (i.e. dimensions with few repeating values). Enabling it may also require additional garbage collection tuning to avoid long GC pauses.|`0` (disabled)| |`druid.processing.fifo`|If the processing queue should treat tasks of equal priority in a FIFO manner|`false`| |`druid.processing.tmpDir`|Path where temporary files created while processing a query should be stored. If specified, this configuration takes priority over the default `java.io.tmpdir` path.|path represented by `java.io.tmpdir`| +|`druid.processing.useParallelMergePool`|Enable automatic parallel merging for Brokers on a dedicated async ForkJoinPool. If `false`, instead merges will be done serially on the `HTTP` thread pool.|`true`| +|`druid.processing.numMergePoolThreads`|Size of ForkJoinPool|`druid.processing.numThreads * 1.5`| Review comment: added This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r94585
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1059 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import com.google.common.primitives.Ints;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAt;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAt = System.currentTimeMillis() + timeoutMillis;
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAt,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAt, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAt,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new BaseSequence<>(
+new BaseSequence.IteratorMaker>()
+{
+
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r94447
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1059 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import com.google.common.primitives.Ints;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAt;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAt = System.currentTimeMillis() + timeoutMillis;
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAt,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAt, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAt,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new BaseSequence<>(
+new BaseSequence.IteratorMaker>()
+{
+
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r94135
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1059 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import com.google.common.primitives.Ints;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAt;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAt = System.currentTimeMillis() + timeoutMillis;
+this.queryPriority = queryPriority;
+this.parallelism = parallelism;
+this.yieldAfter = yieldAfter;
+this.batchSize = batchSize;
+this.queueSize = 4 * (yieldAfter / batchSize);
+this.cancellationGizmo = new CancellationGizmo();
+ }
+
+ @Override
+ public Yielder toYielder(OutType initValue,
YieldingAccumulator accumulator)
+ {
+if (baseSequences.isEmpty()) {
+ return Sequences.empty().toYielder(initValue, accumulator);
+}
+
+final BlockingQueue> outputQueue = new
ArrayBlockingQueue<>(queueSize);
+MergeCombinePartitioningAction finalMergeAction = new
MergeCombinePartitioningAction<>(
+baseSequences,
+orderingFn,
+combineFn,
+outputQueue,
+queueSize,
+parallelism,
+yieldAfter,
+batchSize,
+hasTimeout,
+timeoutAt,
+cancellationGizmo
+);
+workerPool.execute(finalMergeAction);
+Sequence finalOutSequence = makeOutputSequenceForQueue(outputQueue,
hasTimeout, timeoutAt, cancellationGizmo);
+return finalOutSequence.toYielder(initValue, accumulator);
+ }
+
+ /**
+ * Create an output {@link Sequence} that wraps the output {@link
BlockingQueue} of a
+ * {@link MergeCombinePartitioningAction}
+ */
+ static Sequence makeOutputSequenceForQueue(
+ BlockingQueue> queue,
+ boolean hasTimeout,
+ long timeoutAt,
+ CancellationGizmo cancellationGizmo
+ )
+ {
+return new BaseSequence<>(
+new BaseSequence.IteratorMaker>()
+{
+
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r92318
##
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##
@@ -0,0 +1,1059 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common.guava;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Ordering;
+import com.google.common.primitives.Ints;
+import org.apache.druid.java.util.common.RE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.utils.JvmUtils;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.function.BinaryOperator;
+
+/**
+ * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke,
small-batch parallel merge combinining sequence
+ */
+public class ParallelMergeCombiningSequence extends YieldingSequenceBase
+{
+ private static final Logger LOG = new
Logger(ParallelMergeCombiningSequence.class);
+
+ private final ForkJoinPool workerPool;
+ private final List> baseSequences;
+ private final Ordering orderingFn;
+ private final BinaryOperator combineFn;
+ private final int queueSize;
+ private final boolean hasTimeout;
+ private final long timeoutAt;
+ private final int queryPriority; // not currently used :(
+ private final int yieldAfter;
+ private final int batchSize;
+ private final int parallelism;
+ private final CancellationGizmo cancellationGizmo;
+
+ public ParallelMergeCombiningSequence(
+ ForkJoinPool workerPool,
+ List> baseSequences,
+ Ordering orderingFn,
+ BinaryOperator combineFn,
+ boolean hasTimeout,
+ long timeoutMillis,
+ int queryPriority,
+ int parallelism,
+ int yieldAfter,
+ int batchSize
+ )
+ {
+this.workerPool = workerPool;
+this.baseSequences = baseSequences;
+this.orderingFn = orderingFn;
+this.combineFn = combineFn;
+this.hasTimeout = hasTimeout;
+this.timeoutAt = System.currentTimeMillis() + timeoutMillis;
Review comment:
Not :100:, but went ahead and made it consistently use `System.nanoTime`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r92198
##
File path: processing/src/main/java/org/apache/druid/query/QueryToolChest.java
##
@@ -113,9 +113,10 @@ public ObjectMapper decorateObjectMapper(final
ObjectMapper objectMapper, final
* function is used in the default {@link ResultMergeQueryRunner} provided by
* {@link QueryToolChest#mergeResults(QueryRunner)} and can be used in
additional future merge implementations
*/
+ @Nullable
Review comment:
Updated javadoc with new usage in this PR, describe implications of
returning `null`, also added precondition checks for `ResultMergeQueryRunner`
comparator and mergeFn factories.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r328452705 ## File path: processing/src/main/java/org/apache/druid/guice/LifecycleForkJoinPool.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.guice; + + +import org.apache.druid.java.util.common.lifecycle.LifecycleStop; +import org.apache.druid.java.util.common.logger.Logger; + +import java.util.concurrent.ForkJoinPool; +import java.util.concurrent.TimeUnit; + +public class LifecycleForkJoinPool extends ForkJoinPool Review comment: I'm actually a bit less certain that this class is the issue... if I pull it into another project I don't seem to have an issue compiling with a newer java... However, commenting out this class and using a plain `ForkJoinPool` does allow `druid-processing` to compile correctly with jdk11. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r328452705 ## File path: processing/src/main/java/org/apache/druid/guice/LifecycleForkJoinPool.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.guice; + + +import org.apache.druid.java.util.common.lifecycle.LifecycleStop; +import org.apache.druid.java.util.common.logger.Logger; + +import java.util.concurrent.ForkJoinPool; +import java.util.concurrent.TimeUnit; + +public class LifecycleForkJoinPool extends ForkJoinPool Review comment: ~I'm actually a bit less certain that this class is the issue... if I pull it into another project I don't seem to have an issue compiling with a newer java...~ Commenting out this class and using a plain `ForkJoinPool` does allow `druid-processing` to compile correctly with jdk11. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r328452705 ## File path: processing/src/main/java/org/apache/druid/guice/LifecycleForkJoinPool.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.guice; + + +import org.apache.druid.java.util.common.lifecycle.LifecycleStop; +import org.apache.druid.java.util.common.logger.Logger; + +import java.util.concurrent.ForkJoinPool; +import java.util.concurrent.TimeUnit; + +public class LifecycleForkJoinPool extends ForkJoinPool Review comment: I'm actually a bit less certain that this class is the issue... if I pull it into another project I don't seem to have an issue compiling with a newer java... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool
clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r327529254
##
File path:
processing/src/main/java/org/apache/druid/guice/LifecycleForkJoinPool.java
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.guice;
+
+
+import org.apache.druid.java.util.common.lifecycle.LifecycleStop;
+import org.apache.druid.java.util.common.logger.Logger;
+
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.TimeUnit;
+
+public class LifecycleForkJoinPool extends ForkJoinPool
Review comment:
This seems to be the cause of mysterious java 9+ compilation issues causing
CI failures (my favorite part is how the compiler error doesn't at all specify
what is causing the error). `ForkJoinPool` has the `@Contended` annotation,
which from javadocs looks like it leaks to subclasses I guess?
```
* The class level {@code @Contended} annotation is not inherited and has
* no effect on the fields declared in any sub-classes. The effects of all
* {@code @Contended} annotations, however, remain in force for all
* subclass instances, providing isolation of all the defined contention
* groups. Contention group tags are not inherited, and the same tag used
* in a superclass and subclass, represent distinct contention groups.
```
This might be fixed by something like:
```
--add-exports
java.base/jdk.internal.misc=ALL-UNNAMED
```
added to jdk9+ profile, but would also require removing all source/target
directives into a jdk8 profile I think, since:
```
error: option --add-exports not allowed with target 8
```
happens otherwise.
Not sure what is the best thing to do here. it could probably be worked
around by I guess having a lifecycle'd module that wraps a `ForkJoinPool` for
the provider instead of extending `ForkJoinPool`, since just using
`ForkJoinPool` doesn't seem to cause this error in jdk9+, but I'm not sure if
that is the better solution, or if we should try to add the compiler args.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
